id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
4f8b5c70967de5fd27f2092f1f8da47f4705bb67 | Analyze and fix the following issue in the Linux kernel code: [MIPS] Fix atomic.h build errors. | Problem Details:
For the definition of atomic64_t atomic.h was relying on <asm/types.h>
having been included previously. Before changeset
d89d8e0637a5e4e0a12e90c4bc934d0d4c335239 this was happening as a
side effect of including <linux/spinlock.h>.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org> | ```diff
diff --git a/include/asm-mips/atomic.h b/include/asm-mips/atomic.h
index 7978d8e11647..365767074c79 100644
--- a/include/asm-mips/atomic.h
+++ b/include/asm-mips/atomic.h
@@ -375,7 +375,7 @@ static __inline__ int atomic_sub_if_positive(int i, atomic_t * v)
#ifdef CONFIG_64BIT
-typedef struct { volatile __s... |
05e4396651ca1cac51d8da9ff4992741c9dc1e39 | Analyze and fix the following issue in the Linux kernel code: [MIPS] Use SYSVIPC_COMPAT to fix various problems on N32 | Problem Details:
N32 SysV IPC system calls should use 32-bit compatible code.
arch/mips/kernel/linux32.c have similar compatible code for O32, but
ipc/compat.c seems more complete. We can use it for both N32 and O32.
This patch should fix these problems (and other possible problems):
http://www.linux-mips.org/cgi-bi... | ```diff
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 27f83e642968..2308c8ef0218 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -1940,6 +1940,11 @@ config COMPAT
depends on MIPS32_COMPAT
default y
+config SYSVIPC_COMPAT
+ bool
+ depends on COMPAT && SYSVIPC
+ default y
+
config MIPS32_O32
... |
8e42a5a220a3369c70d88474e887a6de6a4ae209 | Analyze and fix the following issue in the Linux kernel code: [PATCH] pata_ali: small fixes | Problem Details:
Switch to pci_get_bus_and_slot because some x86 systems seem to be
handing us a device with dev->bus = NULL. Also don't apply the isa fixup
to revision C6 and later of the chip.
Really we need to work out wtf is handing us pdev->bus = NULL, but firstly
and more importantly we need the drivers working.... | ```diff
diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c
index d25563794c8d..c5d61d1911a5 100644
--- a/drivers/ata/pata_ali.c
+++ b/drivers/ata/pata_ali.c
@@ -34,7 +34,7 @@
#include <linux/dmi.h>
#define DRV_NAME "pata_ali"
-#define DRV_VERSION "0.7.1"
+#define DRV_VERSION "0.7.2"
/*
* Cable specia... |
a80958f4849316a18c06f75b9e850ccecbf20df8 | Analyze and fix the following issue in the Linux kernel code: [PATCH] fix fallout from header dependency trimming | Problem Details:
OK, that seems to be enough to deal with the mess.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/include/linux/kernelcapi.h b/include/linux/kernelcapi.h
index f8a0ff86dacc..aea34e74c496 100644
--- a/include/linux/kernelcapi.h
+++ b/include/linux/kernelcapi.h
@@ -48,6 +48,7 @@ typedef struct kcapi_carddef {
#include <linux/list.h>
#include <linux/skbuff.h>
#include <linux/workqueue.h>
+#incl... |
f75e3b1de6a72f6eb22f3ab120dd52b902357c03 | Analyze and fix the following issue in the Linux kernel code: [PATCH] m68knommu: fix missing bracket in scatterlist.h | Problem Details:
This patch adds missing bracket.
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Ungerer <gerg@uclinux.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/include/asm-m68knommu/scatterlist.h b/include/asm-m68knommu/scatterlist.h
index 12309b181d29..2085d6ff8782 100644
--- a/include/asm-m68knommu/scatterlist.h
+++ b/include/asm-m68knommu/scatterlist.h
@@ -10,7 +10,7 @@ struct scatterlist {
unsigned int length;
};
-#define sg_address(sg) (page_add... |
04a9f081b76f536bcf69db066153c2a4231d5783 | Analyze and fix the following issue in the Linux kernel code: [PATCH] m68knommu: fix dma-mapping.h | Problem Details:
Make the m68knommu DMA handling consistent with other architectures.
Compile problems pointed out by Adrian Bunk <bunk@stusta.de>
Signed-off-by: Greg Ungerer <gerg@uclinux.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/include/asm-m68knommu/dma-mapping.h b/include/asm-m68knommu/dma-mapping.h
index 5622b855a577..6aeab18e58bd 100644
--- a/include/asm-m68knommu/dma-mapping.h
+++ b/include/asm-m68knommu/dma-mapping.h
@@ -1,9 +1,10 @@
#ifndef _M68KNOMMU_DMA_MAPPING_H
#define _M68KNOMMU_DMA_MAPPING_H
-
#ifdef CONF... |
1b9552af943f54336333c9a6e02f5ed9f18e0bcc | Analyze and fix the following issue in the Linux kernel code: [PATCH] m68knommu: fix compile when CONFIG_BLK_DEV_INITRD=n | Problem Details:
This patch fixes the following compile error with
CONFIG_BLK_DEV_INITRD=n and -Werror-implicit-function-declaration:
...
CC arch/m68knommu/kernel/setup.o
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/arch/m68knommu/kernel/setup.c: In function 'setup_arch':
/home/bunk/linux/kernel-2.6... | ```diff
diff --git a/arch/m68knommu/kernel/setup.c b/arch/m68knommu/kernel/setup.c
index 7b21959eaeae..9cf2e4d1fc77 100644
--- a/arch/m68knommu/kernel/setup.c
+++ b/arch/m68knommu/kernel/setup.c
@@ -36,10 +36,7 @@
#include <asm/setup.h>
#include <asm/irq.h>
#include <asm/machdep.h>
-
-#ifdef CONFIG_BLK_DEV_INITRD
#... |
74f8f557fd0c6f32e17e78c9ef508ca66ef37d3a | Analyze and fix the following issue in the Linux kernel code: [S390] Don't use small stacks when lockdep is used. | Problem Details:
The lock dependency validator adds a bunch of extra stack frames to
the stack, which can cause stack overflows. Especially seen on 31 bit
where the small stack is only 4k.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com> | ```diff
diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index 5b04c4095c8d..583d9ff0a571 100644
--- a/arch/s390/Kconfig
+++ b/arch/s390/Kconfig
@@ -178,7 +178,7 @@ config PACK_STACK
config SMALL_STACK
bool "Use 4kb/8kb for kernel stack instead of 8kb/16kb"
- depends on PACK_STACK
+ depends on PACK_STACK && !LOC... |
9163bb2e556f6c7879961df94540f0879db4717b | Analyze and fix the following issue in the Linux kernel code: [S390] non-unique constant/macro identifiers. | Problem Details:
Add some prefixes to constands defined in drivers/s390/net/qdio.h
and drivers/s390/lcs.h to make it possible to include the three
header files drivers/s390/net/qeth.h, drivers/s390/net/qdio.h and
drivers/net/s390/lcs.h in one C file. This is required for the
patch that generates the kerntypes.o file fo... | ```diff
diff --git a/drivers/s390/cio/qdio.c b/drivers/s390/cio/qdio.c
index 476aa1da5cbc..8d5fa1b4d11f 100644
--- a/drivers/s390/cio/qdio.c
+++ b/drivers/s390/cio/qdio.c
@@ -481,7 +481,7 @@ qdio_stop_polling(struct qdio_q *q)
unsigned char state = 0;
struct qdio_irq *irq = (struct qdio_irq *) q->irq_pt... |
8b62bc9642300471737bc3b77b2a4a2ead46dedb | Analyze and fix the following issue in the Linux kernel code: [S390] Memory detection fixes. | Problem Details:
VMALLOC_END on 31bit should be 0x8000000UL instead of 0x7fffffffL.
The page mask which is used to make sure memory_end is on 4MB/2MB
boundary is wrong and not needed. Therefore remove it.
Make sure a vmalloc area does also exist and work on (future)
machines with 4TB and more memory.
Signed-off-by: He... | ```diff
diff --git a/arch/s390/kernel/head31.S b/arch/s390/kernel/head31.S
index 9817c327aab1..4388b3309e0c 100644
--- a/arch/s390/kernel/head31.S
+++ b/arch/s390/kernel/head31.S
@@ -177,8 +177,6 @@ startup_continue:
st %r0,4(%r3) # store size of chunk
st %r6,8(%r3) # store type of chunk
la %r3,12(%r3)
- l %r4,... |
740b5706b9c4b3767f597b3ea76654c6f2a800b2 | Analyze and fix the following issue in the Linux kernel code: [S390] cpcmd <-> __cpcmd calling issues | Problem Details:
In case of reipl cpcmd gets called when all other cpus are not running
anymore. To prevent deadlocks change __cpcmd so that it doesn't take
any locks and call cpcmd or __cpcmd, whatever is correct in the current
context.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin S... | ```diff
diff --git a/arch/s390/kernel/cpcmd.c b/arch/s390/kernel/cpcmd.c
index 1eae74e72f95..a5972f1541fe 100644
--- a/arch/s390/kernel/cpcmd.c
+++ b/arch/s390/kernel/cpcmd.c
@@ -21,14 +21,15 @@ static DEFINE_SPINLOCK(cpcmd_lock);
static char cpcmd_buf[241];
/*
- * the caller of __cpcmd has to ensure that the respo... |
6b4044bdd158aa9ad07b3f68d1c7598036d3ee58 | Analyze and fix the following issue in the Linux kernel code: [S390] extmem unbalanced spin_lock. | Problem Details:
segment save will exit with a lock held if the passed segment doesn't
exist. Any subsequent call to segment_save will lead to a deadlock.
Fix this and give up the lock before returning.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com> | ```diff
diff --git a/arch/s390/mm/extmem.c b/arch/s390/mm/extmem.c
index 226275d5c4f6..077af5404948 100644
--- a/arch/s390/mm/extmem.c
+++ b/arch/s390/mm/extmem.c
@@ -563,8 +563,9 @@ segment_save(char *name)
seg = segment_by_name (name);
if (seg == NULL) {
- PRINT_ERR ("could not find segment %s in segment_save,... |
c2f5ccfbd5198cadd03d8c4bb0e28175b78cd910 | Analyze and fix the following issue in the Linux kernel code: [ARM] 3973/1: AT91: Serial driver compile fix | Problem Details:
1. The CPU identification has moved from <system.h> to <cpu.h>.
2. AT91RM9200_BASE_US0 is only defined if we are compiling in support
for the AT91RM9200. Therefore we need to replace the CONFIG_ARM ifdef
with CONFIG_ARCH_AT91RM9200
Signed-off-by: Andrew Victor <andrew@sanpeople.com>
Signed-off-by: R... | ```diff
diff --git a/drivers/serial/atmel_serial.c b/drivers/serial/atmel_serial.c
index f930df042f9b..9217ee6c7865 100644
--- a/drivers/serial/atmel_serial.c
+++ b/drivers/serial/atmel_serial.c
@@ -1,5 +1,5 @@
/*
- * linux/drivers/char/at91_serial.c
+ * linux/drivers/char/atmel_serial.c
*
* Driver for Atmel AT... |
c019d49b69237f195b1a31d90facf738a371841f | Analyze and fix the following issue in the Linux kernel code: [ARM] 3972/1: AT91: Update board.h | Problem Details:
Replace the 'is_b' variable with 'slot_b' in at91_mmc_data.
Also add the new 'chipselect' variable for CF/PCMCIA and 'bus_width_16'
variable for NAND.
This (and previous patches) will unfortunately break the current MMC,
USB Gadget and PCMCIA drivers. Updates and fixes for those drivers will
be submi... | ```diff
diff --git a/arch/arm/mach-at91rm9200/board-carmeva.c b/arch/arm/mach-at91rm9200/board-carmeva.c
index 5cd68e6001ef..654f0379550a 100644
--- a/arch/arm/mach-at91rm9200/board-carmeva.c
+++ b/arch/arm/mach-at91rm9200/board-carmeva.c
@@ -88,7 +88,7 @@ static struct at91_udc_data __initdata carmeva_udc_data = {
//... |
872455e2ca12843e3dd16ebde1ce02dccc4bf99f | Analyze and fix the following issue in the Linux kernel code: [POWERPC] Fix debug printks for 32-bit resources in the PCI code | Problem Details:
Cure the damage done by the former PCI debug printks fix for the case
of 64-bit resources (commit 685143ac1f7a579a3fac9c7f2ac8f82e95af6864)
which broke it for the plain vanilla 32-bit resources...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Paul Mackerras <paulus@samba.org> | ```diff
diff --git a/arch/powerpc/kernel/pci_32.c b/arch/powerpc/kernel/pci_32.c
index b08238f30502..2f54cd81dea5 100644
--- a/arch/powerpc/kernel/pci_32.c
+++ b/arch/powerpc/kernel/pci_32.c
@@ -100,7 +100,7 @@ pcibios_fixup_resources(struct pci_dev *dev)
continue;
if (res->end == 0xffffffff) {
DBG("PCI:%s R... |
0470466dbafd1db0815bb884d26a6be431e19f96 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] Fix cputable.h for combined build | Problem Details:
Remove CPU_FTR_16M_PAGE from the cupfeatures mask at runtime on iSeries.
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Paul Mackerras <paulus@samba.org> | ```diff
diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
index 1915661c2c81..c0d2a694fa30 100644
--- a/arch/powerpc/mm/hash_utils_64.c
+++ b/arch/powerpc/mm/hash_utils_64.c
@@ -277,7 +277,7 @@ static void __init htab_init_page_sizes(void)
* Not in the device-tree, let's fallback on know... |
4468f01dc7cfd1998845cd66a0cdb1f3ef9740f0 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] Fix OF pci flags parsing | Problem Details:
For PCI devices with only io ports, of_bus_pci_get_flags() will fall
through and still mark the resource as IORESOURCE_MEM.
Signed-off-by: Olof Johansson <olof@lixom.net>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org> | ```diff
diff --git a/arch/powerpc/kernel/prom_parse.c b/arch/powerpc/kernel/prom_parse.c
index 346fb7bf9a05..0dfbe1cd28eb 100644
--- a/arch/powerpc/kernel/prom_parse.c
+++ b/arch/powerpc/kernel/prom_parse.c
@@ -160,9 +160,11 @@ static unsigned int of_bus_pci_get_flags(const u32 *addr)
switch((w >> 24) & 0x03) {
cas... |
c705677e1c69012adea3bc51b54e9c7170d1cbee | Analyze and fix the following issue in the Linux kernel code: [POWERPC] iSeries: Eliminate "exceeds stub group size" warnings | Problem Details:
Commit 3ccfc65c5004e5fe5cfbffe43b8acc686680b53e missed the same fixes for
legacy iSeries specific code, so make some more symbols no longer global.
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Paul Mackerras <paulus@samba.org> | ```diff
diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S
index ec754c92ba94..1a3d4de197d2 100644
--- a/arch/powerpc/kernel/entry_64.S
+++ b/arch/powerpc/kernel/entry_64.S
@@ -97,7 +97,9 @@ BEGIN_FW_FTR_SECTION
cmpdi cr1,r0,0x5555 /* syscall 0x5555 */
andi. r10,r12,MSR_PR /* from kernel... |
a5715d6dfc85e002bfad68bb2858cf5a248e2060 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] pSeries/kexec: Fix for interrupt distribution | Problem Details:
This allows any secondary CPU thread also to become boot cpu for
POWER5. The patch is required to solve kdump boot issue when the
kdump kernel is booted with parameter "maxcpus=1". XICS init code
tries to match the current boot cpu id with "reg" property in each CPU
node in the device tree. But CPU ... | ```diff
diff --git a/arch/powerpc/platforms/pseries/xics.c b/arch/powerpc/platforms/pseries/xics.c
index d071abe78ab1..b5b2b1103de8 100644
--- a/arch/powerpc/platforms/pseries/xics.c
+++ b/arch/powerpc/platforms/pseries/xics.c
@@ -656,13 +656,38 @@ static void __init xics_setup_8259_cascade(void)
set_irq_chained_hand... |
11faa658c668030759d4aea6a273b7ac9a0b4746 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] fix building without PCI | Problem Details:
At least the ide driver calls pcibus_to_node, which is not
defined when CONFIG_PCI is disabled. This adds a nop function
for the !PCI case.
Signed-off-by: Arnd Bergmann <arnd.bergmann@de.ibm.com> | ```diff
diff --git a/include/asm-powerpc/topology.h b/include/asm-powerpc/topology.h
index 9fe7894ee035..50c014007de7 100644
--- a/include/asm-powerpc/topology.h
+++ b/include/asm-powerpc/topology.h
@@ -32,7 +32,14 @@ static inline int node_to_first_cpu(int node)
int of_node_to_nid(struct device_node *device);
stru... |
369cf4b940d0d92d33f39a2df11102f3e2df0e0a | Analyze and fix the following issue in the Linux kernel code: [POWERPC] fix missing #include in sys_ppc32.c | Problem Details:
sys_mmap is declared in asm/syscalls.h
Signed-off-by: Arnd Bergmann <arnd.bergmann@de.ibm.com> | ```diff
diff --git a/arch/powerpc/kernel/sys_ppc32.c b/arch/powerpc/kernel/sys_ppc32.c
index d15c33e95959..03a2a2f30d66 100644
--- a/arch/powerpc/kernel/sys_ppc32.c
+++ b/arch/powerpc/kernel/sys_ppc32.c
@@ -51,6 +51,7 @@
#include <asm/time.h>
#include <asm/mmu_context.h>
#include <asm/ppc-pci.h>
+#include <asm/sysca... |
e22ba7e38144c1cccac5024cfd6ec88bb64d3e1f | Analyze and fix the following issue in the Linux kernel code: [POWERPC] ps3: multiplatform build fixes | Problem Details:
A few code paths need to check whether or not they are running
on the PS3's LV1 hypervisor before making hcalls. This introduces
a new firmware feature bit for this, FW_FEATURE_PS3_LV1.
Now when both PS3 and IBM_CELL_BLADE are enabled, but not PSERIES,
FW_FEATURE_PS3_LV1 and FW_FEATURE_LPAR get enable... | ```diff
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index c0146a40c6f3..c04b7138e1a6 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -390,6 +390,7 @@ config PPC_PSERIES
select PPC_RTAS
select RTAS_ERROR_LOGGING
select PPC_UDBG_16550
+ select PPC_NATIVE
default y
config PPC_ISERIE... |
e055595d3e5f5233374211bc6893e5d16976df99 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] cell: fix building without spufs | Problem Details:
It may be desireable to build a kernel for cell without
spufs, e.g. as the initial kboot kernel. This requires
that the SPU specific parts of the core dump and the xmon
code depend on CONFIG_SPU_BASE instead of CONFIG_PPC_CELL.
Signed-off-by: Arnd Bergmann <arnd.bergmann@de.ibm.com> | ```diff
diff --git a/arch/powerpc/xmon/Makefile b/arch/powerpc/xmon/Makefile
index 69303575d3d6..51d97588e762 100644
--- a/arch/powerpc/xmon/Makefile
+++ b/arch/powerpc/xmon/Makefile
@@ -8,5 +8,5 @@ obj-y += xmon.o setjmp.o start.o nonstdio.o
ifdef CONFIG_XMON_DISASSEMBLY
obj-y += ppc-dis.o ppc-opc.o
-obj-$(CON... |
aa668d6aac63f5fc02aa63bf25ff36d12510e050 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] Fix compile issue for Efika platform | Problem Details:
This patch fixes a compile issue for the Efika platform recently
introduced by API changes.
Signed-off-by: Nicolas DET <nd@bplan-gmbh.de>
Signed-off-by: Paul Mackerras <paulus@samba.org> | ```diff
diff --git a/arch/powerpc/platforms/efika/Makefile b/arch/powerpc/platforms/efika/Makefile
index 17b2a781fbae..56d440440236 100644
--- a/arch/powerpc/platforms/efika/Makefile
+++ b/arch/powerpc/platforms/efika/Makefile
@@ -1 +1 @@
-obj-y += setup.o mpc52xx.o pci.o
+obj-y += setup.o pci.o
diff --git a/arch/power... |
a985239bdf017e00e985c3a31149d6ae128fdc5f | Analyze and fix the following issue in the Linux kernel code: [POWERPC] cell: spu management xmon routines | Problem Details:
This fixes the xmon support for the cell spu to be compatable with the split
spu platform code.
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Arnd Bergmann <arnd.bergmann@de.ibm.com> | ```diff
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index c999638cc2de..1cf90c8ac34a 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -2789,8 +2789,6 @@ static void dump_spu_fields(struct spu *spu)
DUMP_FIELD(spu, "0x%x", number);
DUMP_FIELD(spu, "%s", name);
- DUMP_FIE... |
437a0706837d09d8ab071c6790da07d9d6bb3d22 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] Fix sparse warning in xmon Cell code | Problem Details:
My patch to add spu helpers to xmon (a898497088f46252e6750405504064e2dce53117)
introduced a few sparse warnings, because I was dereferencing an __iomem
pointer.
I think the best way to handle it is to actually use the appropriate in_beXX
functions. Need to rejigger the DUMP macro a little to accomodat... | ```diff
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index d66c3a170327..6b9d720f7ff8 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -2748,13 +2748,13 @@ static void restart_spus(void)
}
#define DUMP_WIDTH 23
-#define DUMP_FIELD(obj, format, field) \
+#define DUMP_VA... |
18f2190d796198fbb5d4bc4c87511acf3ced7d47 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] cell: Add oprofile support | Problem Details:
Add PPU event-based and cycle-based profiling support to Oprofile for Cell.
Oprofile is expected to collect data on all CPUs simultaneously.
However, there is one set of performance counters per node. There are
two hardware threads or virtual CPUs on each node. Hence, OProfile must
multiplex in time... | ```diff
diff --git a/arch/powerpc/configs/cell_defconfig b/arch/powerpc/configs/cell_defconfig
index dbcd4e3329d0..3d6a2f10a7dd 100644
--- a/arch/powerpc/configs/cell_defconfig
+++ b/arch/powerpc/configs/cell_defconfig
@@ -1121,7 +1121,8 @@ CONFIG_PLIST=y
#
# Instrumentation Support
#
-# CONFIG_PROFILING is not set
... |
c6730ed4c280ff9e55766796523c94a7d111da09 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] spufs: Load isolation kernel from spu_run | Problem Details:
In order to fit with the "don't-run-spus-outside-of-spu_run" model, this
patch starts the isolated-mode loader in spu_run, rather than
spu_create. If spu_run is passed an isolated-mode context that isn't in
isolated mode state, it will run the loader.
This fixes potential races with the isolated SPE a... | ```diff
diff --git a/arch/powerpc/platforms/cell/spufs/file.c b/arch/powerpc/platforms/cell/spufs/file.c
index e6667530332b..50e0afc46ad2 100644
--- a/arch/powerpc/platforms/cell/spufs/file.c
+++ b/arch/powerpc/platforms/cell/spufs/file.c
@@ -1358,37 +1358,6 @@ static struct file_operations spufs_mfc_fops = {
.mmap ... |
3692dc66149dc17cd82ec785a06478322c0eddff | Analyze and fix the following issue in the Linux kernel code: [POWERPC] spufs: Fix return value of spufs_mfc_write | Problem Details:
This patch changes spufs_mfc_write() to return
correct size instead of 0.
Signed-off-by: Masato Noguchi <Masato.Noguchi@jp.sony.com>
Signed-off-by: Arnd Bergmann <arnd.bergmann@de.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org> | ```diff
diff --git a/arch/powerpc/platforms/cell/spufs/file.c b/arch/powerpc/platforms/cell/spufs/file.c
index 1c1af71d19cb..e6667530332b 100644
--- a/arch/powerpc/platforms/cell/spufs/file.c
+++ b/arch/powerpc/platforms/cell/spufs/file.c
@@ -1279,6 +1279,7 @@ static ssize_t spufs_mfc_write(struct file *file, const cha... |
5c3ecd659bd20cda214a402a3132c790cc886cd2 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] spufs: Avoid user-triggered oops in ptrace | Problem Details:
When one of the spufs files is mapped into a process address
space, regular users can use ptrace to attempt accessing
them with access_process_vm(). With the way that the
mappings currently work, this likely causes an oops.
Setting the vm_flags to VM_IO makes sure that ptrace can
not access them but r... | ```diff
diff --git a/arch/powerpc/platforms/cell/spufs/file.c b/arch/powerpc/platforms/cell/spufs/file.c
index c0cf9ee4d45f..55d7e0f4bb3b 100644
--- a/arch/powerpc/platforms/cell/spufs/file.c
+++ b/arch/powerpc/platforms/cell/spufs/file.c
@@ -132,7 +132,7 @@ spufs_mem_mmap(struct file *file, struct vm_area_struct *vma)... |
2ebb2477f9a61b436dd22b75189857df1a77e585 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] spufs: Fix missing stop-and-signal | Problem Details:
When there is pending signals, current spufs_run_spu() always returns
-ERESTARTSYS and it is called again automatically.
But, if spe already stopped by stop-and-signal or halt instruction,
returning -ERESTARTSYS makes stop-and-signal/halt lost and
spu run over the end-point.
For your convenience, I at... | ```diff
diff --git a/arch/powerpc/platforms/cell/spufs/run.c b/arch/powerpc/platforms/cell/spufs/run.c
index 88a41d83a79b..c88fd7f9ea74 100644
--- a/arch/powerpc/platforms/cell/spufs/run.c
+++ b/arch/powerpc/platforms/cell/spufs/run.c
@@ -79,13 +79,7 @@ static inline int spu_run_fini(struct spu_context *ctx, u32 * npc,... |
8dc86ab954d28513f75918d743c40cddbff7388a | Analyze and fix the following issue in the Linux kernel code: [POWERPC] Change ppc_rtas declaration to weak | Problem Details:
Change the definition of powerpc's cond_syscall() to use the standard gcc
weak attribute specifier which provides proper support for C linkage as
needed by spu_syscall_table[].
Fixes this powerpc build error with CONFIG_SPU_FS=y, CONFIG_PPC_RTAS=n:
arch/powerpc/platforms/built-in.o: undefined refere... | ```diff
diff --git a/include/asm-powerpc/unistd.h b/include/asm-powerpc/unistd.h
index 0e4ea37f6466..04b6c17cc59b 100644
--- a/include/asm-powerpc/unistd.h
+++ b/include/asm-powerpc/unistd.h
@@ -446,7 +446,6 @@ type name(type1 arg1, type2 arg2, type3 arg3, type4 arg4, type5 arg5, type6 arg6
#include <linux/types.h>
#... |
78dc4c20de0f2cb2aa6d4542f965f889be6da775 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] 8xx: Off-by-one fixes to SCC parameter RAM definitions | Problem Details:
The SCC parameter RAM areas are mapped wrong in MPC8xx device descriptions. All
memory areas overlap with the next one, so that I2C, SPI, SMC1 and SMC2 cannot
be enabled if the four SCCs are.
Signed-off-by: Kalle Pokki <kalle.pokki@iki.fi>
Acked-by: Kumar Gala <galak@kernel.crashing.org>
Signed-off-by... | ```diff
diff --git a/arch/ppc/syslib/mpc8xx_devices.c b/arch/ppc/syslib/mpc8xx_devices.c
index cf5ab47487a7..31fb56593d17 100644
--- a/arch/ppc/syslib/mpc8xx_devices.c
+++ b/arch/ppc/syslib/mpc8xx_devices.c
@@ -78,7 +78,7 @@ struct platform_device ppc_sys_platform_devices[] = {
{
.name = "pram",
.start ... |
adaa3a796282e2fa3bc48bc57bccd01ce891b8d2 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] setup_kcore(): Fix incorrect function name in panic() call. | Problem Details:
Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Signed-off-by: Paul Mackerras <paulus@samba.org> | ```diff
diff --git a/arch/powerpc/mm/init_64.c b/arch/powerpc/mm/init_64.c
index 3ff374697e34..9a178549cbcf 100644
--- a/arch/powerpc/mm/init_64.c
+++ b/arch/powerpc/mm/init_64.c
@@ -130,7 +130,7 @@ static int __init setup_kcore(void)
/* GFP_ATOMIC to avoid might_sleep warnings during boot */
kcore_mem = kmalloc(... |
9a06c3b176976919e223844f8ed9f1acae20b433 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] Fix wraparound problem in smp-tbsync on 32-bit | Problem Details:
The patch below fixes an arithmetic wrap-around issue on 32bit machines
using smp-tbsync. Without this patch a timebase value over
0x000000007fffffff will hang the boot process while bringing up
secondary CPUs.
Signed-off-by: Adrian Cox <adrian@humboldt.co.uk>
Signed-off-by: Paul Mackerras <paulus@sam... | ```diff
diff --git a/arch/powerpc/kernel/smp-tbsync.c b/arch/powerpc/kernel/smp-tbsync.c
index de59c6c31a5b..e1970f83f14a 100644
--- a/arch/powerpc/kernel/smp-tbsync.c
+++ b/arch/powerpc/kernel/smp-tbsync.c
@@ -78,7 +78,7 @@ static int __devinit start_contest(int cmd, long offset, int num)
{
int i, score=0;
u64 tb... |
533462df56db99ceba4b4124b69469aa2a46a8de | Analyze and fix the following issue in the Linux kernel code: [POWERPC] CPM_UART: Fix inconsistency of function definition | Problem Details:
The below hunk was missed from the recent patch, and now, there are somewhat
inconsistent definitions:
in cpm_uart.h:
int __init cpm_uart_init_portdesc(void);
in cpm_uart_cpm1.c:
int __init cpm_uart_init_portdesc(void)
{
}
in cpm_uart_cpm2.c:
int cpm_uart_init_portdesc(void)
{
}
Signed-off-by: Kall... | ```diff
diff --git a/drivers/serial/cpm_uart/cpm_uart_cpm2.c b/drivers/serial/cpm_uart/cpm_uart_cpm2.c
index b691d3e14754..787a8f134677 100644
--- a/drivers/serial/cpm_uart/cpm_uart_cpm2.c
+++ b/drivers/serial/cpm_uart/cpm_uart_cpm2.c
@@ -282,7 +282,7 @@ void cpm_uart_freebuf(struct uart_cpm_port *pinfo)
}
/* Setup... |
1d30593e4c406c753e395676ba8b58600ccccbc1 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] Compilation fixes for ppc4xx PCI-less configs | Problem Details:
Fix compilation without PCI support for Bubinga, CPCI405 and EP405.
bios_fixup() for these boards uses functions available only with
CONFIG_PCI, so linker fails.
Signed-off-by: Wojtek Kaniewski <wojtekka@toxygen.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <a... | ```diff
diff --git a/arch/ppc/platforms/4xx/bubinga.c b/arch/ppc/platforms/4xx/bubinga.c
index 4009f4983ca6..75857b38e894 100644
--- a/arch/ppc/platforms/4xx/bubinga.c
+++ b/arch/ppc/platforms/4xx/bubinga.c
@@ -116,6 +116,7 @@ bubinga_early_serial_map(void)
void __init
bios_fixup(struct pci_controller *hose, struct p... |
56291e19e37cf3bb8fc701ebf3aa8ffbf59f73ef | Analyze and fix the following issue in the Linux kernel code: [POWERPC] iSeries: fix slb.c for combined build | Problem Details:
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Paul Mackerras <paulus@samba.org> | ```diff
diff --git a/arch/powerpc/mm/slb.c b/arch/powerpc/mm/slb.c
index d3733912adb4..224e960650a0 100644
--- a/arch/powerpc/mm/slb.c
+++ b/arch/powerpc/mm/slb.c
@@ -23,6 +23,7 @@
#include <asm/cputable.h>
#include <asm/cacheflush.h>
#include <asm/smp.h>
+#include <asm/firmware.h>
#include <linux/compiler.h>
#i... |
1d13581d00a041797c2c14adaccd306c91f87d46 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] iSeries: fix xmon.c for combined build | Problem Details:
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Paul Mackerras <paulus@samba.org> | ```diff
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index 0689c0845777..d66c3a170327 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -39,6 +39,7 @@
#include <asm/irq_regs.h>
#include <asm/spu.h>
#include <asm/spu_priv1.h>
+#include <asm/firmware.h>
#ifdef CONFIG_PPC64
... |
501b6d2938fd51e85279d950a6d23d515ae22c59 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] iSeries: fix time.c for combined build | Problem Details:
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Paul Mackerras <paulus@samba.org> | ```diff
diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c
index 46a24de36fec..f6f0c6b07c4c 100644
--- a/arch/powerpc/kernel/time.c
+++ b/arch/powerpc/kernel/time.c
@@ -631,7 +631,8 @@ void timer_interrupt(struct pt_regs * regs)
calculate_steal_time();
#ifdef CONFIG_PPC_ISERIES
- get_lppaca()->in... |
ad5cb17f730ae49e494cfd680a5c62f81c3ca484 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] iSeries: fix sysfs.c for combined build | Problem Details:
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Paul Mackerras <paulus@samba.org> | ```diff
diff --git a/arch/powerpc/kernel/sysfs.c b/arch/powerpc/kernel/sysfs.c
index cda21a27490a..22123a0d5416 100644
--- a/arch/powerpc/kernel/sysfs.c
+++ b/arch/powerpc/kernel/sysfs.c
@@ -200,10 +200,9 @@ static void register_cpu_online(unsigned int cpu)
struct cpu *c = &per_cpu(cpu_devices, cpu);
struct sys_dev... |
b06a318372ba95873abfe323076bd7e115d64b67 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] iSeries: fix irq.c for combined build | Problem Details:
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Paul Mackerras <paulus@samba.org> | ```diff
diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
index eb9fc621e057..e1936952017c 100644
--- a/arch/powerpc/kernel/irq.c
+++ b/arch/powerpc/kernel/irq.c
@@ -268,7 +268,8 @@ void do_IRQ(struct pt_regs *regs)
set_irq_regs(old_regs);
#ifdef CONFIG_PPC_ISERIES
- if (get_lppaca()->int_dword.fi... |
6ad4e70cafc43155d3a7e6e796e8b6b6967fc9e2 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] Fix IDE build with ARCH=ppc | Problem Details:
The recent IO accessor changes broke IDE on arch/ppc due to the IDE
stream IO macros using the new reads/writes{b,w,l} accessors that
are only defined for arch/powerpc. This adds them to arch/ppc.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@sa... | ```diff
diff --git a/include/asm-ppc/io.h b/include/asm-ppc/io.h
index bfb639f9e420..ccf1a9bb2e43 100644
--- a/include/asm-ppc/io.h
+++ b/include/asm-ppc/io.h
@@ -231,6 +231,14 @@ static inline void __raw_writel(__u32 b, volatile void __iomem *addr)
#define insl(port, buf, nl) _insl_ns((port)+___IO_BASE, (buf), (nl))
... |
757db1ed9b50d28cd4c1e7d9925c9ea7783b2f91 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] Fix __raw* accessors | Problem Details:
The new IO accessor code allows to stick a token in the top bit of MMIO
addresses which gets masked out during actual accesses. However, the
__raw_* accessors forgot to mask it out. This fixes it.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@sa... | ```diff
diff --git a/include/asm-powerpc/io.h b/include/asm-powerpc/io.h
index 53bff8bd39b9..75df3bce9ccb 100644
--- a/include/asm-powerpc/io.h
+++ b/include/asm-powerpc/io.h
@@ -185,53 +185,6 @@ extern void _memcpy_toio(volatile void __iomem *dest, const void *src,
* of the accessors.
*/
-
-/*
- * Non ordered an... |
014da7ff47b559e5f0ae3e044b73f0359c08153d | Analyze and fix the following issue in the Linux kernel code: [POWERPC] Cell "Spider" MMIO workarounds | Problem Details:
This patch implements a workaround for a Spider PCI host bridge bug
where it doesn't enforce some of the PCI ordering rules unless some
manual manipulation of a special register is done. In order to be
fully compliant with the PCI spec, I do this on every MMIO read
operation.
Signed-off-by: Benjamin H... | ```diff
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 3e89d9d34937..9547aacc3193 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -476,6 +476,7 @@ config PPC_CELL_NATIVE
select PPC_CELL
select PPC_DCR_MMIO
select PPC_OF_PLATFORM_PCI
+ select PPC_INDIRECT_IO
select MPIC
default ... |
4c9d2800be5dfabf26acdeb401cbabe9edc1dcf2 | Analyze and fix the following issue in the Linux kernel code: [POWERPC] Generic OF platform driver for PCI host bridges. | Problem Details:
When enabled in Kconfig, it will pick up any of_platform_device
matching it's match list (currently type "pci", "pcix", "pcie",
or "ht" and setup a PHB for it.
Platform must provide a ppc_md.pci_setup_phb() for it to work
(for doing the necessary initialisations specific to a given PHB
like setting up... | ```diff
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 65588a6bd2fe..3d26ba7ad76d 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -223,6 +223,11 @@ config PPC_DCR
depends on PPC_DCR_NATIVE || PPC_DCR_MMIO
default y
+config PPC_OF_PLATFORM_PCI
+ bool
+ depends on PPC64 # not support... |
f90bb153b1493719d18b4529a46ebfe43220ea6c | Analyze and fix the following issue in the Linux kernel code: [POWERPC] Make pci_read_irq_line the default | Problem Details:
This patch reworks the way IRQs are fixed up on PCI for arch powerpc.
It makes pci_read_irq_line() called by default in the PCI code for
devices that are probed, and add an optional per-device fixup in
ppc_md for platforms that really need to correct what they obtain
from pci_read_irq_line().
It also... | ```diff
diff --git a/arch/powerpc/kernel/pci_32.c b/arch/powerpc/kernel/pci_32.c
index 0d9ff72e2852..853ecef81780 100644
--- a/arch/powerpc/kernel/pci_32.c
+++ b/arch/powerpc/kernel/pci_32.c
@@ -12,6 +12,7 @@
#include <linux/errno.h>
#include <linux/bootmem.h>
#include <linux/irq.h>
+#include <linux/list.h>
#incl... |
ef9467f8f0803881d6b20ad6f0f770fc39bcc2c2 | Analyze and fix the following issue in the Linux kernel code: [SUNHME]: Fix for sunhme failures on x86 | Problem Details:
The following patch fixes the failure of sunhme drivers on x86 hosts
due to missing pci_enable_device() and pci_set_master() calls, lost
during code refactoring. It has been filed as bugzilla bug #7502 [0]
and Debian bug #397460 [1].
[0] http://bugzilla.kernel.org/show_bug.cgi?id=7502
[1] http://bug... | ```diff
diff --git a/drivers/net/sunhme.c b/drivers/net/sunhme.c
index ec432ea879fb..df40e34c7766 100644
--- a/drivers/net/sunhme.c
+++ b/drivers/net/sunhme.c
@@ -3012,6 +3012,11 @@ static int __devinit happy_meal_pci_probe(struct pci_dev *pdev,
#endif
err = -ENODEV;
+
+ if (pci_enable_device(pdev))
+ goto err_ou... |
b4ad86bf52469b26148c677cb59d8bc81f129cc2 | Analyze and fix the following issue in the Linux kernel code: [XFRM] xfrm_user: Better validation of user templates. | Problem Details:
Since we never checked the ->family value of templates
before, many applications simply leave it at zero.
Detect this and fix it up to be the pol->family value.
Also, do not clobber xp->family while reading in templates,
that is not necessary.
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
index 6f97665983d2..311205ffa775 100644
--- a/net/xfrm/xfrm_user.c
+++ b/net/xfrm/xfrm_user.c
@@ -858,7 +858,6 @@ static void copy_templates(struct xfrm_policy *xp, struct xfrm_user_tmpl *ut,
int i;
xp->xfrm_nr = nr;
- xp->family = ut->family;
for... |
cc9f022d97d08e4e36d38661857991fe91447d68 | Analyze and fix the following issue in the Linux kernel code: r8169: more alignment for the 0x8168 | Problem Details:
Two thirds of packets are lost because of misalignment. Users of
Asus laptop did apparently not notice it.
Reported on Gigabyte GA-945GM-S2.
Fix for http://bugzilla.kernel.org/show_bug.cgi?id=7517
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com> | ```diff
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 0b57050252eb..2379d83768d6 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -2018,7 +2018,7 @@ static int rtl8169_alloc_rx_skb(struct pci_dev *pdev, struct sk_buff **sk_buff,
if (!skb)
goto err_out;
- skb_reserve(skb, align);
+ skb... |
d03902b8864d7814c938f67befade5a3bba68708 | Analyze and fix the following issue in the Linux kernel code: r8169: tweak the PCI data parity error recovery | Problem Details:
The 8110SB based n2100 board signals a lot of what ought to be
PCI data parity errors durint operation of the 8169 as target.
Experiment proved that the driver can ignore the error and
process the packet as if nothing had happened.
Let's add an ad-hoc knob to enable users to fix their system while
avo... | ```diff
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index c8fa9b1b2290..7438049ca6d8 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -225,6 +225,7 @@ MODULE_DEVICE_TABLE(pci, rtl8169_pci_tbl);
static int rx_copybreak = 200;
static int use_dac;
+static int ignore_parity_err;
static struct {... |
90fb0e60dd9178dbca2e42c682c483cdb7ea9f2d | Analyze and fix the following issue in the Linux kernel code: [DCCP] tfrc: Fix small error in reverse lookup of p for given f(p) | Problem Details:
This fixes the following small error in tfrc_calc_x_reverse_lookup.
1) The table is generated by the following equations:
lookup[index][0] = g((index+1) * 1000000/TFRC_CALC_X_ARRSIZE);
lookup[index][1] = g((index+1) * TFRC_CALC_X_SPLIT/TFRC_CALC_X_ARRSIZE);
where g(q) is 1E6 * f(q/1E6)
2) The... | ```diff
diff --git a/net/dccp/ccids/lib/tfrc_equation.c b/net/dccp/ccids/lib/tfrc_equation.c
index 57665e979308..78bdf3489162 100644
--- a/net/dccp/ccids/lib/tfrc_equation.c
+++ b/net/dccp/ccids/lib/tfrc_equation.c
@@ -667,9 +667,9 @@ u32 tfrc_calc_x_reverse_lookup(u32 fvalue)
ctr++;
if (small)
- return TFRC_CA... |
26af3072b035daadf34a99d02510f0ff98f41f90 | Analyze and fix the following issue in the Linux kernel code: [DCCP] ccid3: Fix warning message about illegal ACK | Problem Details:
This avoids a (harmless) warning message being printed at the DCCP server
(the receiver of a DCCP half connection).
Incoming packets are both directed to
* ccid_hc_rx_packet_recv() for the server half
* ccid_hc_tx_packet_recv() for the client half
The message gets printed since on a server the cli... | ```diff
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
index bd353044c547..721efc7ed319 100644
--- a/net/dccp/ccids/ccid3.c
+++ b/net/dccp/ccids/ccid3.c
@@ -555,7 +555,8 @@ static void ccid3_hc_tx_packet_recv(struct sock *sk, struct sk_buff *skb)
hctx->ccid3hctx_idle = 1;
break;
case TFRC_SSTAT... |
5c3fbb6acf9d32772ec7fc01cedd9478d0e26f44 | Analyze and fix the following issue in the Linux kernel code: [DCCP] ccid3: Fix bug in calculation of send rate | Problem Details:
The main object of this patch is the following bug:
==> In ccid3_hc_tx_packet_recv, the parameters p and X_recv were updated
_after_ the send rate was calculated. This is clearly an error and is
resolved by re-ordering statements.
In addition,
* r_sample is converted from u32 to long to c... | ```diff
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
index 22a07248c240..bd353044c547 100644
--- a/net/dccp/ccids/ccid3.c
+++ b/net/dccp/ccids/ccid3.c
@@ -121,12 +121,15 @@ static inline void ccid3_update_send_time(struct ccid3_hc_tx_sock *hctx)
/*
* Update X by
* If (p > 0)
- * x_calc = c... |
76d127779e51fbf67ad6793214369aa1fea90278 | Analyze and fix the following issue in the Linux kernel code: [DCCP]: Fix BUG in retransmission delay calculation | Problem Details:
This bug resulted in ccid3_hc_tx_send_packet returning negative
delay values, which in turn triggered silently dequeueing packets in
dccp_write_xmit. As a result, only a few out of the submitted packets made
it at all onto the network. Occasionally, when dccp_wait_for_ccid was
involved, this also trig... | ```diff
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
index 99807783a22f..22a07248c240 100644
--- a/net/dccp/ccids/ccid3.c
+++ b/net/dccp/ccids/ccid3.c
@@ -339,7 +339,7 @@ static int ccid3_hc_tx_send_packet(struct sock *sk, struct sk_buff *skb)
* else
* // send the packet in (t_nom - t_now)... |
f56035110661417e15814fa08e1f4bf19cb26f93 | Analyze and fix the following issue in the Linux kernel code: [SCSI] lpfc 8.1.11 : Misc Fixes | Problem Details:
Misc Fixes:
- Prevent references to NULL node list element in reset routines.
- Add missing IOCB types to switch tables
- Reset the card on Port Error 5
- Fix infinite loop in LUN reset
Signed-off-by: James Smart <James.Smart@emulex.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com... | ```diff
diff --git a/drivers/scsi/lpfc/lpfc_hw.h b/drivers/scsi/lpfc/lpfc_hw.h
index 3ba1ee4ace9a..f79cb6136906 100644
--- a/drivers/scsi/lpfc/lpfc_hw.h
+++ b/drivers/scsi/lpfc/lpfc_hw.h
@@ -1294,6 +1294,10 @@ typedef struct { /* FireFly BIU registers */
#define CMD_FCP_IREAD_CX 0x1B
#define CMD_FCP_ICMND_CR ... |
146911500f2572fba31895aebacdc4f283208c37 | Analyze and fix the following issue in the Linux kernel code: [SCSI] lpfc 8.1.11 : Fix Memory leaks | Problem Details:
Fix Memory leaks associated with mbox cmds READ_LA, READ_SPARAM, REG_LOGIN
Signed-off-by: James Smart <James.Smart@emulex.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com> | ```diff
diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index a47e5ab1ec4d..a5f33a0dd4e7 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -243,6 +243,7 @@ lpfc_cmpl_els_flogi_fabric(struct lpfc_hba *phba, struct lpfc_nodelist *ndlp,
struct serv_parm *sp, IOCB_t... |
a4bc3379fbc368597024104727fdf14ced483c14 | Analyze and fix the following issue in the Linux kernel code: [SCSI] lpfc 8.1.11 : Fix lpfc_multi_ring_support | Problem Details:
It was not accounted for in the fast/slow rings.
Genericize the implementation and control it via sysfs
Signed-off-by: James Smart <James.Smart@emulex.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com> | ```diff
diff --git a/drivers/scsi/lpfc/lpfc.h b/drivers/scsi/lpfc/lpfc.h
index 3f7f5f8abd75..e94190e83fc3 100644
--- a/drivers/scsi/lpfc/lpfc.h
+++ b/drivers/scsi/lpfc/lpfc.h
@@ -296,6 +296,8 @@ struct lpfc_hba {
uint32_t cfg_cr_delay;
uint32_t cfg_cr_count;
uint32_t cfg_multi_ring_support;
+ uint32_t cfg_multi_r... |
2fb9bd8b9cbe9a8d70bf5f43a9ee6a4fa565ed5a | Analyze and fix the following issue in the Linux kernel code: [SCSI] lpfc 8.1.11 : Discovery Fixes | Problem Details:
Discovery Fixes:
- Prevent starting discovery of a node if discovery is in progress.
- Code improvement (reduction) for lpfc_findnode_did().
- Update discovery to send RFF to Fabric on link up
- Bypass unique WWN checks for fabric addresses
- Add ndlp to plogi list prior to issuing the plogi els c... | ```diff
diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
index 3add7c237859..a51a41b7f15d 100644
--- a/drivers/scsi/lpfc/lpfc_ct.c
+++ b/drivers/scsi/lpfc/lpfc_ct.c
@@ -558,6 +558,14 @@ lpfc_cmpl_ct_cmd_rsnn_nn(struct lpfc_hba * phba, struct lpfc_iocbq * cmdiocb,
return;
}
+static void
+lpfc_... |
c603d04ef6826a29f50cb151cb992f256d0cf19d | Analyze and fix the following issue in the Linux kernel code: [SCSI] 53c700: brown paper bag fix for auto request sense | Problem Details:
In the switch over, I forgot to set the command length, so it sends out
a request sense with whatever length the prior command had (and fails
badly if it wasn't 6).
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com> | ```diff
diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c
index 562432d017b0..335a25540c08 100644
--- a/drivers/scsi/53c700.c
+++ b/drivers/scsi/53c700.c
@@ -622,8 +622,10 @@ NCR_700_scsi_done(struct NCR_700_Host_Parameters *hostdata,
dma_unmap_single(hostdata->dev, slot->dma_handle, sizeof(SCp->sense_buff... |
46ddab7b1c7225269ad45d33fc39d0a385194360 | Analyze and fix the following issue in the Linux kernel code: [SCSI] qla2xxx: use NULL instead of 0 | Problem Details:
Use NULL instead of 0 for pointers (sparse warning):
drivers/scsi/qla2xxx/qla_attr.c:393:4: warning: Using plain integer as NULL pointer
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.c... | ```diff
diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
index 285c8e8ff1a0..7b18a6c7b7eb 100644
--- a/drivers/scsi/qla2xxx/qla_attr.c
+++ b/drivers/scsi/qla2xxx/qla_attr.c
@@ -390,7 +390,7 @@ static struct sysfs_entry {
{ "optrom_ctl", &sysfs_optrom_ctl_attr, },
{ "vpd", &sysfs_vpd_at... |
599b7202c5bf2c7345ea34007379ba241c94a491 | Analyze and fix the following issue in the Linux kernel code: [PATCH] sata_promise: PHYMODE4 fixup | Problem Details:
This patch adds code to fix up the PHYMODE4 "align timing"
register value on second-generation Promise SATA chips.
Failure to correct this value on non-x86 machines makes
drive detection prone to failure due to timeouts. (I've
observed about 50% detection failure rates on SPARC64.)
The HW boots with a... | ```diff
diff --git a/drivers/ata/sata_promise.c b/drivers/ata/sata_promise.c
index 8daf5d67dfe2..a2778cf016bc 100644
--- a/drivers/ata/sata_promise.c
+++ b/drivers/ata/sata_promise.c
@@ -280,6 +280,7 @@ static struct pci_driver pdc_ata_pci_driver = {
static int pdc_port_start(struct ata_port *ap)
{
struct device *d... |
3ac551a6a63dcbc707348772a27bd7090b081524 | Analyze and fix the following issue in the Linux kernel code: [libata] pata_cs5535: fix build | Problem Details:
Noticed by Tejun and others.
Signed-off-by: Jeff Garzik <jeff@garzik.org> | ```diff
diff --git a/drivers/ata/pata_cs5535.c b/drivers/ata/pata_cs5535.c
index 73b9b5453a3c..e3efec4ffc79 100644
--- a/drivers/ata/pata_cs5535.c
+++ b/drivers/ata/pata_cs5535.c
@@ -269,7 +269,7 @@ static struct pci_driver cs5535_pci_driver = {
.name = DRV_NAME,
.id_table = cs5535,
.probe = cs5535_init_one,
-... |
f84e7e41e1b88547218a3c3b1eb528005e9afdb4 | Analyze and fix the following issue in the Linux kernel code: [PATCH] libata: make sure sdev doesn't go away while rescanning | Problem Details:
ata_scsi_dev_rescan() doesn't synchronize against SCSI device detach
and the target sdev might go away in the middle. Fix it.
Signed-off-by: Tejun Heo <htejun@gmail.com> | ```diff
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 7ff1adfc729c..d250858d201c 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -3181,15 +3181,27 @@ static int ata_scsi_user_scan(struct Scsi_Host *shost, unsigned int channel,
void ata_scsi_dev_rescan(void *data)
{... |
6a36261e63770ab61422550b774fe949ccca5fa9 | Analyze and fix the following issue in the Linux kernel code: [PATCH] libata: fix READ CAPACITY simulation | Problem Details:
* READ CAPACITY (16) implementation fixed. Result was shifted by two
bytes. Carlos Pardo spotted this problem and submitted preliminary
patch. Capacity => 2TB is handled correctly now. (verifid w/ fake
capacity)
* Use dev->n_sectors instead of re-reading directly from ID data.
* Define and ... | ```diff
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 56d7e1ea9d72..7ff1adfc729c 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -1697,6 +1697,22 @@ void ata_scsi_rbuf_fill(struct ata_scsi_args *args,
args->done(cmd);
}
+/**
+ * ATA_SCSI_RBUF_SET - helper to set... |
c972b60bf167a3d2c3da23df2af1eac93229e7cc | Analyze and fix the following issue in the Linux kernel code: [PATCH] libata: add missing sht->slave_destroy | Problem Details:
Add missing sht->slave_destroy. Most drivers received this fix in
didn't. Fix those four drives.
Signed-off-by: Tejun Heo <htejun@gmail.com> | ```diff
diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c
index d2268bfe6f55..14c6a2daf52e 100644
--- a/drivers/ata/pata_ixp4xx_cf.c
+++ b/drivers/ata/pata_ixp4xx_cf.c
@@ -117,6 +117,7 @@ static struct scsi_host_template ixp4xx_sht = {
.proc_name = DRV_NAME,
.dma_boundary = ATA_DMA_BOUNDARY... |
2b5f6dcce5bf94b9b119e9ed8d537098ec61c3d2 | Analyze and fix the following issue in the Linux kernel code: [XFRM]: Fix aevent structuring to be more complete. | Problem Details:
aevents can not uniquely identify an SA. We break the ABI with this
patch, but consensus is that since it is not yet utilized by any
(known) application then it is fine (better do it now than later).
Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/Documentation/networking/xfrm_sync.txt b/Documentation/networking/xfrm_sync.txt
index 8be626f7c0b8..d7aac9dedeb4 100644
--- a/Documentation/networking/xfrm_sync.txt
+++ b/Documentation/networking/xfrm_sync.txt
@@ -47,10 +47,13 @@ aevent_id structure looks like:
struct xfrm_aevent_id {
... |
02dba025b0bc881432cf325bfb124fae523087d5 | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: xtables: fixes warning on compilation of hashlimit | Problem Details:
To use ipv6_find_hdr(), IP6_NF_IPTABLES is necessary.
Signed-off-by: Yasuyuki Kozakai <yasuyuki.kozakai@toshiba.co.jp>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/netfilter/xt_hashlimit.c b/net/netfilter/xt_hashlimit.c
index 46de566d3721..501c564e247f 100644
--- a/net/netfilter/xt_hashlimit.c
+++ b/net/netfilter/xt_hashlimit.c
@@ -388,7 +388,7 @@ hashlimit_init_dst(struct xt_hashlimit_htable *hinfo, struct dsthash_dst *dst,
return 0;
nexthdr = skb... |
1863f0965e716cc61d3c23cf106d41aa070f706f | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: nf_conntrack: fix header inclusions for helpers | Problem Details:
Signed-off-by: Yasuyuki Kozakai <yasuyuki.kozakai@toshiba.co.jp>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/netfilter/nf_conntrack_amanda.c b/net/netfilter/nf_conntrack_amanda.c
index 5c495dc9d942..b8869eab7650 100644
--- a/net/netfilter/nf_conntrack_amanda.c
+++ b/net/netfilter/nf_conntrack_amanda.c
@@ -15,6 +15,7 @@
#include <linux/skbuff.h>
#include <linux/in.h>
#include <linux/udp.h>
+#include... |
55a733247d6d2883d9bb77825fafac3dfca13fc2 | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: nf_nat: add FTP NAT helper port | Problem Details:
Add FTP NAT helper.
Split out from Jozsef's big nf_nat patch with a few small fixes by myself.
Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/include/linux/netfilter/nf_conntrack_ftp.h b/include/linux/netfilter/nf_conntrack_ftp.h
index ad4a41c9ce93..81453ea7e4c2 100644
--- a/include/linux/netfilter/nf_conntrack_ftp.h
+++ b/include/linux/netfilter/nf_conntrack_ftp.h
@@ -3,16 +3,16 @@
/* FTP tracking. */
/* This enum is exposed to user... |
bff9a89bcac5b68ac0a1ea856b1726a35ae1eabb | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: nf_conntrack: endian annotations | Problem Details:
Resync with Al Viro's ip_conntrack annotations and fix a missed
spot in ip_nat_proto_icmp.c.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/include/net/netfilter/nf_conntrack_tuple.h b/include/net/netfilter/nf_conntrack_tuple.h
index 530ef1f75283..be9dc9a0eb77 100644
--- a/include/net/netfilter/nf_conntrack_tuple.h
+++ b/include/net/netfilter/nf_conntrack_tuple.h
@@ -26,8 +26,8 @@
network order! */
union nf_conntrack_man_l3proto {... |
f9aae95828d3478520f4bd73221bcb450ec1a5c0 | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: nf_conntrack: fix helper structure alignment | Problem Details:
Adding the alignment to the size doesn't make any sense, what it
should do is align the size of the conntrack structure to the
alignment requirements of the helper structure and return an
aligned pointer in nfct_help().
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <d... | ```diff
diff --git a/include/net/netfilter/nf_conntrack.h b/include/net/netfilter/nf_conntrack.h
index d0d0e6491448..b4beb8c799e5 100644
--- a/include/net/netfilter/nf_conntrack.h
+++ b/include/net/netfilter/nf_conntrack.h
@@ -273,6 +273,7 @@ static inline struct nf_conn_help *nfct_help(const struct nf_conn *ct)
if (... |
0c4ca1bd8638d04796553b6e678063c4fadb92cc | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: nf_conntrack: fix NF_CONNTRACK_PROC_COMPAT dependency | Problem Details:
NF_CONNTRACK_PROC_COMPAT depends on NF_CONNTRACK_IPV4, not NF_CONNTRACK.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/ipv4/netfilter/Kconfig b/net/ipv4/netfilter/Kconfig
index bc298a3f236f..06fec80a0089 100644
--- a/net/ipv4/netfilter/Kconfig
+++ b/net/ipv4/netfilter/Kconfig
@@ -21,7 +21,7 @@ config NF_CONNTRACK_IPV4
config NF_CONNTRACK_PROC_COMPAT
bool "proc/sysctl compatibility with old connection track... |
1e9b3d5339d2afd6348e8211f0db695b00261e17 | Analyze and fix the following issue in the Linux kernel code: [NET_SCHED]: policer: restore compatibility with old iproute binaries | Problem Details:
The tc actions increased the size of struct tc_police, which broke
compatibility with old iproute binaries since both the act_police
and the old NET_CLS_POLICE code check for an exact size match.
Since the new members are not even used, the simple fix is to also
accept the size of the old structure. D... | ```diff
diff --git a/net/sched/act_police.c b/net/sched/act_police.c
index fed47b658837..af68e1e83251 100644
--- a/net/sched/act_police.c
+++ b/net/sched/act_police.c
@@ -46,6 +46,18 @@ static struct tcf_hashinfo police_hash_info = {
.lock = &police_lock,
};
+/* old policer structure from before tc actions */
+str... |
bb2ef25c2c62444b8fdb0346a23658a419803df9 | Analyze and fix the following issue in the Linux kernel code: [EBTABLES]: Fix wraparounds in ebt_entries verification. | Problem Details:
We need to verify that
a) we are not too close to the end of buffer to dereference
b) next entry we'll be checking won't be _before_ our
While we are at it, don't subtract unrelated pointers...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
index 9f85666f29f7..0dcebf20d6ce 100644
--- a/net/bridge/netfilter/ebtables.c
+++ b/net/bridge/netfilter/ebtables.c
@@ -401,13 +401,17 @@ ebt_check_entry_size_and_hooks(struct ebt_entry *e,
struct ebt_entries **hook_entries, unsi... |
b6332e6cf9c9198c0f3b0fe37c2c57514dafe1b8 | Analyze and fix the following issue in the Linux kernel code: [TCP]: Fix warnings with TCP_MD5SIG disabled. | Problem Details:
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 7684297d80aa..a1222d6968c4 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -1233,11 +1233,11 @@ struct request_sock_ops tcp_request_sock_ops __read_mostly = {
.send_reset = tcp_v4_send_reset,
};
-static struct tcp_request_sock_ops t... |
08dd1a506bbc4528db60dfdfff61423a1608ed3f | Analyze and fix the following issue in the Linux kernel code: [TCP] MD5SIG: Kill CONFIG_TCP_MD5SIG_DEBUG. | Problem Details:
It just obfuscates the code and adds limited value. And as Adrian
Bunk noticed, it lacked Kconfig help text too, so just kill it.
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index 39e0cb763588..503e7059e312 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -630,9 +630,5 @@ config TCP_MD5SIG
If unsure, say N.
-config TCP_MD5SIG_DEBUG
- bool "TCP: MD5 Signature Option debugging"
- depends on TCP_MD5SIG
-
source "net/ipv4... |
e488eafcc50be296f0d1e1fd67c6b5d865183011 | Analyze and fix the following issue in the Linux kernel code: [NET_SCHED]: Fix endless loops (part 5): netem/tbf/hfsc ->requeue failures | Problem Details:
When peeking at the next packet in a child qdisc by calling dequeue/requeue,
the upper qdisc qlen counter may get out of sync in case the requeue fails.
The qdisc and the child qdisc both have their counter decremented, but since
no packet is given to the upper qdisc it won't decrement its counter itse... | ```diff
diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
index 2d437447e085..6eefa6995777 100644
--- a/net/sched/sch_hfsc.c
+++ b/net/sched/sch_hfsc.c
@@ -946,6 +946,7 @@ qdisc_peek_len(struct Qdisc *sch)
if (unlikely(sch->ops->requeue(skb, sch) != NET_XMIT_SUCCESS)) {
if (net_ratelimit())
printk("qdis... |
256d61b87b2c2ac6fc333c1654d1abea61979006 | Analyze and fix the following issue in the Linux kernel code: [NET_SCHED]: Fix endless loops (part 4): HTB | Problem Details:
Convert HTB to use qdisc_tree_decrease_len() and add a callback
for deactivating a class when its child queue becomes empty.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c
index 3b36e9d60c20..215e68c2b615 100644
--- a/net/sched/sch_htb.c
+++ b/net/sched/sch_htb.c
@@ -1230,11 +1230,7 @@ static int htb_graft(struct Qdisc *sch, unsigned long arg, struct Qdisc *new,
return -ENOBUFS;
sch_tree_lock(sch);
if ((*old = xchg(... |
f973b913e18ab5a4795738ddf8a8666ac306ee12 | Analyze and fix the following issue in the Linux kernel code: [NET_SCHED]: Fix endless loops (part 3): HFSC | Problem Details:
Convert HFSC to use qdisc_tree_decrease_len() and add a callback
for deactivating a class when its child queue becomes empty.
All queue purging goes through hfsc_purge_queue(), which is used in
three cases: grafting, class creation (when a leaf class is turned
into an intermediate class by attaching a... | ```diff
diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
index 1142d298ecf6..2d437447e085 100644
--- a/net/sched/sch_hfsc.c
+++ b/net/sched/sch_hfsc.c
@@ -957,11 +957,7 @@ hfsc_purge_queue(struct Qdisc *sch, struct hfsc_class *cl)
unsigned int len = cl->qdisc->q.qlen;
qdisc_reset(cl->qdisc);
- if (len > 0... |
5e50da01d0ce7ef0ba3ed6cfabd62f327da0aca6 | Analyze and fix the following issue in the Linux kernel code: [NET_SCHED]: Fix endless loops (part 2): "simple" qdiscs | Problem Details:
Convert the "simple" qdiscs to use qdisc_tree_decrease_qlen() where
necessary:
- all graft operations
- destruction of old child qdiscs in prio, red and tbf change operation
- purging of queue in sfq change operation
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <dav... | ```diff
diff --git a/net/sched/sch_cbq.c b/net/sched/sch_cbq.c
index 908b10d0d61f..ba82dfab6043 100644
--- a/net/sched/sch_cbq.c
+++ b/net/sched/sch_cbq.c
@@ -1687,7 +1687,7 @@ static int cbq_graft(struct Qdisc *sch, unsigned long arg, struct Qdisc *new,
sch_tree_lock(sch);
*old = cl->q;
cl->q = new;
- sch->q... |
43effa1e57fc4635e0301b27d78f9d83afe78974 | Analyze and fix the following issue in the Linux kernel code: [NET_SCHED]: Fix endless loops caused by inaccurate qlen counters (part 1) | Problem Details:
There are multiple problems related to qlen adjustment that can lead
to an upper qdisc getting out of sync with the real number of packets
queued, leading to endless dequeueing attempts by the upper layer code.
All qdiscs must maintain an accurate q.qlen counter. There are basically
two groups of oper... | ```diff
diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
index b37572db12ab..82086392735a 100644
--- a/include/net/sch_generic.h
+++ b/include/net/sch_generic.h
@@ -60,6 +60,7 @@ struct Qdisc_class_ops
int (*graft)(struct Qdisc *, unsigned long cl,
struct Qdisc *, struct Qdisc **);
struct ... |
76592584be7828cd314bc8d5dc7773ff1692fb99 | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: Fix PROC_FS=n warnings | Problem Details:
Fix some unused function/variable warnings.
Signed-off-by: Patrick McHardy <kaber@trash.net> | ```diff
diff --git a/net/ipv4/netfilter/ipt_CLUSTERIP.c b/net/ipv4/netfilter/ipt_CLUSTERIP.c
index 5d43a63e5656..098365062234 100644
--- a/net/ipv4/netfilter/ipt_CLUSTERIP.c
+++ b/net/ipv4/netfilter/ipt_CLUSTERIP.c
@@ -167,7 +167,6 @@ clusterip_config_init(struct ipt_clusterip_tgt_info *i, __be32 ip,
struct net_dev... |
d7a5c32442ed3d528b9ddfd3d5b837bad0ffa9da | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: nfnetlink_log: remove useless prefix length limitation | Problem Details:
There is no reason for limiting netlink attributes in size.
Signed-off-by: Patrick McHardy <kaber@trash.net> | ```diff
diff --git a/include/linux/netfilter/nfnetlink_log.h b/include/linux/netfilter/nfnetlink_log.h
index 55a2a2b814ed..5966afa026e9 100644
--- a/include/linux/netfilter/nfnetlink_log.h
+++ b/include/linux/netfilter/nfnetlink_log.h
@@ -32,8 +32,6 @@ struct nfulnl_msg_packet_timestamp {
aligned_be64 usec;
};
-#d... |
7b621c1ea64a54f77b8a841b16dc4c9fee3ecf48 | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: ctnetlink: rework conntrack fields dumping logic on events | Problem Details:
| NEW | UPDATE | DESTROY |
----------------------------------------|
tuples | Y | Y | Y |
status | Y | Y | N |
timeout | Y | Y | N |
protoinfo | S | S | N |
helper | S | S |... | ```diff
diff --git a/net/ipv4/netfilter/ip_conntrack_netlink.c b/net/ipv4/netfilter/ip_conntrack_netlink.c
index d5d2efddba57..5fcf91d617cd 100644
--- a/net/ipv4/netfilter/ip_conntrack_netlink.c
+++ b/net/ipv4/netfilter/ip_conntrack_netlink.c
@@ -320,8 +320,6 @@ static int ctnetlink_conntrack_event(struct notifier_bloc... |
d73468533451fd896324058d9ba649c11ba3e3ee | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: nf_conntrack_ftp: fix missing helper mask initilization | Problem Details:
Signed-off-by: Patrick McHardy <kaber@trash.net> | ```diff
diff --git a/net/netfilter/nf_conntrack_ftp.c b/net/netfilter/nf_conntrack_ftp.c
index 10836fc22a44..05cb78ca90ae 100644
--- a/net/netfilter/nf_conntrack_ftp.c
+++ b/net/netfilter/nf_conntrack_ftp.c
@@ -586,6 +586,7 @@ static int __init nf_conntrack_ftp_init(void)
for (j = 0; j < 2; j++) {
ftp[i][j].tupl... |
3a137d2065571864be0301b9ebd72ddb01060997 | Analyze and fix the following issue in the Linux kernel code: [TCP]: Renove the __ prefix on the struct tcp_sock members | Problem Details:
As this struct is not userland visible at all.
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com> | ```diff
diff --git a/include/linux/tcp.h b/include/linux/tcp.h
index b42ff0efc2df..3cc70d1a3504 100644
--- a/include/linux/tcp.h
+++ b/include/linux/tcp.h
@@ -185,17 +185,17 @@ struct tcp_sack_block_wire {
};
struct tcp_sack_block {
- __u32 start_seq;
- __u32 end_seq;
+ u32 start_seq;
+ u32 end_seq;
};
struct t... |
91cf5a17257e1d2ef936fbf0223c3436ca583af9 | Analyze and fix the following issue in the Linux kernel code: [DCCP] ccid3: Fix calculation of t_ipi time of scheduled transmission | Problem Details:
Problem: | ```diff
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
index df88c54b2ec5..fb1a5e89c023 100644
--- a/net/dccp/ccids/ccid3.c
+++ b/net/dccp/ccids/ccid3.c
@@ -304,11 +304,19 @@ static int ccid3_hc_tx_send_packet(struct sock *sk,
break;
case TFRC_SSTATE_NO_FBACK:
case TFRC_SSTATE_FBACK:
- delay = (ti... |
90feeb951f61a80d3a8f8e5ced25b9ec78867eaf | Analyze and fix the following issue in the Linux kernel code: [DCCP] ccid3: Fix bug in calculation of first t_nom and first t_ipi | Problem Details:
Problem: | ```diff
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
index fb21f2d9ffc6..d7b688e9f983 100644
--- a/net/dccp/ccids/ccid3.c
+++ b/net/dccp/ccids/ccid3.c
@@ -298,13 +298,14 @@ static int ccid3_hc_tx_send_packet(struct sock *sk,
hctx->ccid3hctx_last_win_count = 0;
hctx->ccid3hctx_t_last_win_count = n... |
4a89c2562cb81c24c515b9de041aced4d21cb6d1 | Analyze and fix the following issue in the Linux kernel code: [DECNET] address: Convert to new netlink interface | Problem Details:
Extends the netlink interface to support the __le16 type and
converts address addition, deletion and, dumping to use the
new netlink interface.
Fixes multiple occasions of possible illegal memory references
due to not validated netlink attributes.
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off... | ```diff
diff --git a/include/net/netlink.h b/include/net/netlink.h
index 30021339157c..fd75fd65d59e 100644
--- a/include/net/netlink.h
+++ b/include/net/netlink.h
@@ -829,6 +829,9 @@ static inline int nla_put_msecs(struct sk_buff *skb, int attrtype,
#define NLA_PUT_U16(skb, attrtype, value) \
NLA_PUT_TYPE(skb, u16, ... |
567131a722ca064c917c0b06e4bcf07d47602103 | Analyze and fix the following issue in the Linux kernel code: [IPV6]: Fix SIOCCHGTUNNEL bug in IPv6 tunnels | Problem Details:
A logic bug in tunnel lookup could result in duplicate tunnels when
changing an existing device.
Signed-off-by: Ville Nuorvala <vnuorval@tcs.hut.fi>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c
index 25bc5ed49104..fdf1a2fa3a3d 100644
--- a/net/ipv6/ip6_tunnel.c
+++ b/net/ipv6/ip6_tunnel.c
@@ -215,11 +215,10 @@ ip6ip6_tnl_unlink(struct ip6_tnl *t)
* Create tunnel matching given parameters.
*
* Return:
- * 0 on success
+ * created ... |
8e5200f54062b8af0ed1d186ea0f113854786d89 | Analyze and fix the following issue in the Linux kernel code: [NET]: Fix assorted misannotations (from md5 and udplite merges). | Problem Details:
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/include/net/tcp.h b/include/net/tcp.h
index aa7989c53791..c99774f15eba 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -1154,7 +1154,7 @@ extern int tcp_v4_md5_do_add(struct sock *sk,
u8 newkeylen);
extern int tcp_v4_md5_do_del(struct sock *sk,
- u32 addr);
+ ... |
30330ee00ce077de9d459c17125573ff618bd7a9 | Analyze and fix the following issue in the Linux kernel code: [SCTP] bug: endianness problem in sctp_getsockopt_sctp_status() | Problem Details:
Again, invalid sockaddr passed to userland - host-endiand sin_port.
Potential leak, again, but less dramatic than in previous case.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index f4d13ab79f49..b6e038a387c2 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -3217,8 +3217,8 @@ static int sctp_getsockopt_sctp_status(struct sock *sk, int len,
status.sstat_outstrms = asoc->c.sinit_num_ostreams;
status.sstat_fragmentation_poi... |
0906e20fa03afdb14faf7fd166bfe4ed67c8db55 | Analyze and fix the following issue in the Linux kernel code: [SCTP] bug: sctp_assoc_control_transport() breakage | Problem Details:
a) struct sockaddr_storage * passed to sctp_ulpevent_make_peer_addr_change()
actually points at union sctp_addr field in a structure. Then that sucker
gets copied to userland, with whatever junk we might have there.
b) it's actually having host-endian sin_port.
Signed-off-by: Al Viro <viro@zeniv.lin... | ```diff
diff --git a/net/sctp/associola.c b/net/sctp/associola.c
index 7639044b0074..746b0b0f5ace 100644
--- a/net/sctp/associola.c
+++ b/net/sctp/associola.c
@@ -709,6 +709,7 @@ void sctp_assoc_control_transport(struct sctp_association *asoc,
struct sctp_transport *first;
struct sctp_transport *second;
struct sc... |
d5c747f6efc03495635f129c8eb1dad0200ab183 | Analyze and fix the following issue in the Linux kernel code: [SCTP] bug: sctp_find_unmatch_addr() compares net-endian to host-endian | Problem Details:
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/sctp/bind_addr.c b/net/sctp/bind_addr.c
index 2b9c12a170e5..23b5b664a8a0 100644
--- a/net/sctp/bind_addr.c
+++ b/net/sctp/bind_addr.c
@@ -332,12 +332,14 @@ union sctp_addr *sctp_find_unmatch_addr(struct sctp_bind_addr *bp,
addr_buf = (union sctp_addr *)addrs;
for (i = 0; i < addrcnt; ... |
39940a48c42441da5e7428483ac515e822d52b1d | Analyze and fix the following issue in the Linux kernel code: [SCTP] bug: sctp_assoc_lookup_laddr() is broken with ipv6. | Problem Details:
It expects (and gets) laddr with net-endian sin_port. And then it calls
sctp_bind_addr_match(), which *does* care about port numbers in case of
ipv6 and expects them to be host-endian.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/sctp/associola.c b/net/sctp/associola.c
index a5d7abba89e4..7639044b0074 100644
--- a/net/sctp/associola.c
+++ b/net/sctp/associola.c
@@ -1335,10 +1335,12 @@ int sctp_assoc_lookup_laddr(struct sctp_association *asoc,
const union sctp_addr *laddr)
{
int found;
+ union sctp_addr tmp;
... |
04afd8b282d702bc122051751466000e9513ef96 | Analyze and fix the following issue in the Linux kernel code: [SCTP]: Beginning of sin_port fixes. | Problem Details:
That's going to be a long series. Introduced temporary helpers
doing copy-and-convert for sctp_addr; they are used to kill
flip-in-place in global data structures and will be used
to gradually push host-endian uses of sctp_addr out of existence.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed... | ```diff
diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
index ca77bc5b7ff5..2aa61ac9a9f3 100644
--- a/include/net/sctp/structs.h
+++ b/include/net/sctp/structs.h
@@ -74,6 +74,28 @@ union sctp_addr {
struct sockaddr sa;
};
+static inline void flip_to_n(union sctp_addr *to, const union sctp_addr... |
1459bb36b12ac52bde68d70e2ba7a6f1f2e8be17 | Analyze and fix the following issue in the Linux kernel code: [XFRM]: Make copy_to_user_policy_type take a type | Problem Details:
Make copy_to_user_policy_type take a type instead a policy and
fix its users to pass the type
Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
index 2ee14f8a1908..6ddb49367c13 100644
--- a/net/xfrm/xfrm_user.c
+++ b/net/xfrm/xfrm_user.c
@@ -1083,12 +1083,12 @@ static inline int copy_to_user_sec_ctx(struct xfrm_policy *xp, struct sk_buff *s
}
#ifdef CONFIG_XFRM_SUB_POLICY
-static int copy_to_... |
746859625d879688adb99f1e5e8108fea876d369 | Analyze and fix the following issue in the Linux kernel code: [BRIDGE] netlink: Convert bridge netlink code to new netlink interface | Problem Details:
Removes dependency on buggy rta_buf, fixes a memory corruption bug due to
a unvalidated netlink attribute, and simplifies the code.
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index 15d6efbe7519..a9139682c49b 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -36,51 +36,43 @@ static int br_fill_ifinfo(struct sk_buff *skb, const struct net_bridge_port *por
{
const struct net_bridge *br = port->br;
c... |
82e3ab9dbeebd5c8d5402ad1607d22086271a56d | Analyze and fix the following issue in the Linux kernel code: [DCCP]: Adds the tx buffer sysctls | Problem Details:
This one got lost on the way from Ian to Gerrit to me, fix it.
Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com> | ```diff
diff --git a/Documentation/networking/dccp.txt b/Documentation/networking/dccp.txt
index 1910d097a0ad..dda15886bcb5 100644
--- a/Documentation/networking/dccp.txt
+++ b/Documentation/networking/dccp.txt
@@ -100,6 +100,10 @@ rx_ccid = 2
seq_window = 100
The initial sequence window (sec. 7.5.2).
+tx_qlen = 5... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.