id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
66393392533048b7e45a202f349974d16c4c9ea3 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix a lockdep splat | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/super-io.c b/fs/bcachefs/super-io.c
index ff9728b62b6e..0b3a761fe93e 100644
--- a/fs/bcachefs/super-io.c
+++ b/fs/bcachefs/super-io.c
@@ -143,7 +143,7 @@ int bch2_sb_realloc(struct bch_sb_handle *sb, unsigned u64s)
sb->bio = bio;
}
- new_sb = (void *) __get_free_pages(GFP_KERNEL|... |
24547d097a520312cf9d727d3af8da1b0c985f98 | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix bch2_sb_field_resize() | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/super-io.c b/fs/bcachefs/super-io.c
index dafdc45b442c..2ad1266e167d 100644
--- a/fs/bcachefs/super-io.c
+++ b/fs/bcachefs/super-io.c
@@ -188,6 +188,7 @@ struct bch_sb_field *bch2_sb_field_resize(struct bch_sb_handle *sb,
}
}
+ f = bch2_sb_field_get(sb->sb, type);
f = __bch2_sb... |
94cd106f8db3e454fa900acc1ffcbc5dcc0eddd8 | Analyze and fix the following issue in the Linux kernel code: bcachefs: delete a debug printk | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/recovery.c b/fs/bcachefs/recovery.c
index 2eaff9a6fee5..2ff86262d41c 100644
--- a/fs/bcachefs/recovery.c
+++ b/fs/bcachefs/recovery.c
@@ -215,10 +215,11 @@ int bch2_fs_recovery(struct bch_fs *c)
if (ret)
goto err;
+ bch_verbose(c, "starting stripes_read");
ret = bch2_stripes_re... |
736affa8bb3eeff49014dff9fd728f7ba3ffa550 | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix for unmount hang | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/alloc_background.c b/fs/bcachefs/alloc_background.c
index 83b3445cc76f..c44e0417af87 100644
--- a/fs/bcachefs/alloc_background.c
+++ b/fs/bcachefs/alloc_background.c
@@ -1257,7 +1257,8 @@ void bch2_dev_allocator_add(struct bch_fs *c, struct bch_dev *ca)
void bch2_dev_allocator_quiesc... |
b935a8a67ab744d20002aefd7f8053381b38532f | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix a bug when shutting down before allocator started | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/alloc_background.c b/fs/bcachefs/alloc_background.c
index 686287d12d14..83b3445cc76f 100644
--- a/fs/bcachefs/alloc_background.c
+++ b/fs/bcachefs/alloc_background.c
@@ -1535,6 +1535,8 @@ int bch2_fs_allocator_start(struct bch_fs *c)
}
}
+ set_bit(BCH_FS_ALLOCATOR_RUNNING, &c->fl... |
6e1b07183a32583cbe4d781ea0e14e0b06bc44af | Analyze and fix the following issue in the Linux kernel code: bcachefs: improve alloc_debug | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/sysfs.c b/fs/bcachefs/sysfs.c
index 424636310bbf..a7b4f76d0e61 100644
--- a/fs/bcachefs/sysfs.c
+++ b/fs/bcachefs/sysfs.c
@@ -240,27 +240,29 @@ static ssize_t show_fs_alloc_debug(struct bch_fs *c, char *buf)
if (!fs_usage)
return -ENOMEM;
- pr_buf(&out, "capacity:\t\t%llu\n", c->... |
bdba6c29ffc9041257eeeb5916bc3ae6f8828a0d | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix inode counting | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/buckets.c b/fs/bcachefs/buckets.c
index a1c243f622a8..d40aa69532cc 100644
--- a/fs/bcachefs/buckets.c
+++ b/fs/bcachefs/buckets.c
@@ -823,7 +823,7 @@ static int __bch2_mark_key(struct bch_fs *c, struct bkey_s_c k,
ret = bch2_mark_stripe(c, k, inserting,
fs_usage, journal_... |
5e5d9bdbb89c51603653360ecfbfa90c0bceb108 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix fifo overflow in allocator startup | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/alloc_background.c b/fs/bcachefs/alloc_background.c
index 871a41b923da..b79d5b059621 100644
--- a/fs/bcachefs/alloc_background.c
+++ b/fs/bcachefs/alloc_background.c
@@ -1334,6 +1334,24 @@ static void allocator_start_issue_discards(struct bch_fs *c)
ca->mi.bucket_size, GFP_NO... |
dbaee468461bfa82e6453ca0e009e9661cc570da | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix error message in device remove path | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
index 198f78dbb6d9..55069f40d04b 100644
--- a/fs/bcachefs/super.c
+++ b/fs/bcachefs/super.c
@@ -1258,8 +1258,8 @@ int bch2_dev_remove(struct bch_fs *c, struct bch_dev *ca, int flags)
if (data) {
char data_has_str[100];
- bch2_string_opt_to_text(&PBU... |
b030f691da68835e46a50f221c36b59898c91bf6 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix some reserve calculations | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/alloc_foreground.c b/fs/bcachefs/alloc_foreground.c
index f37110497b51..f40fca9328f9 100644
--- a/fs/bcachefs/alloc_foreground.c
+++ b/fs/bcachefs/alloc_foreground.c
@@ -107,6 +107,7 @@ void __bch2_open_bucket_put(struct bch_fs *c, struct open_bucket *ob)
bch2_mark_alloc_bucket(c, ca,... |
0519b72dd24754c560b6ac47b0224aaf462978c8 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Add a workqueue for journal reclaim | Problem Details:
journal reclaim writes btree nodes, which can end up waiting for in
flight btree writes to complete, and btree write completions run out of
workqueues - so we can't run out of the same workqueue or we risk
deadlock
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/bcachefs.h b/fs/bcachefs/bcachefs.h
index 244b808688b3..64836a8c69d8 100644
--- a/fs/bcachefs/bcachefs.h
+++ b/fs/bcachefs/bcachefs.h
@@ -600,6 +600,7 @@ struct bch_fs {
struct workqueue_struct *wq;
/* copygc needs its own workqueue for index updates.. */
struct workqueue_struct *... |
b0cbf659a5349ec73c5745bdf1975d5915f89071 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix an allocator error path | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/alloc_foreground.c b/fs/bcachefs/alloc_foreground.c
index 9eae8c29e3c4..f37110497b51 100644
--- a/fs/bcachefs/alloc_foreground.c
+++ b/fs/bcachefs/alloc_foreground.c
@@ -838,15 +838,17 @@ struct write_point *bch2_alloc_sectors_start(struct bch_fs *c,
{
struct write_point *wp;
struc... |
000de45996c4b0f9a7b4f2830c11ed584f473257 | Analyze and fix the following issue in the Linux kernel code: bcachefs: fixes for getting stuck flushing journal pins | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/journal_reclaim.c b/fs/bcachefs/journal_reclaim.c
index 770a6e0c7d97..eaf77c77b2c4 100644
--- a/fs/bcachefs/journal_reclaim.c
+++ b/fs/bcachefs/journal_reclaim.c
@@ -65,6 +65,9 @@ static inline void __journal_pin_drop(struct journal *j,
if (atomic_dec_and_test(&pin_list->count) &&
... |
ed4840308c9bd3f70e395bd6e37a410a96dcd883 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix a dio bug | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/fs-io.c b/fs/bcachefs/fs-io.c
index ad06db069fcf..c9a136797aa7 100644
--- a/fs/bcachefs/fs-io.c
+++ b/fs/bcachefs/fs-io.c
@@ -57,7 +57,7 @@ struct bch_writepage_io {
struct dio_write {
struct closure cl;
struct kiocb *req;
- struct task_struct *task;
+ struct mm_struct *mm;
... |
e19e57f8a1e5ebe1fe78dc0dff5120b4752ee8b1 | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix new reinherit_attrs ioctl | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/fs-ioctl.c b/fs/bcachefs/fs-ioctl.c
index 4925a127a335..b00d25b18ed4 100644
--- a/fs/bcachefs/fs-ioctl.c
+++ b/fs/bcachefs/fs-ioctl.c
@@ -184,7 +184,7 @@ static int bch2_ioc_reinherit_attrs(struct bch_fs *c,
if (unlikely(ret < 0))
goto err1;
- qstr.hash_len = ret;
+ qstr.len = re... |
2fab25cdd70be6868936639dfb03eaa9fa0245c0 | Analyze and fix the following issue in the Linux kernel code: bcachefs: more project quota fixes | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/fs-ioctl.c b/fs/bcachefs/fs-ioctl.c
index 92939befe507..4925a127a335 100644
--- a/fs/bcachefs/fs-ioctl.c
+++ b/fs/bcachefs/fs-ioctl.c
@@ -104,19 +104,6 @@ static int bch2_ioc_fsgetxattr(struct bch_inode_info *inode,
return copy_to_user(arg, &fa, sizeof(fa));
}
-static int bch2_set_... |
69d46f903120d4aab0e0ad239191245d839224cc | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix an rcu usage bug | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/io.c b/fs/bcachefs/io.c
index 74c3a848e153..e1c7d572fbff 100644
--- a/fs/bcachefs/io.c
+++ b/fs/bcachefs/io.c
@@ -967,6 +967,7 @@ void bch2_write(struct closure *cl)
struct promote_op {
struct closure cl;
+ struct rcu_head rcu;
u64 start_time;
struct rhash_head hash;
@@ -... |
a36d3685bbc3a5193f0c284233386d56136363c7 | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix ja->cur_idx use while reading journal | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/journal_io.c b/fs/bcachefs/journal_io.c
index 4178dd9ceb8e..67ff2633ba16 100644
--- a/fs/bcachefs/journal_io.c
+++ b/fs/bcachefs/journal_io.c
@@ -584,7 +584,7 @@ static void bch2_journal_read_device(struct closure *cl)
while (ja->bucket_seq[ja->cur_idx] > min_seq &&
ja->bucke... |
d3bb629d04ec4ec49556fe3d974e0744a0dd0084 | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix device remove error path | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
index b2113c5426ca..4e811ffdec8e 100644
--- a/fs/bcachefs/super.c
+++ b/fs/bcachefs/super.c
@@ -1306,7 +1306,8 @@ int bch2_dev_remove(struct bch_fs *c, struct bch_dev *ca, int flags)
mutex_unlock(&c->state_lock);
return 0;
err:
- if (ca->mi.state == BC... |
19b505a93434500469d9e2726967f28685f777a3 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix duplicate ioctl nr | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/bcachefs_ioctl.h b/fs/bcachefs/bcachefs_ioctl.h
index 2dca4bb0362b..8c0599618404 100644
--- a/fs/bcachefs/bcachefs_ioctl.h
+++ b/fs/bcachefs/bcachefs_ioctl.h
@@ -71,7 +71,11 @@ struct bch_ioctl_incremental {
#define BCH_IOCTL_USAGE _IOWR(0xbc, 11, struct bch_ioctl_usage)
#define BCH_... |
7121643e4fe20cbf916bf7ff032873dfbc19ee8e | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix for building in userspace | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/bcachefs_format.h b/fs/bcachefs/bcachefs_format.h
index 162a0a307f1b..8ef17c7ddaf7 100644
--- a/fs/bcachefs/bcachefs_format.h
+++ b/fs/bcachefs/bcachefs_format.h
@@ -74,6 +74,7 @@
#include <asm/types.h>
#include <asm/byteorder.h>
+#include <linux/kernel.h>
#include <linux/uuid.h>
... |
f9ccc30824a6b9f44b975c8ce952938eff5920f3 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix bkey_method compilation on gcc 7.3.0 | Problem Details:
Signed-off-by: Tim Schlueter <schlueter.tim@linux.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/bkey_methods.c b/fs/bcachefs/bkey_methods.c
index f518062d896b..37c44f087a0b 100644
--- a/fs/bcachefs/bkey_methods.c
+++ b/fs/bcachefs/bkey_methods.c
@@ -25,13 +25,13 @@ static const char *deleted_key_invalid(const struct bch_fs *c,
return NULL;
}
-const struct bkey_ops bch2_bkey_o... |
56e0e7c79f492df2a5ad207a0ba16f13511b6416 | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix an incorrect bkey_debugcheck() call | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/btree_iter.c b/fs/bcachefs/btree_iter.c
index 4720061e9562..3eb51724f9e1 100644
--- a/fs/bcachefs/btree_iter.c
+++ b/fs/bcachefs/btree_iter.c
@@ -531,8 +531,24 @@ found:
btree_iter_set_dirty(iter, BTREE_ITER_NEED_PEEK);
bch2_btree_node_iter_sort(node_iter, b);
- if (!b->level && n... |
57cb2142ed1aadf2bf737f732bc74e5649dbcb15 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix for running in degraded mode | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/journal_io.c b/fs/bcachefs/journal_io.c
index f3bb28f32c6e..4178dd9ceb8e 100644
--- a/fs/bcachefs/journal_io.c
+++ b/fs/bcachefs/journal_io.c
@@ -1036,7 +1036,7 @@ done:
spin_unlock(&j->lock);
rcu_read_unlock();
- return replicas >= replicas_want ? 0 : -EROFS;
+ return replicas >=... |
db636adb2e74fd54489f00667722e09a75702aaa | Analyze and fix the following issue in the Linux kernel code: bcachefs: Compression fixes | Problem Details:
regressions from switching disk space accounting to be in compressed
sectors
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/extents.c b/fs/bcachefs/extents.c
index c9a6f6e4a165..1076d32945f8 100644
--- a/fs/bcachefs/extents.c
+++ b/fs/bcachefs/extents.c
@@ -305,8 +305,7 @@ unsigned bch2_extent_is_compressed(struct bkey_s_c k)
extent_for_each_ptr_decode(e, p, entry)
if (!p.ptr.cached &&
- p.crc... |
3636ed489ac05e61d59be29b8e69111ef781d528 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Deferred btree updates | Problem Details:
Will be used in the future for inode updates, which will be very helpful
for multithreaded workloads that have to update the inode with every
extent update (appends, or updates that change i_sectors)
Also will be used eventually for fully persistent alloc info
However - we still need a mechanism for ... | ```diff
diff --git a/fs/bcachefs/btree_types.h b/fs/bcachefs/btree_types.h
index f34f340ff034..ce5127301cb2 100644
--- a/fs/bcachefs/btree_types.h
+++ b/fs/bcachefs/btree_types.h
@@ -245,9 +245,28 @@ struct btree_iter {
#define BTREE_ITER_MAX 8
+struct deferred_update {
+ struct journal_entry_pin journal;
+
+ spi... |
01a0108f0139a2f6dbace54dd5d592d2d76415c1 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix a btree iter usage error | Problem Details:
previously, if the code traversed to the next btree node, that could
return an error (due to lock restarts) - which was not being checked
for.
fix is to rework it so it never iterates past the current leaf node, and
pops an assertion if it ever sees an error.
Signed-off-by: Kent Overstreet <kent.over... | ```diff
diff --git a/fs/bcachefs/fs-io.c b/fs/bcachefs/fs-io.c
index 40d3f02d86d8..e7d7c5fe6db7 100644
--- a/fs/bcachefs/fs-io.c
+++ b/fs/bcachefs/fs-io.c
@@ -242,9 +242,15 @@ static s64 sum_sector_overwrites(struct bkey_i *new, struct btree_iter *_iter,
bch2_btree_iter_link(_iter, &iter);
bch2_btree_iter_copy(&ite... |
9d11058a789a86eb580d2b0684604a1a5d795fe3 | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix waiting on an open journal entry | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/journal.c b/fs/bcachefs/journal.c
index 4045c0e68462..2f8dae4013af 100644
--- a/fs/bcachefs/journal.c
+++ b/fs/bcachefs/journal.c
@@ -461,7 +461,7 @@ u64 bch2_journal_last_unwritten_seq(struct journal *j)
int bch2_journal_open_seq_async(struct journal *j, u64 seq, struct closure *cl)
... |
eeb83e25bb07ff1d00297c541c03e35c8c3c762c | Analyze and fix the following issue in the Linux kernel code: bcachefs: Hold usage_lock over mark_key and fs_usage_apply | Problem Details:
Fixes an inconsistency at the end of gc
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/bkey_methods.h b/fs/bcachefs/bkey_methods.h
index be6041e92c05..62b86a8e2ba8 100644
--- a/fs/bcachefs/bkey_methods.h
+++ b/fs/bcachefs/bkey_methods.h
@@ -54,6 +54,18 @@ struct bkey_ops {
bool is_extents;
};
+static inline bool bkey_type_needs_gc(enum bkey_type type)
+{
+ switch (t... |
ad7ae8d63fa82e5d713e73a1a6a4ca9728f84898 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Btree locking fix, refactoring | Problem Details:
Hit an assertion, probably spurious, indicating an iterator was unlocked
when it shouldn't have been (spurious because it wasn't locked at all
when the caller called btree_insert_at()).
Add a flag, BTREE_ITER_NOUNLOCK, and tighten up the assertions
Signed-off-by: Kent Overstreet <kent.overstreet@linu... | ```diff
diff --git a/fs/bcachefs/btree_gc.c b/fs/bcachefs/btree_gc.c
index 6eba65fcb52c..55d49677d5fe 100644
--- a/fs/bcachefs/btree_gc.c
+++ b/fs/bcachefs/btree_gc.c
@@ -1113,7 +1113,6 @@ next:
/* Free the old nodes and update our sliding window */
for (i = 0; i < nr_old_nodes; i++) {
bch2_btree_node_free_inmem... |
e647369168e02a06ff5ee229cc14ad72b2f5ddfd | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix mempool double initialization | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/compress.c b/fs/bcachefs/compress.c
index 42ae4cfdcb6b..6b5b61f10fcb 100644
--- a/fs/bcachefs/compress.c
+++ b/fs/bcachefs/compress.c
@@ -596,11 +596,13 @@ have_compressed:
goto out;
}
- ret = mempool_init_kmalloc_pool(
- &c->decompress_workspace,
- 1, decompress_workspace_s... |
8812600c2953bf7e394ad11d44c7d71fbdd719cc | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix btree iterator bug when using depth > 0 | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/btree_iter.c b/fs/bcachefs/btree_iter.c
index ea37fa21ed6e..a50a6a51a3a5 100644
--- a/fs/bcachefs/btree_iter.c
+++ b/fs/bcachefs/btree_iter.c
@@ -818,7 +818,7 @@ static inline int btree_iter_lock_root(struct btree_iter *iter,
*/
iter->level = depth_want;
iter->l[iter->level... |
f1a79365a7416c5046f88d0db025e1d84c32b252 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Don't block on journal reservation with btree locks held | Problem Details:
Fixes a deadlock between the allocator thread, when it first starts up,
and journal replay
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/btree_update_interior.c b/fs/bcachefs/btree_update_interior.c
index 01e476d72595..af31819c88c7 100644
--- a/fs/bcachefs/btree_update_interior.c
+++ b/fs/bcachefs/btree_update_interior.c
@@ -638,12 +638,12 @@ static void btree_update_wait_on_journal(struct closure *cl)
int ret;
ret... |
f81b648d1f8f285d1471bed0d47bb4316044b864 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Clean up, possixly fix page disk reservation accounting | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/fs-io.c b/fs/bcachefs/fs-io.c
index a65e6a6d54e7..40d3f02d86d8 100644
--- a/fs/bcachefs/fs-io.c
+++ b/fs/bcachefs/fs-io.c
@@ -454,12 +454,12 @@ struct bch_page_state {
union { struct {
/* existing data: */
unsigned sectors:PAGE_SECTOR_SHIFT + 1;
+
+ /* Uncompressed, fully allocate... |
b1ba2359fb86b2f87b55d7d8cc9847b826242b33 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix an error path | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/fs-io.c b/fs/bcachefs/fs-io.c
index eecf792198e4..a65e6a6d54e7 100644
--- a/fs/bcachefs/fs-io.c
+++ b/fs/bcachefs/fs-io.c
@@ -2542,10 +2542,9 @@ static long bch2_fallocate(struct bch_inode_info *inode, int mode,
&disk_res, "a_res,
iter, &reservation.k_i,
0, true, true... |
283cca30a8ae878e6f78cfbd73886fd78c1b13f8 | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix typo when picking read method | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/extents.c b/fs/bcachefs/extents.c
index 9bb4e10283e1..9e3ac910572e 100644
--- a/fs/bcachefs/extents.c
+++ b/fs/bcachefs/extents.c
@@ -637,11 +637,11 @@ static int extent_pick_read_device(struct bch_fs *c,
!bch2_dev_is_readable(ca))
p.idx++;
- if (!p.idx && p.ec_nr)
+ if (... |
82ebd49cd6c68a5af44ada2487e00da606423404 | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix a replicas bug | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/replicas.c b/fs/bcachefs/replicas.c
index 72dd70b00abb..a7c3aca1bf01 100644
--- a/fs/bcachefs/replicas.c
+++ b/fs/bcachefs/replicas.c
@@ -267,6 +267,8 @@ int bch2_mark_bkey_replicas(struct bch_fs *c,
struct bch_replicas_entry_padded search;
int ret;
+ memset(&search, 0, sizeof(sea... |
8b335baef22768deb7140e45f32f37ea51a1faf4 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Assorted fixes for running on very small devices | Problem Details:
It's now possible to create and use a filesystem on a 512k device with
4k buckets (though at that size we still waste almost half to internal
reserves)
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/alloc_background.c b/fs/bcachefs/alloc_background.c
index 1eb39283e7e2..a4c4a08aed59 100644
--- a/fs/bcachefs/alloc_background.c
+++ b/fs/bcachefs/alloc_background.c
@@ -374,6 +374,11 @@ static void bch2_rescale_bucket_io_times(struct bch_fs *c, int rw)
}
}
+static inline u64 bucke... |
72644db153e6d3fc146d2c805dcba5b5d676cd99 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix an assertion when rebuilding replicas | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/extents.c b/fs/bcachefs/extents.c
index 4a62eefd40cd..e2bb1502eaad 100644
--- a/fs/bcachefs/extents.c
+++ b/fs/bcachefs/extents.c
@@ -679,7 +679,8 @@ void bch2_btree_ptr_debugcheck(struct bch_fs *c, struct btree *b,
goto err;
}
- if (!bch2_bkey_replicas_marked(c, btree_node_type... |
6bdbfa87a832c0d3766e1b680729fede21eca7dc | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix journal replay when replicas sb section missing | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/journal_io.c b/fs/bcachefs/journal_io.c
index 0bcc4346285c..eb2fbe235483 100644
--- a/fs/bcachefs/journal_io.c
+++ b/fs/bcachefs/journal_io.c
@@ -746,7 +746,8 @@ int bch2_journal_read(struct bch_fs *c, struct list_head *list)
jlist.ret = 0;
for_each_member_device(ca, c, iter) {
- ... |
636ad1d391b9e0f22107ace04e6dbc07d8875739 | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix bounds checks in bch2_bio_map() | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/util.c b/fs/bcachefs/util.c
index 75053322d0f0..ed90bd3a5d18 100644
--- a/fs/bcachefs/util.c
+++ b/fs/bcachefs/util.c
@@ -529,15 +529,17 @@ void bch2_bio_map(struct bio *bio, void *base)
BUG_ON(!bio->bi_iter.bi_size);
BUG_ON(bio->bi_vcnt);
+ BUG_ON(!bio->bi_max_vecs);
bv->bv_o... |
ac10a9611d8794c849092a777a5febc4f69788ae | Analyze and fix the following issue in the Linux kernel code: bcachefs: Some fixes for building in userspace | Problem Details:
userspace allocators don't align allocations as nicely as kernel
allocators, which meant that in some cases we weren't allocating big
enough bvec arrays - just make the calculations more rigorous and
explicit to fix it.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/bset.c b/fs/bcachefs/bset.c
index 74d8871528a6..7fc8fb85069f 100644
--- a/fs/bcachefs/bset.c
+++ b/fs/bcachefs/bset.c
@@ -1672,7 +1672,7 @@ struct bkey_packed *bch2_btree_node_iter_prev_filter(struct btree_node_iter *ite
struct bkey_packed *orig_pos = bch2_btree_node_iter_peek_all(ite... |
b564513cf990d2d30305ac63a72a013fc197e7da | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix bch2_bkey_print_bfloat | Problem Details:
was popping an assertion in the eytzinger code
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/bset.c b/fs/bcachefs/bset.c
index 8e14e4be0b5c..74d8871528a6 100644
--- a/fs/bcachefs/bset.c
+++ b/fs/bcachefs/bset.c
@@ -1774,7 +1774,7 @@ int bch2_bkey_print_bfloat(struct btree *b, struct bkey_packed *k,
struct bkey_packed *l, *r, *p;
struct bkey uk, up;
char buf1[200], buf2[20... |
deb3318b0ea4b288431f09f8dbcf5de90a14b27b | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix missing include | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/alloc_foreground.h b/fs/bcachefs/alloc_foreground.h
index 609685d08642..636fe686dc48 100644
--- a/fs/bcachefs/alloc_foreground.h
+++ b/fs/bcachefs/alloc_foreground.h
@@ -5,6 +5,8 @@
#include "bcachefs.h"
#include "alloc_types.h"
+#include <linux/hash.h>
+
struct bkey;
struct bch_d... |
6278a46da3b39dee17d067a9634c3c68051e916e | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix a spurious gcc warning | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/alloc_foreground.c b/fs/bcachefs/alloc_foreground.c
index 562c1317aa9e..920d9ff3c53b 100644
--- a/fs/bcachefs/alloc_foreground.c
+++ b/fs/bcachefs/alloc_foreground.c
@@ -207,7 +207,7 @@ struct open_bucket *bch2_bucket_alloc(struct bch_fs *c, struct bch_dev *ca,
{
struct bucket_array ... |
ef337c54c6d18d4c6ce0aef8f4f327d4cf42ae08 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Allocation code refactoring | Problem Details:
bch2_alloc_sectors_start() was a nightmare to work with - it's got some
tricky stuff to do, since it wants to use the buckets the writepoint
already has, unless they're not in the target it wants to write to,
unless it can't allocate from any other devices in which case it will
use those buckets if it ... | ```diff
diff --git a/fs/bcachefs/alloc_background.c b/fs/bcachefs/alloc_background.c
index d22b2b72b0d1..45e8b124a9f3 100644
--- a/fs/bcachefs/alloc_background.c
+++ b/fs/bcachefs/alloc_background.c
@@ -1101,7 +1101,7 @@ void bch2_dev_allocator_remove(struct bch_fs *c, struct bch_dev *ca)
struct btree_alloc *a =
... |
f43cc5be6e08bd3e0425cc848a7c2a4d3c1974f3 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix failure to suspend | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/move.c b/fs/bcachefs/move.c
index b29e7c322e9a..9402b45bf868 100644
--- a/fs/bcachefs/move.c
+++ b/fs/bcachefs/move.c
@@ -504,7 +504,6 @@ int bch2_move_data(struct bch_fs *c,
if (unlikely(freezing(current))) {
bch2_btree_iter_unlock(&stats->iter);
move_ctxt_wait_event(&ctx... |
c2fcff5973c93af7ffa87ad28eca2fddd2be83c5 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix suspend when moving data faster than ratelimit | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/move.c b/fs/bcachefs/move.c
index 93083cfff9bf..b29e7c322e9a 100644
--- a/fs/bcachefs/move.c
+++ b/fs/bcachefs/move.c
@@ -470,7 +470,7 @@ int bch2_move_data(struct bch_fs *c,
struct bkey_s_c_extent e;
struct data_opts data_opts;
enum data_cmd data_cmd;
- u64 cur_inum = U64_MAX;
+ ... |
d06182cadb5bbd9ab7fa3d3e59608bb573bffbee | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix bch2_acl_chmod() | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/acl.c b/fs/bcachefs/acl.c
index 0074b3eb196d..eb6fa4d7c1f6 100644
--- a/fs/bcachefs/acl.c
+++ b/fs/bcachefs/acl.c
@@ -377,6 +377,7 @@ int bch2_acl_chmod(struct btree_trans *trans,
goto err;
}
+ new->k.p = iter->pos;
bch2_trans_update(trans, BTREE_INSERT_ENTRY(iter, &new->k_i));... |
34b8e552764d6f759072b8452831c6f72a28111c | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix a deadlock | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/btree_update_interior.c b/fs/bcachefs/btree_update_interior.c
index 6a2fcc4201b6..6d99f3d191d3 100644
--- a/fs/bcachefs/btree_update_interior.c
+++ b/fs/bcachefs/btree_update_interior.c
@@ -1550,7 +1550,13 @@ void bch2_btree_insert_node(struct btree_update *as, struct btree *b,
btre... |
cf0517af15e1ef43a0ece3e3dcbfc94a19e89bac | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix a divide | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/rebalance.c b/fs/bcachefs/rebalance.c
index 04824f667693..74702e753f60 100644
--- a/fs/bcachefs/rebalance.c
+++ b/fs/bcachefs/rebalance.c
@@ -113,7 +113,7 @@ static void rebalance_work_accumulate(struct rebalance_work *w,
work = U64_MAX;
work = min(work, capacity);
- percent_full... |
741daa5be5c8d9cccaaac9759eb99893f1beb09b | Analyze and fix the following issue in the Linux kernel code: bcachefs: Dirent repair code | Problem Details:
There was a bug for awhile in previous kernels where we weren't
computing dirent name lengths correctly and we weren't zeroing out
padding at the end of dirents (due to struct bch_dirent changing size by
adding __attribute__((aligned)), and not updating other code to use
offsetof).
This patch fixes di... | ```diff
diff --git a/fs/bcachefs/dirent.c b/fs/bcachefs/dirent.c
index d5e174e1e59f..0651f5575131 100644
--- a/fs/bcachefs/dirent.c
+++ b/fs/bcachefs/dirent.c
@@ -16,16 +16,7 @@ unsigned bch2_dirent_name_bytes(struct bkey_s_c_dirent d)
unsigned len = bkey_val_bytes(d.k) -
offsetof(struct bch_dirent, d_name);
- w... |
cbdf24cef19be489f6885cecb4887fe407cebdfc | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix a btree iter bug when iter pos == POS_MAX | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/btree_iter.c b/fs/bcachefs/btree_iter.c
index 1ab468a29d21..1ba59c53c36f 100644
--- a/fs/bcachefs/btree_iter.c
+++ b/fs/bcachefs/btree_iter.c
@@ -36,7 +36,16 @@ static inline int __btree_iter_pos_cmp(struct btree_iter *iter,
return cmp;
if (bkey_deleted(k))
return -1;
- if (iter... |
647d7b60b193967f113a47fcfd20102c4498f109 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix an assertion in the btree node merge path | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/btree_iter.c b/fs/bcachefs/btree_iter.c
index 7bead41b226f..8918268f99f4 100644
--- a/fs/bcachefs/btree_iter.c
+++ b/fs/bcachefs/btree_iter.c
@@ -69,26 +69,6 @@ void __bch2_btree_node_lock_write(struct btree *b, struct btree_iter *iter)
&b->lock.state.counter);
}
-/*
- * Lock... |
94c1f4adec42c03c8fb1b7dc41f2fc07481a5395 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix locking in allocator thread | Problem Details:
gc lock must be held while invalidating buckets - fixes
"1f7a95698e bcachefs: Invalidate buckets when writing to alloc btree"
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/alloc.c b/fs/bcachefs/alloc.c
index ea1dc52e5ff6..192ab655ca23 100644
--- a/fs/bcachefs/alloc.c
+++ b/fs/bcachefs/alloc.c
@@ -964,16 +964,21 @@ static int bch2_allocator_thread(void *arg)
if (ret)
goto stop;
+ down_read(&c->gc_lock);
+
ret = bch2_invalidate_buckets(c, ca);
... |
277c981c634f3e64dd99523aabfd9ed5e6c5be55 | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix bch2_val_to_text() | Problem Details:
was returning wrong value
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/alloc.c b/fs/bcachefs/alloc.c
index 19523226afd8..ea1dc52e5ff6 100644
--- a/fs/bcachefs/alloc.c
+++ b/fs/bcachefs/alloc.c
@@ -154,8 +154,8 @@ const char *bch2_alloc_invalid(const struct bch_fs *c, struct bkey_s_c k)
return NULL;
}
-void bch2_alloc_to_text(struct bch_fs *c, char *bu... |
bb1b3658aa7259bdacf7500abdeb8fdff61a51ba | Analyze and fix the following issue in the Linux kernel code: bcachefs: minor fsync fix | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/fs-io.c b/fs/bcachefs/fs-io.c
index ed028b5b7613..cc99eb1b36e0 100644
--- a/fs/bcachefs/fs-io.c
+++ b/fs/bcachefs/fs-io.c
@@ -2107,7 +2107,7 @@ int bch2_fsync(struct file *file, loff_t start, loff_t end, int datasync)
{
struct bch_inode_info *inode = file_bch_inode(file);
struct bc... |
60476b14b4c4e7a733047374aa135fb16c6ab340 | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix last_seq_ondisk | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/journal_io.c b/fs/bcachefs/journal_io.c
index d479d946eea7..dd423e79a65c 100644
--- a/fs/bcachefs/journal_io.c
+++ b/fs/bcachefs/journal_io.c
@@ -1207,6 +1207,7 @@ static void journal_write_done(struct closure *cl)
struct bch_devs_list devs =
bch2_extent_devs(bkey_i_to_s_c_extent(&... |
658971f2769a8c9beaa09dd52218b5b2d17ca497 | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix mtime/ctime update on truncate | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/fs-io.c b/fs/bcachefs/fs-io.c
index 33c379ecf5a1..ed028b5b7613 100644
--- a/fs/bcachefs/fs-io.c
+++ b/fs/bcachefs/fs-io.c
@@ -278,7 +278,8 @@ static int i_sectors_dirty_finish(struct bch_fs *c, struct i_sectors_hook *h)
mutex_lock(&h->inode->ei_update_lock);
i_sectors_acct(c, h->ino... |
73ab6f356db737d9997c830730ab927bbdf6b678 | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix fsync after create | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/fs.c b/fs/bcachefs/fs.c
index cd29404e0b9b..5963f88b8156 100644
--- a/fs/bcachefs/fs.c
+++ b/fs/bcachefs/fs.c
@@ -327,6 +327,7 @@ __bch2_create(struct mnt_idmap *idmap,
struct bch_inode_unpacked inode_u;
struct bch_hash_info hash_info;
struct posix_acl *default_acl = NULL, *acl = ... |
3142e7ef4b39f03c1e1aac90c2ac8f07f55ffa64 | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix nbuckets usage on device resize | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/buckets.c b/fs/bcachefs/buckets.c
index 6a7e8b7b6a79..65232f5e61bc 100644
--- a/fs/bcachefs/buckets.c
+++ b/fs/bcachefs/buckets.c
@@ -818,9 +818,9 @@ int bch2_dev_buckets_resize(struct bch_fs *c, struct bch_dev *ca, u64 nbuckets)
size_t btree_reserve = DIV_ROUND_UP(BTREE_NODE_RESERVE,... |
8bb4dff72d07f4f46e5627870a9614c4cee5a1bb | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix an assertion | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/btree_update_leaf.c b/fs/bcachefs/btree_update_leaf.c
index 7ce2e35dafa2..3d0c6f5c98ad 100644
--- a/fs/bcachefs/btree_update_leaf.c
+++ b/fs/bcachefs/btree_update_leaf.c
@@ -490,7 +490,7 @@ out:
bch2_btree_iter_verify_locks(linked);
BUG_ON((trans->flags & BTREE_INSERT_NOUNLOCK) ... |
d96b3ffe3884d8402ca64d1a1ae880460339ec63 | Analyze and fix the following issue in the Linux kernel code: bcachefs: fix rename + fsync | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/fs.c b/fs/bcachefs/fs.c
index a4d82252bc49..cd29404e0b9b 100644
--- a/fs/bcachefs/fs.c
+++ b/fs/bcachefs/fs.c
@@ -849,6 +849,10 @@ retry:
journal_seq_copy(i.dst_dir, journal_seq);
}
+ journal_seq_copy(i.src_inode, journal_seq);
+ if (i.dst_inode)
+ journal_seq_copy(i.dst_inode, ... |
2ea9004864b918be34e742e38fb08d868600d020 | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix mtime/ctime updates | Problem Details:
Also make inode flags consistent with how the rest of the inode is
updated
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/acl.c b/fs/bcachefs/acl.c
index eaf5c8e138fb..7ee2022d9501 100644
--- a/fs/bcachefs/acl.c
+++ b/fs/bcachefs/acl.c
@@ -286,10 +286,9 @@ static int inode_update_for_set_acl_fn(struct bch_inode_info *inode,
void *p)
{
struct bch_fs *c = inode->v.i_sb->s_fs_info;
- struct tim... |
4e1ec2cc0d82f1d4344e7b5a53229c9ccde8437d | Analyze and fix the following issue in the Linux kernel code: bcachefs: Simplify bch2_write_inode_trans, fix lockdep splat | Problem Details:
ei_update_lock isn't currently needed for write inode (but it will be
needed again when deferred btree updates are used for inode updates)
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/fs-io.c b/fs/bcachefs/fs-io.c
index b53fbdc15c87..29d289b0dfa5 100644
--- a/fs/bcachefs/fs-io.c
+++ b/fs/bcachefs/fs-io.c
@@ -355,8 +355,6 @@ bchfs_extent_update_hook(struct extent_insert_hook *hook,
h->inode_u.bi_size = offset;
do_pack = true;
- inode->ei_inode.bi_size = offse... |
4077991c8536595b50b52bab739ef1e9ac6a72cf | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix a use after free in the journal code | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/btree_update_interior.c b/fs/bcachefs/btree_update_interior.c
index 1710efd7c687..cc1f8b9a9e09 100644
--- a/fs/bcachefs/btree_update_interior.c
+++ b/fs/bcachefs/btree_update_interior.c
@@ -579,6 +579,8 @@ static void bch2_btree_update_free(struct btree_update *as)
{
struct bch_fs *c... |
97446a242a56f9350be7b8985ed933fe9118f41e | Analyze and fix the following issue in the Linux kernel code: bcachefs: Fix device add | Problem Details:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> | ```diff
diff --git a/fs/bcachefs/btree_gc.c b/fs/bcachefs/btree_gc.c
index 155e69056d96..00c28a0a4d9d 100644
--- a/fs/bcachefs/btree_gc.c
+++ b/fs/bcachefs/btree_gc.c
@@ -327,9 +327,16 @@ void bch2_mark_dev_superblock(struct bch_fs *c, struct bch_dev *ca,
unsigned i;
u64 b;
+ /*
+ * This conditional is kind of g... |
3294d01f7a5ddacb796d7f7bf31eb100a8f6d0e0 | Analyze and fix the following issue in the Linux kernel code: firmware: qcom: scm: add a missing forward declaration for struct device | Problem Details:
We reference struct device in the private scm header but we neither
include linux/device.h nor forward declare it. Fix it.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Tested-by: Andrew Halaney <ahalaney@redhat.com> # sc8280xp-le... | ```diff
diff --git a/drivers/firmware/qcom/qcom_scm.h b/drivers/firmware/qcom/qcom_scm.h
index 7b68fa820495..c88e29051d20 100644
--- a/drivers/firmware/qcom/qcom_scm.h
+++ b/drivers/firmware/qcom/qcom_scm.h
@@ -4,6 +4,8 @@
#ifndef __QCOM_SCM_INT_H
#define __QCOM_SCM_INT_H
+struct device;
+
enum qcom_scm_convention... |
8126cab004bab7b9d58b156435350379d88e8539 | Analyze and fix the following issue in the Linux kernel code: m68k: remove unused includes from dma.c | Problem Details:
dma.c doesn't need most of the headers it includes. Also there is
no point in undefining the DEBUG symbol given that it isn't used
anywhere in this small file.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Greg Ungerer <gerg@linux-m6... | ```diff
diff --git a/arch/m68k/kernel/dma.c b/arch/m68k/kernel/dma.c
index eef63d032abb..16063783aa80 100644
--- a/arch/m68k/kernel/dma.c
+++ b/arch/m68k/kernel/dma.c
@@ -4,17 +4,8 @@
* for more details.
*/
-#undef DEBUG
-
#include <linux/dma-map-ops.h>
-#include <linux/device.h>
#include <linux/kernel.h>
-#inc... |
d2a0fc372aca561556e765d0a9ec365c7c12f0ad | Analyze and fix the following issue in the Linux kernel code: tcp: fix wrong RTO timeout when received SACK reneging | Problem Details:
This commit fix wrong RTO timeout when received SACK reneging.
When an ACK arrived pointing to a SACK reneging, tcp_check_sack_reneging()
will rearm the RTO timer for min(1/2*srtt, 10ms) into to the future.
But since the commit 62d9f1a6945b ("tcp: fix TLP timer not set when
CA_STATE changes from DISO... | ```diff
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 8afb0950a697..804821d6bd4d 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -2207,16 +2207,17 @@ void tcp_enter_loss(struct sock *sk)
* restore sanity to the SACK scoreboard. If the apparent reneging
* persists until this RTO then... |
9b311b7313d6c104dd4a2d43ab54536dce07f960 | Analyze and fix the following issue in the Linux kernel code: ACPI: NFIT: Install Notify() handler before getting NFIT table | Problem Details:
If there is no NFIT at startup, it will return 0 immediately in function
acpi_nfit_add() and will not install Notify() handler. If hotplugging
a nvdimm device later, it will not be identified as there is no Notify()
handler.
Install the handler before getting NFI table in function acpi_nfit_add()
to a... | ```diff
diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
index f96bf32cd368..7d88db451cfb 100644
--- a/drivers/acpi/nfit/core.c
+++ b/drivers/acpi/nfit/core.c
@@ -3339,6 +3339,16 @@ static int acpi_nfit_add(struct acpi_device *adev)
acpi_size sz;
int rc = 0;
+ rc = acpi_dev_install_notify_handler(... |
b8d35024d4059ca550cba11ac9ab23a6c238d929 | Analyze and fix the following issue in the Linux kernel code: r8152: Release firmware if we have an error in probe | Problem Details:
The error handling in rtl8152_probe() is missing a call to release
firmware. Add it in to match what's in the cleanup code in
rtl8152_disconnect().
Fixes: 9370f2d05a2a ("r8152: support request_firmware for RTL8153")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Grant Grundler <g... | ```diff
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index d10b0886b652..656fe90734fc 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -9786,6 +9786,7 @@ out1:
cancel_delayed_work_sync(&tp->hw_phy_work);
if (tp->rtl_ops.unload)
tp->rtl_ops.unload(tp);
+ rtl8152_release_firm... |
bb8adff9123e492598162ac1baad01a53891aef6 | Analyze and fix the following issue in the Linux kernel code: r8152: Cancel hw_phy_work if we have an error in probe | Problem Details:
The error handling in rtl8152_probe() is missing a call to cancel the
hw_phy_work. Add it in to match what's in the cleanup code in
rtl8152_disconnect().
Fixes: a028a9e003f2 ("r8152: move the settings of PHY to a work queue")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Grant G... | ```diff
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 201c688e3e3f..d10b0886b652 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -9783,6 +9783,7 @@ static int rtl8152_probe(struct usb_interface *intf,
out1:
tasklet_kill(&tp->tx_tl);
+ cancel_delayed_work_sync(&tp->hw_ph... |
5dd17689526971c5ae12bc8398f34bd68cd0499e | Analyze and fix the following issue in the Linux kernel code: r8152: Run the unload routine if we have errors during probe | Problem Details:
The rtl8152_probe() function lacks a call to the chip-specific
unload() routine when it sees an error in probe. Add it in to match
the cleanup code in rtl8152_disconnect().
Fixes: ac718b69301c ("net/usb: new driver for RTL8152")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Gran... | ```diff
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 482957beae66..201c688e3e3f 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -9783,6 +9783,8 @@ static int rtl8152_probe(struct usb_interface *intf,
out1:
tasklet_kill(&tp->tx_tl);
+ if (tp->rtl_ops.unload)
+ tp->rtl_... |
a5feba71ec9c14a54c3babdc732c5b6866d8ee43 | Analyze and fix the following issue in the Linux kernel code: r8152: Increase USB control msg timeout to 5000ms as per spec | Problem Details:
According to the comment next to USB_CTRL_GET_TIMEOUT and
USB_CTRL_SET_TIMEOUT, although sending/receiving control messages is
usually quite fast, the spec allows them to take up to 5 seconds.
Let's increase the timeout in the Realtek driver from 500ms to 5000ms
(using the #defines) to account for this... | ```diff
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 0c13d9950cd8..482957beae66 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -1212,7 +1212,7 @@ int get_registers(struct r8152 *tp, u16 value, u16 index, u16 size, void *data)
ret = usb_control_msg(tp->udev, tp->pipe_ct... |
fd78ec3fbc470d33c42a312fd22506e3f3704374 | Analyze and fix the following issue in the Linux kernel code: bnxt_en: Fix invoking hwmon_notify_event | Problem Details:
FW sends the async event to the driver when the device temperature goes
above or below the threshold values. Only notify hwmon if the
temperature is increasing to the next alert level, not when it is
decreasing.
Cc: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Kashyap Desai <kashyap.desai@broadcom... | ```diff
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 7837e22f237b..65092150d451 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -2166,6 +2166,7 @@ static bool bnxt_event_error_report(struct bnxt *bp, u3... |
55862094a9d0d14f607eec00b925401407d61070 | Analyze and fix the following issue in the Linux kernel code: bnxt_en: Do not call sleeping hwmon_notify_event() from NAPI | Problem Details:
Defer hwmon_notify_event() to bnxt_sp_task() workqueue because
hwmon_notify_event() can try to acquire a mutex shown in the stack trace
below. Modify bnxt_event_error_report() to return true if we need to
schedule bnxt_sp_task() to notify hwmon.
__schedule+0x68/0x520
hwmon_notify_event+0xe8/0x114... | ```diff
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 16eb7a7af970..7837e22f237b 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -2147,7 +2147,8 @@ static u16 bnxt_agg_ring_id_to_grp_idx(struct bnxt *bp,... |
51a32e828109b4a209efde44505baa356b37a4ce | Analyze and fix the following issue in the Linux kernel code: net: usb: smsc95xx: Fix uninit-value access in smsc95xx_read_reg | Problem Details:
syzbot reported the following uninit-value access issue [1]:
smsc95xx 1-1:0.0 (unnamed net_device) (uninitialized): Failed to read reg index 0x00000030: -32
smsc95xx 1-1:0.0 (unnamed net_device) (uninitialized): Error reading E2P_CMD
=====================================================
BUG: KMSAN: un... | ```diff
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 17da42fe605c..a530f20ee257 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -95,7 +95,9 @@ static int __must_check smsc95xx_read_reg(struct usbnet *dev, u32 index,
ret = fn(dev, USB_VENDOR_REQUEST_READ_REGIST... |
ca082f019d8fbb983f03080487946da714154bae | Analyze and fix the following issue in the Linux kernel code: net: ieee802154: adf7242: Fix some potential buffer overflow in adf7242_stats_show() | Problem Details:
strncat() usage in adf7242_debugfs_init() is wrong.
The size given to strncat() is the maximum number of bytes that can be
written, excluding the trailing NULL.
Here, the size that is passed, DNAME_INLINE_LEN, does not take into account
the size of "adf7242-" that is already in the array.
In order to... | ```diff
diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c
index a03490ba2e5b..cc7ddc40020f 100644
--- a/drivers/net/ieee802154/adf7242.c
+++ b/drivers/net/ieee802154/adf7242.c
@@ -1162,9 +1162,10 @@ static int adf7242_stats_show(struct seq_file *file, void *offset)
static void adf7242_... |
5d9f6f26ec6656b43bf90f12705dbe88ce77f8d5 | Analyze and fix the following issue in the Linux kernel code: staging: vt6655: Rename variable byEIFS | Problem Details:
Remove byte Type encoding "by" from variable name and replace camelcase
with snakecase.
Fix checkpatch.pl error:
CHECK: Avoid CamelCase: <byEIFS>
Signed-off-by: Gilbert Adikankwu <gilbertadikankwu@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/4... | ```diff
diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 9c8648ea96be..079fd01c6780 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -250,9 +250,9 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type)
priv->difs = difs;
iowrite8(priv->d... |
30af3e57580d93bab1929e3b7cbed9177a8a6cef | Analyze and fix the following issue in the Linux kernel code: staging: vt6655: Rename variable byDIFS | Problem Details:
Remove byte Type encoding "by" from variable name and replace camelcase
with snakecase
Fix checkpatch.pl error:
CHECK: Avoid CamelCase: <byDIFS>
Signed-off-by: Gilbert Adikankwu <gilbertadikankwu@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/f1... | ```diff
diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 48e571badfb1..9c8648ea96be 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -187,7 +187,7 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type)
unsigned char cw_max_min = 0;
unsigne... |
d988a485f5940e119d6de4f2b17ea0a1dfc7db4f | Analyze and fix the following issue in the Linux kernel code: staging: vt6655: Rename variable bySIFS | Problem Details:
Remove byte Type encoding "by" from variable name and replace camelcase
with snakecase
Fix checkpatch.pl error:
CHECK: Avoid CamelCase: <bySIFS>
Signed-off-by: Gilbert Adikankwu <gilbertadikankwu@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/f7... | ```diff
diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index b5a87837995f..48e571badfb1 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -186,7 +186,7 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type)
{
unsigned char cw_max_min = 0;
unsi... |
e59314b68cc7ab639bfe1bf658a619b4b8b3ce4e | Analyze and fix the following issue in the Linux kernel code: staging: vt6655: Rename variable bySlot | Problem Details:
Remove byte Type encoding "by" from variable name and replace camelcase
with snakecase.
Fix checkpatch.pl error:
CHECK: Avoid CamelCase: <bySlot>
Signed-off-by: Gilbert Adikankwu <gilbertadikankwu@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/5... | ```diff
diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 08e50311f7ba..b5a87837995f 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -185,7 +185,7 @@ static void s_vCalculateOFDMRParameter(unsigned char rate,
bool CARDbSetPhyParameter(struct vnt_private ... |
25b8c77ecdd39eb8afb4e3be001f6f7baf12acda | Analyze and fix the following issue in the Linux kernel code: staging: vt6655: Rename variable byCWMaxMin | Problem Details:
Remove byte Type encoding "by" from variable name and replace camelcase
with snakecase
Fix checkpatch.pl error:
CHECK: Avoid CamelCase: <byCWMaxMin>
Signed-off-by: Gilbert Adikankwu <gilbertadikankwu@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/... | ```diff
diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index bec39c72d540..08e50311f7ba 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -184,7 +184,7 @@ static void s_vCalculateOFDMRParameter(unsigned char rate,
*/
bool CARDbSetPhyParameter(struct vnt_pri... |
7060d3ccdd4cf042749664d2fe93f978a777e3e9 | Analyze and fix the following issue in the Linux kernel code: apparmor: mark new functions static | Problem Details:
Two new functions were introduced as global functions when they are
only called from inside the file that defines them and should have
been static:
security/apparmor/lsm.c:658:5: error: no previous prototype for 'apparmor_uring_override_creds' [-Werror=missing-prototypes]
security/apparmor/lsm.c:682:5... | ```diff
diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
index b047d1d355a9..4d34180e9799 100644
--- a/security/apparmor/lsm.c
+++ b/security/apparmor/lsm.c
@@ -655,7 +655,7 @@ static int profile_uring(struct aa_profile *profile, u32 request,
* Check to see if the current task is allowed to override it'... |
9040c0d96fd66e84bb9b017b821e31f2876e949c | Analyze and fix the following issue in the Linux kernel code: RDMA/bnxt_re: Fix clang -Wimplicit-fallthrough in bnxt_re_handle_cq_async_error() | Problem Details:
Clang warns (or errors with CONFIG_WERROR=y):
drivers/infiniband/hw/bnxt_re/main.c:1114:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
1114 | default:
| ^
drivers/infiniband/hw/bnxt_re/main.c:1114:2: note: insert 'break;' to avo... | ```diff
diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
index bd3deb254a85..f79369c8360a 100644
--- a/drivers/infiniband/hw/bnxt_re/main.c
+++ b/drivers/infiniband/hw/bnxt_re/main.c
@@ -1111,6 +1111,7 @@ static int bnxt_re_handle_cq_async_error(void *event, struct bnxt_re_cq *cq... |
836d083524888069cd358776a4e6c4ceec04962e | Analyze and fix the following issue in the Linux kernel code: ARM: dts: qcom: msm8226: provide dsi phy clocks to mmcc | Problem Details:
Some mmcc clocks have dsi0pll & dsi0pllbyte as clock parents so we
should provide them in the dt, which I missed in the commit adding the
mdss nodes.
Fixes: d5fb01ad5eb4 ("ARM: dts: qcom: msm8226: Add mdss nodes")
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshk... | ```diff
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
index 98cc5ea637e1..0e480f824d78 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
@@ -416,8 +416,8 @@
<&gcc GPLL0_VOTE>,
<&gcc GPLL1_VOTE>,
<&rpm... |
4960e06d386ecc5307bc2e66a77d5f06df1e2a6f | Analyze and fix the following issue in the Linux kernel code: ARM: dts: qcom: msm8974: sort nodes by reg | Problem Details:
Some nodes weren't sorted by reg, so fix that now. Now all nodes inside
/soc should be sorted correctly.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20230627-msm8974-sort-v1-2-75c5800a2e09@z3ntu.xyz
Signed-off-by: Bjo... | ```diff
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
index 6cb61ef57a4f..76006c3c4af2 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
@@ -346,6 +346,12 @@
reg = <0xf9011000 0x1000>;
};
+ saw_l2: power-cont... |
207f4ce365819ac68b634153d074252338d00ef6 | Analyze and fix the following issue in the Linux kernel code: ARM: dts: qcom: msm8974: replace incorrect indentation in interconnect | Problem Details:
The clocks definition in the interconnect nodes should use tabs (+ 1
space) for indentation instead of 9 spaces. Fix that.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20230627-msm8974-sort-v1-1-75c5800a2e09@z3ntu.xyz
... | ```diff
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
index 0bc2e66d15b1..6cb61ef57a4f 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
@@ -1107,7 +1107,7 @@
#interconnect-cells = <1>;
clock-names = "bus", "bu... |
2e84dc37920012b458e9458b19fc4ed33f81bc74 | Analyze and fix the following issue in the Linux kernel code: driver core: Release all resources during unbind before updating device links | Problem Details:
This commit fixes a bug in commit 9ed9895370ae ("driver core: Functional
dependencies tracking support") where the device link status was
incorrectly updated in the driver unbind path before all the device's
resources were released.
Fixes: 9ed9895370ae ("driver core: Functional dependencies tracking s... | ```diff
diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index a528cec24264..0c3725c3eefa 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -1274,8 +1274,8 @@ static void __device_release_driver(struct device *dev, struct device *parent)
if (dev->bus && dev->bus->dma_cleanup)
dev->bus->dma_cleanup(dev)... |
12280cc708f28357e7ad85bab2bcc3715e59a8f7 | Analyze and fix the following issue in the Linux kernel code: parport: Clean up resources correctly when parport_register_port() fails | Problem Details:
The smatch warns about uncleaned resources in case the
parport_register_port() fails:
parport_register_port() warn: '&tmp->full_list' not removed from list
This is indeed an issue introduced when converting code to use
kasprintf(). However, the whole kasprintf() dance in this case
is not needed as ... | ```diff
diff --git a/drivers/parport/share.c b/drivers/parport/share.c
index a9a9cb0477ea..048a459ce4b0 100644
--- a/drivers/parport/share.c
+++ b/drivers/parport/share.c
@@ -361,7 +361,6 @@ static void free_port(struct device *dev)
kfree(port->probe_info[d].description);
}
- kfree(port->name);
kfree(port);
}... |
63ba2d07b4be72b94216d20561f43e1150b25d98 | Analyze and fix the following issue in the Linux kernel code: mcb: fix error handling for different scenarios when parsing | Problem Details:
chameleon_parse_gdd() may fail for different reasons and end up
in the err tag. Make sure we at least always free the mcb_device
allocated with mcb_alloc_dev().
If mcb_device_register() fails, make sure to give up the reference
in the same place the device was added.
Fixes: 728ac3389296 ("mcb: mcb-pa... | ```diff
diff --git a/drivers/mcb/mcb-core.c b/drivers/mcb/mcb-core.c
index 2a4a5e71ad4e..ba4530459de8 100644
--- a/drivers/mcb/mcb-core.c
+++ b/drivers/mcb/mcb-core.c
@@ -246,6 +246,7 @@ int mcb_device_register(struct mcb_bus *bus, struct mcb_device *dev)
return 0;
out:
+ put_device(&dev->dev);
return ret;
}
... |
a3457cc5bc30ad053c90ae9f14e9b7723d204a98 | Analyze and fix the following issue in the Linux kernel code: arm64: dts: qcom: sc8280xp-x13s: add missing camera LED pin config | Problem Details:
Add the missing pin configuration for the recently added camera
indicator LED.
Fixes: 1c63dd1c5fda ("arm64: dts: qcom: sc8280xp-x13s: Add camera activity LED")
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20231003093... | ```diff
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index 6a4c6cc19c09..f2055899ae7a 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -82,6 ... |
6cd8621758004d98f7c622c2d756c116c6888127 | Analyze and fix the following issue in the Linux kernel code: arm64: dts: qcom: pm7250b: Use correct node name for gpios | Problem Details:
Use gpio@ instead of pinctrl@ as that's the name expected by the
qcom,spmi-pmic.yaml schema. Update it to fix dt validation.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20231002-pm7250b-gpio-fixu... | ```diff
diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
index df0afe82f250..3bf7cf5d1700 100644
--- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
@@ -148,7 +148,7 @@
status = "disabled";
};
- pm7250b_gpios: pinctrl@c000 {
+ pm72... |
0cd080dd6d08817c9980d2069197b066636b0f23 | Analyze and fix the following issue in the Linux kernel code: arm64: dts: qcom: sc8280xp-x13s: Use the correct DP PHY compatible | Problem Details:
The DP PHY needs different settings when an eDP display is used.
Make sure these apply on the X13s.
FWIW
I could not notice any user-facing change stemming from this commit.
Fixes: f48c70b111b4 ("arm64: dts: qcom: sc8280xp-x13s: enable eDP display")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.... | ```diff
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index 38edaf51aa34..6a4c6cc19c09 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -601,6... |
b364cc485da1b769f1ead705dcd853e87b42f96e | Analyze and fix the following issue in the Linux kernel code: arm64: dts: qcom: msm8916-*: Fix alphabetic node order | Problem Details:
Fix a couple of instances of incorrectly sorted nodes in the MSM8916
boards. They should be ordered alphabetically for consistency.
No functional change.
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Link: https://lore.kernel.org/r/20230921-msm8916-rmem-fixups-v1-3-34d2b6e721cf@gerhold.net
Sig... | ```diff
diff --git a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
index aa4c1ab1e673..fade93c55299 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
@@ -58,10 +58,6 @@
};
};
-&b... |
d63ae4a814a763a5d2d4d078073562698693a909 | Analyze and fix the following issue in the Linux kernel code: arm64: dts: qcom: msm8939-longcheer-l9100: Enable wcnss_mem | Problem Details:
Enable &wcnss_mem for msm8939-longcheer-l9100. This is needed now to
have WCNSS working. It was missed when &wcnss_mem was disabled by
default because the patch with the msm8939-longcheer-l9100 device tree
was not applied yet.
Fixes: 0ece6438a8c0 ("arm64: dts: qcom: msm8916/39: Disable unneeded firmwa... | ```diff
diff --git a/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts b/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
index 6802714fda3f..a3357513037c 100644
--- a/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
+++ b/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
@@ -247,6 +247,10 @@
compatible... |
e87cef6a035edc03b4ac98f88121c706b2843156 | Analyze and fix the following issue in the Linux kernel code: arm64: dts: qcom: msm8916-samsung-gt5: Enable GPU | Problem Details:
Enable the GPU for the msm8916-samsung-gt58 and gt510 tablets now that
they have display panels enabled in the device tree. This was missed
when the GPU was disabled by default because the change was not applied
yet.
Fixes: 0ce5bb825d54 ("arm64: dts: qcom: msm8916/39: Disable GPU by default")
Signed-o... | ```diff
diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt510.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt510.dts
index 75c4854ecd64..c3f1acc55078 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt510.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt510.dts
@@ -112,6 +112,10 @@
};
};
+&gpu {
+... |
5635ef0bd1052420bc659a00be6fd0c60cec5cb9 | Analyze and fix the following issue in the Linux kernel code: clk: qcom: ipq5332: drop the CLK_SET_RATE_PARENT flag from GPLL clocks | Problem Details:
GPLL clock rates are fixed and shouldn't be scaled based on the
request from dependent clocks. Doing so will result in the unexpected
behaviour. So drop the CLK_SET_RATE_PARENT flag from the GPLL clocks.
Fixes: 3d89d52970fd ("clk: qcom: add Global Clock controller (GCC) driver for IPQ5332 SoC")
Signed... | ```diff
diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c
index b836159fbdef..f98591148a97 100644
--- a/drivers/clk/qcom/gcc-ipq5332.c
+++ b/drivers/clk/qcom/gcc-ipq5332.c
@@ -112,7 +112,6 @@ static struct clk_alpha_pll_postdiv gpll2 = {
&gpll2_main.clkr.hw },
.num_parents = 1,
.op... |
99a8f8764b70158a712992640a6be46a8fd79d15 | Analyze and fix the following issue in the Linux kernel code: clk: qcom: ipq9574: drop the CLK_SET_RATE_PARENT flag from GPLL clocks | Problem Details:
GPLL clock rates are fixed and shouldn't be scaled based on the request
from dependent clocks. Doing so will result in the unexpected behaviour.
So drop the CLK_SET_RATE_PARENT flag from the GPLL clocks.
----
Changes in V2:
- No changes
Fixes: d75b82cff488 ("clk: qcom: Add Global Clock Controller dr... | ```diff
diff --git a/drivers/clk/qcom/gcc-ipq9574.c b/drivers/clk/qcom/gcc-ipq9574.c
index 8f430367299e..e8190108e1ae 100644
--- a/drivers/clk/qcom/gcc-ipq9574.c
+++ b/drivers/clk/qcom/gcc-ipq9574.c
@@ -87,7 +87,6 @@ static struct clk_fixed_factor gpll0_out_main_div2 = {
&gpll0_main.clkr.hw
},
.num_parents = ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.