Sandpies Claude Opus 5 commited on
Commit ·
ef379a4
1
Parent(s): 4bf5daf
Drop the agent handover note from the repo
Browse filesdocs/GROK_TO_CLAUDE.md was a 2026-09-05 agent-to-agent pickup note -- "Grok
finished the writing of v2, you are taking over review + remaining GPU tests"
-- carrying instructions that expired the day they were followed, including a
"do not push, do not publish" line that has been false since 2.0.0. It is not
history anyone needs and it reads oddly to someone unzipping the pack.
GROK_V2_HANDBACK.md opened and closed by pointing at it, so both pointers are
repaired rather than left dangling. The .comfyignore entry goes with the file.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
- .comfyignore +0 -1
- docs/GROK_TO_CLAUDE.md +0 -108
- docs/GROK_V2_HANDBACK.md +3 -3
.comfyignore
CHANGED
|
@@ -49,7 +49,6 @@ docs/DEVLOG.md
|
|
| 49 |
#
|
| 50 |
# BETA_NOTES.md is here for a duller reason: it describes 1.2.0-beta1, is
|
| 51 |
# marked superseded, and is not 2.0.0 user material.
|
| 52 |
-
docs/GROK_TO_CLAUDE.md
|
| 53 |
docs/GROK_V2_HANDBACK.md
|
| 54 |
docs/GROK_V2_GPU_TESTS.md
|
| 55 |
docs/POST_V2.md
|
|
|
|
| 49 |
#
|
| 50 |
# BETA_NOTES.md is here for a duller reason: it describes 1.2.0-beta1, is
|
| 51 |
# marked superseded, and is not 2.0.0 user material.
|
|
|
|
| 52 |
docs/GROK_V2_HANDBACK.md
|
| 53 |
docs/GROK_V2_GPU_TESTS.md
|
| 54 |
docs/POST_V2.md
|
docs/GROK_TO_CLAUDE.md
DELETED
|
@@ -1,108 +0,0 @@
|
|
| 1 |
-
# Pickup for Claude — Hand Tie Clips v2
|
| 2 |
-
|
| 3 |
-
Grok finished the **writing** of v2. You are taking over **review + remaining
|
| 4 |
-
GPU tests**. The human continues the GPU window with you. Do not push. Do
|
| 5 |
-
not publish. Do not zip.
|
| 6 |
-
|
| 7 |
-
Read this file first, then `GROK_V2_GPU_TESTS.md` (same folder, remaining
|
| 8 |
-
tests 3–5). Engineering detail: `GROK_V2_HANDBACK.md`. Repo authority:
|
| 9 |
-
`CLAUDE.md` (outranks this). Copies also live in the pack under `docs/`.
|
| 10 |
-
|
| 11 |
-
---
|
| 12 |
-
|
| 13 |
-
## Where the tree is
|
| 14 |
-
|
| 15 |
-
- Repo: `D:\ComfyUI\custom_nodes\ComfyUI-Hand-Tie-Clips`
|
| 16 |
-
- Branch: **`v2`**, unpushed
|
| 17 |
-
- Head: **`2b22e73`** (this handoff). Writing+GPU 1–2: `d0ba7af`.
|
| 18 |
-
- Parent writing: `d140c0d` xfade rank fix, `c7ece81` 2.0.0 bump
|
| 19 |
-
- Python: `D:\ComfyUI\venv\Scripts\python.exe`
|
| 20 |
-
- Checkers: `D:\ComfyUI\venv\Scripts\python.exe tools\check_all.py` (22, all
|
| 21 |
-
green after the xfade commit)
|
| 22 |
-
- ComfyUI log: `D:\ComfyUI\user\comfyui.log`
|
| 23 |
-
- ComfyUI was restarted after `d140c0d`. Python on disk is loaded.
|
| 24 |
-
|
| 25 |
-
`texture-lab` was **not** merged. Do not merge it.
|
| 26 |
-
|
| 27 |
-
---
|
| 28 |
-
|
| 29 |
-
## GPU status (2026-09-05, this machine)
|
| 30 |
-
|
| 31 |
-
This is **not** the tester's 9-hop couch chain. The live graph is Mia at a
|
| 32 |
-
podcast desk, 576p 9:16, 8 steps `lcm`/`sgm_uniform`, 2 hops × 8 s, overlap
|
| 33 |
-
0.9 s, `cache_hops=on`, budget 19 GB.
|
| 34 |
-
|
| 35 |
-
Take on disk (26.36 s, stereo, 44100 Hz):
|
| 36 |
-
|
| 37 |
-
a single ElevenLabs TTS take (26.36 s, stereo, 44100 Hz) under `input/h3_refs/`
|
| 38 |
-
|
| 39 |
-
under `ComfyUI/input/h3_refs/`.
|
| 40 |
-
|
| 41 |
-
| test | result |
|
| 42 |
-
|---|---|
|
| 43 |
-
| 1 audio lock on | **PASS.** Hop 1 `[0.00s-8.00s]`, hop 2 `[7.08s-15.08s]`, passthrough `[0.00s-15.08s]`, drift +0 ms. First attempt crashed at hop-2 xfade (2-D take vs 3-D hop audio). Fixed `d140c0d`, ComfyUI restarted, second attempt joined. |
|
| 44 |
-
| 2 lock off | **PASS.** Empty MEDIA slot. No `master_audio_file: loaded`, no `audio locked`, no passthrough. Generated voice **heard**. Drift −40 ms (generated xfade). |
|
| 45 |
-
| 3 restart hop 4 | **not run** |
|
| 46 |
-
| 4 restart master length | **not run** (log-only if 3 runs) |
|
| 47 |
-
| 5 last-frame guide | **not run** |
|
| 48 |
-
|
| 49 |
-
Fail C (wooden mouth, correct take) was not scored. Beats were not rewritten
|
| 50 |
-
to match the take's words.
|
| 51 |
-
|
| 52 |
-
**Latent sidecar (not a test-1/2 blocker):** every hop logs
|
| 53 |
-
`latent not cached (ValueError('latent is not representable without pickling
|
| 54 |
-
(unrecognised samples container, or a non-scalar non-tensor member)'))`.
|
| 55 |
-
Hops still render. A later cache hit will fall back to the AddGuide pixel
|
| 56 |
-
pin. Motion-Context still ran on hop 2 of these tests because the live
|
| 57 |
-
sampler latent was in RAM. Worth a look after 3–5, not instead of them.
|
| 58 |
-
|
| 59 |
-
---
|
| 60 |
-
|
| 61 |
-
## What you do next
|
| 62 |
-
|
| 63 |
-
1. **GPU tests 3, then 4, then 5** — verbatim in
|
| 64 |
-
`C:\Users\User\Desktop\GROK_V2_GPU_TESTS.md`. Adapted to *this* graph
|
| 65 |
-
(desk/podcast, not the tester couch). If the window is short: **3 and 4**.
|
| 66 |
-
4 is a log read if 3 already ran.
|
| 67 |
-
2. Record results in that file and in `docs/DEVLOG.md` (next free section
|
| 68 |
-
is **63**).
|
| 69 |
-
3. Do not push, tag, or `comfy node publish` unless the human asks.
|
| 70 |
-
|
| 71 |
-
If you write code: `check_all.py` green before every commit; one behaviour
|
| 72 |
-
per commit; append widgets last; hop-2+ levers in the per-hop key not
|
| 73 |
-
`chain_salt`; restart hops pass `None` prev_key; Core calls keyword-only
|
| 74 |
-
via `_core_call`; no pickle; no `texture-lab`; do not rewrite `tone.py`
|
| 75 |
-
seam guarantee.
|
| 76 |
-
|
| 77 |
-
---
|
| 78 |
-
|
| 79 |
-
## Hard facts that already bit this session
|
| 80 |
-
|
| 81 |
-
- **AddGuide `frame_idx` is pixel frames.** `FRAME_PER_TOKEN` is
|
| 82 |
-
`(1,4,4,4,4)`. `latent_T-1` on an 8 s hop is ~2.3 s in. Last-frame guide
|
| 83 |
-
uses `-1`.
|
| 84 |
-
- **`start_at` is `render_from`.** Restart flags are `hop_starts`.
|
| 85 |
-
- **A restart hop writes full length.** 4×192, restart at hop 4 → **724**
|
| 86 |
-
frames, not 702. Log: `restart, wrote all 192 frames (no overlap trim)`.
|
| 87 |
-
- **Python changes need a ComfyUI process restart.** Browser refresh is JS
|
| 88 |
-
only. Restart wipes `temp/` (hop cache).
|
| 89 |
-
- **Log line numbers in a traceback tell you if the process reloaded.**
|
| 90 |
-
The xfade `torch.cat` is at **1474** on current `h3_ref_chain.py`. A
|
| 91 |
-
crash at 1457 is the pre-fix process.
|
| 92 |
-
|
| 93 |
-
---
|
| 94 |
-
|
| 95 |
-
## Files
|
| 96 |
-
|
| 97 |
-
| path | what |
|
| 98 |
-
|---|---|
|
| 99 |
-
| `C:\Users\User\Desktop\GROK_TO_CLAUDE.md` | this file |
|
| 100 |
-
| `C:\Users\User\Desktop\GROK_V2_GPU_TESTS.md` | remaining tests, exact widgets |
|
| 101 |
-
| `C:\Users\User\Desktop\GROK_V2_HANDBACK.md` | commits, decisions, falsification |
|
| 102 |
-
| pack `docs/` | copies of the three, committed on `v2` |
|
| 103 |
-
| pack `CLAUDE.md` | authority; live-queue pointer at the end |
|
| 104 |
-
| pack `docs/DEVLOG.md` | §§56–62 are this v2 work |
|
| 105 |
-
| pack `CHANGELOG.md` | user-facing 2.0.0 |
|
| 106 |
-
|
| 107 |
-
Original takeover brief (historical): `C:\Users\User\Desktop\GROK_TAKEOVER_v2.md`.
|
| 108 |
-
Reviews: `GROK_VIDEO_REVIEW.md`, `GROK_REVIEW_2.md` on the Desktop.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
docs/GROK_V2_HANDBACK.md
CHANGED
|
@@ -1,7 +1,7 @@
|
|
| 1 |
# Hand Tie Clips v2 — handback
|
| 2 |
|
| 3 |
-
**
|
| 4 |
-
the
|
| 5 |
|
| 6 |
Branch `v2` at `D:\ComfyUI\custom_nodes\ComfyUI-Hand-Tie-Clips`. Committed,
|
| 7 |
**unpushed**. Head **`d0ba7af`**. `check_all.py`: 22 checks, all green after
|
|
@@ -246,4 +246,4 @@ shipped; test 4 is the length check.
|
|
| 246 |
## 7. GPU tests
|
| 247 |
|
| 248 |
`GROK_V2_GPU_TESTS.md` (Desktop and `docs/`). Tests 1–2 done. Claude
|
| 249 |
-
runs 3–5.
|
|
|
|
| 1 |
# Hand Tie Clips v2 — handback
|
| 2 |
|
| 3 |
+
**This file is the writing record.** Its companion pickup note was removed
|
| 4 |
+
from the repo on 2026-09-22; what it asked for is done. Remaining GPU work is tests **3–5**.
|
| 5 |
|
| 6 |
Branch `v2` at `D:\ComfyUI\custom_nodes\ComfyUI-Hand-Tie-Clips`. Committed,
|
| 7 |
**unpushed**. Head **`d0ba7af`**. `check_all.py`: 22 checks, all green after
|
|
|
|
| 246 |
## 7. GPU tests
|
| 247 |
|
| 248 |
`GROK_V2_GPU_TESTS.md` (Desktop and `docs/`). Tests 1–2 done. Claude
|
| 249 |
+
runs 3–5.
|