Rifqi Hafizuddin Claude Opus 5.5 commited on
Commit
3e4a81a
·
1 Parent(s): d20cd21

[NOTICKET] docs(plans): tracker — P0-10 (Sofhia's ADT root cause)

Browse files
Files changed (1) hide show
  1. docs/plans/AUDIT_FIXES_2026-11.md +2 -1
docs/plans/AUDIT_FIXES_2026-11.md CHANGED
@@ -37,7 +37,8 @@ its own 7-question check passes.
37
  | P0-7 | Report caps status on model-fit `quality.weak` only (importance, cluster, forecast, anomaly — not ab_test) | Rifqi (lead) | ✅ `5595f0e2` | `anchored._weak_fit`: status ≤ partial with "the model's own fit check is weak (accuracy 0.989 vs baseline 0.989)"; a weak primary sorts behind a clean one; limitation line |
38
  | P0-8 | Trend/forecast keep empty periods empty + per-period n + stub flag; correlation n + p-value + quality | Sofhia | ✅ `f28898b0` `50cae402` `1ac2267a` | `temporal._resample`: `sum` uses `min_count=1` (an empty period is None, `count` keeps 0), shared by forecast. Points/history carry `n` + `stub` (< ½ median non-empty period, needs ≥ 3 periods); trend leaves stubs out of first/last/direction/slope with a caveat, forecast fits all and caveats a thin last period. IPR OB LOADER (Aug empty, Sep 9 rows vs 63–66): sum(mtbs) "down" → "up". Correlation pairs carry `n`, `p_value`, `weak` (n < 10 or p ≥ 0.05) + `quality` block + caveat; `n_*` skipped when no `column_ids`. Local tests; full suite 388 passed, 6 pre-existing failures. Not yet checked through a chat. Report trend table still shows period/value only (no n/stub column) |
39
  | P0-9 | Exhausted plan gets its own message ("Anda", no data-gap claim) | Rifqi (lead) | ✅ `863bf8e8` (message switch in `621aed1d`) | `TaskList._exhausted` (private, not in the model's schema); new EN/ID texts ("Ini tidak berarti datanya tidak ada"); shown without the data-gap lead |
40
- | Review | Independent reviews: P0-1 ×2 rounds, P0-2, then P0-1b/4/5/6/7/9 | lead + reviewer agents | ✅ | Round 3 fixes: YoY/period comparisons released, "N bulan lalu" and open ranges unresolved, comparisons vs a target keep the window, all-time wording releases, the schema docstring no longer carries incident text into the tool description, only `*_id` hidden next to its code, forecast "not validated" note |
 
41
 
42
  ## Verification gates (paid runs on GPT-5.4-mini, serial, each with Rifqi's go)
43
  | Gate | Tokens (est.) | Status |
 
37
  | P0-7 | Report caps status on model-fit `quality.weak` only (importance, cluster, forecast, anomaly — not ab_test) | Rifqi (lead) | ✅ `5595f0e2` | `anchored._weak_fit`: status ≤ partial with "the model's own fit check is weak (accuracy 0.989 vs baseline 0.989)"; a weak primary sorts behind a clean one; limitation line |
38
  | P0-8 | Trend/forecast keep empty periods empty + per-period n + stub flag; correlation n + p-value + quality | Sofhia | ✅ `f28898b0` `50cae402` `1ac2267a` | `temporal._resample`: `sum` uses `min_count=1` (an empty period is None, `count` keeps 0), shared by forecast. Points/history carry `n` + `stub` (< ½ median non-empty period, needs ≥ 3 periods); trend leaves stubs out of first/last/direction/slope with a caveat, forecast fits all and caveats a thin last period. IPR OB LOADER (Aug empty, Sep 9 rows vs 63–66): sum(mtbs) "down" → "up". Correlation pairs carry `n`, `p_value`, `weak` (n < 10 or p ≥ 0.05) + `quality` block + caveat; `n_*` skipped when no `column_ids`. Local tests; full suite 388 passed, 6 pre-existing failures. Not yet checked through a chat. Report trend table still shows period/value only (no n/stub column) |
39
  | P0-9 | Exhausted plan gets its own message ("Anda", no data-gap claim) | Rifqi (lead) | ✅ `863bf8e8` (message switch in `621aed1d`) | `TaskList._exhausted` (private, not in the model's schema); new EN/ID texts ("Ini tidak berarti datanya tidak ada"); shown without the data-gap lead |
40
+ | P0-10 | GROUP BY without an aggregate = one row per group key on uploaded files (pandas compiler) | Rifqi (lead) | ✅ (see the commit `fix(query): GROUP BY without an aggregate…`) | Root cause of Sofhia's "ADT lost" (analysis da688944): the value-index query returned 50 raw rows, so `site_code` read `['LAT','BIN','SDJ']` of 7 and the objective's site ADT was never pinned (focus = section only, pinned=True, all session). Now dedupe on the group keys before the select (SQL parity, incl. `SELECT a GROUP BY a, b`); rendered query shows it. Re-run on her data: 7 sites, 6 sections; objective → `site_code ADT` + `OB HAULER`. Reviewed |
41
+ | Review | Independent reviews: P0-1 ×2 rounds, P0-2, then P0-1b/4/5/6/7/9, then P0-10 | lead + reviewer agents | ✅ | Round 3 fixes: YoY/period comparisons released, "N bulan lalu" and open ranges unresolved, comparisons vs a target keep the window, all-time wording releases, the schema docstring no longer carries incident text into the tool description, only `*_id` hidden next to its code, forecast "not validated" note |
42
 
43
  ## Verification gates (paid runs on GPT-5.4-mini, serial, each with Rifqi's go)
44
  | Gate | Tokens (est.) | Status |