sofhiaazzhr Claude Opus 5.5 commited on
Commit
5772bbc
·
1 Parent(s): 1ac2267

[NOTICKET] docs(plans): tracker — P0-8 done, commit ids

Browse files

- P0-8 row set to done with the three commit ids (f28898b0, 50cae402, 1ac2267a)
- Evidence: what changed, the IPR OB LOADER example, test counts
- Notes it is not yet checked through a chat and the report trend table has no n/stub

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Files changed (1) hide show
  1. docs/plans/AUDIT_FIXES_2026-11.md +1 -1
docs/plans/AUDIT_FIXES_2026-11.md CHANGED
@@ -35,7 +35,7 @@ its own 7-question check passes.
35
  | P0-5 | Relative periods resolved against today (D7) and applied by code | Rifqi (lead) | ✅ `621aed1d` | Done as CODE, not a validator retry: `period.relative_window` — "N bulan terakhir" = the N complete months before today's month (planner.md rule), bulan lalu/ini, tahun lalu/ini, kuartal lalu/ini (WIB). Released to the planner: windows across two years, period comparisons (YoY, "dibanding tahun lalu"), "N bulan lalu", open ranges ("sejak tahun lalu"), weekly windows. Planner eval passes the case's fixed date to the hook. **D1b (route month questions to the month-grain table) not enforced** — a month window on a weekly table gets the ISO weeks instead → P1 |
36
  | P0-6 | Report summary generated after the answers (+1 prompt line) | Rifqi (lead) | ✅ `d8c47594` | `ReportSummaryNarrative` order bq_answers → title → executive_summary → next_analyses; report_summary.md: the summary restates the answers only. Prompt change → gate |
37
  | P0-7 | Report caps status on model-fit `quality.weak` only (importance, cluster, forecast, anomaly — not ab_test) | Rifqi (lead) | ✅ `5595f0e2` | `anchored._weak_fit`: status ≤ partial with "the model's own fit check is weak (accuracy 0.989 vs baseline 0.989)"; a weak primary sorts behind a clean one; limitation line |
38
- | P0-8 | Trend/forecast keep empty periods empty + per-period n + stub flag; correlation n + p-value + quality | Sofhia | ⬜ | |
39
  | P0-9 | Exhausted plan gets its own message ("Anda", no data-gap claim) | Rifqi (lead) | ✅ `863bf8e8` (message switch in `621aed1d`) | `TaskList._exhausted` (private, not in the model's schema); new EN/ID texts ("Ini tidak berarti datanya tidak ada"); shown without the data-gap lead |
40
  | Review | Independent reviews: P0-1 ×2 rounds, P0-2, then P0-1b/4/5/6/7/9 | lead + reviewer agents | ✅ | Round 3 fixes: YoY/period comparisons released, "N bulan lalu" and open ranges unresolved, comparisons vs a target keep the window, all-time wording releases, the schema docstring no longer carries incident text into the tool description, only `*_id` hidden next to its code, forecast "not validated" note |
41
 
 
35
  | P0-5 | Relative periods resolved against today (D7) and applied by code | Rifqi (lead) | ✅ `621aed1d` | Done as CODE, not a validator retry: `period.relative_window` — "N bulan terakhir" = the N complete months before today's month (planner.md rule), bulan lalu/ini, tahun lalu/ini, kuartal lalu/ini (WIB). Released to the planner: windows across two years, period comparisons (YoY, "dibanding tahun lalu"), "N bulan lalu", open ranges ("sejak tahun lalu"), weekly windows. Planner eval passes the case's fixed date to the hook. **D1b (route month questions to the month-grain table) not enforced** — a month window on a weekly table gets the ISO weeks instead → P1 |
36
  | P0-6 | Report summary generated after the answers (+1 prompt line) | Rifqi (lead) | ✅ `d8c47594` | `ReportSummaryNarrative` order bq_answers → title → executive_summary → next_analyses; report_summary.md: the summary restates the answers only. Prompt change → gate |
37
  | P0-7 | Report caps status on model-fit `quality.weak` only (importance, cluster, forecast, anomaly — not ab_test) | Rifqi (lead) | ✅ `5595f0e2` | `anchored._weak_fit`: status ≤ partial with "the model's own fit check is weak (accuracy 0.989 vs baseline 0.989)"; a weak primary sorts behind a clean one; limitation line |
38
+ | P0-8 | Trend/forecast keep empty periods empty + per-period n + stub flag; correlation n + p-value + quality | Sofhia | ✅ `f28898b0` `50cae402` `1ac2267a` | `temporal._resample`: `sum` uses `min_count=1` (an empty period is None, `count` keeps 0), shared by forecast. Points/history carry `n` + `stub` (< ½ median non-empty period, needs ≥ 3 periods); trend leaves stubs out of first/last/direction/slope with a caveat, forecast fits all and caveats a thin last period. IPR OB LOADER (Aug empty, Sep 9 rows vs 63–66): sum(mtbs) "down" → "up". Correlation pairs carry `n`, `p_value`, `weak` (n < 10 or p ≥ 0.05) + `quality` block + caveat; `n_*` skipped when no `column_ids`. Local tests; full suite 388 passed, 6 pre-existing failures. Not yet checked through a chat. Report trend table still shows period/value only (no n/stub column) |
39
  | P0-9 | Exhausted plan gets its own message ("Anda", no data-gap claim) | Rifqi (lead) | ✅ `863bf8e8` (message switch in `621aed1d`) | `TaskList._exhausted` (private, not in the model's schema); new EN/ID texts ("Ini tidak berarti datanya tidak ada"); shown without the data-gap lead |
40
  | Review | Independent reviews: P0-1 ×2 rounds, P0-2, then P0-1b/4/5/6/7/9 | lead + reviewer agents | ✅ | Round 3 fixes: YoY/period comparisons released, "N bulan lalu" and open ranges unresolved, comparisons vs a target keep the window, all-time wording releases, the schema docstring no longer carries incident text into the tool description, only `*_id` hidden next to its code, forecast "not validated" note |
41