Update app.py

app.py

@@ -3,12 +3,11 @@ import requests
 import pandas as pd
 
 # ===============================
-# Firebase config từ secrets.toml
+# Firebase config from secrets.toml
 # ===============================
 FIREBASE_URL = st.secrets["firebase_database_url"]
 FIREBASE_AUTH = st.secrets["firebase_api_key"]
 
-
 # ===============================
 # Helper functions
 # ===============================
@@ -30,40 +29,44 @@ def firebase_put(path, data):
         return None
 
 
-# ===============================
-# SIDEBAR MENU
-# ===============================
-st.sidebar.title("SmartEdu System")
-menu = st.sidebar.selectbox("Select Mode", ["Quiz Creator", "Student Evaluation"])
+# ===================================================
+# GLOBAL LOGIN (applies to all roles)
+# ===================================================
+st.sidebar.title("🎓Professor Dashboard🎓")
 
+if "logged_in" not in st.session_state:
+    st.session_state.logged_in = False
 
-# ===============================
-# QUIZ CREATOR
-# ===============================
-if menu == "Quiz Creator":
+if not st.session_state.logged_in:
+    st.subheader("🔐 Login Required")
 
-    st.header("Quiz Creator Login")
+    username = st.text_input("Username")
+    password = st.text_input("Password", type="password")
 
-    # Session Login
-    if "creator_login" not in st.session_state:
-        st.session_state.creator_login = False
+    if st.button("Login"):
+        if username == "master" and password == "master":
+            st.session_state.logged_in = True
+            st.success("Login successful!")
+            st.rerun()
+        else:
+            st.error("Incorrect username or password")
 
-    if not st.session_state.creator_login:
-        usr = st.text_input("Username")
-        pwd = st.text_input("Password", type="password")
+    st.stop()  # stop everything until login is completed
 
-        if st.button("Login"):
-            if usr == "master" and pwd == "master":
-                st.session_state.creator_login = True
-                st.success("Login successful!")
-                st.rerun()
-            else:
-                st.error("Wrong username or password")
 
-        st.stop()
+# ===================================================
+# After login → Show menu
+# ===================================================
+menu = st.sidebar.selectbox("Select Mode", ["Professor Panel", "Student Evaluation"])
 
-    # After login
-    st.success("You are logged in as Quiz Creator")
+
+# ===================================================
+# PROFESSOR PANEL (Quiz Creator)
+# ===================================================
+if menu == "Professor Panel":
+
+    st.header("🏫Professor Panel🏫")
+    st.success("You are logged in as Professor")
     st.subheader("Create New Quiz")
 
     quiz_name = st.text_input("Quiz Name (Example: Quiz1)")
@@ -73,16 +76,16 @@ if menu == "Quiz Creator":
     for i in range(1, 11):
         st.markdown(f"### Question {i}")
 
-        q_text = st.text_input(f"Nội dung câu hỏi {i}", key=f"q{i}")
+        q_text = st.text_input(f"Question content {i}", key=f"q{i}")
 
         options = []
         for j in range(1, 5):
-            opt = st.text_input(f"Đáp án {j}", key=f"q{i}_opt{j}")
+            opt = st.text_input(f"Option {j}", key=f"q{i}_opt{j}")
             options.append(opt)
 
         # Correct answer chosen by TEXT
         correct = st.selectbox(
-            f"Đáp án đúng của câu {i} (chọn theo text)",
+            f"Correct answer for Question {i} (select by text)",
             options,
             key=f"q{i}_correct"
         )
@@ -97,25 +100,25 @@ if menu == "Quiz Creator":
         valid = all(q["question"] and all(q["options"]) for q in questions)
 
         if not quiz_name:
-            st.error("Quiz name required!")
+            st.error("Quiz name is required!")
 
         elif not valid:
-            st.error("Fill all questions and answers!")
+            st.error("Please complete all questions and answers!")
 
         else:
             firebase_put(f"master_quizzes/{quiz_name}", {"questions": questions})
             st.success(f"Quiz '{quiz_name}' saved successfully!")
 
 
-# ===============================
+# ===================================================
 # STUDENT EVALUATION
-# ===============================
+# ===================================================
 elif menu == "Student Evaluation":
 
-    st.header("Student Evaluation")
+    st.header("📊Student Evaluation📊")
 
-    # -------- Refresh Button --------
-    if st.button("🔄 Refresh Data"):
+    # Refresh button
+    if st.button("🌀Refresh Data🌀"):
         st.cache_data.clear()
         st.rerun()
 
@@ -126,20 +129,19 @@ elif menu == "Student Evaluation":
         st.warning("No student data found.")
         st.stop()
 
-    # List of student IDs
     student_ids = list(students.keys())
-
     selected_id = st.selectbox("Select Student ID", student_ids)
+
     info = students[selected_id]
 
     st.subheader("Student Information")
     st.write(f"**Name:** {info.get('Name', '')}")
     st.write(f"**Class:** {info.get('Class', '')}")
 
-    # Find quiz keys
+    # Identify quizzes
     quiz_keys = [k for k in info.keys() if k.startswith("Quiz")]
 
-    # ---- Table Overview ----
+    # Show overview table
     table_data = []
     for q in quiz_keys:
         qd = info[q]
@@ -156,24 +158,23 @@ elif menu == "Student Evaluation":
             "Feedbacked": fb_status
         })
 
-    st.subheader("Quiz Overview Table")
+    st.subheader("Quiz Overview")
     df = pd.DataFrame(table_data)
     st.dataframe(df, use_container_width=True)
 
-    # ----- FEEDBACK SECTION -----
-    st.subheader("Feedback")
+    # Feedback section
+    st.subheader("Provide Feedback")
 
-    choose_quiz = st.selectbox("Select quiz to feedback", quiz_keys)
+    choose_quiz = st.selectbox("Select a quiz to give feedback", quiz_keys)
     selected_quiz_data = info[choose_quiz]
 
-    # Show existing feedback
     existing_fb = selected_quiz_data.get("Feedback", "")
     if existing_fb:
-        st.info(f"📌 Existing feedback:\n\n{existing_fb}")
+        st.info(f"📌 Existing Feedback:\n\n{existing_fb}")
 
     feedback = st.text_area("Enter new feedback")
 
     if st.button("Send Feedback"):
         firebase_put(f"student_quizzes/{selected_id}/{choose_quiz}/Feedback", feedback)
         st.success("Feedback sent successfully!")
-        st.rerun()
+        st.rerun()