Upload 176 files

README.md

@@ -194,6 +194,35 @@ UI update (2025-11-03): No‑Contact controls
 - Added a single, visible primary toggle alongside the "Upravit začátek" and "Nastavit na teď" actions. The primary toggle uses the canonical `noContact.startISO` state as the single source of truth and shows the labels "Zahájení Bez Kontaktu" (inactive) / "Ukončit Bez kontaktu" (active).
 - This change reduces duplicated controls, simplifies the interaction surface, and makes the No‑Contact flow deterministic (optimistic UI updates remain in handlers).
 
+### Localization sweep (2025-11-10)
+
+- Performed a repo-wide localization sweep to fix runtime i18n issues and make UI texts update immediately when the user switches language.
+- Key fixes applied:
+	- Moved `LocaleProvider` to `frontend/src/main.tsx` so `useLocale()` / `useTranslation()` are available at app mount time (fixes "useLocale must be used within a LocaleProvider").
+	- Removed module-level calls to `t()` and moved translation-dependent constants into component scope (fixes "t is not defined" runtime errors).
+	- Ensured memoized values that depend on translated text include `locale` in their dependency arrays (notably `App.activeTab`, `ProfileView.loadSummary`, `AttachmentView.allQuestions`).
+	- Attachment content flow: `AttachmentView` displays per-locale content fields as-is (content buckets are localized) and keeps `locale` in memo deps; `AttachmentStylesView` now requests `/api/content/attachment_styles?locale={locale}` so content refetches when language changes.
+	- Added English activities content (`content/activities.en.json`) and updated `ActivitiesView` to load locale-appropriate content buckets.
+- Build: frontend production build succeeded after the sweep and produced `dist/` assets.
+
+## Recent developer updates (2025-11-10)
+
+- Persistence & store reliability: several frontend stores (chat, journal, noContact and related loaders) were updated to await IndexedDB writes (`idbSet`) and to log failures. This reduces race conditions where writes could be lost during reloads or app shutdown. Loaders (`loadMedals`, `loadCompletedActions`, `loadNoContact`) now include diagnostic logs to help reproduce persistence issues.
+
+- Activity logging consistency: `activityLogger` usage has been consolidated in places to ensure store-first writes are completed before emitting assistant/journal messages. Helpers now await persistence and medal checks to avoid race conditions.
+
+- Translation helper update: `frontend/src/lib/strings.ts` was updated 
+
+- Tests & typing: Unit-tests were updated to reflect corrected store shapes and keys (for example `medals` and `completedActions`). A small typing fix in `frontend/tests/unit.test.ts` resolves a TS2339 complaint related to a test mock shape.
+
+- Server SPA cache: the backend serving logic was tuned to serve `index.html` with a no-cache policy so clients revalidate the HTML (avoids HF Spaces / CDN stale-hashed-asset 404s when deploys remove old hashed assets).
+
+These developer-facing changes were made to make debugging persistence and localization issues easier. See `docs/lessons-learned.md` for guidance on interpreting the new diagnostic logs and on the recommended store-first logging pattern.
+
+Next recommended steps:
+- Run the runtime QA flow (start backend + frontend/dev server and verify header, tabs, Activities, Attachment and Profile update immediately on language switch).
+- Optionally run a full automated patch to add `locale` to remaining memo/callback deps across the codebase; this is low-risk but touches many files and should be validated by the test suite.
+
 UI & chat updates (2025-11-03):
 - Chat message metadata: chat messages now carry optional `meta` (for example `{ type: 'medal', medal: 'První krok' }`) so the frontend can render special visual variants for high-value events (medals, assessment results, no-contact milestones).
 - Medal visuals & divider: the frontend renders a small medal badge/divider and a distinct `.chat-bubble.medal` style for earned medals to make them immediately visible and celebratory.

app.py

@@ -34,13 +34,18 @@ def create_app() -> FastAPI:
     app.include_router(user_state_router)
     app.include_router(sse_router)
 
-    # Mount static assets if available
+    # Mount static assets if available (serve hashed assets under /assets)
     if os.path.exists(ASSETS_DIR):
         app.mount("/assets", StaticFiles(directory=ASSETS_DIR), name="assets")
 
-    # Mount the built SPA at root as a fallback for non-API routes
-    if os.path.exists(DIST_DIR):
-        app.mount("/", StaticFiles(directory=DIST_DIR, html=True), name="spa")
+    # Serve the SPA index.html as a controlled fallback for non-API routes.
+    # We intentionally do NOT mount the whole `dist` directory at `/` because
+    # StaticFiles would serve `index.html` without custom cache headers. To
+    # avoid clients reusing stale `index.html` (which can reference old hashed
+    # asset filenames that no longer exist and cause 404s), we return
+    # `index.html` via an explicit fallback route with Cache-Control: no-cache
+    # so browsers revalidate and fetch the latest HTML after a deploy.
+    # Note: individual hashed assets under /assets can be cached long-term.
 
     return app
 
@@ -60,7 +65,24 @@ def favicon():
 def index():
     path = os.path.join(DIST_DIR, "index.html")
     if os.path.exists(path):
-        return FileResponse(path)
+        # Serve index.html with headers that prevent long-lived caching of the
+        # HTML itself. This ensures clients revalidate the page when we deploy
+        # a new build (and prevents requests for old hashed asset names).
+        return FileResponse(path, headers={"Cache-Control": "no-cache, no-store, must-revalidate"})
+    raise HTTPException(status_code=404, detail="index.html not found")
+
+
+@app.get("/{full_path:path}", include_in_schema=False)
+def spa_fallback(full_path: str):
+    """Fallback for SPA routes: return index.html with no-cache headers.
+
+    This lets the frontend use client-side routing while ensuring the
+    HTML is revalidated after deploys, which prevents clients from trying to
+    fetch stale hashed asset filenames that no longer exist on disk.
+    """
+    path = os.path.join(DIST_DIR, "index.html")
+    if os.path.exists(path):
+        return FileResponse(path, headers={"Cache-Control": "no-cache, no-store, must-revalidate"})
     raise HTTPException(status_code=404, detail="index.html not found")
 
 

docs/lessons-learned.md

@@ -50,6 +50,31 @@ const message = t('logger.activity_completed', locale, { activity: activityName
 
 ---
 
+## 2025-11-10: Persistence, tests & helper updates
+
+Short summary of recent developer fixes and guidance for future contributors:
+
+- Persistence writes now awaited: Several stores (`chat`, `journal`, `noContact`, and related save paths) were changed to update Zustand state first and then `await` the `idbSet(key, value)` call. This reduces lost-writes during reloads and shutdowns. When adding new stores, follow the pattern: update store → await persistence → emit assistant/journal messages.
+
+- Diagnostic load logging: `loadMedals()`, `loadCompletedActions()` and `loadNoContact()` include console logs to surface what is read from IndexedDB on startup. Use these logs when reproducing persistence issues.
+
+- ActivityLogger ordering: The atomic helper `emitAssistantAndJournalWithOptions` is the recommended API; make sure to await persistence operations before triggering medal checks or UI-only journal messages.
+
+- `t()` helper relaxed signature: To reduce widespread TS errors from varying call-sites, `frontend/src/lib/strings.ts` now supports calls like `t(key, vars?)` (locale defaults to `getLocale()`). Avoid calling `t()` at module scope; prefer within component render/effects.
+
+- Test updates: Unit tests were adjusted to match corrected store key names and shapes (for example `medals` and `completedActions`). When writing tests that mock stores, prefer explicit `any` typed mocks or properly shaped objects to avoid TypeScript `never` inference issues in mock expectations.
+
+Quick checklist when debugging persistence/localization issues:
+
+1. Inspect the browser console for `load*` logs produced by `loadMedals`, `loadCompletedActions`, and `loadNoContact` on app start.
+2. Ensure store writes use: `set(newState)` then `await idbSet(key, newState)` inside try/catch and log errors.
+3. If medals or counts appear missing after reload, confirm the keys used in `idbSet` exactly match keys used in loaders (`'medals'`, `'completedActions'`, `'noContact'`, `'chat'`, `'journal'`).
+4. Avoid calling `t()` at module top-level; keep translations inside components or effects and include `locale` in memo/deps when caching translated values.
+
+These notes were added after a targeted debugging and test-fix session on 2025-11-10. Keep them in mind when adding new stores or updating activity logging to prevent regressions.
+
+---
+
 ### SupportView t() Funkce Bez Locale
 
 **Problém:** `Uncaught ReferenceError: t is not defined` v SupportView.tsx - pole `RESOURCES` a `SUBTAB_LABELS` používaly funkci `t()` bez locale parametru na module level.

frontend/src/lib/strings.ts

@@ -1,5 +1,6 @@
 import cs from '../i18n/cs.json'
 import en from '../i18n/en.json'
+import { getLocale } from './locale'
 
 const bundles: Record<string, any> = {
   cs,
@@ -16,7 +17,24 @@ function lookup(key: string, bundle: any) {
   return cur
 }
 
-export function t(key: string, locale: string, vars?: Record<string, string | number>) {
+/**
+ * Translation helper.
+ * Supports two calling styles:
+ *   t(key, locale?, vars?)
+ *   t(key, vars?) // uses stored locale
+ */
+export function t(key: string, localeOrVars?: string | Record<string, string | number>, maybeVars?: Record<string, string | number>) {
+  let locale: string
+  let vars: Record<string, string | number> | undefined
+
+  if (typeof localeOrVars === 'string') {
+    locale = localeOrVars
+    vars = maybeVars
+  } else {
+    locale = getLocale()
+    vars = localeOrVars as Record<string, string | number> | undefined
+  }
+
   const bundle = bundles[locale] || bundles['cs']
   let str = lookup(key, bundle) || lookup(key, bundles['cs']) || key
   if (vars) {

frontend/src/state/modules/chat.ts

@@ -7,32 +7,40 @@ export const useChat = create<{ chat: Msg[]; push: (m:Msg)=>void; appendToken: (
   chat: [],
   push: async (m)=> {
     const withTs = { ...m, ts: m.ts || new Date().toISOString() }
-    set(s=>{ const newChat = [...s.chat, withTs]; idbSet('chat', newChat); return { chat: newChat } })
+    const newChat = get().chat.concat([withTs])
+    // Update state immediately for responsive UI
+    set({ chat: newChat })
+    try {
+      await idbSet('chat', newChat)
+    } catch (err) {
+      console.error('Error persisting chat push:', err)
+    }
     // REMOVED: checkAndLogMedals(['chat']) - causes infinite recursion when called from logMedalEarned
     // Medal checks should be explicit in activityLogger functions, not on every chat push
   },
-  appendToken: async (t)=> set(s=>{
-    const chat = s.chat.slice(); const last = chat[chat.length-1];
-    if(!last || last.role!=='assistant'){ chat.push({role:'assistant', content:t, ts: new Date().toISOString()}) } else { last.content += t }
-    idbSet('chat', chat);
-    return { chat }
-  }),
-  appendAgentToken: async (agent, token) => set(s=>{
-    const chat = s.chat.slice(); const last = chat[chat.length-1];
-    // Keep continuity: if the last message is from assistant, append tokens to it
-    // regardless of which agent emitted them. Only create a new assistant message
-    // when the last message is not an assistant message.
+  appendToken: async (t)=> {
+    const chat = get().chat.slice()
+    const last = chat[chat.length-1]
+    if(!last || last.role!=='assistant'){
+      chat.push({role:'assistant', content:t, ts: new Date().toISOString()})
+    } else {
+      last.content += t
+    }
+    set({ chat })
+    try { await idbSet('chat', chat) } catch (err) { console.error('Error persisting chat appendToken:', err) }
+  },
+  appendAgentToken: async (agent, token) => {
+    const chat = get().chat.slice()
+    const last = chat[chat.length-1]
     if (!last || last.role !== 'assistant') {
       chat.push({ role: 'assistant', content: token, agent, ts: new Date().toISOString() })
     } else {
-      // Append token to existing assistant bubble. If agent metadata wasn't set,
-      // set it to the first agent that contributed to this bubble.
       last.content += token
       if (!last.agent) last.agent = agent
     }
-    idbSet('chat', chat);
-    return { chat }
-  })
+    set({ chat })
+    try { await idbSet('chat', chat) } catch (err) { console.error('Error persisting chat appendAgentToken:', err) }
+  }
 }))
 
 // Načtení chat historie z IndexedDB při inicializaci

frontend/src/state/modules/completedActions.ts

@@ -52,6 +52,7 @@ export const useCompletedActions = create<CompletedActionsStore>((set, get) => (
 // Load completed actions from IndexedDB on init
 export async function loadCompletedActions() {
   const saved = await idbGet('completedActions')
+  console.log('loadCompletedActions: read from IndexedDB ->', saved)
   if (saved && Array.isArray(saved)) {
     useCompletedActions.setState({ actions: saved })
   }

frontend/src/state/modules/journal.ts

@@ -8,11 +8,13 @@ export const useJournal = create<{ journal: JournalEntry[]; addJournal: (text:st
   journal: [],
   addJournal: async (text, meta)=> {
     const entry = { id: String(Date.now()), ts: new Date().toISOString(), text, meta };
-    set(s => {
-      const newJournal = [...s.journal, entry];
-      idbSet('journal', newJournal);
-      return { journal: newJournal }
-    })
+    const newJournal = get().journal.concat([entry])
+    set({ journal: newJournal })
+    try {
+      await idbSet('journal', newJournal)
+    } catch (err) {
+      console.error('Error persisting journal entry:', err)
+    }
     // Check for journal-related medals (like "3 deníkové zápisy")
     await checkAndLogMedals(['journal'])
     // Recompute user stage after journaling (affects phase detection)

frontend/src/state/modules/medal.ts

@@ -43,6 +43,7 @@ export const useMedal = create<MedalStore>((set, get) => ({
 // Load medals from IndexedDB on init
 export async function loadMedals() {
   const saved = await idbGet('medals')
+  console.log('loadMedals: read from IndexedDB ->', saved)
   if (saved && Array.isArray(saved)) {
     useMedal.setState({ medals: saved })
   }

frontend/src/state/modules/noContact.ts

@@ -9,7 +9,14 @@ export const useNoContact = create<{ noContact: NoContact; startNoContact: ()=>v
   noContact: { startISO: null, lastPraiseISO: null, reasons: [] },
   startNoContact: async ()=> {
     const now = new Date().toISOString()
-    set(s=>{ const newState = {...s.noContact, startISO: now, lastPraiseISO: now}; idbSet('noContact', newState); return { noContact: newState } })
+    const newState = { startISO: now, lastPraiseISO: now, reasons: get().noContact.reasons }
+    // Update state first, then persist and await to ensure the write completes
+    set({ noContact: newState })
+    try {
+      await idbSet('noContact', newState)
+    } catch (err) {
+      console.error('Error persisting noContact start:', err)
+    }
     // Log milestone - always show start message
     const { logNoContactMilestone } = await import('../../lib/activityLogger')
     await logNoContactMilestone(0, true)  // isStart = true, days = 0 for start message
@@ -18,23 +25,40 @@ export const useNoContact = create<{ noContact: NoContact; startNoContact: ()=>v
   resetNoContact: async ()=> {
     const newState = { startISO:null, lastPraiseISO:null, reasons: [] };
     set({ noContact: newState });
-    await idbSet('noContact', newState);
+    try {
+      await idbSet('noContact', newState);
+    } catch (err) {
+      console.error('Error persisting noContact reset:', err)
+    }
     // Log reset milestone
     const { logNoContactMilestone } = await import('../../lib/activityLogger')
     await logNoContactMilestone(0, false)  // isStart = false for reset message
     try { await recomputeStage() } catch (e) { /* ignore */ }
   },
   updateLastPraise: async (iso: string)=> {
-    set(s=>{ const newState = {...s.noContact, lastPraiseISO: iso}; idbSet('noContact', newState); return { noContact: newState } })
+    const newState = { ...get().noContact, lastPraiseISO: iso }
+    set({ noContact: newState })
+    try {
+      await idbSet('noContact', newState)
+    } catch (err) {
+      console.error('Error persisting noContact lastPraise update:', err)
+    }
   },
   updateReasons: async (reasons: string[])=> {
-    set(s=>{ const newState = {...s.noContact, reasons}; idbSet('noContact', newState); return { noContact: newState } })
+    const newState = { ...get().noContact, reasons }
+    set({ noContact: newState })
+    try {
+      await idbSet('noContact', newState)
+    } catch (err) {
+      console.error('Error persisting noContact reasons update:', err)
+    }
   }
 }))
 
 // Načtení noContact stavu z IndexedDB při inicializaci
 export async function loadNoContact() {
   const saved = await idbGet('noContact')
+  console.log('loadNoContact: read from IndexedDB ->', saved)
   if (saved && typeof saved === 'object' && 'startISO' in saved) {
     useNoContact.setState({ noContact: {
       startISO: saved.startISO || null,

frontend/src/views/ProfileView.tsx

@@ -293,12 +293,14 @@ export default function ProfileView({ accent }: Props) {
 
       console.log('Step 2: Deleting IndexedDB data...')
       // Smazat všechna data z IndexedDB
+      // Note: keys must match those used by the stores (medals, completedActions, noContact, profile, chat, journal, last_active_tab)
       await Promise.all([
         idbDel('profile'),
         idbDel('chat'),
         idbDel('journal'),
         idbDel('noContact'),
-        idbDel('medal'),
+        idbDel('medals'),
+        idbDel('completedActions'),
         idbDel('last_active_tab')
         // onboarding_completed is no longer used
       ])

frontend/tests/unit.test.ts

@@ -829,7 +829,7 @@ describe('Unit tests', () => {
       const mockUseChatSetState = vi.fn()
       const mockUseJournalSetState = vi.fn()
       const mockUseNoContactSetState = vi.fn()
-      const mockUseMedalSetState = vi.fn()
+  const mockUseMedalSetState: any = vi.fn()
 
       // Mock window.location.reload
       const mockReload = vi.fn()
@@ -879,7 +879,8 @@ describe('Unit tests', () => {
           mockIdbDel('chat'),
           mockIdbDel('journal'),
           mockIdbDel('noContact'),
-          mockIdbDel('medal'),
+          mockIdbDel('medals'),
+          mockIdbDel('completedActions'),
           mockIdbDel('last_active_tab')
         ])
         console.log('Data deleted from IndexedDB')
@@ -889,7 +890,7 @@ describe('Unit tests', () => {
         mockUseChatSetState({ chat: [] })
         mockUseJournalSetState({ journal: [] })
         mockUseNoContactSetState({ noContact: { startISO: null, lastPraiseISO: null } })
-        mockUseMedalSetState({ medal: null })
+  mockUseMedalSetState({ medals: [] })
         console.log('Zustand reset, reloading page...')
 
         // Reload stránky pro čistý start
@@ -899,12 +900,13 @@ describe('Unit tests', () => {
       await handleForget()
 
       // Verify all IndexedDB keys were deleted (except onboarding_completed which is no longer used)
-      expect(mockIdbDel).toHaveBeenCalledWith('profile')
-      expect(mockIdbDel).toHaveBeenCalledWith('chat')
-      expect(mockIdbDel).toHaveBeenCalledWith('journal')
-      expect(mockIdbDel).toHaveBeenCalledWith('noContact')
-      expect(mockIdbDel).toHaveBeenCalledWith('medal')
-      expect(mockIdbDel).toHaveBeenCalledWith('last_active_tab')
+  expect(mockIdbDel).toHaveBeenCalledWith('profile')
+  expect(mockIdbDel).toHaveBeenCalledWith('chat')
+  expect(mockIdbDel).toHaveBeenCalledWith('journal')
+  expect(mockIdbDel).toHaveBeenCalledWith('noContact')
+  expect(mockIdbDel).toHaveBeenCalledWith('medals')
+  expect(mockIdbDel).toHaveBeenCalledWith('completedActions')
+  expect(mockIdbDel).toHaveBeenCalledWith('last_active_tab')
       // onboarding_completed is no longer used, so should not be called
       expect(mockIdbDel).not.toHaveBeenCalledWith('onboarding_completed')
 
@@ -913,7 +915,7 @@ describe('Unit tests', () => {
       expect(mockUseChatSetState).toHaveBeenCalledWith({ chat: [] })
       expect(mockUseJournalSetState).toHaveBeenCalledWith({ journal: [] })
       expect(mockUseNoContactSetState).toHaveBeenCalledWith({ noContact: { startISO: null, lastPraiseISO: null } })
-      expect(mockUseMedalSetState).toHaveBeenCalledWith({ medal: null })
+  expect(mockUseMedalSetState).toHaveBeenCalledWith({ medals: [] } as any)
 
       // Verify page reload was called
       expect(mockReload).toHaveBeenCalled()