File size: 5,704 Bytes
e03e963 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 | <?php
/**
* Matomo - free/libre analytics platform
*
* @link https://matomo.org
* @license https://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
*/
namespace Piwik\Plugins\CoreUpdater\tests\Integration;
use Piwik\Config;
use Piwik\Nonce;
use Piwik\Plugins\CoreUpdater\Controller;
use Piwik\Plugins\CoreUpdater\Updater;
use Piwik\Tests\Framework\Mock\FakeAccess;
use Piwik\Tests\Framework\TestCase\IntegrationTestCase;
/**
* @group Plugins
* @group CoreUpdater
*/
class ControllerTest extends IntegrationTestCase
{
private $originalGet = [];
private $originalPost = [];
private $originalEnableAutoUpdate;
private $originalEnableInternetFeatures;
private $originalUpdateDetailsToken;
private $hadEnableAutoUpdate = false;
private $hadEnableInternetFeatures = false;
private $hadUpdateDetailsToken = false;
public function setUp(): void
{
parent::setUp();
$this->originalGet = $_GET;
$this->originalPost = $_POST;
$general = Config::getInstance()->General;
$this->hadEnableAutoUpdate = array_key_exists('enable_auto_update', $general);
$this->hadEnableInternetFeatures = array_key_exists('enable_internet_features', $general);
$this->hadUpdateDetailsToken = array_key_exists('update_details_token', $general);
$this->originalEnableAutoUpdate = $general['enable_auto_update'] ?? null;
$this->originalEnableInternetFeatures = $general['enable_internet_features'] ?? null;
$this->originalUpdateDetailsToken = $general['update_details_token'] ?? null;
Config::getInstance()->General['enable_auto_update'] = 1;
Config::getInstance()->General['enable_internet_features'] = 1;
}
public function tearDown(): void
{
$_GET = $this->originalGet;
$_POST = $this->originalPost;
FakeAccess::clearAccess();
$config = Config::getInstance();
if ($this->hadEnableAutoUpdate) {
$config->General['enable_auto_update'] = $this->originalEnableAutoUpdate;
} else {
unset($config->General['enable_auto_update']);
}
if ($this->hadEnableInternetFeatures) {
$config->General['enable_internet_features'] = $this->originalEnableInternetFeatures;
} else {
unset($config->General['enable_internet_features']);
}
if ($this->hadUpdateDetailsToken) {
$config->General['update_details_token'] = $this->originalUpdateDetailsToken;
} else {
unset($config->General['update_details_token']);
}
$config->forceSave();
parent::tearDown();
}
public function testOneClickResultsDoesNotCreateOrExposeTokenForAnonymousRequest()
{
FakeAccess::clearAccess(false);
unset(Config::getInstance()->General['update_details_token']);
$_GET = [];
$_POST = [];
$result = $this->buildController()->oneClickResults();
self::assertStringNotContainsString('updateDetailsToken=', $result);
self::assertEmpty(Config::getInstance()->General['update_details_token'] ?? null);
}
public function testOneClickResultsOnlyExposesStoredTokenForSuperUserContext()
{
$token = '1234567890abcdef1234567890abcdef';
Config::getInstance()->General['update_details_token'] = $token;
Config::getInstance()->forceSave();
$_GET = [];
$_POST = [];
FakeAccess::clearAccess(true);
$superUserResult = $this->buildController()->oneClickResults();
self::assertStringContainsString('updateDetailsToken=' . urlencode($token), $superUserResult);
FakeAccess::clearAccess(false);
$anonymousResult = $this->buildController()->oneClickResults();
self::assertStringNotContainsString('updateDetailsToken=' . urlencode($token), $anonymousResult);
}
public function testOneClickResultsCreatesAndExposesTokenForSuperUserWhenMissing()
{
FakeAccess::clearAccess(true);
unset(Config::getInstance()->General['update_details_token']);
$_GET = [];
$_POST = [];
$result = $this->buildController()->oneClickResults();
$createdToken = Config::getInstance()->General['update_details_token'] ?? null;
self::assertNotEmpty($createdToken);
self::assertStringContainsString('updateDetailsToken=' . urlencode($createdToken), $result);
}
public function testOneClickUpdateRotatesStoredUpdateDetailsTokenAfterSuccessfulUpdate()
{
FakeAccess::clearAccess(true);
Config::getInstance()->General['update_details_token'] = 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa';
$_GET = [];
$_POST = [];
$_GET['nonce'] = Nonce::getNonce('oneClickUpdate');
ob_start();
try {
$this->buildController()->oneClickUpdate();
$output = ob_get_clean();
} catch (\Throwable $e) {
ob_end_clean();
throw $e;
}
$rotatedToken = Config::getInstance()->General['update_details_token'] ?? '';
self::assertStringContainsString('action=oneClickResults', $output);
self::assertNotSame('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa', $rotatedToken);
self::assertSame(1, preg_match('/^[a-f0-9]{32}$/', $rotatedToken));
}
public function provideContainerConfig()
{
return array(
'Piwik\Access' => new FakeAccess(),
);
}
private function buildController(): Controller
{
$updater = $this->createMock(Updater::class);
$updater->method('updatePiwik')->willReturn(array());
return new Controller($updater);
}
}
|