Mike0021 commited on
Commit
44728ba
·
verified ·
1 Parent(s): c27af77

Sidebar: New button spaced by its ink

Browse files
Files changed (1) hide show
  1. piweb/hf-design.patch +26 -15
piweb/hf-design.patch CHANGED
@@ -9991,7 +9991,7 @@ index 737e7a5..c098317 100644
9991
 
9992
  .sidebar-sheet .sidebar-menu-question-text {
9993
  diff --git a/app/sidebar.css b/app/sidebar.css
9994
- index 0b8f66a..d805083 100644
9995
  --- a/app/sidebar.css
9996
  +++ b/app/sidebar.css
9997
  @@ -91,8 +91,9 @@
@@ -10572,7 +10572,18 @@ index 0b8f66a..d805083 100644
10572
  }
10573
 
10574
  .sidebar-header-spacer {
10575
- @@ -1061,7 +1118,7 @@ a.session-tree-main {
 
 
 
 
 
 
 
 
 
 
 
10576
  }
10577
 
10578
  .sidebar-search-toggle {
@@ -10581,7 +10592,7 @@ index 0b8f66a..d805083 100644
10581
  padding: 0;
10582
  }
10583
 
10584
- @@ -1076,7 +1133,7 @@ a.session-tree-main {
10585
  label is still each one's name. */
10586
  .sidebar-header[data-fit="1"] .sidebar-new-button,
10587
  .sidebar-header[data-fit="2"] .sidebar-new-button {
@@ -10590,7 +10601,7 @@ index 0b8f66a..d805083 100644
10590
  padding: 0;
10591
  }
10592
 
10593
- @@ -1088,6 +1145,11 @@ a.session-tree-main {
10594
  font-size: 11px;
10595
  }
10596
 
@@ -10602,7 +10613,7 @@ index 0b8f66a..d805083 100644
10602
  .sidebar-header[data-fit="1"] .sidebar-new-label,
10603
  .sidebar-header[data-fit="2"] .sidebar-new-label,
10604
  .sidebar-header[data-fit="2"] .sidebar-tab-label {
10605
- @@ -1106,8 +1168,9 @@ a.session-tree-main {
10606
  .sidebar-archive-menu-button:focus-visible,
10607
  .sidebar-tool-button:focus-visible,
10608
  .sidebar-files-section-toggle:focus-visible {
@@ -10614,7 +10625,7 @@ index 0b8f66a..d805083 100644
10614
  }
10615
 
10616
  .sidebar-panel {
10617
- @@ -1186,7 +1249,7 @@ a.session-tree-main {
10618
  the root too), and its time 4px inside the row. The header row's keys and
10619
  the picker's boxes end there. */
10620
  .session-sidebar.is-files-below {
@@ -10623,7 +10634,7 @@ index 0b8f66a..d805083 100644
10623
  }
10624
 
10625
  /* The files section's header row (files below the sessions only), one row
10626
- @@ -1230,7 +1293,7 @@ a.session-tree-main {
10627
  padding: 0 5px;
10628
  overflow: hidden;
10629
  border: 0;
@@ -10632,7 +10643,7 @@ index 0b8f66a..d805083 100644
10632
  background: transparent;
10633
  color: var(--text-muted);
10634
  font: inherit;
10635
- @@ -1256,10 +1319,8 @@ a.session-tree-main {
10636
  .sidebar-files-section-label {
10637
  min-width: 0;
10638
  overflow: hidden;
@@ -10644,7 +10655,7 @@ index 0b8f66a..d805083 100644
10644
  }
10645
 
10646
  /* The changed files' count, as the pinned section's (.session-tree-pinned-count). */
10647
- @@ -1278,7 +1339,7 @@ a.session-tree-main {
10648
  display: flex;
10649
  flex: 1000 0 calc(7 * 18px);
10650
  align-items: center;
@@ -10653,7 +10664,7 @@ index 0b8f66a..d805083 100644
10653
  }
10654
 
10655
  /* The section's keys: the files tab's square keys, a step under the row's
10656
- @@ -1286,9 +1347,9 @@ a.session-tree-main {
10657
  .sidebar-files-keys .sidebar-tool-button {
10658
  flex: 1 1 0;
10659
  min-width: 18px;
@@ -10666,7 +10677,7 @@ index 0b8f66a..d805083 100644
10666
  }
10667
 
10668
  /* Under that row (or the whole files tab): the head, then the tree filling
10669
- @@ -1301,31 +1362,7 @@ a.session-tree-main {
10670
  min-height: 0;
10671
  }
10672
 
@@ -10699,7 +10710,7 @@ index 0b8f66a..d805083 100644
10699
  slides in over the tree, which stays mounted under it (hidden once the
10700
  archive is in), and away again. SessionTree fills each. */
10701
  .sidebar-sessions-views {
10702
- @@ -1397,7 +1434,7 @@ a.session-tree-main {
10703
  height: 26px;
10704
  padding: 0 6px;
10705
  border: 0;
@@ -10708,7 +10719,7 @@ index 0b8f66a..d805083 100644
10708
  background: transparent;
10709
  color: var(--text-muted);
10710
  font-size: 12px;
10711
- @@ -1485,10 +1522,11 @@ a.session-tree-main {
10712
  six (the changes view is disabled, not gone, without changes), so nothing
10713
  moves as the count flips. At the sidebar's 180px minimum they give way
10714
  together, down to 21px wide, and the gap before the views closes. */
@@ -10721,7 +10732,7 @@ index 0b8f66a..d805083 100644
10721
  margin-top: 4px;
10722
  }
10723
 
10724
- @@ -1498,17 +1536,18 @@ a.session-tree-main {
10725
  margin-left: auto;
10726
  }
10727
 
@@ -10745,7 +10756,7 @@ index 0b8f66a..d805083 100644
10745
  background: transparent;
10746
  color: var(--text-dim);
10747
  cursor: pointer;
10748
- @@ -1516,8 +1555,8 @@ a.session-tree-main {
10749
  }
10750
 
10751
  .sidebar-tool-button:not(:disabled):hover {
 
9991
 
9992
  .sidebar-sheet .sidebar-menu-question-text {
9993
  diff --git a/app/sidebar.css b/app/sidebar.css
9994
+ index 0b8f66a..9a60b64 100644
9995
  --- a/app/sidebar.css
9996
  +++ b/app/sidebar.css
9997
  @@ -91,8 +91,9 @@
 
10572
  }
10573
 
10574
  .sidebar-header-spacer {
10575
+ @@ -1056,12 +1113,18 @@ a.session-tree-main {
10576
+ min-width: 0;
10577
+ }
10578
+
10579
+ +/* Spaced by ink, not boxes: Carbon's plus draws the middle 6px of its 12px box, and "N"
10580
+ + sits 1.5px into its own. The plus's ink starts about 8.6px from the left, as the label's
10581
+ + ends from the right (within a device pixel at 4x), and they are 6.5px apart: our
10582
+ + buttons' icon-to-label space (the composer's mode button). */
10583
+ .sidebar-new-button {
10584
+ + gap: 2px;
10585
+ + padding: 0 9px 0 6px;
10586
+ font-weight: 500;
10587
  }
10588
 
10589
  .sidebar-search-toggle {
 
10592
  padding: 0;
10593
  }
10594
 
10595
+ @@ -1076,7 +1139,7 @@ a.session-tree-main {
10596
  label is still each one's name. */
10597
  .sidebar-header[data-fit="1"] .sidebar-new-button,
10598
  .sidebar-header[data-fit="2"] .sidebar-new-button {
 
10601
  padding: 0;
10602
  }
10603
 
10604
+ @@ -1088,6 +1151,11 @@ a.session-tree-main {
10605
  font-size: 11px;
10606
  }
10607
 
 
10613
  .sidebar-header[data-fit="1"] .sidebar-new-label,
10614
  .sidebar-header[data-fit="2"] .sidebar-new-label,
10615
  .sidebar-header[data-fit="2"] .sidebar-tab-label {
10616
+ @@ -1106,8 +1174,9 @@ a.session-tree-main {
10617
  .sidebar-archive-menu-button:focus-visible,
10618
  .sidebar-tool-button:focus-visible,
10619
  .sidebar-files-section-toggle:focus-visible {
 
10625
  }
10626
 
10627
  .sidebar-panel {
10628
+ @@ -1186,7 +1255,7 @@ a.session-tree-main {
10629
  the root too), and its time 4px inside the row. The header row's keys and
10630
  the picker's boxes end there. */
10631
  .session-sidebar.is-files-below {
 
10634
  }
10635
 
10636
  /* The files section's header row (files below the sessions only), one row
10637
+ @@ -1230,7 +1299,7 @@ a.session-tree-main {
10638
  padding: 0 5px;
10639
  overflow: hidden;
10640
  border: 0;
 
10643
  background: transparent;
10644
  color: var(--text-muted);
10645
  font: inherit;
10646
+ @@ -1256,10 +1325,8 @@ a.session-tree-main {
10647
  .sidebar-files-section-label {
10648
  min-width: 0;
10649
  overflow: hidden;
 
10655
  }
10656
 
10657
  /* The changed files' count, as the pinned section's (.session-tree-pinned-count). */
10658
+ @@ -1278,7 +1345,7 @@ a.session-tree-main {
10659
  display: flex;
10660
  flex: 1000 0 calc(7 * 18px);
10661
  align-items: center;
 
10664
  }
10665
 
10666
  /* The section's keys: the files tab's square keys, a step under the row's
10667
+ @@ -1286,9 +1353,9 @@ a.session-tree-main {
10668
  .sidebar-files-keys .sidebar-tool-button {
10669
  flex: 1 1 0;
10670
  min-width: 18px;
 
10677
  }
10678
 
10679
  /* Under that row (or the whole files tab): the head, then the tree filling
10680
+ @@ -1301,31 +1368,7 @@ a.session-tree-main {
10681
  min-height: 0;
10682
  }
10683
 
 
10710
  slides in over the tree, which stays mounted under it (hidden once the
10711
  archive is in), and away again. SessionTree fills each. */
10712
  .sidebar-sessions-views {
10713
+ @@ -1397,7 +1440,7 @@ a.session-tree-main {
10714
  height: 26px;
10715
  padding: 0 6px;
10716
  border: 0;
 
10719
  background: transparent;
10720
  color: var(--text-muted);
10721
  font-size: 12px;
10722
+ @@ -1485,10 +1528,11 @@ a.session-tree-main {
10723
  six (the changes view is disabled, not gone, without changes), so nothing
10724
  moves as the count flips. At the sidebar's 180px minimum they give way
10725
  together, down to 21px wide, and the gap before the views closes. */
 
10732
  margin-top: 4px;
10733
  }
10734
 
10735
+ @@ -1498,17 +1542,18 @@ a.session-tree-main {
10736
  margin-left: auto;
10737
  }
10738
 
 
10756
  background: transparent;
10757
  color: var(--text-dim);
10758
  cursor: pointer;
10759
+ @@ -1516,8 +1561,8 @@ a.session-tree-main {
10760
  }
10761
 
10762
  .sidebar-tool-button:not(:disabled):hover {