File size: 37,279 Bytes
5294c4d
4e19890
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
c6d182c
 
4e19890
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
8f5abd4
4e19890
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
5294c4d
 
4e19890
5294c4d
4e19890
 
 
 
 
 
 
 
 
 
 
 
 
 
5294c4d
 
 
4e19890
 
 
 
 
 
 
 
3403232
03c33a2
 
 
 
4e19890
3403232
4e19890
 
 
 
3403232
 
4e19890
3403232
4e19890
 
 
 
 
 
 
 
3403232
 
4e19890
 
 
 
 
 
 
 
 
 
3403232
 
4e19890
 
 
 
3403232
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
4e19890
 
3403232
 
 
4e19890
 
 
 
 
 
 
3403232
 
 
 
 
 
4e19890
3403232
4e19890
 
 
 
3403232
 
4e19890
 
 
 
 
 
 
3403232
4e19890
5294c4d
 
3403232
4e19890
3403232
4e19890
3403232
4e19890
 
 
 
 
 
 
 
 
 
 
3403232
 
 
 
 
 
 
 
 
4e19890
 
3403232
 
4e19890
3403232
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
4e19890
 
 
 
 
 
 
 
 
 
 
3403232
4e19890
5294c4d
4e19890
 
3403232
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
4e19890
 
 
 
3403232
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
4e19890
 
 
 
 
 
 
 
 
 
 
 
5294c4d
 
 
4e19890
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
5294c4d
4e19890
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
8f5abd4
 
 
 
 
 
 
 
 
 
b0b88cc
 
4e19890
 
 
 
 
 
 
 
 
 
 
 
 
 
5294c4d
4e19890
 
 
 
 
 
 
 
 
 
 
 
 
5294c4d
4e19890
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
5294c4d
4e19890
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
8f5abd4
 
 
4e19890
 
 
 
8f5abd4
b0b88cc
4e19890
 
 
 
 
 
 
 
 
 
 
 
 
8f5abd4
 
 
4e19890
 
 
 
8f5abd4
b0b88cc
4e19890
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
8f5abd4
 
 
 
 
4e19890
 
 
 
8f5abd4
b0b88cc
 
4e19890
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
c6d182c
 
 
 
 
 
 
 
 
4e19890
 
c6d182c
 
 
 
4e19890
c6d182c
 
 
4e19890
 
c6d182c
4e19890
c6d182c
 
 
 
 
 
 
 
4e19890
c6d182c
4e19890
 
c6d182c
 
 
 
 
 
 
4e19890
 
 
c6d182c
 
4e19890
c6d182c
 
4e19890
 
 
c6d182c
 
 
 
 
 
4e19890
c6d182c
4e19890
 
c6d182c
 
4e19890
 
 
c6d182c
 
 
 
 
 
4e19890
c6d182c
4e19890
 
c6d182c
4e19890
 
 
 
 
c6d182c
 
 
 
4e19890
c6d182c
4e19890
 
c6d182c
 
4e19890
 
 
c6d182c
 
 
 
4e19890
c6d182c
4e19890
 
c6d182c
4e19890
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
"""Extra coverage tests for animetix.api.core targeting branches not covered by
``test_core_coverage.py``.

Same pattern as the sibling file: neutralise permissions, drive views via
``RequestFactory`` + ``force_authenticate``, mock all I/O (services, adapters,
httpx, ``safe_http_request``). No false-green: every test asserts the status
code and, where meaningful, the JSON body / side effects.

Targets the previously-missing line ranges in core.py:
  93-96  (image_proxy generic exception -> 404)
  152-197 (MediaSearchView.post image-search flow)
  215-216 (GameSessionView.get)
  288-289 (RegisterView create_user exception -> 400)
  394-395 (TransparencyData positive_rate branch)
  504-510 (suwayomi_image_proxy non-200 / exception)
  552/583/652/696/703-705 (Suwayomi views: not-configured / exception)
  732-775 (FavoriteMangaToggleView auto-import path)
  MangaChapterSyncView : chapitre invalide, et poussée vers une liaison
  confirmée (écriture distante en échec, adaptateur qui lève)
"""

import base64
import json
from unittest.mock import MagicMock, patch

import pytest
from animetix.api.core import (
    FavoriteMangaToggleView,
    GameSessionView,
    MangaChapterSyncView,
    MediaSearchView,
    RegisterView,
    SuwayomiExtensionsActionView,
    SuwayomiExtensionsListView,
    SuwayomiImportView,
    SuwayomiSearchView,
    TransparencyDataView,
    image_proxy_view,
    suwayomi_image_proxy,
)
from animetix.containers import get_container
from django.contrib.auth.models import User
from django.test import RequestFactory
from rest_framework.parsers import JSONParser, MultiPartParser
from rest_framework.request import Request
from rest_framework.test import force_authenticate


@pytest.fixture
def factory():
    return RequestFactory()


def _drive(view_cls, request, user=None, **view_kwargs):
    with patch.object(view_cls, "permission_classes", []):
        view = view_cls.as_view()
        if user is not None:
            force_authenticate(request, user=user)
        return view(request, **view_kwargs)


# --------------------------------------------------------------------------- #
# image_proxy_view: generic exception -> 404 (lines 93-96)
# --------------------------------------------------------------------------- #
def test_image_proxy_generic_exception_returns_404(factory):
    encoded = base64.b64encode(b"http://example.com/a.png").decode()
    request = factory.get("/img/", {"url": encoded, "sig": "good"})
    with (
        patch("animetix.api.core.media.verify_proxy_signature", return_value=True),
        patch("animetix.api.core.media.cache") as mock_cache,
        patch(
            "animetix.api.core.media.safe_http_request",
            side_effect=RuntimeError("network boom"),
        ),
    ):
        mock_cache.get.return_value = None
        response = image_proxy_view(request)
    assert response.status_code == 404


def test_image_proxy_non_200_upstream_returns_404(factory):
    """Upstream returns non-200; the success block is skipped -> falls through to 404."""
    encoded = base64.b64encode(b"http://example.com/a.png").decode()
    request = factory.get("/img/", {"url": encoded, "sig": "good"})
    upstream = MagicMock(status_code=500, content=b"", headers={})
    with (
        patch("animetix.api.core.media.verify_proxy_signature", return_value=True),
        patch("animetix.api.core.media.cache") as mock_cache,
        patch("animetix.api.core.media.safe_http_request", return_value=upstream),
    ):
        mock_cache.get.return_value = None
        response = image_proxy_view(request)
    assert response.status_code == 404


# --------------------------------------------------------------------------- #
# MediaSearchView.post image-search flow (lines 152-197)
#
# `post()` takes `visual_index_service` as an `@inject`-ed keyword argument
# (Provide[Container.core.visual_index_service]): passing an explicit mock for
# that keyword overrides the DI default outright, so these tests never touch the
# real, DI-wired singleton (whose `is_available()` would hit the empty test DB).
# --------------------------------------------------------------------------- #
def _post_image_view(request, *, quota=True, index_available=True, visual_index=None):
    view = MediaSearchView()
    view.guardrail_service = MagicMock()
    view.usage_port = MagicMock()
    view.usage_port.check_quota.return_value = quota
    visual = visual_index or MagicMock()
    visual.is_available.return_value = index_available
    drf_request = Request(request, parsers=[MultiPartParser(), JSONParser()])
    return view, drf_request, visual


@pytest.mark.django_db
def test_media_search_post_quota_exceeded(factory):
    user = User.objects.create_user(username="qe", password="pw")
    request = factory.post("/search/")
    force_authenticate(request, user=user)
    request.user = user
    view, drf_request, visual = _post_image_view(request, quota=False)
    response = view.post(drf_request, visual_index_service=visual)
    assert response.status_code == 403
    assert "quota" in response.data["error"].lower()


@pytest.mark.django_db
def test_media_search_post_no_image(factory):
    user = User.objects.create_user(username="ni", password="pw")
    request = factory.post("/search/")
    force_authenticate(request, user=user)
    request.user = user
    view, drf_request, visual = _post_image_view(request)
    response = view.post(drf_request, visual_index_service=visual)
    assert response.status_code == 400
    assert response.data["error"] == "No image provided"


@pytest.mark.django_db
def test_media_search_post_unknown_target(factory):
    """`target` is validated -- and charged nothing -- before the
    per-target availability guard even runs."""
    from django.core.files.uploadedfile import SimpleUploadedFile

    user = User.objects.create_user(username="banana", password="pw")
    img = SimpleUploadedFile("x.png", b"data", content_type="image/png")
    request = factory.post("/search/", {"image": img, "target": "banana"})
    force_authenticate(request, user=user)
    request.user = user
    view, drf_request, visual = _post_image_view(request)
    with patch("animetix.api.core.media.deduct_berrix") as mock_deduct:
        response = view.post(drf_request, visual_index_service=visual)
    assert response.status_code == 400
    mock_deduct.assert_not_called()
    visual.is_available.assert_not_called()


@pytest.mark.django_db
def test_media_search_post_image_too_large(factory):
    """An oversized upload must be rejected *before* Berrix is touched: the
    size is known without spending money, so charging first and validating
    after means paying for a request that was always going to be refused."""
    from django.core.files.uploadedfile import SimpleUploadedFile

    user = User.objects.create_user(username="big", password="pw")
    img = SimpleUploadedFile("x.png", b"data", content_type="image/png")
    request = factory.post("/search/", {"image": img})
    force_authenticate(request, user=user)
    request.user = user
    view, drf_request, visual = _post_image_view(request)
    with (
        patch("animetix.api.core.media.validate_file_size", return_value=False),
        patch("animetix.api.core.media.deduct_berrix") as mock_deduct,
    ):
        response = view.post(drf_request, visual_index_service=visual)
    assert response.status_code == 413
    mock_deduct.assert_not_called()


@pytest.mark.django_db
def test_media_search_post_invalid_mime(factory):
    """A disallowed MIME type is likewise known without spending money: it
    must be rejected before Berrix is deducted, not after."""
    from django.core.files.uploadedfile import SimpleUploadedFile

    user = User.objects.create_user(username="badmime", password="pw")
    img = SimpleUploadedFile("x.png", b"data", content_type="image/png")
    request = factory.post("/search/", {"image": img})
    force_authenticate(request, user=user)
    request.user = user
    view, drf_request, visual = _post_image_view(request)
    with (
        patch("animetix.api.core.media.validate_file_size", return_value=True),
        patch("animetix.api.core.media.validate_file_mime_type", return_value=False),
        patch("animetix.api.core.media.deduct_berrix") as mock_deduct,
    ):
        response = view.post(drf_request, visual_index_service=visual)
    assert response.status_code == 415
    mock_deduct.assert_not_called()


@pytest.mark.django_db
def test_media_search_post_success(factory):
    from django.core.files.uploadedfile import SimpleUploadedFile

    user = User.objects.create_user(username="okimg", password="pw")
    img = SimpleUploadedFile("x.png", b"imgbytes", content_type="image/png")
    request = factory.post("/search/", {"image": img})
    force_authenticate(request, user=user)
    request.user = user
    view, drf_request, visual = _post_image_view(request)
    visual.encode_image.return_value = [0.1] * 512
    visual.search.return_value = [{"id": "7", "title": "ByImage"}]
    with (
        patch("animetix.api.core.media.validate_file_size", return_value=True),
        patch("animetix.api.core.media.validate_file_mime_type", return_value=True),
        patch("animetix.api.core.media.deduct_berrix") as mock_deduct,
    ):
        response = view.post(drf_request, visual_index_service=visual)
    assert response.status_code == 200
    assert response.data[0]["id"] == "7"
    visual.encode_image.assert_called_once_with("work", b"imgbytes")
    visual.search.assert_called_once()
    view.usage_port.log_usage.assert_called_once()
    # Regression guard for the billing fix: when the index *is* available,
    # the search still charges exactly as before.
    mock_deduct.assert_called_once()


@pytest.mark.django_db
def test_media_search_post_result_id_is_resolvable_by_media_detail_view(factory):
    """CRITICAL regression guard: every other test in this module hands
    `MediaSearchView.post` an already-mocked `visual_index_service`, so none
    of them exercise the REAL `VisualIndexService.search()` id-rewrite through
    the REAL `MediaItemSerializer`. Before the fix, the composite key the
    writer used internally (`vector_key`, "Anime:5114") travelled all the way
    to the client: `SearchBar.tsx` would navigate to
    `/media/Anime/Anime:5114/`, and `MediaDetailView`
    (`MediaItem.objects.get(media_type=..., external_id=item_id)`) would 404
    on every single visual-search result -- a correct-looking hit that was
    always a dead link.
    """
    from animetix.models import MediaItem
    from core.domain.services.visual_index import VisualIndexService
    from django.core.files.uploadedfile import SimpleUploadedFile

    MediaItem.objects.create(
        external_id="5114",
        media_type="Anime",
        title="Fullmetal Alchemist",
        image_url="http://img/fma.png",
    )

    user = User.objects.create_user(username="realhit", password="pw")
    img = SimpleUploadedFile("x.png", b"imgbytes", content_type="image/png")
    request = factory.post("/search/", {"image": img})
    force_authenticate(request, user=user)
    request.user = user

    store = MagicMock()
    store.get_collection_count.return_value = 1
    store.search_by_vector.return_value = [
        {
            "id": "Anime:5114",
            "external_id": "5114",
            "media_type": "Anime",
            "title": "Fullmetal Alchemist",
            "image": "http://img/fma.png",
        }
    ]
    engine = MagicMock()
    engine.get_image_embedding.return_value = [0.1] * 512
    real_visual = VisualIndexService(
        inference_engine=engine, repository=MagicMock(), vector_store=store
    )

    view = MediaSearchView()
    view.guardrail_service = MagicMock()
    view.usage_port = MagicMock()
    view.usage_port.check_quota.return_value = True
    drf_request = Request(request, parsers=[MultiPartParser(), JSONParser()])

    with (
        patch("animetix.api.core.media.validate_file_size", return_value=True),
        patch("animetix.api.core.media.validate_file_mime_type", return_value=True),
        patch("animetix.api.core.media.deduct_berrix"),
    ):
        response = view.post(drf_request, visual_index_service=real_visual)

    assert response.status_code == 200
    result = response.data[0]
    # The id the client receives is the one `MediaDetailView` can actually
    # resolve -- not the internal composite key.
    assert result["id"] == "5114"
    assert (
        MediaItem.objects.get(media_type=result["type"], external_id=result["id"]).title
        == "Fullmetal Alchemist"
    )


@pytest.mark.django_db
def test_media_search_post_index_unavailable_no_charge(factory):
    """An empty target index -- `work` or `character` -- must be refused up
    front (503, honest French copy) and Berrix must never be deducted."""
    from django.core.files.uploadedfile import SimpleUploadedFile

    user = User.objects.create_user(username="emptyidx", password="pw")
    img = SimpleUploadedFile("x.png", b"imgbytes", content_type="image/png")
    request = factory.post("/search/", {"image": img})
    force_authenticate(request, user=user)
    request.user = user
    view, drf_request, visual = _post_image_view(request, index_available=False)
    with patch("animetix.api.core.media.deduct_berrix") as mock_deduct:
        response = view.post(drf_request, visual_index_service=visual)
    assert response.status_code == 503
    assert "index" in response.data["error"].lower()
    mock_deduct.assert_not_called()
    visual.encode_image.assert_not_called()
    visual.search.assert_not_called()


@pytest.mark.django_db
def test_media_search_post_exception_returns_500(factory):
    from django.core.files.uploadedfile import SimpleUploadedFile

    user = User.objects.create_user(username="exc", password="pw")
    img = SimpleUploadedFile("x.png", b"imgbytes", content_type="image/png")
    request = factory.post("/search/", {"image": img})
    force_authenticate(request, user=user)
    request.user = user
    view, drf_request, visual = _post_image_view(request)
    with patch(
        "animetix.api.core.media.validate_file_size",
        side_effect=RuntimeError("boom"),
    ):
        response = view.post(drf_request, visual_index_service=visual)
    assert response.status_code == 500
    assert response.data["error"] == "Internal server error"


@pytest.mark.django_db
def test_media_search_post_search_exception_returns_500(factory):
    """Distinct from `test_media_search_post_exception_returns_500` above,
    which now lands entirely inside the upload-validation try/except added
    by the billing fix: this covers the *other* try/except, the one around
    `encode_image`/`search` themselves, which nothing else exercises."""
    from django.core.files.uploadedfile import SimpleUploadedFile

    user = User.objects.create_user(username="searchexc", password="pw")
    img = SimpleUploadedFile("x.png", b"imgbytes", content_type="image/png")
    request = factory.post("/search/", {"image": img})
    force_authenticate(request, user=user)
    request.user = user
    view, drf_request, visual = _post_image_view(request)
    visual.encode_image.return_value = [0.1] * 512
    visual.search.side_effect = RuntimeError("boom")
    with (
        patch("animetix.api.core.media.validate_file_size", return_value=True),
        patch("animetix.api.core.media.validate_file_mime_type", return_value=True),
        patch("animetix.api.core.media.deduct_berrix"),
    ):
        response = view.post(drf_request, visual_index_service=visual)
    assert response.status_code == 500
    assert response.data["error"] == "Internal server error"


@pytest.mark.django_db
def test_media_search_post_encode_failure_never_charges_berrix(factory):
    """IMPORTANT: a cold Brain (Cloud Run GPU scaled to zero) is a routine
    event, not an outage. Before the fix, Berrix was deducted BEFORE
    encode_image/search ran, so a routine cold start meant the user paid Bx
    and read "Internal server error" for a search that never happened. Now
    the charge only happens after a successful encode+search: an encode
    failure must leave the user's balance untouched."""
    from django.core.files.uploadedfile import SimpleUploadedFile

    user = User.objects.create_user(username="nopay", password="pw")
    img = SimpleUploadedFile("x.png", b"imgbytes", content_type="image/png")
    request = factory.post("/search/", {"image": img})
    force_authenticate(request, user=user)
    request.user = user
    view, drf_request, visual = _post_image_view(request)
    visual.encode_image.side_effect = RuntimeError("brain unreachable: cold start")
    with (
        patch("animetix.api.core.media.validate_file_size", return_value=True),
        patch("animetix.api.core.media.validate_file_mime_type", return_value=True),
        patch("animetix.api.core.media.deduct_berrix") as mock_deduct,
    ):
        response = view.post(drf_request, visual_index_service=visual)
    assert response.status_code == 500
    mock_deduct.assert_not_called()
    view.usage_port.log_usage.assert_not_called()


@pytest.mark.django_db
def test_media_search_post_search_failure_never_charges_berrix(factory):
    """Same guarantee, but the failure happens one step later (search itself,
    not encode) -- both must leave Berrix untouched."""
    from django.core.files.uploadedfile import SimpleUploadedFile

    user = User.objects.create_user(username="nopay2", password="pw")
    img = SimpleUploadedFile("x.png", b"imgbytes", content_type="image/png")
    request = factory.post("/search/", {"image": img})
    force_authenticate(request, user=user)
    request.user = user
    view, drf_request, visual = _post_image_view(request)
    visual.encode_image.return_value = [0.1] * 512
    visual.search.side_effect = RuntimeError("pgvector connection lost")
    with (
        patch("animetix.api.core.media.validate_file_size", return_value=True),
        patch("animetix.api.core.media.validate_file_mime_type", return_value=True),
        patch("animetix.api.core.media.deduct_berrix") as mock_deduct,
    ):
        response = view.post(drf_request, visual_index_service=visual)
    assert response.status_code == 500
    mock_deduct.assert_not_called()


@pytest.mark.django_db
def test_media_search_post_invalid_limit_is_a_400_not_a_500(factory):
    """MINOR: `int(request.data.get("limit", 10))` used to sit outside any
    try/except -- `limit=abc` was an uncaught ValueError -> 500. It must be a
    400 (a client input error), and must never touch Berrix."""
    from django.core.files.uploadedfile import SimpleUploadedFile

    user = User.objects.create_user(username="badlimit", password="pw")
    img = SimpleUploadedFile("x.png", b"imgbytes", content_type="image/png")
    request = factory.post("/search/", {"image": img, "limit": "abc"})
    force_authenticate(request, user=user)
    request.user = user
    view, drf_request, visual = _post_image_view(request)
    with patch("animetix.api.core.media.deduct_berrix") as mock_deduct:
        response = view.post(drf_request, visual_index_service=visual)
    assert response.status_code == 400
    mock_deduct.assert_not_called()
    visual.is_available.assert_not_called()


@pytest.mark.django_db
def test_media_search_post_survives_cache_backend_failure(factory, mocker):
    """A Redis blip in the availability-check cache must not 500 an endpoint
    that doesn't otherwise need Redis -- it must fall back to a live COUNT
    and behave exactly as if the cache had a hit (index available -> search
    proceeds, charges, and returns 200)."""
    from adapters.persistence.pg_vector_store_adapter import PgVectorStoreAdapter
    from core.domain.services.visual_index import VisualIndexService
    from django.core.files.uploadedfile import SimpleUploadedFile

    user = User.objects.create_user(username="cachefail", password="pw")
    img = SimpleUploadedFile("x.png", b"imgbytes", content_type="image/png")
    request = factory.post("/search/", {"image": img})
    force_authenticate(request, user=user)
    request.user = user

    mock_manager = MagicMock()
    mock_manager.get_collection.return_value.count.return_value = 3
    mocker.patch(
        "adapters.persistence.pg_vector_store_adapter.vector_manager", mock_manager
    )
    mocker.patch(
        "adapters.persistence.pg_vector_store_adapter.cache.get",
        side_effect=RuntimeError("redis down"),
    )

    real_vector_db = PgVectorStoreAdapter()
    visual = VisualIndexService(
        inference_engine=MagicMock(),
        repository=MagicMock(),
        vector_store=real_vector_db,
    )
    visual.encode_image = MagicMock(return_value=[0.1] * 512)
    visual.search = MagicMock(return_value=[{"id": "1", "title": "T"}])

    view = MediaSearchView()
    view.guardrail_service = MagicMock()
    view.usage_port = MagicMock()
    view.usage_port.check_quota.return_value = True
    drf_request = Request(request, parsers=[MultiPartParser(), JSONParser()])
    with (
        patch("animetix.api.core.media.validate_file_size", return_value=True),
        patch("animetix.api.core.media.validate_file_mime_type", return_value=True),
        patch("animetix.api.core.media.deduct_berrix") as mock_deduct,
    ):
        response = view.post(drf_request, visual_index_service=visual)

    assert response.status_code == 200
    mock_manager.get_collection.assert_called()
    mock_deduct.assert_called_once()


# --------------------------------------------------------------------------- #
# GameSessionView.get (lines 215-216)
# --------------------------------------------------------------------------- #
def test_game_session_get(factory):
    request = factory.get("/game/session/")
    fake_session = {
        "media_type": "Anime",
        "is_ranked": True,
        "is_daily": False,
        "game_over": False,
        "guesses": ["a", "b"],
    }
    with patch(
        "animetix.api.core.accounts.get_session_service", return_value=fake_session
    ):
        response = _drive(GameSessionView, request)
    assert response.status_code == 200
    assert response.data["media_type"] == "Anime"
    assert response.data["guess_count"] == 2


# --------------------------------------------------------------------------- #
# RegisterView create_user exception -> 400 (lines 288-289)
# --------------------------------------------------------------------------- #
@pytest.mark.django_db
def test_register_create_user_exception(factory):
    request = factory.post(
        "/auth/register/",
        {"username": "newx", "password": "pw12345", "email": "n@x.com"},
    )
    with patch(
        "animetix.api.core.accounts.User.objects.create_user",
        side_effect=RuntimeError("db down"),
    ):
        response = _drive(RegisterView, request)
    assert response.status_code == 400
    assert "db down" in response.data["error"]


# --------------------------------------------------------------------------- #
# TransparencyData positive_rate branch (lines 394-395)
# --------------------------------------------------------------------------- #
@pytest.mark.django_db
def test_transparency_with_feedback(factory):
    from animetix.models import AIFeedback

    # Two feedbacks, one positive -> positive_rate computed branch executed.
    AIFeedback.objects.create(is_positive=True)
    AIFeedback.objects.create(is_positive=False)
    request = factory.get("/transparency/")
    mock_sota = MagicMock()
    mock_sota.get_all_benchmarks.return_value = []
    mock_drift = MagicMock()
    mock_drift.get_drift_report.return_value = {}
    real_container = get_container()
    real_container.core.sota_benchmark_service.override(mock_sota)
    real_container.core.drift_service.override(mock_drift)
    try:
        response = _drive(TransparencyDataView, request)
    finally:
        real_container.core.sota_benchmark_service.reset_last_overriding()
        real_container.core.drift_service.reset_last_overriding()
    assert response.status_code == 200
    assert response.data["global_metrics"]["total_feedbacks"] == 2
    assert response.data["global_metrics"]["community_satisfaction"] == 0.5


# --------------------------------------------------------------------------- #
# suwayomi_image_proxy non-200 / exception (lines 504-510)
# --------------------------------------------------------------------------- #
def test_suwayomi_image_non_200(factory):
    encoded = base64.b64encode(b"relative/page.png").decode()
    request = factory.get("/suwayomi-image/", {"page_url": encoded})
    upstream = MagicMock(status_code=404, content=b"", headers={})
    with (
        patch("core.config.settings") as mock_settings,
        patch("animetix.api.core.suwayomi.safe_http_request", return_value=upstream),
    ):
        mock_settings.SUWAYOMI_URL = "http://suwayomi.local"
        mock_settings.SUWAYOMI_PASSWORD = ""
        response = suwayomi_image_proxy(request)
    assert response.status_code == 404


def test_suwayomi_image_exception(factory):
    encoded = base64.b64encode(b"relative/page.png").decode()
    request = factory.get("/suwayomi-image/", {"page_url": encoded})
    with (
        patch("core.config.settings") as mock_settings,
        patch(
            "animetix.api.core.suwayomi.safe_http_request",
            side_effect=RuntimeError("conn refused"),
        ),
    ):
        mock_settings.SUWAYOMI_URL = "http://suwayomi.local"
        mock_settings.SUWAYOMI_PASSWORD = ""
        response = suwayomi_image_proxy(request)
    assert response.status_code == 500


def test_suwayomi_image_absolute_authorized_url(factory):
    """Absolute URL that matches the configured base is allowed through."""
    encoded = base64.b64encode(b"http://suwayomi.local/page.png").decode()
    request = factory.get("/suwayomi-image/", {"page_url": encoded})
    upstream = MagicMock(
        status_code=200, content=b"PNG", headers={"Content-Type": "image/png"}
    )
    with (
        patch("core.config.settings") as mock_settings,
        patch("animetix.api.core.suwayomi.safe_http_request", return_value=upstream),
    ):
        mock_settings.SUWAYOMI_URL = "http://suwayomi.local"
        mock_settings.SUWAYOMI_PASSWORD = "pw"
        response = suwayomi_image_proxy(request)
    assert response.status_code == 200


# --------------------------------------------------------------------------- #
# Suwayomi views: not-configured branches (552, 583, 652, 696)
# --------------------------------------------------------------------------- #
def test_suwayomi_search_not_configured(factory):
    request = factory.get("/suwayomi/search/", {"source_id": "s1"})
    view = SuwayomiSearchView()
    view.suwayomi_adapter = None
    response = view.get(Request(request))
    assert response.status_code == 500


@pytest.mark.django_db
def test_suwayomi_import_not_configured(factory):
    request = factory.post(
        "/import/",
        json.dumps({"source_id": "s", "suwayomi_manga_id": "m"}),
        content_type="application/json",
    )
    view = SuwayomiImportView()
    view.suwayomi_adapter = None
    response = view.post(Request(request, parsers=[JSONParser()]))
    assert response.status_code == 500


def test_suwayomi_extensions_list_not_configured(factory):
    request = factory.get("/extensions/")
    view = SuwayomiExtensionsListView()
    view.suwayomi_adapter = None
    response = view.get(Request(request))
    assert response.status_code == 500


def test_suwayomi_extensions_action_not_configured(factory):
    request = factory.post(
        "/extensions/action/",
        json.dumps({"ids": ["1"], "action": "install"}),
        content_type="application/json",
    )
    view = SuwayomiExtensionsActionView()
    view.suwayomi_adapter = None
    response = view.post(Request(request, parsers=[JSONParser()]))
    assert response.status_code == 500


def test_suwayomi_extensions_action_exception(factory):
    """update_extensions raising -> 500 (lines 703-705)."""
    request = factory.post(
        "/extensions/action/",
        json.dumps({"ids": ["1"], "action": "update"}),
        content_type="application/json",
    )
    view = SuwayomiExtensionsActionView()
    view.suwayomi_adapter = MagicMock()
    view.suwayomi_adapter.update_extensions.side_effect = RuntimeError("boom")
    response = view.post(Request(request, parsers=[JSONParser()]))
    assert response.status_code == 500
    assert response.data["error"] == "Internal server error"


# --------------------------------------------------------------------------- #
# FavoriteMangaToggleView auto-import path (lines 732-775)
# --------------------------------------------------------------------------- #
@pytest.mark.django_db
def test_favorite_toggle_autoimport_not_configured(factory):
    user = User.objects.create_user(username="fa1", password="pw")
    request = factory.post(
        "/media/Manga/new-x/favorite/",
        json.dumps({"source_id": "s", "suwayomi_manga_id": "m"}),
        content_type="application/json",
    )
    real_container = get_container()
    real_container.persistence.suwayomi_adapter.override(None)
    try:
        force_authenticate(request, user=user)
        with patch.object(FavoriteMangaToggleView, "permission_classes", []):
            view = FavoriteMangaToggleView.as_view()
            response = view(request, media_id="new-x")
    finally:
        real_container.persistence.suwayomi_adapter.reset_last_overriding()
    assert response.status_code == 500


@pytest.mark.django_db
def test_favorite_toggle_autoimport_details_missing(factory):
    user = User.objects.create_user(username="fa2", password="pw")
    request = factory.post(
        "/media/Manga/new-y/favorite/",
        json.dumps({"source_id": "s", "suwayomi_manga_id": "m"}),
        content_type="application/json",
    )
    adapter = MagicMock()
    adapter.get_manga_details.return_value = None
    real_container = get_container()
    real_container.persistence.suwayomi_adapter.override(adapter)
    try:
        force_authenticate(request, user=user)
        with patch.object(FavoriteMangaToggleView, "permission_classes", []):
            view = FavoriteMangaToggleView.as_view()
            response = view(request, media_id="new-y")
    finally:
        real_container.persistence.suwayomi_adapter.reset_last_overriding()
    assert response.status_code == 404


@pytest.mark.django_db
def test_favorite_toggle_autoimport_success(factory):
    from animetix.models import FavoriteManga, MediaItem

    user = User.objects.create_user(username="fa3", password="pw")
    request = factory.post(
        "/media/Manga/new-z/favorite/",
        json.dumps({"source_id": "s", "suwayomi_manga_id": "m"}),
        content_type="application/json",
    )
    adapter = MagicMock()
    adapter.get_manga_details.return_value = {
        "title": "Auto Imported",
        "description": "d",
        "thumbnailUrl": "http://thumb/y.png",
        "author": "A",
        "artist": "B",
        "status": "ongoing",
    }
    mock_manga_service = MagicMock()
    real_container = get_container()
    real_container.persistence.suwayomi_adapter.override(adapter)
    real_container.core.manga_service.override(mock_manga_service)
    try:
        force_authenticate(request, user=user)
        with patch.object(FavoriteMangaToggleView, "permission_classes", []):
            view = FavoriteMangaToggleView.as_view()
            response = view(request, media_id="new-z")
    finally:
        real_container.persistence.suwayomi_adapter.reset_last_overriding()
        real_container.core.manga_service.reset_last_overriding()
    assert response.status_code == 200
    assert response.data["is_favorite"] is True
    # Manga was auto-created and favorited.
    assert MediaItem.objects.filter(external_id="new-z").exists()
    assert FavoriteManga.objects.filter(user=user).count() == 1


# --------------------------------------------------------------------------- #
# MangaChapterSyncView branches (910-1069)
# --------------------------------------------------------------------------- #
@pytest.mark.django_db
def test_chapter_sync_invalid_chapter_number(factory):
    from animetix.models import MediaItem, TrackerConnection

    user = User.objects.create_user(username="sv1", password="pw")
    MediaItem.objects.create(external_id="man-iv", media_type="Manga", title="IV")
    TrackerConnection.objects.create(
        user=user, tracker="anilist", token="mock-token", username="u"
    )
    request = factory.post("/sync/", {}, content_type="application/json")
    response = _drive(
        MangaChapterSyncView,
        request,
        user=user,
        media_id="man-iv",
        chapter_number="abc",
    )
    assert response.status_code == 400
    assert "Invalid chapter" in response.data["error"]


# --------------------------------------------------------------------------- #
# MangaChapterSyncView : poussée via une liaison confirmée
#
# Les tests de résolution par titre (recherche GraphQL AniList / Jikan à chaque
# poussée, identifiant repêché dans `metadata`) ont disparu avec le code qu'ils
# couvraient : la vue ne devine plus l'œuvre distante, elle pousse à travers une
# liaison confirmée. Ne subsistent ici que les chemins d'erreur qui existent
# encore — l'écriture distante qui échoue, et l'adaptateur qui lève.
# --------------------------------------------------------------------------- #


def _confirmed_link(username, media_id, tracker, remote_id, remote_progress=1):
    """Utilisateur + manga + connexion + liaison CONFIRMÉE : le seul montage
    qui fait effectivement pousser la vue."""
    from animetix.models import MangaTrackerLink, MediaItem, TrackerConnection

    user = User.objects.create_user(username=username, password="pw")
    manga = MediaItem.objects.create(
        external_id=media_id, media_type="Manga", title=media_id, metadata={}
    )
    TrackerConnection.objects.create(
        user=user, tracker=tracker, token="tok", username="u"
    )
    MangaTrackerLink.objects.create(
        user=user,
        manga=manga,
        tracker=tracker,
        remote_id=remote_id,
        remote_title="Remote title",
        remote_progress=remote_progress,
        status="confirmed",
    )
    return user


def _sync_with_adapter(factory, user, tracker, adapter, media_id, chapter_number):
    """Pilote la vue avec un faux adaptateur pour ``tracker``."""
    provider = getattr(get_container().persistence, f"{tracker}_adapter")
    provider.override(adapter)
    try:
        request = factory.post("/sync/", {}, content_type="application/json")
        return _drive(
            MangaChapterSyncView,
            request,
            user=user,
            media_id=media_id,
            chapter_number=chapter_number,
        )
    finally:
        provider.reset_last_overriding()


@pytest.mark.django_db
def test_chapter_sync_anilist_write_failure(factory):
    """L'écriture distante échoue (l'adaptateur renvoie False) -> résultat en
    échec pour ce tracker, sans erreur de page."""
    user = _confirmed_link("sv4", "man-meta", "anilist", "999")
    adapter = MagicMock()
    adapter.write_progress.return_value = False

    response = _sync_with_adapter(factory, user, "anilist", adapter, "man-meta", "6")

    assert response.status_code == 200
    assert response.data["results"]["anilist"] == {"success": False}
    adapter.write_progress.assert_called_once_with("999", 6, token="tok")


@pytest.mark.django_db
def test_chapter_sync_anilist_adapter_raises(factory):
    """Un adaptateur qui lève (il n'est pas censé le faire) est rattrapé : la
    lecture de chapitre reste un succès, le tracker seul est en échec."""
    user = _confirmed_link("sv10", "man-mx", "anilist", "42")
    adapter = MagicMock()
    adapter.write_progress.side_effect = RuntimeError("mutation boom")

    response = _sync_with_adapter(factory, user, "anilist", adapter, "man-mx", "2")

    assert response.status_code == 200
    assert response.data["success"] is True
    assert response.data["results"]["anilist"]["success"] is False
    assert "mutation boom" in response.data["results"]["anilist"]["error"]


@pytest.mark.django_db
def test_chapter_sync_mal_write_failure(factory):
    user = _confirmed_link("sv7", "man-me", "myanimelist", "77")
    adapter = MagicMock()
    adapter.write_progress.return_value = False

    response = _sync_with_adapter(factory, user, "myanimelist", adapter, "man-me", "9")

    assert response.status_code == 200
    assert response.data["results"]["myanimelist"] == {"success": False}
    adapter.write_progress.assert_called_once_with("77", 9, token="tok")


@pytest.mark.django_db
def test_chapter_sync_mal_adapter_raises(factory):
    user = _confirmed_link("sv12", "man-ux", "myanimelist", "55")
    adapter = MagicMock()
    adapter.write_progress.side_effect = RuntimeError("patch boom")

    response = _sync_with_adapter(factory, user, "myanimelist", adapter, "man-ux", "3")

    assert response.status_code == 200
    assert response.data["success"] is True
    assert response.data["results"]["myanimelist"]["success"] is False
    assert "patch boom" in response.data["results"]["myanimelist"]["error"]