File size: 9,366 Bytes
624c7c9
15c2525
 
 
 
624c7c9
15c2525
624c7c9
 
 
 
15c2525
624c7c9
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
15c2525
 
 
624c7c9
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
01e0bb5
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
624c7c9
 
 
 
 
 
 
 
 
 
 
 
15c2525
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
"""
Tests de `POST /api/v1/auth/sso-exchange` (SSO entrante) y `POST /api/v1/auth/sso-ticket`
(SSO saliente): canje de ticket del Core por una sesión propia de M6, y el camino
inverso — pedirle al Core un ticket para navegar hacia otro módulo, usando el
`core_token` embebido en la sesión (ver `app/routers/auth.py`).

No golpean el Core real: se stubean `core_auth.exchange_sso_ticket`/`request_sso_ticket`.
"""
import pytest

from app.config import settings
from app.dependencies import create_access_token, decode_token
from app.integrations import core_auth


def _core_user(roles: list[str], user_id: int = 42) -> dict:
    return {
        "id": user_id,
        "first_name": "Ana",
        "last_name": "Pérez",
        "email": "ana@example.com",
        "roles": [{"id": i, "name": name} for i, name in enumerate(roles)],
    }


@pytest.fixture
def sso_enabled(monkeypatch):
    monkeypatch.setattr(settings, "sso_enabled", True)


def test_sso_exchange_ok(client, monkeypatch, sso_enabled):
    monkeypatch.setattr(
        core_auth,
        "exchange_sso_ticket",
        lambda ticket: {"user": _core_user(["admin_internacion"]), "token": "core-jwt"},
    )

    resp = client.post("/api/v1/auth/sso-exchange", json={"ticket": "un-ticket-valido"})

    assert resp.status_code == 200
    body = resp.json()
    assert body["rol"] == "ADMINISTRATIVO"
    assert body["user"]["id"] == 42
    assert body["user"]["email"] == "ana@example.com"

    payload = decode_token(body["token"])
    assert payload["sub"] == "42"
    assert payload["rol"] == "ADMINISTRATIVO"
    # El JWT del Core queda embebido — necesario para pedir tickets SSO salientes
    # más adelante (POST /auth/sso-ticket), sin volver a tocar el Core en cada request.
    assert payload["core_token"] == "core-jwt"


def test_sso_exchange_medico(client, monkeypatch, sso_enabled):
    monkeypatch.setattr(
        core_auth,
        "exchange_sso_ticket",
        lambda ticket: {"user": _core_user(["Medico"], user_id=9), "token": "core-jwt"},
    )

    resp = client.post("/api/v1/auth/sso-exchange", json={"ticket": "otro-ticket"})

    assert resp.status_code == 200
    assert resp.json()["rol"] == "MEDICO"


def test_sso_exchange_ticket_invalido_401(client, monkeypatch, sso_enabled):
    def _raise(ticket):
        raise core_auth.SSOTicketInvalid("expirado")

    monkeypatch.setattr(core_auth, "exchange_sso_ticket", _raise)

    resp = client.post("/api/v1/auth/sso-exchange", json={"ticket": "usado-o-expirado"})

    assert resp.status_code == 401
    assert resp.json()["detail"]["codigo"] == "NO_AUTENTICADO"


def test_sso_exchange_core_inalcanzable_502(client, monkeypatch, sso_enabled):
    def _raise(ticket):
        raise core_auth.SSOExchangeError("timeout")

    monkeypatch.setattr(core_auth, "exchange_sso_ticket", _raise)

    resp = client.post("/api/v1/auth/sso-exchange", json={"ticket": "cualquiera"})

    assert resp.status_code == 502
    assert resp.json()["detail"]["codigo"] == "SERVICIO_EXTERNO_NO_DISPONIBLE"


def test_sso_exchange_rol_no_mapeado_403(client, monkeypatch, sso_enabled):
    monkeypatch.setattr(
        core_auth,
        "exchange_sso_ticket",
        lambda ticket: {"user": _core_user(["Enfermero"], user_id=10), "token": "core-jwt"},
    )

    resp = client.post("/api/v1/auth/sso-exchange", json={"ticket": "un-ticket"})

    assert resp.status_code == 403
    assert resp.json()["detail"]["codigo"] == "NO_AUTORIZADO"


# ─── Fallback de roles (GET /roles) cuando `user.roles[]` viene vacío ──────
# El Core real no siempre puebla `user.roles[]` en la respuesta del canje SSO
# (ver changelog #48 en M6_DISEÑO.md §14.11) — `sso_exchange` cae entonces a
# `core_auth.resolve_user_roles`, que resuelve vía `GET /roles`.


def test_sso_exchange_roles_vacio_usa_fallback(client, monkeypatch, sso_enabled):
    monkeypatch.setattr(
        core_auth,
        "exchange_sso_ticket",
        lambda ticket: {"user": _core_user([], user_id=7), "token": "core-jwt"},
    )
    monkeypatch.setattr(core_auth, "resolve_user_roles", lambda user_id: ["Medico"])

    resp = client.post("/api/v1/auth/sso-exchange", json={"ticket": "un-ticket"})

    assert resp.status_code == 200
    assert resp.json()["rol"] == "MEDICO"


def test_sso_exchange_roles_vacio_fallback_tambien_vacio_403(client, monkeypatch, sso_enabled):
    monkeypatch.setattr(
        core_auth,
        "exchange_sso_ticket",
        lambda ticket: {"user": _core_user([], user_id=8), "token": "core-jwt"},
    )
    monkeypatch.setattr(core_auth, "resolve_user_roles", lambda user_id: [])

    resp = client.post("/api/v1/auth/sso-exchange", json={"ticket": "un-ticket"})

    assert resp.status_code == 403
    assert resp.json()["detail"]["codigo"] == "NO_AUTORIZADO"


def test_sso_exchange_roles_no_vacio_no_usa_fallback(client, monkeypatch, sso_enabled):
    """Si el canje ya trae roles, no se llama al fallback (camino feliz sin tocar el Core de nuevo)."""
    monkeypatch.setattr(
        core_auth,
        "exchange_sso_ticket",
        lambda ticket: {"user": _core_user(["admin_internacion"]), "token": "core-jwt"},
    )

    def _fail(user_id):
        raise AssertionError("no debería llamarse: user.roles[] ya vino poblado")

    monkeypatch.setattr(core_auth, "resolve_user_roles", _fail)

    resp = client.post("/api/v1/auth/sso-exchange", json={"ticket": "un-ticket"})

    assert resp.status_code == 200
    assert resp.json()["rol"] == "ADMINISTRATIVO"


def test_sso_exchange_fallback_de_roles_falla_502(client, monkeypatch, sso_enabled):
    monkeypatch.setattr(
        core_auth,
        "exchange_sso_ticket",
        lambda ticket: {"user": _core_user([], user_id=11), "token": "core-jwt"},
    )

    def _raise(user_id):
        raise core_auth.SSOExchangeError("timeout en GET /roles")

    monkeypatch.setattr(core_auth, "resolve_user_roles", _raise)

    resp = client.post("/api/v1/auth/sso-exchange", json={"ticket": "un-ticket"})

    assert resp.status_code == 502
    assert resp.json()["detail"]["codigo"] == "SERVICIO_EXTERNO_NO_DISPONIBLE"


def test_sso_exchange_ticket_vacio_422(client, sso_enabled):
    resp = client.post("/api/v1/auth/sso-exchange", json={"ticket": ""})

    assert resp.status_code == 422


def test_sso_exchange_deshabilitado_404(client, monkeypatch):
    monkeypatch.setattr(settings, "sso_enabled", False)

    resp = client.post("/api/v1/auth/sso-exchange", json={"ticket": "cualquiera"})

    assert resp.status_code == 404


# ─── POST /auth/sso-ticket (SSO saliente) ──────────────────────────────────


def _headers_con_core_token(core_token: str = "core-jwt-vigente") -> dict:
    token = create_access_token(sub="1", rol="ADMINISTRATIVO", extra={"core_token": core_token})
    return {"Authorization": f"Bearer {token}"}


def test_sso_ticket_ok(client, monkeypatch, sso_enabled):
    monkeypatch.setattr(
        core_auth, "request_sso_ticket", lambda core_token: {"ticket": "un-ticket-nuevo", "expires_in": 60}
    )

    resp = client.post("/api/v1/auth/sso-ticket", headers=_headers_con_core_token())

    assert resp.status_code == 200
    assert resp.json() == {"ticket": "un-ticket-nuevo", "expires_in": 60}


def test_sso_ticket_pasa_el_core_token_correcto(client, monkeypatch, sso_enabled):
    received = []
    monkeypatch.setattr(
        core_auth,
        "request_sso_ticket",
        lambda core_token: received.append(core_token) or {"ticket": "t", "expires_in": 60},
    )

    client.post("/api/v1/auth/sso-ticket", headers=_headers_con_core_token("mi-core-token"))

    assert received == ["mi-core-token"]


def test_sso_ticket_sin_core_token_401(client, admin_headers, sso_enabled):
    """Sesiones que no vinieron de un SSO real (p.ej. el endpoint de dev, admin_headers
    de conftest.py) no tienen core_token embebido — no pueden pedir un ticket saliente."""
    resp = client.post("/api/v1/auth/sso-ticket", headers=admin_headers)

    assert resp.status_code == 401
    assert resp.json()["detail"]["codigo"] == "SIN_SESION_CORE"


def test_sso_ticket_core_token_vencido_401(client, monkeypatch, sso_enabled):
    def _raise(core_token):
        raise core_auth.CoreTokenInvalid("vencido")

    monkeypatch.setattr(core_auth, "request_sso_ticket", _raise)

    resp = client.post("/api/v1/auth/sso-ticket", headers=_headers_con_core_token())

    assert resp.status_code == 401
    assert resp.json()["detail"]["codigo"] == "NO_AUTENTICADO"


def test_sso_ticket_core_inalcanzable_502(client, monkeypatch, sso_enabled):
    def _raise(core_token):
        raise core_auth.SSOExchangeError("timeout")

    monkeypatch.setattr(core_auth, "request_sso_ticket", _raise)

    resp = client.post("/api/v1/auth/sso-ticket", headers=_headers_con_core_token())

    assert resp.status_code == 502
    assert resp.json()["detail"]["codigo"] == "SERVICIO_EXTERNO_NO_DISPONIBLE"


def test_sso_ticket_sin_sesion_401(client, sso_enabled):
    resp = client.post("/api/v1/auth/sso-ticket")

    assert resp.status_code == 401


def test_sso_ticket_deshabilitado_404(client, monkeypatch):
    monkeypatch.setattr(settings, "sso_enabled", False)

    resp = client.post("/api/v1/auth/sso-ticket", headers=_headers_con_core_token())

    assert resp.status_code == 404