Fix Play: Gradio Plot drops Plotly frames; drive playback server-side with gr.Timer

app.py

@@ -69,7 +69,7 @@ and with lost messages. The merge rules guarantee that everyone who has heard th
 evidence every honest drone can check for itself, then **dropped automatically**. The rest keep going, and each round
 ends with a **receipt** that a quorum of drones co-signs and anyone can check afterwards.
 
-**Watch the mission.** Press **Run mission**, then hit **Play** on the animation. Left = **WITH** Trusted Swarms (converges, attackers dropped). Right = **WITHOUT** — leader-based (poisoned picture, then blank when the leader is lost).
+**Watch the mission.** Press **Run mission**, then hit **▶ Play** above the animation. Left = **WITH** Trusted Swarms (converges, attackers dropped). Right = **WITHOUT** — leader-based (poisoned picture, then blank when the leader is lost).
 """
 
 S4 = f"""
@@ -291,9 +291,11 @@ def _frame_traces(sw, upto):
     return left, right, left_note, right_note
 
 
-def _anim_compare(sw):
-    """Gold-standard side-by-side animated mission: WITH trusted vs WITHOUT leader-based."""
+def _anim_compare(sw, upto=None):
+    """Side-by-side mission at round `upto` (1..N): WITH trusted vs WITHOUT leader-based.
+    Gradio's Plot component drops Plotly `frames`, so playback is driven server-side by gr.Timer."""
     n_rounds = len(sw.rounds)
+    upto = n_rounds if upto is None else max(1, min(int(upto), n_rounds))
     xr, yr = _axis_range(sw)
     fig = make_subplots(
         rows=1, cols=2, shared_xaxes=False, shared_yaxes=True,
@@ -303,121 +305,101 @@ def _anim_compare(sw):
         ),
         horizontal_spacing=0.06,
     )
-
-    # Seed with final frame so static view is complete; frames animate from round 1
-    left, right, _, _ = _frame_traces(sw, n_rounds)
+    left, right, _, _ = _frame_traces(sw, upto)
     for tr in left:
         fig.add_trace(tr, row=1, col=1)
     for tr in right:
         fig.add_trace(tr, row=1, col=2)
-
-    frames = []
-    for upto in range(1, n_rounds + 1):
-        left, right, ln, rn = _frame_traces(sw, upto)
-        data = left + right
-        frames.append(go.Frame(
-            data=data, name=str(upto),
-            layout=go.Layout(title_text=f"Mission animation · round {upto} of {n_rounds}"),
-        ))
-    fig.frames = frames
-
-    sliders = [dict(
-        active=n_rounds - 1,
-        currentvalue=dict(prefix="Round ", font=dict(size=14)),
-        pad=dict(t=40, b=10),
-        steps=[dict(method="animate",
-                    args=[[str(i)], dict(mode="immediate", frame=dict(duration=0, redraw=True), transition=dict(duration=0))],
-                    label=str(i)) for i in range(1, n_rounds + 1)],
-    )]
     fig.update_layout(
-        title=dict(text="Side-by-side mission: press ▶ Play to watch WITH vs WITHOUT", x=0.02, xanchor="left"),
-        height=560, margin=dict(l=40, r=20, t=80, b=80),
+        title=dict(text=f"Mission · round {upto} of {n_rounds}", x=0.02, xanchor="left"),
+        height=560, margin=dict(l=40, r=20, t=90, b=40),
         template="plotly_white",
         legend=dict(orientation="h", y=1.12, x=0),
-        updatemenus=[dict(
-            type="buttons", showactive=False, direction="left",
-            x=1, xanchor="right", y=1.14, yanchor="top",
-            buttons=[
-                dict(label="▶ Play", method="animate",
-                     args=[None, dict(frame=dict(duration=700, redraw=True), fromcurrent=True,
-                                      transition=dict(duration=400, easing="cubic-in-out"),
-                                      mode="immediate")]),
-                dict(label="⏸ Pause", method="animate",
-                     args=[[None], dict(frame=dict(duration=0, redraw=False), mode="immediate",
-                                        transition=dict(duration=0))]),
-                dict(label="⟲ Restart", method="animate",
-                     args=[["1"], dict(frame=dict(duration=0, redraw=True), mode="immediate",
-                                       transition=dict(duration=0))]),
-            ],
-        )],
-        sliders=sliders,
+        uirevision="mission",
     )
     fig.update_xaxes(title_text="metres east", range=xr, row=1, col=1)
     fig.update_xaxes(title_text="metres east", range=xr, row=1, col=2)
     fig.update_yaxes(title_text="metres north", range=yr, scaleanchor="x", scaleratio=1, row=1, col=1)
     fig.update_yaxes(range=yr, scaleanchor="x2", scaleratio=1, row=1, col=2)
-    # Stronger subplot title styling
     for ann in fig.layout.annotations:
-        if "WITH" in (ann.text or ""):
-            ann.font = dict(size=13, color="#1f6feb")
-        elif "WITHOUT" in (ann.text or ""):
+        if "WITHOUT" in (ann.text or ""):
             ann.font = dict(size=13, color="#d62828")
+        elif "WITH" in (ann.text or ""):
+            ann.font = dict(size=13, color="#1f6feb")
     return fig
 
 
-def _err_anim(sw):
-    """Animated error bars building round by round."""
+def _err_anim(sw, upto=None):
+    """Error bars built up to round `upto`."""
     n_rounds = len(sw.rounds)
+    upto = n_rounds if upto is None else max(1, min(int(upto), n_rounds))
     xs = [r["round"] for r in sw.rounds]
     te = [r["trusted_err"] if r["trusted_err"] is not None else 0 for r in sw.rounds]
     le = [r["lead_err"] if r["lead_err"] is not None else 0 for r in sw.rounds]
     lead_miss = [r["lead_err"] is None for r in sw.rounds]
-
-    def bar_frame(upto):
-        te_v = te[:upto] + [0] * (n_rounds - upto)
-        le_v = le[:upto] + [0] * (n_rounds - upto)
-        texts = []
-        for i in range(n_rounds):
-            if i >= upto:
-                texts.append("")
-            elif lead_miss[i]:
-                texts.append("leader lost")
-            else:
-                texts.append("")
-        return [
-            go.Bar(x=xs, y=te_v, name="Trusted (WITH)", marker_color="#1f6feb", legendgroup="t"),
-            go.Bar(x=xs, y=le_v, name="Leader-based (WITHOUT)", marker_color="#d62828", legendgroup="l",
-                   text=texts, textposition="outside"),
-        ]
-
-    fig = go.Figure(data=bar_frame(n_rounds))
-    fig.frames = [go.Frame(data=bar_frame(u), name=str(u)) for u in range(1, n_rounds + 1)]
+    te_v = te[:upto] + [0] * (n_rounds - upto)
+    le_v = le[:upto] + [0] * (n_rounds - upto)
+    texts = ["leader lost" if (i < upto and lead_miss[i]) else "" for i in range(n_rounds)]
+    ymax = max(te + le + [1]) * 1.2
+    fig = go.Figure(data=[
+        go.Bar(x=xs, y=te_v, name="Trusted (WITH)", marker_color="#1f6feb"),
+        go.Bar(x=xs, y=le_v, name="Leader-based (WITHOUT)", marker_color="#d62828",
+               text=texts, textposition="outside"),
+    ])
     fig.update_layout(
         barmode="group",
-        title="Error from truth over rounds (metres; lower is better) — ▶ Play",
+        title=f"Error from truth, rounds 1–{upto} (metres; lower is better)",
         height=340, margin=dict(l=40, r=20, t=60, b=40), template="plotly_white",
-        xaxis=dict(title="round", dtick=1), yaxis=dict(title="error (m)"),
+        xaxis=dict(title="round", dtick=1, range=[0.5, n_rounds + 0.5]),
+        yaxis=dict(title="error (m)", range=[0, ymax]),
         legend=dict(orientation="h", y=-0.22),
-        updatemenus=[dict(
-            type="buttons", showactive=False, direction="left", x=1, xanchor="right", y=1.15, yanchor="top",
-            buttons=[
-                dict(label="▶ Play", method="animate",
-                     args=[None, dict(frame=dict(duration=550, redraw=True), fromcurrent=True,
-                                      transition=dict(duration=300), mode="immediate")]),
-                dict(label="⏸ Pause", method="animate",
-                     args=[[None], dict(frame=dict(duration=0), mode="immediate", transition=dict(duration=0))]),
-            ],
-        )],
-        sliders=[dict(
-            active=n_rounds - 1, currentvalue=dict(prefix="Round "),
-            steps=[dict(method="animate",
-                        args=[[str(i)], dict(mode="immediate", frame=dict(duration=0, redraw=True), transition=dict(duration=0))],
-                        label=str(i)) for i in range(1, n_rounds + 1)],
-        )],
+        uirevision="err",
     )
     return fig
 
 
+def _render(sw, rnd):
+    if sw is None:
+        return gr.update(), gr.update()
+    return _anim_compare(sw, rnd), _err_anim(sw, rnd)
+
+
+def play(sw, rnd):
+    if sw is None:
+        return gr.update(), gr.update(), gr.update(), gr.Timer(active=False)
+    n_rounds = len(sw.rounds)
+    rnd = int(rnd or 1)
+    if rnd >= n_rounds:  # at the end: start over
+        rnd = 1
+    a, e = _render(sw, rnd)
+    return a, e, gr.update(value=rnd, maximum=n_rounds), gr.Timer(active=True)
+
+
+def tick(sw, rnd):
+    if sw is None:
+        return gr.update(), gr.update(), gr.update(), gr.Timer(active=False)
+    n_rounds = len(sw.rounds)
+    rnd = min(int(rnd or 0) + 1, n_rounds)
+    a, e = _render(sw, rnd)
+    return a, e, gr.update(value=rnd), gr.Timer(active=rnd < n_rounds)
+
+
+def pause():
+    return gr.Timer(active=False)
+
+
+def restart(sw):
+    if sw is None:
+        return gr.update(), gr.update(), gr.update(), gr.Timer(active=False)
+    a, e = _render(sw, 1)
+    return a, e, gr.update(value=1), gr.Timer(active=False)
+
+
+def scrub(sw, rnd):
+    a, e = _render(sw, rnd)
+    return a, e, gr.Timer(active=False)
+
+
 def _kpis(sw, n, att):
     rs = sw.rounds; acc = sum(r["accepted"] for r in rs)
     te = [r["trusted_err"] for r in rs if r["trusted_err"] is not None]
@@ -459,8 +441,10 @@ def run(n, poisoner, equivocator, impersonator, loss, lose_lead, rounds, seed):
            "cosigners": last["cosigners"], "cosignatures": last["cosignatures"], "public_keys": sw.pki}
     path = tempfile.NamedTemporaryFile("w", suffix="-receipt.json", delete=False).name
     json.dump(rec, open(path, "w"), indent=2)
-    return (_story(sw), _kpis(sw, n, att), _anim_compare(sw), _err_anim(sw), sw.trust_table(), log, rec, path, sw,
-            "Receipt not yet checked. Press **Verify the last receipt**.")
+    nr = len(sw.rounds)
+    return (_story(sw), _kpis(sw, n, att), _anim_compare(sw, nr), _err_anim(sw, nr), sw.trust_table(), log, rec, path, sw,
+            "Receipt not yet checked. Press **Verify the last receipt**.",
+            gr.update(value=nr, maximum=nr), gr.Timer(active=False))
 
 
 def verify(sw):
@@ -488,10 +472,16 @@ with gr.Blocks(title="Trusted Swarms: leaderless, poison-proof shared mission st
         with gr.Column(scale=3):
             story = gr.Markdown()
             kpis = gr.Markdown()
+    with gr.Row(equal_height=True):
+        play_btn = gr.Button("▶ Play", variant="primary", scale=1, min_width=100)
+        pause_btn = gr.Button("⏸ Pause", scale=1, min_width=100)
+        restart_btn = gr.Button("⟲ Restart", scale=1, min_width=100)
+        rnd = gr.Slider(1, 8, value=8, step=1, label="Round (drag to scrub)", scale=4)
+    timer = gr.Timer(0.9, active=False)
     with gr.Row():
-        anim = gr.Plot(label="Side-by-side mission animation")
+        anim = gr.Plot(label="Side-by-side mission animation", show_label=False)
     with gr.Row():
-        er = gr.Plot(label="Error over rounds")
+        er = gr.Plot(label="Error over rounds", show_label=False)
     with gr.Row():
         with gr.Column():
             gr.Markdown("**Trust in each drone** (E4 trust layer; ≤ 0.1 in any dimension = dropped by every honest drone)")
@@ -510,8 +500,13 @@ with gr.Blocks(title="Trusted Swarms: leaderless, poison-proof shared mission st
     with gr.Column(elem_classes="sec"):
         gr.Markdown(S4); gr.Markdown(S5); gr.Markdown(S6); gr.Markdown(FOOT)
     ins = [n, p, e, i, loss, ll, rounds, seed]
-    outs = [story, kpis, anim, er, tt, lg, rj, fl, state, vo]
+    outs = [story, kpis, anim, er, tt, lg, rj, fl, state, vo, rnd, timer]
     go_btn.click(run, ins, outs)
+    play_btn.click(play, [state, rnd], [anim, er, rnd, timer], show_progress="hidden")
+    timer.tick(tick, [state, rnd], [anim, er, rnd, timer], show_progress="hidden")
+    pause_btn.click(pause, None, timer, show_progress="hidden")
+    restart_btn.click(restart, state, [anim, er, rnd, timer], show_progress="hidden")
+    rnd.release(scrub, [state, rnd], [anim, er, timer], show_progress="hidden")
     vb.click(verify, state, vo)
     demo.load(run, ins, outs)