auto / tests /test_admin_email_validation.py
rsnarsna
feat(admin): whitelist narayanansubramani14@gmail.com and sync blog specs for logic-first manifesto
3721a3e
Raw History Blame Contribute Delete
4.19 kB
"""
Tests for Centralized Admin Email Validation & Triage Desk Access
Verifies database-backed admin whitelist, access verification, and RBAC enforcement.
"""
import pytest
from fastapi.testclient import TestClient
from main import app
from database.mongo import workflow_repo
@pytest.fixture
def client():
return TestClient(app)
def test_admin_repo_email_whitelist_operations():
"""Verify AdminRepoMixin correctly checks, adds, and removes admin emails."""
# Seeded dev admins should be valid
assert workflow_repo.is_admin_email("admin@alli.io") is True
assert workflow_repo.is_admin_email("ADMIN@ALLI.IO") is True # Case insensitive
assert workflow_repo.is_admin_email("owner@alli.io") is True
assert workflow_repo.is_admin_email("narayanansubramani14@gmail.com") is True
# Unknown emails should be false
assert workflow_repo.is_admin_email("random_user@domain.com") is False
assert workflow_repo.is_admin_email(None) is False
assert workflow_repo.is_admin_email("") is False
# Add dynamic admin
new_admin = "security_lead@company.org"
doc = workflow_repo.add_admin_email(new_admin, role="super_admin", added_by="test_suite")
assert doc["email"] == new_admin
assert workflow_repo.is_admin_email(new_admin) is True
# List admin emails
admin_list = workflow_repo.list_admin_emails()
emails = {item["email"] for item in admin_list}
assert new_admin in emails
# Remove dynamic admin
removed = workflow_repo.remove_admin_email(new_admin)
assert removed is True
assert workflow_repo.is_admin_email(new_admin) is False
def test_api_admin_check_access_endpoint(client):
"""Verify GET /api/admin/check-access validates admin presence in DB."""
# Check default seeded admin
res = client.get("/api/admin/check-access?email=admin@alli.io")
assert res.status_code == 200
data = res.json()
assert data["is_admin"] is True
assert data["email"] == "admin@alli.io"
assert data["role"] == "admin"
# Check non-admin
res_non = client.get("/api/admin/check-access?email=unauthorized@test.com")
assert res_non.status_code == 200
data_non = res_non.json()
assert data_non["is_admin"] is False
assert data_non["role"] == "none"
def test_api_feedback_admin_access_with_whitelisted_email(client):
"""Verify feedback administrative queue enforces database email check."""
# Non-admin email should be rejected with 403
res_denied = client.get(
"/api/feedback/admin/all",
headers={"X-User-Email": "unauthorized_dev@random.com", "X-User-Id": "u_999"},
)
assert res_denied.status_code == 403
assert "Admin privileges required" in res_denied.json()["detail"]
# Authorized admin email should succeed
res_allowed = client.get(
"/api/feedback/admin/all",
headers={"X-User-Email": "admin@alli.io", "X-User-Id": "u_admin"},
)
assert res_allowed.status_code == 200
assert isinstance(res_allowed.json(), list)
def test_admin_email_management_endpoints(client):
"""Verify /api/admin/emails endpoints are protected and manage DB state."""
# Non-admin rejected
res_fail = client.get(
"/api/admin/emails",
headers={"X-User-Email": "viewer@test.com"},
)
assert res_fail.status_code == 403
# Admin allowed to list
res_ok = client.get(
"/api/admin/emails",
headers={"X-User-Email": "admin@alli.io"},
)
assert res_ok.status_code == 200
assert any(item["email"] == "admin@alli.io" for item in res_ok.json())
# Admin allowed to add new admin
add_res = client.post(
"/api/admin/emails",
json={"email": "newly_promoted@alli.io", "role": "admin"},
headers={"X-User-Email": "admin@alli.io"},
)
assert add_res.status_code == 201
assert workflow_repo.is_admin_email("newly_promoted@alli.io") is True
# Admin allowed to remove
del_res = client.delete(
"/api/admin/emails/newly_promoted@alli.io",
headers={"X-User-Email": "admin@alli.io"},
)
assert del_res.status_code == 200
assert workflow_repo.is_admin_email("newly_promoted@alli.io") is False