refactor: Optimize YouTube comment generation and improve error handling

app/routes/commend/gemini_service.py

@@ -1,7 +1,6 @@
 """
 Gemini AI Service for Crown Commend
-Generates contextual YouTube comments using Google's Gemini API.
-Uses the new google.genai package (replacing deprecated google.generativeai).
+Token-optimized YouTube comment generation.
 """
 
 from __future__ import annotations
@@ -10,13 +9,11 @@ import os
 from typing import Optional, Tuple, List, Dict, Any
 
 from google import genai
-from google.genai import types
 
 from ...services.logging_config import get_logger
 
 logger = get_logger(__name__)
 
-# Gemini client configuration
 _client = None
 
 
@@ -29,42 +26,58 @@ def _get_client():
 
     api_key = os.getenv('COMMEND_GEMINI_API_KEY')
     if not api_key:
-        raise ValueError("COMMEND_GEMINI_API_KEY environment variable is required")
+        raise ValueError("COMMEND_GEMINI_API_KEY required")
 
     try:
         _client = genai.Client(api_key=api_key)
-        logger.info("Gemini client initialized successfully")
+        logger.info("Gemini initialized")
         return _client
     except Exception as e:
-        logger.error(f"Failed to initialize Gemini: {e}")
-        raise ValueError(f"Gemini initialization failed: {e}")
+        logger.error(f"Gemini init failed: {e}")
+        raise ValueError(f"Gemini failed: {e}")
 
 
 def summarize_transcript(transcript_text: str, language: str) -> Tuple[Optional[str], Optional[str]]:
-    """Video transcript'ini özetler."""
+    """Transcript özeti - max 2000 karakter input."""
     try:
         client = _get_client()
 
         if not transcript_text or len(transcript_text.strip()) < 50:
-            return None, "Insufficient transcript data"
+            return None, "No transcript"
 
-        prompt = f"""
-Bu video transcript'ini {language} dilinde 2-3 cümlelik kısa bir özet haline getir:
+        # Token tasarrufu: max 2000 karakter al
+        text = transcript_text[:2000]
 
-{transcript_text}
-
-ONEMLI: Sadece özetin kendisini yaz, başka açıklama yapma.
-"""
+        prompt = f"Summarize in {language}, 1-2 sentences only:\n{text}"
 
         response = client.models.generate_content(
             model="gemini-2.0-flash",
             contents=prompt
         )
-        return response.text.strip(), None
+        return response.text.strip()[:500], None
 
     except Exception as e:
-        logger.error(f"Transcript summarization error: {e}")
-        return None, "Failed to summarize transcript"
+        logger.error(f"Summary error: {e}")
+        return None, "Summary failed"
+
+
+# Disclaimer mapping - sabit, prompt'a dahil etmiyoruz
+DISCLAIMERS = {
+    'Turkish': '\n\nNot: Bu yorum AI tarafından üretilmiştir.',
+    'English': '\n\nNote: This comment was generated by AI.',
+    'Russian': '\n\nПримечание: Этот комментарий создан ИИ.',
+    'Chinese': '\n\n注：此评论由AI生成。',
+    'Japanese': '\n\n注：このコメントはAIによって生成されました。'
+}
+
+# Style mapping - kısa açıklamalar
+STYLES = {
+    'supportive': 'positive, encouraging',
+    'analytical': 'thoughtful, detailed',
+    'humorous': 'witty, fun',
+    'curious': 'asking questions',
+    'professional': 'formal, respectful'
+}
 
 
 def generate_comment(
@@ -75,99 +88,75 @@ def generate_comment(
     transcript_summary: Optional[str] = None
 ) -> Tuple[Optional[str], Optional[str]]:
     """
-    AI-powered comment generation using Gemini.
-
-    Args:
-        video_details: Video metadata (title, channel, stats, etc.)
-        comment_style: Style preference (supportive, analytical, humorous, etc.)
-        language: Target language for the comment
-        existing_comments: Sample comments from the video
-        transcript_summary: Optional transcript summary
-
-    Returns:
-        (generated_comment, error_message)
+    Token-optimized comment generation.
+    ~300-400 tokens input hedefi.
     """
     try:
         client = _get_client()
 
-        # Format existing comments
-        comment_section = "No comments available to analyze."
-        if existing_comments:
-            comment_section = "\n".join(
-                [f"- '{c['text'][:150]}' (by {c['author']})" for c in existing_comments[:5]]
-            )
-
-        # Build the prompt
-        prompt = f"""
-### GOREV ###
-Sen Crown Commend AI'sin - YouTube videolarına özgün, yaratıcı ve değerli yorumlar üreten bir yapay zeka.
-Yorum dili: **{language}**
-
-### VIDEO ANALIZI ###
-
-**Mevcut Yorumlar (ONCELIKLI):**
-{comment_section}
-
-**Video Icerigi:**
-{f"- Ozet: {transcript_summary}" if transcript_summary else "- Icerik ozeti mevcut degil"}
-
-**Video Bilgileri:**
-- Baslik: {video_details.get('title', 'Bilinmiyor')}
-- Kanal: {video_details.get('channelName', 'Bilinmiyor')}
-- Aciklama: {video_details.get('description', '')[:300]}
-
-**Istatistikler:**
-- Izlenme: {video_details.get('viewCount', 0):,}
-- Begeni: {video_details.get('likeCount', 0):,}
-- Sure: {video_details.get('duration', 0) // 60} dakika
-
-### YORUM STRATEJISI ###
-**{comment_style}** stilinde yorum yaz:
-
-1. **Gercekcilik:** Normal bir izleyici gibi yaz, abartma.
-2. **Emoji Siniri:** Hic emoji kullanma veya en fazla 1 adet kullan.
-3. **Dogallik:** Samimi ama sade bir dil kullan.
-4. **Video Odak:** Videonun icerigini ve mevcut yorumlari on planda tut.
-5. **Kisalik:** Uzun yorumlardan kacin, net ve oz ol.
-
-### YORUM KURALLARI ###
-- **Dil:** Tamamen **{language}** dilinde yaz (disclaimer dahil)
-- **Uzunluk:** 1-3 cumle arasi, kisa ve etkili
-- **Ton:** Video konusuna uygun (ciddi/eglenceli/destekleyici)
-- **Ozgunluk:** Klise ifadelerden kacin
-- **Disclaimer:** Yorumun sonuna yeni satirda disclaimer ekle:
-  - Turkish: "Not: Bu yorum AI tarafindan uretilmistir."
-  - English: "Note: This comment was generated by AI."
-  - Russian: "Primechanie: Etot kommentariy sozdan II."
-  - Chinese: "Zhu: Ci pinglun you AI shengcheng."
-  - Japanese: "Chu: Kono komento wa AI ni yotte seisei saremashita."
-
-### ORNEKLER ###
-Kotu: "Harika video! Cok begendim!"
-Iyi: "3:45'teki o detay gercekten onemli bir noktaydi, bu konuya hic bu acidan bakmamistim."
-
-**Yorumun:**
-"""
+        # Kısa video bilgisi
+        title = video_details.get('title', '')[:80]
+        channel = video_details.get('channelName', '')[:30]
+        desc = video_details.get('description', '')[:150]
+        views = video_details.get('viewCount', 0)
+
+        # Sadece en iyi 2 yorum, kısa
+        comments_text = ""
+        if existing_comments and len(existing_comments) > 0:
+            top_comments = existing_comments[:2]
+            comments_text = " | ".join([c['text'][:80] for c in top_comments])
+
+        # Özet varsa ekle (kısa)
+        summary_text = ""
+        if transcript_summary:
+            summary_text = f"Content: {transcript_summary[:200]}"
+
+        # Stil açıklaması
+        style_desc = STYLES.get(comment_style, 'natural')
+
+        # Kompakt prompt (~300 token)
+        prompt = f"""Write a YouTube comment in {language}.
+
+Video: {title}
+Channel: {channel}
+{f'Desc: {desc}' if desc else ''}
+{f'Views: {views:,}' if views else ''}
+{f'Comments: {comments_text}' if comments_text else ''}
+{summary_text}
+
+Style: {style_desc}
+Rules:
+- 1-2 sentences max
+- Sound natural, like a real viewer
+- No emojis or minimal (max 1)
+- Be specific to video content
+
+Comment:"""
 
         response = client.models.generate_content(
             model="gemini-2.0-flash",
             contents=prompt
         )
-        generated_text = response.text.strip()
 
-        # Clean up the response if needed
-        if generated_text.startswith('"') and generated_text.endswith('"'):
-            generated_text = generated_text[1:-1]
+        generated = response.text.strip()
+
+        # Tırnak temizle
+        if generated.startswith('"') and generated.endswith('"'):
+            generated = generated[1:-1]
+
+        # Disclaimer ekle
+        disclaimer = DISCLAIMERS.get(language, DISCLAIMERS['English'])
+        final_comment = generated + disclaimer
 
-        return generated_text, None
+        return final_comment, None
 
     except Exception as e:
-        logger.error(f"Comment generation error: {e}")
+        logger.error(f"Generate error: {e}")
         error_str = str(e).lower()
 
         if "api key" in error_str:
-            return None, "Invalid API key configuration"
-        elif "quota" in error_str or "limit" in error_str:
-            return None, "API quota exceeded, please try again later"
+            return None, "Invalid API key"
+        elif "quota" in error_str or "limit" in error_str or "resource" in error_str:
+            return None, "API quota exceeded"
         else:
-            return None, f"Failed to generate comment: {str(e)}"
+            return None, f"Generation failed: {str(e)}"