fix: update analysis and commend endpoints with additional tests and default values

app/routes/analyze.py

@@ -32,7 +32,7 @@ class AnalysisFeatures(BaseModel):
     spectralRegularity: float = 0.5
     temporalPatterns: float = 0.5
     harmonicStructure: float = 0.5
-    artificialIndicators: List[str] = []
+    artificialIndicators: List[str] = Field(default_factory=list)
 
 
 class AudioInfo(BaseModel):
@@ -62,8 +62,8 @@ class AnalyzeResponse(BaseModel):
     """Response model for analysis endpoint."""
 
     result: Optional[AnalysisResult] = None
-    warnings: List[str] = []
-    errors: List[str] = []
+    warnings: List[str] = Field(default_factory=list)
+    errors: List[str] = Field(default_factory=list)
 
 
 @router.post("/api/analyze", response_model=AnalyzeResponse)

tests/test_analyze.py

@@ -0,0 +1,104 @@
+"""Tests for /api/analyze endpoint."""
+
+from __future__ import annotations
+
+import io
+
+from fastapi.testclient import TestClient
+
+
+def test_analyze_missing_source_type(client: TestClient) -> None:
+    """Analyze should reject a request without sourceType."""
+    response = client.post("/api/analyze")
+    assert response.status_code == 422
+
+
+def test_analyze_invalid_source_type(client: TestClient) -> None:
+    """Analyze should return error for unknown sourceType."""
+    response = client.post(
+        "/api/analyze",
+        data={"sourceType": "unknown"},
+    )
+    assert response.status_code == 200
+    data = response.json()
+    assert "invalid_source_type" in data["errors"]
+    assert data["result"] is None
+
+
+def test_analyze_unsupported_source(client: TestClient) -> None:
+    """Analyze should return unsupported_source for spotify/apple."""
+    for source in ("spotify", "apple"):
+        response = client.post(
+            "/api/analyze",
+            data={"sourceType": source},
+        )
+        assert response.status_code == 200
+        data = response.json()
+        assert "unsupported_source" in data["errors"]
+
+
+def test_analyze_youtube_missing_url(client: TestClient) -> None:
+    """Analyze youtube without url should return missing_url error."""
+    response = client.post(
+        "/api/analyze",
+        data={"sourceType": "youtube"},
+    )
+    assert response.status_code == 200
+    data = response.json()
+    assert "missing_url" in data["errors"]
+
+
+def test_analyze_file_missing_file(client: TestClient) -> None:
+    """Analyze file without upload should return missing_file error."""
+    response = client.post(
+        "/api/analyze",
+        data={"sourceType": "file"},
+    )
+    assert response.status_code == 200
+    data = response.json()
+    assert "missing_file" in data["errors"]
+
+
+def test_analyze_file_invalid_type(client: TestClient) -> None:
+    """Analyze should reject non-audio file."""
+    fake_file = io.BytesIO(b"not audio content " * 100)
+    response = client.post(
+        "/api/analyze",
+        data={"sourceType": "file"},
+        files={"file": ("test.txt", fake_file, "text/plain")},
+    )
+    assert response.status_code == 200
+    data = response.json()
+    assert "invalid_file_type" in data["errors"]
+
+
+def test_analyze_file_too_small(client: TestClient) -> None:
+    """Analyze should reject files smaller than 1KB."""
+    tiny_file = io.BytesIO(b"\x00" * 100)
+    response = client.post(
+        "/api/analyze",
+        data={"sourceType": "file"},
+        files={"file": ("tiny.wav", tiny_file, "audio/wav")},
+    )
+    assert response.status_code == 200
+    data = response.json()
+    assert "file_too_small" in data["errors"]
+
+
+def test_analyze_file_happy_path(client: TestClient) -> None:
+    """Analyze with a valid audio file should return a preview result."""
+    audio_content = b"\x00" * 2048
+    fake_audio = io.BytesIO(audio_content)
+    response = client.post(
+        "/api/analyze",
+        data={"sourceType": "file"},
+        files={"file": ("test.wav", fake_audio, "audio/wav")},
+    )
+    assert response.status_code == 200
+    data = response.json()
+    assert data["result"] is not None
+    result = data["result"]
+    assert "isAIGenerated" in result
+    assert "confidence" in result
+    assert result["analysisMode"] == "preview"
+    assert result["decisionSource"] == "preview"

tests/test_commend.py

@@ -15,6 +15,15 @@ def test_commend_health(client: TestClient) -> None:
     assert "youtubeConfigured" in data
 
 
+def test_commend_styles(client: TestClient) -> None:
+    """Styles endpoint should return available comment styles."""
+    response = client.get("/api/commend/styles")
+    assert response.status_code == 200
+    data = response.json()
+    assert "styles" in data
+    assert len(data["styles"]) > 0
+
+
 def test_commend_generate_rejects_invalid_url(client: TestClient) -> None:
     """Generate endpoint should reject a non-YouTube URL."""
     response = client.post(
@@ -25,4 +34,30 @@ def test_commend_generate_rejects_invalid_url(client: TestClient) -> None:
             "style": "supportive",
         },
     )
-    assert response.status_code in (400, 422)
+    assert response.status_code in (400, 401, 422)
+
+
+def test_commend_generate_rejects_empty_url(client: TestClient) -> None:
+    """Generate endpoint should reject empty URL."""
+    response = client.post(
+        "/api/commend/generate",
+        json={
+            "url": "",
+            "language": "en",
+            "style": "supportive",
+        },
+    )
+    assert response.status_code in (400, 401, 422)
+
+
+def test_commend_post_disabled_by_default(client: TestClient) -> None:
+    """Post endpoint should be disabled by default (feature flag)."""
+    response = client.post(
+        "/api/commend/post",
+        json={
+            "videoId": "dQw4w9WgXcQ",
+            "comment": "Test comment",
+        },
+    )
+    # Either 401 (auth) or 403 (feature flag disabled)
+    assert response.status_code in (401, 403, 422)

tests/test_data_processing.py

@@ -0,0 +1,40 @@
+"""Tests for /api/process/audio endpoint."""
+
+from __future__ import annotations
+
+import io
+
+from fastapi.testclient import TestClient
+
+
+def test_audio_rejects_non_audio(client: TestClient) -> None:
+    """Should reject non-audio content type."""
+    fake = io.BytesIO(b"not audio")
+    response = client.post(
+        "/api/process/audio",
+        data={"options": '{"pitch_shift": 0}'},
+        files={"file": ("test.txt", fake, "text/plain")},
+    )
+    assert response.status_code == 400
+    assert "audio" in response.json()["detail"].lower()
+
+
+def test_audio_rejects_missing_content_type(client: TestClient) -> None:
+    """Should reject file with no content type."""
+    fake = io.BytesIO(b"some bytes")
+    response = client.post(
+        "/api/process/audio",
+        data={"options": '{"pitch_shift": 0}'},
+        files={"file": ("test.bin", fake, "")},
+    )
+    # Empty content_type should be treated as invalid
+    assert response.status_code == 400
+
+
+def test_audio_rejects_missing_file(client: TestClient) -> None:
+    """Should reject request without file."""
+    response = client.post(
+        "/api/process/audio",
+        data={"options": '{"pitch_shift": 0}'},
+    )
+    assert response.status_code == 422