Make player last name optional

src/admin.ts

@@ -15,7 +15,8 @@ const profileSchema = z.object({
   academy: z.string().trim().max(150).nullable(), role: z.string().trim().max(50).nullable(),
 }).strict();
 const playerSchema = z.object({
-  name: z.string().trim().min(1).max(200), age: z.number().int().min(4).max(60).nullable().optional(),
+  fname: z.string().trim().min(1).max(100), lname: z.string().trim().max(100).optional().default(""),
+  age: z.number().int().min(4).max(60).nullable().optional(),
   heightCm: z.number().min(100).max(230).nullable().optional(), weightKg: z.number().min(20).max(150).nullable().optional(),
   club: z.string().trim().max(150).nullable().optional(), position: z.string().trim().max(50).nullable().optional(),
   gender: z.enum(["male", "female"]).nullable().optional(), userId: uuid.nullable().optional(),
@@ -26,10 +27,6 @@ function asyncRoute(handler: (req: Request, res: Response) => Promise<unknown>)
   return (req: Request, res: Response, next: NextFunction) => { void handler(req, res).catch(next); };
 }
 async function admin(req: Request, res: Response) { return requireAdmin(req, res); }
-function playerName(name: string) {
-  const [fname, ...parts] = name.split(/\s+/);
-  return { fname, lname: parts.join(" ") };
-}
 function ageDate(age?: number | null) {
   if (age == null) return null;
   const birth = new Date();
@@ -200,11 +197,10 @@ export function registerAdminRoutes(app: Express) {
       if (error) throw new Error(`Unable to verify player owner: ${error.message}`);
       if (!data) return fail(res, 404, "Player owner not found.");
     }
-    const { fname, lname } = playerName(input.data.name);
     const { data, error } = await supabaseAdmin.rpc("admin_create_player", {
       p_user_id: input.data.userId ?? null,
-      p_fname: fname,
-      p_lname: lname,
+      p_fname: input.data.fname,
+      p_lname: input.data.lname,
       p_bdate: ageDate(input.data.age),
       p_height: input.data.heightCm ?? null,
       p_weight: input.data.weightKg ?? null,

src/server.ts

@@ -72,17 +72,24 @@ const actionReviewSchema = z.object({
   feedback: z.array(z.string().trim().min(1).max(2000)).max(30),
 }).strict();
 const playerProfileSchema = z.object({
-  name: z.string().trim().min(1).max(200),
+  fname: z.string().trim().min(1).max(100).optional(),
+  lname: z.string().trim().max(100).optional(),
+  name: z.string().trim().max(200).optional(),
   age: z.string().regex(/^(|\d{1,2})$/),
   heightCm: z.string().regex(/^(|\d{2,3}(?:\.\d{1,2})?)$/),
   weightKg: z.string().regex(/^(|\d{1,3}(?:\.\d{1,2})?)$/),
   club: z.string().trim().max(150),
   position: z.string().trim().max(50),
   gender: z.union([z.enum(["male", "female"]), z.literal("")]),
-}).strict();
+}).strict().transform((input) => {
+  const legacyNameParts = (input.name ?? "").split(/\s+/).filter(Boolean);
+  const fname = input.fname ?? legacyNameParts.shift() ?? "";
+  const lname = input.lname ?? legacyNameParts.join(" ");
+  return { ...input, fname, lname };
+}).refine((input) => Boolean(input.fname), { message: "First name is required." });
 const playerCreateSchema = z.object({
   fname: z.string().trim().min(1).max(100),
-  lname: z.string().trim().min(1).max(100),
+  lname: z.string().trim().max(100).optional().default(""),
   age: z.string().regex(/^(|\d{1,2})$/),
   heightCm: z.string().regex(/^(|\d{2,3}(?:\.\d{1,2})?)$/),
   weightKg: z.string().regex(/^(|\d{1,3}(?:\.\d{1,2})?)$/),
@@ -290,6 +297,8 @@ app.get("/api/owned-players", async (req, res, next) => {
     const ownedPlayers = admin ? data ?? [] : (data ?? []).filter((player) => player.user_id === current.user.id);
     return res.json({ players: ownedPlayers.map((player) => ({
       playerId: player.player_id,
+      fname: player.fname ?? "",
+      lname: player.lname ?? "",
       name: [player.fname, player.lname].filter(Boolean).join(" "),
       isOwner: player.user_id === current.user.id,
       position: player.position ?? "",
@@ -321,7 +330,7 @@ app.post("/api/players", async (req, res, next) => {
     const { data, error } = await supabaseAdmin.from("players").insert({
       user_id: current.user.id,
       fname: input.fname,
-      lname: input.lname,
+      lname: input.lname || "",
       bdate: birthday,
       height,
       weight,
@@ -338,6 +347,8 @@ app.post("/api/players", async (req, res, next) => {
     if (error) throw new Error(`Unable to create player: ${error.message}`);
     return res.status(201).json({ player: {
       playerId: data.player_id,
+      fname: data.fname ?? "",
+      lname: data.lname ?? "",
       name: [data.fname, data.lname].filter(Boolean).join(" "),
       position: data.position ?? "",
       club: data.club ?? "",
@@ -364,9 +375,6 @@ app.put("/api/players/:playerId", async (req, res, next) => {
       .select("player_id,bdate").eq("player_id", id.data).eq("user_id", current.user.id).maybeSingle();
     if (readError) throw new Error(`Unable to load player: ${readError.message}`);
     if (!existing) return res.status(404).json({ error: "Player not found." });
-    const [fname, ...lastParts] = input.name.split(/\s+/);
-    const lname = lastParts.join(" ");
-    if (fname.length > 100 || lname.length > 100) return res.status(400).json({ error: "Player first and last names must be 100 characters or fewer." });
     let birthday = existing.bdate;
     if (age === null) birthday = null;
     else if (ageFromBirthday(existing.bdate) !== String(age)) {
@@ -375,8 +383,8 @@ app.put("/api/players/:playerId", async (req, res, next) => {
       birthday = date.toISOString().slice(0, 10);
     }
     const { error } = await supabaseAdmin.from("players").update({
-      fname,
-      lname,
+      fname: input.fname,
+      lname: input.lname || "",
       bdate: birthday,
       height,
       weight,
@@ -491,6 +499,8 @@ app.get("/api/players-overview", async (req, res, next) => {
       return {
         playerId: row.player_id,
         isOwner: row.user_id === current.user.id,
+        fname: row.fname ?? "",
+        lname: row.lname ?? "",
         name: [row.fname, row.lname].filter(Boolean).join(" "),
         age: ageFromBirthday(row.bdate),
         heightCm: row.height == null ? "" : String(row.height),
@@ -573,7 +583,7 @@ app.get("/api/players-overview/:playerId", async (req, res, next) => {
     const rankIndex = rankedPlayers.findIndex((entry) => entry.id === playerId.data);
     const squadAverage = { byQuality: [], byAction: squadByAction };
     return res.json({
-      playerId: player.player_id, name: [player.fname, player.lname].filter(Boolean).join(" "),
+      playerId: player.player_id, fname: player.fname ?? "", lname: player.lname ?? "", name: [player.fname, player.lname].filter(Boolean).join(" "),
       isOwner: player.user_id === current.user.id,
       age: ageFromBirthday(player.bdate),
       heightCm: player.height == null ? "" : String(player.height), weightKg: player.weight == null ? "" : String(player.weight),