Normalize player ratings to a 100-point scale

src/server.ts

@@ -63,6 +63,11 @@ const actionReviewSchema = z.object({
   feedback: z.array(z.string().trim().min(1).max(2000)).max(30),
 }).strict();
 
+// Stored coach ratings use a 0–10 scale. Player dashboards use a 0–100 scale.
+const meanPlayerScore = (values: number[]) => values.length
+  ? values.reduce((sum, value) => sum + value, 0) / values.length * 10
+  : null;
+
 
 async function requireActiveSubscription(req: Request, res: Response) {
   const current = await authenticatedUser(req, res);
@@ -150,12 +155,12 @@ app.get("/api/players-overview", async (req, res, next) => {
       const byAction = [...new Set(playerActions.map((action) => action.type))].map((type) => {
         const matching = playerActions.filter((action) => action.type === type);
         const values = matching.map((action) => scoresByAction.get(action.action_id)).filter((score): score is number => score != null && Number.isFinite(score));
-        return { axis: type, score: values.length ? values.reduce((sum, value) => sum + value, 0) / values.length : null, samples: values.length };
+        return { axis: type, score: meanPlayerScore(values), samples: values.length };
       });
       const playerScoreSessions = playerSessions.map((session) => {
         const sessionActions = actionsBySession.get(session.session_id) ?? [];
         const values = sessionActions.map((action) => scoresByAction.get(action.action_id)).filter((score): score is number => score != null && Number.isFinite(score));
-        return { sessionId: session.session_id, createdAt: Date.parse(session.created_at) || 0, score: values.length ? values.reduce((sum, value) => sum + value, 0) / values.length : null, actionCount: sessionActions.length, scoredCount: values.length };
+        return { sessionId: session.session_id, createdAt: Date.parse(session.created_at) || 0, score: meanPlayerScore(values), actionCount: sessionActions.length, scoredCount: values.length };
       });
       return {
         playerId: row.player_id,
@@ -170,7 +175,7 @@ app.get("/api/players-overview", async (req, res, next) => {
         scores: {
           playerId: row.player_id, rubricVersion: "database", totalActions: playerActions.length,
           scoredActions: scored.length, byAction, byQuality: [],
-          overall: scored.length ? scored.reduce((sum, value) => sum + value, 0) / scored.length : null,
+          overall: meanPlayerScore(scored),
           sessions: playerScoreSessions,
         },
       };
@@ -215,18 +220,38 @@ app.get("/api/players-overview/:playerId", async (req, res, next) => {
     const byAction = [...new Set(ownActions.map((row) => row.type))].map((type) => {
       const matching = ownActions.filter((row) => row.type === type);
       const values = matching.map((row) => scoreMap.get(row.action_id)).filter((score): score is number => score != null && Number.isFinite(score));
-      return { axis: type, score: values.length ? values.reduce((sum, value) => sum + value, 0) / values.length : null, samples: values.length };
+      return { axis: type, score: meanPlayerScore(values), samples: values.length };
+    });
+    const sessionPlayerById = new Map((sessions ?? []).map((row) => [row.session_id, row.player_id]));
+    const squadActions = (actions ?? []).filter((action) => {
+      const ownerId = sessionPlayerById.get(action.session_id);
+      return Boolean(ownerId) && ownerId !== playerId.data;
+    });
+    const squadByAction = [...new Set(squadActions.map((action) => action.type))].map((type) => {
+      const matching = squadActions.filter((action) => action.type === type);
+      const values = matching.map((action) => scoreMap.get(action.action_id)).filter((score): score is number => score != null && Number.isFinite(score));
+      return { axis: type, score: meanPlayerScore(values), samples: values.length };
     });
     const player = overview?.find((row) => row.player_id === playerId.data);
     if (!player) return res.status(404).json({ error: "Player not found." });
     const sessionsForPlayer = ownSessions.map((row) => {
       const sessionActions = ownActions.filter((action) => action.session_id === row.session_id);
       const values = sessionActions.map((action) => scoreMap.get(action.action_id)).filter((score): score is number => score != null && Number.isFinite(score));
-      return { sessionId: row.session_id, createdAt: Date.parse(row.created_at) || 0, score: values.length ? values.reduce((sum, value) => sum + value, 0) / values.length : null, actionCount: sessionActions.length, scoredCount: values.length };
+      return { sessionId: row.session_id, createdAt: Date.parse(row.created_at) || 0, score: meanPlayerScore(values), actionCount: sessionActions.length, scoredCount: values.length };
     });
     const { data: peers, error: peersError } = await supabaseAdmin.from("players").select("player_id");
     if (peersError) throw new Error(`Unable to load roster: ${peersError.message}`);
-    const squadAverage = { byQuality: [], byAction };
+    const playerScores = new Map<string, number[]>();
+    for (const action of actions ?? []) {
+      const ownerId = sessionPlayerById.get(action.session_id);
+      const score = scoreMap.get(action.action_id);
+      if (ownerId && score != null && Number.isFinite(score)) playerScores.set(ownerId, [...(playerScores.get(ownerId) ?? []), score]);
+    }
+    const rankedPlayers = [...playerScores.entries()]
+      .map(([id, values]) => ({ id, score: meanPlayerScore(values)! }))
+      .sort((a, b) => b.score - a.score);
+    const rankIndex = rankedPlayers.findIndex((entry) => entry.id === playerId.data);
+    const squadAverage = { byQuality: [], byAction: squadByAction };
     return res.json({
       playerId: player.player_id, name: [player.fname, player.lname].filter(Boolean).join(" "),
       age: player.bdate ? String(Math.max(0, new Date().getFullYear() - new Date(player.bdate).getFullYear())) : "",
@@ -234,8 +259,8 @@ app.get("/api/players-overview/:playerId", async (req, res, next) => {
       club: player.club ?? "", position: player.position ?? "", dominantFoot: "", notes: "", avatarPath: "",
       createdAt: "", updatedAt: "", hasProfile: true, sessionCount: ownSessions.length, actionCount: ownActions.length,
       lastSessionAt: sessionsForPlayer[0]?.createdAt ?? 0,
-      scores: { playerId: player.player_id, rubricVersion: "database", totalActions: ownActions.length, scoredActions: ownScores.length, byAction, byQuality: [], overall: ownScores.length ? ownScores.reduce((sum, value) => sum + value, 0) / ownScores.length : null, sessions: sessionsForPlayer },
-      squadAverage, rank: null, playerCount: peers?.length ?? 0,
+      scores: { playerId: player.player_id, rubricVersion: "database", totalActions: ownActions.length, scoredActions: ownScores.length, byAction, byQuality: [], overall: meanPlayerScore(ownScores), sessions: sessionsForPlayer },
+      squadAverage, rank: rankIndex < 0 ? null : rankIndex + 1, playerCount: peers?.length ?? 0,
     });
   } catch (error) { next(error); }
 });