Update app.py

app.py

@@ -2,76 +2,73 @@ import os
 import gradio as gr
 from docx import Document
 import datetime
-from groq import Groq
 from huggingface_hub import InferenceClient
 
-# ✅ Initialize Groq client (for English)
-GROQ_API_KEY = os.getenv("GROQ_API_KEY")
-client_groq = Groq(api_key=GROQ_API_KEY)
+# ✅ Load your Hugging Face token from environment (set it in HF Spaces or locally)
+HF_TOKEN = os.getenv("HF_TOKEN")
 
-# ✅ Initialize Zephyr model client (for Urdu)
-urdu_model = InferenceClient(model="HuggingFaceH4/zephyr-7b-beta")
+# ✅ Initialize Hugging Face client
+client = InferenceClient(
+    model="tiiuae/falcon-7b-instruct", 
+    token=HF_TOKEN
+)
 
-def generate_lesson_plan(class_, subject, topic, students, duration, date, teacher, language):
-    try:
-        # ========================= Urdu MODE ==========================
-        if language == "Urdu":
-            prompt = f"""
+def generate_lesson_plan(language, class_, subject, topic, students, duration, date, teacher):
+    if language == "Urdu":
+        prompt = f"""
 آپ ایک تجربہ کار استاد ہیں۔
-موضوع "{topic}" کے لیے BOPPPS ماڈل کے مطابق ایک مکمل سبق کا منصوبہ (Lesson Plan) تیار کریں۔
-سبق کا متن فصیح اور درست اردو میں ہو، اور درج ذیل حصے شامل ہوں:
-1. Bridge-In: سبق کے آغاز کے لیے ایک دلچسپ اور متوجہ کرنے والا پیراگراف۔
-2. تین واضح تعلیمی مقاصد۔
-3. دو پیشگی سوالات (Pre-Assessment)۔
-4. ایک تفصیلی تدریسی سرگرمی (Participatory Learning Activity)۔
-5. دو سے تین بعد از تدریس سوالات (Post-Assessment)۔
-6. استاد کی طرف سے ایک مختصر اختتامی خلاصہ پیراگراف۔
-نوٹ: بنیادی معلومات (جیسے کلاس، موضوع، استاد کا نام وغیرہ) کو دوبارہ متن میں شامل نہ کریں۔
-"""
-            response = urdu_model.text_generation(
-                prompt,
-                max_new_tokens=900,
-                temperature=0.7,
-                do_sample=True
-            )
-            lesson_text = response.strip()
-
-        # ========================= English MODE ==========================
-        else:
-            prompt = f"""
-You are a professional lesson plan designer.
+براہ کرم درج ذیل موضوع پر ایک مکمل BOPPPS لیسن پلان اردو زبان میں تیار کریں۔
+موضوع: "{topic}"
+منصوبہ میں درج ذیل حصے شامل ہوں:
+1. Bridge-In: ایک مختصر دلچسپ تمہیدی پیراگراف۔
+2. 3 واضح تعلیمی مقاصد۔
+3. 2 قبل از جائزہ (Pre-Assessment) سوالات۔
+4. ایک مفصل تدریسی سرگرمی (Participatory Learning)۔
+5. 2 تا 3 بعد از جائزہ (Post-Assessment) سوالات۔
+6. سبق کا خلاصہ (Summary)۔
+براہ کرم متن کو قدرتی اور تعلیمی انداز میں اردو میں لکھیں۔
+        """
+    else:
+        prompt = f"""
+You are a professional lesson plan expert.
 Create a detailed English lesson plan using the BOPPPS model for the topic: "{topic}".
-Do not repeat the basic info (class, subject, topic, teacher etc.) in headings or body.
-Include only these structured sections:
-1. Bridge-In: engaging introduction.
-2. 3 clear Learning Objectives.
+Do not repeat the basic info (class, subject, topic, teacher etc.) again in headings or body.
+Include only the following:
+1. Bridge-In: a short, engaging paragraph.
+2. 3 Clear Learning Objectives.
 3. 2 Pre-Assessment Questions.
 4. One detailed Participatory Learning Activity.
 5. 2–3 Post-Assessment Questions.
-6. Summary paragraph by the teacher.
-"""
-            response = client_groq.chat.completions.create(
-                model="llama-3.1-8b-instant",
-                messages=[{"role": "user", "content": prompt}],
-                temperature=0.7,
-            )
-            lesson_text = response.choices[0].message.content.strip()
+6. A short Summary paragraph.
+        """
+
+    try:
+        # ✅ Generate lesson text
+        response = client.text_generation(
+            prompt,
+            max_new_tokens=800,
+            temperature=0.7,
+        )
+
+        lesson_text = response.strip()
 
         # ✅ Create Word document
         doc = Document()
-        doc.add_heading("BOPPPS سبق کا منصوبہ" if language == "Urdu" else "BOPPPS Lesson Plan", 0)
+        doc.add_heading("BOPPPS Lesson Plan", 0)
 
-        # ✅ Metadata Table
+        # Metadata table
         table = doc.add_table(rows=0, cols=2)
         data = {
-            "Class / جماعت": class_,
-            "Subject / مضمون": subject,
-            "Topic / موضوع": topic,
-            "No. of Students / طلبہ کی تعداد": students,
-            "Duration / دورانیہ": duration,
-            "Date / تاریخ": date,
-            "Teacher / استاد کا نام": teacher
+            "Language": language,
+            "Class": class_,
+            "Subject": subject,
+            "Topic": topic,
+            "No. of Students": students,
+            "Duration": duration,
+            "Date": date,
+            "Teacher": teacher
         }
+
         for key, value in data.items():
             row_cells = table.add_row().cells
             row_cells[0].text = key
@@ -81,13 +78,14 @@ Include only these structured sections:
         doc.add_paragraph(lesson_text)
         doc.add_paragraph("\nDeveloped by Najaf Ali Sharqi")
 
-        filename = f"lesson_plan_{language.lower()}_{datetime.datetime.now().strftime('%Y%m%d%H%M%S')}.docx"
+        filename = f"lesson_plan_{datetime.datetime.now().strftime('%Y%m%d%H%M%S')}.docx"
         filepath = f"/tmp/{filename}"
         doc.save(filepath)
+
         return filepath
 
     except Exception as e:
-        # Return error file instead of crash
+        # Error handling
         error_doc = Document()
         error_doc.add_heading("Error in Lesson Plan Generator", 0)
         error_doc.add_paragraph(str(e))
@@ -97,30 +95,30 @@ Include only these structured sections:
         return filepath
 
 
-# ✅ Gradio UI
+# ✅ Build Gradio UI
 with gr.Blocks() as demo:
-    gr.Markdown("## 📘 BOPPPS Lesson Plan Generator (English + Urdu — Accurate Urdu Version)")
+    gr.Markdown("## 📘 BOPPPS Lesson Plan Generator (English + Urdu)")
 
     with gr.Group():
+        language = gr.Radio(["English", "Urdu"], label="Select Language", value="English")
+
         with gr.Row():
-            class_ = gr.Textbox(label="Class / جماعت", placeholder="e.g., 9th / نہم")
-            subject = gr.Textbox(label="Subject / مضمون", placeholder="e.g., Physics / طبیعیات")
+            class_ = gr.Textbox(label="Class", placeholder="e.g., 9th")
+            subject = gr.Textbox(label="Subject", placeholder="e.g., Physics")
         with gr.Row():
-            topic = gr.Textbox(label="Topic / موضوع", placeholder="e.g., Newton’s First Law / نیوٹن کا پہلا قانون")
-            students = gr.Textbox(label="Number of Students / طلبہ کی تعداد", placeholder="e.g., 30")
+            topic = gr.Textbox(label="Topic", placeholder="e.g., Laws of Motion")
+            students = gr.Textbox(label="Number of Students", placeholder="e.g., 30")
         with gr.Row():
-            duration = gr.Textbox(label="Duration / دورانیہ", placeholder="e.g., 40")
-            date = gr.Textbox(label="Date / تاریخ", placeholder="e.g., 2025-10-05")
-        teacher = gr.Textbox(label="Teacher / استاد کا نام", placeholder="e.g., Najaf Ali Sharqi")
+            duration = gr.Textbox(label="Duration (minutes)", placeholder="e.g., 40")
+            date = gr.Textbox(label="Date", placeholder="e.g., 2025-10-05")
+        teacher = gr.Textbox(label="Teacher Name", placeholder="e.g., Najaf Ali Sharqi")
 
-        language = gr.Radio(["English", "Urdu"], label="Select Language / زبان منتخب کریں", value="English")
-
-        generate_button = gr.Button("Generate Lesson Plan / سبق کا منصوبہ تیار کریں")
-        output_file = gr.File(label="📄 Download Word File / فائل ڈاؤن لوڈ کریں")
+        generate_button = gr.Button("Generate Lesson Plan")
+        output_file = gr.File(label="📄 Download Word File")
 
     generate_button.click(
         fn=generate_lesson_plan,
-        inputs=[class_, subject, topic, students, duration, date, teacher, language],
+        inputs=[language, class_, subject, topic, students, duration, date, teacher],
         outputs=output_file
     )
 
@@ -129,3 +127,4 @@ with gr.Blocks() as demo:
 
 demo.launch()
 
+