abinazebinoy commited on
Commit
36b340f
·
1 Parent(s): 2232d85

Add keyring==25.7.0 as the 24th pinned dependency (D6 prep)

Browse files

Why: Phase D6 (API key manager / OS-keychain credential storage) needs
the keyring package. Adding it to requirements.txt first, on its own,
before config/credentials.py lands, so this dependency change can be
reviewed and verified in isolation from the actual credential-storage
logic.

Verified: real (not --dry-run) install of keyring into a clean, isolated
venv -- resolves to 25.7.0 (MIT license). Confirmed 'import keyring' and
'keyring.get_keyring()' both succeed even with no OS keychain backend
available (this sandbox has none); confirmed the failure only surfaces
at the first actual get_password()/set_password() call, raised as
NoKeyringError specifically. This is the exact failure point
config/credentials.py's error handling will be built around in the next
step, so confirming it now (rather than assuming from memory) matters.

Not done as a full-stack reinstall: keyring is small and functionally
independent of the ML/PDF stack (spacy/torch/weasyprint etc.), so it was
verified in its own isolated venv rather than re-running the ~13GB full
install used to verify the original 23 pins together. No other file
changes in this commit.

Files changed (1) hide show
  1. requirements.txt +22 -10
requirements.txt CHANGED
@@ -48,24 +48,36 @@ indic-transliteration==2.3.82
48
  weasyprint==70.0
49
  pdfplumber==0.11.10
50
 
 
 
 
 
 
 
 
 
 
 
 
 
51
  # Utilities
52
  loguru==0.7.3
53
  schedule==1.2.2
54
 
55
- # Pinning note: all 23 direct dependencies above are exact (==), not
56
  # range (>=), pins as of this commit -- resolves the audit's own
57
  # "0/20 entries exactly pinned" finding, a real reproducibility risk
58
  # specifically for a frozen/packaged desktop build (D2), where "whatever
59
  # resolves today" would otherwise get baked permanently into that one
60
- # installer. Every version here was verified together, not picked
61
- # individually: did a real (not --dry-run) full install of this exact
62
- # file into a clean venv, confirmed the app actually imports and boots
63
- # (GET /health-equivalent smoke check), and ran the full test suite
64
- # against that real environment for the first time in this project's
65
- # history with every dependency genuinely present (previous verification
66
- # passes deliberately used a lighter dependency subset to conserve
67
- # sandbox disk) -- 116 passed, 0 failed, with torch/spacy/sentence-
68
- # transformers/weasyprint all real and importable, not lazily-absent.
69
  # A full transitive-dependency lockfile (pip-compile --generate-hashes)
70
  # is a further, separate recommended step, not attempted here -- this
71
  # pins only the direct dependencies this file already declared.
 
48
  weasyprint==70.0
49
  pdfplumber==0.11.10
50
 
51
+ # Desktop credential storage (Phase D6, in progress) -- OS-keychain-backed
52
+ # storage for ADMIN_SECRET and (once a UI exists to write them, D5/D6-UI)
53
+ # NEO4J_URI/NEO4J_USER/NEO4J_PASSWORD/DATAGOV_API_KEY/OPENSANCTIONS_API_KEY.
54
+ # See config/credentials.py (not yet delivered as of this commit). Verified
55
+ # via a real, isolated install into a clean venv (25.7.0 resolved, MIT
56
+ # license); confirmed import and keyring.get_keyring() succeed even with no
57
+ # OS keychain backend available in this sandbox, and that the failure
58
+ # surfaces only at the first real get_password()/set_password() call
59
+ # (NoKeyringError) -- config/credentials.py's own try/except is written
60
+ # around that exact, empirically-confirmed failure point.
61
+ keyring==25.7.0
62
+
63
  # Utilities
64
  loguru==0.7.3
65
  schedule==1.2.2
66
 
67
+ # Pinning note: all 24 direct dependencies above are exact (==), not
68
  # range (>=), pins as of this commit -- resolves the audit's own
69
  # "0/20 entries exactly pinned" finding, a real reproducibility risk
70
  # specifically for a frozen/packaged desktop build (D2), where "whatever
71
  # resolves today" would otherwise get baked permanently into that one
72
+ # installer. The original 23 were verified together via one full, real
73
+ # install of the whole file into a clean venv, plus the complete test
74
+ # suite passing against it (116/116). keyring (24th, added this commit)
75
+ # was verified separately, in its own isolated venv, to avoid re-running
76
+ # that ~13GB full-stack install for one small, functionally-independent
77
+ # addition: confirmed it imports cleanly, resolves to 25.7.0, and that
78
+ # config/credentials.py's specific error-handling assumption
79
+ # (NoKeyringError raised only at the first get_password()/set_password()
80
+ # call, not at import or get_keyring() time) holds.
81
  # A full transitive-dependency lockfile (pip-compile --generate-hashes)
82
  # is a further, separate recommended step, not attempted here -- this
83
  # pins only the direct dependencies this file already declared.