Update app.py

app.py

@@ -70,29 +70,39 @@ class QuizGenerator:
             raise QuizGenerationError(f"Failed to generate questions: {str(e)}")
     
     def _create_prompt(self, text: str, num_questions: int) -> str:
-        """Create a simple, clear prompt optimized for llama-3.2-3b-preview"""
-        return f"""Create {num_questions} multiple choice questions about this text. Return only the JSON array in this exact format:
-[
-  {{
-    "question": "Write the question here?",
-    "options": [
-      "First option",
-      "Second option",
-      "Third option",
-      "Fourth option"
-    ],
-    "correct_answer": 0
-  }}
-]
-
-Rules:
-1. Return only the JSON array
-2. Each question must have exactly 4 options
-3. correct_answer must be 0, 1, 2, or 3
-4. No explanations or additional text
-
-Text to use:
-{text.strip()}"""
+        """Create a simple, clear prompt optimized for gemma2-9b-it"""
+        return f"""Create exactly {num_questions} multiple choice questions based on this text. Return your response in this exact JSON format with no additional text or formatting:
+    [{{
+        "question": "Write the first question here?",
+        "options": [
+            "First option",
+            "Second option",
+            "Third option",
+            "Fourth option"
+        ],
+        "correct_answer": 0
+    }},{{
+        "question": "Write the second question here?",
+        "options": [
+            "First option",
+            "Second option",
+            "Third option",
+            "Fourth option"
+        ],
+        "correct_answer": 0
+    }}]
+    
+    Important formatting rules:
+    1. The JSON must start with [ and end with ]
+    2. Each question object must be wrapped in {{ }}
+    3. Questions must be separated by commas
+    4. No trailing commas after the last question
+    5. Each question must have exactly 4 options
+    6. correct_answer must be a number (0, 1, 2, or 3)
+    7. Return only the JSON with no other text
+    
+    Text to use:
+    {text.strip()}"""
 
     def _parse_response(self, response_text: str) -> List[Dict]:
         """Parse response with improved error handling"""
@@ -100,7 +110,7 @@ Text to use:
             # Clean up the response text
             cleaned = response_text.strip()
             
-            # Remove any markdown formatting
+            # Remove markdown formatting
             cleaned = cleaned.replace('```json', '').replace('```', '').strip()
             
             # Find the JSON array
@@ -112,35 +122,40 @@ Text to use:
             
             json_str = cleaned[start:end]
             
-            # Remove any trailing commas before closing brackets
-            json_str = re.sub(r',(\s*})', r'\1', json_str)
-            json_str = re.sub(r',(\s*])', r'\1', json_str)
+            # Fix common JSON formatting issues
+            json_str = re.sub(r',(\s*})', r'\1', json_str)  # Remove trailing commas in objects
+            json_str = re.sub(r',(\s*])', r'\1', json_str)  # Remove trailing commas in arrays
+            json_str = re.sub(r'}\s*{', '},{', json_str)    # Fix spacing between objects
+            json_str = re.sub(r'\n\s*\n', '\n', json_str)   # Remove extra newlines
+            
+            # Fix missing commas between objects
+            json_str = re.sub(r'}\s*{', '},{', json_str)
+            
+            # Ensure array brackets
+            if not json_str.startswith('['):
+                json_str = '[' + json_str
+            if not json_str.endswith(']'):
+                json_str = json_str + ']'
             
-            # Try to parse the cleaned JSON
             try:
                 return json.loads(json_str)
             except json.JSONDecodeError:
-                # If that fails, try using ast.literal_eval as a fallback
-                import ast
-                return ast.literal_eval(json_str)
+                # Try fixing any remaining issues
+                fixed_str = re.sub(r'(["\d\w])\s*}', r'\1}', json_str)  # Fix spacing before closing braces
+                fixed_str = re.sub(r'\[\s*{', '[{', fixed_str)          # Fix spacing after opening bracket
+                fixed_str = re.sub(r'}\s*]', '}]', fixed_str)           # Fix spacing before closing bracket
                 
+                try:
+                    return json.loads(fixed_str)
+                except:
+                    # Last resort: Try using ast.literal_eval
+                    import ast
+                    return ast.literal_eval(fixed_str)
+                    
         except Exception as e:
             print(f"Parse error details: {str(e)}")
             print(f"Attempted to parse: {response_text}")
-            
-            # Last resort: try to fix the JSON manually
-            try:
-                # Remove any trailing commas and fix newlines
-                fixed = re.sub(r',(\s*[}\]])', r'\1', response_text)
-                fixed = fixed.replace('}\n{', '},{')
-                fixed = fixed.strip()
-                if not fixed.startswith('['):
-                    fixed = '[' + fixed
-                if not fixed.endswith(']'):
-                    fixed = fixed + ']'
-                return json.loads(fixed)
-            except:
-                raise ValueError(f"Failed to parse response: {str(e)}")
+            raise ValueError(f"Failed to parse response: {str(e)}")
     
     def _validate_questions(self, questions: List[Dict], num_questions: int) -> List[Question]:
         """Validate questions with strict checking"""