Spaces:
Sleeping
Sleeping
File size: 10,401 Bytes
116524e | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 | """SkillManager tool registrars and dependency container.
The agentic SkillManager operates on the real :class:`Skillbook` via
atomic mutation tools (ADD / UPDATE / REMOVE / TAG) and read-only
inspection tools (search / read). Tools apply changes directly; there
is no staging. Each mutation appends an ``UpdateOperation`` to
``deps.operations`` so the caller can recover an audit trail after the
run.
Generic tools (``execute_code``, ``recurse``) are provided by
:mod:`ace.core.recursive_agent`.
"""
from __future__ import annotations
from dataclasses import dataclass, field
from typing import TYPE_CHECKING, Any, Iterable, Literal, Optional
from pydantic_ai import RunContext
from ace.core.insight_source import InsightSource
from ace.core.recursive_agent import AgenticDeps
from ace.core.skillbook import Skillbook, UpdateOperation
if TYPE_CHECKING:
from pydantic_ai import Agent as PydanticAgent
# ------------------------------------------------------------------
# Dependency container
# ------------------------------------------------------------------
@dataclass
class SMDeps(AgenticDeps):
"""Dependencies injected into SkillManager tool calls via ``RunContext``."""
skillbook: Optional[Skillbook] = None
operations: list[UpdateOperation] = field(default_factory=list)
current_source: Optional[InsightSource] = None
def _normalize_keywords(keywords: Iterable[str]) -> list[str]:
normalized: list[str] = []
seen: set[str] = set()
for keyword in keywords:
text = str(keyword).strip().lower().replace(" ", "_")
if not text or text in seen:
continue
normalized.append(text)
seen.add(text)
return normalized
def _derive_operation_source(
base: InsightSource | None,
*,
operation_type: str,
issue: str | None = None,
insight: str | None = None,
reason: str | None = None,
) -> InsightSource | None:
if base is None:
return None
return InsightSource(
trace_uid=base.trace_uid,
source_system=base.source_system,
trace_id=base.trace_id,
display_name=base.display_name,
relation=base.relation,
sample_question=base.sample_question,
epoch=base.epoch,
operation_type=operation_type,
error_identification=issue or base.error_identification,
learning_text=insight or reason or base.learning_text,
)
# ------------------------------------------------------------------
# Mutation tools
# ------------------------------------------------------------------
def register_add_skill(agent: "PydanticAgent[SMDeps, Any]") -> None:
"""Register ``add_skill``."""
@agent.tool
def add_skill(
ctx: RunContext[SMDeps],
section: str,
issue: str,
keywords: list[str],
insight: str | None = None,
) -> dict[str, Any]:
sb = ctx.deps.skillbook
if sb is None:
return {"error": "skillbook unavailable"}
normalized_keywords = _normalize_keywords(keywords)
op_source = _derive_operation_source(
ctx.deps.current_source,
operation_type="ADD",
issue=issue,
insight=insight,
)
skill = sb.add_skill(
section=section,
issue=issue,
keywords=normalized_keywords,
insight=insight,
insight_source=op_source,
)
ctx.deps.operations.append(
UpdateOperation(
type="ADD",
section=skill.section,
issue=issue,
keywords=normalized_keywords,
insight=insight,
skill_id=skill.id,
insight_source=op_source,
)
)
return {"ok": True, "skill_id": skill.id}
def register_update_skill(agent: "PydanticAgent[SMDeps, Any]") -> None:
"""Register ``update_skill``."""
@agent.tool
def update_skill(
ctx: RunContext[SMDeps],
skill_id: str,
issue: str,
keywords: list[str] | None = None,
insight: str | None = None,
) -> dict[str, Any]:
sb = ctx.deps.skillbook
if sb is None:
return {"error": "skillbook unavailable"}
normalized_keywords = (
_normalize_keywords(keywords) if keywords is not None else None
)
op_source = _derive_operation_source(
ctx.deps.current_source,
operation_type="UPDATE",
issue=issue,
insight=insight,
)
skill = sb.update_skill(
skill_id,
issue=issue,
keywords=normalized_keywords if normalized_keywords is not None else None,
insight=insight,
insight_source=op_source,
)
if skill is None:
return {"error": f"skill not found: {skill_id}"}
ctx.deps.operations.append(
UpdateOperation(
type="UPDATE",
section=skill.section,
skill_id=skill_id,
issue=issue,
keywords=normalized_keywords or [],
insight=insight,
insight_source=op_source,
)
)
return {"ok": True, "skill_id": skill_id}
def register_remove_skill(agent: "PydanticAgent[SMDeps, Any]") -> None:
"""Register ``remove_skill``."""
@agent.tool
def remove_skill(
ctx: RunContext[SMDeps],
skill_id: str,
reason: str,
) -> dict[str, Any]:
sb = ctx.deps.skillbook
if sb is None:
return {"error": "skillbook unavailable"}
skill = sb.get_skill(skill_id)
if skill is None:
return {"error": f"skill not found: {skill_id}"}
op_source = _derive_operation_source(
ctx.deps.current_source,
operation_type="REMOVE",
issue=skill.issue,
reason=reason,
)
sb.remove_skill(skill_id, insight_source=op_source)
ctx.deps.operations.append(
UpdateOperation(
type="REMOVE",
section=skill.section,
skill_id=skill_id,
reason=reason,
insight_source=op_source,
)
)
return {"ok": True, "skill_id": skill_id}
def register_tag_skill(agent: "PydanticAgent[SMDeps, Any]") -> None:
"""Register ``tag_skill``."""
@agent.tool
def tag_skill(
ctx: RunContext[SMDeps],
skill_id: str,
delta: Literal[1, -1, 0],
) -> dict[str, Any]:
sb = ctx.deps.skillbook
if sb is None:
return {"error": "skillbook unavailable"}
existing = sb.get_skill(skill_id)
if existing is None:
return {"error": f"skill not found: {skill_id}"}
op_source = _derive_operation_source(
ctx.deps.current_source,
operation_type="TAG",
issue=existing.issue,
reason=f"effectiveness_delta={int(delta)}",
)
skill = sb.tag_skill(skill_id, delta, insight_source=op_source)
if skill is None:
return {"error": f"skill not found: {skill_id}"}
ctx.deps.operations.append(
UpdateOperation(
type="TAG",
section=skill.section,
skill_id=skill_id,
metadata={"delta": int(delta)},
insight_source=op_source,
)
)
return {
"ok": True,
"skill_id": skill_id,
"helpful_count": skill.helpful_count,
"harmful_count": skill.harmful_count,
"neutral_count": skill.neutral_count,
}
# ------------------------------------------------------------------
# Read-only tools
# ------------------------------------------------------------------
def register_sm_read_skill(agent: "PydanticAgent[SMDeps, Any]") -> None:
"""Register ``read_skill``."""
@agent.tool
def read_skill(ctx: RunContext[SMDeps], skill_id: str) -> dict[str, Any]:
sb = ctx.deps.skillbook
if sb is None:
return {"error": "skillbook unavailable"}
skill = sb.get_skill(skill_id)
if skill is None:
return {"error": f"skill not found: {skill_id}"}
return {
"id": skill.id,
"section": skill.section,
"keywords": list(skill.keywords),
"issue": skill.issue,
"insight": skill.insight,
"active": skill.active,
"used_count": skill.used_count,
"helpful_count": skill.helpful_count,
"harmful_count": skill.harmful_count,
"neutral_count": skill.neutral_count,
"occurrences": [source.to_dict() for source in skill.occurrences],
}
def register_sm_search_skills(agent: "PydanticAgent[SMDeps, Any]") -> None:
"""Register ``search_skills``."""
@agent.tool
def search_skills(
ctx: RunContext[SMDeps],
query: str,
top_k: int = 5,
section: str | None = None,
keywords: list[str] | None = None,
) -> list[dict[str, Any]]:
sb = ctx.deps.skillbook
if sb is None:
return [{"error": "skillbook unavailable"}]
from ace.implementations.skill_rendering import retrieve_top_k
results = retrieve_top_k(
sb,
query,
top_k=top_k,
section=section,
keywords=keywords,
)
return [
{
"id": skill.id,
"section": skill.section,
"keywords": list(skill.keywords),
"issue": skill.issue,
"insight": skill.insight,
"active": skill.active,
"used_count": skill.used_count,
"helpful_count": skill.helpful_count,
"harmful_count": skill.harmful_count,
"neutral_count": skill.neutral_count,
}
for skill in results
]
|