Spaces:
Sleeping
Sleeping
File size: 10,420 Bytes
116524e | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 | """Tests for ace steps: ReflectStep, UpdateStep, provenance."""
from __future__ import annotations
import logging
from dataclasses import dataclass
from typing import Any, Optional
from unittest.mock import MagicMock
import pytest
from ace.core.context import ACEStepContext, SkillbookView
from ace.core.outputs import (
AgentOutput,
ReflectorOutput,
SkillManagerOutput,
)
from ace.core.skillbook import Skillbook, UpdateBatch, UpdateOperation
from ace.steps import learning_tail
from ace.steps.reflect import ReflectStep
from ace.steps.update import UpdateStep
# ------------------------------------------------------------------ #
# Helpers — mock roles satisfying protocols
# ------------------------------------------------------------------ #
class MockReflector:
"""Minimal mock satisfying ReflectorLike."""
def __init__(self, output: ReflectorOutput | None = None):
self.output = output or ReflectorOutput(
reasoning="test reasoning",
correct_approach="test approach",
key_insight="test insight",
)
self.calls: list[dict] = []
def reflect(
self,
*,
question: str,
agent_output: AgentOutput,
skillbook: Any,
ground_truth: Optional[str] = None,
feedback: Optional[str] = None,
**kwargs: Any,
) -> ReflectorOutput:
self.calls.append(
{
"question": question,
"agent_output": agent_output,
"ground_truth": ground_truth,
"feedback": feedback,
**kwargs,
}
)
return self.output
class MockSkillManager:
"""Minimal mock satisfying SkillManagerLike."""
def __init__(self, output: SkillManagerOutput | None = None):
self.output = output or SkillManagerOutput(
update=UpdateBatch(reasoning="test", operations=[]),
)
self.calls: list[dict] = []
def update_skills(
self,
*,
reflections: tuple[ReflectorOutput, ...],
skillbook: Any,
question_context: str,
progress: str,
**kwargs: Any,
) -> SkillManagerOutput:
self.calls.append(
{
"reflections": reflections,
"question_context": question_context,
"progress": progress,
}
)
return self.output
# ------------------------------------------------------------------ #
# ReflectStep
# ------------------------------------------------------------------ #
class TestReflectStep:
def test_dict_trace(self):
"""Structured dict trace should extract known fields."""
reflector = MockReflector()
step = ReflectStep(reflector)
trace = {
"question": "What is 2+2?",
"answer": "4",
"reasoning": "simple math",
"ground_truth": "4",
"feedback": "Correct!",
}
sb = Skillbook()
ctx = ACEStepContext(
trace=trace,
skillbook=SkillbookView(sb),
)
result = step(ctx)
assert len(result.reflections) == 1
assert len(reflector.calls) == 1
call = reflector.calls[0]
assert call["question"] == "What is 2+2?"
assert call["agent_output"].final_answer == "4"
assert call["ground_truth"] == "4"
assert call["feedback"] == "Correct!"
def test_raw_trace(self):
"""Non-dict trace should be passed as-is via kwargs."""
reflector = MockReflector()
step = ReflectStep(reflector)
raw_trace = ["step1", "step2", "step3"]
sb = Skillbook()
ctx = ACEStepContext(
trace=raw_trace,
skillbook=SkillbookView(sb),
)
result = step(ctx)
assert len(result.reflections) == 1
assert len(reflector.calls) == 1
call = reflector.calls[0]
assert call["question"] == ""
assert call["agent_output"].final_answer == ""
assert call.get("trace") is raw_trace
def test_batch_dict_trace_is_passed_raw(self):
"""Batch dict traces should bypass structured trace extraction."""
reflector = MockReflector()
step = ReflectStep(reflector)
batch_trace = {
"tasks": [
{"task_id": "task-0", "trace": {"question": "What is 2+2?"}},
{"task_id": "task-1", "trace": {"question": "What is 3+3?"}},
]
}
sb = Skillbook()
ctx = ACEStepContext(
trace=batch_trace,
skillbook=SkillbookView(sb),
)
result = step(ctx)
assert len(result.reflections) == 1
assert len(reflector.calls) == 1
call = reflector.calls[0]
assert call["question"] == ""
assert call["agent_output"].final_answer == ""
assert call.get("trace") is batch_trace
def test_provides_and_requires(self):
step = ReflectStep(MockReflector())
assert "trace" in step.requires
assert "skillbook" in step.requires
assert "reflections" in step.provides
assert step.async_boundary is True
assert step.max_workers == 3
# ------------------------------------------------------------------ #
# UpdateStep
# ------------------------------------------------------------------ #
class TestUpdateStep:
def test_generates_update_batch(self):
sm = MockSkillManager()
sb = Skillbook()
step = UpdateStep(sm, sb)
reflection = ReflectorOutput(
reasoning="r",
correct_approach="c",
key_insight="k",
)
trace = {"question": "What is 2+2?", "context": "math quiz"}
ctx = ACEStepContext(
reflections=(reflection,),
skillbook=SkillbookView(sb),
trace=trace,
epoch=2,
total_epochs=3,
step_index=5,
total_steps=10,
)
result = step(ctx)
assert result.skill_manager_output is not None
assert len(sm.calls) == 1
call = sm.calls[0]
assert "Epoch 2/3" in call["progress"]
assert "sample 5/10" in call["progress"]
assert "What is 2+2?" in call["question_context"]
def test_non_dict_trace(self):
"""Non-dict trace should produce empty question_context."""
sm = MockSkillManager()
sb = Skillbook()
step = UpdateStep(sm, sb)
reflection = ReflectorOutput(
reasoning="r",
correct_approach="c",
key_insight="k",
)
ctx = ACEStepContext(
reflections=(reflection,),
skillbook=SkillbookView(sb),
trace="raw string trace",
)
step(ctx)
assert sm.calls[0]["question_context"] == ""
def test_forwards_full_reflections_tuple(self):
"""UpdateStep forwards the entire reflections tuple to the skill manager."""
sm = MockSkillManager()
sb = Skillbook()
step = UpdateStep(sm, sb)
r1 = ReflectorOutput(reasoning="r1", correct_approach="c", key_insight="k1")
r2 = ReflectorOutput(reasoning="r2", correct_approach="c", key_insight="k2")
ctx = ACEStepContext(
reflections=(r1, r2),
skillbook=SkillbookView(sb),
)
step(ctx)
assert len(sm.calls) == 1
assert sm.calls[0]["reflections"] == (r1, r2)
def test_provides_and_requires(self):
sb = Skillbook()
step = UpdateStep(MockSkillManager(), sb)
assert "reflections" in step.requires
assert "skillbook" in step.requires
assert "skill_manager_output" in step.provides
assert step.max_workers == 1
# ------------------------------------------------------------------ #
# learning_tail helper
# ------------------------------------------------------------------ #
class TestLearningTail:
def test_basic_tail(self):
reflector = MockReflector()
sm = MockSkillManager()
sb = Skillbook()
steps = learning_tail(reflector, sm, sb)
assert len(steps) == 2
assert isinstance(steps[0], ReflectStep)
assert isinstance(steps[1], UpdateStep)
def test_step_like_reflector_is_inserted_directly(self):
class ReflectorStep(MockReflector):
requires = frozenset({"trace", "skillbook"})
provides = frozenset({"reflections"})
def __call__(self, ctx: ACEStepContext) -> ACEStepContext:
return ctx.replace(reflections=(self.output,))
reflector = ReflectorStep()
sm = MockSkillManager()
sb = Skillbook()
steps = learning_tail(reflector, sm, sb)
assert steps[0] is reflector
assert isinstance(steps[1], UpdateStep)
def test_with_checkpoint(self, tmp_path):
reflector = MockReflector()
sm = MockSkillManager()
sb = Skillbook()
steps = learning_tail(
reflector,
sm,
sb,
checkpoint_dir=str(tmp_path),
checkpoint_interval=5,
)
assert len(steps) == 3 # 2 + CheckpointStep
def test_with_dedup(self):
reflector = MockReflector()
sm = MockSkillManager()
sb = Skillbook()
dedup = MagicMock()
steps = learning_tail(
reflector,
sm,
sb,
dedup_manager=dedup,
dedup_interval=5,
)
assert len(steps) == 3 # 2 + DeduplicateStep
def test_with_both(self, tmp_path):
reflector = MockReflector()
sm = MockSkillManager()
sb = Skillbook()
dedup = MagicMock()
steps = learning_tail(
reflector,
sm,
sb,
dedup_manager=dedup,
dedup_interval=5,
checkpoint_dir=str(tmp_path),
checkpoint_interval=5,
)
assert len(steps) == 4 # 2 + DeduplicateStep + CheckpointStep
|