Replace ineffective collaborator authorization tests with async regressions

tests/test_project_collaboration_authorization.py

@@ -1,23 +1,53 @@
 from __future__ import annotations
 
-import unittest
+from unittest.mock import AsyncMock
 
-from app.projects.repositories.collaboration_repository import CollaborationRepository
-from app.projects.services.collaboration_service import CollaborationService
-
-
-class CollaborationAuthorizationTests(unittest.TestCase):
-    def test_project_collaborator_list_requires_project_workspace(self) -> None:
-        repository = CollaborationRepository(None)
-        service = CollaborationService(repository)
+import pytest
 
-        with self.assertRaises(Exception):
-            service.list_project_collaborators("project-from-another-workspace")
-
-    def test_project_collaborator_removal_requires_project_workspace(self) -> None:
-        repository = CollaborationRepository(None)
-        service = CollaborationService(repository)
+from app.projects.services.collaboration_service import CollaborationService
 
-        with self.assertRaises(Exception):
-            service.remove_project_collaborator("project-from-another-workspace", "user-id")
 
+@pytest.mark.asyncio
+async def test_project_collaborator_listing_passes_authenticated_workspace() -> None:
+    repository = type("Repository", (), {})()
+    repository.list_project_collaborators = AsyncMock(return_value=[])
+    service = CollaborationService(repository)
+    assert await service.list_project_collaborators("workspace-a", "project-a") == []
+    repository.list_project_collaborators.assert_awaited_once_with("workspace-a", "project-a")
+
+
+@pytest.mark.asyncio
+async def test_project_collaborator_removal_passes_authenticated_workspace() -> None:
+    repository = type("Repository", (), {})()
+    repository.remove_project_collaborator = AsyncMock()
+    service = CollaborationService(repository)
+    await service.remove_project_collaborator("workspace-a", "project-a", "user-b")
+    repository.remove_project_collaborator.assert_awaited_once_with(
+        "workspace-a", "project-a", "user-b"
+    )
+
+
+@pytest.mark.asyncio
+async def test_invitation_requires_workspace_admin_or_owner() -> None:
+    repository = type("Repository", (), {})()
+    repository.get_membership = AsyncMock(return_value=type(
+        "Membership", (), {"role": "member", "status": "active"}
+    )())
+    service = CollaborationService(repository)
+    with pytest.raises(Exception, match="Only workspace owners or admins"):
+        await service.invite_member("workspace-a", "user-a", "new@example.com", "member")
+    repository.invite_member_with_hash = AsyncMock()
+    repository.invite_member_with_hash.assert_not_awaited()
+
+
+@pytest.mark.asyncio
+async def test_member_role_changes_reject_privileged_unknown_roles() -> None:
+    repository = type("Repository", (), {})()
+    repository.get_membership = AsyncMock(return_value=type(
+        "Membership", (), {"role": "admin", "status": "active", "user_id": "admin-a"}
+    )())
+    repository.update_member_role = AsyncMock()
+    service = CollaborationService(repository)
+    with pytest.raises(ValueError, match="Member role must be admin or member"):
+        await service.update_member_role("workspace-a", "admin-a", "user-b", "owner")
+    repository.update_member_role.assert_not_awaited()