Refactor(pipeline): improve code readability and update function calls for clarity

src/pozify/pipeline.py

@@ -42,7 +42,9 @@ def run_pipeline(
 ) -> dict[str, Any]:
     mock_mode = _env_mock_mode(video_path) if mock is None else mock
 
-    run_id = f"{datetime.now(timezone.utc).strftime('%Y%m%dT%H%M%SZ')}-{uuid4().hex[:8]}"
+    run_id = (
+        f"{datetime.now(timezone.utc).strftime('%Y%m%dT%H%M%SZ')}-{uuid4().hex[:8]}"
+    )
     run_dir = RUNS_DIR / run_id
     artifact_index: list[dict[str, str]] = []
 
@@ -121,7 +123,9 @@ def run_pipeline(
     )
 
     emit("exercise", "active", "Let me figure out which exercise you are doing.")
-    classification = exercise_classifier.run(cleaned_pose_sequence, profile)
+    classification = exercise_classifier.run(
+        cleaned_pose_sequence, profile, mock=mock_mode
+    )
     write_artifact("exercise_classification.json", classification)
     emit(
         "exercise",
@@ -211,7 +215,9 @@ def run_pipeline(
     if mock_mode:
         mock_steps.insert(0, "exercise_classifier")
 
-    summary = coach_summary.run(profile, classification, reps, analysis, variation, issues)
+    summary = coach_summary.run(
+        profile, classification, reps, analysis, variation, issues
+    )
     write_artifact("coach_summary.json", summary)
 
     verification = verifier.run(summary, issues, variation)

tests/test_pipeline_contracts.py

@@ -51,17 +51,35 @@ EXPECTED_ARTIFACT_KEYS = {
         "video_path",
         "width",
     ],
-    "pose_sequence.json": ["frames", "normalized", "pose_valid_ratio", "smoothing_method"],
+    "pose_sequence.json": [
+        "frames",
+        "normalized",
+        "pose_valid_ratio",
+        "smoothing_method",
+    ],
     "exercise_classification.json": [
         "confidence",
         "exercise",
         "fallback_required",
         "window_predictions",
     ],
-    "rep_debug.json": ["accepted_reps", "body_line_mean", "extrema", "raw_signal_range", "selected_signal", "thresholds", "usable_signal_samples"],
+    "rep_debug.json": [
+        "accepted_reps",
+        "body_line_mean",
+        "extrema",
+        "raw_signal_range",
+        "selected_signal",
+        "thresholds",
+        "usable_signal_samples",
+    ],
     "reps.json": ["exercise", "partial_reps", "reps"],
     "rep_analysis.json": ["aggregate_metrics", "exercise", "items"],
-    "variation.json": ["detected_variation", "exercise", "not_issues", "variation_confidence"],
+    "variation.json": [
+        "detected_variation",
+        "exercise",
+        "not_issues",
+        "variation_confidence",
+    ],
     "issue_markers.json": ["issues"],
     "coach_summary.json": [
         "confidence_notes",
@@ -120,8 +138,16 @@ class PipelineContractTests(unittest.TestCase):
         for frame_index in range(int(fps * duration_sec)):
             frame = np.full((height, width, 3), 130, dtype=np.uint8)
             offset = frame_index % 120
-            cv2.rectangle(frame, (40 + offset, 80), (260 + offset, 300), (245, 245, 245), -1)
-            cv2.line(frame, (0, frame_index % height), (width - 1, height - 1), (20, 20, 20), 3)
+            cv2.rectangle(
+                frame, (40 + offset, 80), (260 + offset, 300), (245, 245, 245), -1
+            )
+            cv2.line(
+                frame,
+                (0, frame_index % height),
+                (width - 1, height - 1),
+                (20, 20, 20),
+                3,
+            )
             writer.write(frame)
         writer.release()
         return path
@@ -138,7 +164,9 @@ class PipelineContractTests(unittest.TestCase):
             self.assertEqual(sorted(payload.keys()), keys, artifact_name)
             if artifact_name == "final_report.json":
                 self.assertIn("issue_thumbnail_paths", payload["artifacts"])
-                self.assertIsInstance(payload["artifacts"]["issue_thumbnail_paths"], list)
+                self.assertIsInstance(
+                    payload["artifacts"]["issue_thumbnail_paths"], list
+                )
                 self.assertIn("issue_clip_paths", payload["artifacts"])
                 self.assertIsInstance(payload["artifacts"]["issue_clip_paths"], list)
 
@@ -163,17 +191,23 @@ class PipelineContractTests(unittest.TestCase):
         )
 
     def test_pipeline_runs_end_to_end_without_video(self) -> None:
-        result = pipeline.run_pipeline(video_path=None, profile_input=PROFILE_INPUT, mock=True)
+        result = pipeline.run_pipeline(
+            video_path=None, profile_input=PROFILE_INPUT, mock=True
+        )
 
         self._assert_pipeline_artifacts(result)
         report = result["final_report"]
         self.assertEqual(report["exercise"]["exercise"], "squat")
-        self.assertEqual(report["video_manifest"]["quality_warnings"], ["video_decode_failed"])
+        self.assertEqual(
+            report["video_manifest"]["quality_warnings"], ["video_decode_failed"]
+        )
         self.assertFalse(report["video_manifest"]["analysis_allowed"])
 
     def test_pipeline_runs_end_to_end_with_fixture_video_path(self) -> None:
         fixture = self._write_video("sample.mp4")
-        result = pipeline.run_pipeline(video_path=str(fixture), profile_input=PROFILE_INPUT, mock=True)
+        result = pipeline.run_pipeline(
+            video_path=str(fixture), profile_input=PROFILE_INPUT, mock=True
+        )
 
         self._assert_pipeline_artifacts(result)
         report = result["final_report"]
@@ -274,7 +308,9 @@ class PipelineContractTests(unittest.TestCase):
         self.assertEqual(report["exercise"]["exercise"], "unknown")
         self.assertFalse(report["exercise"]["fallback_required"])
         self.assertEqual(report["reps"]["reps"], [])
-        self.assertEqual(report["reps"]["partial_reps"], [{"reason": "unknown_exercise"}])
+        self.assertEqual(
+            report["reps"]["partial_reps"], [{"reason": "unknown_exercise"}]
+        )
 
     def test_mock_mode_defaults_to_real_when_video_path_is_present(self) -> None:
         with patch.dict(os.environ, {}, clear=True):

web/app.js

@@ -27,16 +27,6 @@ function label(value) {
   return value.replaceAll("_", " ");
 }
 
-async function readResponseBody(response) {
-  const text = await response.text();
-  if (!text) return {};
-
-  const contentType = response.headers.get("content-type") || "";
-  if (contentType.includes("application/json")) return JSON.parse(text);
-
-  return { detail: text };
-}
-
 function Field({ labelText, children, full = false }) {
   return h(
     "label",
@@ -185,7 +175,8 @@ function applyProgressEvent(currentSteps, event) {
 }
 
 async function readAnalysisStream(response, onEvent) {
-  if (!response.body) throw new Error("Streaming is not available in this browser.");
+  if (!response.body)
+    throw new Error("Streaming is not available in this browser.");
   const reader = response.body.getReader();
   const decoder = new TextDecoder();
   let buffer = "";
@@ -202,7 +193,8 @@ async function readAnalysisStream(response, onEvent) {
       const event = JSON.parse(line);
       if (event.type === "progress") onEvent(event);
       if (event.type === "complete") result = event.result;
-      if (event.type === "error") throw new Error(event.detail || "Analysis failed.");
+      if (event.type === "error")
+        throw new Error(event.detail || "Analysis failed.");
     }
   }
 
@@ -210,7 +202,8 @@ async function readAnalysisStream(response, onEvent) {
     const event = JSON.parse(buffer);
     if (event.type === "progress") onEvent(event);
     if (event.type === "complete") result = event.result;
-    if (event.type === "error") throw new Error(event.detail || "Analysis failed.");
+    if (event.type === "error")
+      throw new Error(event.detail || "Analysis failed.");
   }
 
   if (!result) throw new Error("Analysis finished without a report.");
@@ -223,7 +216,11 @@ function ProgressPanel({ steps }) {
   return h(
     "section",
     { className: "progress-panel", "aria-live": "polite" },
-    h("h3", null, isComplete ? "Scan results are ready" : "Your scan is moving"),
+    h(
+      "h3",
+      null,
+      isComplete ? "Scan results are ready" : "Your scan is moving",
+    ),
     h(
       "ol",
       { className: "progress-list" },
@@ -287,7 +284,9 @@ function ReviewInsights({ result }) {
       h(
         "small",
         null,
-        warnings.length ? warnings.map(label).join(", ") : "clear enough to coach",
+        warnings.length
+          ? warnings.map(label).join(", ")
+          : "clear enough to coach",
       ),
     ),
   );