File size: 21,021 Bytes
1cd53ba a54f188 1cd53ba 4ce08fd 1cd53ba 4ce08fd 1cd53ba 4ce08fd 1cd53ba 4ce08fd 1cd53ba 4ce08fd 1cd53ba 4ce08fd 1cd53ba 4ce08fd 1cd53ba 4ce08fd 1cd53ba 4ce08fd 1cd53ba 4ce08fd 1cd53ba 4ce08fd 1cd53ba 4ce08fd 1cd53ba 4ce08fd 1cd53ba bc2df26 64075d7 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 | import json
from datetime import UTC, date, datetime
from typing import Any
from unittest.mock import AsyncMock
import pytest
from app.config import Settings
from app.models.domain import AIProviderResponse, ExtractedTrip, WhatsAppInboundMessage
from app.services.group_message_service import GroupMessageService
from tests.conftest import FakeRepository, FakeEmbeddings
class FakeProvider:
def __init__(self, response_content: str | None = None) -> None:
self.response_content = response_content
self.calls: list[dict[str, Any]] = []
async def chat(
self,
messages: list[dict[str, Any]],
*,
tools: list[dict[str, Any]] | None = None,
tool_choice: str | None = None,
temperature: float = 0.2,
) -> AIProviderResponse:
self.calls.append({"messages": messages, "tools": tools, "temperature": temperature})
return AIProviderResponse(content=self.response_content)
@pytest.fixture
def settings() -> Settings:
return Settings(
supabase_url="https://example.supabase.co",
supabase_service_role_key="supabase-secret",
jina_api_key="jina-secret",
groq_api_key="groq-secret",
groq_model="groq-tool-model",
openrouter_api_key="openrouter-secret",
openrouter_model="openrouter-tool-model",
whatsapp_verify_token="verify-token",
whatsapp_app_secret="app-secret",
whatsapp_access_token="wa-token",
whatsapp_phone_number_id="123",
admin_api_key="admin-secret",
)
def _make_inbound(
text: str,
message_id: str = "wamid.group.1",
) -> WhatsAppInboundMessage:
return WhatsAppInboundMessage(
message_id=message_id,
remoteJid="12345@g.us",
text=text,
timestamp="1790000000",
is_group=True,
)
def _trip_ad_response(
*,
departure: str = "صنعاء",
destination: str = "عدن",
departure_date: str = "2026-07-15",
departure_time: str = "morning",
price: float = 5000,
driver_phone: str = "967712345678",
driver_name: str | None = "أحمد",
car_type: str | None = "سيارة",
available_seats: int | None = 4,
total_seats: int | None = 4,
) -> str:
return json.dumps({
"is_trip_ad": True,
"departure": departure,
"destination": destination,
"departure_date": departure_date,
"departure_time": departure_time,
"available_seats": available_seats,
"total_seats": total_seats,
"price": price,
"car_type": car_type,
"driver_name": driver_name,
"driver_phone": driver_phone,
})
@pytest.mark.asyncio
async def test_non_trip_message_is_ignored(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
provider = FakeProvider(response_content=json.dumps({"is_trip_ad": False}))
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="مرحبا بالجميع")
await service.handle_group_message(inbound)
assert len(repo.customers_by_remote_jid) == 0
assert len(repo.created_drivers) == 0
assert len(repo.created_trips) == 0
@pytest.mark.asyncio
async def test_trip_ad_from_new_driver_creates_all_entities(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
provider = FakeProvider(response_content=_trip_ad_response())
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة من صنعاء إلى عدن بكرة الصباح 5000 ريال 967712345678")
await service.handle_group_message(inbound)
assert len(repo.customers_by_remote_jid) == 1
customer = list(repo.customers_by_remote_jid.values())[0]
assert customer["registered"] is False
assert customer["phone_number"] == "967712345678"
assert len(repo.created_drivers) == 1
assert len(repo.created_trips) == 1
trip = repo.created_trips[0]
assert trip["departure"] == "صنعاء"
assert trip["destination"] == "عدن"
@pytest.mark.asyncio
async def test_trip_ad_from_existing_customer_is_discarded(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
provider = FakeProvider(response_content=_trip_ad_response())
existing_customer = await repo.upsert_customer(
remote_jid="967712345678",
name="أحمد",
phone_number="967712345678",
registered=True,
)
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة من صنعاء إلى عدن 967712345678")
await service.handle_group_message(inbound)
assert len(repo.created_drivers) == 0
assert len(repo.created_trips) == 0
@pytest.mark.asyncio
async def test_existing_unregistered_driver_adds_new_trip(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
provider = FakeProvider(response_content=_trip_ad_response())
await repo.upsert_customer(
remote_jid="967712345678",
name="أحمد",
phone_number="967712345678",
registered=False,
)
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة من صنعاء إلى عدن")
await service.handle_group_message(inbound)
assert len(repo.created_trips) == 1
assert repo.created_trips[0]["departure"] == "صنعاء"
@pytest.mark.asyncio
async def test_existing_unregistered_driver_duplicate_trip_is_skipped(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
provider = FakeProvider(response_content=_trip_ad_response())
await repo.upsert_customer(
remote_jid="967712345678",
name="أحمد",
phone_number="967712345678",
registered=False,
)
driver = await repo.create_driver(
customer_id=list(repo.customers_by_remote_jid.values())[0]["id"]
)
await repo.create_driver_trip(
driver_id=str(driver["id"]),
car_id=None,
departure="صنعاء",
destination="عدن",
departure_date=date(2026, 7, 15),
departure_time="morning",
available_seats=4,
total_seats=4,
price=5000,
)
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
initial_count = len(repo.created_trips)
inbound = _make_inbound(text="رحلة من صنعاء إلى عدن")
await service.handle_group_message(inbound)
assert len(repo.created_trips) == initial_count
@pytest.mark.asyncio
async def test_incomplete_fields_cause_skip(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
response = json.dumps({
"is_trip_ad": True,
"departure": "صنعاء",
"destination": None,
"departure_date": "2026-07-15",
"departure_time": "morning",
"price": 5000,
"driver_phone": "967712345678",
})
provider = FakeProvider(response_content=response)
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة من صنعاء")
await service.handle_group_message(inbound)
assert len(repo.created_trips) == 0
@pytest.mark.asyncio
async def test_missing_phone_cause_skip(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
response = json.dumps({
"is_trip_ad": True,
"departure": "صنعاء",
"destination": "عدن",
"departure_date": "2026-07-15",
"departure_time": "morning",
"price": 5000,
"driver_phone": None,
})
provider = FakeProvider(response_content=response)
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة من صنعاء إلى عدن")
await service.handle_group_message(inbound)
assert len(repo.created_trips) == 0
@pytest.mark.asyncio
async def test_duplicate_group_message_is_deduplicated(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
provider = FakeProvider(response_content=_trip_ad_response())
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة", message_id="wamid.dup.1")
await service.handle_group_message(inbound)
assert len(repo.created_trips) == 1
await service.handle_group_message(inbound)
assert len(repo.created_trips) == 1
@pytest.mark.asyncio
async def test_phone_normalization(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
provider = FakeProvider(
response_content=_trip_ad_response(driver_phone="+967-71-234-5678")
)
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة")
await service.handle_group_message(inbound)
assert len(repo.customers_by_remote_jid) == 1
customer = list(repo.customers_by_remote_jid.values())[0]
assert customer["phone_number"] == "967712345678"
@pytest.mark.asyncio
async def test_invalid_json_response_cause_skip(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
provider = FakeProvider(response_content="this is not json")
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة")
await service.handle_group_message(inbound)
assert len(repo.created_trips) == 0
@pytest.mark.asyncio
async def test_markdown_fenced_json_is_parsed(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
fenced = f"```json\n{_trip_ad_response()}\n```"
provider = FakeProvider(response_content=fenced)
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة")
await service.handle_group_message(inbound)
assert len(repo.created_trips) == 1
@pytest.mark.asyncio
async def test_trip_ad_with_missing_car_type_uses_unknown(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
provider = FakeProvider(
response_content=_trip_ad_response(car_type=None)
)
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة")
await service.handle_group_message(inbound)
assert len(repo.created_trips) == 1
cars = list(repo.driver_cars_by_driver.values())[0]
assert cars[0]["car_type"] == "غير معروف"
@pytest.mark.asyncio
async def test_trip_ad_with_missing_name_uses_none(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
provider = FakeProvider(
response_content=_trip_ad_response(driver_name=None)
)
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة")
await service.handle_group_message(inbound)
assert len(repo.created_trips) == 1
customer = list(repo.customers_by_remote_jid.values())[0]
assert customer["name"] is None
@pytest.mark.asyncio
async def test_multiple_phone_numbers_are_separated_by_slash(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
provider = FakeProvider(
response_content=_trip_ad_response(driver_phone="967712345678/967876543210")
)
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة")
await service.handle_group_message(inbound)
assert len(repo.customers_by_remote_jid) == 1
customer = list(repo.customers_by_remote_jid.values())[0]
assert customer["phone_number"] == "967712345678/967876543210"
@pytest.mark.asyncio
async def test_unregistered_driver_has_null_remote_jid(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
provider = FakeProvider(response_content=_trip_ad_response())
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة")
await service.handle_group_message(inbound)
assert len(repo.customers_by_remote_jid) == 1
customer = list(repo.customers_by_remote_jid.values())[0]
assert customer["remoteJid"] is None
assert customer["phone_number"] == "967712345678"
@pytest.mark.asyncio
async def test_phone_normalization_with_multiple_numbers(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
provider = FakeProvider(
response_content=_trip_ad_response(driver_phone="+967-71-234-5678 / +967-78-765-4321")
)
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة")
await service.handle_group_message(inbound)
assert len(repo.customers_by_remote_jid) == 1
customer = list(repo.customers_by_remote_jid.values())[0]
assert customer["phone_number"] == "967712345678/967787654321"
@pytest.mark.asyncio
async def test_local_phone_number_gets_country_code_prepended(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
provider = FakeProvider(
response_content=_trip_ad_response(driver_phone="712345678")
)
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة")
await service.handle_group_message(inbound)
assert len(repo.customers_by_remote_jid) == 1
customer = list(repo.customers_by_remote_jid.values())[0]
assert customer["phone_number"] == "967712345678"
@pytest.mark.asyncio
async def test_leading_zero_stripped_then_country_code_prepended(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
provider = FakeProvider(
response_content=_trip_ad_response(driver_phone="0712345678")
)
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة")
await service.handle_group_message(inbound)
assert len(repo.customers_by_remote_jid) == 1
customer = list(repo.customers_by_remote_jid.values())[0]
assert customer["phone_number"] == "967712345678"
@pytest.mark.asyncio
async def test_existing_unregistered_driver_with_multiple_phones_adds_new_trip(
settings: Settings,
) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
provider = FakeProvider(
response_content=_trip_ad_response(driver_phone="967712345678/967876543210")
)
await repo.upsert_customer(
remote_jid=None,
name="أحمد",
phone_number="967712345678/967876543210",
registered=False,
)
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة من صنعاء إلى عدن")
await service.handle_group_message(inbound)
assert len(repo.created_trips) == 1
assert repo.created_trips[0]["departure"] == "صنعاء"
@pytest.mark.asyncio
async def test_get_driver_by_phone_number_with_multiple_phones(settings: Settings) -> None:
repo = FakeRepository()
customer = await repo.upsert_customer(
remote_jid=None,
name="أحمد",
phone_number="967712345678/967876543210",
registered=False,
)
await repo.create_driver(customer_id=str(customer["id"]))
driver = await repo.get_driver_by_phone_number("967712345678/967876543210")
assert driver is not None
assert driver["customers"]["phone_number"] == "967712345678/967876543210"
@pytest.mark.asyncio
async def test_unregistered_driver_later_dm_merges_into_same_row(settings: Settings) -> None:
"""When a driver saved from a group (remoteJid=None) later DMs us,
the DM should update the existing row instead of creating a duplicate."""
repo = FakeRepository()
embeddings = FakeEmbeddings()
provider = FakeProvider(response_content=_trip_ad_response())
# Step 1: Driver posts trip ad in group (creates unregistered customer)
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة من صنعاء إلى عدن")
await service.handle_group_message(inbound)
assert len(repo.customers_by_remote_jid) == 1
existing = list(repo.customers_by_remote_jid.values())[0]
assert existing["remoteJid"] is None
assert existing["phone_number"] == "967712345678"
existing_id = existing["id"]
# Step 2: Same driver sends a DM (should update existing row, not create new one)
customer = await repo.upsert_customer(
remote_jid="967712345678",
name="أحمد",
phone_number="967712345678",
registered=True,
)
assert customer["id"] == existing_id
assert customer["remoteJid"] == "967712345678"
assert customer["registered"] is True
# Should still be only one customer row
assert len(repo.customers_by_remote_jid) == 1
@pytest.mark.asyncio
async def test_dm_with_shared_phone_merges_into_existing(settings: Settings) -> None:
"""When a customer exists with phone_number matching a DM's phone,
the DM should update the existing row."""
repo = FakeRepository()
# Create a customer via DM first
customer1 = await repo.upsert_customer(
remote_jid="967712345678",
name="أحمد",
phone_number="967712345678",
registered=True,
)
# Another DM with same phone_number but different remoteJid (e.g. new device)
customer2 = await repo.upsert_customer(
remote_jid="967999999999",
name="أحمد",
phone_number="967712345678",
registered=True,
)
assert customer1["id"] == customer2["id"]
assert len(repo.customers_by_remote_jid) == 1
@pytest.mark.asyncio
async def test_dm_with_multi_phone_merges_into_existing(settings: Settings) -> None:
"""When a DM's phone_number matches one of the phones in an existing
/-separated phone_number, it should update the existing row."""
repo = FakeRepository()
# Create unregistered driver with two phones
customer1 = await repo.upsert_customer(
remote_jid=None,
name="أحمد",
phone_number="967712345678/967876543210",
registered=False,
)
# DM comes in with just the first phone number
customer2 = await repo.upsert_customer(
remote_jid="967712345678",
name="أحمد",
phone_number="967712345678",
registered=True,
)
assert customer1["id"] == customer2["id"]
assert customer2["remoteJid"] == "967712345678"
assert customer2["registered"] is True
@pytest.mark.asyncio
async def test_trip_ad_with_null_seats_stores_none(settings: Settings) -> None:
repo = FakeRepository()
embeddings = FakeEmbeddings()
provider = FakeProvider(
response_content=_trip_ad_response(available_seats=None, total_seats=None)
)
service = GroupMessageService(
repository=repo,
embeddings=embeddings,
ai=provider,
settings=settings,
)
inbound = _make_inbound(text="رحلة من صنعاء إلى عدن")
await service.handle_group_message(inbound)
assert len(repo.created_trips) == 1
trip = repo.created_trips[0]
assert trip.get("available_seats") is None
assert trip.get("total_seats") is None
|