File size: 16,196 Bytes
25059bd
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
 
 
7b6e647
 
 
 
 
 
25059bd
1f0f638
25059bd
7b6e647
25059bd
7b6e647
 
 
25059bd
 
 
 
 
 
 
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
 
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
 
7b6e647
 
 
 
 
 
 
 
25059bd
1f0f638
25059bd
 
 
 
 
 
 
 
 
 
 
7b6e647
 
25059bd
 
 
 
 
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
 
 
 
 
 
 
 
1f0f638
25059bd
 
 
 
 
 
e9d5bbe
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
25059bd
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
import { describe, it, expect, vi, afterAll } from 'vitest'
import fs from 'fs'
import path from 'path'
import { mkdtempSync } from 'fs'
import { tmpdir } from 'os'
import { createRequire } from 'module'
import net from 'net'

const tmpDir = mkdtempSync(path.join(tmpdir(), 'cov-redis-'))
const _require = createRequire(import.meta.url)

afterAll(() => {
  try { fs.rmSync(tmpDir, { recursive: true, force: true }) } catch {}
})

async function closeServer(server) {
  await new Promise((resolve) => server.close(resolve))
}

describe('redis.js', () => {
  it('encodes RESP commands', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port: 6379 })
    expect(c._encode('PING')).toBe('*1\r\n$4\r\nPING\r\n')
    expect(c._encode('SET', 'k', 'v')).toBe('*3\r\n$3\r\nSET\r\n$1\r\nk\r\n$1\r\nv\r\n')
  })

  it('parses all RESP types', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port: 6379 })
    const p = (b) => c._parse(Buffer.from(b))

    expect(p('+OK\r\n').value).toEqual(Buffer.from('OK'))
    const e = p('-ERR x\r\n')
    expect(e.isError).toBe(true); expect(e.value.message).toBe('ERR x')
    expect(p(':42\r\n').value).toBe(42)
    expect(p('$-1\r\n').value).toBeNull()
    expect(p('$5\r\nhello\r\n').value).toEqual(Buffer.from('hello'))
    const a = p('*2\r\n$3\r\nfoo\r\n$3\r\nbar\r\n')
    expect(a.value.length).toBe(2)
    expect(a.value[0]).toEqual(Buffer.from('foo'))
    expect(a.value[1]).toEqual(Buffer.from('bar'))
    expect(p('*-1\r\n').value).toBeNull()
    expect(c._parse(Buffer.alloc(0))).toBeNull()
    expect(c._parse(Buffer.from('$5\r\nhel'))).toBeNull()
  })

  it('throws on unknown RESP type', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port: 6379 })
    expect(() => c._parse(Buffer.from('!x\r\n'))).toThrow('Unknown RESP type')
  })

  it('connect returns early when already connected or connecting', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port: 6379 })
    c.connected = true
    await expect(c.connect()).resolves.toBeUndefined()
    c.connected = false; c._connecting = true
    await expect(c.connect()).resolves.toBeUndefined()
  })

  it('parses URL in constructor', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ url: 'redis://:secret@myhost:6380/3' })
    expect(c.host).toBe('myhost')
    expect(c.port).toBe(6380)
    expect(c.password).toBe('secret')
    expect(c.db).toBe(3)
  })

  it('send and _onData process responses', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port: 6379 })
    c.socket = { write: vi.fn() }
    const p = c.send('PING')
    expect(c.queue.length).toBe(1)
    c._onData(Buffer.from('+PONG\r\n'))
    await expect(p).resolves.toEqual(Buffer.from('PONG'))
  })

  it('rejects on error response', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port: 6379 })
    c.socket = { write: vi.fn() }
    const p = c.send('PING')
    c._onData(Buffer.from('-ERR bad\r\n'))
    await expect(p).rejects.toThrow('ERR bad')
  })

  it('handles partial data across multiple _onData calls', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port: 6379 })
    c.socket = { write: vi.fn() }
    const p = c.send('GET', 'key')
    c._onData(Buffer.from('$'))
    c._onData(Buffer.from('3\r\nval\r\n'))
    await expect(p).resolves.toEqual(Buffer.from('val'))
  })

  it('quit resolves immediately when socket is null', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port: 6379 })
    await expect(c.quit()).resolves.toBeUndefined()
  })

  it('quit sends QUIT and destroys socket', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port: 6379 })
    const write = vi.fn()
    const destroy = vi.fn()
    c.socket = { write, destroy }
    await expect(c.quit()).resolves.toBeUndefined()
    expect(write).toHaveBeenCalledWith(expect.stringContaining('QUIT'))
    expect(destroy).toHaveBeenCalled()
  })

  it('connect handler with auth and select via TCP', async () => {
    const server = net.createServer(s => {
      s.on('data', d => {
        if (d.includes('AUTH')) s.write(Buffer.from('+OK\r\n'))
        else if (d.includes('SELECT')) s.write(Buffer.from('+OK\r\n'))
      })
    })
    await new Promise(r => server.listen(0, '127.0.0.1', r))
    const { port } = server.address()
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port, password: 's', db: 1 })
    await expect(c.connect()).resolves.toBeUndefined()
    expect(c.connected).toBe(true)
    server.close()
  })

  it('connect handler without auth/select via TCP', async () => {
    const server = net.createServer(s => {
      s.on('data', () => s.write(Buffer.from('+OK\r\n')))
    })
    await new Promise(r => server.listen(0, '127.0.0.1', r))
    const { port } = server.address()
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port })
    await expect(c.connect()).resolves.toBeUndefined()
    expect(c.connected).toBe(true)
    server.close()
  })

  it('uses default constructor options', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient()
    expect(c.host).toBe('127.0.0.1')
    expect(c.port).toBe(6379)
    expect(c.db).toBe(0)
    expect(c.password).toBeUndefined()
  })

  it('parses URL without port and without password', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ url: 'redis://myhost/3' })
    expect(c.host).toBe('myhost')
    expect(c.port).toBe(6379)
    expect(c.password).toBeUndefined()
    expect(c.db).toBe(3)
  })

  it('handles _parse offset and array null branches', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port: 6379 })
    expect(c._parse(Buffer.from('x'), 1)).toBeNull()
    expect(c._parse(Buffer.from('*-1\r\n')).value).toBeNull()
  })

  it('parses URL with empty hostname, using default host', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ url: 'redis:///3' })
    expect(c.host).toBe('127.0.0.1')
    expect(c.db).toBe(3)
  })

  it('parses URL with non-numeric path, keeping default db', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ url: 'redis://host/db' })
    expect(c.host).toBe('host')
    expect(c.db).toBe(0)
  })

  it('handles incomplete array data in _parse', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port: 6379 })
    expect(c._parse(Buffer.from('*2\r\n$3\r\nfoo'))).toBeNull()
  })

  it('covers _onData when no response is complete', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port: 6379 })
    c.socket = { write: vi.fn() }
    c.send('PING')
    c._onData(Buffer.from('+'))
    expect(c.queue.length).toBe(1)
  })

  it('handles write error in send()', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port: 6379 })
    c.socket = { write: vi.fn(() => { throw new Error('write error') }) }
    await expect(c.send('PING')).rejects.toThrow('write error')
    expect(c.queue.length).toBe(0)
  })

  it('covers redis helper methods', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port: 6379 })
    c.socket = { write: vi.fn() }
    c.ping()
    c.auth('s')
    c.get('k')
    c.set('k', 'v', 'EX', 1)
    c.setex('k', 1, 'v')
    c.incr('k')
    c.expire('k', 1)
    c.del('a', 'b')
    c.ttl('k')
    c.eval('return 1', 0)
    expect(c.socket.write).toHaveBeenCalledTimes(10)
  })

  it('connect handler with auth failure via TCP', async () => {
    const server = net.createServer(s => {
      s.on('data', d => {
        if (d.includes('AUTH')) s.write(Buffer.from('-ERR invalid password\r\n'))
      })
    })
    await new Promise(r => server.listen(0, '127.0.0.1', r))
    const { port } = server.address()
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port, password: 's' })
    await expect(c.connect()).rejects.toThrow('ERR invalid password')
    expect(c.connected).toBe(false)
    server.close()
  })

  it('connect error handler rejects queued commands via TCP', async () => {
    const server = net.createServer(() => {})
    await new Promise(r => server.listen(0, '127.0.0.1', r))
    const { port } = server.address()
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port })
    c.connect().catch(() => {})
    await new Promise(r => setTimeout(r, 20))
    c.socket.destroy(new Error('ECONNRESET'))
    const p = c.send('PING')
    await expect(p).rejects.toThrow()
    server.close()
  })
})

describe('redis.js connect handlers', () => {
  it('covers connect error handler rejecting queued commands', async () => {
    const server = net.createServer((socket) => {
      socket.on('data', () => socket.destroy(new Error('ECONNRESET')))
      socket.on('error', () => {})
    })
    await new Promise((resolve) => server.listen(0, '127.0.0.1', resolve))
    const { port } = server.address()
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port })
    await c.connect()
    const p = c.send('PING')
    c.socket.destroy(new Error('ECONNRESET'))
    await expect(p).rejects.toThrow()
    expect(c.connected).toBe(false)
    expect(c._connecting).toBe(false)
    c.socket.destroy(new Error('ECONNRESET'))
    await closeServer(server)
  })

  it('covers connect handler with auth and select', async () => {
    const server = net.createServer((socket) => {
      socket.on('data', (data) => {
        if (data.includes('AUTH')) socket.write(Buffer.from('+OK\r\n'))
        if (data.includes('SELECT')) socket.write(Buffer.from('+OK\r\n'))
      })
    })
    await new Promise((resolve) => server.listen(0, '127.0.0.1', resolve))
    const { port } = server.address()
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port, password: 's', db: 1 })
    await expect(c.connect()).resolves.toBeUndefined()
    expect(c.connected).toBe(true)
    c.socket.destroy(new Error('ECONNRESET'))
    await closeServer(server)
  })

  it('covers connect handler without auth/select', async () => {
    const server = net.createServer(() => {})
    await new Promise((resolve) => server.listen(0, '127.0.0.1', resolve))
    const { port } = server.address()
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port })
    await expect(c.connect()).resolves.toBeUndefined()
    expect(c.connected).toBe(true)
    c.socket.destroy(new Error('ECONNRESET'))
    await closeServer(server)
  })

  it('covers connect handler with auth failure', async () => {
    const server = net.createServer((socket) => {
      socket.on('data', () => socket.write(Buffer.from('-ERR invalid password\r\n')))
    })
    await new Promise((resolve) => server.listen(0, '127.0.0.1', resolve))
    const { port } = server.address()
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port, password: 's' })
    await expect(c.connect()).rejects.toThrow('ERR invalid password')
    expect(c.connected).toBe(false)
    c.socket.destroy(new Error('ECONNRESET'))
    await closeServer(server)
  })

  it('reconnect updates host and port and reconnects', async () => {
    let connections = 0
    const server = net.createServer((socket) => {
      connections++
      socket.on('data', () => socket.write(Buffer.from('+OK\r\n')))
    })
    await new Promise((resolve) => server.listen(0, '127.0.0.1', resolve))
    const { port } = server.address()
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port })

    await c.connect()
    expect(c.connected).toBe(true)
    expect(connections).toBe(1)

    await c.reconnect({ host: '127.0.0.1', port })
    expect(c.connected).toBe(true)
    expect(connections).toBe(2)
    expect(c.host).toBe('127.0.0.1')
    expect(c.port).toBe(port)
    c.socket.destroy()
    await closeServer(server)
  })

  it('reconnect with url re-parses all fields', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: 'oldhost', port: 6379 })
    c.socket = { write: vi.fn(), destroy: vi.fn() }
    c.queue.push({ reject: vi.fn() })

    const connectSpy = vi.spyOn(c, 'connect').mockResolvedValue()
    await c.reconnect({ url: 'redis://:newpass@newhost:6380/3' })
    expect(c.host).toBe('newhost')
    expect(c.port).toBe(6380)
    expect(c.password).toBe('newpass')
    expect(c.db).toBe(3)
    expect(c.connected).toBe(false)
    expect(c.queue.length).toBe(0)
    expect(connectSpy).toHaveBeenCalled()
    connectSpy.mockRestore()
  })

  it('reconnect rejects pending queue items', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port: 6379 })
    c.socket = { write: vi.fn(), destroy: vi.fn() }
    const rejectFn = vi.fn()
    c.queue.push({ resolve: vi.fn(), reject: rejectFn })
    c.queue.push({ resolve: vi.fn(), reject: vi.fn() })

    const connectSpy = vi.spyOn(c, 'connect').mockResolvedValue()
    await c.reconnect({ host: '127.0.0.1', port: 6379 })
    expect(rejectFn).toHaveBeenCalledWith(expect.objectContaining({ message: 'Reconnecting' }))
    expect(c.queue.length).toBe(0)
    connectSpy.mockRestore()
  })

  it('reconnect with minimal URL covers default fallbacks', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: 'oldhost', port: 9999, password: 'oldpw', db: 99 })
    c.socket = { write: vi.fn(), destroy: vi.fn() }
    const connectSpy = vi.spyOn(c, 'connect').mockResolvedValue()
    await c.reconnect({ url: 'redis:///0' })
    expect(c.host).toBe('127.0.0.1')
    expect(c.port).toBe(6379)
    expect(c.password).toBeUndefined()
    expect(c.db).toBe(0)
    connectSpy.mockRestore()
  })

  it('reconnect with all individual options sets all fields', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port: 6379 })
    c.socket = { write: vi.fn(), destroy: vi.fn() }
    const connectSpy = vi.spyOn(c, 'connect').mockResolvedValue()
    await c.reconnect({ host: 'newhost', port: 6380, db: 3, password: 'secret' })
    expect(c.host).toBe('newhost')
    expect(c.port).toBe(6380)
    expect(c.db).toBe(3)
    expect(c.password).toBe('secret')
    connectSpy.mockRestore()
  })

  it('reconnect with empty options preserves existing values', async () => {
    const RedisClient = _require('../../src/redis/index.js')
    const c = new RedisClient({ host: '127.0.0.1', port: 6379, db: 1, password: 'pw' })
    c.socket = { write: vi.fn(), destroy: vi.fn() }
    const connectSpy = vi.spyOn(c, 'connect').mockResolvedValue()
    await c.reconnect({})
    expect(c.host).toBe('127.0.0.1')
    expect(c.port).toBe(6379)
    expect(c.db).toBe(1)
    expect(c.password).toBe('pw')
    connectSpy.mockRestore()
  })
})