dangkhoa2016 commited on
Commit
7db7c77
·
1 Parent(s): a3bf2e3

feat: require confirm body for reset-database and extract mock factory

Browse files

- Guard the reset-database admin endpoint behind a confirmation body
- Extract a mock factory to simplify test configuration

README.md CHANGED
@@ -188,7 +188,9 @@ curl -X PATCH http://localhost:3000/api/admin/settings/NODE_ENV \
188
 
189
  # Reset database (clears all data and re-fetches from JSONPlaceholder)
190
  curl -X POST http://localhost:3000/api/admin/reset-database \
191
- -H "Authorization: Bearer my-secret-key"
 
 
192
  ```
193
 
194
  The `ADMIN_KEY` is hashed with **argon2** before storage. When updating the password via `PATCH /api/admin/settings/ADMIN_KEY`, the new value is automatically hashed. Passwords are never stored in plaintext.
 
188
 
189
  # Reset database (clears all data and re-fetches from JSONPlaceholder)
190
  curl -X POST http://localhost:3000/api/admin/reset-database \
191
+ -H "Authorization: Bearer my-secret-key" \
192
+ -H "Content-Type: application/json" \
193
+ -d '{"confirm": true}'
194
  ```
195
 
196
  The `ADMIN_KEY` is hashed with **argon2** before storage. When updating the password via `PATCH /api/admin/settings/ADMIN_KEY`, the new value is automatically hashed. Passwords are never stored in plaintext.
src/server/index.js CHANGED
@@ -255,9 +255,6 @@ async function checkAdminAuth(req) {
255
 
256
  async function handleAdmin(req, res, pathname, method) {
257
  if (!(await checkAdminAuth(req))) {
258
- /* v8 ignore start */ if (!adminKey) {
259
- return json(res, 401, { error: 'Admin not configured', message: 'ADMIN_KEY environment variable is not set' });
260
- } /* v8 ignore stop */
261
  return json(res, 401, { error: 'Unauthorized' });
262
  }
263
 
@@ -329,6 +326,11 @@ async function withResetLock(fn) {
329
  }
330
 
331
  async function handleAdminResetDatabase(req, res) {
 
 
 
 
 
332
  await withResetLock(async () => {
333
  const d = db.getWrappedDb();
334
  d.exec('BEGIN');
 
255
 
256
  async function handleAdmin(req, res, pathname, method) {
257
  if (!(await checkAdminAuth(req))) {
 
 
 
258
  return json(res, 401, { error: 'Unauthorized' });
259
  }
260
 
 
326
  }
327
 
328
  async function handleAdminResetDatabase(req, res) {
329
+ const body = await readBodySafe(req, res);
330
+ if (body === null) return;
331
+ if (body.confirm !== true) {
332
+ return badRequest(res, 'Reset requires confirm: true in request body');
333
+ }
334
  await withResetLock(async () => {
335
  const d = db.getWrappedDb();
336
  d.exec('BEGIN');
tests/README.md CHANGED
@@ -36,6 +36,7 @@ tests/
36
  server.test.js # Server request handler, admin auth, graceful shutdown (13 tests)
37
  helpers/
38
  coverage.js # Shared test utilities (save/restore/setEnv/clearCjs/configMockFactory)
 
39
  index.js # startServer / stopServer / request utilities
40
  seed.js # Standalone script to create & seed temp DB
41
  seed-settings-coverage.test.js # Seed-settings.js V8 coverage (4 tests)
 
36
  server.test.js # Server request handler, admin auth, graceful shutdown (13 tests)
37
  helpers/
38
  coverage.js # Shared test utilities (save/restore/setEnv/clearCjs/configMockFactory)
39
+ mock-factory.js # Mock factory helpers (mkDb/mkReq/mkRes/mkRedis/mkSettingsTable)
40
  index.js # startServer / stopServer / request utilities
41
  seed.js # Standalone script to create & seed temp DB
42
  seed-settings-coverage.test.js # Seed-settings.js V8 coverage (4 tests)
tests/helpers/mock-factory.js ADDED
@@ -0,0 +1,56 @@
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
+ import { vi } from 'vitest'
2
+
3
+ export function mkDb(overrides = {}) {
4
+ const mock = {
5
+ getDb: () => ({ prepare: () => ({ all: () => [], get: () => null, run: () => {} }), exec: () => {} }),
6
+ getWrappedDb: () => ({ prepare: () => ({ all: () => [], get: () => null, run: () => {} }), exec: () => {} }),
7
+ listAll: () => [],
8
+ getOne: () => null,
9
+ insertOne: () => null,
10
+ updateOne: () => null,
11
+ deleteOne: () => null,
12
+ nextId: () => 1,
13
+ TABLES: ['users', 'posts', 'comments', 'albums', 'photos', 'todos'],
14
+ }
15
+ return { ...mock, ...overrides }
16
+ }
17
+
18
+ export function mkRedis(overrides = {}) {
19
+ const mockClient = {
20
+ connect: vi.fn().mockResolvedValue(),
21
+ ping: vi.fn().mockResolvedValue(),
22
+ connected: false,
23
+ quit: vi.fn().mockResolvedValue(),
24
+ send: vi.fn().mockResolvedValue(),
25
+ ...overrides,
26
+ }
27
+ const mockRedisClass = function () { return mockClient }
28
+ return { mockClient, mockRedisClass }
29
+ }
30
+
31
+ export function mkReq(url = '/', method = 'GET', headers = {}, body) {
32
+ return {
33
+ url,
34
+ method,
35
+ headers: { ...headers },
36
+ socket: { remoteAddress: '::1' },
37
+ destroy() {},
38
+ on(evt, cb) {
39
+ if (evt === 'data' && body !== undefined) cb(body)
40
+ if (evt === 'end') queueMicrotask(() => cb())
41
+ },
42
+ }
43
+ }
44
+
45
+ export function mkRes() {
46
+ return { writeHead: vi.fn(), end: vi.fn(), setHeader: vi.fn(), writableEnded: false }
47
+ }
48
+
49
+ export function mkSettingsTable(entries) {
50
+ if (entries) return entries
51
+ return [
52
+ { key: 'ADMIN_KEY', value: '$argon2id$v=19$m=65536,t=3,p=4$mockedhash', description: 'Admin key', updated_at: '2025-01-01' },
53
+ { key: 'NODE_ENV', value: 'development', description: 'Environment', updated_at: '2025-01-01' },
54
+ { key: 'REDIS_PASSWORD', value: 'mockpassword', description: 'Redis password', updated_at: '2025-01-01' },
55
+ ]
56
+ }
tests/server/integration.test.js CHANGED
@@ -615,6 +615,7 @@ describe('Admin routes', () => {
615
  const res = await request('/api/admin/reset-database', {
616
  method: 'POST',
617
  headers: { authorization: `Bearer ${adminToken}` },
 
618
  });
619
  expect(res.status).toBe(200);
620
  expect(res.body.message).toContain('reset');
 
615
  const res = await request('/api/admin/reset-database', {
616
  method: 'POST',
617
  headers: { authorization: `Bearer ${adminToken}` },
618
+ body: { confirm: true },
619
  });
620
  expect(res.status).toBe(200);
621
  expect(res.body.message).toContain('reset');
tests/server/server.test.js CHANGED
@@ -5,6 +5,7 @@ import { mkdtempSync } from 'fs'
5
  import { tmpdir } from 'os'
6
  import { createRequire } from 'module'
7
  import { save, restore, setEnv, configMockFactory } from '../helpers/coverage'
 
8
 
9
  const tmpDir = mkdtempSync(path.join(tmpdir(), 'cov-srv-'))
10
  const _require = createRequire(import.meta.url)
@@ -26,17 +27,10 @@ describe('server.js', () => {
26
  it('handles 500 when db throws', async () => {
27
  const s = save('START_SERVER', 'PORT', 'REDIS_URL', 'DB_PATH')
28
  setEnv({ START_SERVER: 'false', PORT: '0', REDIS_URL: '', DB_PATH: path.join(tmpDir, 'srv1.db') })
29
- const mockDb = {
30
- getDb: () => ({ prepare: () => ({ all: () => [], get: () => null, run: () => {} }), exec: () => {} }),
31
- getWrappedDb: () => ({ prepare: () => ({ all: () => [], get: () => null, run: () => {} }), exec: () => {} }),
32
  listAll: () => { throw new Error('boom') },
33
- getOne: () => null,
34
  insertOne: () => { throw new Error('duplicate') },
35
- updateOne: () => null,
36
- deleteOne: () => null,
37
- nextId: () => 1,
38
- TABLES: ['users', 'posts', 'comments', 'albums', 'photos', 'todos'],
39
- }
40
  clearCjs('../../src/server/index.js', '../../src/db/index.js', '../../src/middleware/rate-limiter.js')
41
  const resolvedDb = _require.resolve('../../src/db/index.js')
42
  _require.cache[resolvedDb] = { exports: mockDb, id: resolvedDb, filename: resolvedDb, loaded: true }
@@ -44,33 +38,24 @@ describe('server.js', () => {
44
  vi.resetModules()
45
  const { requestHandler } = await import('../../src/server/index.js')
46
 
47
- const mkReq = (url, method, body) => ({
48
- url, method, headers: {}, socket: { remoteAddress: '::1' },
49
- on: (evt, cb) => {
50
- if (evt === 'data' && body) cb(body)
51
- if (evt === 'end') queueMicrotask(() => cb())
52
- },
53
- })
54
- const mkRes = () => ({ writeHead: vi.fn(), end: vi.fn(), setHeader: vi.fn(), writableEnded: false })
55
-
56
  const res1 = mkRes()
57
  await requestHandler(mkReq('/api/users', 'GET'), res1)
58
  expect(res1.writeHead).toHaveBeenCalledWith(500, expect.anything())
59
 
60
  const res2 = mkRes()
61
- await requestHandler(mkReq('/api/users', 'POST', '{"name":"X"}'), res2)
62
  expect(res2.writeHead).toHaveBeenCalledWith(400, expect.anything())
63
 
64
  const res3 = mkRes()
65
- await requestHandler(mkReq('/api/users/1', 'PUT', 'bad-json'), res3)
66
  expect(res3.writeHead).toHaveBeenCalledWith(400, expect.anything())
67
 
68
  const res4 = mkRes()
69
- await requestHandler(mkReq('/api/users/1', 'PATCH', 'bad-json'), res4)
70
  expect(res4.writeHead).toHaveBeenCalledWith(400, expect.anything())
71
 
72
  const res5 = mkRes()
73
- await requestHandler(mkReq('/api/users', 'POST', ''), res5)
74
  expect(res5.writeHead).toHaveBeenCalledWith(400, expect.anything())
75
  } finally {
76
  delete _require.cache[resolvedDb]
@@ -81,25 +66,13 @@ describe('server.js', () => {
81
  it('rejects invalid pagination params with 400', async () => {
82
  const s = save('START_SERVER', 'PORT', 'REDIS_URL', 'DB_PATH')
83
  setEnv({ START_SERVER: 'false', PORT: '0', REDIS_URL: '', DB_PATH: path.join(tmpDir, 'srv-pag.db') })
84
- const mockDb = {
85
- getDb: () => ({ prepare: () => ({ all: () => [], get: () => null, run: () => {} }), exec: () => {} }),
86
- getWrappedDb: () => ({ prepare: () => ({ all: () => [], get: () => null, run: () => {} }), exec: () => {} }),
87
- listAll: () => [],
88
- getOne: () => null,
89
- insertOne: () => null,
90
- updateOne: () => null,
91
- deleteOne: () => null,
92
- nextId: () => 1,
93
- TABLES: ['users', 'posts', 'comments', 'albums', 'photos', 'todos'],
94
- }
95
  clearCjs('../../src/server/index.js', '../../src/db/index.js', '../../src/middleware/rate-limiter.js')
96
  const resolvedDb = _require.resolve('../../src/db/index.js')
97
  _require.cache[resolvedDb] = { exports: mockDb, id: resolvedDb, filename: resolvedDb, loaded: true }
98
  try {
99
  vi.resetModules()
100
  const { requestHandler } = await import('../../src/server/index.js')
101
- const mkReq = (url) => ({ url, method: 'GET', headers: {}, socket: { remoteAddress: '::1' }, on: () => {} })
102
- const mkRes = () => ({ writeHead: vi.fn(), end: vi.fn(), setHeader: vi.fn(), writableEnded: false })
103
 
104
  const badParams = ['_page=abc', '_limit=-1', '_start=NaN', '_end=1.5']
105
  for (const param of badParams) {
@@ -120,25 +93,13 @@ describe('server.js', () => {
120
  it('returns 400 for non-numeric ID in route', async () => {
121
  const s = save('START_SERVER', 'PORT', 'REDIS_URL', 'DB_PATH')
122
  setEnv({ START_SERVER: 'false', PORT: '0', REDIS_URL: '', DB_PATH: path.join(tmpDir, 'srv-id.db') })
123
- const mockDb = {
124
- getDb: () => ({ prepare: () => ({ all: () => [], get: () => null, run: () => {} }), exec: () => {} }),
125
- getWrappedDb: () => ({ prepare: () => ({ all: () => [], get: () => null, run: () => {} }), exec: () => {} }),
126
- listAll: () => [],
127
- getOne: () => null,
128
- insertOne: () => null,
129
- updateOne: () => null,
130
- deleteOne: () => null,
131
- nextId: () => 1,
132
- TABLES: ['users', 'posts', 'comments', 'albums', 'photos', 'todos'],
133
- }
134
  clearCjs('../../src/server/index.js', '../../src/db/index.js', '../../src/middleware/rate-limiter.js')
135
  const resolvedDb = _require.resolve('../../src/db/index.js')
136
  _require.cache[resolvedDb] = { exports: mockDb, id: resolvedDb, filename: resolvedDb, loaded: true }
137
  try {
138
  vi.resetModules()
139
  const { requestHandler } = await import('../../src/server/index.js')
140
- const mkReq = (url) => ({ url, method: 'GET', headers: {}, socket: { remoteAddress: '::1' }, on: () => {} })
141
- const mkRes = () => ({ writeHead: vi.fn(), end: vi.fn(), setHeader: vi.fn(), writableEnded: false })
142
 
143
  const res = mkRes()
144
  await requestHandler(mkReq('/api/users/abc'), res)
@@ -172,29 +133,12 @@ describe('server.js', () => {
172
  const s = save('START_SERVER', 'REDIS_URL', 'DB_PATH')
173
  setEnv({ START_SERVER: 'false', REDIS_URL: '', DB_PATH: path.join(tmpDir, 'srv-redis-banner.db') })
174
 
175
- const mockDb = {
176
- getDb: () => ({ prepare: () => ({ all: () => [], get: () => null, run: () => {} }), exec: () => {} }),
177
- getWrappedDb: () => ({ prepare: () => ({ all: () => [], get: () => null, run: () => {} }), exec: () => {} }),
178
- listAll: () => [],
179
- getOne: () => null,
180
- insertOne: () => null,
181
- updateOne: () => null,
182
- deleteOne: () => null,
183
- nextId: () => 1,
184
- TABLES: ['users', 'posts', 'comments', 'albums', 'photos', 'todos'],
185
- }
186
 
187
  const resolvedRedis = _require.resolve('../../src/redis/index.js')
188
  const resolvedDb = _require.resolve('../../src/db/index.js')
189
 
190
- const mockClient = {
191
- connect: vi.fn().mockResolvedValue(),
192
- ping: vi.fn().mockResolvedValue(),
193
- connected: true,
194
- quit: vi.fn().mockResolvedValue(),
195
- send: vi.fn().mockResolvedValue(),
196
- }
197
- const mockRedisClass = function() { return mockClient }
198
 
199
  const origRedisCache = _require.cache[resolvedRedis]
200
  const origDbCache = _require.cache[resolvedDb]
@@ -249,8 +193,7 @@ describe('server.js', () => {
249
  { key: 'REDIS_PASSWORD', value: 'mockpassword', description: 'Redis password', updated_at: '2025-01-01' },
250
  ]
251
 
252
- const mockDb = {
253
- getDb: () => ({ prepare: () => ({ all: () => [], get: () => null, run: () => {} }), exec: () => {} }),
254
  getWrappedDb: () => ({
255
  prepare: (sql) => {
256
  if (sql.includes('SELECT value FROM settings')) {
@@ -267,18 +210,13 @@ describe('server.js', () => {
267
  exec: () => {},
268
  }),
269
  listAll: () => settingsTable,
270
- getOne: () => null,
271
- insertOne: () => null,
272
- updateOne: () => null,
273
- deleteOne: () => null,
274
- nextId: () => 1,
275
  TABLES: ['users', 'posts', 'comments', 'albums', 'photos', 'todos', 'settings'],
276
- }
277
 
278
  const resolvedDb = _require.resolve('../../src/db/index.js')
279
  const resolvedRedis = _require.resolve('../../src/redis/index.js')
280
  const resolvedSeed = _require.resolve('../../src/db/seed.js')
281
- const mockRedisClass = function() { return { connect: vi.fn().mockResolvedValue(), ping: vi.fn().mockResolvedValue(), connected: false, quit: vi.fn().mockResolvedValue() } }
282
 
283
  const origDbCache = _require.cache[resolvedDb]
284
  const origRedisCache = _require.cache[resolvedRedis]
@@ -296,15 +234,6 @@ describe('server.js', () => {
296
  clearCjs('../../src/server/index.js', '../../src/middleware/rate-limiter.js', '../../src/config/index.js', '../../src/config/load-env.js')
297
  vi.resetModules()
298
  const { requestHandler } = await import('../../src/server/index.js')
299
- const mkReq = (url, method, headers = {}, body) => ({
300
- url, method, headers: { ...headers }, socket: { remoteAddress: '::1' },
301
- destroy: () => {},
302
- on: (evt, cb) => {
303
- if (evt === 'data' && body) cb(body)
304
- if (evt === 'end') queueMicrotask(() => cb())
305
- },
306
- })
307
- const mkRes = () => ({ writeHead: vi.fn(), end: vi.fn(), setHeader: vi.fn(), writableEnded: false })
308
 
309
  const res0 = mkRes()
310
  await requestHandler(mkReq('/api/admin/settings', 'GET'), res0)
@@ -363,9 +292,18 @@ describe('server.js', () => {
363
  expect(res9.writeHead).toHaveBeenCalledWith(400, expect.anything())
364
 
365
  const resReset = mkRes()
366
- await requestHandler(mkReq('/api/admin/reset-database', 'POST', { authorization: 'Bearer secret' }), resReset)
367
  expect(resReset.writeHead).toHaveBeenCalledWith(200, expect.anything())
368
 
 
 
 
 
 
 
 
 
 
369
  argon2Mock.verify = vi.fn().mockRejectedValue(new Error('verify fail'))
370
  const resThrow = mkRes()
371
  await requestHandler(mkReq('/api/admin/settings', 'GET', { authorization: 'Bearer uncached' }), resThrow)
@@ -392,29 +330,12 @@ describe('server.js', () => {
392
  const s = save('START_SERVER', 'PORT', 'REDIS_URL', 'DB_PATH')
393
  setEnv({ START_SERVER: 'false', PORT: '0', REDIS_URL: '', DB_PATH: path.join(tmpDir, 'srv-redis.db') })
394
 
395
- const mockDb = {
396
- getDb: () => ({ prepare: () => ({ all: () => [], get: () => null, run: () => {} }), exec: () => {} }),
397
- getWrappedDb: () => ({ prepare: () => ({ all: () => [], get: () => null, run: () => {} }), exec: () => {} }),
398
- listAll: () => [],
399
- getOne: () => null,
400
- insertOne: () => null,
401
- updateOne: () => null,
402
- deleteOne: () => null,
403
- nextId: () => 1,
404
- TABLES: ['users', 'posts', 'comments', 'albums', 'photos', 'todos'],
405
- }
406
 
407
  const resolvedRedis = _require.resolve('../../src/redis/index.js')
408
  const resolvedDb = _require.resolve('../../src/db/index.js')
409
 
410
- const mockClient = {
411
- connect: vi.fn().mockResolvedValue(),
412
- ping: vi.fn().mockResolvedValue(),
413
- connected: true,
414
- quit: vi.fn().mockResolvedValue(),
415
- send: vi.fn().mockResolvedValue(),
416
- }
417
- const mockRedisClass = function() { return mockClient }
418
 
419
  const origRedisCache = _require.cache[resolvedRedis]
420
  const origDbCache = _require.cache[resolvedDb]
@@ -463,17 +384,11 @@ describe('server.js', () => {
463
  clearCjs('../../src/server/index.js', '../../src/middleware/rate-limiter.js', '../../src/redis/index.js')
464
  vi.resetModules()
465
 
466
- const mockClient = {
467
- connect: vi.fn().mockResolvedValue(),
468
- ping: vi.fn().mockResolvedValue(),
469
- connected: false,
470
- quit: vi.fn().mockResolvedValue(),
471
- send: vi.fn().mockResolvedValue(),
472
- }
473
  const resolvedRedis = _require.resolve('../../src/redis/index.js')
474
  const origRedisCache = _require.cache[resolvedRedis]
475
  _require.cache[resolvedRedis] = {
476
- exports: function() { return mockClient },
477
  id: resolvedRedis, filename: resolvedRedis, loaded: true,
478
  }
479
 
@@ -519,8 +434,7 @@ describe('server.js', () => {
519
  { key: 'ADMIN_KEY', value: '$argon2id$v=19$m=65536,t=3,p=4$mockedhash', description: 'Admin key', updated_at: '2025-01-01' },
520
  ]
521
 
522
- const mockDb = {
523
- getDb: () => ({ prepare: () => ({ all: () => [], get: () => null, run: () => {} }), exec: () => {} }),
524
  getWrappedDb: () => ({
525
  prepare: (sql) => {
526
  if (sql.includes('SELECT value FROM settings')) return { get: () => settingsTable[0] }
@@ -529,15 +443,12 @@ describe('server.js', () => {
529
  exec: () => {},
530
  }),
531
  listAll: () => settingsTable,
532
- getOne: () => null, insertOne: () => null, updateOne: () => null,
533
- deleteOne: () => null, nextId: () => 1,
534
  TABLES: ['users', 'posts', 'comments', 'albums', 'photos', 'todos', 'settings'],
535
- }
536
 
537
  const resolvedDb = _require.resolve('../../src/db/index.js')
538
  const resolvedRedis = _require.resolve('../../src/redis/index.js')
539
- const mockRedisClass = function() { return { connect: vi.fn().mockResolvedValue(), ping: vi.fn().mockResolvedValue(), connected: false, quit: vi.fn().mockResolvedValue() } }
540
-
541
  const origDbCache = _require.cache[resolvedDb]
542
  const origRedisCache = _require.cache[resolvedRedis]
543
  _require.cache[resolvedDb] = { exports: mockDb, id: resolvedDb, filename: resolvedDb, loaded: true }
@@ -547,29 +458,24 @@ describe('server.js', () => {
547
  clearCjs('../../src/server/index.js', '../../src/middleware/rate-limiter.js')
548
  vi.resetModules()
549
  const { requestHandler } = await import('../../src/server/index.js')
550
- const mkReq = (headers = {}) => ({
551
- url: '/api/admin/settings', method: 'GET', headers,
552
- socket: { remoteAddress: '::1' }, on: () => {},
553
- })
554
- const mkRes = () => ({ writeHead: vi.fn(), end: vi.fn(), setHeader: vi.fn(), writableEnded: false })
555
 
556
  const res1 = mkRes()
557
- await requestHandler(mkReq({ authorization: 'Bearer secret' }), res1)
558
  expect(res1.writeHead).toHaveBeenCalledWith(200, expect.anything())
559
  const firstCalls = verifySpy.mock.calls.length
560
 
561
  const res2 = mkRes()
562
- await requestHandler(mkReq({ authorization: 'Bearer secret' }), res2)
563
  expect(res2.writeHead).toHaveBeenCalledWith(200, expect.anything())
564
  expect(verifySpy.mock.calls.length).toBe(firstCalls)
565
 
566
  const res3 = mkRes()
567
- await requestHandler(mkReq({ authorization: 'Bearer wrong' }), res3)
568
  expect(res3.writeHead).toHaveBeenCalledWith(401, expect.anything())
569
  expect(verifySpy.mock.calls.length).toBe(firstCalls + 1)
570
 
571
  const res4 = mkRes()
572
- await requestHandler(mkReq({ authorization: 'Bearer wrong' }), res4)
573
  expect(res4.writeHead).toHaveBeenCalledWith(401, expect.anything())
574
  expect(verifySpy.mock.calls.length).toBe(firstCalls + 1)
575
  } finally {
@@ -593,8 +499,7 @@ describe('server.js', () => {
593
  arModule.verify = vi.fn().mockResolvedValue(true)
594
  arModule.hash = vi.fn().mockResolvedValue('$argon2id$mockhash')
595
 
596
- const mockDbThrows = {
597
- getDb: () => ({ prepare: () => ({ all: () => [], get: () => null, run: () => {} }), exec: () => {} }),
598
  getWrappedDb: () => ({
599
  prepare: (sql) => {
600
  if (sql.includes('SELECT value FROM settings')) return { get: () => ({ value: '$argon2id$mockhash' }) }
@@ -603,15 +508,13 @@ describe('server.js', () => {
603
  exec: () => {},
604
  }),
605
  listAll: () => { throw new Error('unexpected db error') },
606
- getOne: () => null, insertOne: () => null, updateOne: () => null,
607
- deleteOne: () => null, nextId: () => 1,
608
  TABLES: ['users', 'posts', 'comments', 'albums', 'photos', 'todos', 'settings'],
609
- }
610
 
611
  const resolvedDb = _require.resolve('../../src/db/index.js')
612
  const resolvedRedis = _require.resolve('../../src/redis/index.js')
613
  const resolvedSeed = _require.resolve('../../src/db/seed.js')
614
- const mockRedisClass = function() { return { connect: vi.fn().mockResolvedValue(), ping: vi.fn().mockResolvedValue(), connected: false, quit: vi.fn().mockResolvedValue() } }
615
 
616
  const origDbCache = _require.cache[resolvedDb]
617
  const origRedisCache = _require.cache[resolvedRedis]
@@ -624,14 +527,9 @@ describe('server.js', () => {
624
  clearCjs('../../src/server/index.js', '../../src/middleware/rate-limiter.js')
625
  vi.resetModules()
626
  const { requestHandler } = await import('../../src/server/index.js')
627
- const mkReq = (headers = {}) => ({
628
- url: '/api/admin/settings', method: 'GET', headers,
629
- socket: { remoteAddress: '::1' }, on: () => {},
630
- })
631
- const mkRes = () => ({ writeHead: vi.fn(), end: vi.fn(), setHeader: vi.fn(), writableEnded: false })
632
 
633
  const res = mkRes()
634
- await requestHandler(mkReq({ authorization: 'Bearer secret' }), res)
635
  expect(res.writeHead).toHaveBeenCalledWith(500, expect.anything())
636
  } finally {
637
  arModule.verify = origArVerify
@@ -664,19 +562,16 @@ describe('server.js', () => {
664
  },
665
  exec: vi.fn(),
666
  }
667
- const mockDbSeedFail = {
668
- getDb: () => ({ prepare: () => ({ all: () => [], get: () => null, run: () => {} }), exec: () => {} }),
669
  getWrappedDb: () => wrappedDb,
670
  listAll: () => [{ key: 'foo', value: 'bar' }],
671
- getOne: () => null, insertOne: () => null, updateOne: () => null,
672
- deleteOne: () => null, nextId: () => 1,
673
  TABLES: ['users', 'posts', 'comments', 'albums', 'photos', 'todos', 'settings'],
674
- }
675
 
676
  const resolvedDb = _require.resolve('../../src/db/index.js')
677
  const resolvedRedis = _require.resolve('../../src/redis/index.js')
678
  const resolvedSeed = _require.resolve('../../src/db/seed.js')
679
- const mockRedisClass = function() { return { connect: vi.fn().mockResolvedValue(), ping: vi.fn().mockResolvedValue(), connected: false, quit: vi.fn().mockResolvedValue() } }
680
 
681
  const origDbCache = _require.cache[resolvedDb]
682
  const origRedisCache = _require.cache[resolvedRedis]
@@ -689,15 +584,9 @@ describe('server.js', () => {
689
  clearCjs('../../src/server/index.js', '../../src/middleware/rate-limiter.js')
690
  vi.resetModules()
691
  const { requestHandler } = await import('../../src/server/index.js')
692
- const mkReq = (headers = {}, body) => ({
693
- url: '/api/admin/reset-database', method: 'POST', headers,
694
- socket: { remoteAddress: '::1' }, on: () => {},
695
- body: body ? JSON.stringify(body) : '',
696
- })
697
- const mkRes = () => ({ writeHead: vi.fn(), end: vi.fn(), setHeader: vi.fn(), writableEnded: false })
698
 
699
  const res = mkRes()
700
- await requestHandler(mkReq({ authorization: 'Bearer secret', 'content-type': 'application/json' }), res)
701
  expect(res.writeHead).toHaveBeenCalledWith(500, expect.anything())
702
  expect(mockDbSeedFail.getWrappedDb().exec).toHaveBeenCalledWith('ROLLBACK')
703
  } finally {
@@ -727,8 +616,7 @@ describe('server.js', () => {
727
  { key: 'ADMIN_KEY', value: '$argon2id$v=19$m=65536,t=3,p=4$mockedhash', description: 'Admin key', updated_at: '2025-01-01' },
728
  ]
729
 
730
- const mockDb = {
731
- getDb: () => ({ prepare: () => ({ all: () => [], get: () => null, run: () => {} }), exec: () => {} }),
732
  getWrappedDb: () => ({
733
  prepare: (sql) => {
734
  if (sql.includes('SELECT value FROM settings')) return { get: () => settingsTable[0] }
@@ -737,14 +625,12 @@ describe('server.js', () => {
737
  exec: () => {},
738
  }),
739
  listAll: () => settingsTable,
740
- getOne: () => null, insertOne: () => null, updateOne: () => null,
741
- deleteOne: () => null, nextId: () => 1,
742
  TABLES: ['users', 'posts', 'comments', 'albums', 'photos', 'todos', 'settings'],
743
- }
744
 
745
  const resolvedDb = _require.resolve('../../src/db/index.js')
746
  const resolvedRedis = _require.resolve('../../src/redis/index.js')
747
- const mockRedisClass = function() { return { connect: vi.fn().mockResolvedValue(), ping: vi.fn().mockResolvedValue(), connected: false, quit: vi.fn().mockResolvedValue() } }
748
 
749
  const origDbCache = _require.cache[resolvedDb]
750
  const origRedisCache = _require.cache[resolvedRedis]
@@ -755,19 +641,14 @@ describe('server.js', () => {
755
  clearCjs('../../src/server/index.js', '../../src/middleware/rate-limiter.js')
756
  vi.resetModules()
757
  const { requestHandler } = await import('../../src/server/index.js')
758
- const mkReq = (headers = {}) => ({
759
- url: '/api/admin/settings', method: 'GET', headers,
760
- socket: { remoteAddress: '::1' }, on: () => {},
761
- })
762
- const mkRes = () => ({ writeHead: vi.fn(), end: vi.fn(), setHeader: vi.fn(), writableEnded: false })
763
 
764
  const res1 = mkRes()
765
- await requestHandler(mkReq({ authorization: 'Bearer throw' }), res1)
766
  expect(res1.writeHead).toHaveBeenCalledWith(401, expect.anything())
767
  expect(verifySpy).toHaveBeenCalledTimes(1)
768
 
769
  const res2 = mkRes()
770
- await requestHandler(mkReq({ authorization: 'Bearer throw' }), res2)
771
  expect(res2.writeHead).toHaveBeenCalledWith(401, expect.anything())
772
  expect(verifySpy).toHaveBeenCalledTimes(1)
773
  } finally {
 
5
  import { tmpdir } from 'os'
6
  import { createRequire } from 'module'
7
  import { save, restore, setEnv, configMockFactory } from '../helpers/coverage'
8
+ import { mkDb, mkRedis, mkReq, mkRes } from '../helpers/mock-factory'
9
 
10
  const tmpDir = mkdtempSync(path.join(tmpdir(), 'cov-srv-'))
11
  const _require = createRequire(import.meta.url)
 
27
  it('handles 500 when db throws', async () => {
28
  const s = save('START_SERVER', 'PORT', 'REDIS_URL', 'DB_PATH')
29
  setEnv({ START_SERVER: 'false', PORT: '0', REDIS_URL: '', DB_PATH: path.join(tmpDir, 'srv1.db') })
30
+ const mockDb = mkDb({
 
 
31
  listAll: () => { throw new Error('boom') },
 
32
  insertOne: () => { throw new Error('duplicate') },
33
+ })
 
 
 
 
34
  clearCjs('../../src/server/index.js', '../../src/db/index.js', '../../src/middleware/rate-limiter.js')
35
  const resolvedDb = _require.resolve('../../src/db/index.js')
36
  _require.cache[resolvedDb] = { exports: mockDb, id: resolvedDb, filename: resolvedDb, loaded: true }
 
38
  vi.resetModules()
39
  const { requestHandler } = await import('../../src/server/index.js')
40
 
 
 
 
 
 
 
 
 
 
41
  const res1 = mkRes()
42
  await requestHandler(mkReq('/api/users', 'GET'), res1)
43
  expect(res1.writeHead).toHaveBeenCalledWith(500, expect.anything())
44
 
45
  const res2 = mkRes()
46
+ await requestHandler(mkReq('/api/users', 'POST', {}, '{"name":"X"}'), res2)
47
  expect(res2.writeHead).toHaveBeenCalledWith(400, expect.anything())
48
 
49
  const res3 = mkRes()
50
+ await requestHandler(mkReq('/api/users/1', 'PUT', {}, 'bad-json'), res3)
51
  expect(res3.writeHead).toHaveBeenCalledWith(400, expect.anything())
52
 
53
  const res4 = mkRes()
54
+ await requestHandler(mkReq('/api/users/1', 'PATCH', {}, 'bad-json'), res4)
55
  expect(res4.writeHead).toHaveBeenCalledWith(400, expect.anything())
56
 
57
  const res5 = mkRes()
58
+ await requestHandler(mkReq('/api/users', 'POST', {}, ''), res5)
59
  expect(res5.writeHead).toHaveBeenCalledWith(400, expect.anything())
60
  } finally {
61
  delete _require.cache[resolvedDb]
 
66
  it('rejects invalid pagination params with 400', async () => {
67
  const s = save('START_SERVER', 'PORT', 'REDIS_URL', 'DB_PATH')
68
  setEnv({ START_SERVER: 'false', PORT: '0', REDIS_URL: '', DB_PATH: path.join(tmpDir, 'srv-pag.db') })
69
+ const mockDb = mkDb()
 
 
 
 
 
 
 
 
 
 
70
  clearCjs('../../src/server/index.js', '../../src/db/index.js', '../../src/middleware/rate-limiter.js')
71
  const resolvedDb = _require.resolve('../../src/db/index.js')
72
  _require.cache[resolvedDb] = { exports: mockDb, id: resolvedDb, filename: resolvedDb, loaded: true }
73
  try {
74
  vi.resetModules()
75
  const { requestHandler } = await import('../../src/server/index.js')
 
 
76
 
77
  const badParams = ['_page=abc', '_limit=-1', '_start=NaN', '_end=1.5']
78
  for (const param of badParams) {
 
93
  it('returns 400 for non-numeric ID in route', async () => {
94
  const s = save('START_SERVER', 'PORT', 'REDIS_URL', 'DB_PATH')
95
  setEnv({ START_SERVER: 'false', PORT: '0', REDIS_URL: '', DB_PATH: path.join(tmpDir, 'srv-id.db') })
96
+ const mockDb = mkDb()
 
 
 
 
 
 
 
 
 
 
97
  clearCjs('../../src/server/index.js', '../../src/db/index.js', '../../src/middleware/rate-limiter.js')
98
  const resolvedDb = _require.resolve('../../src/db/index.js')
99
  _require.cache[resolvedDb] = { exports: mockDb, id: resolvedDb, filename: resolvedDb, loaded: true }
100
  try {
101
  vi.resetModules()
102
  const { requestHandler } = await import('../../src/server/index.js')
 
 
103
 
104
  const res = mkRes()
105
  await requestHandler(mkReq('/api/users/abc'), res)
 
133
  const s = save('START_SERVER', 'REDIS_URL', 'DB_PATH')
134
  setEnv({ START_SERVER: 'false', REDIS_URL: '', DB_PATH: path.join(tmpDir, 'srv-redis-banner.db') })
135
 
136
+ const mockDb = mkDb()
 
 
 
 
 
 
 
 
 
 
137
 
138
  const resolvedRedis = _require.resolve('../../src/redis/index.js')
139
  const resolvedDb = _require.resolve('../../src/db/index.js')
140
 
141
+ const { mockRedisClass } = mkRedis({ connected: true })
 
 
 
 
 
 
 
142
 
143
  const origRedisCache = _require.cache[resolvedRedis]
144
  const origDbCache = _require.cache[resolvedDb]
 
193
  { key: 'REDIS_PASSWORD', value: 'mockpassword', description: 'Redis password', updated_at: '2025-01-01' },
194
  ]
195
 
196
+ const mockDb = mkDb({
 
197
  getWrappedDb: () => ({
198
  prepare: (sql) => {
199
  if (sql.includes('SELECT value FROM settings')) {
 
210
  exec: () => {},
211
  }),
212
  listAll: () => settingsTable,
 
 
 
 
 
213
  TABLES: ['users', 'posts', 'comments', 'albums', 'photos', 'todos', 'settings'],
214
+ })
215
 
216
  const resolvedDb = _require.resolve('../../src/db/index.js')
217
  const resolvedRedis = _require.resolve('../../src/redis/index.js')
218
  const resolvedSeed = _require.resolve('../../src/db/seed.js')
219
+ const { mockRedisClass } = mkRedis()
220
 
221
  const origDbCache = _require.cache[resolvedDb]
222
  const origRedisCache = _require.cache[resolvedRedis]
 
234
  clearCjs('../../src/server/index.js', '../../src/middleware/rate-limiter.js', '../../src/config/index.js', '../../src/config/load-env.js')
235
  vi.resetModules()
236
  const { requestHandler } = await import('../../src/server/index.js')
 
 
 
 
 
 
 
 
 
237
 
238
  const res0 = mkRes()
239
  await requestHandler(mkReq('/api/admin/settings', 'GET'), res0)
 
292
  expect(res9.writeHead).toHaveBeenCalledWith(400, expect.anything())
293
 
294
  const resReset = mkRes()
295
+ await requestHandler(mkReq('/api/admin/reset-database', 'POST', { authorization: 'Bearer secret' }, JSON.stringify({ confirm: true })), resReset)
296
  expect(resReset.writeHead).toHaveBeenCalledWith(200, expect.anything())
297
 
298
+ const resResetNoConfirm = mkRes()
299
+ await requestHandler(mkReq('/api/admin/reset-database', 'POST', { authorization: 'Bearer secret' }), resResetNoConfirm)
300
+ expect(resResetNoConfirm.writeHead).toHaveBeenCalledWith(400, expect.anything())
301
+
302
+ // malformed JSON body → readBodySafe returns null → early return from handleAdminResetDatabase
303
+ const resMalformed = mkRes()
304
+ await requestHandler(mkReq('/api/admin/reset-database', 'POST', { authorization: 'Bearer secret' }, 'not json'), resMalformed)
305
+ expect(resMalformed.writeHead).toHaveBeenCalledWith(400, expect.anything())
306
+
307
  argon2Mock.verify = vi.fn().mockRejectedValue(new Error('verify fail'))
308
  const resThrow = mkRes()
309
  await requestHandler(mkReq('/api/admin/settings', 'GET', { authorization: 'Bearer uncached' }), resThrow)
 
330
  const s = save('START_SERVER', 'PORT', 'REDIS_URL', 'DB_PATH')
331
  setEnv({ START_SERVER: 'false', PORT: '0', REDIS_URL: '', DB_PATH: path.join(tmpDir, 'srv-redis.db') })
332
 
333
+ const mockDb = mkDb()
 
 
 
 
 
 
 
 
 
 
334
 
335
  const resolvedRedis = _require.resolve('../../src/redis/index.js')
336
  const resolvedDb = _require.resolve('../../src/db/index.js')
337
 
338
+ const { mockRedisClass } = mkRedis({ connected: true })
 
 
 
 
 
 
 
339
 
340
  const origRedisCache = _require.cache[resolvedRedis]
341
  const origDbCache = _require.cache[resolvedDb]
 
384
  clearCjs('../../src/server/index.js', '../../src/middleware/rate-limiter.js', '../../src/redis/index.js')
385
  vi.resetModules()
386
 
387
+ const { mockClient, mockRedisClass } = mkRedis()
 
 
 
 
 
 
388
  const resolvedRedis = _require.resolve('../../src/redis/index.js')
389
  const origRedisCache = _require.cache[resolvedRedis]
390
  _require.cache[resolvedRedis] = {
391
+ exports: mockRedisClass,
392
  id: resolvedRedis, filename: resolvedRedis, loaded: true,
393
  }
394
 
 
434
  { key: 'ADMIN_KEY', value: '$argon2id$v=19$m=65536,t=3,p=4$mockedhash', description: 'Admin key', updated_at: '2025-01-01' },
435
  ]
436
 
437
+ const mockDb = mkDb({
 
438
  getWrappedDb: () => ({
439
  prepare: (sql) => {
440
  if (sql.includes('SELECT value FROM settings')) return { get: () => settingsTable[0] }
 
443
  exec: () => {},
444
  }),
445
  listAll: () => settingsTable,
 
 
446
  TABLES: ['users', 'posts', 'comments', 'albums', 'photos', 'todos', 'settings'],
447
+ })
448
 
449
  const resolvedDb = _require.resolve('../../src/db/index.js')
450
  const resolvedRedis = _require.resolve('../../src/redis/index.js')
451
+ const { mockRedisClass } = mkRedis()
 
452
  const origDbCache = _require.cache[resolvedDb]
453
  const origRedisCache = _require.cache[resolvedRedis]
454
  _require.cache[resolvedDb] = { exports: mockDb, id: resolvedDb, filename: resolvedDb, loaded: true }
 
458
  clearCjs('../../src/server/index.js', '../../src/middleware/rate-limiter.js')
459
  vi.resetModules()
460
  const { requestHandler } = await import('../../src/server/index.js')
 
 
 
 
 
461
 
462
  const res1 = mkRes()
463
+ await requestHandler(mkReq('/api/admin/settings', 'GET', { authorization: 'Bearer secret' }), res1)
464
  expect(res1.writeHead).toHaveBeenCalledWith(200, expect.anything())
465
  const firstCalls = verifySpy.mock.calls.length
466
 
467
  const res2 = mkRes()
468
+ await requestHandler(mkReq('/api/admin/settings', 'GET', { authorization: 'Bearer secret' }), res2)
469
  expect(res2.writeHead).toHaveBeenCalledWith(200, expect.anything())
470
  expect(verifySpy.mock.calls.length).toBe(firstCalls)
471
 
472
  const res3 = mkRes()
473
+ await requestHandler(mkReq('/api/admin/settings', 'GET', { authorization: 'Bearer wrong' }), res3)
474
  expect(res3.writeHead).toHaveBeenCalledWith(401, expect.anything())
475
  expect(verifySpy.mock.calls.length).toBe(firstCalls + 1)
476
 
477
  const res4 = mkRes()
478
+ await requestHandler(mkReq('/api/admin/settings', 'GET', { authorization: 'Bearer wrong' }), res4)
479
  expect(res4.writeHead).toHaveBeenCalledWith(401, expect.anything())
480
  expect(verifySpy.mock.calls.length).toBe(firstCalls + 1)
481
  } finally {
 
499
  arModule.verify = vi.fn().mockResolvedValue(true)
500
  arModule.hash = vi.fn().mockResolvedValue('$argon2id$mockhash')
501
 
502
+ const mockDbThrows = mkDb({
 
503
  getWrappedDb: () => ({
504
  prepare: (sql) => {
505
  if (sql.includes('SELECT value FROM settings')) return { get: () => ({ value: '$argon2id$mockhash' }) }
 
508
  exec: () => {},
509
  }),
510
  listAll: () => { throw new Error('unexpected db error') },
 
 
511
  TABLES: ['users', 'posts', 'comments', 'albums', 'photos', 'todos', 'settings'],
512
+ })
513
 
514
  const resolvedDb = _require.resolve('../../src/db/index.js')
515
  const resolvedRedis = _require.resolve('../../src/redis/index.js')
516
  const resolvedSeed = _require.resolve('../../src/db/seed.js')
517
+ const { mockRedisClass } = mkRedis()
518
 
519
  const origDbCache = _require.cache[resolvedDb]
520
  const origRedisCache = _require.cache[resolvedRedis]
 
527
  clearCjs('../../src/server/index.js', '../../src/middleware/rate-limiter.js')
528
  vi.resetModules()
529
  const { requestHandler } = await import('../../src/server/index.js')
 
 
 
 
 
530
 
531
  const res = mkRes()
532
+ await requestHandler(mkReq('/api/admin/settings', 'GET', { authorization: 'Bearer secret' }), res)
533
  expect(res.writeHead).toHaveBeenCalledWith(500, expect.anything())
534
  } finally {
535
  arModule.verify = origArVerify
 
562
  },
563
  exec: vi.fn(),
564
  }
565
+ const mockDbSeedFail = mkDb({
 
566
  getWrappedDb: () => wrappedDb,
567
  listAll: () => [{ key: 'foo', value: 'bar' }],
 
 
568
  TABLES: ['users', 'posts', 'comments', 'albums', 'photos', 'todos', 'settings'],
569
+ })
570
 
571
  const resolvedDb = _require.resolve('../../src/db/index.js')
572
  const resolvedRedis = _require.resolve('../../src/redis/index.js')
573
  const resolvedSeed = _require.resolve('../../src/db/seed.js')
574
+ const { mockRedisClass } = mkRedis()
575
 
576
  const origDbCache = _require.cache[resolvedDb]
577
  const origRedisCache = _require.cache[resolvedRedis]
 
584
  clearCjs('../../src/server/index.js', '../../src/middleware/rate-limiter.js')
585
  vi.resetModules()
586
  const { requestHandler } = await import('../../src/server/index.js')
 
 
 
 
 
 
587
 
588
  const res = mkRes()
589
+ await requestHandler(mkReq('/api/admin/reset-database', 'POST', { authorization: 'Bearer secret', 'content-type': 'application/json' }, JSON.stringify({ confirm: true })), res)
590
  expect(res.writeHead).toHaveBeenCalledWith(500, expect.anything())
591
  expect(mockDbSeedFail.getWrappedDb().exec).toHaveBeenCalledWith('ROLLBACK')
592
  } finally {
 
616
  { key: 'ADMIN_KEY', value: '$argon2id$v=19$m=65536,t=3,p=4$mockedhash', description: 'Admin key', updated_at: '2025-01-01' },
617
  ]
618
 
619
+ const mockDb = mkDb({
 
620
  getWrappedDb: () => ({
621
  prepare: (sql) => {
622
  if (sql.includes('SELECT value FROM settings')) return { get: () => settingsTable[0] }
 
625
  exec: () => {},
626
  }),
627
  listAll: () => settingsTable,
 
 
628
  TABLES: ['users', 'posts', 'comments', 'albums', 'photos', 'todos', 'settings'],
629
+ })
630
 
631
  const resolvedDb = _require.resolve('../../src/db/index.js')
632
  const resolvedRedis = _require.resolve('../../src/redis/index.js')
633
+ const { mockRedisClass } = mkRedis()
634
 
635
  const origDbCache = _require.cache[resolvedDb]
636
  const origRedisCache = _require.cache[resolvedRedis]
 
641
  clearCjs('../../src/server/index.js', '../../src/middleware/rate-limiter.js')
642
  vi.resetModules()
643
  const { requestHandler } = await import('../../src/server/index.js')
 
 
 
 
 
644
 
645
  const res1 = mkRes()
646
+ await requestHandler(mkReq('/api/admin/settings', 'GET', { authorization: 'Bearer throw' }), res1)
647
  expect(res1.writeHead).toHaveBeenCalledWith(401, expect.anything())
648
  expect(verifySpy).toHaveBeenCalledTimes(1)
649
 
650
  const res2 = mkRes()
651
+ await requestHandler(mkReq('/api/admin/settings', 'GET', { authorization: 'Bearer throw' }), res2)
652
  expect(res2.writeHead).toHaveBeenCalledWith(401, expect.anything())
653
  expect(verifySpy).toHaveBeenCalledTimes(1)
654
  } finally {