File size: 26,956 Bytes
b54637e
 
 
201d943
 
608f92f
b54637e
 
8918e94
b54637e
 
 
05734d8
 
 
 
 
b54637e
 
8918e94
b54637e
 
 
 
 
8918e94
 
 
 
b54637e
 
8918e94
 
b54637e
608f92f
 
b54637e
8918e94
 
 
 
608f92f
 
 
 
8918e94
 
608f92f
 
8918e94
608f92f
 
8918e94
 
 
 
 
 
 
3190623
 
 
 
 
 
 
 
 
 
 
 
 
 
8918e94
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
608f92f
 
8918e94
608f92f
 
 
beacc25
 
 
 
 
 
 
 
 
 
 
 
 
 
608f92f
 
 
 
 
 
 
 
 
 
 
8918e94
b54637e
608f92f
 
b54637e
 
 
 
608f92f
b54637e
 
 
 
 
 
beacc25
 
 
 
864ffc8
201d943
 
 
 
 
 
 
 
 
 
 
 
b54637e
 
 
608f92f
b54637e
 
 
 
 
 
 
f1bb81c
608f92f
 
b54637e
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
05734d8
b54637e
05734d8
 
 
 
 
 
 
 
 
 
 
 
b54637e
 
 
 
 
 
 
 
beacc25
 
 
 
 
 
 
 
b54637e
 
 
 
 
 
 
 
 
 
05734d8
 
 
b54637e
beacc25
b54637e
 
 
 
 
 
beacc25
b54637e
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
608f92f
beacc25
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
97ce675
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
608f92f
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
05734d8
 
608f92f
05734d8
 
 
 
 
608f92f
 
 
 
 
 
05734d8
608f92f
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
05734d8
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
from flask import Blueprint, request, jsonify
from flask_jwt_extended import create_access_token, get_jwt_identity, jwt_required
from werkzeug.security import check_password_hash
from datetime import datetime, timedelta, timezone

from models import User, ApiKey
from app import db
from logging_utils import log_event
import base64

login_bp = Blueprint('login', __name__)

def is_admin_user(user_id):
    """Check if user is admin (for now, check if username is 'admin')"""
    user = User.query.get(user_id)
    return user and user.username == 'admin' and user.is_active

@login_bp.route('/login', methods=['POST'])
def login():
    """User login endpoint - supports multiple authentication methods"""
    try:
        data = request.get_json()
        if not data:
            return jsonify({'error': 'JSON data required'}), 400
        
        # Extract different authentication methods
        api_token = data.get('api_token')
        client_id = data.get('client_id')
        client_secret = data.get('client_secret')
        username = data.get('username')
        password = data.get('password')
        # Legacy support
        api_key = data.get('api_key')
        
        user = None
        auth_method = None
        
        if api_token or api_key:
            # Method 1: API Token authentication
            token = api_token or api_key
            api_key_obj = ApiKey.query.filter_by(key=token).first()
            
            if not api_key_obj or not api_key_obj.is_valid():
                log_event(
                    severity=4,
                    message=f"Failed login attempt with invalid API token",
                    event_type="login_failed_api_token",
                    source_ip=request.remote_addr
                )
                return jsonify({'error': 'Invalid or expired API token'}), 401
            
            user = User.query.get(api_key_obj.user_id)
            auth_method = "api_token"
            
        elif client_id and client_secret:
            # Method 2: Client ID/Secret authentication (base64 decoded from API key)
            import base64
            try:
                # Reconstruct base64 credentials
                # Try to decode client_secret as base64 first
                try:
                    decoded_secret = base64.b64decode(client_secret).decode('utf-8')
                    parts = decoded_secret.split(':')
                    if parts[0] == client_id:
                        token = client_secret
                    else:
                        # Fall back to original method
                        credentials = f"{client_id}:{client_secret}"
                        token = base64.b64encode(credentials.encode()).decode()
                except Exception:
                    # If decoding fails, use original method
                    credentials = f"{client_id}:{client_secret}"
                    token = base64.b64encode(credentials.encode()).decode()
                
                api_key_obj = ApiKey.query.filter_by(key=token).first()
                
                if not api_key_obj or not api_key_obj.is_valid():
                    log_event(
                        severity=4,
                        message=f"Failed login attempt with invalid client credentials for: {client_id}",
                        event_type="login_failed_client_creds",
                        source_ip=request.remote_addr
                    )
                    return jsonify({'error': 'Invalid client credentials'}), 401
                
                user = User.query.get(api_key_obj.user_id)
                auth_method = "client_credentials"
                
            except Exception as e:
                log_event(
                    severity=4,
                    message=f"Failed to process client credentials for: {client_id}",
                    event_type="login_failed_client_creds_format",
                    source_ip=request.remote_addr
                )
                return jsonify({'error': 'Invalid client credentials format'}), 401
            
        elif username and password:
            # Method 3: Username/password authentication  
            user = User.query.filter_by(username=username).first()
            
            if not user or not user.check_password(password):
                # Record the failed login if user exists
                if user:
                    account_deactivated = user.record_login_failure()
                    db.session.commit()
                    
                    if account_deactivated:
                        log_event(
                            severity=3,
                            message=f"Account deactivated after 50 failed login attempts: {username}",
                            event_type="account_deactivated_login_failures",
                            user_id=user.id,
                            source_ip=request.remote_addr
                        )
                
                log_event(
                    severity=4,
                    message=f"Failed login attempt for username: {username}",
                    event_type="login_failed",
                    source_ip=request.remote_addr
                )
                return jsonify({'error': 'Invalid credentials'}), 401
            
            auth_method = "password"
            
        else:
            return jsonify({'error': 'Authentication required: provide api_token, client_id/client_secret, or username/password'}), 400
        
        if not user:
            return jsonify({'error': 'User not found'}), 404
        
        if not user.is_active:
            log_event(
                severity=4,
                message=f"Login attempt for inactive user: {user.username}",
                event_type="login_inactive",
                user_id=user.id,
                source_ip=request.remote_addr
            )
            return jsonify({'error': 'Account is inactive'}), 401
        
        # Record successful login
        user.record_login_success()
        db.session.commit()
        
        # Create access token (convert ID to string for JWT compliance)
        expires_delta = timedelta(hours=1)
        expiration_time = datetime.now(timezone.utc) + expires_delta
        expiration_ts = int(expiration_time.timestamp())
        access_token = create_access_token(
            identity=str(user.id),
            additional_claims={
                "client_id": user.username,
                "name": user.username,
                "expiration": expiration_ts
            },
            expires_delta=expires_delta
        )
        
        log_event(
            severity=6,
            message=f"Successful login for user: {user.username} via {auth_method}",
            event_type="login_success",
            user_id=user.id,
            source_ip=request.remote_addr
        )
        
        return jsonify({
            'access_token': access_token,
            'token': access_token,  # Legacy support
            'user': user.to_dict(),
            'auth_method': auth_method
        })
        
    except Exception as e:
        log_event(
            severity=3,
            message=f"Login error: {str(e)}",
            event_type="login_error",
            source_ip=request.remote_addr
        )
        return jsonify({'error': 'Login failed'}), 500

@login_bp.route('/logout', methods=['POST'])
@jwt_required()
def logout():
    """User logout endpoint"""
    try:
        user_id = get_jwt_identity()
        user = User.query.get(user_id)
        
        log_event(
            severity=6,
            message=f"User logout: {user.username if user else 'unknown'}",
            event_type="logout",
            user_id=user_id,
            source_ip=request.remote_addr
        )
        
        return jsonify({'message': 'Logged out successfully'})
        
    except Exception as e:
        log_event(
            severity=3,
            message=f"Logout error: {str(e)}",
            event_type="logout_error",
            source_ip=request.remote_addr
        )
        return jsonify({'error': 'Logout failed'}), 500

@login_bp.route('/profile', methods=['GET'])
@jwt_required()
def get_profile():
    """Get current user profile"""
    try:
        user_id = get_jwt_identity()
        user = User.query.get(user_id)
        
        if not user:
            return jsonify({'error': 'User not found'}), 404
        
        return jsonify(user.to_dict())
        
    except Exception as e:
        log_event(
            severity=3,
            message=f"Profile error: {str(e)}",
            event_type="profile_error",
            user_id=get_jwt_identity(),
            source_ip=request.remote_addr
        )
        return jsonify({'error': 'Failed to get profile'}), 500

@login_bp.route('/users', methods=['POST'])
@jwt_required()
def create_user():
    """Create new user (admin only)"""
    try:
        # Check admin privileges
        current_user_id = int(get_jwt_identity())
        if not is_admin_user(current_user_id):
            log_event(
                severity=4,
                message=f"Non-admin user {current_user_id} attempted to create user",
                event_type="unauthorized_user_creation",
                user_id=current_user_id,
                source_ip=request.remote_addr
            )
            return jsonify({'error': 'Admin privileges required'}), 403
        
        data = request.get_json()
        if not data:
            return jsonify({'error': 'JSON data required'}), 400
        
        username = data.get('username')
        email = data.get('email')
        password = data.get('password')
        
        # If no password provided, use default and set flag to force change
        password_change_required = False
        if not password:
            password = "bad@pass"
            password_change_required = True
        
        if not username or not email:
            return jsonify({'error': 'Username and email required'}), 400
        
        # Check if user already exists
        existing_user = User.query.filter(
            (User.username == username) | (User.email == email)
        ).first()
        
        if existing_user:
            return jsonify({'error': 'User already exists'}), 409
        
        # Create new user
        user = User()
        user.username = username
        user.email = email
        user.set_password(password)
        user.password_change_required = password_change_required
        
        db.session.add(user)
        db.session.commit()
        
        log_event(
            severity=6,
            message=f"New user created: {username}, password change required: {password_change_required}",
            event_type="user_created",
            user_id=get_jwt_identity(),
            source_ip=request.remote_addr
        )
        
        return jsonify(user.to_dict()), 201
        
    except Exception as e:
        log_event(
            severity=3,
            message=f"User creation error: {str(e)}",
            event_type="user_creation_error",
            user_id=get_jwt_identity(),
            source_ip=request.remote_addr
        )
        return jsonify({'error': 'Failed to create user'}), 500

@login_bp.route('/users/bulk', methods=['POST'])
@jwt_required()
def create_users_bulk():
    """Create multiple users in bulk (admin only)"""
    try:
        # Check admin privileges
        current_user_id = int(get_jwt_identity())
        if not is_admin_user(current_user_id):
            log_event(
                severity=4,
                message=f"Non-admin user {current_user_id} attempted to create users in bulk",
                event_type="unauthorized_bulk_user_creation",
                user_id=current_user_id,
                source_ip=request.remote_addr
            )
            return jsonify({'error': 'Admin privileges required'}), 403
        
        data = request.get_json()
        if not data or not isinstance(data, list):
            return jsonify({'error': 'JSON array of users required'}), 400
        
        results = {
            'success': [],
            'failed': []
        }
        
        for user_data in data:
            try:
                if not isinstance(user_data, dict):
                    results['failed'].append({
                        'data': user_data,
                        'error': 'Invalid user data format'
                    })
                    continue
                
                username = user_data.get('username')
                email = user_data.get('email')
                password = user_data.get('password')
                
                # If no username or email, skip this entry
                if not username or not email:
                    results['failed'].append({
                        'data': user_data,
                        'error': 'Username and email required'
                    })
                    continue
                
                # Check if user already exists
                existing_user = User.query.filter(
                    (User.username == username) | (User.email == email)
                ).first()
                
                if existing_user:
                    results['failed'].append({
                        'data': user_data,
                        'error': 'User already exists'
                    })
                    continue
                
                # If no password provided, use default and set flag to force change
                password_change_required = False
                if not password:
                    password = "badpaswword@here"
                    password_change_required = True
                
                # Create new user
                user = User()
                user.username = username
                user.email = email
                user.set_password(password)
                user.password_change_required = password_change_required
                
                db.session.add(user)
                db.session.flush()  # Get the ID without committing
                
                results['success'].append({
                    'id': user.id,
                    'username': user.username,
                    'email': user.email,
                    'password_change_required': user.password_change_required
                })
                
            except Exception as e:
                results['failed'].append({
                    'data': user_data,
                    'error': str(e)
                })
        
        # Commit all successful changes
        if results['success']:
            db.session.commit()
            
            log_event(
                severity=6,
                message=f"Bulk user creation: {len(results['success'])} users created, {len(results['failed'])} failed",
                event_type="users_created_bulk",
                user_id=current_user_id,
                source_ip=request.remote_addr
            )
        else:
            db.session.rollback()
        
        return jsonify(results), 201 if results['success'] else 400
        
    except Exception as e:
        db.session.rollback()
        log_event(
            severity=3,
            message=f"Bulk user creation error: {str(e)}",
            event_type="bulk_user_creation_error",
            user_id=int(get_jwt_identity()),
            source_ip=request.remote_addr
        )
        return jsonify({'error': 'Failed to create users', 'details': str(e)}), 500

@login_bp.route('/users/bulk', methods=['GET'])
@jwt_required()
def get_users_bulk():
    """Get all users in a format suitable for bulk creation (admin only)"""
    try:
        # Check admin privileges
        current_user_id = int(get_jwt_identity())
        if not is_admin_user(current_user_id):
            log_event(
                severity=4,
                message=f"Non-admin user {current_user_id} attempted to access bulk users list",
                event_type="unauthorized_bulk_users_access",
                user_id=current_user_id,
                source_ip=request.remote_addr
            )
            return jsonify({'error': 'Admin privileges required'}), 403
        
        # Get all users, including inactive ones if requested
        include_inactive = request.args.get('include_inactive', 'false').lower() == 'true'
        
        query = User.query
        if not include_inactive:
            query = query.filter_by(is_active=True)
            
        users = query.order_by(User.username).all()
        
        # Format users for CSV-compatible output
        users_data = []
        for user in users:
            users_data.append({
                'username': user.username,
                'email': user.email,
                'password': '',  # Never include passwords
                'require_password_change': user.password_change_required,
                'is_active': user.is_active,
                'is_admin': user.is_admin or user.username == 'admin'
            })
        
        log_event(
            severity=6,
            message=f"Admin {current_user_id} retrieved bulk users list ({len(users)} users)",
            event_type="bulk_users_retrieved",
            user_id=current_user_id,
            source_ip=request.remote_addr
        )
        
        return jsonify({'users': users_data})
        
    except Exception as e:
        log_event(
            severity=3,
            message=f"Bulk users retrieval error: {str(e)}",
            event_type="bulk_users_retrieval_error",
            user_id=int(get_jwt_identity()),
            source_ip=request.remote_addr
        )
        return jsonify({'error': 'Failed to retrieve users', 'details': str(e)}), 500

@login_bp.route('/generate-api-key', methods=['POST'])
def generate_api_key():
    """Generate API key for user (admin only)"""
    try:
        data = request.get_json()
        if not data:
            return jsonify({'error': 'JSON data required'}), 400
        
        # Authenticate the admin making the request
        admin_username = data.get('username')
        admin_password = data.get('password')
        target_user_id = data.get('target_user_id')
        key_name = data.get('name')
        expiration_days = data.get('expiration_days', 365)  # Default 1 year
        
        if not admin_username or not admin_password:
            return jsonify({'error': 'Admin username and password required'}), 400
        
        if not target_user_id:
            return jsonify({'error': 'target_user_id required'}), 400
        
        # Validate admin credentials
        admin_user = User.query.filter_by(username=admin_username).first()
        if not admin_user or not admin_user.check_password(admin_password):
            log_event(
                severity=4,
                message=f"Failed API key generation attempt by: {admin_username}",
                event_type="api_key_gen_failed",
                source_ip=request.remote_addr
            )
            return jsonify({'error': 'Invalid admin credentials'}), 401
        
        if not admin_user.is_active:
            return jsonify({'error': 'Admin account is inactive'}), 401
        
        # For now, assume admin user has username 'admin' (can be enhanced with roles later)
        if admin_user.username != 'admin':
            log_event(
                severity=4,
                message=f"Non-admin user {admin_username} attempted to generate API key",
                event_type="unauthorized_api_key_gen",
                user_id=admin_user.id,
                source_ip=request.remote_addr
            )
            return jsonify({'error': 'Admin privileges required'}), 403
        
        # Validate target user exists
        target_user = User.query.get(target_user_id)
        if not target_user:
            return jsonify({'error': 'Target user not found'}), 404
        
        # Handle no expiration case and ensure type safety
        expiration = expiration_days
        if expiration_days == 0 or expiration_days is None:
            expiration = None
        elif not isinstance(expiration_days, int):
            expiration = 365  # Default fallback
        else:
            expiration = expiration_days
        
        # Create API key
        api_key = ApiKey.create_key(
            user_id=target_user_id,
            created_by=admin_user.id,
            name=key_name,
            expiration_days=expiration
        )
        
        db.session.add(api_key)
        db.session.commit()
        
        log_event(
            severity=6,
            message=f"API key generated for user {target_user.username} by admin {admin_username}",
            event_type="api_key_generated",
            user_id=admin_user.id,
            source_ip=request.remote_addr
        )
        
        return jsonify({
            'api_key': api_key.key,
            'name': api_key.name,
            'user_id': api_key.user_id,
            'expiration_date': api_key.expiration_date.isoformat() if api_key.expiration_date else None,
            'expires_in_days': expiration_days
        })
        
    except Exception as e:
        log_event(
            severity=3,
            message=f"API key generation error: {str(e)}",
            event_type="api_key_gen_error",
            source_ip=request.remote_addr
        )
        return jsonify({'error': 'Failed to generate API key'}), 500

@login_bp.route('/api-key', methods=['POST'])
@jwt_required()
def create_api_key():
    """Create API key with JWT authentication - users can create for themselves, admin can create for anyone"""
    try:
        data = request.get_json()
        if not data:
            return jsonify({'error': 'JSON data required'}), 400
        
        current_user_id = int(get_jwt_identity())
        target_user_id = data.get('user_id', current_user_id)  # Default to self
        key_name = data.get('name')
        expiration_days = data.get('expiration_days', 365)  # Default 1 year
        
        # Check permissions: users can only create keys for themselves, admin can create for anyone
        if target_user_id != current_user_id and not is_admin_user(current_user_id):
            log_event(
                severity=4,
                message=f"User {current_user_id} attempted to create API key for user {target_user_id}",
                event_type="unauthorized_api_key_creation",
                user_id=current_user_id,
                source_ip=request.remote_addr
            )
            return jsonify({'error': 'Can only create API keys for yourself unless you are admin'}), 403
        
        # Validate target user exists
        target_user = User.query.get(target_user_id)
        if not target_user:
            return jsonify({'error': 'Target user not found'}), 404
        
        # Handle no expiration case and ensure type safety
        expiration = expiration_days
        if expiration_days == 0 or expiration_days is None:
            expiration = None
        elif not isinstance(expiration_days, int):
            expiration = 365  # Default fallback
        else:
            expiration = expiration_days
        
        # Create API key
        api_key = ApiKey.create_key(
            user_id=target_user_id,
            created_by=current_user_id,
            name=key_name,
            expiration_days=expiration
        )
        
        db.session.add(api_key)
        db.session.commit()
        
        log_event(
            severity=6,
            message=f"API key created for user {target_user.username} by user {current_user_id}",
            event_type="api_key_created",
            user_id=current_user_id,
            source_ip=request.remote_addr
        )
        
        return jsonify({
            'api_key': api_key.key,
            'name': api_key.name,
            'user_id': api_key.user_id,
            'expiration_date': api_key.expiration_date.isoformat() if api_key.expiration_date else None,
            'expires_in_days': expiration
        }), 201
        
    except Exception as e:
        log_event(
            severity=3,
            message=f"API key creation error: {str(e)}",
            event_type="api_key_creation_error",
            user_id=int(get_jwt_identity()),
            source_ip=request.remote_addr
        )
        return jsonify({'error': 'Failed to create API key'}), 500

@login_bp.route('/users', methods=['GET'])
@jwt_required()
def list_users():
    """List users (admin only)"""
    try:
        # Check admin privileges
        current_user_id = int(get_jwt_identity())
        if not is_admin_user(current_user_id):
            return jsonify({'error': 'Admin privileges required'}), 403
        
        users = User.query.filter_by(is_active=True).all()
        users_data = [user.to_dict() for user in users]
        
        log_event(
            severity=6,
            message=f"Admin {current_user_id} listed {len(users)} users",
            event_type="users_listed",
            user_id=current_user_id,
            source_ip=request.remote_addr
        )
        
        return jsonify({'users': users_data})
        
    except Exception as e:
        log_event(
            severity=3,
            message=f"User listing error: {str(e)}",
            event_type="user_listing_error",
            user_id=int(get_jwt_identity()),
            source_ip=request.remote_addr
        )
        return jsonify({'error': 'Failed to list users'}), 500

@login_bp.route('/api-keys', methods=['GET'])
@jwt_required()
def list_api_keys():
    """List API keys - users see their own keys, admin sees all keys"""
    try:
        current_user_id = int(get_jwt_identity())
        
        if is_admin_user(current_user_id):
            # Admin can see all API keys
            api_keys = ApiKey.query.filter_by(is_active=True).all()
            message = f"Admin {current_user_id} listed all API keys"
        else:
            # Regular users can only see their own API keys
            api_keys = ApiKey.query.filter_by(user_id=current_user_id, is_active=True).all()
            message = f"User {current_user_id} listed their API keys"
        
        keys_data = [key.to_dict() for key in api_keys]
        
        log_event(
            severity=6,
            message=message,
            event_type="api_keys_listed",
            user_id=current_user_id,
            source_ip=request.remote_addr
        )
        
        return jsonify({'api_keys': keys_data})
        
    except Exception as e:
        log_event(
            severity=3,
            message=f"API key listing error: {str(e)}",
            event_type="api_key_listing_error",
            user_id=int(get_jwt_identity()),
            source_ip=request.remote_addr
        )
        return jsonify({'error': 'Failed to list API keys'}), 500