Spaces:
Sleeping
Sleeping
File size: 5,321 Bytes
55626ac | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 | import json
import tempfile
from pathlib import Path
from unittest.mock import patch
import pytest
from fastapi import FastAPI
from fastapi.exceptions import RequestValidationError
from fastapi.testclient import TestClient
from pydantic import BaseModel, field_validator
from app import asgi
from app.config import config
@pytest.mark.parametrize('number', ['NaN', 'Infinity', '-Infinity'])
@pytest.mark.parametrize('path,field', [('/api/v1/videos', 'n_threads'), ('/api/v1/terms', 'amount')])
def test_rejected_nonfinite_json_numbers_return_validation_response(number, path, field):
with (
patch.dict(config.app, {'api_key': ''}),
patch('app.controllers.v1.video.task_manager.add_task') as schedule,
patch('app.controllers.v1.llm.llm.generate_terms') as generate,
TestClient(asgi.get_application(), raise_server_exceptions=False) as client,
):
response = client.post(
path,
content='{"video_subject":"test","' + field + '":' + number + '}',
headers={'content-type': 'application/json'},
)
assert response.status_code == 400
body = response.json()
assert body['status'] == 400
assert body['data'][0]['loc'] == ['body', field]
json.dumps(body, allow_nan=False)
schedule.assert_not_called()
generate.assert_not_called()
def test_validator_exception_context_is_serializable():
class Parameters(BaseModel):
value: str
@field_validator('value')
@classmethod
def reject_value(cls, value):
raise ValueError('invalid custom value')
instance = FastAPI()
instance.add_exception_handler(RequestValidationError, asgi.validation_exception_handler)
@instance.post('/validate')
def validate(params: Parameters):
return params.model_dump()
response = TestClient(instance, raise_server_exceptions=False).post('/validate', json={'value': 'x'})
assert response.status_code == 400
assert response.json()['data'][0]['ctx']['error'] == 'invalid custom value'
def test_normal_error_details_remain_available():
instance = asgi.get_application()
with patch.dict(config.app, {'api_key': ''}):
response = TestClient(instance).post('/api/v1/terms', json={'amount': 0})
assert response.status_code == 400
error = response.json()['data'][0]
assert error['type'] == 'greater_than_equal'
assert error['input'] == 0
assert error['ctx'] == {'ge': 1}
def test_unsafe_font_name_returns_403_not_400():
"""create_task pre-checks font_name via the file-serving wrapper.
Path-escaping attempts must be rejected with the same 403 that the
artifact endpoints already use, instead of the generic 400 returned
for value errors such as invalid subtitle colors.
"""
payload = {
'video_subject': 'unsafe font test',
'video_script': 'demo',
'subtitle_enabled': True,
'font_name': '../etc/passwd',
}
with (
patch.dict(config.app, {'api_key': ''}),
patch('app.controllers.v1.video.task_manager.add_task') as schedule,
TestClient(asgi.get_application(), raise_server_exceptions=False) as client,
):
response = client.post('/api/v1/videos', json=payload)
assert response.status_code == 403, response.text
schedule.assert_not_called()
def test_unknown_font_name_returns_404():
"""A font_name that is well-formed but missing on disk is a 404, not a 400."""
payload = {
'video_subject': 'unknown font test',
'video_script': 'demo',
'subtitle_enabled': True,
'font_name': 'this-font-does-not-exist.ttf',
}
with (
patch.dict(config.app, {'api_key': ''}),
patch('app.controllers.v1.video.task_manager.add_task') as schedule,
TestClient(asgi.get_application(), raise_server_exceptions=False) as client,
):
response = client.post('/api/v1/videos', json=payload)
assert response.status_code == 404, response.text
schedule.assert_not_called()
def test_valid_font_name_still_reaches_scheduler():
"""A safe font_name must still pass through to the task scheduler.
The fixture writes a real file into a temp font directory and points
``utils.font_dir`` at it, so the pre-check passes because the font
actually exists on disk — not because the check was bypassed or the
repo's bundled fonts happen to be present.
"""
payload = {
'video_subject': 'safe font test',
'video_script': 'demo',
'subtitle_enabled': True,
'font_name': 'custom.ttf',
}
with tempfile.TemporaryDirectory() as temp_dir:
font_dir = Path(temp_dir, 'fonts')
font_dir.mkdir()
(font_dir / 'custom.ttf').write_bytes(b'font file')
with (
patch.dict(config.app, {'api_key': ''}),
patch('app.controllers.v1.video.utils.font_dir', return_value=str(font_dir)),
patch('app.controllers.v1.video.task_manager.add_task') as schedule,
TestClient(asgi.get_application(), raise_server_exceptions=False) as client,
):
response = client.post('/api/v1/videos', json=payload)
assert response.status_code == 200, response.text
assert response.json()['status'] == 200
schedule.assert_called_once()
|