fsanyoto commited on
Commit
344f467
Β·
verified Β·
1 Parent(s): ce0d7d8

Deploy AIOS web (React glide grid + FastAPI slice)

Browse files
RELEASES.json CHANGED
@@ -1,5 +1,5 @@
1
  {
2
- "current": "872f5c5",
3
  "releases": [
4
  {
5
  "version": "v14",
 
1
  {
2
+ "current": "734cf1b",
3
  "releases": [
4
  {
5
  "version": "v14",
VERSION CHANGED
@@ -1 +1 @@
1
- 872f5c5
 
1
+ 734cf1b
web/src/automation/AutomationBuilder.tsx CHANGED
@@ -398,6 +398,36 @@ export default function AutomationBuilder({
398
  * the next reload, and a control that undoes itself is worse than no control.
399
  */
400
  const chosen = !!trigger || !!automation.schedule?.enabled;
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
401
  const configured = !trigger || trigger.configured !== false;
402
 
403
  /** Write one key of the trigger, keeping the rest β€” the engine merges against `previous`. */
@@ -1411,6 +1441,21 @@ function TriggerProps({
1411
  const connected = !!(provider && oauth?.[provider]?.connected);
1412
  const startUrl = picked?.connect?.startUrl || "";
1413
  const needsTable = !!trigger && "table" in trigger;
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1414
  const last = automation.runs?.[0];
1415
  /** ITEM 22 / D-70 / R12 β€” the shared Run guard (see `runBlock`). */
1416
  const runState = runBlock(automation);
@@ -1495,7 +1540,11 @@ function TriggerProps({
1495
  forbids β€” a heading over an empty region says "there should be something here", which is a
1496
  different and false statement. This is `null`, not an empty fragment.
1497
  */}
1498
- {!chosen ? null : (
 
 
 
 
1499
  <>
1500
  <h3>Configuration</h3>
1501
  {needsTable ? (
@@ -1544,7 +1593,7 @@ function TriggerProps({
1544
  two retired kinds through their own Properties panels. Widening this would put two pickers
1545
  on one key and let them disagree, which is the exact defect R2 was written to end.
1546
  */}
1547
- {!needsTable && automation.kind === "plain" ? (
1548
  <div className="auto-field">
1549
  <label htmlFor="autox-cfgtable">
1550
  <span className="autox-req">*</span> Database
 
398
  * the next reload, and a control that undoes itself is worse than no control.
399
  */
400
  const chosen = !!trigger || !!automation.schedule?.enabled;
401
+ /**
402
+ * ⭐⭐ 2026-08-07 (owner report, the SECOND time on this feature) β€” *"I still can't do
403
+ * Enrichment, when the Trigger is Manual, it says that I need to bound it to a database, how?"*
404
+ *
405
+ * β›” THE DATABASE PICKER EXISTED AND WAS UNREACHABLE FOR THE ONE TRIGGER THAT NEEDS IT MOST,
406
+ * and the two decisions that combined to hide it were each locally right:
407
+ * 1. `clean_trigger` STORES NOTHING for `manual` and `schedule` (`:8389`) β€” "storing a no-op
408
+ * trigger would be a second copy of that fact". So a manual automation holds `trigger:
409
+ * null` forever, by design.
410
+ * 2. `chosen` is therefore FALSE for it (the note above says so explicitly), and W25/R14 hides
411
+ * the whole Configuration section until a trigger is `chosen`.
412
+ * β‡’ The picker `caee549` added for exactly this case sits INSIDE that section, so picking
413
+ * Manual could never reveal it. `run_plain` then refused with *"pick one on the trigger, or in
414
+ * Properties"* β€” a sentence naming two doors while rendering neither. MEASURED in the live
415
+ * nurilab store: `auto_2` "Enrichment test", `kind:'plain'`, `trigger:None`,
416
+ * `config.targetTable:''`, one `enrich_instagram` action, unrunnable.
417
+ *
418
+ * ⚠ AND THE SCREEN DISAGREED WITH THE STORE, which is why the owner reasonably believed they
419
+ * had picked something: `triggerKey` DERIVES `"manual"` when nothing is stored, so the panel
420
+ * displays "Manual" over a definition that holds no trigger at all.
421
+ *
422
+ * β›” THE FIX IS NOT TO START STORING A MANUAL TRIGGER. The note above already argued that out
423
+ * and it is still right β€” a control whose selection stores nothing bounces back on reload. What
424
+ * was wrong is treating "no trigger stored" as "nothing to configure": a `plain` automation
425
+ * whose trigger carries no table of its own ALWAYS has one thing to configure, the database its
426
+ * steps walk, and that is true in exactly the state where `chosen` is false. So Configuration
427
+ * opens for that too β€” the trigger-specific blocks inside are each keyed off `triggerKey` and
428
+ * stay hidden on their own. That widening lives in the Properties panel beside the picker it
429
+ * reveals (`needsOwnTable`), not here: `chosen` still means exactly what it says.
430
+ */
431
  const configured = !trigger || trigger.configured !== false;
432
 
433
  /** Write one key of the trigger, keeping the rest β€” the engine merges against `previous`. */
 
1441
  const connected = !!(provider && oauth?.[provider]?.connected);
1442
  const startUrl = picked?.connect?.startUrl || "";
1443
  const needsTable = !!trigger && "table" in trigger;
1444
+ /**
1445
+ * ⭐⭐ 2026-08-07 β€” DOES THIS AUTOMATION HAVE TO NAME ITS OWN DATABASE?
1446
+ *
1447
+ * True for a `plain` automation whose trigger carries no table β€” which INCLUDES the state where
1448
+ * no trigger is stored at all, and that inclusion is the whole fix. `clean_trigger` stores
1449
+ * nothing for `manual`/`schedule` by design, so those automations hold `trigger: null`, `chosen`
1450
+ * is false, and W25/R14's "Configuration does not render until a trigger is picked" hid the
1451
+ * Database picker below from the exact automations that cannot get a database any other way.
1452
+ * The owner hit it twice: *"when the Trigger is Manual, it says that I need to bound it to a
1453
+ * database, how?"* β€” and the honest answer was that there was no how.
1454
+ *
1455
+ * ⚠ It is the SAME condition the picker itself renders on, named once and used twice, so the
1456
+ * section cannot open without the control or the control appear without its section.
1457
+ */
1458
+ const needsOwnTable = automation.kind === "plain" && !needsTable;
1459
  const last = automation.runs?.[0];
1460
  /** ITEM 22 / D-70 / R12 β€” the shared Run guard (see `runBlock`). */
1461
  const runState = runBlock(automation);
 
1540
  forbids β€” a heading over an empty region says "there should be something here", which is a
1541
  different and false statement. This is `null`, not an empty fragment.
1542
  */}
1543
+ {/* ⭐ 2026-08-07 β€” `|| needsOwnTable`: R14's rule was "do not render Configuration before a
1544
+ trigger is picked", and it is intact for every trigger that stores one. What it must not
1545
+ also mean is "a manual automation has nothing to configure" β€” it has exactly one thing,
1546
+ the database its steps walk, and no other surface can name it. See `needsOwnTable`. */}
1547
+ {!chosen && !needsOwnTable ? null : (
1548
  <>
1549
  <h3>Configuration</h3>
1550
  {needsTable ? (
 
1593
  two retired kinds through their own Properties panels. Widening this would put two pickers
1594
  on one key and let them disagree, which is the exact defect R2 was written to end.
1595
  */}
1596
+ {needsOwnTable ? (
1597
  <div className="auto-field">
1598
  <label htmlFor="autox-cfgtable">
1599
  <span className="autox-req">*</span> Database