Spaces:
Running on CPU Upgrade
Running on CPU Upgrade
File size: 6,748 Bytes
f530297 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 | /* ---------------------------------------------------------------------------
styles/wave50/rail.css β W50-T09 (owner instruction 10, ruling R16)
TWO IMPORTERS, AND BOTH ARE LOAD-BEARING: `customer-grid/ViewSidebar.tsx` and
`home/HomePage.tsx`. The rail rule below only ever paints inside the grid
chunk; the Home rule only ever paints on the Home route, which never loads
that chunk. A single importer would leave one of the two surfaces unstyled and
every gate green, because a stylesheet nothing on the route imports does
nothing at all. Do not "tidy" either import away.
β NOTHING HERE MAY LIVE IN `index.css` THIS WAVE β that file is shared with
two concurrent lanes. These rules are additive overrides scoped to two
selectors that exist nowhere else.
β TOKENS ONLY (DESIGN.md Β§5). `verify_ui.py` scans every stylesheet under
`web/src/**` for a literal `font-size` and goes red on one, so nothing here
writes a type size at all.
--------------------------------------------------------------------------- */
/* ββ Instruction 10, first half: A DATABASE ROW IS AS TALL AS A VIEW ROW ββββββ
Owner, verbatim: *"The spacing between database rows (Odoo customers / Odoo
products) on the rail differs from the View rail."*
MEASURED, not reasoned about. `.cg-fold-toggle` (index.css:5866) sets
`padding: 4px 6px 4px 7px` around a 16px mark and declares NO min-height, so a
database row resolves to 16 + 4 + 4 = 24px. `.cg-view-main` (index.css:866)
declares `min-height: 32px`. Eight pixels, on two lists stacked one above the
other, which is exactly the difference the owner is reading as "spacing".
β SCOPED TO `.cg-data-database`, NOT TO `.cg-fold-toggle`. Folder headings and
the root fold wear the same class; instruction 10 names the DATABASE rows, and
growing every fold heading by 8px would re-space a list nobody complained
about. `min-height` rather than `height` for the reason `.cg-view-main` carries
it: a row that ever wraps must be allowed to grow, and a fixed height clips. */
.cg-data-database .cg-fold-toggle {
min-height: 32px;
}
/* ββ Ruling R16, second half: THE DATABASE GLYPH REPLACES THE FILLED BADGE ββββ
R16, verbatim: *"the outlined database glyph replaces the filled connector
badge everywhere a database is listed"*, and owner instruction 10: *"The
database mark must be unfilled (hollow) so the database icon reads as an
icon."*
Home drew a database as `.shell-db-chip` β a 26px solid `--lp-primary` tile
with two white letters in it ("OD" for every Odoo database, so ten tiles read
as one thing). That is the CONNECTOR badge vocabulary, and DESIGN.md Β§4's
connector-identity ruling keeps it for connectors: `.conn-tile.is-brand` on
the Connectors page is a connector listing and is untouched.
β THE BOX IS KEPT AT 26px AND ONLY ITS FILL IS DROPPED. Rendering the bare
16px mark would shorten every tile in the section against the automation and
starred-view tiles beside it, and DESIGN.md Β§4 asks controls in a row to share
height. Same square, same radius, no paint.
β AND `.shell-db-chip` MUST NOT STAY ON THE ELEMENT. `index.css:11419` forces
`.shell-db-chip .cg-folder-mark path { stroke: currentColor }` so a mark inside
the chip takes the chip's white ink β on a chip whose background this rule had
removed, that is white on white: invisible, and green in every gate. The class
is dropped in the TSX; this rule supplies the geometry it took away. */
.home-db-glyph {
display: inline-flex;
align-items: center;
justify-content: center;
flex: 0 0 auto;
width: 26px;
height: 26px;
border-radius: var(--lp-r-md);
background: transparent;
}
/* ββ Instruction 6: THE EXPORT PANEL READS AT ONE SIZE βββββββββββββββββββββββ
Owner, verbatim: *"The 'Export Excel' font under Bulk select is out of place
and off brand."*
β THE TICKET BLAMED A MISSING `font: inherit` ON A RAW `<button>`. THAT IS NOT
THE MECHANISM, AND A READER WHO CHECKS WILL FIND IT ALREADY THERE: the export
pane is an `AnchoredOverlay` carrying `className="cg-view-menu"`, so
`index.css:977` (`.cg-view-menu button, .cg-column-actions button`) already
declares `border: 0; background: transparent; font: inherit; color:
var(--cg-text)` on every one of these `role="menuitem"` buttons. DESIGN.md Β§4's
leaked-UA-chrome clause is satisfied and was satisfied before this wave.
β THE ACTUAL DEFECT IS A TYPE STEP, AND WAVE 46 ALREADY RULED ON IT. That same
index.css rule ends `font-size: var(--lp-fs-xs)` (13px), while everything else
inside the bulk pane sits one step down at `--lp-fs-2xs` (12px):
`.cg-pop-title` (index.css:1633), `.cg-pop-note` (index.css:1987) and
`.cg-export-view-row` (`styles/wave46/rail-select.css:120`). W46-T03 put the
checkbox rows on `--lp-fs-2xs` for exactly this reason and wrote the rule down:
*"the whole export PANEL reads at ONE size"*. It moved the rows and never moved
the format buttons underneath them, so the jump the owner is reading is the
last unmoved element of that same ruling. This finishes it.
β DO NOT "CORRECT" THIS BACK TO `--lp-fs-xs`. That is the menu step every OTHER
`.cg-view-menu` panel uses, so it looks like the consistent answer and is the
change a later reader will reach for. It is the defect. This panel is not a
plain menu: it carries a title, a note and a checkbox list, and those three
were deliberately put on the smaller step.
β `font: inherit` IS RESTATED HERE ON PURPOSE and it must stay FIRST. The
shorthand resets `font-size` to the inherited value, so a later reader who
moves it below the size line silently deletes the size. Restating it also keeps
the guarantee local: this panel's buttons are portalled to `<body>`, and the
rule that supplies `font: inherit` today lives in a file two lanes are editing.
β SCOPED BY `data-overlay-kind`, NOT BY `.cg-view-menu` ALONE. `OverlaySurface`
stamps that attribute on the SAME node as the class (`OverlaySurface.tsx:348`
and `:352`), and `ViewSidebar.tsx` passes `dataKind="view-export"` for this pane
only. The class is shared by four panels; three of them are ordinary menus and
must keep the menu step. The attribute also buys specificity (0,2,1 against
`.cg-view-menu button`'s 0,1,1), so this wins on rank rather than on stylesheet
import order, which nothing here controls.
Tokens only: `--lp-fs-2xs` is the scale step, never a literal. */
.cg-view-menu[data-overlay-kind="view-export"] button {
font: inherit;
font-size: var(--lp-fs-2xs);
}
|