Spaces:
Paused
Paused
File size: 10,718 Bytes
06d700b d82af56 06d700b d82af56 06d700b | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 | 'use strict';
/**
* Feedback Controller Unit Tests
* Tests for feedback event endpoints
*/
// Mock dependencies before requiring the controller
const mockPool = {
query: jest.fn(),
connect: jest.fn(() => ({
query: jest.fn(),
release: jest.fn()
}))
};
jest.mock('../src/db', () => ({
getPool: jest.fn(() => mockPool)
}));
jest.mock('uuid', () => ({
v4: jest.fn(() => 'mock-uuid-1234')
}));
const feedbackController = require('../src/controllers/feedback.controller');
const { getPool } = require('../src/db');
describe('Feedback Controller', () => {
let mockReq;
let mockRes;
let mockPool;
beforeEach(() => {
mockReq = {
body: {},
query: {},
params: {}
};
mockRes = {
status: jest.fn().mockReturnThis(),
json: jest.fn().mockReturnThis()
};
mockPool = getPool();
jest.clearAllMocks();
});
describe('createFeedbackEvent', () => {
it('should return 400 if event_type is missing', async () => {
mockReq.body = { session_id: 'session-1' };
await feedbackController.createFeedbackEvent(mockReq, mockRes);
expect(mockRes.status).toHaveBeenCalledWith(400);
expect(mockRes.json).toHaveBeenCalledWith({
error: { message: 'event_type is required' }
});
});
it('should return 400 for invalid event_type', async () => {
mockReq.body = { event_type: 'invalid_type' };
await feedbackController.createFeedbackEvent(mockReq, mockRes);
expect(mockRes.status).toHaveBeenCalledWith(400);
expect(mockRes.json).toHaveBeenCalledWith(
expect.objectContaining({
error: expect.objectContaining({
message: expect.stringContaining('Invalid event_type')
})
})
);
});
it('should accept all valid event types', async () => {
const validEventTypes = [
'plan_saved', 'plan_completed', 'rating_positive',
'poi_added', 'plan_abandoned', 'poi_removed',
'rating_negative', 'poi_reordered', 'poi_swapped', 'session_start'
];
for (const eventType of validEventTypes) {
mockReq.body = { event_type: eventType };
mockPool.query.mockResolvedValueOnce({});
await feedbackController.createFeedbackEvent(mockReq, mockRes);
// Reset for next iteration
jest.clearAllMocks();
mockPool = getPool();
}
});
it('should create a feedback event successfully', async () => {
mockReq.body = {
event_type: 'plan_saved',
session_id: 'session-123',
user_hash: 'user-hash-456',
context: { destination: 'Ranchi' },
itinerary_snapshot: [{ poi_id: 'poi-1', name: 'Hundru Falls' }],
modifications: [],
reward: 1.5
};
mockPool.query.mockResolvedValueOnce({});
await feedbackController.createFeedbackEvent(mockReq, mockRes);
expect(mockRes.status).toHaveBeenCalledWith(201);
expect(mockRes.json).toHaveBeenCalledWith({
data: expect.objectContaining({
id: 'mock-uuid-1234',
event_type: 'plan_saved',
session_id: 'session-123',
reward: 1.5
}),
message: 'Feedback event recorded successfully'
});
});
it('should return 503 if database is not available', async () => {
mockReq.body = { event_type: 'plan_saved' };
// Override getPool to return null
require('../src/db').getPool.mockReturnValueOnce(null);
await feedbackController.createFeedbackEvent(mockReq, mockRes);
expect(mockRes.status).toHaveBeenCalledWith(503);
expect(mockRes.json).toHaveBeenCalledWith({
error: { message: 'Database not available' }
});
});
it('should return 500 on database error', async () => {
mockReq.body = { event_type: 'plan_saved' };
mockPool.query.mockRejectedValueOnce(new Error('DB connection failed'));
await feedbackController.createFeedbackEvent(mockReq, mockRes);
expect(mockRes.status).toHaveBeenCalledWith(500);
expect(mockRes.json).toHaveBeenCalledWith({
error: { message: 'Failed to record feedback event' }
});
});
it('should use default values for optional fields', async () => {
mockReq.body = { event_type: 'session_start' };
mockPool.query.mockResolvedValueOnce({});
await feedbackController.createFeedbackEvent(mockReq, mockRes);
expect(mockPool.query).toHaveBeenCalledWith(
expect.any(String),
expect.arrayContaining([
'mock-uuid-1234',
'session_start',
null, // session_id
null, // user_hash
'{}', // context
'[]', // itinerary_snapshot
'[]', // modifications
0 // reward
])
);
});
});
describe('listFeedbackEvents', () => {
it('should list all feedback events with default pagination', async () => {
const mockEvents = [
{ id: '1', event_type: 'plan_saved' },
{ id: '2', event_type: 'poi_added' }
];
mockPool.query.mockResolvedValueOnce({ rows: mockEvents });
await feedbackController.listFeedbackEvents(mockReq, mockRes);
expect(mockRes.json).toHaveBeenCalledWith({ data: mockEvents });
});
it('should filter by event_type', async () => {
mockReq.query = { event_type: 'plan_saved' };
mockPool.query.mockResolvedValueOnce({ rows: [] });
await feedbackController.listFeedbackEvents(mockReq, mockRes);
expect(mockPool.query).toHaveBeenCalledWith(
expect.stringContaining('event_type = $'),
expect.arrayContaining(['plan_saved'])
);
});
it('should filter by session_id', async () => {
mockReq.query = { session_id: 'session-123' };
mockPool.query.mockResolvedValueOnce({ rows: [] });
await feedbackController.listFeedbackEvents(mockReq, mockRes);
expect(mockPool.query).toHaveBeenCalledWith(
expect.stringContaining('session_id = $'),
expect.arrayContaining(['session-123'])
);
});
it('should apply custom pagination', async () => {
mockReq.query = { limit: '50', offset: '100' };
mockPool.query.mockResolvedValueOnce({ rows: [] });
await feedbackController.listFeedbackEvents(mockReq, mockRes);
expect(mockPool.query).toHaveBeenCalledWith(
expect.any(String),
expect.arrayContaining([50, 100])
);
});
it('should cap limit at 1000', async () => {
mockReq.query = { limit: '5000' };
mockPool.query.mockResolvedValueOnce({ rows: [] });
await feedbackController.listFeedbackEvents(mockReq, mockRes);
expect(mockPool.query).toHaveBeenCalledWith(
expect.any(String),
expect.arrayContaining([1000])
);
});
it('should return 503 if database is not available', async () => {
require('../src/db').getPool.mockReturnValueOnce(null);
await feedbackController.listFeedbackEvents(mockReq, mockRes);
expect(mockRes.status).toHaveBeenCalledWith(503);
});
it('should return 500 on database error', async () => {
mockPool.query.mockRejectedValueOnce(new Error('DB error'));
await feedbackController.listFeedbackEvents(mockReq, mockRes);
expect(mockRes.status).toHaveBeenCalledWith(500);
expect(mockRes.json).toHaveBeenCalledWith({
error: { message: 'Failed to list feedback events' }
});
});
});
describe('getPOIStats', () => {
it('should return 400 if poi_id is missing', async () => {
mockReq.params = {};
await feedbackController.getPOIStats(mockReq, mockRes);
expect(mockRes.status).toHaveBeenCalledWith(400);
expect(mockRes.json).toHaveBeenCalledWith({
error: { message: 'poi_id is required' }
});
});
it('should return aggregated stats for a POI', async () => {
mockReq.params = { poi_id: 'poi-123' };
const mockEvents = [
{ event_type: 'plan_saved', reward: '1.0', modifications: '[]' },
{ event_type: 'plan_saved', reward: '0.5', modifications: '[]' },
{ event_type: 'poi_removed', reward: '-0.5', modifications: '[{"poi_id": "poi-123"}]' }
];
mockPool.query.mockResolvedValueOnce({ rows: mockEvents });
await feedbackController.getPOIStats(mockReq, mockRes);
expect(mockRes.json).toHaveBeenCalledWith({
data: expect.objectContaining({
poi_id: 'poi-123',
times_suggested: 3,
times_saved: 2,
times_removed: 1
})
});
});
it('should calculate save_rate correctly', async () => {
mockReq.params = { poi_id: 'poi-456' };
const mockEvents = [
{ event_type: 'plan_saved', reward: '1.0', modifications: '[]' },
{ event_type: 'plan_completed', reward: '1.0', modifications: '[]' }
];
mockPool.query.mockResolvedValueOnce({ rows: mockEvents });
await feedbackController.getPOIStats(mockReq, mockRes);
expect(mockRes.json).toHaveBeenCalledWith({
data: expect.objectContaining({
times_saved: 1,
times_suggested: 2,
save_rate: '0.50'
})
});
});
it('should return zero stats for POI with no events', async () => {
mockReq.params = { poi_id: 'new-poi' };
mockPool.query.mockResolvedValueOnce({ rows: [] });
await feedbackController.getPOIStats(mockReq, mockRes);
expect(mockRes.json).toHaveBeenCalledWith({
data: expect.objectContaining({
poi_id: 'new-poi',
times_suggested: 0,
times_saved: 0,
times_removed: 0,
avg_reward: 0,
save_rate: 0
})
});
});
it('should return 503 if database is not available', async () => {
mockReq.params = { poi_id: 'poi-123' };
require('../src/db').getPool.mockReturnValueOnce(null);
await feedbackController.getPOIStats(mockReq, mockRes);
expect(mockRes.status).toHaveBeenCalledWith(503);
});
it('should return 500 on database error', async () => {
mockReq.params = { poi_id: 'poi-123' };
mockPool.query.mockRejectedValueOnce(new Error('DB error'));
await feedbackController.getPOIStats(mockReq, mockRes);
expect(mockRes.status).toHaveBeenCalledWith(500);
expect(mockRes.json).toHaveBeenCalledWith({
error: { message: 'Failed to get POI stats' }
});
});
});
});
|