File size: 9,943 Bytes
85b7ac8 4b07aaf 85b7ac8 4b07aaf 85b7ac8 4b07aaf 85b7ac8 4b07aaf 85b7ac8 4b07aaf 85b7ac8 4b07aaf 85b7ac8 4b07aaf 85b7ac8 4b07aaf 85b7ac8 4b07aaf 85b7ac8 4b07aaf 85b7ac8 4b07aaf 85b7ac8 4b07aaf 85b7ac8 4b07aaf 85b7ac8 4b07aaf 85b7ac8 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 | """Docker build/run simulator with deterministic rule-based validation."""
from __future__ import annotations
from typing import Dict, List, Optional, Set
from server.models import FileContent
class DockerSimulator:
VALID_INSTRUCTIONS: Set[str] = {
"FROM",
"RUN",
"CMD",
"LABEL",
"MAINTAINER",
"EXPOSE",
"ENV",
"ADD",
"COPY",
"ENTRYPOINT",
"VOLUME",
"USER",
"WORKDIR",
"ARG",
"ONBUILD",
"STOPSIGNAL",
"HEALTHCHECK",
"SHELL",
}
def _split_lines(self, content: str) -> List[str]:
return [line.rstrip() for line in content.split("\n")]
def _non_empty_non_comment_lines(self, lines: List[str]) -> List[str]:
return [line.strip() for line in lines if line.strip() and not line.strip().startswith("#")]
def _source_exists(self, source: str, context_files: Dict[str, FileContent]) -> bool:
if source in {".", "./"}:
return True
if "*" in source:
prefix = source.replace("*", "")
return any(path.startswith(prefix) for path in context_files)
return source in context_files
def _join_continuation_lines(self, lines: List[str]) -> List[str]:
"""Join lines ending with backslash into single logical lines."""
result: List[str] = []
current = ""
for line in lines:
stripped = line.rstrip()
if stripped.endswith("\\"):
current += stripped[:-1] + " "
else:
current += stripped
result.append(current)
current = ""
if current:
result.append(current)
return result
def validate(self, dockerfile: Optional[FileContent], context_files: Dict[str, FileContent]):
if dockerfile is None:
return {"build_success": False, "run_success": False, "error": "Dockerfile missing"}
content = dockerfile.content
lines = self._split_lines(content)
active_lines = self._non_empty_non_comment_lines(lines)
if not active_lines:
return {"build_success": False, "run_success": False, "error": "Dockerfile is empty"}
# --- ARG before FROM is allowed, but first non-ARG instruction must be FROM ---
first_non_arg = None
for line in active_lines:
token = line.split()[0].upper()
if token == "ARG":
continue
first_non_arg = token
break
if first_non_arg is None or first_non_arg != "FROM":
return {
"build_success": False,
"run_success": False,
"error": "Dockerfile must start with FROM",
}
# --- Instruction validation ---
for idx, raw in enumerate(active_lines, start=1):
token = raw.split()[0].upper()
# Handle --platform= prefix on FROM
if token.startswith("FROM"):
token = "FROM"
if token.startswith("&&"):
return {
"build_success": False,
"run_success": False,
"error": f"Dockerfile parse error: unknown instruction: {token}",
"line": idx,
}
# Strip leading --flags (e.g. --platform=...) — the instruction is after
if token.startswith("--"):
continue
if token not in self.VALID_INSTRUCTIONS:
return {
"build_success": False,
"run_success": False,
"error": f"Dockerfile parse error: unknown instruction: {token}",
"line": idx,
}
# --- Invalid base image tags ---
if "FROM python:3.9-slimm" in content:
return {
"build_success": False,
"run_success": False,
"error": "pull access denied for python:3.9-slimm",
}
# --- Typo in requirements filename ---
if "requirments.txt" in content:
return {
"build_success": False,
"run_success": False,
"error": "COPY failed: file not found in build context: requirments.txt",
}
# --- COPY source validation ---
for raw in active_lines:
upper = raw.upper()
if upper.startswith("COPY "):
parts = raw.split()
if len(parts) < 3:
return {
"build_success": False,
"run_success": False,
"error": "COPY requires source and destination",
}
src = parts[1]
if src.startswith("--from=") and len(parts) >= 4:
src = parts[2]
if src.startswith("--"):
continue
if not self._source_exists(src, context_files):
return {
"build_success": False,
"run_success": False,
"error": f"COPY failed: file not found in build context: {src}",
}
# --- Platform ARG declarations ---
if "--platform=$BUILDPLATFORM" in content and "ARG BUILDPLATFORM" not in content:
return {
"build_success": False,
"run_success": False,
"error": "failed to parse platform: BUILDPLATFORM not declared",
}
if "--platform=$TARGETPLATFORM" in content and "ARG TARGETPLATFORM" not in content:
return {
"build_success": False,
"run_success": False,
"error": "failed to parse platform: TARGETPLATFORM not declared",
}
# --- Multi-stage artifact path mismatch (dist vs build) ---
if "COPY --from=builder /app/dist" in content:
pkg = context_files.get("package.json")
if pkg and "react-scripts build" in pkg.content:
return {
"build_success": False,
"run_success": False,
"error": "COPY failed: stat app/dist: file does not exist",
}
# --- EXPOSE string validation ---
for raw in active_lines:
upper = raw.upper()
if upper.startswith("EXPOSE "):
parts = raw.split()
for part in parts[1:]:
cleaned = part.strip('"').strip("'")
port_proto = cleaned.split("/")[0]
if not port_proto.isdigit():
return {
"build_success": False,
"run_success": False,
"error": f"EXPOSE requires numeric port or port/protocol, got: {cleaned}",
}
# =====================================================
# Runtime checks (build succeeds, run may fail)
# =====================================================
# --- Missing WORKDIR causing module resolution failures ---
has_workdir = "WORKDIR" in content
if ("npm start" in content or 'CMD ["npm", "start"]' in content) and not has_workdir:
return {
"build_success": True,
"run_success": False,
"run_error": "Error: Cannot find module '/package.json'",
}
# --- ENTRYPOINT + identical CMD conflict ---
if 'ENTRYPOINT ["python"' in content and 'CMD ["python"' in content:
return {
"build_success": True,
"run_success": False,
"run_error": "container exits immediately; ENTRYPOINT and CMD both specify full command",
}
# --- Entrypoint script not executable ---
if 'ENTRYPOINT ["./start.sh"]' in content and "chmod +x" not in content:
return {
"build_success": True,
"run_success": False,
"run_error": "exec ./start.sh: permission denied",
}
# --- Missing required ENV variable (DATABASE_URL) ---
# Check if the scenario error mentions DATABASE_URL (via context files or content)
has_database_url_env = "ENV DATABASE_URL" in content
needs_database_url = (
"app.py" in content
and "DATABASE_URL" not in content
and any("gunicorn" in fc.content for fc in context_files.values() if fc.content)
)
if needs_database_url and not has_database_url_env:
return {
"build_success": True,
"run_success": False,
"run_error": "KeyError: 'DATABASE_URL' — Application requires DATABASE_URL environment variable",
}
# --- Non-root user binding to privileged port ---
has_user_switch = False
expose_port = None
for raw in active_lines:
upper = raw.upper()
if upper.startswith("USER ") and "root" not in raw.lower():
has_user_switch = True
if upper.startswith("EXPOSE "):
parts = raw.split()
if len(parts) >= 2:
port_str = parts[1].split("/")[0].strip('"').strip("'")
if port_str.isdigit():
expose_port = int(port_str)
if has_user_switch and expose_port is not None and expose_port < 1024:
return {
"build_success": True,
"run_success": False,
"run_error": f"PermissionError: [Errno 13] Permission denied — non-root user cannot bind to port {expose_port}",
}
return {"build_success": True, "run_success": True}
|