File size: 16,685 Bytes
330f477
 
8494801
 
bff0fe1
330f477
 
 
bf521ca
8494801
 
bf521ca
 
 
 
 
 
330f477
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
bf521ca
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
330f477
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
bff0fe1
 
 
330f477
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
bff0fe1
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
8494801
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
0b7bc1e
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
8494801
 
 
 
 
 
 
 
 
 
 
 
 
c00df26
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
from __future__ import annotations

from pathlib import Path

import numpy as np
from fastapi.testclient import TestClient

from openmusic_analysis.api import create_app
from openmusic_analysis.application import build_service
from openmusic_analysis.audio.decoder import AudioMetadata, DecodedAudio
from openmusic_analysis.domain import LyricsResolution, LyricsSourceError
from openmusic_analysis.settings import (
    AudioEmotionConfig,
    LimitConfig,
    Settings,
    TemporalAudioConfig,
)

from .conftest import FailingAudioEncoder, make_service


def client_for(service) -> TestClient:
    return TestClient(create_app(service=service, settings=Settings()))


def upload(content: bytes = b"valid fake audio"):
    return {"audio": ("track.mp3", content, "audio/mpeg")}


def test_valid_audio_only_request(service_bundle):
    service, _, _ = service_bundle
    response = client_for(service).post("/v1/tracks/analyze", files=upload())
    assert response.status_code == 200
    assert set(response.json()["representations"]) == {"audio.global", "audio.temporal"}
    assert response.json()["schema_version"] == "1"


def test_audio_emotion_global_request_uses_schema_v2(service_bundle):
    service, _, _ = service_bundle
    response = client_for(service).post(
        "/v1/tracks/analyze",
        files=upload(),
        data={"requested_representations": "audio.emotion.global"},
    )
    assert response.status_code == 200
    body = response.json()
    assert body["schema_version"] == "2"
    result = body["representations"]["audio.emotion.global"]
    assert -1 <= result["valence"] <= 1
    assert -1 <= result["arousal"] <= 1
    assert len(result["mood_distribution"]["labels"]) == 56
    assert result["emotion_embedding"] is None


def test_combined_legacy_and_audio_emotion_representations(service_bundle):
    service, decoder, _ = service_bundle
    response = client_for(service).post(
        "/v1/tracks/analyze",
        files=upload(),
        data={
            "requested_representations": [
                "audio.global",
                "audio.emotion.global",
                "audio.emotion.temporal",
            ]
        },
    )
    assert response.status_code == 200
    assert list(response.json()["representations"]) == [
        "audio.global",
        "audio.emotion.global",
        "audio.emotion.temporal",
    ]
    assert decoder.calls == 1


def test_lyrics_emotion_request_returns_typed_unavailable(service_bundle):
    service, _, _ = service_bundle
    response = client_for(service).post(
        "/v1/tracks/analyze",
        files=upload(),
        data={
            "lyrics": "[Verse]\nHello world\n\n[Припев]\nПривет, мир",
            "requested_representations": "lyrics.emotion.global",
        },
    )
    assert response.status_code == 503
    assert response.json()["error"]["code"] == "LYRICS_EMOTION_MODEL_UNAVAILABLE"


def test_disabled_deployment_audio_emotion_is_typed_unavailable():
    settings = Settings(audio_emotion=AudioEmotionConfig(enabled=False))
    response = client_for(build_service(settings)).post(
        "/v1/tracks/analyze",
        files=upload(),
        data={"requested_representations": "audio.emotion.global"},
    )
    assert response.status_code == 503
    assert response.json()["error"]["code"] == "EMOTION_MODEL_UNAVAILABLE"
    assert "traceback" not in response.text.lower()


def test_status_reports_lazy_emotion_runtime_state_and_real_availability():
    settings = Settings(audio_emotion=AudioEmotionConfig(enabled=True))
    response = TestClient(create_app(service=build_service(settings), settings=settings)).get(
        "/v1/status"
    )
    assert response.status_code == 200
    body = response.json()
    assert body["model_states"] == {
        "audio.emotion.global": "not_loaded",
        "audio.emotion.temporal": "not_loaded",
    }
    assert "audio.emotion.global" in body["available_representations"]
    assert "lyrics.emotion.global" not in body["available_representations"]


def test_audio_emotion_inference_failure_is_sanitized(service_bundle):
    service, _, _ = service_bundle
    encoder = service.registry.analyzer("audio.emotion.global").pipeline.encoder

    async def fail(_windows):
        raise RuntimeError("private emotion runtime detail")

    encoder.predict = fail
    response = client_for(service).post(
        "/v1/tracks/analyze",
        files=upload(),
        data={"requested_representations": "audio.emotion.global"},
    )
    assert response.status_code == 500
    assert response.json()["error"]["code"] == "EMOTION_INFERENCE_FAILED"
    assert "private emotion runtime detail" not in response.text


def test_audio_emotion_malformed_output_is_typed(service_bundle):
    from openmusic_analysis.analyzers.emotion import RawEmotionPrediction

    service, _, _ = service_bundle
    encoder = service.registry.analyzer("audio.emotion.global").pipeline.encoder

    async def malformed(windows):
        return [
            RawEmotionPrediction(
                raw_valence=5.0,
                raw_arousal=5.0,
                mood_probabilities=(0.5,),
            )
            for _ in windows
        ]

    encoder.predict = malformed
    response = client_for(service).post(
        "/v1/tracks/analyze",
        files=upload(),
        data={"requested_representations": "audio.emotion.global"},
    )
    assert response.status_code == 500
    assert response.json()["error"]["code"] == "EMOTION_OUTPUT_INVALID"


def test_audio_and_multilingual_lyrics(service_bundle):
    service, _, _ = service_bundle
    response = client_for(service).post(
        "/v1/tracks/analyze",
        files=upload(),
        data={"lyrics": "[Verse]\nHello world\n\n[Припев]\nПривет, мир!"},
    )
    assert response.status_code == 200
    assert "lyrics.global" in response.json()["representations"]


def test_requested_representations_avoid_unrequested_work(service_bundle):
    service, decoder, encoder = service_bundle
    response = client_for(service).post(
        "/v1/tracks/analyze",
        files=upload(),
        data={
            "lyrics": "lyrics that must not be encoded",
            "requested_representations": "audio.global",
        },
    )
    assert response.status_code == 200
    assert list(response.json()["representations"]) == ["audio.global"]
    assert decoder.calls == 1
    assert len(encoder.calls) == 1


def test_invalid_file_returns_structured_decode_error(service_bundle):
    service, _, _ = service_bundle
    response = client_for(service).post(
        "/v1/tracks/analyze", files=upload(b"bad bytes")
    )
    assert response.status_code == 422
    assert response.json()["error"]["code"] == "AUDIO_DECODE_FAILED"


def test_missing_audio_is_structured(service_bundle):
    service, _, _ = service_bundle
    response = client_for(service).post("/v1/tracks/analyze", data={"lyrics": "text"})
    assert response.status_code == 422
    assert response.json()["error"]["code"] == "MISSING_AUDIO"


def test_unsupported_representation(service_bundle):
    service, _, _ = service_bundle
    response = client_for(service).post(
        "/v1/tracks/analyze",
        files=upload(),
        data={"requested_representations": "audio.emotion"},
    )
    assert response.status_code == 422
    assert response.json()["error"]["code"] == "UNSUPPORTED_REPRESENTATION"


def test_unsupported_extension(service_bundle):
    service, _, _ = service_bundle
    response = client_for(service).post(
        "/v1/tracks/analyze", files={"audio": ("track.txt", b"data", "text/plain")}
    )
    assert response.status_code == 415
    assert response.json()["error"]["code"] == "UNSUPPORTED_AUDIO_FORMAT"


def test_explicit_lyrics_representation_requires_lyrics(service_bundle):
    service, _, _ = service_bundle
    response = client_for(service).post(
        "/v1/tracks/analyze",
        files=upload(),
        data={"requested_representations": "lyrics.global"},
    )
    assert response.status_code == 422
    assert response.json()["error"]["code"] == "LYRICS_REQUIRED"


def test_invalid_empty_lyrics(service_bundle):
    service, _, _ = service_bundle
    response = client_for(service).post(
        "/v1/tracks/analyze", files=upload(), data={"lyrics": "   \n "}
    )
    assert response.status_code == 422
    assert response.json()["error"]["code"] == "INVALID_LYRICS"


def test_model_failure_does_not_leak_internal_exception():
    service, _, _ = make_service(audio_encoder=FailingAudioEncoder())
    response = client_for(service).post(
        "/v1/tracks/analyze",
        files=upload(),
        data={"requested_representations": "audio.global"},
    )
    assert response.status_code == 500
    assert response.json()["error"]["code"] == "MODEL_INFERENCE_FAILED"
    assert "internal model detail" not in response.text


def test_temporal_api_response_uses_adjacent_transition_index():
    service, _, _ = make_service(waveform=np.arange(150, dtype=np.float32))
    service.registry.analyzer("audio.temporal").config = TemporalAudioConfig(
        sample_rate=10,
        window_seconds=1,
        hop_seconds=1,
        max_segments=15,
        minimum_audio_seconds=1,
    )
    response = client_for(service).post(
        "/v1/tracks/analyze",
        files=upload(),
        data={"requested_representations": "audio.temporal"},
    )
    assert response.status_code == 200
    temporal = response.json()["representations"]["audio.temporal"]
    assert len(temporal["segments"]) == 15
    assert temporal["summary"]["number_of_segments"] == 15
    assert 0 <= temporal["summary"]["largest_transition_index"] <= 13


class ContentDecoder:
    canonical_sample_rate = 10

    def __init__(self) -> None:
        self.calls = 0

    def decode(self, source_path) -> DecodedAudio:
        self.calls += 1
        content = source_path.read_bytes()
        if content in {b"target", b"same"}:
            waveform = np.linspace(-1.0, 1.0, 95, dtype=np.float32)
        elif content == b"reversed":
            waveform = np.linspace(1.0, -1.0, 95, dtype=np.float32)
        else:
            waveform = np.full(95, 3.0, dtype=np.float32)
        return DecodedAudio(
            waveform=waveform,
            sample_rate=self.canonical_sample_rate,
            metadata=AudioMetadata(
                duration_ms=9500,
                source_sample_rate=10,
                source_channels=1,
                source_format="fake",
            ),
        )


class FakeLyricsResolver:
    async def resolve(self, source_path, *, provided_lyrics=None, supplied_metadata=None):
        content = Path(source_path).read_bytes()
        if content == b"same":
            return LyricsResolution(
                text="Resolved candidate lyrics",
                source="lrclib",
                errors=[
                    LyricsSourceError(
                        source="embedded",
                        code="LYRICS_NOT_FOUND",
                        message="No embedded lyrics.",
                    )
                ],
            )
        return LyricsResolution(
            errors=[
                LyricsSourceError(
                    source="lrclib",
                    code="LYRICS_NOT_FOUND",
                    message="No provider match.",
                )
            ]
        )


def test_rank_similar_tracks_returns_descending_global_audio_similarity(service_bundle):
    service, _, encoder = service_bundle
    decoder = ContentDecoder()
    service.decoder = decoder
    service.lyrics_resolver = FakeLyricsResolver()
    response = client_for(service).post(
        "/v1/tracks/rank-similar",
        files=[
            ("target_audio", ("target.mp3", b"target", "audio/mpeg")),
            ("tracks", ("different.mp3", b"different", "audio/mpeg")),
            ("tracks", ("same.mp3", b"same", "audio/mpeg")),
            ("tracks", ("reversed.mp3", b"reversed", "audio/mpeg")),
        ],
        data={
            "target_track_id": "target-id",
            "target_lyrics": "Lyrics supplied for target",
            "track_ids": ["different-id", "same-id", "reversed-id"],
        },
    )
    assert response.status_code == 200
    body = response.json()
    assert body["representation"] == "audio.global"
    assert body["target"]["track_id"] == "target-id"
    assert body["target"]["filename"] == "target.mp3"
    assert body["target"]["lyrics"]["text"] == "Lyrics supplied for target"
    assert body["target"]["lyrics"]["source"] == "request"
    assert body["tracks"][0]["track_id"] == "same-id"
    assert body["tracks"][0]["similarity"] == 1.0
    assert body["tracks"][0]["lyrics"]["text"] == "Resolved candidate lyrics"
    assert body["tracks"][0]["lyrics"]["source"] == "lrclib"
    assert body["tracks"][0]["lyrics"]["errors"][0]["source"] == "embedded"
    assert [item["similarity"] for item in body["tracks"]] == sorted(
        [item["similarity"] for item in body["tracks"]], reverse=True
    )
    assert decoder.calls == 4
    assert len(encoder.calls) == 4


def test_analyze_automatically_adds_lyrics_representation(service_bundle):
    service, _, _ = service_bundle
    service.lyrics_resolver = FakeLyricsResolver()
    response = client_for(service).post(
        "/v1/tracks/analyze",
        files=upload(b"same"),
        data={"title": "Candidate", "artist": "Artist"},
    )
    assert response.status_code == 200
    body = response.json()
    assert "lyrics.global" in body["representations"]
    assert body["lyrics"]["text"] == "Resolved candidate lyrics"
    assert body["lyrics"]["source"] == "lrclib"


def test_rank_similar_tracks_validates_track_id_count(service_bundle):
    service, _, _ = service_bundle
    response = client_for(service).post(
        "/v1/tracks/rank-similar",
        files=[
            ("target_audio", ("target.mp3", b"target", "audio/mpeg")),
            ("tracks", ("one.mp3", b"one", "audio/mpeg")),
            ("tracks", ("two.mp3", b"two", "audio/mpeg")),
        ],
        data={"track_ids": ["only-one-id"]},
    )
    assert response.status_code == 422
    assert response.json()["error"]["code"] == "INVALID_TRACK_IDS"


def test_rank_similar_tracks_treats_swagger_empty_arrays_as_omitted(service_bundle):
    service, _, _ = service_bundle
    response = client_for(service).post(
        "/v1/tracks/rank-similar",
        files=[
            ("target_audio", ("target.mp3", b"target", "audio/mpeg")),
            ("tracks", ("one.mp3", b"one", "audio/mpeg")),
            ("tracks", ("two.mp3", b"two", "audio/mpeg")),
        ],
        data={
            "track_ids": "",
            "track_lyrics": "",
            "track_titles": "",
            "track_artists": "",
            "track_albums": "",
            "track_isrcs": "",
        },
    )
    assert response.status_code == 200
    assert [item["track_id"] for item in response.json()["tracks"]] == [None, None]


def test_rank_similar_tracks_respects_candidate_limit(service_bundle):
    service, _, _ = service_bundle
    settings = Settings(limits=LimitConfig(max_similarity_tracks=1))
    response = TestClient(create_app(service=service, settings=settings)).post(
        "/v1/tracks/rank-similar",
        files=[
            ("target_audio", ("target.mp3", b"target", "audio/mpeg")),
            ("tracks", ("one.mp3", b"one", "audio/mpeg")),
            ("tracks", ("two.mp3", b"two", "audio/mpeg")),
        ],
    )
    assert response.status_code == 413
    assert response.json()["error"]["code"] == "TOO_MANY_CANDIDATE_TRACKS"


def test_rank_similar_openapi_declares_tracks_as_multiple_binary_files(service_bundle):
    service, _, _ = service_bundle
    schema = client_for(service).get("/openapi.json").json()
    operation = schema["paths"]["/v1/tracks/rank-similar"]["post"]
    multipart = operation["requestBody"]["content"]["multipart/form-data"]
    body = multipart["schema"]
    if "$ref" in body:
        body_name = body["$ref"].rsplit("/", maxsplit=1)[-1]
        body = schema["components"]["schemas"][body_name]
    tracks = body["properties"]["tracks"]
    assert tracks["type"] == "array"
    assert tracks["items"] == {"type": "string", "format": "binary"}
    assert tracks["minItems"] == 1
    assert multipart["encoding"]["tracks"]["explode"] is True
    assert body["properties"]["target_lyrics"]["example"] == ""
    assert body["properties"]["track_lyrics"]["example"] == []
    response_example = operation["responses"]["200"]["content"]["application/json"][
        "example"
    ]
    assert response_example["tracks"][0]["lyrics"]["text"] is None
    assert response_example["tracks"][0]["lyrics"]["source"] is None