afp-backend / tests /unit /test_article_import_processor.py
Cyril Dupland
feat(article_import): introduce support for 'COMMUN' brand alias to link articles to all existing brands, update schemas and processing logic accordingly
dae5737
Raw History Blame Contribute Delete
7.62 kB
from pathlib import Path
from types import SimpleNamespace
from unittest.mock import AsyncMock
import pytest
from app.services.article_import_processor import ArticleImportProcessor
@pytest.mark.unit
@pytest.mark.asyncio
async def test_process_single_pass_sets_total_rows_at_finish(tmp_path) -> None:
csv_path = tmp_path / "job.csv"
csv_path.write_text("Ref,Nom\nR1,Label\n", encoding="utf-8")
import_id = "test-import-id"
object_key = f"catalogues/{import_id}.csv"
job_row = SimpleNamespace(
type="articles",
mapping={"reference_number": "Ref", "label_fr": "Nom"},
options={"has_header": True, "delimiter": ",", "encoding": "utf-8"},
path=object_key,
)
import_repo = AsyncMock()
import_repo.get_by_id.return_value = job_row
error_repo = AsyncMock()
bulk_repo = AsyncMock()
bulk_repo.upsert_batch.return_value = []
async def fake_download(_key: str, iid: str) -> Path:
dest = tmp_path / f"{iid}.csv"
dest.write_bytes(csv_path.read_bytes())
return dest
file_storage = AsyncMock()
file_storage.download_to_temp.side_effect = fake_download
processor = ArticleImportProcessor(import_repo, error_repo, bulk_repo, file_storage)
await processor.process(import_id)
import_repo.set_total_rows.assert_not_called()
file_storage.download_to_temp.assert_awaited_once_with(object_key, import_id)
import_repo.set_processing.assert_awaited_once_with(import_id)
bulk_repo.upsert_batch.assert_awaited_once()
import_repo.set_finished.assert_awaited_once()
_args, kwargs = import_repo.set_finished.call_args
assert kwargs["status"] == "succeeded"
assert kwargs["row_count"] == 1
assert kwargs["total_rows"] == 1
assert kwargs["row_succeeded"] == 1
assert kwargs["row_failed"] == 0
assert (tmp_path / f"{import_id}.csv").exists() is False
record = bulk_repo.upsert_batch.call_args[0][0][0]
assert record.status is True
assert record.label_fr == "Label"
assert record.brand is None
@pytest.mark.unit
@pytest.mark.asyncio
async def test_process_nfp_row_deactivates_and_ignores_other_fields(tmp_path) -> None:
csv_path = tmp_path / "job.csv"
csv_path.write_text(
"Ref,Nom,Old\nR1,Label,NFP\n",
encoding="utf-8",
)
import_id = "test-import-nfp"
object_key = f"catalogues/{import_id}.csv"
job_row = SimpleNamespace(
type="articles",
mapping={
"reference_number": "Ref",
"label_fr": "Nom",
"reference_old": "Old",
},
options={"has_header": True, "delimiter": ",", "encoding": "utf-8"},
path=object_key,
)
import_repo = AsyncMock()
import_repo.get_by_id.return_value = job_row
error_repo = AsyncMock()
bulk_repo = AsyncMock()
bulk_repo.upsert_batch.return_value = []
async def fake_download(_key: str, iid: str) -> Path:
dest = tmp_path / f"{iid}.csv"
dest.write_bytes(csv_path.read_bytes())
return dest
file_storage = AsyncMock()
file_storage.download_to_temp.side_effect = fake_download
processor = ArticleImportProcessor(import_repo, error_repo, bulk_repo, file_storage)
await processor.process(import_id)
record = bulk_repo.upsert_batch.call_args[0][0][0]
assert record.status is False
assert record.reference_number == "R1"
assert record.label_fr is None
assert record.label_en is None
assert record.category_level_1 is None
assert record.moq is None
assert record.origin is None
assert record.reference_old is None
assert record.reference_new is None
assert record.brand is None
assert record.category_level_1 is None
assert record.category_level_2 is None
assert record.category_level_3 is None
@pytest.mark.unit
@pytest.mark.asyncio
async def test_process_passes_brand_on_normal_row(tmp_path) -> None:
csv_path = tmp_path / "job.csv"
csv_path.write_text("Ref,Brand\nR1,Acme\n", encoding="utf-8")
import_id = "test-import-brand"
object_key = f"catalogues/{import_id}.csv"
job_row = SimpleNamespace(
type="articles",
mapping={"reference_number": "Ref", "brand": "Brand"},
options={"has_header": True, "delimiter": ",", "encoding": "utf-8"},
path=object_key,
)
import_repo = AsyncMock()
import_repo.get_by_id.return_value = job_row
error_repo = AsyncMock()
bulk_repo = AsyncMock()
bulk_repo.upsert_batch.return_value = []
async def fake_download(_key: str, iid: str) -> Path:
dest = tmp_path / f"{iid}.csv"
dest.write_bytes(csv_path.read_bytes())
return dest
file_storage = AsyncMock()
file_storage.download_to_temp.side_effect = fake_download
processor = ArticleImportProcessor(import_repo, error_repo, bulk_repo, file_storage)
await processor.process(import_id)
record = bulk_repo.upsert_batch.call_args[0][0][0]
assert record.brand == "Acme"
@pytest.mark.unit
@pytest.mark.asyncio
async def test_process_commun_brand_sets_link_all_brands(tmp_path) -> None:
csv_path = tmp_path / "job.csv"
csv_path.write_text("Ref,Brand\nR1,commun\n", encoding="utf-8")
import_id = "test-import-commun"
object_key = f"catalogues/{import_id}.csv"
job_row = SimpleNamespace(
type="articles",
mapping={"reference_number": "Ref", "brand": "Brand"},
options={"has_header": True, "delimiter": ",", "encoding": "utf-8"},
path=object_key,
)
import_repo = AsyncMock()
import_repo.get_by_id.return_value = job_row
error_repo = AsyncMock()
bulk_repo = AsyncMock()
bulk_repo.upsert_batch.return_value = []
async def fake_download(_key: str, iid: str) -> Path:
dest = tmp_path / f"{iid}.csv"
dest.write_bytes(csv_path.read_bytes())
return dest
file_storage = AsyncMock()
file_storage.download_to_temp.side_effect = fake_download
processor = ArticleImportProcessor(import_repo, error_repo, bulk_repo, file_storage)
await processor.process(import_id)
record = bulk_repo.upsert_batch.call_args[0][0][0]
assert record.link_all_brands is True
assert record.brand is None
@pytest.mark.unit
@pytest.mark.asyncio
async def test_process_passes_category_levels_on_normal_row(tmp_path) -> None:
csv_path = tmp_path / "job.csv"
csv_path.write_text("Ref,C1,C2\nR1,Famille,Sous\n", encoding="utf-8")
import_id = "test-import-cat"
object_key = f"catalogues/{import_id}.csv"
job_row = SimpleNamespace(
type="articles",
mapping={
"reference_number": "Ref",
"category_level_1": "C1",
"category_level_2": "C2",
},
options={"has_header": True, "delimiter": ",", "encoding": "utf-8"},
path=object_key,
)
import_repo = AsyncMock()
import_repo.get_by_id.return_value = job_row
error_repo = AsyncMock()
bulk_repo = AsyncMock()
bulk_repo.upsert_batch.return_value = []
async def fake_download(_key: str, iid: str) -> Path:
dest = tmp_path / f"{iid}.csv"
dest.write_bytes(csv_path.read_bytes())
return dest
file_storage = AsyncMock()
file_storage.download_to_temp.side_effect = fake_download
processor = ArticleImportProcessor(import_repo, error_repo, bulk_repo, file_storage)
await processor.process(import_id)
record = bulk_repo.upsert_batch.call_args[0][0][0]
assert record.category_level_1 == "Famille"
assert record.category_level_2 == "Sous"
assert record.category_level_3 is None