Peng Ding commited on
Commit
aefeb84
·
1 Parent(s): 029a377

add stats dashboard at GET / and restrict deploy-hf triggers

Browse files

- New stats module: per-endpoint counters, avg/p95 latency, rolling
deque(maxlen=1000)
- Instrument render and screenshot handlers with timing
- Add active_pages/is_browser_alive properties to BrowserManager
- New dashboard route: auto-refreshing HTML page with uptime, browser
status, request stats table
- deploy-hf.yml: trigger only on workflow_dispatch and tags

.github/workflows/deploy-hf.yml CHANGED
@@ -1,8 +1,8 @@
1
  name: Deploy HF
2
 
3
  on:
 
4
  push:
5
- branches: [master]
6
  tags: ["v*"]
7
 
8
  jobs:
 
1
  name: Deploy HF
2
 
3
  on:
4
+ workflow_dispatch:
5
  push:
 
6
  tags: ["v*"]
7
 
8
  jobs:
src/veilrender/app.py CHANGED
@@ -11,7 +11,7 @@ from veilrender._vendor.httpserver import App
11
  from veilrender.browser import browser_manager
12
  from veilrender.cdp_proxy import handle_cdp_upgrade, is_websocket_upgrade
13
  from veilrender.config import settings
14
- from veilrender.routes import health, render, screenshot
15
 
16
  logging.basicConfig(
17
  level=logging.INFO,
@@ -40,6 +40,7 @@ def create_app() -> App:
40
 
41
  # Register routes
42
  health.register(app)
 
43
  render.register(app)
44
  screenshot.register(app)
45
 
 
11
  from veilrender.browser import browser_manager
12
  from veilrender.cdp_proxy import handle_cdp_upgrade, is_websocket_upgrade
13
  from veilrender.config import settings
14
+ from veilrender.routes import dashboard, health, render, screenshot
15
 
16
  logging.basicConfig(
17
  level=logging.INFO,
 
40
 
41
  # Register routes
42
  health.register(app)
43
+ dashboard.register(app)
44
  render.register(app)
45
  screenshot.register(app)
46
 
src/veilrender/browser.py CHANGED
@@ -139,6 +139,16 @@ class BrowserManager:
139
  assert self._browser is not None
140
  return self._browser
141
 
 
 
 
 
 
 
 
 
 
 
142
  @asynccontextmanager
143
  async def get_page(
144
  self,
 
139
  assert self._browser is not None
140
  return self._browser
141
 
142
+ @property
143
+ def active_pages(self) -> int:
144
+ """Number of browser pages currently in use."""
145
+ return settings.max_concurrent - self._semaphore._value
146
+
147
+ @property
148
+ def is_browser_alive(self) -> bool:
149
+ """Whether the browser process is connected."""
150
+ return self._browser is not None and self._browser.is_connected()
151
+
152
  @asynccontextmanager
153
  async def get_page(
154
  self,
src/veilrender/routes/dashboard.py ADDED
@@ -0,0 +1,127 @@
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
+ """Dashboard endpoint — GET / stats page."""
2
+
3
+ from __future__ import annotations
4
+
5
+ from veilrender import stats
6
+ from veilrender._vendor.httpserver import App, Request, Response
7
+ from veilrender.browser import browser_manager
8
+ from veilrender.config import settings
9
+
10
+
11
+ def _stats_row(name: str, ep: stats.EndpointStats) -> str:
12
+ """Build an HTML table row for one endpoint."""
13
+ return f"""
14
+ <tr>
15
+ <td>{name}</td>
16
+ <td>{ep.requests}</td>
17
+ <td>{ep.successes}</td>
18
+ <td>{ep.failures}</td>
19
+ <td>{ep.success_rate:.1f}%</td>
20
+ <td>{ep.avg_ms:.0f} ms</td>
21
+ <td>{ep.p95_ms:.0f} ms</td>
22
+ </tr>"""
23
+
24
+
25
+ def _build_html() -> str:
26
+ """Build the dashboard HTML."""
27
+ browser_status = "🟢 alive" if browser_manager.is_browser_alive else "🔴 dead"
28
+ active = browser_manager.active_pages
29
+ max_conc = settings.max_concurrent
30
+
31
+ total_req = stats.render.requests + stats.screenshot.requests
32
+ total_ok = stats.render.successes + stats.screenshot.successes
33
+ total_fail = stats.render.failures + stats.screenshot.failures
34
+
35
+ return f"""<!DOCTYPE html>
36
+ <html lang="en">
37
+ <head>
38
+ <meta charset="utf-8">
39
+ <meta name="viewport" content="width=device-width, initial-scale=1">
40
+ <meta http-equiv="refresh" content="5">
41
+ <title>VeilRender Dashboard</title>
42
+ <style>
43
+ * {{ margin: 0; padding: 0; box-sizing: border-box; }}
44
+ body {{ font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", sans-serif;
45
+ background: #0f172a; color: #e2e8f0; padding: 2rem; }}
46
+ h1 {{ font-size: 1.5rem; margin-bottom: 1.5rem; color: #f8fafc; }}
47
+ .grid {{ display: grid; grid-template-columns: repeat(auto-fit, minmax(180px, 1fr));
48
+ gap: 1rem; margin-bottom: 2rem; }}
49
+ .card {{ background: #1e293b; border-radius: 8px; padding: 1.2rem; }}
50
+ .card .label {{ font-size: 0.75rem; text-transform: uppercase; letter-spacing: 0.05em;
51
+ color: #94a3b8; margin-bottom: 0.3rem; }}
52
+ .card .value {{ font-size: 1.5rem; font-weight: 600; }}
53
+ .green {{ color: #4ade80; }}
54
+ .red {{ color: #f87171; }}
55
+ .blue {{ color: #60a5fa; }}
56
+ table {{ width: 100%; border-collapse: collapse; background: #1e293b;
57
+ border-radius: 8px; overflow: hidden; }}
58
+ th, td {{ padding: 0.75rem 1rem; text-align: left; }}
59
+ th {{ background: #334155; font-size: 0.75rem; text-transform: uppercase;
60
+ letter-spacing: 0.05em; color: #94a3b8; }}
61
+ td {{ border-top: 1px solid #334155; }}
62
+ .footer {{ margin-top: 2rem; font-size: 0.75rem; color: #64748b; }}
63
+ </style>
64
+ </head>
65
+ <body>
66
+ <h1>👻 VeilRender Dashboard</h1>
67
+
68
+ <div class="grid">
69
+ <div class="card">
70
+ <div class="label">Uptime</div>
71
+ <div class="value">{stats.format_uptime()}</div>
72
+ </div>
73
+ <div class="card">
74
+ <div class="label">Browser</div>
75
+ <div class="value">{browser_status}</div>
76
+ </div>
77
+ <div class="card">
78
+ <div class="label">Active Pages</div>
79
+ <div class="value blue">{active} / {max_conc}</div>
80
+ </div>
81
+ <div class="card">
82
+ <div class="label">Total Requests</div>
83
+ <div class="value">{total_req}</div>
84
+ </div>
85
+ <div class="card">
86
+ <div class="label">Successes</div>
87
+ <div class="value green">{total_ok}</div>
88
+ </div>
89
+ <div class="card">
90
+ <div class="label">Failures</div>
91
+ <div class="value red">{total_fail}</div>
92
+ </div>
93
+ </div>
94
+
95
+ <table>
96
+ <thead>
97
+ <tr>
98
+ <th>Endpoint</th>
99
+ <th>Requests</th>
100
+ <th>Success</th>
101
+ <th>Failure</th>
102
+ <th>Rate</th>
103
+ <th>Avg Latency</th>
104
+ <th>P95 Latency</th>
105
+ </tr>
106
+ </thead>
107
+ <tbody>
108
+ {_stats_row("/render", stats.render)}
109
+ {_stats_row("/screenshot", stats.screenshot)}
110
+ </tbody>
111
+ </table>
112
+
113
+ <div class="footer">Auto-refreshes every 5 seconds &middot; Stats are in-memory and reset on restart</div>
114
+ </body>
115
+ </html>"""
116
+
117
+
118
+ def register(app: App) -> None:
119
+ """Register dashboard route on the app."""
120
+
121
+ @app.get("/")
122
+ async def dashboard(request: Request) -> Response:
123
+ return Response(
124
+ body=_build_html(),
125
+ status_code=200,
126
+ content_type="text/html; charset=utf-8",
127
+ )
src/veilrender/routes/health.py CHANGED
@@ -11,7 +11,3 @@ def register(app: App) -> None:
11
  @app.get("/health")
12
  async def health(request: Request) -> JSONResponse:
13
  return JSONResponse({"status": "ok"})
14
-
15
- @app.get("/")
16
- async def root(request: Request) -> JSONResponse:
17
- return JSONResponse({"service": "veilrender", "status": "ok"})
 
11
  @app.get("/health")
12
  async def health(request: Request) -> JSONResponse:
13
  return JSONResponse({"status": "ok"})
 
 
 
 
src/veilrender/routes/render.py CHANGED
@@ -4,10 +4,12 @@ from __future__ import annotations
4
 
5
  import logging
6
  import re
 
7
 
8
  from veilrender._vendor.httpserver import App, JSONResponse, Request
9
  from veilrender._vendor.readability import extract as readability_extract
10
  from veilrender._vendor.soup import Soup
 
11
  from veilrender.auth import verify_token
12
  from veilrender.browser import browser_manager
13
  from veilrender.config import settings
@@ -70,6 +72,8 @@ def register(app: App) -> None:
70
 
71
  req = RenderRequest.from_dict(data)
72
  timeout = req.timeout or settings.timeout
 
 
73
 
74
  try:
75
  async with browser_manager.get_page() as (ctx, page):
@@ -83,6 +87,8 @@ def register(app: App) -> None:
83
  final_url = page.url
84
  html = await page.content()
85
  except Exception as exc:
 
 
86
  logger.error("Render failed for %s: %s", req.url, exc)
87
  return JSONResponse(
88
  {"error": f"Render failed: {exc!s}"},
@@ -119,4 +125,6 @@ def register(app: App) -> None:
119
  links=links,
120
  )
121
 
 
 
122
  return JSONResponse(result.to_dict())
 
4
 
5
  import logging
6
  import re
7
+ import time
8
 
9
  from veilrender._vendor.httpserver import App, JSONResponse, Request
10
  from veilrender._vendor.readability import extract as readability_extract
11
  from veilrender._vendor.soup import Soup
12
+ from veilrender import stats
13
  from veilrender.auth import verify_token
14
  from veilrender.browser import browser_manager
15
  from veilrender.config import settings
 
72
 
73
  req = RenderRequest.from_dict(data)
74
  timeout = req.timeout or settings.timeout
75
+ stats.render.requests += 1
76
+ t0 = time.monotonic()
77
 
78
  try:
79
  async with browser_manager.get_page() as (ctx, page):
 
87
  final_url = page.url
88
  html = await page.content()
89
  except Exception as exc:
90
+ elapsed = (time.monotonic() - t0) * 1000
91
+ stats.render.record_failure(elapsed)
92
  logger.error("Render failed for %s: %s", req.url, exc)
93
  return JSONResponse(
94
  {"error": f"Render failed: {exc!s}"},
 
125
  links=links,
126
  )
127
 
128
+ elapsed = (time.monotonic() - t0) * 1000
129
+ stats.render.record_success(elapsed)
130
  return JSONResponse(result.to_dict())
src/veilrender/routes/screenshot.py CHANGED
@@ -3,8 +3,10 @@
3
  from __future__ import annotations
4
 
5
  import logging
 
6
 
7
  from veilrender._vendor.httpserver import App, Request, Response
 
8
  from veilrender.auth import verify_token
9
  from veilrender.browser import browser_manager
10
  from veilrender.config import settings
@@ -38,6 +40,8 @@ def register(app: App) -> None:
38
 
39
  req = ScreenshotRequest.from_dict(data)
40
  timeout = req.timeout or settings.timeout
 
 
41
 
42
  try:
43
  async with browser_manager.get_page(
@@ -51,6 +55,8 @@ def register(app: App) -> None:
51
  )
52
  png_bytes = await page.screenshot(full_page=req.full_page)
53
  except Exception as exc:
 
 
54
  logger.error("Screenshot failed for %s: %s", req.url, exc)
55
  return Response(
56
  body=f'{{"error": "Screenshot failed: {exc!s}"}}'.encode(),
@@ -58,6 +64,8 @@ def register(app: App) -> None:
58
  content_type="application/json",
59
  )
60
 
 
 
61
  return Response(
62
  body=png_bytes,
63
  status_code=200,
 
3
  from __future__ import annotations
4
 
5
  import logging
6
+ import time
7
 
8
  from veilrender._vendor.httpserver import App, Request, Response
9
+ from veilrender import stats
10
  from veilrender.auth import verify_token
11
  from veilrender.browser import browser_manager
12
  from veilrender.config import settings
 
40
 
41
  req = ScreenshotRequest.from_dict(data)
42
  timeout = req.timeout or settings.timeout
43
+ stats.screenshot.requests += 1
44
+ t0 = time.monotonic()
45
 
46
  try:
47
  async with browser_manager.get_page(
 
55
  )
56
  png_bytes = await page.screenshot(full_page=req.full_page)
57
  except Exception as exc:
58
+ elapsed = (time.monotonic() - t0) * 1000
59
+ stats.screenshot.record_failure(elapsed)
60
  logger.error("Screenshot failed for %s: %s", req.url, exc)
61
  return Response(
62
  body=f'{{"error": "Screenshot failed: {exc!s}"}}'.encode(),
 
64
  content_type="application/json",
65
  )
66
 
67
+ elapsed = (time.monotonic() - t0) * 1000
68
+ stats.screenshot.record_success(elapsed)
69
  return Response(
70
  body=png_bytes,
71
  status_code=200,
src/veilrender/stats.py ADDED
@@ -0,0 +1,83 @@
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
+ """In-memory request statistics.
2
+
3
+ All counters are safe to mutate without locks because asyncio
4
+ is single-threaded cooperative multitasking.
5
+ """
6
+
7
+ from __future__ import annotations
8
+
9
+ import time
10
+ from collections import deque
11
+ from dataclasses import dataclass, field
12
+
13
+ _start_time: float = time.monotonic()
14
+
15
+
16
+ @dataclass
17
+ class EndpointStats:
18
+ """Per-endpoint request counters and latency tracking."""
19
+
20
+ requests: int = 0
21
+ successes: int = 0
22
+ failures: int = 0
23
+ total_ms: float = 0.0
24
+ _latencies: deque[float] = field(default_factory=lambda: deque(maxlen=1000))
25
+
26
+ def record_success(self, elapsed_ms: float) -> None:
27
+ """Record a successful request."""
28
+ self.successes += 1
29
+ self.total_ms += elapsed_ms
30
+ self._latencies.append(elapsed_ms)
31
+
32
+ def record_failure(self, elapsed_ms: float) -> None:
33
+ """Record a failed request."""
34
+ self.failures += 1
35
+ self.total_ms += elapsed_ms
36
+ self._latencies.append(elapsed_ms)
37
+
38
+ @property
39
+ def avg_ms(self) -> float:
40
+ """Average latency in milliseconds."""
41
+ total = self.successes + self.failures
42
+ return self.total_ms / total if total > 0 else 0.0
43
+
44
+ @property
45
+ def p95_ms(self) -> float:
46
+ """95th percentile latency in milliseconds."""
47
+ if not self._latencies:
48
+ return 0.0
49
+ sorted_lat = sorted(self._latencies)
50
+ idx = int(len(sorted_lat) * 0.95)
51
+ return sorted_lat[min(idx, len(sorted_lat) - 1)]
52
+
53
+ @property
54
+ def success_rate(self) -> float:
55
+ """Success rate as a percentage."""
56
+ total = self.successes + self.failures
57
+ return (self.successes / total * 100) if total > 0 else 0.0
58
+
59
+
60
+ render = EndpointStats()
61
+ screenshot = EndpointStats()
62
+
63
+
64
+ def uptime_seconds() -> float:
65
+ """Seconds since the process started."""
66
+ return time.monotonic() - _start_time
67
+
68
+
69
+ def format_uptime() -> str:
70
+ """Human-readable uptime string."""
71
+ secs = int(uptime_seconds())
72
+ days, secs = divmod(secs, 86400)
73
+ hours, secs = divmod(secs, 3600)
74
+ mins, secs = divmod(secs, 60)
75
+ parts = []
76
+ if days:
77
+ parts.append(f"{days}d")
78
+ if hours:
79
+ parts.append(f"{hours}h")
80
+ if mins:
81
+ parts.append(f"{mins}m")
82
+ parts.append(f"{secs}s")
83
+ return " ".join(parts)