Spaces:
Paused
Paused
File size: 24,924 Bytes
1d0f191 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 | """Every API endpoint must behave identically on SQLite and PostgreSQL.
The route layer was written with literal `?` placeholders, which SQLite accepts
and psycopg does not. Nothing caught it because the whole API suite ran on
SQLite, so the only backend the deployment engine actually uses had never
exercised these endpoints.
This file walks the endpoints that write through the raw-SQL paths -- session
bootstrap, batch listing, evaluation, promote, rollback -- against both
backends. It is deliberately end-to-end through the FastAPI app rather than a
unit test of the SQL, because the thing that broke was a dialect mismatch
between the SQL text and the driver, and only running the real app catches that.
Skipped for PostgreSQL when FORGESIGHT_TEST_PG is unset, so a local run still
covers SQLite rather than erroring in fixture setup.
"""
from __future__ import annotations
import os
import pytest
from forgesight.db.migrate import migrate
from forgesight.db.pool import Dialect, get_pool
from forgesight.ledger.claims import new_id
from forgesight.settings import get_settings, reset_settings
from tests.support import requires_weights
PG_DSN = os.environ.get("FORGESIGHT_TEST_PG", "").strip()
DSNS: dict[str, str] = {"sqlite": "sqlite:///./data/test_api_dialects.db"}
if PG_DSN:
DSNS["postgres"] = PG_DSN
pytestmark = pytest.mark.integration
@pytest.fixture(params=list(DSNS))
def backend(request):
"""The backend *name*, so call sites branch on it and look up the DSN."""
return request.param
@pytest.fixture(scope="session")
def pg_pool():
"""One migrated PostgreSQL schema for the session; truncated between tests."""
if "postgres" not in DSNS:
pytest.skip("FORGESIGHT_TEST_PG not set")
pool = get_pool(DSNS["postgres"])
with pool.write() as conn:
conn.executescript("DROP SCHEMA public CASCADE; CREATE SCHEMA public;")
migrate(pool, verbose=False)
yield pool
pool.close()
def _truncate(pool) -> None:
"""Empty the data tables, keeping the schema and its migration record.
See tests/integration/test_ledger.py for why `schema_migration` and `counter`
are excluded: truncating them leaves tables that exist but a migration log
that says nothing has been applied, and the next migrate() fails with
DuplicateTable.
"""
keep = {"schema_migration", "counter"}
with pool.connection() as conn:
names = [
r["tablename"]
for r in conn.fetchall(
"SELECT tablename FROM pg_tables WHERE schemaname = 'public'"
)
if r["tablename"] not in keep
]
if not names:
return
with pool.write() as conn:
conn.execute(f"TRUNCATE {', '.join(names)} RESTART IDENTITY CASCADE")
@pytest.fixture
def stack(request, backend, tmp_path):
"""A migrated, empty database behind a real FastAPI app with a live token."""
if backend == "postgres":
pool = request.getfixturevalue("pg_pool")
_truncate(pool)
else:
pool = get_pool(f"sqlite:///{tmp_path / 'api.db'}")
migrate(pool, verbose=False)
s = get_settings().model_copy(
update={"data_dir": tmp_path / "data",
"database_url": f"sqlite:///{tmp_path / 'api.db'}"
if backend == "sqlite" else DSNS["postgres"]}
)
s.ensure_dirs()
from forgesight.settings import configure
configure(s)
import forgesight.api.deps as deps
deps.set_pool(pool)
from forgesight.api.app import create_app
from forgesight.api.deps import hash_token
from forgesight.api.repo import WorkspaceRepo
repo = WorkspaceRepo(pool)
ws = repo.create_workspace("dialects")
repo.add_token(ws, hash_token("tok"), "owner", 24)
from fastapi.testclient import TestClient
client = TestClient(create_app())
client.headers["Authorization"] = "Bearer tok"
yield client, pool, repo, ws
if backend != "postgres":
pool.close()
reset_settings()
@requires_weights
def test_session_bootstrap_seeds_a_usable_workspace_on_every_backend(stack):
"""POST /sessions registers the built-in candidates and an active release.
Each call creates its own workspace and mints its own token, so the point is
not idempotency but that the raw-SQL seed path -- artifact lookup, candidate
insert, release insert, channel update -- completes on both backends. A fresh
workspace with no active release would refuse every upload, so this is the
"a new session is immediately usable" property.
Needs weights: the seed registers whatever is in the candidate registry, and
the registry is empty until the models are fetched. Without weights
POST /sessions correctly returns 503 instead, which
test_session_bootstrap_refuses_when_no_models_are_registered covers.
"""
client, _pool, _repo, _ws = stack
first = client.post("/v1/sessions", json={"kind": "personal"})
assert first.status_code == 201, first.text
body = first.json()
assert body["token"], body
# The seed must have produced candidates and an active release.
auth = {"Authorization": "Bearer " + body["token"]}
listed = client.get("/v1/candidates", headers=auth)
assert listed.status_code == 200, listed.text
assert listed.json(), "session seed registered no candidates"
rel = client.get("/v1/releases", headers=auth)
assert rel.status_code == 200, rel.text
assert rel.json()["active_release_id"], "session seed left no active release"
def test_empty_batch_list_returns_200_on_every_backend(stack):
"""GET /batches hits a raw-SQL path with a literal placeholder."""
client, _pool, _repo, _ws = stack
r = client.get("/v1/batches")
assert r.status_code == 200, r.text
assert r.json()["items"] == []
def test_candidates_list_is_workspace_scoped_on_every_backend(stack):
"""GET /candidates returns only this workspace's candidates."""
client, _pool, _repo, ws = stack
r = client.get("/v1/candidates")
assert r.status_code == 200, r.text
for c in r.json():
assert c["workspace_id"] == ws
def test_system_status_reports_queues_on_every_backend(stack):
client, _pool, _repo, _ws = stack
r = client.get("/v1/system/status")
assert r.status_code == 200, r.text
body = r.json()
assert "queues" in body or "queue_depth" in body or "depth" in body, body
def test_candidate_create_rejects_unknown_profiles_on_every_backend(stack):
"""The three-way artifact/profile lookup runs on both backends.
These are literal-`?` statements (routes_reports.py) and they must 422 on an
unknown hash rather than create a row. The point is the lookup works on both
dialects; the 422 is the cheap observable that it ran and found nothing.
"""
client, _pool, _repo, _ws = stack
r = client.post("/v1/candidates", json={
"name": "ghost",
"artifact_sha256": "does-not-exist",
"preprocess_hash": "does-not-exist",
"runtime_hash": "does-not-exist",
"score_threshold": 0.3,
"tile_enabled": False,
})
assert r.status_code == 422, r.text
assert "artifact" in r.json()["detail"].lower(), r.text
def test_promote_rejects_a_stale_channel_version_on_every_backend(stack):
"""The optimistic channel-version check runs on both backends.
A promote whose expected version does not match the current one must be
refused, and the refusal is the optimistic-concurrency write
(routes_releases.py) -- literal `?` on both backends.
"""
client, _pool, _repo, _ws = stack
r = client.post("/v1/releases/promote", json={
"candidate_name": "does-not-exist",
"evaluation_id": "does-not-exist",
"expected_channel_version": 999,
"reason": "dialect smoke test",
})
# No such evaluation -> refused (404 or 422), never a 500 from bad SQL.
assert r.status_code in (404, 422), (r.status_code, r.text)
assert "psycopg" not in r.text and "placeholders" not in r.text, r.text
def test_placeholders_match_the_active_dialect(stack):
"""The regression that motivated this file, asserted directly.
A psycopg connection given a `?` placeholder does not silently do the wrong
thing -- it raises. So a 500 from any endpoint that writes through raw SQL is
the symptom. Here we assert the dialect's own placeholder is what the pool
advertises, and that a direct raw-SQL round-trip through the pool works, so
the failure mode is a clear error rather than a mysterious 500.
"""
_client, pool, _repo, _ws = stack
from forgesight.db.pool import ph
expected = "?" if pool.dialect is Dialect.SQLITE else "%s"
assert ph(pool.dialect) == expected
# A direct round-trip using the dialect's placeholder must succeed.
with pool.connection() as conn:
conn.execute(f"SELECT {ph(pool.dialect)} AS probe", ("x",))
row = conn.fetchone(f"SELECT {ph(pool.dialect)} AS probe", ("x",))
assert row["probe"] == "x"
# -- the translation itself, independent of any database ---------------------
def test_portable_placeholders_are_rewritten_for_postgres():
from forgesight.db.pool import to_postgres_placeholders as tx
assert tx("SELECT * FROM t WHERE a = ? AND b = ?") == (
"SELECT * FROM t WHERE a = %s AND b = %s"
)
# already-correct SQL must pass through untouched
assert tx("SELECT %s, %s") == "SELECT %s, %s"
assert tx("SELECT 1") == "SELECT 1"
def test_a_question_mark_inside_a_literal_is_not_rewritten():
from forgesight.db.pool import to_postgres_placeholders as tx
assert tx("SELECT 'why?' AS q") == "SELECT 'why?' AS q"
assert tx("SELECT ? AS v") == "SELECT %s AS v"
# an escaped quote inside a literal must not end the literal early
assert tx("SELECT 'it''s ok?' , ?") == "SELECT 'it''s ok?' , %s"
def test_macos_appledouble_sidecars_are_ignored(tmp_path, monkeypatch):
"""A `._foo.sql` sidecar must not be treated as a migration.
macOS writes AppleDouble sidecars on any non-HFS filesystem -- a Docker bind
mount, a network share, an extracted tar. They match `*.sql`, sort before the
real migration, and are binary, so an unfiltered glob made the API fail to
start with a UnicodeDecodeError raised from inside migrate().
"""
import forgesight.db.migrate as mig
d = tmp_path / "migrations"
d.mkdir()
(d / "0001_init.sql").write_text("SELECT 1;")
(d / "._0001_init.sql").write_bytes(b"\x00\x05\x16\x07\xa3\x01\x00\x00binary")
(d / ".DS_Store").write_bytes(b"\x00binary")
monkeypatch.setattr(mig, "MIGRATIONS_DIR", d)
names = [p.name for p in mig._migration_files()]
assert names == ["0001_init.sql"], names
def test_a_misnamed_migration_fails_loudly(tmp_path, monkeypatch):
"""A migration that is neither hidden nor numbered is a typo, not a skip.
Silently ignoring it would leave the schema half-applied, which is worse than
refusing to start.
"""
import forgesight.db.migrate as mig
d = tmp_path / "migrations"
d.mkdir()
(d / "0001_init.sql").write_text("SELECT 1;")
(d / "add_column.sql").write_text("SELECT 1;")
monkeypatch.setattr(mig, "MIGRATIONS_DIR", d)
with pytest.raises(ValueError, match="numbered migration"):
mig._migration_files()
def test_api_routes_are_not_shadowed_by_the_spa_catch_all(stack, monkeypatch):
"""`/healthz` and `/v1/system/info` must answer JSON, not index.html.
`_mount_web` registers a catch-all `/{path:path}`, and Starlette matches in
registration order. When the SPA was mounted before these two, the catch-all
won and they returned index.html -- with HTTP 200, so a load balancer health
check would report the container healthy while handing back HTML instead of
JSON. Nothing local noticed because 200 is 200.
Asserted two ways: on the real response body, and on route order, so a future
move of _mount_web cannot silently reintroduce the shadowing.
"""
client, _pool, _repo, _ws = stack
for path in ("/healthz", "/v1/system/info"):
r = client.get(path)
assert r.status_code == 200, (path, r.status_code)
assert r.headers["content-type"].startswith("application/json"), (
f"{path} returned {r.headers['content-type']}, not JSON"
)
assert r.json(), f"{path} returned no JSON body"
assert "<!doctype html>" not in r.text, f"{path} returned the SPA shell"
order = [
getattr(r, "path", None)
for r in client.app.routes
]
if "/{path:path}" not in order:
# No web build, so no catch-all exists and there is nothing to shadow.
# The JSON assertions above still ran, and are the part that matters.
return
catch_all = order.index("/{path:path}")
for path in ("/healthz", "/v1/system/info"):
assert order.index(path) < catch_all, (
f"{path} is registered after the SPA catch-all and will be shadowed"
)
def test_session_bootstrap_refuses_when_no_models_are_registered(tmp_path, monkeypatch):
"""A session must not be minted for a workspace that cannot do anything.
With no model artifacts the registry is empty, so the seed creates a
workspace with no candidates and no active release -- every upload is then
refused, and the caller holds a valid token with no explanation. So the
request is refused instead, *before* anything is written, and the message
names the directories to populate.
"""
from fastapi.testclient import TestClient
from forgesight.api.app import create_app
from forgesight.db.migrate import migrate
from forgesight.db.pool import get_pool
from forgesight.settings import configure, get_settings
missing = tmp_path / "absent"
s = get_settings().model_copy(update={
"data_dir": tmp_path / "data",
"database_url": f"sqlite:///{tmp_path / 'n.db'}",
"models_dir": missing / "models",
"artifacts_dir": missing / "artifacts",
})
s.ensure_dirs()
configure(s)
import forgesight.api.deps as deps
pool = get_pool(s.database_url)
migrate(pool, verbose=False)
deps.set_pool(pool)
client = TestClient(create_app())
r = client.post("/v1/sessions", json={"kind": "local"})
assert r.status_code == 503, r.text
assert "no model artifacts" in r.json()["detail"], r.text
# Names the directory so the fix is actionable, not just a refusal.
assert str(missing) in r.json()["detail"], r.text
# Nothing may be left behind: no orphan workspace, no orphan token.
with pool.connection() as conn:
assert conn.fetchone("SELECT COUNT(*) AS n FROM workspace")["n"] == 0
assert conn.fetchone("SELECT COUNT(*) AS n FROM api_token")["n"] == 0
pool.close()
from forgesight.settings import reset_settings
reset_settings()
# -- the shadow diff view ----------------------------------------------------
def _register_two_candidates(repo, ws):
"""Register every candidate the registry can build, and return their ids.
Returns () when the weights are absent, so the caller can skip rather than
assert on an empty registry.
"""
from forgesight.settings import get_settings
from forgesight.vision.registry import registry
class _Row:
def __init__(self, i):
self.id = i
ids = []
for bc in registry(get_settings()):
if repo.find_candidate_by_hash(ws, bc.candidate.hash):
ids.append(repo.list_candidates(ws)[0]["id"])
continue
pp, rt = repo.profiles_for(ws, bc.candidate.artifact, bc.candidate)
with repo.pool.connection() as conn:
art = conn.fetchone(
f"SELECT id FROM model_artifact WHERE workspace_id = {repo.ph} "
f"AND sha256 = {repo.ph}",
(ws, bc.candidate.artifact.sha256))
repo.insert_candidate(
ws, bc.name, bc.candidate.hash, _Row(art["id"]), pp, rt,
bc.candidate.score_threshold, bc.candidate.label_map_hash,
bc.candidate.tile_enabled)
found = next(c for c in repo.list_candidates(ws)
if c["candidate_hash"] == bc.candidate.hash)
ids.append(found["id"])
return tuple(ids[:2])
def _seed_release(repo, ws: str, candidate_id: str) -> str:
"""Give the workspace an active release, which an upload requires."""
channel = repo.ensure_channel(ws)
release_id = new_id("rel")
ph = "?" if repo.pool.dialect is Dialect.SQLITE else "%s"
with repo.pool.write() as conn:
conn.execute(
f"INSERT INTO release(id, workspace_id, channel_id, candidate_id, "
f"action, reason, actor, channel_version) "
f"VALUES ({','.join([ph] * 8)})",
(release_id, ws, channel, candidate_id, "seed", "test fixture",
"test", 1))
conn.execute(
f"UPDATE channel SET active_release_id = {ph}, version = 1 WHERE id = {ph}",
(release_id, channel))
return release_id
@pytest.mark.model
def test_a_shadowed_page_reports_its_shadow_result(stack):
"""Regression: `has_shadow` was permanently false, so the diff view never rendered.
The shadow join read `sr.work_item_id = w.id AND sr.candidate_id <> w.candidate_id`.
A work item is created one per (page, candidate) pair, so the shadow
candidate's prediction lives on a *different* work item sharing `page_id`.
That predicate could never be true -- verified against a seeded database, the
old join matched 0 rows where the page-based join matches every shadowed page.
The consequence was not a crash. `ItemOut.diff` was simply always None, and
design section 18 beat 4 ("the diff view shows added, missing and relabeled
boxes") rendered an empty panel. That reads as "no difference found" rather
than as a bug, which is why nothing caught it.
"""
from forgesight.api.repo import WorkspaceRepo
from forgesight.ledger.claims import Ledger, PredictionIn
from forgesight.vision.types import Detection
client, pool, _repo, ws = stack
repo = WorkspaceRepo(pool)
pair = _register_two_candidates(repo, ws)
if len(pair) < 2:
pytest.skip("need at least two registered candidates")
primary, shadow = pair
# batch.release_id has a composite FK to release(workspace_id, id), so a real
# release row is required. ensure_channel returns the *channel*, not a
# release, which is an easy confusion and produced a foreign-key violation.
channel = repo.ensure_channel(ws)
release_id = new_id("rel")
ph = "?" if pool.dialect is Dialect.SQLITE else "%s"
with pool.write() as conn:
conn.execute(
f"INSERT INTO release(id, workspace_id, channel_id, candidate_id, "
f"action, reason, actor, channel_version) "
f"VALUES ({','.join([ph] * 8)})",
(release_id, ws, channel, primary, "seed", "diff regression",
"test", 1))
asset, page, batch = new_id("as"), new_id("pg"), new_id("b")
with pool.write() as conn:
conn.execute(
f"INSERT INTO batch(id, workspace_id, release_id, shadow_candidate_id, "
f"total_items, synthetic) VALUES ({','.join([ph] * 6)})",
(batch, ws, release_id, shadow, 2, True))
conn.execute(
f"INSERT INTO asset(id, workspace_id, sha256, byte_size, media_type, "
f"object_key, page_count, provenance, synthetic) "
f"VALUES ({','.join([ph] * 9)})",
(asset, ws, "diff-sha", 10, "image/png", "k", 1, "synthetic:test", True))
# page carries no `synthetic` column; the flag lives on asset and batch.
conn.execute(
f"INSERT INTO page(id, workspace_id, asset_id, page_index, width_px, "
f"height_px, render_dpi, object_key) VALUES ({','.join([ph] * 8)})",
(page, ws, asset, 0, 100, 100, 150, "k"))
# work_item carries pool and role, not the artifact/profile columns --
# those live on candidate. `role` is what distinguishes a shadow row.
for cid, role, pool_name in ((primary, "primary", "torch"),
(shadow, "shadow", "onnxruntime")):
conn.execute(
f"INSERT INTO work_item(id, workspace_id, batch_id, page_id, "
f"candidate_id, pool, role) VALUES ({','.join([ph] * 7)})",
(new_id("wi"), ws, batch, page, cid, pool_name, role))
det = PredictionIn([Detection(class_id=0, label="text", score=0.9,
box=(0.1, 0.1, 0.5, 0.5))])
# Both pools: the shadow item is pinned to onnxruntime, and claim() is
# pool-scoped, so claiming only "torch" leaves the shadow unpredicted and the
# diff empty for a reason that has nothing to do with the join under test.
ledger = Ledger(pool)
for pool_name in ("torch", "onnxruntime"):
for it in ledger.claim(pool_name, "w", n=8, lease_s=60):
ledger.complete(it, det)
# Asserted on `shadow_detections`, not the SQL helper column `has_shadow`:
# ItemOut has no such field, so reading it tests the response shape rather
# than the join.
items = client.get(f"/v1/batches/{batch}/items").json()
assert items, "no items returned for the seeded batch"
primary_items = [i for i in items if i["role"] == "primary"]
assert primary_items, "the primary item is missing from the batch listing"
shadowed = [i for i in primary_items if i["shadow_detections"]]
assert shadowed, (
"the primary item has no shadow_detections; the diff view renders empty"
)
assert shadowed[0]["diff"], "both sides have boxes, so a diff must be computed"
detail = client.get(f"/v1/items/{shadowed[0]['id']}").json()
assert detail["shadow_detections"], "single-item fetch also lost the shadow"
def test_an_upload_can_declare_its_pages_synthetic(stack):
"""The `synthetic` flag had no way to become true.
`_stage` hardcoded `synthetic = False`, and the batch-level rollup is
`all(x["synthetic"])`, so `asset.synthetic` and `batch.synthetic` were
permanently FALSE for every upload. That is not cosmetic: the flag is what
the rest of the system reads to label data, and this repository's own demo
pages are generated by `forgesight/synth`. Verified before the fix on a
seeded database: `SELECT DISTINCT synthetic FROM asset` returned `[False]`
and provenance was `upload:page00-...` rather than a synthetic marker.
The API receives opaque bytes and cannot verify origin, so this records the
uploader's declaration rather than pretending to check it. The test asserts
the declaration is stored, and that omitting it still defaults to false, so
an unlabelled upload cannot be mistaken for a labelled one.
"""
import io as _io
from PIL import Image
from forgesight.synth.generator import generate_page
client, pool, repo, ws = stack
client.headers["Authorization"] = "Bearer tok"
pair = _register_two_candidates(repo, ws)
if len(pair) < 2:
pytest.skip("need at least two registered candidates")
_seed_release(repo, ws, pair[0])
def png(seed: int) -> bytes:
page = generate_page(template="two_column", seed=seed, dpi=150)["image"]
buf = _io.BytesIO()
Image.fromarray(page).save(buf, format="PNG")
return buf.getvalue()
# Declared synthetic.
r = client.post("/v1/batches", files=[("files", ("s.png", png(1), "image/png"))],
data={"synthetic": "true"})
assert r.status_code == 202, r.text
batch_id = r.json()["id"]
assert client.get(f"/v1/batches/{batch_id}").json()["synthetic"] is True
ph = "?" if pool.dialect is Dialect.SQLITE else "%s"
with pool.connection() as conn:
declared = conn.fetchall(
f"SELECT synthetic, provenance FROM asset WHERE workspace_id = {ph} "
f"AND provenance LIKE {ph} ORDER BY created_at DESC", (ws, "synthetic-upload%"))
plain = conn.fetchall(
f"SELECT synthetic FROM asset WHERE workspace_id = {ph} "
f"AND provenance LIKE {ph}", (ws, "upload:%"))
assert declared, "no asset recorded a synthetic provenance"
assert all(bool(r["synthetic"]) for r in declared), declared
# Every asset, declared or not, is accounted for -- so the assertion above
# cannot pass by only ever seeing the one row it created.
assert len(declared) + len(plain) >= 1
# Not declared: still false, so an unlabelled upload is never mistaken for
# a labelled one.
r2 = client.post("/v1/batches", files=[("files", ("r.png", png(2), "image/png"))])
assert r2.status_code == 202, r2.text
assert client.get(f"/v1/batches/{r2.json()['id']}").json()["synthetic"] is False
|