Spaces:
Sleeping
Sleeping
Commit ·
80b86bb
1
Parent(s): 255cd61
claim(repository-convergence): startup invocation retirement
Browse files
workpackage_claims/SCRUB-WP_REPOSITORY_CONVERGENCE_STARTUP_INVOCATION_RETIREMENT.md
ADDED
|
@@ -0,0 +1,53 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Workpackage claim — SCRUB-WP_REPOSITORY_CONVERGENCE_STARTUP_INVOCATION_RETIREMENT
|
| 2 |
+
|
| 3 |
+
Status: implementation in progress
|
| 4 |
+
Role: `implementation_operations`
|
| 5 |
+
Issue: #115
|
| 6 |
+
Branch: `wp/repository-convergence-startup-invocation-retirement`
|
| 7 |
+
Starting main: `255cd619d5cf6eab32f9383940eaa4af362cb68c`
|
| 8 |
+
Started: 2026-09-05 Europe/Amsterdam
|
| 9 |
+
|
| 10 |
+
## Objective
|
| 11 |
+
|
| 12 |
+
Remove the obsolete Docker pre-start invocation of the two legacy Streamlit source-patch scripts after source inspection proved that both scripts exit without mutating the current direct-source application.
|
| 13 |
+
|
| 14 |
+
## Evidence before implementation
|
| 15 |
+
|
| 16 |
+
Current `presidio_streamlit.py` directly imports:
|
| 17 |
+
|
| 18 |
+
- `premium_streamlit_shell_ui`, which causes `fix_streamlit_nested_expanders.py` to exit immediately;
|
| 19 |
+
- `render_reinsert_mode` from `reinsert_mode_ui`, which causes `fix_streamlit_pdf_text_reinsert.py` to exit immediately.
|
| 20 |
+
|
| 21 |
+
Current Docker startup nevertheless executes both scripts before launching Streamlit.
|
| 22 |
+
|
| 23 |
+
This creates a live runtime dependency on historical mutation machinery even though current product behavior is already direct source.
|
| 24 |
+
|
| 25 |
+
## Scope
|
| 26 |
+
|
| 27 |
+
Authorized:
|
| 28 |
+
|
| 29 |
+
- change the Docker `CMD` so Streamlit launches directly with all existing port/address/XSRF/CORS flags preserved;
|
| 30 |
+
- update only test assertions that specifically require the obsolete startup invocation;
|
| 31 |
+
- add a narrow current-runtime contract if needed;
|
| 32 |
+
- align `WORKPACKAGES.md`, `CHANGELOG.md` and the temporary convergence debt ledger;
|
| 33 |
+
- write the mandatory handover.
|
| 34 |
+
|
| 35 |
+
Not authorized:
|
| 36 |
+
|
| 37 |
+
- changing `presidio_streamlit.py` product/UI behavior;
|
| 38 |
+
- changing recognizers, profiles, review/export/Scrub Key/reinsert semantics;
|
| 39 |
+
- removing persistent replacement memory or external AI paths;
|
| 40 |
+
- changing unrelated Docker hardening/security settings;
|
| 41 |
+
- deleting the historical patch scripts in this workpackage;
|
| 42 |
+
- mass-retiring historical `*_ui_patch.py` tests.
|
| 43 |
+
|
| 44 |
+
## Acceptance
|
| 45 |
+
|
| 46 |
+
1. Docker starts `presidio_streamlit.py` directly through Streamlit.
|
| 47 |
+
2. Neither `fix_streamlit_nested_expanders.py` nor `fix_streamlit_pdf_text_reinsert.py` is invoked at runtime startup.
|
| 48 |
+
3. Existing Streamlit port/address/XSRF/CORS flags remain unchanged.
|
| 49 |
+
4. Tests protect current direct-source behavior rather than requiring the obsolete invocation.
|
| 50 |
+
5. Full exact-head `python -m pytest -q tests` is green.
|
| 51 |
+
6. Changed-file scope contains no user-visible product behavior change.
|
| 52 |
+
7. Fresh independent `governance_release_assurance` returns PASS before merge.
|
| 53 |
+
8. After merge, exact-main Tests and GitHub→Hugging Face sync are verified.
|