Switch to public Google Sheet backend, add privacy warnings

- Replace service account auth with public sheet CSV reads + Apps Script writes
- No credentials needed — just a shared Google Sheet and a deployed script
- Add privacy warning on save: no real names, companies, or identifying info
- Add per-deal calculator with split deals, clawbacks, accelerator multipliers
- Support both attainment-based and deal-size commission models
- Include apps_script.js for easy Google Sheets setup

.streamlit/secrets.toml.example

@@ -1,22 +1,10 @@
-# Copy this to secrets.toml and fill in your GCP service account credentials.
-# On Streamlit Cloud, paste these values into the app's Secrets settings.
+# Copy this to secrets.toml (local) or paste into Streamlit Cloud Secrets.
 #
-# Steps:
-# 1. Go to https://console.cloud.google.com/iam-admin/serviceaccounts
-# 2. Create a service account (or use an existing one)
-# 3. Grant it "Editor" role
-# 4. Create a JSON key and paste the values below
-# 5. Enable the Google Sheets API: https://console.cloud.google.com/apis/library/sheets.googleapis.com
-# 6. Enable the Google Drive API: https://console.cloud.google.com/apis/library/drive.googleapis.com
+# 1. Create a Google Sheet with headers in row 1: name | author | timestamp | data_json
+# 2. Share it as "Anyone with the link" → Editor
+# 3. Open Extensions → Apps Script, paste the code from apps_script.js
+# 4. Deploy as Web App → Execute as Me → Anyone can access
+# 5. Fill in the URLs below
 
-[gcp_service_account]
-type = "service_account"
-project_id = ""
-private_key_id = ""
-private_key = ""
-client_email = ""
-client_id = ""
-auth_uri = "https://accounts.google.com/o/oauth2/auth"
-token_uri = "https://oauth2.googleapis.com/token"
-auth_provider_x509_cert_url = "https://www.googleapis.com/oauth2/v1/certs"
-client_x509_cert_url = ""
+sheet_url = "https://docs.google.com/spreadsheets/d/YOUR_SHEET_ID/edit"
+apps_script_url = "https://script.google.com/macros/s/YOUR_SCRIPT_ID/exec"

app.py

@@ -3,78 +3,73 @@ import json
 import datetime
 import pandas as pd
 import plotly.graph_objects as go
-import gspread
-from google.oauth2.service_account import Credentials
+import requests
 
 # ---------------------------------------------------------------------------
-# Google Sheets Backend
+# Google Sheets Backend (public sheet, no credentials)
 # ---------------------------------------------------------------------------
 
-SCOPES = [
-    "https://www.googleapis.com/auth/spreadsheets",
-    "https://www.googleapis.com/auth/drive",
-]
-SHEET_NAME = "SalesComp Scenarios"
+SHEET_CSV_TMPL = "https://docs.google.com/spreadsheets/d/{sheet_id}/gviz/tq?tqx=out:csv"
 
 
-@st.cache_resource
-def get_gsheet_client():
-    """Authenticate with Google Sheets using Streamlit secrets."""
-    creds_dict = dict(st.secrets["gcp_service_account"])
-    creds = Credentials.from_service_account_info(creds_dict, scopes=SCOPES)
-    return gspread.authorize(creds)
+def _get_sheet_id():
+    url = st.secrets.get("sheet_url", "")
+    if not url:
+        return None
+    # Extract ID from URL like https://docs.google.com/spreadsheets/d/XXXXX/edit...
+    parts = url.split("/d/")
+    if len(parts) < 2:
+        return None
+    return parts[1].split("/")[0]
 
 
-def _get_worksheet():
-    """Return the first worksheet, creating the spreadsheet if needed."""
-    gc = get_gsheet_client()
-    try:
-        sh = gc.open(SHEET_NAME)
-    except gspread.SpreadsheetNotFound:
-        sh = gc.create(SHEET_NAME)
-        sh.share(None, perm_type="anyone", role="reader")  # link-shareable
-    ws = sh.sheet1
-    # Ensure header row exists
-    if ws.row_count == 0 or ws.cell(1, 1).value != "name":
-        ws.clear()
-        ws.append_row(["name", "author", "timestamp", "data_json"])
-    return ws
+def _get_apps_script_url():
+    return st.secrets.get("apps_script_url", "")
 
 
+@st.cache_data(ttl=30)
 def load_scenarios() -> dict:
-    ws = _get_worksheet()
-    records = ws.get_all_records()
-    scenarios = {}
-    for r in records:
-        try:
-            scenarios[r["name"]] = json.loads(r["data_json"])
-        except (json.JSONDecodeError, KeyError):
-            continue
-    return scenarios
+    sheet_id = _get_sheet_id()
+    if not sheet_id:
+        return {}
+    try:
+        csv_url = SHEET_CSV_TMPL.format(sheet_id=sheet_id)
+        df = pd.read_csv(csv_url)
+        scenarios = {}
+        for _, row in df.iterrows():
+            try:
+                scenarios[row["name"]] = json.loads(row["data_json"])
+            except (json.JSONDecodeError, KeyError):
+                continue
+        return scenarios
+    except Exception:
+        return {}
 
 
 def save_scenario(name: str, data: dict):
-    ws = _get_worksheet()
-    records = ws.get_all_records()
-    row_idx = None
-    for i, r in enumerate(records):
-        if r["name"] == name:
-            row_idx = i + 2  # 1-indexed + header
-            break
-    row = [name, data.get("author", ""), data.get("timestamp", ""), json.dumps(data)]
-    if row_idx:
-        ws.update(f"A{row_idx}:D{row_idx}", [row])
-    else:
-        ws.append_row(row)
+    url = _get_apps_script_url()
+    if not url:
+        raise ValueError("Apps Script URL not configured in secrets")
+    payload = {
+        "action": "save",
+        "name": name,
+        "author": data.get("author", ""),
+        "timestamp": data.get("timestamp", ""),
+        "data_json": json.dumps(data),
+    }
+    resp = requests.post(url, json=payload, timeout=15)
+    if resp.status_code != 200:
+        raise ValueError(f"Apps Script returned {resp.status_code}")
 
 
 def delete_scenario(name: str):
-    ws = _get_worksheet()
-    records = ws.get_all_records()
-    for i, r in enumerate(records):
-        if r["name"] == name:
-            ws.delete_rows(i + 2)
-            return
+    url = _get_apps_script_url()
+    if not url:
+        raise ValueError("Apps Script URL not configured in secrets")
+    payload = {"action": "delete", "name": name}
+    resp = requests.post(url, json=payload, timeout=15)
+    if resp.status_code != 200:
+        raise ValueError(f"Apps Script returned {resp.status_code}")
 
 
 # ---------------------------------------------------------------------------
@@ -107,13 +102,11 @@ def calc_commission_deal_rate(deals, deal_rate_tiers, attainment_pct, accel_tier
     deal_rate_tiers: list of (min_acv, max_acv | None, rate_pct)
     accel_tiers: list of (upper_attainment_pct | None, multiplier)
     """
-    # Determine accelerator multiplier
     multiplier = 1.0
     for upper_pct, mult in accel_tiers:
         if upper_pct is None or attainment_pct <= upper_pct:
             multiplier = mult
             break
-    # Commission per deal
     total = 0.0
     deal_results = []
     for deal in deals:
@@ -159,6 +152,23 @@ def calc_ramp_adjusted_quota(annual_quota, ramp_pcts, months_employed=12):
 st.set_page_config(page_title="Sales Comp Calculator", layout="wide")
 st.title("Sales Compensation Calculator")
 
+# Check config
+sheet_ok = bool(_get_sheet_id())
+script_ok = bool(_get_apps_script_url())
+if not sheet_ok or not script_ok:
+    with st.expander("Setup required — click to configure", expanded=True):
+        st.warning("Add these to `.streamlit/secrets.toml` (local) or Streamlit Cloud Secrets:")
+        st.code('''sheet_url = "https://docs.google.com/spreadsheets/d/YOUR_SHEET_ID/edit"
+apps_script_url = "https://script.google.com/macros/s/YOUR_SCRIPT_ID/exec"''', language="toml")
+        st.markdown("""
+**Quick setup (5 min):**
+1. Create a Google Sheet with headers in row 1: `name | author | timestamp | data_json`
+2. Share it as **"Anyone with the link" → Editor**
+3. Open **Extensions → Apps Script**, paste the script from `apps_script.js` in this repo
+4. Deploy as **Web App** → Execute as **Me** → Access **Anyone**
+5. Copy the sheet URL and web app URL into secrets
+        """)
+
 # ---- Sidebar: Plan Parameters ----
 
 st.sidebar.header("Plan Parameters")
@@ -178,15 +188,19 @@ commission_mode = st.sidebar.radio(
     "Commission model",
     ["Attainment-based rates", "Deal-size rates + accelerators"],
     key="comm_mode",
-    help="Plan 1 style: tiered % on revenue bands. Plan 2 style: flat % per deal size with attainment multipliers.",
+    help="Plan 1: tiered % on revenue bands. Plan 2: flat % per deal size with attainment multipliers.",
 )
 
 # -- Attainment-based tiers --
+att_tiers = []
+deal_rate_tiers = []
+accel_tiers = []
+avg_rate = 0.0
+
 if commission_mode == "Attainment-based rates":
     with st.sidebar.expander("Commission Tiers (attainment)", expanded=True):
         st.caption("Marginal rates — each applies only to revenue in that band")
         num_tiers = st.number_input("Number of tiers", 1, 8, 4, key="num_tiers")
-        att_tiers = []
         att_defaults = [(100, 4.0), (125, 5.0), (150, 6.0), (None, 7.0)]
         for i in range(int(num_tiers)):
             c1, c2 = st.columns(2)
@@ -205,7 +219,6 @@ else:
     with st.sidebar.expander("Deal-Size Commission Rates", expanded=True):
         num_deal_tiers = st.number_input("Number of deal-size tiers", 1, 6, 3, key="num_deal_tiers")
         deal_defaults = [(0, 29_999, 20.0), (30_000, 100_000, 40.0), (100_001, None, 40.0)]
-        deal_rate_tiers = []
         for i in range(int(num_deal_tiers)):
             c1, c2, c3 = st.columns(3)
             d = deal_defaults[i] if i < len(deal_defaults) else (0, None, 40.0)
@@ -224,7 +237,6 @@ else:
         st.caption("Multiplier applied to deal commission based on annual attainment")
         num_accels = st.number_input("Number of accelerator tiers", 1, 6, 3, key="num_accels")
         accel_defaults = [(99, 1.0), (124, 1.3), (None, 1.5)]
-        accel_tiers = []
         for i in range(int(num_accels)):
             c1, c2 = st.columns(2)
             d = accel_defaults[i] if i < len(accel_defaults) else (None, 1.0)
@@ -278,14 +290,10 @@ with tab_scenario:
     if commission_mode == "Attainment-based rates":
         commission = calc_commission_attainment(actual_revenue, effective_quota, att_tiers)
     else:
-        # For total-revenue mode with deal-rate model, treat as single "blended" deal
-        # Real per-deal calc is in Tab 2. Here we approximate with the rate for the avg deal.
-        avg_rate = 0.0
         for mn, mx, rt in deal_rate_tiers:
             if mx is None or actual_revenue / max(1, 12) <= mx:
                 avg_rate = rt
                 break
-        # Apply accelerator
         mult = 1.0
         for upper, m in accel_tiers:
             if upper is None or attainment_pct <= upper:
@@ -354,7 +362,6 @@ with tab_scenario:
                 comm_pts.append(r * (avg_rate / 100) * m_)
         att_pts = [r / effective_quota * 100 if effective_quota > 0 else 0 for r in rev_pts]
 
-        # Total comp curve (base + draw + commission)
         total_comp_pts = [prorated_base + draw_paid + c for c in comm_pts]
 
         fig = go.Figure()
@@ -399,15 +406,23 @@ with tab_scenario:
         },
     }
 
+    st.warning(
+        "**Privacy:** Saved scenarios are stored in a shared Google Sheet. "
+        "Do NOT use real names, company names, or any identifying information "
+        "in scenario names or the 'Your name' field. Use generic labels "
+        "(e.g. 'Plan A - aggressive', 'Option 2 - conservative').",
+        icon="🔒",
+    )
     scol1, scol2 = st.columns(2)
     with scol1:
         scenario_name = st.text_input("Scenario name", key="save_name",
-                                       placeholder="e.g. 'plan-v2-jane'")
+                                       placeholder="e.g. 'plan-a-aggressive'")
         if st.button("Save Scenario", type="primary"):
             if scenario_name.strip():
                 try:
                     save_scenario(scenario_name.strip(), scenario_data)
-                    st.success(f"Saved '{scenario_name.strip()}' to Google Sheets")
+                    st.success(f"Saved '{scenario_name.strip()}'")
+                    load_scenarios.clear()
                     st.rerun()
                 except Exception as e:
                     st.error(f"Failed to save: {e}")
@@ -451,64 +466,70 @@ with tab_deals:
 
 with tab_compare:
     st.subheader("Saved Scenarios")
-    try:
-        scenarios = load_scenarios()
-    except Exception as e:
-        st.error(f"Could not load scenarios from Google Sheets: {e}")
-        st.info("Check your Google Sheets credentials in `.streamlit/secrets.toml`")
-        scenarios = {}
-
-    if scenarios:
-        col_a, col_b = st.columns(2)
-        with col_b:
-            to_delete = st.selectbox("Delete a scenario", [""] + list(scenarios.keys()), key="del_sel")
-            if st.button("Delete"):
-                if to_delete:
-                    delete_scenario(to_delete)
-                    st.success(f"Deleted '{to_delete}'")
-                    st.rerun()
 
-        selected = st.multiselect("Select scenarios to compare", list(scenarios.keys()),
-                                   default=list(scenarios.keys())[:5], key="compare_sel")
-        if selected:
-            rows = []
-            for name in selected:
-                s = scenarios[name]
-                r = s.get("results", {})
-                p = s.get("params", {})
-                inp = s.get("inputs", {})
-                rev = inp.get("actual_revenue", 0)
-                rows.append({
-                    "Scenario": name,
-                    "Author": s.get("author", ""),
-                    "Mode": s.get("commission_mode", ""),
-                    "Base": f"${p.get('base_salary', 0):,.0f}",
-                    "Quota": f"${p.get('annual_quota', 0):,.0f}",
-                    "Revenue": f"${rev:,.0f}",
-                    "Attainment": f"{r.get('attainment_pct', 0)}%",
-                    "Commission": f"${r.get('commission', 0):,.0f}",
-                    "Draw": f"${r.get('draw_paid', 0):,.0f}",
-                    "Total Comp": f"${r.get('total_comp', 0):,.0f}",
-                    "Gross Profit": f"${r.get('gross_profit', 0):,.0f}",
-                    "Net After Rep": f"${r.get('net_after_rep', 0):,.0f}",
-                    "Rep Cost % Rev": f"{r.get('total_cost_of_rep', 0) / rev * 100:.1f}%" if rev > 0 else "N/A",
-                    "ROI": f"{r.get('roi_on_rep', 0):.1f}x",
-                })
-            st.dataframe(pd.DataFrame(rows), use_container_width=True, hide_index=True)
-
-            # Side-by-side bar chart
-            fig = go.Figure()
-            for name in selected:
-                s = scenarios[name]
-                r = s.get("results", {})
-                fig.add_trace(go.Bar(
-                    name=name,
-                    x=["Commission", "Total Comp", "Gross Profit", "Net After Rep"],
-                    y=[r.get("commission", 0), r.get("total_comp", 0),
-                       r.get("gross_profit", 0), r.get("net_after_rep", 0)],
-                ))
-            fig.update_layout(barmode="group", height=400,
-                              margin=dict(l=0, r=0, t=30, b=0))
-            st.plotly_chart(fig, use_container_width=True)
+    if not sheet_ok:
+        st.warning("Configure your Google Sheet URL in secrets to enable scenario saving.")
     else:
-        st.info("No saved scenarios yet. Save one from the Scenario Calculator tab.")
+        if st.button("Refresh"):
+            load_scenarios.clear()
+            st.rerun()
+
+        scenarios = load_scenarios()
+
+        if scenarios:
+            col_a, col_b = st.columns(2)
+            with col_b:
+                to_delete = st.selectbox("Delete a scenario", [""] + list(scenarios.keys()), key="del_sel")
+                if st.button("Delete"):
+                    if to_delete:
+                        try:
+                            delete_scenario(to_delete)
+                            load_scenarios.clear()
+                            st.success(f"Deleted '{to_delete}'")
+                            st.rerun()
+                        except Exception as e:
+                            st.error(f"Failed to delete: {e}")
+
+            selected = st.multiselect("Select scenarios to compare", list(scenarios.keys()),
+                                       default=list(scenarios.keys())[:5], key="compare_sel")
+            if selected:
+                rows = []
+                for name in selected:
+                    s = scenarios[name]
+                    r = s.get("results", {})
+                    p = s.get("params", {})
+                    inp = s.get("inputs", {})
+                    rev = inp.get("actual_revenue", 0)
+                    rows.append({
+                        "Scenario": name,
+                        "Author": s.get("author", ""),
+                        "Mode": s.get("commission_mode", ""),
+                        "Base": f"${p.get('base_salary', 0):,.0f}",
+                        "Quota": f"${p.get('annual_quota', 0):,.0f}",
+                        "Revenue": f"${rev:,.0f}",
+                        "Attainment": f"{r.get('attainment_pct', 0)}%",
+                        "Commission": f"${r.get('commission', 0):,.0f}",
+                        "Draw": f"${r.get('draw_paid', 0):,.0f}",
+                        "Total Comp": f"${r.get('total_comp', 0):,.0f}",
+                        "Gross Profit": f"${r.get('gross_profit', 0):,.0f}",
+                        "Net After Rep": f"${r.get('net_after_rep', 0):,.0f}",
+                        "Rep Cost % Rev": f"{r.get('total_cost_of_rep', 0) / rev * 100:.1f}%" if rev > 0 else "N/A",
+                        "ROI": f"{r.get('roi_on_rep', 0):.1f}x",
+                    })
+                st.dataframe(pd.DataFrame(rows), use_container_width=True, hide_index=True)
+
+                fig = go.Figure()
+                for name in selected:
+                    s = scenarios[name]
+                    r = s.get("results", {})
+                    fig.add_trace(go.Bar(
+                        name=name,
+                        x=["Commission", "Total Comp", "Gross Profit", "Net After Rep"],
+                        y=[r.get("commission", 0), r.get("total_comp", 0),
+                           r.get("gross_profit", 0), r.get("net_after_rep", 0)],
+                    ))
+                fig.update_layout(barmode="group", height=400,
+                                  margin=dict(l=0, r=0, t=30, b=0))
+                st.plotly_chart(fig, use_container_width=True)
+        else:
+            st.info("No saved scenarios yet. Save one from the Scenario Calculator tab.")

apps_script.js

@@ -0,0 +1,49 @@
+// Google Apps Script — paste this into Extensions > Apps Script in your Google Sheet.
+// Deploy as: Web App → Execute as Me → Anyone can access.
+//
+// The sheet must have headers in row 1: name | author | timestamp | data_json
+
+function doPost(e) {
+  var sheet = SpreadsheetApp.getActiveSpreadsheet().getActiveSheet();
+  var data = JSON.parse(e.postData.contents);
+
+  if (data.action === "save") {
+    // Check if scenario already exists (update in place)
+    var names = sheet.getRange("A:A").getValues();
+    var rowIndex = -1;
+    for (var i = 1; i < names.length; i++) {
+      if (names[i][0] === data.name) {
+        rowIndex = i + 1; // 1-indexed
+        break;
+      }
+    }
+    var row = [data.name, data.author, data.timestamp, data.data_json];
+    if (rowIndex > 0) {
+      sheet.getRange(rowIndex, 1, 1, 4).setValues([row]);
+    } else {
+      sheet.appendRow(row);
+    }
+    return ContentService.createTextOutput(JSON.stringify({status: "ok"}))
+      .setMimeType(ContentService.MimeType.JSON);
+
+  } else if (data.action === "delete") {
+    var names = sheet.getRange("A:A").getValues();
+    for (var i = 1; i < names.length; i++) {
+      if (names[i][0] === data.name) {
+        sheet.deleteRow(i + 1);
+        break;
+      }
+    }
+    return ContentService.createTextOutput(JSON.stringify({status: "ok"}))
+      .setMimeType(ContentService.MimeType.JSON);
+  }
+
+  return ContentService.createTextOutput(JSON.stringify({status: "error", message: "Unknown action"}))
+    .setMimeType(ContentService.MimeType.JSON);
+}
+
+// Required for Apps Script web app — handles GET requests with a simple status page
+function doGet(e) {
+  return ContentService.createTextOutput("SalesComp API is running.")
+    .setMimeType(ContentService.MimeType.TEXT);
+}

requirements.txt

@@ -1,5 +1,4 @@
 streamlit>=1.30
 plotly>=5.18
 pandas>=2.0
-gspread>=6.0
-google-auth>=2.0
+requests>=2.28