fix(portal): sweep stale bundles — the delete pattern is relative to the upload path

deploy_space passed `<subpath>/assets/*` as the delete pattern. huggingface_hub
matches delete patterns against paths RELATIVE to path_in_repo, so a pattern
that already carried the subpath matched nothing: after one update on
test-mcp (2026-10-20) the portal's path held three bundles, the first build's
main bundle still beside the new one. The unit test had asserted the wrong
pattern, so it passed.

`assets/*` now, in both the shared-Space and dedicated-Space cases. A bundle
whose hash is unchanged between builds is both deleted and re-added in the one
commit, and the library keeps the addition.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

demoprep_app/portal/builder.py

@@ -1531,10 +1531,15 @@ def deploy_space(dist: Path, owner: str, space: str, subpath: str = "") -> str:
     # (update_portal) would otherwise leave each previous bundle beside the new
     # one, forever. Only the bundles are swept: the source zip and index.html
     # at this path are rewritten by the upload that follows, not deleted first.
-    stale = f"{subpath}/assets/*" if subpath else "assets/*"
+    # The pattern is RELATIVE to path_in_repo (huggingface_hub matches delete
+    # patterns against paths under the upload folder, not repo paths). A
+    # subpath-prefixed pattern matched nothing — verified on test-mcp
+    # 2026-10-20, where an updated portal held three bundles instead of two.
+    # A bundle whose hash is unchanged is both deleted and re-added in the one
+    # commit; the library keeps the addition.
     api.upload_folder(folder_path=str(dist), repo_id=repo_id, repo_type="space",
                       path_in_repo=subpath or "",
-                      delete_patterns=[stale],
+                      delete_patterns=["assets/*"],
                       commit_message=f"portal build: {subpath or 'root'}")
     host = space_host(owner, space)
     if subpath:

tests/test_portal_update.py

@@ -549,7 +549,12 @@ def test_build_portal_still_maps_through_the_shared_mapping(server):
 def test_deploy_space_sweeps_the_previous_bundles_at_that_path(monkeypatch, tmp_path):
     """vite names bundles by hash; a rebuild at the same path must replace them,
     not pile them up. Only assets/* — the zip beside the site is overwritten by
-    the upload that follows, never deleted first."""
+    the upload that follows, never deleted first.
+
+    The pattern is relative to path_in_repo: huggingface_hub matches delete
+    patterns against paths UNDER the upload folder. The first version of this
+    test asserted a subpath-prefixed pattern, which matched nothing on the
+    real Space (three bundles after one update, 2026-10-20)."""
     import huggingface_hub
     from demoprep_app.portal.builder import deploy_space
 
@@ -575,7 +580,7 @@ def test_deploy_space_sweeps_the_previous_bundles_at_that_path(monkeypatch, tmp_
 
     url = deploy_space(dist, "thoughtspot-demoprep", "portals", "spendflo-a0f6cdbe")
     assert url == f"https://{HOST}/spendflo-a0f6cdbe/index.html"
-    assert calls["upload"]["delete_patterns"] == ["spendflo-a0f6cdbe/assets/*"]
+    assert calls["upload"]["delete_patterns"] == ["assets/*"], "relative to path_in_repo"
     assert calls["upload"]["path_in_repo"] == "spendflo-a0f6cdbe"
 
     deploy_space(dist, "thoughtspot-demoprep", "vantage-portal", "")