Update app.py

app.py

@@ -75,9 +75,12 @@ def send_mail(to, subject, body):
 
 def login(user, pwd):
 
+    if user == "" or pwd == "":
+        return "❌ Enter Username & Password", "", ""
+
     row = staff_df[
-        (staff_df["staff_id"]==user) &
-        (staff_df["password"]==pwd)
+        (staff_df["staff_id"] == user) &
+        (staff_df["password"] == pwd)
     ]
 
     if row.empty:
@@ -90,101 +93,131 @@ def login(user, pwd):
 
 
 # =========================
-# DATE CHECK
+# DATE VALIDATION
 # =========================
 
-def valid_date(d):
+def valid_date(date_str):
+
+    try:
+        d = datetime.strptime(date_str, "%Y-%m-%d").date()
 
-    today = datetime.today().date()
-    maxd = today + timedelta(days=2)
+        today = datetime.today().date()
+        max_day = today + timedelta(days=2)
 
-    return today <= d <= maxd
+        if today <= d <= max_day:
+            return True
+        else:
+            return False
+
+    except:
+        return False
 
 
 # =========================
-# TIME CHECK
+# TIME VALIDATION
 # =========================
 
-def valid_time(f,t):
+def valid_time(from_t, to_t):
 
     try:
-        f = datetime.strptime(f,"%I:%M %p").time()
-        t = datetime.strptime(t,"%I:%M %p").time()
+        f = datetime.strptime(from_t, "%I:%M %p").time()
+        t = datetime.strptime(to_t, "%I:%M %p").time()
 
-        min_t = datetime.strptime("08:45","%H:%M").time()
-        max_t = datetime.strptime("17:20","%H:%M").time()
+        min_time = datetime.strptime("08:45 AM", "%I:%M %p").time()
+        max_time = datetime.strptime("05:20 PM", "%I:%M %p").time()
 
-        if f < min_t or t > max_t:
+        # Range Check
+        if f < min_time or t > max_time:
             return False
 
+        # Logical Check
         if f >= t:
             return False
 
         return True
+
     except:
         return False
 
 
 # =========================
-# SUBMIT
+# SUBMIT PERMISSION
 # =========================
 
-def submit(staff_id,name,date,from_t,to_t,reason):
+def submit(staff_id, name, date, from_t, to_t, reason):
+
+    # Empty check
+    if not all([staff_id, name, date, from_t, to_t, reason]):
+        return "❌ All fields are mandatory"
 
-    if not all([staff_id,name,date,from_t,to_t,reason]):
-        return "❌ Fill All Fields"
 
-    d = datetime.strptime(date,"%Y-%m-%d").date()
+    # Date validation
+    if not valid_date(date):
+        return "❌ Apply only within today and next 2 days"
 
-    if not valid_date(d):
-        return "❌ Apply within 2 days only"
 
-    if not valid_time(from_t,to_t):
-        return "❌ Time: 8:45AM to 5:20PM only"
+    # Time validation
+    if not valid_time(from_t, to_t):
+        return "❌ Time must be between 8:45 AM and 5:20 PM"
 
 
-    # Same Day Check
+    # Same day check
     cur.execute("""
     SELECT COUNT(*) FROM permissions
     WHERE staff_id=? AND date=?
-    """,(staff_id,date))
+    """, (staff_id, date))
 
     if cur.fetchone()[0] >= 1:
-        return "❌ Already Applied Today"
+        return "❌ Already applied today"
 
 
-    # Monthly Limit
+    # Monthly limit
     month = date[:7]
 
     cur.execute("""
     SELECT COUNT(*) FROM permissions
     WHERE staff_id=? AND substr(date,1,7)=?
-    """,(staff_id,month))
+    """, (staff_id, month))
 
     if cur.fetchone()[0] >= 2:
-        return "❌ Monthly Limit Reached"
+        return "❌ Monthly limit (2 only)"
 
 
-    applied = datetime.now().strftime("%Y-%m-%d %H:%M")
+    # Save
+    applied_on = datetime.now().strftime("%Y-%m-%d %H:%M")
 
     cur.execute("""
     INSERT INTO permissions
     VALUES(NULL,?,?,?,?,?,?,?)
-    """,(staff_id,name,date,from_t,to_t,reason,applied))
+    """, (
+        staff_id,
+        name,
+        date,
+        from_t,
+        to_t,
+        reason,
+        applied_on
+    ))
 
     conn.commit()
 
 
-    # Email
-    email = staff_df[staff_df["staff_id"]==staff_id].iloc[0]["email"]
+    # Email alert
+    try:
+        email = staff_df[
+            staff_df["staff_id"] == staff_id
+        ].iloc[0]["email"]
+
+        send_mail(
+            email,
+            "Permission Submitted",
+            f"Your permission on {date} has been submitted successfully."
+        )
+    except:
+        pass
 
-    send_mail(
-        email,
-        "Permission Approved",
-        f"Your permission on {date} is submitted"
-    )
 
-    return "✅ Applied Successfully"
+    return "✅ Permission Applied Successfully"
 
 
 # =========================
@@ -193,10 +226,10 @@ def submit(staff_id,name,date,from_t,to_t,reason):
 
 def download_report():
 
-    df = pd.read_sql("SELECT * FROM permissions",conn)
+    df = pd.read_sql("SELECT * FROM permissions", conn)
 
     file = "permission_report.xlsx"
-    df.to_excel(file,index=False)
+    df.to_excel(file, index=False)
 
     return file
 
@@ -205,19 +238,26 @@ def download_report():
 # RESET PASSWORD
 # =========================
 
-def reset_pwd(staff_id,newpwd):
+def reset_pwd(staff_id, newpwd):
 
     global staff_df
 
-    idx = staff_df[staff_df["staff_id"]==staff_id].index
+    if staff_id == "" or newpwd == "":
+        return "❌ Enter ID and Password"
+
+
+    idx = staff_df[
+        staff_df["staff_id"] == staff_id
+    ].index
 
-    if len(idx)==0:
-        return "❌ Invalid ID"
+    if len(idx) == 0:
+        return "❌ Invalid Staff ID"
 
-    staff_df.loc[idx,"password"] = newpwd
-    staff_df.to_excel("staff_details.xlsx",index=False)
 
-    return "✅ Password Reset"
+    staff_df.loc[idx, "password"] = newpwd
+    staff_df.to_excel("staff_details.xlsx", index=False)
+
+    return "✅ Password Updated"
 
 
 # =========================
@@ -232,11 +272,12 @@ with gr.Blocks() as app:
     <style>
 
     #head{
-    display:flex;
-    gap:20px;
-    align-items:center;
-    padding:15px;
-    border-bottom:2px solid #ccc;
+        display:flex;
+        gap:20px;
+        align-items:center;
+        justify-content:center;
+        padding:15px;
+        border-bottom:2px solid #ccc;
     }
 
     </style>
@@ -245,7 +286,7 @@ with gr.Blocks() as app:
 
     with gr.Row(elem_id="head"):
 
-        gr.Image("logo.jpg",height=90)
+        gr.Image("logo.jpg", height=90)
 
         gr.Markdown("""
         ## SRC, SASTRA  
@@ -253,15 +294,16 @@ with gr.Blocks() as app:
         """)
 
 
-    # LOGIN
-    gr.Markdown("## Login")
+    # ================= LOGIN =================
+
+    gr.Markdown("## 🔐 Login")
 
     uid = gr.Textbox(label="User ID")
-    pwd = gr.Textbox(label="Password",type="password")
+    pwd = gr.Textbox(label="Password", type="password")
 
     login_btn = gr.Button("Login")
 
-    msg = gr.Textbox()
+    msg = gr.Textbox(interactive=False)
 
     role = gr.State()
     uname = gr.State()
@@ -269,33 +311,50 @@ with gr.Blocks() as app:
 
     login_btn.click(
         login,
-        [uid,pwd],
-        [msg,role,uname]
+        [uid, pwd],
+        [msg, role, uname]
+    )
+
+
+    # ================= STAFF PANEL =================
+
+    gr.Markdown("## 📝 Staff Panel")
+
+    date = gr.Textbox(
+        label="Date (YYYY-MM-DD)",
+        placeholder="2026-02-15"
     )
 
+    ft = gr.Textbox(
+        label="From Time (HH:MM AM/PM)",
+        placeholder="09:00 AM"
+    )
 
-    # STAFF PANEL
-    gr.Markdown("## Staff Panel")
+    tt = gr.Textbox(
+        label="To Time (HH:MM AM/PM)",
+        placeholder="01:00 PM"
+    )
 
-    date = gr.Textbox(label="Date (YYYY-MM-DD)")
-    ft = gr.Textbox(label="From Time (09:00 AM)")
-    tt = gr.Textbox(label="To Time (01:00 PM)")
-    reason = gr.Textbox(lines=3)
+    reason = gr.Textbox(
+        label="Reason",
+        lines=3
+    )
 
-    apply_btn = gr.Button("Apply")
+    apply_btn = gr.Button("Apply Permission", variant="primary")
 
-    out = gr.Textbox()
+    out = gr.Textbox(interactive=False)
 
 
     apply_btn.click(
         submit,
-        [uid,uname,date,ft,tt,reason],
+        [uid, uname, date, ft, tt, reason],
         out
     )
 
 
-    # ADMIN PANEL
-    gr.Markdown("## Admin Panel")
+    # ================= ADMIN PANEL =================
+
+    gr.Markdown("## 📊 Admin Panel")
 
     report_btn = gr.Button("Download Report")
 
@@ -309,20 +368,25 @@ with gr.Blocks() as app:
     )
 
 
-    # RESET
-    gr.Markdown("## Reset Password")
+    # ================= RESET =================
+
+    gr.Markdown("## 🔑 Reset Password")
 
     rid = gr.Textbox(label="Staff ID")
-    np = gr.Textbox(label="New Password")
+
+    np = gr.Textbox(
+        label="New Password",
+        type="password"
+    )
 
     reset_btn = gr.Button("Reset")
 
-    rmsg = gr.Textbox()
+    rmsg = gr.Textbox(interactive=False)
 
 
     reset_btn.click(
         reset_pwd,
-        [rid,np],
+        [rid, np],
         rmsg
     )