feat(simulation): add bypass for all skills when no skills are started
Browse files
mathly2/boardwork.py
CHANGED
|
@@ -148,7 +148,8 @@ def teacher_view(request: Request, row: dict) -> dict:
|
|
| 148 |
|
| 149 |
@router.get("/teaching/work/{attempt_id}")
|
| 150 |
def work_open(attempt_id: str, request: Request, user: dict = Depends(need("class.teach"))) -> dict:
|
| 151 |
-
|
|
|
|
| 152 |
|
| 153 |
|
| 154 |
class Credit(BaseModel):
|
|
|
|
| 148 |
|
| 149 |
@router.get("/teaching/work/{attempt_id}")
|
| 150 |
def work_open(attempt_id: str, request: Request, user: dict = Depends(need("class.teach"))) -> dict:
|
| 151 |
+
from . import boardreview
|
| 152 |
+
return teacher_view(request, boardreview.ensure(request.app, _graded_attempt(request, user, attempt_id))) # opening it starts a missing AI review
|
| 153 |
|
| 154 |
|
| 155 |
class Credit(BaseModel):
|
mathly2/tests/test_boardreview_api.py
CHANGED
|
@@ -155,3 +155,14 @@ def test_gemini_bad_or_cut_output_is_a_failure():
|
|
| 155 |
with pytest.raises(boardreview.ReviewFailure) as caught:
|
| 156 |
reviewer.review(items())
|
| 157 |
assert caught.value.reason == "bad_output"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 155 |
with pytest.raises(boardreview.ReviewFailure) as caught:
|
| 156 |
reviewer.review(items())
|
| 157 |
assert caught.value.reason == "bad_output"
|
| 158 |
+
|
| 159 |
+
|
| 160 |
+
def test_a_test_handed_in_before_the_key_was_set_is_reviewed_when_the_teacher_opens_it():
|
| 161 |
+
fake = FakeReviewer()
|
| 162 |
+
client, store, bank, test, _ = make(fake)
|
| 163 |
+
client.app.state.reviewer = None # handed in with no key: no review
|
| 164 |
+
attempt, _ = hand_in(client, bank, test)
|
| 165 |
+
assert store.get_attempt(attempt["id"]).get("review") is None
|
| 166 |
+
client.app.state.reviewer = fake # the key is set now
|
| 167 |
+
got = client.get(f"/api/teaching/work/{attempt['id']}", headers=auth(TEACHER)).json()
|
| 168 |
+
assert len(fake.calls) == 1 and got["ai_summary"] and any(q["ai"] for q in got["questions"])
|