Sovereign-Event-Bus / .github /PULL_REQUEST_TEMPLATE.md
SNAPKITTYWEST's picture
push from SNAPKITTYWEST/Sovereign-Event-Bus
6afa130 verified
|
Raw History Blame Contribute Delete
3.46 kB
## Pull Request: Sovereign Forge
### Description
Clearly describe the changes you're proposing. What problem does this solve? What new capability does it add?
### Type of Change
- [ ] Bug fix (non-breaking change that fixes an issue)
- [ ] Feature (new capability, non-breaking change)
- [ ] Breaking change (significant alteration to API or behavior)
- [ ] Documentation (README, guides, comments)
- [ ] Refactoring (code cleanup, no functional change)
- [ ] Performance (optimization, benchmarking)
- [ ] Security (vulnerability fix, hardening)
### Testing
Link to test results and describe testing performed:
- [ ] Unit tests added/updated: `make -f netlister/Makefile.sov test-all`
- [ ] Conformance tests pass: Phase 1-5 all 77+ tests passing
- [ ] ASan/UBSan clean: No memory errors detected
- [ ] Fuzzing: 1M+ libFuzzer iterations without crash
- [ ] Manual testing: Describe steps taken
### Security Impact
Does this change touch:
- [ ] Cryptographic code (Blake3, Ed25519)
- [ ] Memory management (allocation, pointers)
- [ ] Certificate generation or verification
- [ ] Key material or signatures
- [ ] Input validation or preconditions
**If yes:** Describe security implications and mitigations.
### Performance Impact
- [ ] No performance change
- [ ] Performance improved (describe: 2x faster for N×N matrices)
- [ ] Performance regressed (describe: now O(N^4) instead of O(N^3))
Provide benchmark results if applicable:
```
Before: matrix_invert 100×100 = 50ms
After: matrix_invert 100×100 = 45ms (10% improvement)
```
### Breaking Changes
Does this change break existing APIs or proof certificates?
- [ ] No breaking changes
- [ ] Yes, breaking change (version bump required, migration path needed)
If breaking: describe migration path for users.
### Documentation
- [ ] README updated (if user-facing feature)
- [ ] DEVELOPER.md updated (if developer-facing)
- [ ] ARCHITECTURE.md updated (if architectural change)
- [ ] Code comments added (if complex logic)
- [ ] Formal proof updated (if algorithm changed)
### Checklist
- [ ] I have read the [DEVELOPER.md](../../DEVELOPER.md)
- [ ] My code follows the project style guide (C89-ish, clear comments)
- [ ] I have performed a self-review of my own changes
- [ ] I have commented complex sections of code
- [ ] I have updated documentation as needed
- [ ] My changes generate no new compiler warnings
- [ ] I have added tests that prove my fix/feature works
- [ ] New tests pass locally with `make -f netlister/Makefile.sov test-all`
- [ ] ASan/UBSan pass: `make -f netlister/Makefile.sov clean asan-build test-all`
- [ ] Fuzzing passes: `cd tests/fuzzing && ./run_libfuzzer.sh`
- [ ] I understand this code will be formally verified in Lean 4
### Related Issues
Closes: #(issue number)
Related to: #(issue number)
### Reviewers
Tag relevant maintainers:
- @Ahmad-Ali-Parr (architecture, threat model)
- @JessicaWesterhoff (coordination, integration)
---
## Contribution Agreement
By submitting this pull request, you agree that:
1. Your contribution is your own original work or properly licensed
2. You grant Jessica Westerhoff and contributors a perpetual, irrevocable license
3. Your code does not violate any third-party intellectual property rights
4. Your code complies with the Apache 2.0 license (see LICENSE)
**Last Updated**: July 29, 2026