Search is not available for this dataset
hash string | author int32 | committer_date string | timezone int64 | parents string | message string | changes string | language string |
|---|---|---|---|---|---|---|---|
006faf3621186e4f2e343d31c66f2fa8861512be | 45 | 2020-02-18 12:02:02-05:00 | 28,800 | ['e49b94d48f43b1a4f15ce3a2a11815c0e2955b59'] | replace current().getLong("id") by .selected()
That should be ex actly the same thing, unless there is a real bug in
the collection. After all, current uses selected. Then get the deck
using the id. If we return the deck's id obtained through the id, it
present no interest | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1064,12 +1064,7 @@ public abstract class AbstractFlashcardViewer extends NavigationDrawerActivity {\n... | Kotlin |
4bc5ee1461158ac4ea386dcdf1aea5f827a9e79b | 80 | 2020-02-18 15:00:17-05:00 | 18,000 | ['006faf3621186e4f2e343d31c66f2fa8861512be'] | Avoid crash on audio clip w/no extension or mime type | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/multimediacard/fields/BasicAudioClipFieldController.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/multimediacard/fields/BasicAudioClipFieldController.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -99,14 +99,17 @@ public class BasicAudioClipFi... | Kotlin |
e6bdf50307c14c31944e2b2f6eb537e90cdde27d | 80 | 2020-02-18 15:47:29-05:00 | 18,000 | ['4bc5ee1461158ac4ea386dcdf1aea5f827a9e79b'] | Handle dynamic decks' lack of rev JSON object | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1773,14 +1773,19 @@ public abstract class AbstractFlashcardViewer extends NavigationDrawerActivity {\... | Kotlin |
cd7a89e52999cd8b047326d486c50474ca819a75 | 80 | 2020-02-18 15:53:43-05:00 | 18,000 | ['e6bdf50307c14c31944e2b2f6eb537e90cdde27d'] | Bumped version to 2.10alpha41
@branch-specific | [{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ... | Kotlin |
a3460b263533c5d653e47d11fdf7261baf5f453d | 80 | 2020-03-01 23:03:39-06:00 | 18,000 | ['abd09c4f7284cb9d21eeef424980f1b39538259a'] | Manually grant permissions <= Lollipop to avoid camera crash
https://medium.com/@quiro91/sharing-files-through-intents-part-2-fixing-the-permissions-before-lollipop-ceb9bb0eec3a | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/multimediacard/fields/BasicImageFieldController.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/multimediacard/fields/BasicImageFieldController.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -20,13 +20,16 @@\n package com.ichi2.anki.multimediaca... | Kotlin |
7ab4833538d724a464778143b03fda63a7568cbb | 80 | 2020-03-02 05:20:40-06:00 | 18,000 | ['a3460b263533c5d653e47d11fdf7261baf5f453d'] | Bump Gradle to 3.6.1 to match Android Studio stable release
Note that ContentProviderTest needed a tweak as Manifest class
is no longer generated correctly, we are using the second method
to handle it, as described here:
https://developer.android.com/studio/releases/gradle-plugin#agp-missing-manifest
Also, lint in 3... | [{'old_path': 'AnkiDroid/src/androidTest/java/com.ichi2.anki.tests/ContentProviderTest.java', 'new_path': 'AnkiDroid/src/androidTest/java/com.ichi2.anki.tests/ContentProviderTest.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -71,7 +71,7 @@ public class ContentProviderTest {\n @Rule\n public GrantPerm... | Kotlin |
96ff7e2fc5bae4e0391a73999fd918a24766703b | 80 | 2020-03-02 05:20:40-06:00 | 18,000 | ['7ab4833538d724a464778143b03fda63a7568cbb'] | Bump play publisher and gradle
These have to go at the same time because they have a cross-dependency
I mentioned to the Play Publisher maintainer that he broke builds in
a minor version (not sem ver) but they have a different semantic versioning
interpretation over there | [{'old_path': 'AnkiDroid/build.gradle', 'new_path': 'AnkiDroid/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -2,7 +2,7 @@ import com.android.ddmlib.DdmPreferences\n \n plugins {\n // Gradle plugin portal \n- id 'com.github.triplet.play' version '2.6.2'\n+ id 'com.github.triplet.play' version '2.7.2'... | Kotlin |
b99a3ad9035e1a1b3579533e1142b80c5d88d53b | 80 | 2020-03-02 06:54:13-06:00 | 18,000 | ['92e61d0e476ba639d332cdf8c68d8ac56679c2fa'] | Update google-analytics library for Android 11 compatibility | [{'old_path': 'AnkiDroid/build.gradle', 'new_path': 'AnkiDroid/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -143,7 +143,7 @@ dependencies {\n implementation'ch.acra:acra-toast:5.2.1'\n implementation'ch.acra:acra-limiter:5.2.1'\n \n- implementation 'net.mikehardy:google-analytics-java7:2.... | Kotlin |
9ada8bc6340b80d47c46691fddee6c1033c5812b | 80 | 2020-03-02 08:05:49-05:00 | 18,000 | ['b99a3ad9035e1a1b3579533e1142b80c5d88d53b'] | Specify the NDK version after gradle 3.6 update
Apparently this is necessary now:
https://stackoverflow.com/questions/60404457/android-no-version-of-ndk-matched-the-requested-version
https://github.com/KYHSGeekCode/Android-Disassembler/blob/b6c9328bf5db1aa179ed24b15458edc96bdf4a4d/app/build.gradle#L73 | [{'old_path': 'AnkiDroid/build.gradle', 'new_path': 'AnkiDroid/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -97,6 +97,7 @@ android {\n check \'NewApi\'\n abortOnError true\n }\n+ ndkVersion "21.0.6113669"\n }\n \n play {\n'}] | Kotlin |
52d109711e8fe97669122e49120725afe15ff978 | 80 | 2020-03-02 08:07:45-05:00 | 18,000 | ['9ada8bc6340b80d47c46691fddee6c1033c5812b'] | Bumped version to 2.10alpha42
@branch-specific | [{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ... | Kotlin |
51ee030a7b278180dd4275bf871d32fadae55c1d | 80 | 2020-03-06 06:18:22+13:00 | 18,000 | ['52d109711e8fe97669122e49120725afe15ff978'] | Avoid crash on browser QA render if cancelled
The mCards array is shared via TaskData into the async render DeckTask,
and in the render there is logic listening for a possible cancel, but
not until after it already attempted to touch the (possibly concurrently
mutated) mCards array, resulting in IndexOutOfBoundsExcept... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/async/DeckTask.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/async/DeckTask.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -887,21 +887,20 @@ public class DeckTask extends BaseAsyncTask<DeckTask.TaskData, DeckTask.TaskData\n \n // for each speci... | Kotlin |
f27758c54d11a9e76ba102f696613402a5e8fd88 | 80 | 2020-03-06 06:21:54+13:00 | 18,000 | ['51ee030a7b278180dd4275bf871d32fadae55c1d'] | Gracefully handle deck deletion while building reminders | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/services/ReminderService.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/services/ReminderService.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -95,6 +95,13 @@ public class ReminderService extends BroadcastReceiver {\n \n // getDeckDue info... | Kotlin |
f8b721bbaefe7e205fb50333dc7cdf05a98426e2 | 80 | 2020-03-05 14:10:40-05:00 | 18,000 | ['f27758c54d11a9e76ba102f696613402a5e8fd88'] | Display useful message when out of space on cache copy | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/utils/ImportUtils.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/utils/ImportUtils.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -76,7 +76,7 @@ public class ImportUtils {\n } else if (filename != null) {\n // Copy to temporar... | Kotlin |
4dcd7d00951736a7f9a653c9087587c4bf8b3903 | 80 | 2020-03-05 14:10:40-05:00 | 18,000 | ['f8b721bbaefe7e205fb50333dc7cdf05a98426e2'] | Show helpful message if import fails for lack of space | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Utils.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Utils.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -652,6 +652,7 @@ public class Utils {\n success = true;\n } catch (IOException e) {\n if... | Kotlin |
2fec60ce40ead1b6ec103c8091230a677d2b7bf5 | 80 | 2020-03-06 09:51:51-05:00 | 18,000 | ['4dcd7d00951736a7f9a653c9087587c4bf8b3903'] | Gracefully handle MediaRecorder.stop exceptions
MediaRecorder.stop is documented to throw a RuntimeException on purpose
in the case where stop is hit immediately after start:
https://developer.android.com/reference/android/media/MediaRecorder#stop() | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/multimediacard/AudioView.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/multimediacard/AudioView.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -27,8 +27,9 @@ import android.media.MediaRecorder;\n import androidx.appcompat.widget.AppCompatImage... | Kotlin |
17ae6930c6b997ad2fd9f7159872f9ee2de30d71 | 80 | 2020-03-06 10:03:00-05:00 | 18,000 | ['2fec60ce40ead1b6ec103c8091230a677d2b7bf5'] | Bumped version to 2.10alpha43
@branch-specific | [{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ... | Kotlin |
7d21aa4c3fc0a72061c5d72a28f03ac093a8366a | 45 | 2020-03-06 14:57:40-05:00 | -3,600 | ['17ae6930c6b997ad2fd9f7159872f9ee2de30d71'] | mCards is not changed while used
I ensure that mCards is set to a new array instead of cleared.
Next aciton is to notify the adapter that the data set has changed, so
anyway the change will be taken into account. However it avoids a
problem if a loop is currently using the array.
More details given in a commit explai... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1161,7 +1161,7 @@ public class CardBrowser extends NavigationDrawerActivity implements\n }\n if (colIsOpen() ... | Kotlin |
c505c2b5f05dd48dca855e22da65c93ddb4ec6b5 | 45 | 2020-03-06 14:57:40-05:00 | -3,600 | ['8d491c93b63ecb8a1685f12f498ece06b1aa6123'] | Factorizing a little bit
Since I was anyway dealing with an error in this area, I thought i
could factorize it a little bit. I hope it's a little bit clearer that
`items` are actually cards, and that items.get(i) is always the same
card, considered in an iteration of the loop. | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/async/DeckTask.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/async/DeckTask.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -892,15 +892,18 @@ public class DeckTask extends BaseAsyncTask<DeckTask.TaskData, DeckTask.TaskData\n Timber.d("do... | Kotlin |
402d70b0d5fbd210b765766b354147dd2a98470c | 45 | 2020-03-06 14:57:40-05:00 | -3,600 | ['c505c2b5f05dd48dca855e22da65c93ddb4ec6b5'] | items -> cards
More precise name | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/async/DeckTask.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/async/DeckTask.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -881,7 +881,7 @@ public class DeckTask extends BaseAsyncTask<DeckTask.TaskData, DeckTask.TaskData\n private TaskData doInBackg... | Kotlin |
f03097a87ad920980c2fd3cae516b84110fedc99 | 80 | 2020-03-09 08:55:19+13:00 | 18,000 | ['df939dcea26ba6f9980a2119a28e861714b3e84d'] | Gracefully handle any exception while building reminder | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/services/ReminderService.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/services/ReminderService.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -108,10 +108,9 @@ public class ReminderService extends BroadcastReceiver {\n ret... | Kotlin |
f0e1f1af18539304d9e6f815d3d45e524b0163d7 | 80 | 2020-03-09 12:53:38+13:00 | 18,000 | ['f03097a87ad920980c2fd3cae516b84110fedc99'] | Avoid crash if unable to delegate to external app | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AnkiActivity.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AnkiActivity.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -4,6 +4,7 @@ package com.ichi2.anki;\n import android.app.Activity;\n import android.app.NotificationManager;\n import andro... | Kotlin |
f14da1694e2a3bb9b74053f35486f38be1ec92dd | 80 | 2020-03-08 22:13:54-05:00 | 18,000 | ['f0e1f1af18539304d9e6f815d3d45e524b0163d7'] | Bumped version to 2.10alpha44
@branch-specific | [{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ... | Kotlin |
35ab9cd64426b459c306a7a165e78894f61c3afc | 45 | 2020-03-09 07:20:54-05:00 | 28,800 | ['f14da1694e2a3bb9b74053f35486f38be1ec92dd'] | Correcting: onMark/onFlag raises nullPointException
When you click on mark/flag in the reviewer but the card is not yet
loaded, this used to lead to a nullPointException. This is now
corrected. I believe that it's okay if those button does nothing while
we are waiting for the next card.
Note that this leaves the rela... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2875,6 +2875,9 @@ public abstract class AbstractFlashcardViewer extends NavigationDrawerActivity {\n ... | Kotlin |
6c649150d01b1dccf8d69162ac7b567c0954e99e | 45 | 2020-03-09 07:20:54-05:00 | -3,600 | ['35ab9cd64426b459c306a7a165e78894f61c3afc'] | add test for nullPointerException in drawMark/Flag
This was requested by @mikehardy in
https://github.com/ankidroid/Anki-Android/pull/5700#issuecomment-596226190
I do not know whether it is actually useful. However, I don't see how
it can hurt | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2871,6 +2871,9 @@ public abstract class AbstractFlashcardViewer extends NavigationDrawerActivity {\n ... | Kotlin |
b9c8a542f18229fab4a5f8d4e2cb3a56a47c15c9 | 80 | 2020-03-09 07:22:31-05:00 | 18,000 | ['6c649150d01b1dccf8d69162ac7b567c0954e99e'] | Render flag as inline SVG for old API compatibility | [{'old_path': 'AnkiDroid/src/main/assets/card_template.html', 'new_path': 'AnkiDroid/src/main/assets/card_template.html', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -16,7 +16,17 @@\n <body class="::class::">\n <div id="_mark_flag">\n <div id="_mark">★</div>\n- <div id="_flag">... | Kotlin |
8f1e03d0332eb0cd07191cae6f1c744aca2b991a | 80 | 2020-03-09 07:23:23-05:00 | 18,000 | ['b9c8a542f18229fab4a5f8d4e2cb3a56a47c15c9'] | Give users more connection error information, handle cleartext failure | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1542,6 +1542,9 @@ public class DeckPicker extends NavigationDrawerActivity implements\n showSyncErrorMe... | Kotlin |
b15d491c70d6d313cad285b028938f41e22aa642 | 45 | 2020-03-09 07:29:10-05:00 | -3,600 | ['8f1e03d0332eb0cd07191cae6f1c744aca2b991a'] | Adding missing line
It seems when I ported the method from anki to ankidroid, I forgot:
1. to add the name of the deck in the set of name of decks.
Here it is. It'll remove timbers.
2. to save the new names in the deck objects once they were computed.
I should note that this did not create any problem. Indeed, it on... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Decks.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Decks.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -866,34 +866,33 @@ public class Decks {\n \n for (JSONObject deck: decks) {\n // two decks with the same name?\n... | Kotlin |
21761ae0f55bcf77c438e5f37fc96bfc5ed4cfc7 | 45 | 2020-03-09 07:32:53-05:00 | -3,600 | ['b15d491c70d6d313cad285b028938f41e22aa642'] | Correct conf' when it's set.
Currently, the conf is corrceted only when accessed. Which I believe
may be the cause of bug #5523. Indeed, data is corrected, and then
accessed, while it is theoretically possible that data is changed back
to a faulty value during an asynchrone process after correction and
before access.
... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -464,6 +464,10 @@ public class CardBrowser extends NavigationDrawerActivity implements\n if (mOrder == 1 && prefer... | Kotlin |
4f9fc05ce8d46e54ac49183653d7d6e11a857f89 | 45 | 2020-03-09 07:33:57-05:00 | -7,200 | ['21761ae0f55bcf77c438e5f37fc96bfc5ed4cfc7'] | The word model should be "note type"
Model is used in the code. But the user only see "note type" in anki,
in almost all ankidroid, and in the manual.
Is there a way to ensure that translations are also updated ? The same
problem occurs in French at least. If it can't be done this way,
another solution would be to al... | [{'old_path': 'AnkiDroid/src/main/res/values/02-strings.xml', 'new_path': 'AnkiDroid/src/main/res/values/02-strings.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -91,7 +91,7 @@\n <string name="discard_unsaved_changes">Close and lose current input?</string>\n <string name="factadder_saving_error">Error... | Kotlin |
0fd54300fca45df58aac8392a27803982ac8de6f | 45 | 2020-03-09 07:33:57-05:00 | -7,200 | ['4f9fc05ce8d46e54ac49183653d7d6e11a857f89'] | Correcting template to card type
I should note that anki's manual and interface are not consistent with
anki's code and anki's json. In the manual and interface, a note type is
composed of multiple card type. Each card type contains a front and a
back template, which is the HTML displayed, with some mustaches.
In anki... | [{'old_path': 'AnkiDroid/src/main/res/values/01-core.xml', 'new_path': 'AnkiDroid/src/main/res/values/01-core.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -159,7 +159,7 @@\n </plurals>\n <string name="invalid_template">A card could not be generated</string>\n <string name="card_template_editor_wo... | Kotlin |
501aee48c8cf5a8a964269d6d42aa06365c1fa4b | 80 | 2020-03-09 07:38:48-05:00 | 18,000 | ['0fd54300fca45df58aac8392a27803982ac8de6f'] | Avoid crashing on import even if collection not found | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Utils.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Utils.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -847,14 +847,11 @@ public class Utils {\n public static List<File> getImportableDecks(Context context) {\n String deckPa... | Kotlin |
167a0c23a6a82cd17ff88844324b5b6b2c4833b4 | 80 | 2020-03-09 07:49:57-05:00 | 18,000 | ['501aee48c8cf5a8a964269d6d42aa06365c1fa4b'] | Remove remnant line from #5601
@Arthur-Milchior please verify this is correct - it was a remnant
as you picked #5601 out of the larger change you made there I think | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Decks.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Decks.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -893,7 +893,6 @@ public class Decks {\n } catch (JSONException e) {\n throw new RuntimeException(e);\n ... | Kotlin |
623f51a7a697f5b4c67b6f7de44f4d23fcd2bcde | 80 | 2020-03-09 07:52:41-05:00 | 18,000 | ['167a0c23a6a82cd17ff88844324b5b6b2c4833b4'] | Bumped version to 2.10alpha45
@branch-specific | [{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ... | Kotlin |
b3d6cb38f3412905462ca49c74ba8baaf66282b6 | 45 | 2020-03-10 11:22:47-05:00 | -3,600 | ['623f51a7a697f5b4c67b6f7de44f4d23fcd2bcde'] | Adds constant string before equal
Codacy rejected a PR because I did `var.equals("constant")`
It explains that I must do `"constant".equals(var)` so that instead of
having a nullPointerException, it justs returns false when var is
null.
I decided to follow this advice and create a script reversing equality everywhere | [{'old_path': 'AnkiDroid/src/androidTest/java/com.ichi2.anki.tests/libanki/ImportTest.java', 'new_path': 'AnkiDroid/src/androidTest/java/com.ichi2.anki.tests/libanki/ImportTest.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -281,9 +281,9 @@ public class ImportTest {\n // i.initMapping();\n // i.... | Kotlin |
7f8272b4519319fa88c081b36cf4809b22d08757 | 80 | 2020-03-11 09:40:37-05:00 | 18,000 | ['b3d6cb38f3412905462ca49c74ba8baaf66282b6'] | Gracefully handle dialog show failures
There are two frequent crashes that show up when AnkiDroid attempts
to show a dialog but the Activity is no longer there. Both have the same
root cause in that when you attempt to show a dialog you have to check
whether it failed to show, and if it did, either notify user / clean... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -61,6 +61,7 @@ import android.view.MenuItem;\n import android.view.View;\n import android.view.View.OnClickListener;\n import an... | Kotlin |
152afb1080935337d49427ee85c3bce4ec43fc99 | 30 | 2020-03-12 20:47:21-05:00 | 0 | ['7f8272b4519319fa88c081b36cf4809b22d08757'] | Fixes #5810 - Beolingus search case insensitivity
Previously, a search of "hello" failed to find a pronunciation on
Beolingus named "Hello". This fixes the issue via .toLowerCase().
Design was discussed on #5810. May need to be improved in the future. | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/multimediacard/beolingus/parsing/BeolingusParser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/multimediacard/beolingus/parsing/BeolingusParser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -41,7 +41,10 @@ public class BeolingusParser {\n ... | Kotlin |
fac394c4a16ee798b0051831ba36bc0cf3a77671 | 80 | 2020-03-12 21:03:24-05:00 | 18,000 | ['152afb1080935337d49427ee85c3bce4ec43fc99'] | Bumped version to 2.10alpha46
@branch-specific | [{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ... | Kotlin |
2161abcc64448719a1bdad577952e7fee028d04a | 80 | 2020-03-13 12:15:11-05:00 | 18,000 | ['fac394c4a16ee798b0051831ba36bc0cf3a77671'] | Put the 'Fixes' before issue link suggestion in PR template | [{'old_path': '.github/pull_request_template.md', 'new_path': '.github/pull_request_template.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -4,7 +4,7 @@\n _Describe the problem or feature and motivation_\n \n ## Fixes\n-_Link to the issues._\n+Fixes _Link to the issues._\n \n ## Approach\n _How does this change... | Kotlin |
5188fc32b5c92f43357024849d55c2e0f10e7d90 | 30 | 2020-03-13 12:24:38-05:00 | 0 | ['2161abcc64448719a1bdad577952e7fee028d04a'] | Fix #5715: Hide style/script in deck description
Previously, the deck description handled converting most HTML into a
`Spanned`, but instances of the script and style tag displayed their
inner text as a string.
Now, we Regex replace the two tags out of the HTML before we use
Android to convert the string into a `Span... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.java', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -22,6 +22,8 @@ import android.content.res.Resources;\n import android.os.Bundle;\n import androidx.fragment.... | Kotlin |
de5b06c0b148c604f9fc3c00277554ee0e2ea2e7 | 30 | 2020-03-13 12:24:38-05:00 | 0 | ['5188fc32b5c92f43357024849d55c2e0f10e7d90'] | Review: Fix variable reuse & access modifier
Codacy requires no variable reassignment, and that the default package
private modifier is not used implicitly. | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.java', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -20,6 +20,8 @@ import android.content.Intent;\n import android.content.SharedPreferences;\n import android.c... | Kotlin |
0904169051eae3969402ba3f67dba9629748b515 | 30 | 2020-03-14 07:10:07-05:00 | 0 | ['de5b06c0b148c604f9fc3c00277554ee0e2ea2e7'] | Fix #5141: Release resources on audio completion
Clicking an individual sound file did not abandon audio focus when it
completed playing.
Cause:
We have `playSound` and `playSounds`. We did not set a completion
listener for `playSound`.
Fix:
We fix this by adding a new completion listener, which will call
`releaseSo... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Sound.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Sound.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -46,6 +46,7 @@ import java.util.HashMap;\n import java.util.regex.Matcher;\n import java.util.regex.Pattern;\n \n+import androidx.an... | Kotlin |
54a56b8bc112af2d427b732b774fe83abba9faf3 | 94 | 2020-03-15 09:34:22-05:00 | 25,200 | ['0904169051eae3969402ba3f67dba9629748b515'] | Fix scheduler - respect max intervals
* Fixes #5778 - Scheduler properly respects max interval
* Minor code formatting | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Sched.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Sched.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1500,8 +1500,16 @@ public class Sched {\n \n \n private void _updateRevIvl(Card card, int ease) {\n+ try {\n ... | Kotlin |
76a252c8637170d7e83ff9f3e60534ed1a0b1689 | 80 | 2020-03-15 09:53:31-05:00 | 18,000 | ['54a56b8bc112af2d427b732b774fe83abba9faf3'] | Bumped version to 2.10alpha47
@branch-specific | [{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ... | Kotlin |
3d27baeae5ea5a346b3364e1559674ade711c246 | 62 | 2020-03-15 10:04:53-05:00 | -3,600 | ['76a252c8637170d7e83ff9f3e60534ed1a0b1689'] | AdvancedStatistics: disregard suspended cards
Fixes #5289 | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/hooks/AdvancedStatistics.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/hooks/AdvancedStatistics.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -588,6 +588,7 @@ public class AdvancedStatistics extends Hook {\n query = "SELECT... | Kotlin |
decdc6239ef267d4e8f2c1451c41e301a2479f9d | 45 | 2020-03-15 10:12:04-05:00 | 28,800 | ['3d27baeae5ea5a346b3364e1559674ade711c246'] | Card browser: consider sounds as we consider images | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1387,7 +1387,7 @@ public class CardBrowser extends NavigationDrawerActivity implements\n s = s.replace("<br />", " ")... | Kotlin |
767d9b799d4a7991fabe959e30f39343ac4241dc | 45 | 2020-03-15 10:21:38-05:00 | -3,600 | ['decdc6239ef267d4e8f2c1451c41e301a2479f9d'] | Removing an unused variable
The variable mBurySiblingsOnAnswer is set to true and then never
changed.
It's tested twice, one where code is executed only if it's
falsy (i.e. never) and once where code is executed if it's
truthy (i.e. always)
I did remove the useless variable, the code never executed, and remove
the te... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Sched.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Sched.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -65,7 +65,6 @@ public class Sched {\n private String mName = "std";\n private boolean mHaveCustomStudy = true;\n private... | Kotlin |
7e360b1bb7e3c6cc78fc85a1ba3ea6696f098848 | 45 | 2020-03-15 10:25:49-05:00 | -3,600 | ['767d9b799d4a7991fabe959e30f39343ac4241dc'] | Adding intent with default flag
All intents starting an activity from Ankidroid must start it only
once. This is not currently what ankidroid does if you click twice
enough on button.
So I created this new class especially for the activity to start
inside Ankidroid; i.e. most intent, appart from some external ones
su... | [{'old_path': None, 'new_path': 'AnkiDroid/src/main/java/com/ichi2/utils/IntentTop.java', 'type': <ModificationType.ADD: 1>, 'diff': '@@ -0,0 +1,37 @@\n+package com.ichi2.utils;\n+\n+import android.content.Context;\n+import android.content.Intent;\n+import android.net.Uri;\n+\n+public class IntentTop extends Intent {\n... | Kotlin |
e0ee33cb6a1f69fd125e086b61573dc2a11fa1ac | 45 | 2020-03-15 10:25:49-05:00 | -3,600 | ['a37252b05a0454ddaef04bcea34321e38c817547'] | Replacing Intent by IntentTop when necessary
I.e. using last commit. Read its message to get explanations | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -90,6 +90,8 @@ import com.ichi2.libanki.template.Template;\n import com.ichi2.themes.HtmlColors;\n imp... | Kotlin |
913f849984b8fd67f3feba703c3ffca3f52e0211 | 96 | 2020-03-15 10:30:44-05:00 | 21,600 | ['e0ee33cb6a1f69fd125e086b61573dc2a11fa1ac'] | Fix card browser text scaling
Update setTextSize to use absolute pixels when scaling font size because that's what getTextSize returns the value as | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1708,7 +1708,8 @@ public class CardBrowser extends NavigationDrawerActivity implements\n }\n // do no... | Kotlin |
4bdd1c0388277708f53ca491f7828f9dce112385 | 139 | 2020-03-15 10:32:44-05:00 | 18,000 | ['913f849984b8fd67f3feba703c3ffca3f52e0211'] | like desktop, allow the following characters in deck names: ( ) [ ] ' | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/ModelBrowser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/ModelBrowser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -494,7 +494,8 @@ public class ModelBrowser extends AnkiActivity {\n .onPositive((dialog, whi... | Kotlin |
83e40a6fcba46c29be2b026bc6057a2c5ce5e36c | 139 | 2020-03-15 10:32:44-05:00 | 18,000 | ['4bdd1c0388277708f53ca491f7828f9dce112385'] | like desktop, allow the following chars in field and note types: '"()[] | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/ModelFieldEditor.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/ModelFieldEditor.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -179,7 +179,7 @@ public class ModelFieldEditor extends AnkiActivity {\n .customView(mFieldNameInput,... | Kotlin |
46e8e35436c9f8d809036dd6982e0821b72241f3 | 54 | 2020-03-15 10:42:39-05:00 | -3,600 | ['88e76e727733928e606e848189b205263a527d72'] | Readability improvements in NavigationDrawerActivity
- Wrap getting current SharedPreferences in a method
- Move applying a night mode change into separate function
- Small reformat of comments and whitespace (automatically done by
Android Studio).
This is the no-op part refactoring part of PR #5686. I'd like to ge... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/NavigationDrawerActivity.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/NavigationDrawerActivity.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -44,7 +44,9 @@ import timber.log.Timber;\n \n public abstract class NavigationDrawerActivity extends... | Kotlin |
e8af637acf1c9796e57f3bac33d127ac23f0eed3 | 80 | 2020-03-15 10:47:06-05:00 | 18,000 | ['46e8e35436c9f8d809036dd6982e0821b72241f3'] | Bumped version to 2.10alpha48
@branch-specific | [{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ... | Kotlin |
86ef26cab2c9cfa138809441b11cead5150bac82 | 80 | 2020-03-15 10:48:37-05:00 | 18,000 | ['e8af637acf1c9796e57f3bac33d127ac23f0eed3'] | Bumped version to 2.10alpha49
@branch-specific | [{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ... | Kotlin |
35aac6bf1635652cb23a0c90232ed25631caaf33 | 60 | 2020-03-16 07:47:10-05:00 | -3,600 | ['86ef26cab2c9cfa138809441b11cead5150bac82'] | Add easy, due, changed, created, edited in browser
* Ease in browser
* Add due in Browser
* Adding changed, created and edited in Browser | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -73,6 +73,7 @@ import com.ichi2.libanki.Utils;\n import com.ichi2.themes.Themes;\n import com.ichi2.upgrade.Upgrade;\n import ... | Kotlin |
1334defb8c057cbbf2d2b6670195c1743b7ee2a0 | 60 | 2020-03-16 07:52:04-05:00 | -3,600 | ['35aac6bf1635652cb23a0c90232ed25631caaf33'] | ETA Subtitle in DeckPicker uses hours if >60mins
* Subtitle in DeckPicker indicates hours if more than 60 minutes
* Comment indicating ETA is in minutes
* Indicates remaining time in hours during review if necessary | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1845,7 +1845,7 @@ public abstract class AbstractFlashcardViewer extends NavigationDrawerActivity {\n ... | Kotlin |
171609e62bb6d199c08e2f57a9298ccc5cbda7da | 1 | 2020-03-16 14:48:02-05:00 | -28,800 | ['1334defb8c057cbbf2d2b6670195c1743b7ee2a0'] | Add ability to answer cards via javascript in WebView
* Update card.js
* Update AbstractFlashcardViewer.java | [{'old_path': 'AnkiDroid/src/main/assets/scripts/card.js', 'new_path': 'AnkiDroid/src/main/assets/scripts/card.js', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -64,6 +64,25 @@ function taFocus() {\n window.location.href = "signal:typefocus";\n }\n \n+/* Call displayCardAnswer() and answerCard() from anki dec... | Kotlin |
9c12b9aac281680e793b23cf32d1069dc7772a2d | 30 | 2020-03-16 15:48:10-05:00 | 0 | ['171609e62bb6d199c08e2f57a9298ccc5cbda7da'] | Gracefully handle WebView Crashes
* Fix #5780 - WebView OOM Crashes Application
Out of Memory issues in the WebView Renderer (e.g. large fonts)
were causing the application to crash and restart, going to the deck
browser.
We catch the OOM using `onRenderProcessGone()` (API >= 26) and recreate
the WebView to a... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -39,6 +39,10 @@ import android.os.Bundle;\n import android.os.Handler;\n import android.os.Message;\n ... | Kotlin |
55772d08ff83a4f82c154c2bb9de52758773dcb4 | 80 | 2020-03-16 17:05:46-05:00 | 18,000 | ['9c12b9aac281680e793b23cf32d1069dc7772a2d'] | Bumped version to 2.10alpha50
@branch-specific | [{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ... | Kotlin |
dc6179b0aba20e3f569ed2f595595be7745c54c5 | 45 | 2020-03-17 21:22:20-05:00 | -3,600 | ['55772d08ff83a4f82c154c2bb9de52758773dcb4'] | Correcting due date of cards in learning
This solve
https://github.com/ankidroid/Anki-Android/pull/5592#issuecomment-600314471 (no
Bug report associated as far as I know)
The problem was that the anki function to display time uses uses input
in second while ankidroid uses it in miliseconds. So time was
incorrect.
I ... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1366,9 +1366,9 @@ public class CardBrowser extends NavigationDrawerActivity implements\n item.put("ease", (c.getF... | Kotlin |
6fda6387b2f86a0653a9be24b31601fd9a6d43bc | 30 | 2020-03-18 09:13:56-05:00 | 0 | ['dc6179b0aba20e3f569ed2f595595be7745c54c5'] | Fix "AnkiDroid directory is inaccessible" Bug
Fixes #5097, #5510
Partially Addresses #5346 (option can still be set if somehow
preferences is the first entered screen, but I think that's
logically impossible)
This bug has been pervasive for some time, and I logically believe that
this change fixes it, although I have... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CollectionHelper.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CollectionHelper.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -27,6 +27,7 @@ import androidx.core.content.ContextCompat;\n import com.ichi2.anki.exception.StorageAccessException;... | Kotlin |
63b8ac0b275c4e1f1196d5984f2ca40656ca959d | 30 | 2020-03-18 15:37:24-05:00 | 0 | ['6fda6387b2f86a0653a9be24b31601fd9a6d43bc'] | #5708 Fix Dynamic Deck with Options defined
A dynamic deck with "conf" (Deck Options) defined will crash the
reviewer.
This adds a task to "Check Database" to remove Deck Options from any
dynamic decks.
We also set CHECK_DB_AT_VERSION, so we automatically apply this fix. | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AnkiDroidApp.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AnkiDroidApp.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -157,7 +157,7 @@ public class AnkiDroidApp extends Application {\n * collections being upgraded to (or after) this vers... | Kotlin |
4607bfc58f825b2eadcfc12f93e75879de10e83a | 30 | 2020-03-18 15:37:24-05:00 | 0 | ['63b8ac0b275c4e1f1196d5984f2ca40656ca959d'] | Review: Fix comment
Co-Authored-By: Mike Hardy <github@mikehardy.net> | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1607,7 +1607,7 @@ public class Collection {\n ArrayList<String> problems = new ArrayList<>();\n long oldS... | Kotlin |
cdc55efcd087d4d11362e6f869af65908bf2a953 | 30 | 2020-03-18 15:37:24-05:00 | 0 | ['4607bfc58f825b2eadcfc12f93e75879de10e83a'] | Fix DB Check version due to alpha upgrade
Co-Authored-By: Mike Hardy <github@mikehardy.net> | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AnkiDroidApp.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AnkiDroidApp.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -157,7 +157,7 @@ public class AnkiDroidApp extends Application {\n * collections being upgraded to (or after) this vers... | Kotlin |
533592b44a2cfc0c7453e8f45eaefade71a1d3ce | 30 | 2020-03-18 15:57:25-05:00 | 0 | ['cdc55efcd087d4d11362e6f869af65908bf2a953'] | Fix #5811 - Clicking hint field blocks key input
Using a bluetooth mouse and keyboard, clicking a `{{hint:}}` field
focused the WebView, disabling navigation via the keyboard and leaving
a permanent text bar input cursor when hovering over the WebView. | [{'old_path': 'AnkiDroid/src/main/assets/scripts/card.js', 'new_path': 'AnkiDroid/src/main/assets/scripts/card.js', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -58,6 +58,17 @@ var resizeImages = function() {\n resizeDone = true;\n };\n \n+/* Tell the app that we no longer want to focus the WebView and should ... | Kotlin |
f1db61d197191a813c1969edd49fb579eb0e85eb | 30 | 2020-03-18 15:59:06-05:00 | 0 | ['533592b44a2cfc0c7453e8f45eaefade71a1d3ce'] | NF: Removed unnecessary method
We were loading preferences, but not using them.
Context:
Usage removed in 2da08a086c417acc42de813d2714a3ce7261947f, but method
remained. | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsActivity.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsActivity.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -83,7 +83,6 @@ public class StudyOptionsActivity extends NavigationDrawerActivity implements St\n public... | Kotlin |
0bc0535c2d3e015d0a66da18aee75a7afcef41b7 | 30 | 2020-03-18 15:59:06-05:00 | 0 | ['f1db61d197191a813c1969edd49fb579eb0e85eb'] | StudyOptions: Unconditionally process arguments
Arguments were previously unset if there was no associated view. | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -20,6 +20,7 @@ import android.content.Intent;\n import android.content.res.Resources;\n import android.os.Bu... | Kotlin |
4e280e24e34e072423997ef40a05b2d316ed98fa | 30 | 2020-03-18 15:59:06-05:00 | 0 | ['0bc0535c2d3e015d0a66da18aee75a7afcef41b7'] | NF: Remove references to mStudyOptionsView
I want to add a Nullable annotation to the variable and want to remove
references to the local | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -20,6 +20,7 @@ import android.content.Intent;\n import android.content.res.Resources;\n import android.os.Bu... | Kotlin |
0c35ba953bcba3b54970d805cbda13541f3c2830 | 30 | 2020-03-18 15:59:06-05:00 | 0 | ['4e280e24e34e072423997ef40a05b2d316ed98fa'] | #5506: Only refresh view when view exists
We can be in this state without an associated View.
If so, don't perform any view-related operations | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -551,6 +551,13 @@ public class StudyOptionsFragment extends Fragment implements Toolbar.OnMenuItem\n ... | Kotlin |
8a5fd48d1dfe85e7b01849005004175e1a092378 | 30 | 2020-03-18 15:59:06-05:00 | 0 | ['0c35ba953bcba3b54970d805cbda13541f3c2830'] | NF: Marked mStudyOptionsView as nullable
#5506 was caused by this being null | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -82,6 +82,7 @@ public class StudyOptionsFragment extends Fragment implements Toolbar.OnMenuItem\n /**\n ... | Kotlin |
f1ac587bc8737624a2ff540787d420db5454b9db | 80 | 2020-03-18 16:33:10-05:00 | 18,000 | ['8a5fd48d1dfe85e7b01849005004175e1a092378'] | Bumped version to 2.10alpha51
@branch-specific | [{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ... | Kotlin |
fbb115f372867c0867d9dd81b2bd1bd2f55528f9 | 30 | 2020-03-19 17:14:38-05:00 | 0 | ['f1ac587bc8737624a2ff540787d420db5454b9db'] | Fix #5253 - Deck Options Corruption on Export
User complaint that exporting a deck reset the deck options to 1.
This also appears to have been the cause of a dynamic deck having
options, and therefore being corrupted. #5708
We fix this via an inefficient deep clone. | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/AnkiPackageExporter.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/AnkiPackageExporter.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -192,11 +192,13 @@ class AnkiExporter extends Exporter {\n dconfs.put(Long.toString(... | Kotlin |
715787bfa341825ad10c6cad33e10f420848d223 | 30 | 2020-03-19 19:28:38-05:00 | 0 | ['fbb115f372867c0867d9dd81b2bd1bd2f55528f9'] | #5595: Display Current Interval on Reschedule
User requested interval data in dialog to assist them in selecting a
new interval | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -973,10 +973,23 @@ public class CardBrowser extends NavigationDrawerActivity implements\n case R.id.action_resched... | Kotlin |
615b06377fb5d335b02f0261335bc88c83a4350b | 30 | 2020-03-19 19:28:38-05:00 | 0 | ['715787bfa341825ad10c6cad33e10f420848d223'] | NF: Refactor RescheduleDialog into class | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -57,6 +57,7 @@ import com.ichi2.anki.dialogs.CardBrowserMySearchesDialog;\n import com.ichi2.anki.dialogs.CardBrowserOrderDial... | Kotlin |
a911bc28cee20c1cc027312f4f15caf6e8c541da | 30 | 2020-03-19 19:28:38-05:00 | 0 | ['615b06377fb5d335b02f0261335bc88c83a4350b'] | Reschedule Dialog - convert to plural | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/dialogs/RescheduleDialog.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/dialogs/RescheduleDialog.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -62,7 +62,7 @@ public class RescheduleDialog extends IntegerDialog {\n return null;\n ... | Kotlin |
bdb3ffbd17620d3d25f9a676ba627d63821ce233 | 30 | 2020-03-19 19:28:38-05:00 | 0 | ['a911bc28cee20c1cc027312f4f15caf6e8c541da'] | NF: Extract Supplier<T> to FunctionalInterfaces | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/preferences/PreferenceExtensions.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/preferences/PreferenceExtensions.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,6 +2,8 @@ package com.ichi2.preferences;\n \n import android.content.SharedPreferences;\n \... | Kotlin |
1aedc0a9cd8fab7302d25c93839dc96d161d27a8 | 30 | 2020-03-19 19:28:38-05:00 | 0 | ['bdb3ffbd17620d3d25f9a676ba627d63821ce233'] | NF: Refactor to FunctionalInterfaces.Consumer | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -73,6 +73,7 @@ import com.ichi2.libanki.Note;\n import com.ichi2.libanki.Utils;\n import com.ichi2.themes.Themes;\n import com... | Kotlin |
00c7fb1ae5b8668e7775c639a5f936e4bf3528ed | 30 | 2020-03-19 19:28:38-05:00 | 0 | ['1aedc0a9cd8fab7302d25c93839dc96d161d27a8'] | NF: IntegerDialog - Improve comment | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/dialogs/IntegerDialog.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/dialogs/IntegerDialog.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -44,7 +44,7 @@ public class IntegerDialog extends AnalyticsDialogFragment {\n .inputRange(... | Kotlin |
c1bbc71fbaa7e8c713723b3b0089a6c73e177366 | 30 | 2020-03-19 19:28:38-05:00 | 0 | ['00c7fb1ae5b8668e7775c639a5f936e4bf3528ed'] | NF: Review - Remove full imports | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/preferences/PreferenceExtensions.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/preferences/PreferenceExtensions.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,7 +2,7 @@ package com.ichi2.preferences;\n \n import android.content.SharedPreferences;\n \... | Kotlin |
75d59fd87b9b9a20b4324f7644a6cd37413d7ebb | 80 | 2020-03-19 19:35:26-05:00 | 18,000 | ['efe4095ff32fcdacfb542d016d4de24d2f4818ad'] | Bumped version to 2.10alpha52
@branch-specific | [{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ... | Kotlin |
d0346797852d9a088530c0105375bad318fab785 | 30 | 2020-03-20 08:22:13-05:00 | 0 | ['75d59fd87b9b9a20b4324f7644a6cd37413d7ebb'] | #5643 - Filter Additional Media for Export
Our code intends to find media beginning with "_" and only include it
when it's valid in the CSS or a formatted answer. This was devised to
ensure that we don't export massive and unused CJK fonts.
See: https://github.com/ankitects/anki/pull/114
This didn't work, as we pass... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/AnkiPackageExporter.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/AnkiPackageExporter.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -233,8 +233,8 @@ class AnkiExporter extends Exporter {\n String fname = f.getName();... | Kotlin |
6452c3720973401c2df49ce97494f5e11b52d85f | 80 | 2020-03-20 14:34:35-05:00 | 18,000 | ['d0346797852d9a088530c0105375bad318fab785'] | Enable full database check to repair collections with #5708 | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -994,9 +994,9 @@ public class DeckPicker extends NavigationDrawerActivity implements\n // Skip full DB check if the ... | Kotlin |
f1c305c247f5e08d21563fd3d6c732058c7ae070 | 80 | 2020-03-20 15:09:32-05:00 | 18,000 | ['06885600188677414ea6b9248d52005f317f3f7b'] | Bumped version to 2.10alpha53
@branch-specific | [{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ... | Kotlin |
5256adb5503bfff3cf37a9250e6c29f37262f167 | 60 | 2020-03-21 09:10:21-05:00 | -3,600 | ['f1c305c247f5e08d21563fd3d6c732058c7ae070'] | Clean manifest (#5597)
* Add missing tabs
* Adding name as top of xml
I believe that name (and then label) are the most relevant things you
may see in an activity manifest. So I moved it top
* Ending symbol of multiline xml tag on their own line
When a multiline tag is edited, sometime, there are use... | [{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -23,7 +23,8 @@\n package="com.ichi2.anki"\n android:installLocation="auto"\n android:versionCode="21000153"\n- android:ve... | Kotlin |
9ac8f898d7335390d0279d9d04de13db1319ce3e | 30 | 2020-03-21 09:22:25-05:00 | 0 | ['5256adb5503bfff3cf37a9250e6c29f37262f167'] | Avoid answer button display / ease calculation in Preview
* NF: Rename showEaseButtons
to displayAnswerBottomBar
* #5756 - Fix Dynamic Card Preview Crash
Previewing a card currently performs displayAnswerBottomBar which
requires an ease calculation.
The ease calculation depends on the current deck, and is... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1729,92 +1729,13 @@ public abstract class AbstractFlashcardViewer extends NavigationDrawerActivity {\... | Kotlin |
02d5d764f9fd19a6750f5799cfaa920700321a14 | 80 | 2020-03-21 12:24:32-05:00 | 18,000 | ['9ac8f898d7335390d0279d9d04de13db1319ce3e'] | Fix formatting error in AndroidManifest
This was a remnant from #5597 picked up in the new lint check
after approving the PR | [{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -179,11 +179,11 @@\n </activity>\n <activity\n android:name="com.ichi2.anki.DeckPicker"\n- android:label="@string/app_nam... | Kotlin |
e0fc58111448f133fdcf6df35012a5f2e9156744 | 60 | 2020-03-21 14:58:55-05:00 | -3,600 | ['02d5d764f9fd19a6750f5799cfaa920700321a14'] | Fix one more card status due date (ms to s) in browser | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Card.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Card.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -715,7 +715,7 @@ public class Card implements Cloneable {\n } else if (getQueue() == 0 || getType() == 0) {\n retu... | Kotlin |
bf4ce65d58f50df5bfb2c7065ceac45e0fe99ee8 | 30 | 2020-03-21 14:59:49-05:00 | 0 | ['e0fc58111448f133fdcf6df35012a5f2e9156744'] | #5740 - Add Dialog Requesting Permissions
Some users din't feel comfortable about us requiring access to
external storage.
We explain that we don't perform any malicious activities with this
in order to hopefully alleviate concerns. | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -41,12 +41,13 @@ import android.os.Bundle;\n import android.os.Message;\n import android.os.ParcelFileDescriptor;\n import andro... | Kotlin |
17aa22017092ba601aa67759884a996d68706d79 | 80 | 2020-03-22 10:55:54-05:00 | 18,000 | ['bf4ce65d58f50df5bfb2c7065ceac45e0fe99ee8'] | Allow Travis CI macOS failures temporarily
Upstream macOS instability issue tracked here:
https://travis-ci.community/t/macos-build-an-error-occurred-while-generating-the-build-script/7684/15 | [{'old_path': '.travis.yml', 'new_path': '.travis.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -69,6 +69,7 @@ jobs:\n script: echo finalize codacy coverage uploads\n allow_failures:\n - env: API=24 JDK="1.11" # non-default JDKs should not hold up success reporting\n+ - os: osx # Until macos is... | Kotlin |
2353c84b3a23c3f82c514b87c7314fb472aa38c0 | 30 | 2020-03-22 11:19:14-05:00 | 0 | ['17aa22017092ba601aa67759884a996d68706d79'] | Gracefully handle Bitmap Compression Failure
* NF: BitmapUtil - Dispose Resources on failure
* Fix #5513 - Don't crash if we can't compress images
Sometimes, the `rotateAndCompress` method could fail, causing a crash.
Instead, we return the uncompressed image, and display both the file
size and a warning tha... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/multimediacard/fields/BasicImageFieldController.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/multimediacard/fields/BasicImageFieldController.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -28,19 +28,25 @@ import android.content.Intent;\n impo... | Kotlin |
eb89b5b9e64c945e5c4a53494f45cf3b1629f625 | 30 | 2020-03-22 11:46:55-05:00 | 0 | ['2353c84b3a23c3f82c514b87c7314fb472aa38c0'] | Fix permission handling in Multimedia editor
* NF: Extract Permissions to Class
* Ensure we have permissions before audio recording
We can get to the AudioView screen from the pronunciation screen,
this is a one-way transition, and should succeed, even if we can't
use the screen to record audio.
* NF: Extract... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AnkiDroidApp.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AnkiDroidApp.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -43,6 +43,7 @@ import com.ichi2.anki.services.NotificationService;\n import com.ichi2.compat.CompatHelper;\n import com.ichi... | Kotlin |
ab9b9354a4990b872ad4d5dcc391fb3aec9baaf4 | 30 | 2020-03-22 14:01:02-05:00 | 0 | ['eb89b5b9e64c945e5c4a53494f45cf3b1629f625'] | Persist Whiteboard Visible State
* Extract: getTableColumnCount
* Extract: getScalarBoolean
* Extract: updateWidgetStatus
* #5065 - Persist Whiteboard Visible State
Previously, the whiteboard visible state depended on the enabled state
This caused problems when switching from Night Mode.
Now, the preferenc... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/MetaDB.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/MetaDB.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -27,7 +27,7 @@ public class MetaDB {\n private static final String DATABASE_NAME = "ankidroid.db";\n \n /** The Database Version... | Kotlin |
a2f8c09475c240d98e9373076ffdacc9683d05bd | 80 | 2020-03-22 15:15:22-05:00 | 18,000 | ['ab9b9354a4990b872ad4d5dcc391fb3aec9baaf4'] | Bumped version to 2.10alpha54
@branch-specific | [{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ... | Kotlin |
a9c689b434bd836c47e5b3d7d7e52f5e65e5d65a | 30 | 2020-03-24 08:19:02-05:00 | 0 | ['a2f8c09475c240d98e9373076ffdacc9683d05bd'] | Fix Crash on Previewing Existing Image
* Fix #5856 - Image Preview Crash
When loading an existing image, we performed the image load before we
had created all elements of the UI. This caused issues.
We fix this by splitting UI creation and initialisation logic
* Fix #5856 - Fix API Errors
createUI has `@S... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/multimediacard/activity/MultimediaEditFieldActivity.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/multimediacard/activity/MultimediaEditFieldActivity.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -25,6 +25,7 @@ import android.content.pm.Packa... | Kotlin |
11d6a6f2470137824ad973019d2b08f335628b20 | 30 | 2020-03-24 13:46:12-05:00 | 0 | ['2dd867f87f1f410504681d667ab208731bc78131'] | Add File Space Warning before Check Database
* Extract: performIntegrityCheck
We want to add in a dialog box under certain circumstances, this is the
first step, as it allows us to conditionally call the 'meat' of the
method without changing the public signature
* Extract method: getFreeDiscSpace
* Check Data... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/BackupManager.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/BackupManager.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -17,12 +17,13 @@\n package com.ichi2.anki;\n \n import android.content.SharedPreferences;\n-import android.os.StatFs;\n \n... | Kotlin |
42b33d1b4e1dab9ba948b5a3ef317de209d0513e | 30 | 2020-03-24 14:22:56-05:00 | 0 | ['11d6a6f2470137824ad973019d2b08f335628b20'] | fixIntegrity Refactor / Instrument+continue if field count fix fails
* Refactor: notifyProgress
* Extract: deleteNotesWithMissingModel
* Extract: deleteCardsWithInvalidModelOrdinals
* Extract: deleteNotesWithWrongFieldCounts
* Extract: deleteNotesWithMissingCards
* Extract: deleteCardsWithMissingNotes
* Extract:... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -36,6 +36,7 @@ import com.ichi2.libanki.exception.NoSuchDeckException;\n import com.ichi2.libanki.hooks.Hooks;\n import co... | Kotlin |
cdfd24fb1fec8ef31f5c2ff8df05c6a9c5da3ff0 | 30 | 2020-03-24 14:27:03-05:00 | 0 | ['42b33d1b4e1dab9ba948b5a3ef317de209d0513e'] | Calculate scheduler limits for sync using AnkiWeb limit
Fixes #5666 - Sync Failure on Large Dynamic Decks
We modified `mReportLimit` in #5326 to allow a user to see how many
cards they had if there were more than 1000 in a queue.
This had an impact on calculating the number of cards in the current
deck, which ... | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2199,4 +2199,17 @@ public class Collection {\n return mContext;\n }\n \n+ /** Not in libAnki */\n+\n+ /... | Kotlin |
3c77850f141eb9f87c4837eb0225510d3559e2cd | 80 | 2020-03-24 15:12:56-05:00 | 18,000 | ['cdfd24fb1fec8ef31f5c2ff8df05c6a9c5da3ff0'] | Bumped version to 2.10alpha55
@branch-specific | [{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ... | Kotlin |
fe692b1471e5cd4d36e3391b2939f0f9660474b6 | 80 | 2020-03-24 15:24:01-05:00 | 18,000 | ['3c77850f141eb9f87c4837eb0225510d3559e2cd'] | Bump database check version to exercise #5854 | [{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AnkiDroidApp.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AnkiDroidApp.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -158,7 +158,7 @@ public class AnkiDroidApp extends Application {\n * collections being upgraded to (or after) this vers... | Kotlin |
892c44c4a477f70fb01a56cf8b74835fd64c38f9 | 80 | 2020-03-24 15:25:19-05:00 | 18,000 | ['fe692b1471e5cd4d36e3391b2939f0f9660474b6'] | Bumped version to 2.10alpha56
@branch-specific | [{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ... | Kotlin |