Search is not available for this dataset
hash
string
author
int32
committer_date
string
timezone
int64
parents
string
message
string
changes
string
language
string
b49ae1c9372da03f3f2c2bfac348ce8b4627f1d8
124
2019-07-05 09:29:10+09:00
-32,400
['7b0bc2078fd91d9e515dc30d719ada0849018071']
Skip DB integrity check, unless basic check fails
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -989,8 +989,15 @@ public class DeckPicker extends NavigationDrawerActivity implements\n return;\n }\...
Kotlin
4342f66f4231366b63309cd1713ed5890afd330f
124
2019-07-05 09:31:50+09:00
-32,400
['b49ae1c9372da03f3f2c2bfac348ce8b4627f1d8']
Bumped version to 2.9alpha79 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
0118463c2d7c4ba9112cd39ea6b0f92c547ba66e
53
2019-07-07 21:56:54+09:00
18,000
['4342f66f4231366b63309cd1713ed5890afd330f']
Fixes display of $ and \ in typed answers.
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -694,11 +694,14 @@ public abstract class AbstractFlashcardViewer extends NavigationDrawerActivity {\n ...
Kotlin
8978dc82a5c64590b90bf335af01e31eea308cab
53
2019-07-07 21:56:54+09:00
18,000
['0118463c2d7c4ba9112cd39ea6b0f92c547ba66e']
Adds tests for the typed answer filter.
[{'old_path': None, 'new_path': 'AnkiDroid/src/test/java/com/ichi2/anki/AbstractFlashcardViewerTest.java', 'type': <ModificationType.ADD: 1>, 'diff': '@@ -0,0 +1,228 @@\n+package com.ichi2.anki;\n+\n+import org.junit.Test;\n+import org.junit.runner.RunWith;\n+\n+import java.lang.reflect.InvocationTargetException;\n+imp...
Kotlin
6fcf8f15614a2d32d39424750a8698fa7643167a
115
2019-07-07 22:00:40+09:00
-43,200
['8978dc82a5c64590b90bf335af01e31eea308cab']
Deprecation/issue 5017 use new should override url loading (#5370) Replace the use of deprecated URLDecoder.decode(string)
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,6 +22,7 @@\n package com.ichi2.anki;\n \n import android.annotation.SuppressLint;\n+import android...
Kotlin
2e53e29d117640dabec9a456253170c9dbfb52a7
124
2019-07-07 22:22:22+09:00
-32,400
['6fcf8f15614a2d32d39424750a8698fa7643167a']
Bumped version to 2.9alpha80 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
938566a8963cad3b2e89f213567b5e89bd77550d
53
2019-07-19 06:30:56+09:00
18,000
['05ac48c7fc1049ff275d1576293308211558dff8']
Adds CSS to hide content until MathJax renders. (#5382)
[{'old_path': None, 'new_path': 'AnkiDroid/src/main/assets/mathjax/mathjax.css', 'type': <ModificationType.ADD: 1>, 'diff': '@@ -0,0 +1,3 @@\n+.mathjax-hasnt-rendered-yet {\n+ visibility: hidden;\n+}\n\\ No newline at end of file\n'}, {'old_path': 'AnkiDroid/src/main/assets/scripts/card.js', 'new_path': 'AnkiDroid/src...
Kotlin
db6988b310119273f18f1662546887c024b2c1b0
80
2019-07-20 09:42:31+09:00
14,400
['b7f55e19cce15805738dc0d7e50151c1f79af90e']
update google auto-service from 1.0-rc5 to 1.0-rc6
[{'old_path': 'AnkiDroid/build.gradle', 'new_path': 'AnkiDroid/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -163,7 +163,7 @@ task jacocoUnitTestReport(type: JacocoReport, dependsOn: [\'testDebugUnitTest\'])\n \n dependencies {\n compileOnly "com.google.auto.service:auto-service-annotations:1.0-r...
Kotlin
0e1c5351cc992df61d2130e502f1efd2edc496c6
80
2019-07-20 09:42:31+09:00
14,400
['db6988b310119273f18f1662546887c024b2c1b0']
Update analytics to 2.0.9 / okhttp back to 3.12.x / Android 4.x The previous analytics 2.0.8 version and a related change here brought in okhttp 4.x which does not work with Android 4.x Until we move to API21 as a minimum version, we can't use okhttp 4.x In fact, until we move to API19 as minimum, we must use okhttp...
[{'old_path': 'AnkiDroid/build.gradle', 'new_path': 'AnkiDroid/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -185,8 +185,8 @@ dependencies {\n implementation'ch.acra:acra-toast:5.2.1'\n implementation'ch.acra:acra-limiter:5.2.1'\n \n- implementation 'net.mikehardy:google-analytics-java7:2....
Kotlin
3d91bc0a1117c853e5904ab888150db9995743ec
113
2019-07-26 08:22:03+09:00
-43,200
['0e1c5351cc992df61d2130e502f1efd2edc496c6']
WIP #5021 Move Text to speech API
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/ReadText.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/ReadText.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -26,10 +26,11 @@ import android.view.View;\n import android.widget.Toast;\n \n import com.afollestad.materialdialogs.MaterialDialog;...
Kotlin
b7dbfde310cc8e72f3c93a3d6a8e7a73f1e7d103
53
2019-07-27 22:16:31+09:00
18,000
['3d91bc0a1117c853e5904ab888150db9995743ec']
Adds CSS to hide content until MathJax renders.
[]
Kotlin
95087f50410ff58fe5a8e914ca6462b53b74fe53
53
2019-07-27 22:16:31+09:00
18,000
['b7dbfde310cc8e72f3c93a3d6a8e7a73f1e7d103']
Detects Mathjax in cards and only renders MathJax if necessary.
[{'old_path': 'AnkiDroid/src/main/assets/mathjax/mathjax.css', 'new_path': 'AnkiDroid/src/main/assets/mathjax/mathjax.css', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,3 +1,3 @@\n-.mathjax-hasnt-rendered-yet {\n+.mathjax-needs-to-render {\n visibility: hidden;\n }\n'}, {'old_path': 'AnkiDroid/src/main/assets...
Kotlin
7f025703eaedfee30a3be30ef84efbfdb6f610da
85
2019-08-19 23:32:24+09:00
-36,000
['683b73f20aa7cfaa1eca22190886da0509ef4937']
fix v2 relearning reset bug https://github.com/dae/anki/commit/9fc4b555758cccedfc5e5982e64dcd0d66b342ef
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/SchedV2.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/SchedV2.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2551,8 +2551,18 @@ public class SchedV2 extends Sched {\n \n \n private void _removeAllFromLearning() {\n+ _removeAl...
Kotlin
86154e00bd02e31abcc51360618e1b70c568780f
85
2019-08-19 23:32:24+09:00
-36,000
['7f025703eaedfee30a3be30ef84efbfdb6f610da']
ensure random distribution of due cards for a given day in v2 sched https://github.com/dae/anki/commit/4dde7b13d05b118ac9a0c0b6d7359337391ea02e
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/SchedV2.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/SchedV2.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1325,7 +1325,7 @@ public class SchedV2 extends Sched {\n .getDatabase()\n .quer...
Kotlin
2c890c116ec73578618d4844eb7a167ade4a83c2
101
2019-08-21 10:39:31+09:00
-28,800
['86154e00bd02e31abcc51360618e1b70c568780f']
fixed the NullpointerException in com.ichi2.util.ImportUtils and com.ichi2.anki.NoteEditor
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/NoteEditor.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/NoteEditor.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -314,10 +314,16 @@ public class NoteEditor extends AnkiActivity {\n savedInstanceState.putInt("caller", mCaller);\n ...
Kotlin
31b9e708532b7bd679176a1bfac5ce323c1d6376
80
2019-08-28 19:41:36-05:00
18,000
['2c890c116ec73578618d4844eb7a167ade4a83c2']
Use black for navigation bar in dark theme
[{'old_path': 'AnkiDroid/src/main/res/values-v21/styles.xml', 'new_path': 'AnkiDroid/src/main/res/values-v21/styles.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -8,9 +8,11 @@\n </style>\n <style name="Theme_Dark_Compat" parent="Theme_Dark">\n <item name="currentDeckBackground">@drawable/item_...
Kotlin
54a541eb726d463103ccc1b7440f1214354bd001
77
2019-08-29 15:46:25-05:00
25,200
['31b9e708532b7bd679176a1bfac5ce323c1d6376']
Update Android Gradle plugin to 3.5.0
[{'old_path': 'build.gradle', 'new_path': 'build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -7,7 +7,7 @@ buildscript {\n jcenter()\n }\n dependencies {\n- classpath \'com.android.tools.build:gradle:3.4.2\'\n+ classpath \'com.android.tools.build:gradle:3.5.0\'\n clas...
Kotlin
2136b55509ef4684298463dd72e2bd4aa7b901a3
77
2019-08-29 15:46:25-05:00
25,200
['54a541eb726d463103ccc1b7440f1214354bd001']
Update Gradle wrapper to 5.6.1
[{'old_path': 'gradle.properties', 'new_path': 'gradle.properties', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -1,5 +1,28 @@\n-android.enableJetifier=true\n+# Project-wide Gradle settings.\n+\n+# IDE (e.g. Android Studio) users:\n+# Gradle settings configured through the IDE *will override*\n+# any settings spec...
Kotlin
7ca6710fbdc1ed51982e5ba314ed74a49de0681e
129
2019-09-09 22:49:02+09:00
-7,200
['2cc4c46125223595edbab6c4a24877551dd620e2']
Stop all sounds on card deletion.
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1195,6 +1195,7 @@ public abstract class AbstractFlashcardViewer extends NavigationDrawerActivity {\n ...
Kotlin
32a2d90ddec5aca717cbec20b1bfdc991efb8e1c
53
2019-09-12 10:00:48-05:00
18,000
['7ca6710fbdc1ed51982e5ba314ed74a49de0681e']
Allow newlines in cloze deletions.
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Models.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Models.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -46,7 +46,8 @@ import java.util.regex.Pattern;\n public class Models {\n private static final Pattern fClozePattern1 = Pattern...
Kotlin
bfa2ed47996d3e52ffaf058102cb7596ccd4990b
53
2019-09-12 10:00:48-05:00
18,000
['32a2d90ddec5aca717cbec20b1bfdc991efb8e1c']
Add test for greedy multiline clozes. Adjust regex to better match Anki Desktop's.
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Models.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Models.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -46,9 +46,7 @@ import java.util.regex.Pattern;\n public class Models {\n private static final Pattern fClozePattern1 = Pattern...
Kotlin
c58a38a80410cdd9aa4071e49a8bfe2b4f24e9dc
43
2019-09-13 07:06:35-05:00
14,400
['bfa2ed47996d3e52ffaf058102cb7596ccd4990b']
Allow connections to user-trusted CAs For custom sync servers. Closes #5423
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -84,7 +84,8 @@\n android:label="@string/app_name"\n android:windowSoftInputMode="adjustResize"\n android:usesCleartextTraffic="true"\n- ...
Kotlin
114e49b11772c8b1f0979c13da64a505000e9de1
112
2019-09-16 23:37:30+09:00
-7,200
['c58a38a80410cdd9aa4071e49a8bfe2b4f24e9dc']
Retire old icon with monolith
[{'old_path': 'docs/graphics/src/anki.svg', 'new_path': 'docs/graphics/legacy/anki.svg', 'type': <ModificationType.RENAME: 3>, 'diff': ''}]
Kotlin
f19ef85446b93fe8ff19e45fb01ff2e27dbd89ae
112
2019-09-16 23:37:30+09:00
-7,200
['114e49b11772c8b1f0979c13da64a505000e9de1']
Add new sources for adaptive icon anki.svg is the complete updated and simplified square SVG without the monolith, while the other two are the separated foreground and background respectively for the adaptive icon layers.
[{'old_path': None, 'new_path': 'docs/graphics/src/anki.svg', 'type': <ModificationType.ADD: 1>, 'diff': '@@ -0,0 +1,59 @@\n+<?xml version="1.0" encoding="UTF-8"?>\n+<svg x="0px" y="0px" width="192px" height="192px" viewBox="0 0 192 192">\n+ <g id="background">\n+ <path d="M 0,0 H 192 V 192 H 0 Z" id="backgro...
Kotlin
704eea3b05deab3e1b0feea0042de525b13981a6
112
2019-09-16 23:37:30+09:00
-7,200
['f19ef85446b93fe8ff19e45fb01ff2e27dbd89ae']
Use new SVGs to create updated adaptive icon The new launcher icon was generated with Android Studio. There was no trimming of whitespace and the zoom level for both foreground and background was set to 68%.
[{'old_path': 'AnkiDroid/src/main/ic_launcher-web.png', 'new_path': 'AnkiDroid/src/main/ic_launcher-web.png', 'type': <ModificationType.MODIFY: 5>, 'diff': 'Binary files a/AnkiDroid/src/main/ic_launcher-web.png and b/AnkiDroid/src/main/ic_launcher-web.png differ\n'}, {'old_path': None, 'new_path': 'AnkiDroid/src/main/r...
Kotlin
625be8dd59863d42028a4ca61a9b6cfdcf98112f
89
2019-09-18 08:10:45+09:00
-7,200
['f3b25e1bd1af227825a520ace2352cfb609e0a5e']
Modified icon to better fit adaptive icon shapes
[{'old_path': 'AnkiDroid/src/main/ic_launcher-web.png', 'new_path': 'AnkiDroid/src/main/ic_launcher-web.png', 'type': <ModificationType.DELETE: 4>, 'diff': 'Binary files a/AnkiDroid/src/main/ic_launcher-web.png and /dev/null differ\n'}, {'old_path': 'AnkiDroid/src/main/res/drawable-v24/ic_launcher_background.xml', 'new...
Kotlin
3593ddd055d21111a0e3b34f62720fd51fbb1c94
80
2019-10-02 12:30:41+09:00
18,000
['625be8dd59863d42028a4ca61a9b6cfdcf98112f']
chore: dependency updates (okhttp, play publishing, junit)
[{'old_path': 'AnkiDroid/build.gradle', 'new_path': 'AnkiDroid/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,6 +1,6 @@\n plugins {\n // Gradle plugin portal \n- id \'com.github.triplet.play\' version \'2.3.0\'\n+ id \'com.github.triplet.play\' version \'2.4.1\'\n }\n \n apply plugin: \'com.androi...
Kotlin
5572b8ecbcaf8294ef37fede0bb1828eedaaeed3
124
2019-10-07 16:45:41+09:00
-46,800
['935a28eaae8b3091949d38b8978bdde4cec4e962']
use separate .colpkg extension for collection exports See dae/anki@0c80b545 Fixes #5107 Note: There is still some refactoring required to fully capture dae/anki@0c80b545 This is purely due to my laziness and the urgency of the current issue
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -101,6 +101,7 @@\n <action android:name="android.intent.action.VIEW" />\n <category android:name="android.intent.category.DEFAUL...
Kotlin
f8a6e6d6ad26d22457ca9c3d9c6d82c996a16873
124
2019-10-07 16:45:41+09:00
-46,800
['5572b8ecbcaf8294ef37fede0bb1828eedaaeed3']
Fix note editor not starting on API16
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/NoteEditor.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/NoteEditor.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1129,10 +1129,10 @@ public class NoteEditor extends AnkiActivity {\n View editline_view = getLayoutInflater().infla...
Kotlin
ddc4fa8918409c6a0566b8fd159b6787b60034c8
124
2019-10-07 16:45:41+09:00
-46,800
['f8a6e6d6ad26d22457ca9c3d9c6d82c996a16873']
Give option to save apkg to filesystem on API <19
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -111,6 +111,7 @@ import org.json.JSONObject;\n \n import java.io.File;\n import java.io.FileOutputStream;\n+import java.io.IOExc...
Kotlin
16fe468689c714c59b54983ed57c761702730cb6
124
2019-10-08 00:06:54+09:00
-46,800
['ddc4fa8918409c6a0566b8fd159b6787b60034c8']
Only clear CardBrowser deck when starting app for first time Otherwise the last deck is forgotten everytime we open the DeckPicker via the navigation drawer
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AnkiDroidApp.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AnkiDroidApp.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -227,6 +227,9 @@ public class AnkiDroidApp extends Application {\n DEFAULT_SWIPE_MIN_DISTANCE = vc.getScaledPagingTo...
Kotlin
439136137436711204d198e8e45d04c84d6fe777
80
2019-10-10 16:51:38+13:00
18,000
['5e12c24c2c431fbba0b114d2712e9ba2a6aa2bfc']
Commit auto-altered codestyle from Android Studio 3.5.x
[{'old_path': '.idea/codeStyles/Project.xml', 'new_path': '.idea/codeStyles/Project.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -24,17 +24,8 @@\n <package name="" withSubpackages="true" static="true" />\n </value>\n </option>\n- <option name="RIGHT_MARGIN" value="100" />\n- <AndroidX...
Kotlin
026537ed47c542c7e2f6552f9bf684b7883e21bd
80
2019-10-16 10:54:18+13:00
18,000
['50419ba4358faa2bb3051bc9ef750c51a48a992c']
fix format string error in hu-HU import progress string Fixes #5501 I also fixed it on crowdin for future exports https://crowdin.com/translate/ankidroid/7303/en-hu#6534325
[]
Kotlin
c71c2fe04dabaff09346202ce8aaeadd745785f4
45
2019-10-16 21:04:19+09:00
-7,200
['026537ed47c542c7e2f6552f9bf684b7883e21bd']
Correct edition of card in filtered deck I believe that this pull request corrects issue #3200, issue #3409 and issue #5184(this is the best report, it gives a LOT of details) which seems to be thrice the same trouble. The note editor contains a list of deck. This allows to select in which deck to put the cards of th...
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/NoteEditor.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/NoteEditor.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -461,8 +461,7 @@ public class NoteEditor extends AnkiActivity {\n try {\n // add current deck and al...
Kotlin
4f268342e86c082ea1aac9a11d79d12847e12add
45
2019-10-17 08:31:30+09:00
-7,200
['c71c2fe04dabaff09346202ce8aaeadd745785f4']
fix negative due dates in filtered decks https://anki.tenderapp.com/discussions/ankidesktop/35978-rebuilding-filtered-deck-on-experimental-v2-empties-deck-and-reschedules-to-the-year-1745 this means affected cards will not have the selected ordering applied, but that seems preferable to the alternatives dae/anki@d46...
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/SchedV2.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/SchedV2.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1764,7 +1764,7 @@ public class SchedV2 extends Sched {\n \n mCol.getDb().executeMany(\n "UPDATE cards S...
Kotlin
ca42304ff4623d72cc34087b9c0281cb3da80aa9
45
2019-10-17 08:33:09+09:00
-7,200
['4f268342e86c082ea1aac9a11d79d12847e12add']
Clears undo before changing schedulers dae/anki@9069d282a2cf7d0e8977631284c2945109a66dc4
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -223,6 +223,7 @@ public class Collection {\n }\n modSchema(true);\n SchedV2 v2Sched = new SchedV2(...
Kotlin
c8a20afbc0b8fd551abc320071157339d41cbb0e
45
2019-10-17 08:36:12+09:00
-7,200
['ca42304ff4623d72cc34087b9c0281cb3da80aa9']
New card with same due are shown according to their ord This commit corrects the following bug: * Create a note N in an empty deck D of type basic (reverse), with only some back, no front. Only card 2 will be generated. * Edit the note, add a front. Card 1 will be generated. * In the main window, try to learn deck D....
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Sched.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Sched.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -619,7 +619,7 @@ public class Sched {\n cur = mCol\n .getDb()\n ...
Kotlin
9c82749461323cd5b8910bbed59a9f5388f513a3
45
2019-10-17 08:39:09+09:00
-7,200
['c8a20afbc0b8fd551abc320071157339d41cbb0e']
when sorting by easiness, put new card separately Imitate 61d7c0b5d9a2d4cde5f8e39818a0b765632a3320 from anki
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Finder.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Finder.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -408,7 +408,7 @@ public class Finder {\n } else if (type.startsWith("cardDue")) {\n sort = "c....
Kotlin
b0ccedc1c4d7324b4c0f3d6926c72cd90a1ea73c
45
2019-10-17 08:41:48+09:00
-7,200
['9c82749461323cd5b8910bbed59a9f5388f513a3']
intNow to intTime In order to be consistent with anki code
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/BackupManager.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/BackupManager.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -123,7 +123,7 @@ public class BackupManager {\n lastBackupDate = null;\n }\n }\n- ...
Kotlin
272b757e142a9ceb60efab251156ff6377ab859e
45
2019-10-17 08:41:48+09:00
-7,200
['b0ccedc1c4d7324b4c0f3d6926c72cd90a1ea73c']
Explaining the name of ModelManager.newModel. Simply stating that it's called new in Anki's code, but in java it's a reserved keyword.
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Models.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Models.java', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -305,6 +305,8 @@ public class Models {\n \n \n /** Create a new model, save it in the registry, and return it. */\n+\t// Calle...
Kotlin
20dfed21f48baac80a68000193c8882d519ed4ce
45
2019-10-17 08:52:23+09:00
-7,200
['272b757e142a9ceb60efab251156ff6377ab859e']
support {{CardFlag}} https://anki.tenderapp.com/discussions/ankidesktop/32158-flags dae/anki@867e4b9f944e8435861aa44c7e6330aa98b94e1d
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Card.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Card.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -293,7 +293,7 @@ public class Card implements Cloneable {\n Object[] data;\n try {\n data = ne...
Kotlin
bcc13aaf374725af69159bc4c7f68ea0d2fa3ea9
45
2019-10-17 08:57:18+09:00
-7,200
['20dfed21f48baac80a68000193c8882d519ed4ce']
some html regexps should be case insensitive dae/anki@27c23c01d6193c4fdae6854f27972956deb0bb12
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Utils.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Utils.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -96,10 +96,10 @@ public class Utils {\n private Utils() { }\n \n // Regex pattern used in removing tags from text before dif...
Kotlin
b2f19a05098be67d6949f1d92af715735b94759d
126
2019-10-18 16:56:10-05:00
-7,200
['bcc13aaf374725af69159bc4c7f68ea0d2fa3ea9']
Bump Gradle from 5.6.1 to 5.6.3, JaCoCo to 0.8.4 Remove JaCoCo from build script dependencies as there is no use of it and it was using a different version than JaCoCo used for test execution. Also fix some clumsy Gradle usages: - duplicate keys in gradle.properties - casting string jacocoVersion property to string
[{'old_path': 'AnkiDroid/build.gradle', 'new_path': 'AnkiDroid/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -7,7 +7,7 @@ apply plugin: \'com.android.application\'\n apply plugin: \'jacoco\'\n \n jacoco {\n- toolVersion = "$rootProject.ext.jacocoVersion"\n+ toolVersion = jacocoVersion\n \n }\n ...
Kotlin
ee7ebde38ffabe486424e8833ad0eca13a7269e8
124
2019-10-20 21:58:18+09:00
-32,400
['b2f19a05098be67d6949f1d92af715735b94759d']
Bumped version to 2.10alpha1 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
43ff6f7b6429db4579820b2f0f973ef052c07e67
80
2019-10-21 06:09:38+09:00
18,000
['ee7ebde38ffabe486424e8833ad0eca13a7269e8']
fix crash on app startup with uninitialized collection
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/services/BootService.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/services/BootService.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -33,6 +33,11 @@ public class BootService extends BroadcastReceiver {\n if (!CollectionHelper.hasStor...
Kotlin
be935e55cbd05b4292e2794978ecf2d667a303d8
45
2019-10-21 06:45:35+09:00
-7,200
['43ff6f7b6429db4579820b2f0f973ef052c07e67']
use a constant for the starting factor dae/anki@227ca090db546363dbda6949ec18ef467d67eed7
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Consts.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Consts.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -57,6 +57,8 @@ public class Consts {\n public static final int MODEL_STD = 0;\n public static final int MODEL_CLOZE = 1;\n...
Kotlin
ece0b5d33a0eea23e8deb7f57e8786c87af0ac17
45
2019-10-21 07:10:05+09:00
-7,200
['be935e55cbd05b4292e2794978ecf2d667a303d8']
escape backslash in find&replace https://anki.tenderapp.com/discussions/ankidesktop/35903-bug-find-and-replace-breaks-when-replacing-with-latexmathjax-commands dae/anki@6b784ae42e767413798acfbff34968d2d984db52
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Finder.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Finder.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -870,6 +870,7 @@ public class Finder {\n // find and gather replacements\n if (!isRegex) {\n src = Pat...
Kotlin
9f2f50ead03ec2a1b60995c578b2891eff57c876
45
2019-10-21 07:31:10+09:00
-7,200
['ece0b5d33a0eea23e8deb7f57e8786c87af0ac17']
Allow for a deck parameter when creating a card This is to follow anki's code. Originally, it allows to correct a bug when previewing new cards. dae/anki@20ff61e59eae6c32e4671c035a0d5438d169ab2f
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -850,25 +850,44 @@ public class Collection {\n * Create a new card.\n */\n private Card _newCard(Note note, ...
Kotlin
a1b55d3bef2b1cb632744ce7e674bdf8740898fd
45
2019-10-21 07:31:10+09:00
-7,200
['9f2f50ead03ec2a1b60995c578b2891eff57c876']
Allow for a deck parameter when previewing a card. This is to follow anki's code. dae/anki@b3de44129be597899a2522c8713618440ee7d5ab
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -814,6 +814,11 @@ public class Collection {\n * @return list of cards\n \t */\n \tpublic List<Card> previewCards(Note...
Kotlin
23f9769d5440cb80d2114d6990668457b5ef16c3
124
2019-10-21 07:39:38+09:00
-32,400
['a1b55d3bef2b1cb632744ce7e674bdf8740898fd']
Bumped version to 2.10alpha2 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
7d699866640bbf1cf1a5c5c4a29b90094dc02b07
60
2019-10-21 14:44:37+09:00
-7,200
['23f9769d5440cb80d2114d6990668457b5ef16c3']
Add interval as a potential second column in the browser (#5549) Answer feature request #5542 This has been tested by starting Ankidroid, openining the Browser with a real collection, and checking that I can select interval and see their values correctly. Tested-by: Arthur Milchior <Arthur@Milchior.fr>
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -142,9 +142,9 @@ public class CardBrowser extends NavigationDrawerActivity implements\n "cardEase",\n "cardRep...
Kotlin
81515b3a97c281f480aac63d460eec8c71c9a725
124
2019-10-21 14:49:07+09:00
-32,400
['7d699866640bbf1cf1a5c5c4a29b90094dc02b07']
Bumped version to 2.10alpha3 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
c4865da41a6ee13f8ee4eebc58d3f3aa84ab158e
137
2019-10-21 14:51:40+09:00
18,000
['81515b3a97c281f480aac63d460eec8c71c9a725']
Cloze menu (#5536) * Fix #5532 * Fix #5532 * Adjust variable declaration style. * Be less oblivious about declaring variables in scope. * Consistent indentation
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/NoteEditor.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/NoteEditor.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -71,6 +71,7 @@ import com.ichi2.async.DeckTask;\n import com.ichi2.compat.CompatHelper;\n import com.ichi2.libanki.Card;\n impor...
Kotlin
2747182b79ac4fcdd77c7d4efc99946483839224
124
2019-10-21 14:53:31+09:00
-32,400
['c4865da41a6ee13f8ee4eebc58d3f3aa84ab158e']
Bumped version to 2.10alpha4 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
66494bb5daf42c5a7c4c74de5f1ab8f478ff4a16
126
2019-10-21 19:18:55+09:00
-7,200
['2747182b79ac4fcdd77c7d4efc99946483839224']
Use inflexion form in 'studied x cards in y minutes' (#5529) The main application screen was using generic 'y minutes' translation string. Some languages use a different form for 'y minutes' and 'in y minutes'.
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -554,7 +554,7 @@ public abstract class AbstractFlashcardViewer extends NavigationDrawerActivity {\n ...
Kotlin
037219dc899dc583d4376de1547fd6e89f8c5480
53
2019-10-22 06:39:56+09:00
18,000
['66494bb5daf42c5a7c4c74de5f1ab8f478ff4a16']
Fix Mathjax Cloze duplication issue.
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/template/Template.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/template/Template.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -391,8 +391,8 @@ public class Template {\n } else {\n m.appendReplacement(repl, ...
Kotlin
aa94e209f26f47e02a1082501a3497d5f18ccdb6
124
2019-10-22 07:11:56+09:00
-32,400
['037219dc899dc583d4376de1547fd6e89f8c5480']
Don't run gitflow-integrate script unless we're on correct branch
[{'old_path': 'tools/gitflow-integrate', 'new_path': 'tools/gitflow-integrate', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -380,6 +380,13 @@ function main() {\n git_is_branch "$from" || fatal "Invalid branch: $from"\n git_is_branch "$into" || fatal "Invalid branch: $into"\n \n+ local current_branch=$(git br...
Kotlin
4424b7a3d785b5117ea9d0943f66637e24ec0636
124
2019-10-22 07:58:32+09:00
-32,400
['aa94e209f26f47e02a1082501a3497d5f18ccdb6']
Bumped version to 2.10alpha5 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
3bcb332229cea588e3fda650a9133c2993c5834b
45
2019-10-22 11:21:25+09:00
-7,200
['26c0aca3383fee07fb51d08e1df390ed593dec01']
Add isModelNew in ModelManager It's here to factorize a method which is trivial in anki, and may throws an exception here, hence is longer.
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Models.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Models.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -186,7 +186,7 @@ public class Models {\n m.put("mod", Utils.intTime());\n m.put("usn", mCol.usn())...
Kotlin
906f185d1a94711842e2f4c226b9c704130c3a75
45
2019-10-22 11:21:25+09:00
-7,200
['3bcb332229cea588e3fda650a9133c2993c5834b']
Allow to create a basic model without adding it. This way, we can add more complex standard model without having to uselessly trigger a new change of mod. dae/anki@c14b9e2077e83481baaa319d7e4f660985c7ca71 and dae/anki@db4edf62ebcf4388b7453f05c957085db59ffd0d
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Models.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Models.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1259,12 +1259,12 @@ public class Models {\n * @throws ConfirmModSchemaException ********************************************...
Kotlin
29d95d409bc3ea681f2533988f8b764c75a45e17
45
2019-10-22 11:21:25+09:00
-7,200
['906f185d1a94711842e2f4c226b9c704130c3a75']
Add a class for assertion Assert are not usually present in android program. See discussion here. https://github.com/ankidroid/Anki-Android/pull/5475#discussion_r336821445
[{'old_path': None, 'new_path': 'AnkiDroid/src/main/java/com/ichi2/utils/Assert.java', 'type': <ModificationType.ADD: 1>, 'diff': '@@ -0,0 +1,26 @@\n+/****************************************************************************************\n+ * Copyright (c) 2009 Bitonator ...
Kotlin
0829284084cab1a00883898cd180329e77ab068e
45
2019-10-22 11:21:25+09:00
-7,200
['29d95d409bc3ea681f2533988f8b764c75a45e17']
Separate addField to avoid exceptions Before this commit, in ModelManager, the addField method's type contained `throws ConfirmModSchemaException`. This method add variants not sending exception: * for new models, * when mod is already changed. I added a private method, so that the actual work can be factorized.
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Models.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Models.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -24,6 +24,8 @@ import android.database.Cursor;\n import android.util.Pair;\n \n import com.ichi2.anki.exception.ConfirmModSchemaEx...
Kotlin
5b5ed9d3a325be3c5654d8f95a94f1e9ef95150d
45
2019-10-22 11:21:25+09:00
-7,200
['0829284084cab1a00883898cd180329e77ab068e']
Similar to last commit, but for templates
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Models.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Models.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -788,14 +788,11 @@ public class Models {\n return t;\n }\n \n-\n- /** Note: should col.genCards() afterwards. \n- ...
Kotlin
cc769fd5f4adec8b6fc3acd16f5d6322c56cd060
45
2019-10-22 11:21:25+09:00
-7,200
['5b5ed9d3a325be3c5654d8f95a94f1e9ef95150d']
Replace addField and addTemplate Instead used specialized function, avoiding try/catch when useless
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/provider/CardContentProvider.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/provider/CardContentProvider.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -901,7 +901,7 @@ public class CardContentProvider extends ContentProvider {\n ...
Kotlin
36b4f1dd7d6596b422aed2e6d0d8f8337ed5c5b4
45
2019-10-22 11:21:25+09:00
-7,200
['cc769fd5f4adec8b6fc3acd16f5d6322c56cd060']
ensure the list of note types is not empty dae/anki@8497da27cf47f395a8288c47d9ff3ba32e95cfc4
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1747,6 +1747,10 @@ public class Collection {\n AnkiDroidApp.sendExceptionReport(e, "doInBackgroundCheckDataba...
Kotlin
559caa6a416358ff57acd17c5e95c160e546ff45
45
2019-10-22 11:21:25+09:00
-7,200
['36b4f1dd7d6596b422aed2e6d0d8f8337ed5c5b4']
Remove useless exception Both as comment and as try/catch
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/ModelBrowser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/ModelBrowser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -418,8 +418,6 @@ public class ModelBrowser extends AnkiActivity {\n } else {\n showToast(getReso...
Kotlin
54390166eba5f34c8e12562d99f8cc4d43d8356b
124
2019-10-22 11:31:22+09:00
-32,400
['e0d3b192241ddbd468f1827e76a190a7134d34ba']
Bumped version to 2.10alpha6 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
ac94ae357193d4837d518c04ea4424e29f4e0571
80
2019-10-21 22:19:51-05:00
18,000
['31b500817737ace3511f1627591163f866eb0447']
fix gradle coverage entropy - classes and output moved
[{'old_path': 'AnkiDroid/build.gradle', 'new_path': 'AnkiDroid/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -134,14 +134,14 @@ task jacocoTestReport(type: JacocoReport, dependsOn: [\'testDebugUnitTest\', \'crea\n }\n \n def fileFilter = [\'**/R.class\', \'**/R$*.class\', \'**/BuildConfig.*\'...
Kotlin
7e1fd5129d551ad4cb3399dfef3d8bda2f22eb77
80
2019-10-21 22:19:51-05:00
18,000
['ac94ae357193d4837d518c04ea4424e29f4e0571']
bump jacoco version, handle new failure mode jacoco 0.8.4 -> 0.8.5 started failing fast for all errors, but it turns out that there were certain configurations (present in typical android instrumented test situations) where certain failures (like inability to write /jacoco.exec) had no consequence because actual outpu...
[{'old_path': None, 'new_path': 'AnkiDroid/src/main/resources/jacoco-agent.properties', 'type': <ModificationType.ADD: 1>, 'diff': '@@ -0,0 +1 @@\n+output=none\n\\ No newline at end of file\n'}, {'old_path': 'build.gradle', 'new_path': 'build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -14,7 +14,7 @@ bui...
Kotlin
21c1838bb186bc073fed68281f33fe23d9d3de42
45
2019-10-22 13:38:16+09:00
-7,200
['7e1fd5129d551ad4cb3399dfef3d8bda2f22eb77']
Adding missing Throw I don't intend to test this commit
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -879,7 +879,7 @@ public class Collection {\n ord = template.getInt("ord");\n card.setOrd(ord);\n ...
Kotlin
01292d7965714aab2985a7d2e11b58e457be0013
45
2019-10-22 15:11:42+09:00
-7,200
['21c1838bb186bc073fed68281f33fe23d9d3de42']
Factorize standard model creation dae/anki@fed2f2fa3dca844cd2fdb397930a67d452c9bbce
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Models.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Models.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1344,46 +1344,53 @@ public class Models {\n }\n \n /* Forward & Reverse */\n+ private static JSONObject _newForwardRev...
Kotlin
daa8b7f61279ac2a9f8df9a80acc0995099efbdd
138
2019-10-23 21:31:35+09:00
-7,200
['01292d7965714aab2985a7d2e11b58e457be0013']
catch and report TTS errors (#5561) * catch and report TTS errors implement onError() to report a Toast with some hints to the user in case the TTS engine returns an error. From API 21 upwards we would also have the error code available for further details on what happened. * Display Snackbar for failing TT...
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/ReadText.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/ReadText.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -18,6 +18,7 @@ package com.ichi2.anki;\n \n import android.content.Context;\n import android.content.res.Resources;\n+import android...
Kotlin
9224ff005b34b9ac6880d5b148bbe0ea6df00817
45
2019-10-25 19:19:04+09:00
-7,200
['daa8b7f61279ac2a9f8df9a80acc0995099efbdd']
Use resources instead of string in standard templates. In Anki, standard models are localized. More precisely, there are translations of field names, card name and model names. I ported this to ankidroid.
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Models.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Models.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -23,6 +23,8 @@ import android.content.ContentValues;\n import android.database.Cursor;\n import android.util.Pair;\n \n+import com...
Kotlin
1193ecfaf7f18b03a14e1f897951cde4d64c4521
45
2019-10-25 19:19:04+09:00
-7,200
['9224ff005b34b9ac6880d5b148bbe0ea6df00817']
Using localization of name of note type
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/ModelBrowser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/ModelBrowser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -300,10 +300,10 @@ public class ModelBrowser extends AnkiActivity {\n String clone = getResources().getString(R.stri...
Kotlin
e845325c0834a95fffae0bc51b5005666fc66c7c
45
2019-10-25 19:23:16+09:00
-7,200
['1193ecfaf7f18b03a14e1f897951cde4d64c4521']
New model: more simple and more unique This commit simultaneously corrects two problems, in which Ankidroid differs from Anki. When a standard model is constructed, Anki add random symbols only if the model's name is already used in the collection. This is now the case in Ankidroid too. When a model of name m is clo...
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/ModelBrowser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/ModelBrowser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -307,6 +307,7 @@ public class ModelBrowser extends AnkiActivity {\n \n //Populates arrayadapters listing the mModels...
Kotlin
504d96a99d31f35cfb48d94af1e7b282603b9bb6
45
2019-10-25 19:25:58+09:00
-7,200
['e845325c0834a95fffae0bc51b5005666fc66c7c']
Correct due of generated siblings. This commit port current Anki code to Ankidroid. It ensures that when a note is edited, and the edit generate new card, those new cards obtain the same due value as their siblings. The bug was reported (by me) as #5456. And I tested this correction simply by trying to reproduce the ...
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -707,19 +707,25 @@ public class Collection {\n String snids = Utils.ids2str(nids);\n HashMap<Long, HashMap...
Kotlin
9208ccec33256a47ea91a6d522007582901f5ff1
45
2019-10-25 19:25:58+09:00
-7,200
['504d96a99d31f35cfb48d94af1e7b282603b9bb6']
New cards of existing note take due value of NEW siblings This commit port to Ankidroid a PR I just did on anki's library. arthurmilchior/anki@3f45de87b393b14abb0891dc851723d75742aabb. https://github.com/dae/anki/pull/339 Once again, I tested this by trying to reproduce the bug with this new version of ankidroid and...
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -744,7 +744,7 @@ public class Collection {\n if (odid != 0) {\n due = odue;\n ...
Kotlin
c1e98478d105341cbc772fda47de7c4b735752e5
124
2019-10-26 14:15:25+09:00
-32,400
['9208ccec33256a47ea91a6d522007582901f5ff1']
Bumped version to 2.10alpha7 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
00b67f5b67519de705d9de480b2973f9c42bcbe6
124
2019-10-26 14:18:37+09:00
-32,400
['c1e98478d105341cbc772fda47de7c4b735752e5']
Bumped version to 2.10alpha8 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
0c1847276700c65338370cd826716ab4922d0472
22
2019-10-27 17:44:00+09:00
-3,600
['00b67f5b67519de705d9de480b2973f9c42bcbe6']
Fix sched v2 overflow bug (#5574) Fixes #5558
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/SchedV2.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/SchedV2.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2178,9 +2178,9 @@ public class SchedV2 extends Sched {\n // review\n boolean early = card.getOD...
Kotlin
605bad8187d1cf1150eb96306d2fec830d54d409
124
2019-10-27 18:11:46+09:00
-32,400
['0c1847276700c65338370cd826716ab4922d0472']
Bumped version to 2.10alpha9 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
0572353d1bcc99c6b30ed86793a99f0446552698
80
2019-10-28 08:35:01-05:00
18,000
['605bad8187d1cf1150eb96306d2fec830d54d409']
use stable channel emulator now that 29.x is out
[{'old_path': '.travis.yml', 'new_path': '.travis.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -66,7 +66,7 @@ install:\n - echo y | sdkmanager "build-tools;28.0.3" >/dev/null # Implicit gradle dependency - gradle drives changes\n - echo y | sdkmanager "platforms;android-$API" >/dev/null # We need the API...
Kotlin
26163e7585fab4dff43e09978260adae315596d5
80
2019-10-28 08:35:01-05:00
18,000
['0572353d1bcc99c6b30ed86793a99f0446552698']
Setup/teardown resources properly in tests
[{'old_path': 'AnkiDroid/src/androidTest/java/com.ichi2.anki.tests/libanki/ImportTest.java', 'new_path': 'AnkiDroid/src/androidTest/java/com.ichi2.anki.tests/libanki/ImportTest.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -30,6 +30,8 @@ import com.ichi2.libanki.importer.AnkiPackageImporter;\n import com.ich...
Kotlin
ff14b3d375438a177c033603b1ac24d34b665a00
80
2019-10-28 08:35:01-05:00
18,000
['26163e7585fab4dff43e09978260adae315596d5']
wait in testAnswerCard for just a moment before assertion
[{'old_path': 'AnkiDroid/src/androidTest/java/com.ichi2.anki.tests/ContentProviderTest.java', 'new_path': 'AnkiDroid/src/androidTest/java/com.ichi2.anki.tests/ContentProviderTest.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -814,6 +814,7 @@ public class ContentProviderTest {\n values.put(FlashCardsC...
Kotlin
7235a5bc667a6c9def934d85764cedc6594814b3
45
2019-10-28 23:44:33+09:00
-3,600
['ff14b3d375438a177c033603b1ac24d34b665a00']
Getting due correct when generating cards with no new siblings Here is a silly problem with porting Python code to Java. Sometimes, it does not work the same way at all. When I committed 504d96a99d31f35cfb48d94af1e7b282603b9bb6 I didn't pay attention to was the value of dues.get(nid) when nid is not in dues. And actua...
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -769,11 +769,16 @@ public class Collection {\n JSONObject model = mModels.get(mid);\n Arra...
Kotlin
0d0fc4711ad07d834ebc7b1e9a54a5c910aa42cd
124
2019-10-30 12:38:02+09:00
-32,400
['7235a5bc667a6c9def934d85764cedc6594814b3']
Bumped version to 2.10alpha10 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
f609f42481032c059f6887f04d3edb214328bd10
45
2019-10-30 14:16:38+09:00
-3,600
['0d0fc4711ad07d834ebc7b1e9a54a5c910aa42cd']
Adding method Parent from Anki For the sake of readability, I added in Ankidroid Anki's method called Parent. I added it in Deck instead of sched, because first it makes more sens. And in python it was a nested function, which is not proper in java.
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Decks.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Decks.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1087,6 +1087,14 @@ public class Decks {\n * ***********************************************************\n */\n \n+\tpublic ...
Kotlin
dbf3c09d5b3ebe2a1e734be4d597a0f01e90be67
45
2019-10-30 14:16:38+09:00
-3,600
['f609f42481032c059f6887f04d3edb214328bd10']
Decks#checkIntegrity As in anki. Moved to deck instead of in Sched
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Decks.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Decks.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -36,14 +36,17 @@ import java.util.Arrays;\n import java.util.Collections;\n import java.util.Comparator;\n import java.util.HashMap;...
Kotlin
b8696208c1276c9c71a50083d1046cbd46bfa2cc
124
2019-10-30 14:18:21+09:00
-32,400
['dbf3c09d5b3ebe2a1e734be4d597a0f01e90be67']
Bumped version to 2.10alpha11 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
9dfcc03785aefde512c6624580a848409b1ccbed
45
2019-10-30 14:54:38+09:00
-3,600
['b8696208c1276c9c71a50083d1046cbd46bfa2cc']
Correcting #5515 hopefully The error was sent in this line: https://github.com/ankidroid/Anki-Android/blob/7235a5bc667a6c9def934d85764cedc6594814b3/AnkiDroid/src/main/java/com/ichi2/async/DeckTask.java#L857 where searchResult is null. It's value is the result of col.findCardsForCardBrowser this method simply returns t...
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Finder.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Finder.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1069,7 +1069,7 @@ public class Finder {\n // cancel if the launching task was cancelled. \n if (t...
Kotlin
726a9b2e9a2706c4f3866f0e6a72cd5bee02801f
124
2019-10-30 14:57:19+09:00
-32,400
['9dfcc03785aefde512c6624580a848409b1ccbed']
Bumped version to 2.10alpha12 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
5c6d293ebfb96d5ec56814bc2ae44209eb923caa
99
2019-11-01 12:01:22-05:00
18,000
['726a9b2e9a2706c4f3866f0e6a72cd5bee02801f']
CI: Use emulator acceleration To take advantage of some of the new nested virtualization capabilities of some of the images in Travis, you must be using the newest LTS release of Ubuntu, 18.04 Bionic Beaver. However, the Travis image of Bionic does not include support for JDK 8, which we need to utilize the Android S...
[{'old_path': '.travis.yml', 'new_path': '.travis.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,17 +1,28 @@\n-language: android\n-dist: trusty\n+sudo: true\n+language: generic\n+dist: bionic\n \n-jdk:\n- - oraclejdk8\n+addons:\n+ apt:\n+ packages:\n+ - bridge-utils\n+ - libpulse0\n+ - l...
Kotlin
5b70e562f013c0fa8ee9bae28face67e8a221793
99
2019-11-01 12:01:22-05:00
18,000
['5c6d293ebfb96d5ec56814bc2ae44209eb923caa']
CI: Support up to Android API 29
[{'old_path': '.travis.yml', 'new_path': '.travis.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -36,10 +36,10 @@ env:\n - API=23\n - API=24\n - API=25\n- #- API=26 ABI=x86_64 # Fails with unrecognized tests? orchestrator change or something?\n- #- API=27 # Same failure as below for API28, but les...
Kotlin
3d880a62a4a81b33ba8bd33b0c4661a6cb8d9c29
99
2019-11-01 12:01:22-05:00
18,000
['5b70e562f013c0fa8ee9bae28face67e8a221793']
CI: Use x86 ABIs for older Android APIs This allows us to leverage the emulator acceleration brought to the other Android APIs we support.
[{'old_path': '.travis.yml', 'new_path': '.travis.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -26,9 +26,9 @@ env:\n - PATH=${ANDROID_HOME}:${ANDROID_HOME}/emulator:${TOOLS}:${TOOLS}/bin:${ANDROID_HOME}/platform-tools:${PATH}\n matrix:\n #- API=15 # only runs locally. Create+Start once from AndroidS...
Kotlin
4b7c26880a13217457d9ad2b619c1e3b60e05192
45
2019-11-03 12:11:42-05:00
-7,200
['c66205cd35df8233889d1dfe235ef7994af25b39']
Typo correction I'm sure the corrected sentence is wrong. Not entirely sure it's the best correction. I believe this is still better than nothing.
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/async/DeckTask.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/async/DeckTask.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1426,7 +1426,7 @@ public class DeckTask extends BaseAsyncTask<DeckTask.TaskData, DeckTask.TaskData\n }\n \n /**\n- * ...
Kotlin
8e95e6885c93695812f880e0b6e2c7aa9d4cfdca
80
2019-11-04 00:38:02-05:00
18,000
['4b7c26880a13217457d9ad2b619c1e3b60e05192']
Fix unit test path issues on windows
[{'old_path': 'AnkiDroid/src/test/java/com/ichi2/compat/CompatCopyFileTest.java', 'new_path': 'AnkiDroid/src/test/java/com/ichi2/compat/CompatCopyFileTest.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -30,6 +30,7 @@ import java.io.FileOutputStream;\n import java.io.IOException;\n import java.io.InputStream;\...
Kotlin
d83a9dc6d38fb326e872b543d008907ec4dcfe05
80
2019-11-04 00:38:02-05:00
18,000
['8e95e6885c93695812f880e0b6e2c7aa9d4cfdca']
Optimize CI w/test split; Verify osx/win work
[{'old_path': '.travis.yml', 'new_path': '.travis.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,16 +1,14 @@\n sudo: true\n-language: generic\n+language: bash\n+# ignored on non-linux platforms, but bionic is required for nested virtualization\n dist: bionic\n \n-addons:\n- apt:\n- packages:\n- - b...
Kotlin
d2b559737971796f75e496076b2603296d2f7526
80
2019-11-04 00:38:02-05:00
18,000
['d83a9dc6d38fb326e872b543d008907ec4dcfe05']
Fetch Android SDK components via http should be slightly more robust vs connection resets than https, at no security cost since we don't publish any of these artifacts
[{'old_path': '.travis.yml', 'new_path': '.travis.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -83,18 +83,18 @@ before_install:\n - if [ "$FINALIZE_COVERAGE" = "FALSE" ]; then mkdir ~/.android; fi # avoid harmless sdkmanager warning\n - if [ "$FINALIZE_COVERAGE" = "FALSE" ]; then echo \'count=0\' > ~/.an...
Kotlin
6a2f922050e977870b22fa6565f75723d5411b4b
45
2019-11-04 22:47:30+09:00
-3,600
['896f6aac21b0461da47be481b3237dfe9970a68f']
AnkiPackageImporter: comments Here to explain diff between anki/libanki
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/importer/AnkiPackageImporter.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/importer/AnkiPackageImporter.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -50,7 +50,7 @@ public class AnkiPackageImporter extends Anki2Importer {\n public v...
Kotlin
77109a22a24e82387abb3d8aec86c8d7cd66d59e
45
2019-11-04 22:47:30+09:00
-3,600
['6a2f922050e977870b22fa6565f75723d5411b4b']
catch attempts to write outside the media folder big thanks to David Bailey for discovering this dae/anki@375c071a2691453a57364e01fbfbc63fb30e710d
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/importer/AnkiPackageImporter.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/importer/AnkiPackageImporter.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -89,6 +89,8 @@ public class AnkiPackageImporter extends Anki2Importer {\n ...
Kotlin