Search is not available for this dataset
hash
string
author
int32
committer_date
string
timezone
int64
parents
string
message
string
changes
string
language
string
78424be314842833c04bc3bef5b72e85fff99204
68
2022-11-21 22:23:08-05:00
18,000
['8c926e6012d27c7ef517d9e3f6e12634bc5e4a1d']
Prepare 5.6.4 (#3666) ### Issue Link :link: This PR prepares the 5.6.4 release.
[{'old_path': 'Alamofire.podspec', 'new_path': 'Alamofire.podspec', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -1,6 +1,6 @@\n Pod::Spec.new do |s|\n s.name = 'Alamofire'\n- s.version = '5.6.3'\n+ s.version = '5.6.4'\n s.license = 'MIT'\n s.summary = 'Elegant HTTP Networking in Swift'\n s.homepage = 'ht...
Swift
d6f58ed15cacaf76bc39d6ac61c2faba6e157db1
68
2022-12-10 20:08:05-05:00
18,000
['78424be314842833c04bc3bef5b72e85fff99204']
Require Swift 5.5 (#3670) ### Goals :soccer: This PR updates Alamofire to require Swift 5.5. ### Implementation Details :construction: This PR updates various configurations and removes conditionals for Swift 5.5 and below. It also updates the formatting. ### Testing Details :mag: Testing for Swift < 5.5 pla...
[{'old_path': '.github/workflows/ci.yml', 'new_path': '.github/workflows/ci.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -59,26 +59,6 @@ jobs:\n runsOn: macOS-11\n name: "macOS 11, Xcode 13.0, Swift 5.5.0"\n testPlan: "macOS-NoTS"\n- - xcode: "Xcode_12.5.1.app"\n-...
Swift
ce7f662709a152e840b130a158b9afef3402e146
52
2022-12-10 21:10:44-05:00
-25,200
['d6f58ed15cacaf76bc39d6ac61c2faba6e157db1']
Fix unused bufferingPolicy in StreamOf (#3668) ### Goals :soccer: `StreamOf` has `bufferingPolicy` which is a private property but it's not used inside the struct. This PR uses `bufferingPolicy` to create `AsyncStream` in `makeAsyncIterator` so that the policy will be applied while interacting `StreamOf` Co-aut...
[{'old_path': 'Source/Concurrency.swift', 'new_path': 'Source/Concurrency.swift', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -663,7 +663,7 @@ public struct StreamOf<Element>: AsyncSequence {\n \n public func makeAsyncIterator() -> Iterator {\n var continuation: AsyncStream<Element>.Continuation?\n- ...
Swift
91367aaed5985f0dce98bf5487ea0c3fc76e9949
15
2023-02-06 01:58:07-05:00
-3,600
['f1f7a06f40c6aadb4beb2a78f380f9938d574fa7']
Update AdvancedUsage.md (#3682) Fixes minor typo in AdvancedUsage documentation
[{'old_path': 'Documentation/AdvancedUsage.md', 'new_path': 'Documentation/AdvancedUsage.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -174,7 +174,7 @@ let session = Session(interceptor: policy)\n \n > For projects deploying to iOS 14, tvOS 14, watchOS 7, or macOS 11 or later, [Apple now provides built in pinn...
Swift
728de0e2a75e9b2358ba7c8902cf3a28453c5f4e
68
2023-02-06 21:01:20-05:00
18,000
['91367aaed5985f0dce98bf5487ea0c3fc76e9949']
Move CI to Xcode 14.2 (#3685) ### Goals :soccer: This PR updates the CI runner to use Xcode 14.2.
[{'old_path': '.github/workflows/ci.yml', 'new_path': '.github/workflows/ci.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -31,6 +31,10 @@ jobs:\n fail-fast: false\n matrix:\n include:\n+ - xcode: "Xcode_14.2.app"\n+ runsOn: macOS-12\n+ name: "macOS 12, Xcode ...
Swift
337b29a49fb05d687e9c5d2035c75d868bf6363a
68
2023-02-06 21:02:18-05:00
18,000
['728de0e2a75e9b2358ba7c8902cf3a28453c5f4e']
Fix Reachability Safety (#3684) ### Issue Link :link: #3676 ### Goals :soccer: This PR updates our integration of `SCNetworkReachabilityContext` to use a weak box class and fully integrate with the framework's retain and release closures. This follows the same logic as [Reachability.swift](https://github.com/a...
[{'old_path': '.swiftformat', 'new_path': '.swiftformat', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -24,6 +24,6 @@\n --nospaceoperators ..<, ...\n --selfrequired validate\n --stripunusedargs closure-only\n---wraparguments after-first\n---wrapcollections after-first\n---wrapparameters after-first\n+--wrapargumen...
Swift
ce0fb463a8f95fc8363c99fab1ea197553af5dfe
68
2023-02-07 15:34:26-05:00
18,000
['337b29a49fb05d687e9c5d2035c75d868bf6363a']
Add NilEncoding to URLEncodedFormParameterEncoder (#3686) ### Issue Link :link: #3631 ### Goals :soccer: This PR adds a `NilEncoding` type for `URLEncodedFormParameterEncoder` so that it can handle optional values. ### Implementation Details :construction: Like the other encodings, it allows a variety of rep...
[{'old_path': 'Documentation/Usage.md', 'new_path': 'Documentation/Usage.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -343,6 +343,28 @@ You can create your own `URLEncodedFormParameterEncoder` and specify the desired\n let encoder = URLEncodedFormParameterEncoder(encoder: URLEncodedFormEncoder(spaceEncoding: ...
Swift
e68cfdf9c5aa4e69f675198a3cf8bef72c7cdede
68
2023-02-15 18:16:27-05:00
18,000
['ce0fb463a8f95fc8363c99fab1ea197553af5dfe']
Add KeyPathEncoding to URLEncodedFormEncoder (#3689) ### Issue Link :link: Fixes #3687. ### Goals :soccer: This PR adds `KeyPathEncoding` to `URLEncodedFormEncoder` to allow the customization of key path encoding in the form encoding. ### Implementation Details :construction: Like the recent `NilEncoding`, `...
[{'old_path': 'Documentation/Usage.md', 'new_path': 'Documentation/Usage.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -330,6 +330,21 @@ You can create your own `URLEncodedFormParameterEncoder` and specify the desired\n let encoder = URLEncodedFormParameterEncoder(encoder: URLEncodedFormEncoder(keyEncoding: .c...
Swift
81a29729e7dbfe7b976723843d0280926587a532
68
2023-03-02 23:14:33-05:00
18,000
['e68cfdf9c5aa4e69f675198a3cf8bef72c7cdede']
Apply SwiftFormat 0.51.0 (#3695) ### Goals :soccer: This PR applies formatting from SwiftFormat 0.51.0.
[{'old_path': '.github/workflows/ci.yml', 'new_path': '.github/workflows/ci.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -25,41 +25,45 @@ jobs:\n name: Test macOS, All Xcodes and Swifts\n runs-on: ${{ matrix.runsOn }}\n env:\n- DEVELOPER_DIR: "/Applications/${{ matrix.xcode }}/Contents/Devel...
Swift
f3f0f136153e8ce3bb5094c5528db431518ee0c7
68
2023-03-16 16:19:44-04:00
14,400
['81a29729e7dbfe7b976723843d0280926587a532']
Add Request Compression (#3701) ### Goals :soccer: For large request bodies it may be beneficial to compress the outgoing data. This PR adds support for the `deflate` compression encoding as a `RequestInterceptor`. ### Implementation Details :construction: `DeflateRequestCompressor` manually compresses body dat...
[{'old_path': '.github/workflows/ci.yml', 'new_path': '.github/workflows/ci.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -280,3 +280,22 @@ jobs:\n set SDKROOT=%SystemDrive%\\Library\\Developer\\Platforms\\Windows.platform\\Developer\\SDKs\\Windows.sdk\n %SystemDrive%\\Library\\Developer\\...
Swift
fd87f7ce7461197ea5af6e4a865168b8fc913ee0
81
2023-03-16 23:10:56+00:00
25,200
['f3f0f136153e8ce3bb5094c5528db431518ee0c7']
Add ArrayEncoding.custom to URLEncodedFormEncoder and ParameterEncoding (#3699) ### Goals :soccer: Let the user define a custom key formatting for arrays. ### Implementation Details :construction: This helps for uncommon formats such as in the AWS API where it expects Array.1.Key or Array.member.1.Key. Rather than ad...
[{'old_path': 'Source/ParameterEncoding.swift', 'new_path': 'Source/ParameterEncoding.swift', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -87,6 +87,8 @@ public struct URLEncoding: ParameterEncoding {\n case noBrackets\n /// Brackets containing the item index are appended. This matches the jQuery a...
Swift
d9551f7fb12b986a0b5b32f69a1b2b075c9670d5
68
2023-05-08 14:34:10+00:00
14,400
['fd87f7ce7461197ea5af6e4a865168b8fc913ee0']
Update builders. (#3712) ### Goals :soccer: This PR updates the macOS, Linux, and Windows builders with more Swift 5.8 / Xcode 14.3 usage.
[{'old_path': '.github/workflows/ci.yml', 'new_path': '.github/workflows/ci.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -75,9 +75,9 @@ jobs:\n run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild -project "Alamofire.xcodeproj" -scheme "Alamofire macOS" -destination "platform=macOS" -testPlan "$...
Swift
1264fe105b26821b978ae28488fdb2c10b5bdb64
62
2023-05-08 14:35:44+00:00
25,200
['d9551f7fb12b986a0b5b32f69a1b2b075c9670d5']
Fix typo "crated" to "created" (#3710) ### Goals :soccer: - Fixing a typo within Request.swift ### Implementation Details :construction: - No architectural changes or new functionality ### Testing Details :mag: - No tests required
[{'old_path': 'Source/Request.swift', 'new_path': 'Source/Request.swift', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -219,7 +219,7 @@ public class Request {\n public var tasks: [URLSessionTask] { $mutableState.tasks }\n /// First `URLSessionTask` created on behalf of the `Request`.\n public var first...
Swift
0a4e521f50ff12c19985dc360ec9eace01baf3a4
102
2023-05-08 14:37:54+00:00
-32,400
['5d3cca2d2554df38e8035830a9017824eeabe3e9']
Update README.md (#3688)
[{'old_path': 'README.md', 'new_path': 'README.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -118,7 +118,7 @@ Once you have your Swift package set up, adding Alamofire as a dependency is as\n \n ```swift\n dependencies: [\n- .package(url: "https://github.com/Alamofire/Alamofire.git", .upToNextMajor(from: "5...
Swift
e065ed9eebbb24c311e28ed4d94d86d165cd9ffa
68
2023-05-09 21:32:19+00:00
14,400
['0a4e521f50ff12c19985dc360ec9eace01baf3a4']
Bump Deployment Targets (#3717) ### Issue Link :link: #3716 ### Goals :soccer: This PR bumps the deployment targets to the iOS 11 generation to fix issues when using Xcode 14.3. ### Implementation Details :construction: Deployment target bumps and removal of relevant conditionals.
[{'old_path': 'Alamofire.podspec', 'new_path': 'Alamofire.podspec', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -8,10 +8,10 @@ Pod::Spec.new do |s|\n s.source = { :git => 'https://github.com/Alamofire/Alamofire.git', :tag => s.version }\n s.documentation_url = 'https://alamofire.github.io/Alamofire/'\n \n- s...
Swift
134218330bdabe8fdca892a57123b2956d773af6
68
2023-05-09 22:58:41+00:00
14,400
['e065ed9eebbb24c311e28ed4d94d86d165cd9ffa']
Prepare 5.7 (#3718) ### Goals :soccer: This PR prepares the 5.7 release.
[{'old_path': '.ruby-version', 'new_path': '.ruby-version', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1 +1 @@\n-3.1.2\n+3.2.2\n'}, {'old_path': 'Alamofire.podspec', 'new_path': 'Alamofire.podspec', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -1,6 +1,6 @@\n Pod::Spec.new do |s|\n s.name = 'Alamofire'\n-...
Swift
bc268c28fb170f494de9e9927c371b8342979ece
68
2023-05-10 15:59:02+00:00
14,400
['236844f551a72b7528b1634c9b8266b17f5abcb3']
Prepare 5.7.1 (#3721) ### Goals :soccer: This PR prepares the 5.7.1 release.
[{'old_path': 'Alamofire.podspec', 'new_path': 'Alamofire.podspec', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -1,6 +1,6 @@\n Pod::Spec.new do |s|\n s.name = 'Alamofire'\n- s.version = '5.7.0'\n+ s.version = '5.7.1'\n s.license = 'MIT'\n s.summary = 'Elegant HTTP Networking in Swift'\n s.homepage = 'ht...
Swift
98c28e683253e920f5220d4456c5e4a6da7aa941
68
2023-06-06 16:16:39+00:00
14,400
['0ef340c886a9fa4b51c863a305d2ea11332b909b']
Update URL Conversion Tests (#3734) ### Goals :soccer: This PR updates some failing tests for the first Xcode 15 beta. ### Implementation Details :construction: In 2023 OSes, `URL` now follows RFC 3986 and automatically encodes URL components with proper escaping. This reduces the cases where strings can't properly b...
[{'old_path': '.github/workflows/ci.yml', 'new_path': '.github/workflows/ci.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -114,7 +114,7 @@ jobs:\n name: "Test Old iOS"\n runs-on: firebreak\n env:\n- DEVELOPER_DIR: "/Applications/Xcode_14.2.app/Contents/Developer"\n+ DEVELOPER_DIR: "/Appl...
Swift
51a2d5077567b257ac1f227b6883c4ff1d7a491d
68
2023-06-22 16:05:29+00:00
14,400
['98c28e683253e920f5220d4456c5e4a6da7aa941']
visionOS Support (#3738) ### Goals :soccer: This PR adds visionOS support with frameworks and test targets. ### Implementation Details :construction: No changes were required except those to add `xrOS` availability checking and the associated Swift version. ### Testing Details :mag: Test target added, visionOS testi...
[{'old_path': '.github/workflows/ci.yml', 'new_path': '.github/workflows/ci.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -148,12 +148,17 @@ jobs:\n - destination: "OS=17.0,name=iPhone 14 Pro"\n name: "iOS 17.0"\n testPlan: "iOS"\n+ scheme: "Alamofire iOS"\n+ ...
Swift
f094c2d0040e27a0a0bb405c980cadd5e47c6c74
108
2023-07-21 15:48:54+00:00
-28,800
['51a2d5077567b257ac1f227b6883c4ff1d7a491d']
fix: no need call empty initializer (#3742) ### Issue Link :link: <!-- What issue does this fix? If an issue doesn't exist, remove this section. --> ### Goals :soccer: <!-- List the high-level objectives of this pull request. --> <!-- Include any relevant context. --> ### Implementation Details :construction: <!-- E...
[{'old_path': 'Source/HTTPHeaders.swift', 'new_path': 'Source/HTTPHeaders.swift', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -34,16 +34,12 @@ public struct HTTPHeaders {\n /// Creates an instance from an array of `HTTPHeader`s. Duplicate case-insensitive names are collapsed into the last\n /// name and v...
Swift
4abb04eb7aa7c73ea22ca8d02567fb652a7ad629
68
2023-07-21 16:23:08-04:00
14,400
['f094c2d0040e27a0a0bb405c980cadd5e47c6c74']
Change xrOS platform to visionOS (#3750) ### Goals :soccer: This PR updates the `xrOS` platform to `visionOS` now that the Xcode betas know about that platform.
[{'old_path': 'Source/MultipartFormData.swift', 'new_path': 'Source/MultipartFormData.swift', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -550,7 +550,7 @@ extension MultipartFormData {\n \n private func mimeType(forPathExtension pathExtension: String) -> String {\n #if swift(>=5.9)\n- if #avail...
Swift
82098ab53e098b9e950556a074fce46630d222a2
6
2023-08-09 11:13:27-04:00
10,800
['4abb04eb7aa7c73ea22ca8d02567fb652a7ad629']
Limit stream upload length according to bodyContentLength specified (#3730) ### Issue Link :link: <!-- What issue does this fix? If an issue doesn't exist, remove this section. --> [Can't upload a specific length of MultipartFormData.BodyPart.bodyContentLength from an InputStream #3714](https://github.com/Alamofi...
[{'old_path': 'Source/MultipartFormData.swift', 'new_path': 'Source/MultipartFormData.swift', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -455,9 +455,11 @@ open class MultipartFormData {\n inputStream.open()\n defer { inputStream.close() }\n \n- while inputStream.hasBytesAvailable {\n- ...
Swift
9f828f62e24bd0cf550816057f614be21c3ae5ea
68
2023-08-09 12:33:24-04:00
14,400
['82098ab53e098b9e950556a074fce46630d222a2']
Replace Some Platform Checks With canImport Checks (#3756) ### Issue Link :link: This PR replaces #3741. ### Goals :soccer: This PR builds on #3741 to replace many platform `#if os` checks with `#if canImport` for the relevant frameworks. --------- Co-authored-by: brennobemoura <37243584+brennobemoura@user...
[{'old_path': 'Source/AFError.swift', 'new_path': 'Source/AFError.swift', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -24,6 +24,10 @@\n \n import Foundation\n \n+#if canImport(Security)\n+import Security\n+#endif\n+\n /// `AFError` is the error type returned by Alamofire. It encompasses a few different types of e...
Swift
d732bc9edfca92bba7a063c2feee9120c195bf52
68
2023-08-17 12:48:47-04:00
14,400
['9f828f62e24bd0cf550816057f614be21c3ae5ea']
Allow Automatic Cancellation By Default (#3757) ### Issue Link :link: #3727 ### Goals :soccer: This PR changes Alamofire's default behavior to better follow user expectations around automatically cancellation when the enclosing async context is cancelled. This PR also updates some other async behaviors for m...
[{'old_path': '.github/workflows/ci.yml', 'new_path': '.github/workflows/ci.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -293,10 +293,9 @@ jobs:\n if not exist .build\\x86_64-unknown-windows-msvc\\debug\\Alamofire.swiftmodule exit 1\n CodeQL:\n name: Analyze with CodeQL\n- runs-on: macOS-1...
Swift
bf689d61ba0745920ea9f07fa39d15baa47af1b2
56
2023-08-17 13:41:30-04:00
25,200
['d732bc9edfca92bba7a063c2feee9120c195bf52']
Added Android Support (#3744) ### Goals :soccer: <!-- List the high-level objectives of this pull request. --> The goal of this pull request is to add Android support to Alamofire. <!-- Include any relevant context. --> The following changes were verified on the swift-5.8 toolchain built for Android. ### Imple...
[{'old_path': '.github/workflows/ci.yml', 'new_path': '.github/workflows/ci.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -272,6 +272,14 @@ jobs:\n - uses: actions/checkout@v3\n - name: ${{ matrix.image }}\n run: swift build --build-tests -c debug\n+ Android:\n+ name: Android\n+ use...
Swift
4413116cc2f674fb2e1257dabddcf68f30f346d7
68
2023-08-18 14:12:22-04:00
14,400
['bf689d61ba0745920ea9f07fa39d15baa47af1b2']
Apply Latest Formatting (#3760) ### Goals :soccer: This PR applies the latest SwiftFormat.
[{'old_path': 'Example/Source/AppDelegate.swift', 'new_path': 'Example/Source/AppDelegate.swift', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -24,7 +24,7 @@\n \n import UIKit\n \n-@UIApplicationMain\n+@main\n class AppDelegate: UIResponder, UIApplicationDelegate, UISplitViewControllerDelegate {\n // MARK: - P...
Swift
b3b8c1f018944482d35eccc7b5125d315757e585
35
2023-08-20 21:56:48-04:00
25,200
['4413116cc2f674fb2e1257dabddcf68f30f346d7']
Update Windows CI (#3763) Adjust the command for building on Windows. The installer should take care of the setup of the environment. The actions setup already refresh the environment on behalf of the user. This should allow us to avoid requiring resetting the environment. The `cd` is implicit in the GHA execution...
[{'old_path': '.github/workflows/ci.yml', 'new_path': '.github/workflows/ci.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -293,12 +293,8 @@ jobs:\n - name: Clone\n uses: actions/checkout@v3\n - name: SPM Windows Build\n- shell: cmd\n run: |\n- cd ${{ github.workspac...
Swift
dc71baf4f1c263ceb419fc306e926a2bb3081c0b
68
2023-08-23 19:20:24-04:00
14,400
['b3b8c1f018944482d35eccc7b5125d315757e585']
Add Upload Progress Test (#3765) ### Issue Link :link: #3722 ### Goals :soccer: This PR adds a test to show that intermediate upload progress values are properly received. One this I noticed here is that, when multiple progress values are issued, it's not guaranteed that there's a final 100% progress value. ...
[{'old_path': 'Tests/ConcurrencyTests.swift', 'new_path': 'Tests/ConcurrencyTests.swift', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -565,6 +565,98 @@ final class DataStreamConcurrencyTests: BaseTestCase {\n }\n }\n \n+// Avoid when using swift-corelibs-foundation.\n+// Only Xcode 14.3+ has async fulfillment...
Swift
1da2d91fa6316690ef97f46b450262286231c261
68
2023-08-31 17:29:15-04:00
14,400
['dc71baf4f1c263ceb419fc306e926a2bb3081c0b']
Add Separate Response Hooks (#3762) ### Issue Link :link: #3401 ### Goals :soccer: This PR adds `onHTTPResponse` closure hooks to `DataRequest` / `UploadRequest` and `DataStreamRequest` to enable the cancellation of requests before data is transferred, requests that need to check response info for later parsin...
[{'old_path': '.swiftformat', 'new_path': '.swiftformat', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -10,7 +10,6 @@\n \n # format options\n \n---closingparen same-line\n --commas inline\n --comments indent\n --decimalgrouping 3,5\n'}, {'old_path': 'Documentation/AdvancedUsage.md', 'new_path': 'Documentation/Adva...
Swift
20d2846db8c52b45f73ebbfcd8c1db09f0ea2237
68
2023-08-31 17:59:26-04:00
14,400
['1da2d91fa6316690ef97f46b450262286231c261']
Move Package to Swift 5.9, Add 5.8 Version (#3767) ### Goals :soccer: This PR moves the Package.swift to Swift 5.9 and adds an explicit 5.8 version.
[{'old_path': '.github/workflows/ci.yml', 'new_path': '.github/workflows/ci.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -216,8 +216,11 @@ jobs:\n fail-fast: false\n matrix:\n include:\n- - xcode: "Xcode_14.3"\n+ - xcode: "Xcode_15.0"\n runsOn: firebreak\n+ ...
Swift
b2fa556e4e48cbf06cf8c63def138c98f4b811fa
68
2023-08-31 18:50:52-04:00
14,400
['20d2846db8c52b45f73ebbfcd8c1db09f0ea2237']
Prepare 5.8.0 (#3768) ### Goals :soccer: This PR prepares the 5.8.0 release.
[{'old_path': 'Alamofire.podspec', 'new_path': 'Alamofire.podspec', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -1,6 +1,6 @@\n Pod::Spec.new do |s|\n s.name = 'Alamofire'\n- s.version = '5.7.1'\n+ s.version = '5.8.0'\n s.license = 'MIT'\n s.summary = 'Elegant HTTP Networking in Swift'\n s.homepage = 'ht...
Swift
41bcbaf24f67efb2befd8abc0f32f0c66d1c78be
68
2023-09-01 15:30:36-04:00
14,400
['b2fa556e4e48cbf06cf8c63def138c98f4b811fa']
Update README (#3770) ### Goals :soccer: This PR updates the README for the latest project requirements.
[{'old_path': 'README.md', 'new_path': 'README.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,11 +1,10 @@\n ![Alamofire: Elegant Networking in Swift](https://raw.githubusercontent.com/Alamofire/Alamofire/master/Resources/AlamofireLogo.png)\n \n-[![Swift](https://img.shields.io/badge/Swift-5.5_5.6_5.7_5.8-ora...
Swift
495e9ffd0845e7caaa1f4ecc8991a09d4abc5d8c
68
2023-09-19 11:25:51-04:00
14,400
['41bcbaf24f67efb2befd8abc0f32f0c66d1c78be']
Refactor Test Runs For Swift 5.9 (#3775) ### Goals :soccer: This PR updates the CI builders to integrate Xcode 15 into all runs.
[{'old_path': '.github/workflows/ci.yml', 'new_path': '.github/workflows/ci.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,7 +22,7 @@ concurrency:\n cancel-in-progress: true\n jobs:\n macOS:\n- name: Test macOS, All Xcodes and Swifts\n+ name: ${{ matrix.name }}\n runs-on: ${{ matrix.runsOn }}...
Swift
e58140b172dab65843f36edba810185f51da03d0
68
2023-09-19 18:37:53-04:00
14,400
['495e9ffd0845e7caaa1f4ecc8991a09d4abc5d8c']
Remove @propertyWrapper From Protected (#3777) ### Goals :soccer: Use of a property wrapper is not thread-safe beyond access of the `wrappedValue` so for a while now Alamofire has had the implicit rule of always accessing `Protected` values through the wrapper using `$`. We can make this completely safe by removin...
[{'old_path': 'Source/AuthenticationInterceptor.swift', 'new_path': 'Source/AuthenticationInterceptor.swift', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -217,15 +217,14 @@ public class AuthenticationInterceptor<AuthenticatorType>: RequestInterceptor wh\n \n /// The `Credential` used to authenticate requests....
Swift
1df2a75e74384b4ca37e7aab7d4f473339fb83c2
68
2023-09-19 20:11:32-04:00
14,400
['e58140b172dab65843f36edba810185f51da03d0']
Add encodeIfPresent Support to URLEncodedFormEncoder (#3779) ### Issue Link :link: Fixes #3778 ### Goals :soccer: The encoding of synthesized `Encodable` values is different than `[String: String?]` so we were missing coverage for `encodeIfPresent`, causing `Optional` values to be dropped. This PR adds the miss...
[{'old_path': 'Source/URLEncodedFormEncoder.swift', 'new_path': 'Source/URLEncodedFormEncoder.swift', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -695,6 +695,74 @@ extension _URLEncodedFormEncoder.KeyedContainer: KeyedEncodingContainerProtocol\n try encode(nilValue, forKey: key)\n }\n \n+ func enco...
Swift
7f1bff79126ab8fe17744e062723179b36e17f97
68
2023-09-20 17:03:56-04:00
14,400
['1df2a75e74384b4ca37e7aab7d4f473339fb83c2']
Add Linux and Windows Swift 5.9 Runners (#3780) ### Goals :soccer: This PR adds Swift 5.9 runners for Linux and Windows now that the Docker tags are out.
[{'old_path': '.github/workflows/ci.yml', 'new_path': '.github/workflows/ci.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -290,16 +290,14 @@ jobs:\n include:\n - image: swift:5.8.1-focal\n - image: swift:5.8.1-jammy\n- - image: swift:5.8.1-bionic\n - image: swift...
Swift
583bce14ca33f7f384a7b73d20a884e2c47977cf
93
2023-10-25 10:14:23-04:00
-28,800
['7f1bff79126ab8fe17744e062723179b36e17f97']
Fix visionOS Target Build Settings (#3788) ### Goals :soccer: The build settings "Skip Install" is missing in visionOS target, which cloud cause the archive invalid when a project linked to the visionOS framework. ### Implementation Details :construction: Set the "Skip Install" in visionOS target to YES ### ...
[{'old_path': 'Alamofire.xcodeproj/project.pbxproj', 'new_path': 'Alamofire.xcodeproj/project.pbxproj', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2218,6 +2218,7 @@\n \t\t\t\t\t"@loader_path/Frameworks",\n \t\t\t\t);\n \t\t\t\tSDKROOT = xros;\n+\t\t\t\tSKIP_INSTALL = YES;\n \t\t\t\tSUPPORTED_PLATFORMS = "xros x...
Swift
3dc6a42c7727c49bf26508e29b0a0b35f9c7e1ad
68
2023-10-26 15:47:55-04:00
14,400
['583bce14ca33f7f384a7b73d20a884e2c47977cf']
Prepare 5.8.1 (#3789) ### Goals :soccer: This PR prepares the 5.8.1 release.
[{'old_path': '.github/workflows/ci.yml', 'new_path': '.github/workflows/ci.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -105,7 +105,7 @@ jobs:\n name: ${{ matrix.name }}\n runs-on: firebreak\n env:\n- DEVELOPER_DIR: "/Applications/Xcode_15b8.app/Contents/Developer"\n+ DEVELOPER_DIR: "/...
Swift
8bb7634fdf19895be8b047f8b300a1e1737d5119
14
2023-11-15 13:30:38-05:00
-32,400
['3dc6a42c7727c49bf26508e29b0a0b35f9c7e1ad']
Fix a trivial typo in AdvancedUsage.md (#3791) ### Implementation Details :construction: Fix 'with `Failure` error.' -> 'with a `Failure` error.' ### Testing Details :mag: No testing is needed as the change is in the comment.
[{'old_path': 'Documentation/AdvancedUsage.md', 'new_path': 'Documentation/AdvancedUsage.md', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -1325,7 +1325,7 @@ This code produces a `DataResponsePublisher<DecodableType>` value which will pub\n \n > To properly handle retry when using Alamofire's `Publisher`s, use Ala...
Swift
82b1a7c4171d43247dc19b2c4f2a42eec1da619c
14
2023-11-19 14:57:08-05:00
-32,400
['8bb7634fdf19895be8b047f8b300a1e1737d5119']
Fix a typo in the method quick help of ParameterEncoding and ResponseSerialization (#3796) ### Implementation Details :construction: 1. Fix a typo in `encode` method's quick help of `JSONEncoding`. |Before|After| |:-----:|:----:| |<img width="352" alt="before" src="https://github.com/Alamofire/Alamofire/assets/...
[{'old_path': 'Source/ParameterEncoding.swift', 'new_path': 'Source/ParameterEncoding.swift', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -297,7 +297,7 @@ public struct JSONEncoding: ParameterEncoding {\n ///\n /// - Parameters:\n /// - urlRequest: `URLRequestConvertible` value into which the object...
Swift
e7d8c0d0d0c8085e02eda369e74ec613bc5d8d53
68
2023-11-19 16:25:42-05:00
18,000
['82b1a7c4171d43247dc19b2c4f2a42eec1da619c']
Add WebSocketRequest Under @_spi(WebSocket) (#3455) ### Goals :soccer: This PR adds `WebSocketRequest`, an Alamofire wrapper around `URLSessionWebSocketTask`, as well as assorted functionality for dealing with WebSockets. This includes: - Automatic listening: no more manual `listen` calls on the task. - Automat...
[{'old_path': 'Alamofire.xcodeproj/project.pbxproj', 'new_path': 'Alamofire.xcodeproj/project.pbxproj', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -403,12 +403,14 @@\n \t\t31DADDFC224811ED0051390F /* AlamofireExtended.swift in Sources */ = {isa = PBXBuildFile; fileRef = 31DADDFA224811ED0051390F /* AlamofireExten...
Swift
827a879ae2dcc473dfcae8ae188b992f66cd07d6
68
2023-11-19 18:38:49-05:00
18,000
['e7d8c0d0d0c8085e02eda369e74ec613bc5d8d53']
Require Swift 5.7.1 (#3798) ### Goals :soccer: This PR updates Alamofire to require Swift 5.7.1, as Xcode 14.1 has been required to ship to the App Store since April. ### Implementation Details :construction: Relevant version checks have been removed and formatting updated for Swift 5.7. ### Testing Details ...
[{'old_path': '.github/workflows/ci.yml', 'new_path': '.github/workflows/ci.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -47,30 +47,6 @@ jobs:\n runsOn: macOS-12\n name: "macOS 12, Xcode 14.1, Swift 5.7.1"\n testPlan: "macOS"\n- - xcode: "Xcode_14.0.1"\n- ...
Swift
1d88c0ce6276d542e12e3ff024d7a58d257d9245
140
2018-11-28 10:10:36-05:00
0
['c7ef2f533fa3555ef9f767a05e1dc3ff8beab88d']
Bump junit-vintage-engine from 5.3.1 to 5.3.2 Bumps [junit-vintage-engine](https://github.com/junit-team/junit5) from 5.3.1 to 5.3.2. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](https://github.com/junit-team/junit5/compare/r5.3.1...r5.3.2) Signed-off-by: dependabot[bot] <support@depen...
[{'old_path': 'AnkiDroid/build.gradle', 'new_path': 'AnkiDroid/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -176,7 +176,7 @@ dependencies {\n implementation \'org.jsoup:jsoup:1.11.3\'\n api project(":api")\n \n- testImplementation \'org.junit.vintage:junit-vintage-engine:5.3.1\'\n+ tes...
Kotlin
d4187deb0c648aa4e544d8fede2a4760a84da031
80
2018-11-28 10:10:36-05:00
18,000
['1d88c0ce6276d542e12e3ff024d7a58d257d9245']
Bump diff-match-patch to 1.2 (includes all upstream changes to this date)
[{'old_path': 'AnkiDroid/build.gradle', 'new_path': 'AnkiDroid/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -159,7 +159,7 @@ dependencies {\n implementation 'com.afollestad.material-dialogs:core:0.9.6.0'\n implementation 'com.getbase:floatingactionbutton:1.10.1'\n implementation 'android...
Kotlin
b88653310bd33c6c99941a108d676bc6cecd3c24
80
2018-12-01 05:13:53+09:00
18,000
['d4187deb0c648aa4e544d8fede2a4760a84da031']
Use centralized file copy logic in Utils, extends #5093 Turns out file copy logic was duplicated in 6 places, not just the 5 that I saw in #5093 This uses the new centralized logic from the #5093 PR while converting some of it to "try-with-resources" which android back-ported down to API15 even so allows for much cle...
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/compat/CompatV15.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/compat/CompatV15.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -194,19 +194,13 @@ public class CompatV15 implements Compat {\n \n // Until API 26 do the copy using streams\n public ...
Kotlin
cd4d48258dd7a93fd489bcd4a923a3f1dec1bedd
80
2018-12-02 09:43:35+09:00
18,000
['b88653310bd33c6c99941a108d676bc6cecd3c24']
Add base onCancelled/onProgressUpdate, delete empty overrides These two callbacks were very rarely used, but had to be overridden by sub-classes, leading to lots of empty code blocks. Provide an empty base implementation and remove the empty sub-class implementations
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -457,12 +457,6 @@ public abstract class AbstractFlashcardViewer extends NavigationDrawerActivity {\n ...
Kotlin
a77225d4d185e970ce4324e26dc1d518dee210b1
80
2018-12-02 09:43:35+09:00
18,000
['cd4d48258dd7a93fd489bcd4a923a3f1dec1bedd']
Convert NoteEditor reposition / reschedule to DeckTasks Previously they were not asynchronous so they were doing database work on the UI thread, now they are async This also sets us up better to do CardBrowser reposition/reschedule on multiple selections
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/NoteEditor.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/NoteEditor.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -181,6 +181,52 @@ public class NoteEditor extends AnkiActivity {\n // restoring the Activity.\n private Bundle mSavedFie...
Kotlin
cfc25d918705538b6fe4bae1e28540313652fde5
80
2018-12-02 09:43:35+09:00
18,000
['a77225d4d185e970ce4324e26dc1d518dee210b1']
Refactor resetProgress to DeckTask like reschedule/reposition This now sets us up very well multi reset
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/NoteEditor.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/NoteEditor.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -207,7 +207,9 @@ public class NoteEditor extends AnkiActivity {\n @Override\n public void onPostExecute(DeckTask...
Kotlin
6f884d2791adc12494c6a2a0f5934997a7cdfbdb
80
2018-12-02 09:43:35+09:00
18,000
['cfc25d918705538b6fe4bae1e28540313652fde5']
Implement reposition/reschedule/reset on multiple cards Fixes #2746 At this point there should be no regression, just refactor then new feature. To be perfect, it is just missing undo implementation now - but that is not a regression, there was no undo for this feature for single cards prior
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -55,6 +55,8 @@ import com.afollestad.materialdialogs.MaterialDialog;\n import com.ichi2.anim.ActivityTransitionAnimation;\n im...
Kotlin
d657e0548e6bc7c6a156cda74be9ca8ac1703feb
80
2018-12-02 09:43:35+09:00
18,000
['6f884d2791adc12494c6a2a0f5934997a7cdfbdb']
Implement undo when altering card schedules Reschedule/reposition/reset now have undo, both in single card edit mode and multi-select mode CardBrowser is careful to listen to memory pressure, and signals to DeckTask if there is pressure, which causes the undo information copy to be aborted before we blow the app up
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1002,6 +1002,15 @@ public class CardBrowser extends NavigationDrawerActivity implements\n mReloadRequired = t...
Kotlin
d7f1fb3d52fb95cc8ffabc84b285bde00853ba83
80
2018-12-02 09:43:35+09:00
18,000
['d657e0548e6bc7c6a156cda74be9ca8ac1703feb']
Convert Reviewer:resetProgress to async/undo style This adopts the change in PR #5119 so that it matches the style proposed in this PR with the new async/undo capabilities added here
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/Reviewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/Reviewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -61,6 +61,26 @@ public class Reviewer extends AbstractFlashcardViewer {\n private static final int ADD_NOTE = 12;\n private ...
Kotlin
7855dd0216828320fe46081b4407910661d58202
80
2018-12-02 09:43:35+09:00
18,000
['d7f1fb3d52fb95cc8ffabc84b285bde00853ba83']
Move reposition/reschedule/reset from editor to reviewer - Implemented Reviewer action sub-menu for scheduling - added svg icon with dropdown arrow - made sure it shows up with sub-menu arrow in menu - made it show up in the menu by default, but it can be a custom button - Altered Collection.undo() for scheduling a...
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -49,6 +49,7 @@ import android.text.style.UnderlineSpan;\n import android.util.TypedValue;\n import and...
Kotlin
a7b77de4e263922b949d82af0dd8664d02735f2e
80
2018-12-02 09:43:35+09:00
18,000
['7855dd0216828320fe46081b4407910661d58202']
Codacy / de-lint changes - no semantic differences
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -213,7 +213,6 @@ public abstract class AbstractFlashcardViewer extends NavigationDrawerActivity {\n ...
Kotlin
e4de3b059a1fd39644c9633513e4936ba5a57989
80
2018-12-02 10:02:49+09:00
18,000
['a7b77de4e263922b949d82af0dd8664d02735f2e']
Catch common Play Console crash, logging for root cause I know just catching null pointers isn't the solution, but I can't figure out how this code is causing a crash, so I'm logging the object lookup chain parts then logging the NullPointerException that is our current top crash on Play Console that I haven't fixed y...
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/utils/VersionUtils.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/utils/VersionUtils.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -62,6 +62,14 @@ public class VersionUtils {\n return pInfo.versionCode;\n } catch (PackageManager.Name...
Kotlin
a60bb2d552827b6b738a1363e78123d6a086f44c
124
2018-12-02 20:33:58+09:00
-32,400
['e4de3b059a1fd39644c9633513e4936ba5a57989']
Bumped version to 2.9alpha53 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
3a41d97e50ab08a2791a30c7c0baf14eb9904653
80
2018-12-03 08:31:16+09:00
18,000
['a60bb2d552827b6b738a1363e78123d6a086f44c']
Return from NoteEditor if TemplateEditor deleted current card Fixes an array overrun crash where note editor tried to build the card button bar but the card was gone
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/NoteEditor.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/NoteEditor.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1062,19 +1062,23 @@ public class NoteEditor extends AnkiActivity {\n break;\n }\n case ...
Kotlin
26501d24558ff63c2a8a647e9cbfc59290a5709d
80
2018-12-03 08:31:16+09:00
18,000
['3a41d97e50ab08a2791a30c7c0baf14eb9904653']
Make Card object truly comparable w/equals()+hashCode() mapping the long to the int for a nice hash distribution is the only fancy bit, but is pretty will understood and not really complicated
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Card.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Card.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -648,4 +648,18 @@ public class Card implements Cloneable {\n }\n return TextUtils.join(", ", members);\n }\n+\n+ ...
Kotlin
1fa1976059beb2d3c40063d62063544a2b1c5ddf
80
2018-12-03 08:31:16+09:00
18,000
['26501d24558ff63c2a8a647e9cbfc59290a5709d']
Focus the correct template when opening template editor
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardTemplateEditor.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardTemplateEditor.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -71,6 +71,7 @@ public class CardTemplateEditor extends AnkiActivity {\n private SlidingTabLayout mSlidingTab...
Kotlin
ccc1a5f65c454c6a82285be93a3aa4fb56346ef7
80
2018-12-03 08:31:16+09:00
18,000
['1fa1976059beb2d3c40063d62063544a2b1c5ddf']
Handle hardware back button in card template editor
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardTemplateEditor.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardTemplateEditor.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -168,14 +168,19 @@ public class CardTemplateEditor extends AnkiActivity {\n }\n \n @Override\n- publi...
Kotlin
0d4c790aa83c11f7345d697a39c01bd82823bf92
80
2018-12-03 08:31:16+09:00
18,000
['ccc1a5f65c454c6a82285be93a3aa4fb56346ef7']
Rename template add/remove handler to reflect purpose calling it an "update" handler when it doesn't handle edits, but just handles add / deletes was confusing in the context of specifically fixing how template editor handles updates vs how it handles add / deletes
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardTemplateEditor.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardTemplateEditor.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -80,8 +80,8 @@ public class CardTemplateEditor extends AnkiActivity {\n // Listeners\n // --------------...
Kotlin
d6350fc136c77d7981280ebdd3bfa812ff8b1af9
124
2018-12-03 20:34:46+09:00
-32,400
['0d4c790aa83c11f7345d697a39c01bd82823bf92']
Bumped version to 2.9alpha54 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
43e7e4ad66bc74f7925c065f1ac89466817264c6
80
2018-12-04 17:49:07-05:00
18,000
['d6350fc136c77d7981280ebdd3bfa812ff8b1af9']
Use Robolectric @Config(sdk=) annotation to test version skew Previously had a sort of complicated subclass thing to test the two different implementations (for API-specific methods) but it turns out Robolectric can do that natively, down to API16
[{'old_path': 'AnkiDroid/src/test/java/com/ichi2/compat/CompatDefaultTest.java', 'new_path': 'AnkiDroid/src/test/java/com/ichi2/compat/CompatCopyFileTest.java', 'type': <ModificationType.RENAME: 3>, 'diff': '@@ -20,6 +20,9 @@ import com.ichi2.anki.TestUtils;\n \n import org.junit.Assert;\n import org.junit.Test;\n+impo...
Kotlin
9f572f07e25c6c15903ef563e7abb717f5fdd332
80
2018-12-04 17:49:07-05:00
18,000
['43e7e4ad66bc74f7925c065f1ac89466817264c6']
Enable robolectric logging by default I had this in there but commented out, it's more useful than not I think, so I'm enabling it by default with this commit. If it starts to blow up Travis with too much logging for some reason, we can tune it later
[{'old_path': 'AnkiDroid/src/test/java/com/ichi2/anki/RobolectricTest.java', 'new_path': 'AnkiDroid/src/test/java/com/ichi2/anki/RobolectricTest.java', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -4,6 +4,7 @@ import com.ichi2.libanki.DB;\n \n import org.junit.After;\n import org.junit.Before;\n+import org.robolec...
Kotlin
d8e0f20ad69017ed8aa04c4cfe945f61fae2310b
80
2018-12-04 17:49:07-05:00
18,000
['9f572f07e25c6c15903ef563e7abb717f5fdd332']
Clean test models more aggressively in content provider
[{'old_path': 'AnkiDroid/src/androidTest/java/com.ichi2.anki.tests/ContentProviderTest.java', 'new_path': 'AnkiDroid/src/androidTest/java/com.ichi2.anki.tests/ContentProviderTest.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -161,7 +161,18 @@ public class ContentProviderTest {\n assertEquals("Check t...
Kotlin
ebf74e06645a9a75e5eb9c14b24b6319b0339775
80
2018-12-04 17:49:07-05:00
18,000
['d8e0f20ad69017ed8aa04c4cfe945f61fae2310b']
Remove deprecated sudo statement from Travis CI They are combining their Linux infrastructure to be all VM-based and not container-based, which was what the sudo directive did, modulo our "android" config which meant we went to VMs all the time (confirmed with their support) So this doesn't change our CI execution at...
[{'old_path': '.travis.yml', 'new_path': '.travis.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,7 +1,5 @@\n language: android\n \n-sudo: false\n-\n jdk:\n - oraclejdk8\n \n'}]
Kotlin
468676f3b96063519c45ab3c610beaf132906aa8
80
2018-12-04 20:27:59-05:00
18,000
['ebf74e06645a9a75e5eb9c14b24b6319b0339775']
Disable API24 in Travis, it has become unreliable This appears to be a progressive disease related to code growth or something, unsure. Bears examination later but in the meantime CI should never flake
[{'old_path': '.travis.yml', 'new_path': '.travis.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -21,7 +21,7 @@ env:\n - API=21\n - API=22\n #- API=23 EMU_FLAVOR=google_apis # fails consistently but can run local\n- - API=24\n+ #- API=24 #API24 flaky now as well (after API18 started flaking). It i...
Kotlin
4b6bdafb3a9d170170a800e4c67c3e9c3088929f
80
2018-12-05 14:51:49+09:00
18,000
['49950bfc94154520c8bd96db6c94c76638c59d55']
Add copyrights, purge flaky UI tests, add utility methods
[{'old_path': '.travis.yml', 'new_path': '.travis.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -69,7 +69,7 @@ install:\n - adb shell input keyevent 82 &\n \n script:\n- - ./gradlew jacocoTestReport -Pandroid.testInstrumentationRunnerArguments.notPackage=com.ichi2.anki.uitests\n+ - ./gradlew jacocoTestRep...
Kotlin
86f77d1dd2cd18ee312ebbe8349ef20cee2e5b96
80
2018-12-08 06:25:24+09:00
18,000
['4b6bdafb3a9d170170a800e4c67c3e9c3088929f']
Don't send exception reports for media sync errors
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/async/Connection.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/async/Connection.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -409,8 +409,6 @@ public class Connection extends BaseAsyncTask<Connection.Payload, Object, Connec\n da...
Kotlin
6b639627e2794ac3bd69164c4292bfc8c34544eb
80
2018-12-12 17:14:24-05:00
18,000
['86f77d1dd2cd18ee312ebbe8349ef20cee2e5b96']
Dependency Updates - annotation, mockito-core, requery (#5160) Bumps annotation from 1.0.0 to 1.0.1. Bumps mockito-core from 2.23.0 to 2.23.4 Bumps sqlite-android from 3.25.2 to 3.25.3
[{'old_path': 'AnkiDroid/build.gradle', 'new_path': 'AnkiDroid/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -153,12 +153,12 @@ dependencies {\n implementation \'androidx.browser:browser:1.0.0\'\n implementation \'androidx.exifinterface:exifinterface:1.0.0\'\n implementation \'androidx.re...
Kotlin
22cc4d9623470ffcab9dc1331659f74e8fac22f1
80
2018-12-13 09:19:17-05:00
18,000
['6b639627e2794ac3bd69164c4292bfc8c34544eb']
Skip API16 method used only in test for API15
[{'old_path': 'AnkiDroid/src/androidTest/java/com.ichi2.anki.tests/libanki/DBTest.java', 'new_path': 'AnkiDroid/src/androidTest/java/com.ichi2.anki.tests/libanki/DBTest.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -3,8 +3,10 @@ package com.ichi2.anki.tests.libanki;\n import android.Manifest;\n import androi...
Kotlin
b032a545c63848c400a83b66a15d126f840053ca
80
2018-12-13 09:19:17-05:00
18,000
['22cc4d9623470ffcab9dc1331659f74e8fac22f1']
ependency updates - androidx.test, google-analytics-java7 - google-analytics-java7 is the Java7 version of google analytics library -- this allows fully async CompletableFuture usage w/out compatibility upstream but the Java7 branch is identical code, just using a compatibility library tested and working correct...
[{'old_path': 'AnkiDroid/build.gradle', 'new_path': 'AnkiDroid/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -167,7 +167,7 @@ dependencies {\n implementation\'ch.acra:acra-toast:5.2.1\'\n implementation\'ch.acra:acra-limiter:5.2.1\'\n \n- implementation \'net.mikehardy:google-analytics-jav...
Kotlin
626493a945e0093d26d7f05448fc6c630e9eca95
140
2018-12-17 09:26:40-05:00
0
['b032a545c63848c400a83b66a15d126f840053ca']
Bump sqlite-android from 3.25.3 to 3.26.0 Bumps [sqlite-android](https://github.com/requery/sqlite-android) from 3.25.3 to 3.26.0. - [Release notes](https://github.com/requery/sqlite-android/releases) - [Changelog](https://github.com/requery/sqlite-android/blob/master/CHANGELOG.md) - [Commits](https://github.com/reque...
[{'old_path': 'AnkiDroid/build.gradle', 'new_path': 'AnkiDroid/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -153,7 +153,7 @@ dependencies {\n implementation 'androidx.browser:browser:1.0.0'\n implementation 'androidx.exifinterface:exifinterface:1.0.0'\n implementation 'androidx.recyclerv...
Kotlin
3c9e69c77aa9262a454d4bd8a8758e65b8535de8
134
2018-12-18 09:25:12+09:00
0
['626493a945e0093d26d7f05448fc6c630e9eca95']
Improve detection of display dimensions
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/Whiteboard.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/Whiteboard.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -234,7 +234,8 @@ public class Whiteboard extends View {\n \n private void createBitmap() {\n // To fix issue #1336, ...
Kotlin
1187dddac916f75d952bdb683931df489fcef985
80
2018-12-21 12:44:56+09:00
18,000
['3c9e69c77aa9262a454d4bd8a8758e65b8535de8']
Track and publish database check progress. Fixes #5155
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1215,7 +1215,7 @@ public class DeckPicker extends NavigationDrawerActivity implements\n DeckTask.launchDeckTask(DeckTas...
Kotlin
d78814220659252affdf4e2a87adcc298e21be96
80
2018-12-21 14:14:17+09:00
18,000
['1187dddac916f75d952bdb683931df489fcef985']
Show a confirmation before full sync, Fixes #5176
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/Preferences.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/Preferences.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -59,6 +59,7 @@ import com.ichi2.libanki.hooks.Hooks;\n import com.ichi2.preferences.NumberRangePreference;\n import com.ichi2....
Kotlin
055fffdf3e3f2341550c261d3f789f6e5d015b50
124
2018-12-21 14:17:14+09:00
-32,400
['d78814220659252affdf4e2a87adcc298e21be96']
Bumped version to 2.9alpha55 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
597edc2f71f55811aeb542d7919fdfc9430edb99
80
2018-12-21 01:10:01-05:00
18,000
['055fffdf3e3f2341550c261d3f789f6e5d015b50']
Allow two more parallel build names (5 total now)
[{'old_path': 'tools/parallel-package-release.sh', 'new_path': 'tools/parallel-package-release.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -27,7 +27,7 @@ export KEYPWD\n # Get on to the tag requested\n #git checkout $TAG\n \n-BUILDNAMES='A B C'\n+BUILDNAMES='A B C D E'\n for BUILD in $BUILDNAMES; do\n gi...
Kotlin
967be10f62fda0fe825d2da5bf0ea9bb363ec237
80
2018-12-28 14:56:45+09:00
18,000
['597edc2f71f55811aeb542d7919fdfc9430edb99']
Refactor dismiss + answer handlers as "next card" handlers Previously the answer handler had the implementation, and the dismiss handler called into it. Now there is a general "next card" handler, and they both use it
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -437,27 +437,8 @@ public abstract class AbstractFlashcardViewer extends NavigationDrawerActivity {\n ...
Kotlin
2883f1e70d296fa5797343c6358c994a0a7be51a
80
2018-12-28 14:56:45+09:00
18,000
['967be10f62fda0fe825d2da5bf0ea9bb363ec237']
Use "next card" handling after reschedule actions, Fixes #5167
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/Reviewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/Reviewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -81,18 +81,14 @@ public class Reviewer extends AbstractFlashcardViewer {\n };\n \n /** We need to listen for and handle repo...
Kotlin
288f24ae948ca7992f109b4f6cf1f239d94d4e56
80
2019-01-03 21:55:55-05:00
18,000
['2883f1e70d296fa5797343c6358c994a0a7be51a']
Update to gradle 4.10.3 Two notes: 1) we have (verified by history) always used 'all' gradle distribution, however I don't think we actually need the 'all' vs 'bin'. Feel free to alter this in the future if you have an 'all'-specific need but in the meantime I'll shave 30% of the weight off the dep by going ...
[{'old_path': 'gradle/wrapper/gradle-wrapper.jar', 'new_path': 'gradle/wrapper/gradle-wrapper.jar', 'type': <ModificationType.MODIFY: 5>, 'diff': 'Binary files a/gradle/wrapper/gradle-wrapper.jar and b/gradle/wrapper/gradle-wrapper.jar differ\n'}, {'old_path': 'gradle/wrapper/gradle-wrapper.properties', 'new_path': 'gr...
Kotlin
e369711937e54fb8bdee9ecd71a4a4e5420c689d
46
2019-01-05 09:30:45+09:00
18,000
['288f24ae948ca7992f109b4f6cf1f239d94d4e56']
Match Anki lib css selectors on cards, Fixes #4721 Ankiweb and Anki Desktop select the text in a Card using the css selector `#qa`, while AnkiDroid previously used `.question` and `.answer` to do the same.
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2324,7 +2324,7 @@ public abstract class AbstractFlashcardViewer extends NavigationDrawerActivity {\n ...
Kotlin
0ab458d74baf5b75db03a6bda0f45f683c7df6b2
124
2019-01-06 10:26:38+09:00
-32,400
['e369711937e54fb8bdee9ecd71a4a4e5420c689d']
Bumped version to 2.9alpha56 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
f15aeefa5afc174cc8d00f7f8fbc05f3224f7847
80
2019-01-08 14:42:03-05:00
18,000
['0ab458d74baf5b75db03a6bda0f45f683c7df6b2']
Dependency updates 20190108 (#5196) ## Pull Request template ## Purpose / Description Point release for okhttp 3.12.0 -> 3.12.1 Bring powermock to release status 2.0.0-RC.4 -> 2.0.0 ## How Has This Been Tested? These are tested in CI then I merge them unless they are large version changes
[{'old_path': 'AnkiDroid/build.gradle', 'new_path': 'AnkiDroid/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -168,7 +168,7 @@ dependencies {\n implementation'ch.acra:acra-limiter:5.2.1'\n \n implementation 'net.mikehardy:google-analytics-java7:2.0.6'\n- implementation 'com.squareup.okhttp3...
Kotlin
2401e1637bbec7ac9f48ae863339ab652eb932b9
80
2019-01-24 08:00:09-05:00
18,000
['f15aeefa5afc174cc8d00f7f8fbc05f3224f7847']
Update gradle plugin from 3.2.1 to 3.3.0
[{'old_path': 'build.gradle', 'new_path': 'build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -7,7 +7,7 @@ buildscript {\n jcenter()\n }\n dependencies {\n- classpath \'com.android.tools.build:gradle:3.2.1\'\n+ classpath \'com.android.tools.build:gradle:3.3.0\'\n clas...
Kotlin
a0820d3fe3a9e60bc168a5aff9604cae56f93d4e
102
2019-01-27 00:39:58+09:00
-28,800
['2401e1637bbec7ac9f48ae863339ab652eb932b9']
Add link to third party apps which support AnkiDroid API (#5204)
[{'old_path': 'AnkiDroid/src/main/res/values/10-preferences.xml', 'new_path': 'AnkiDroid/src/main/res/values/10-preferences.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -152,6 +152,8 @@\n <string name="custom_buttons_setting_if_room">Show if room</string>\n <string name="custom_buttons_setting_menu_o...
Kotlin
8b500b2c2c70d89182a9ce81ae0689d305be3913
80
2019-01-28 14:57:37-05:00
18,000
['a0820d3fe3a9e60bc168a5aff9604cae56f93d4e']
Upgrade JaCoCo to 0.8.3 Created a variable and used it for the required secondary locations The project-level version definition is required or jacocoAnt gets the wrong version The android-block version definition is required or the Jacoco agent is the wrong version
[{'old_path': 'AnkiDroid/build.gradle', 'new_path': 'AnkiDroid/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,6 +2,10 @@ apply plugin: \'com.android.application\'\n apply plugin: \'com.github.triplet.play\'\n apply plugin: \'jacoco\'\n \n+jacoco {\n+ toolVersion = "$rootProject.ext.jacocoVersion...
Kotlin
4ee048f7792171d20edd430a021f8092e1a0cd6c
80
2019-01-28 14:57:37-05:00
18,000
['8b500b2c2c70d89182a9ce81ae0689d305be3913']
Upgrade robolectric to 4.1 (new PackageManager APIs)
[{'old_path': 'AnkiDroid/build.gradle', 'new_path': 'AnkiDroid/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -191,7 +191,7 @@ dependencies {\n testImplementation \'org.hamcrest:hamcrest-all:1.3\'\n testImplementation \'net.lachlanmckee:timber-junit-rule:1.0.1\'\n testImplementation \'andr...
Kotlin
b1e854672634e807315fae4972d380b3f1ea160f
80
2019-01-28 14:57:37-05:00
18,000
['4ee048f7792171d20edd430a021f8092e1a0cd6c']
Update Robolectric in api module to 4.1
[{'old_path': 'api/build.gradle', 'new_path': 'api/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -42,7 +42,7 @@ android {\n dependencies {\n api fileTree(dir: \'libs\', include: [\'*.jar\'])\n testImplementation \'org.junit.vintage:junit-vintage-engine:5.3.2\'\n- testImplementation "org.ro...
Kotlin
039bbc8a0ce3a058677a77db9977f990c2d54528
80
2019-01-28 14:57:37-05:00
18,000
['b1e854672634e807315fae4972d380b3f1ea160f']
Ignore jdk.internal objects for JaCoCo reports This improves forward-compatibility for JDK>8
[{'old_path': 'AnkiDroid/build.gradle', 'new_path': 'AnkiDroid/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -109,6 +109,7 @@ tasks.withType(JavaCompile) {\n \n tasks.withType(Test) {\n jacoco.includeNoLocationClasses = true\n+ jacoco.excludes = ['jdk.internal.*']\n }\n \n // Our merge report ...
Kotlin
f0a73d279260b3e6c48bc6b251bc4a0eff843d8b
80
2019-01-29 08:56:40+09:00
18,000
['039bbc8a0ce3a058677a77db9977f990c2d54528']
Avoid production crash for short stack traces There are user reports in issue #5205 of repeatable production crashes related to logging failures. The affected code is copied from a section of the logging library that is intended for debug use, where a crash is acceptable, but for production the logging code should ne...
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AnkiDroidApp.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/AnkiDroidApp.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -472,8 +472,13 @@ public class AnkiDroidApp extends Application {\n // because Robolectric runs them on the JVM ...
Kotlin
9772156576c5bae1c2d1d4f77d1030608f8da1a2
124
2019-01-29 09:07:38+09:00
-32,400
['f0a73d279260b3e6c48bc6b251bc4a0eff843d8b']
Bumped version to 2.9alpha58 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
df0f54c4ec209dd276cca61f59b11b32053d3bee
64
2019-02-02 15:33:33+11:00
-39,600
['9772156576c5bae1c2d1d4f77d1030608f8da1a2']
Add SchedV2.java class to support Scheduler v2 (#5164) Initial implementation of SchedV2
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Decks.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Decks.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -4,6 +4,7 @@\n * Copyright (c) 2009 Edu Zamora <edu.zasu@gmail.com> *\n * Copyright (c) 2010 Nor...
Kotlin
61642255fcc6f29e7d8b16f7ca3f30cc9bd4e9dc
85
2019-02-03 11:19:44+09:00
-39,600
['df0f54c4ec209dd276cca61f59b11b32053d3bee']
Complete SchedV2 with collection and syncing support Fixed lots of errors in the process
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -103,6 +103,9 @@ public class Collection {\n private static final Pattern fClozePatternA = Pattern.compile("\\\\{\\\\{...
Kotlin
d402790bb955f392b89cdc88bfc1f9b3d95f5634
85
2019-02-03 11:19:44+09:00
-39,600
['61642255fcc6f29e7d8b16f7ca3f30cc9bd4e9dc']
Fix some compiling and loading issues
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/libanki/Collection.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -222,7 +222,7 @@ public class Collection {\n modSchema(true);\n SchedV2 v2Sched = new SchedV2(this);\n ...
Kotlin
ada6b556b9061e66d7cc3d1f76ff6a1d958dfc71
124
2019-02-03 11:21:59+09:00
-32,400
['570b696a5e3fac1d91cba3b01f0782c51bbcf0df']
Bumped version to 2.9alpha59 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
a2ca1bede5c7d9e86b2ed10a893a7c636a40a6c5
80
2019-02-03 11:23:36+09:00
18,000
['ada6b556b9061e66d7cc3d1f76ff6a1d958dfc71']
Use test orchestrator for instrumented tests This change should isolate individual tests, making test results more useful as one test won't halt the whole run This should work okay now with the change to ANDROIDX prefix
[{'old_path': 'AnkiDroid/build.gradle', 'new_path': 'AnkiDroid/build.gradle', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -57,7 +57,7 @@ android {\n \n testOptions {\n // we should use orchestrator, but app data shared on /sdcard makes it unstable\n- //execution 'ANDROID_TEST_ORCHESTRATOR'\n+ ...
Kotlin
2bca8ade9197b59cbd38ef5d3076fc60c32dea84
80
2019-02-03 11:25:00+09:00
18,000
['a2ca1bede5c7d9e86b2ed10a893a7c636a40a6c5']
Extend alternative themes into Reviewer by emitting CSS selectors Fixes #5127 by extending the "dark" (vs black) theme into the reviewer, previously dark theme was ignored in the HTML/CSS emitted if you had selected it - there was only white and black "plain" mode (the "white" alternative theme) doesn't affect the re...
[{'old_path': 'AnkiDroid/src/main/assets/flashcard.css', 'new_path': 'AnkiDroid/src/main/assets/flashcard.css', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -8,6 +8,10 @@ body.night_mode {\n background-color: black;\n }\n \n+body.ankidroid_dark_mode {\n+ background-color: #303030;\n+}\n+\n #content {\n margin...
Kotlin
bbc4bc204320b9760d0865843d9b0fece6c0e862
124
2019-02-03 11:30:40+09:00
-32,400
['2bca8ade9197b59cbd38ef5d3076fc60c32dea84']
Bumped version to 2.9alpha60 @branch-specific
[{'old_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'new_path': 'AnkiDroid/src/main/AndroidManifest.xml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,8 +22,8 @@\n xmlns:tools="http://schemas.android.com/tools"\n package="com.ichi2.anki"\n android:installLocation="auto"\n- ...
Kotlin
103026f758fb557fa7a58ab0a55e628df07ae18c
80
2019-02-05 10:49:34+09:00
18,000
['bbc4bc204320b9760d0865843d9b0fece6c0e862']
Only allow reposition for new cards, Fixes #5216
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -57,6 +57,7 @@ import com.ichi2.anki.dialogs.CardBrowserMySearchesDialog;\n import com.ichi2.anki.dialogs.CardBrowserOrderDial...
Kotlin
4e2ef56c718cd3d853b7e77e8023db128d209e8c
124
2019-02-05 12:06:39+09:00
-32,400
['103026f758fb557fa7a58ab0a55e628df07ae18c']
Preserve order in browser card selection
[{'old_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'new_path': 'AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.java', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -81,10 +81,11 @@ import java.util.ArrayList;\n import java.util.Arrays;\n import java.util.Collections;\n import java.util.Has...
Kotlin