task_id
stringlengths
10
58
repo
stringclasses
854 values
pr_number
int32
1
321k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
task
stringlengths
2
105k
plan
listlengths
1
100
subagents
listlengths
1
100
revisions
listlengths
0
100
final_diff
stringlengths
256
202M
num_subtasks
int32
1
100
num_changed_files
int32
2
100
FuelLabs/fuels-ts#3938
FuelLabs/fuels-ts
3,938
5b3bb62720228a71e7c21ddde5b2824ed56b67f1
2a5d07b82845497503ae6ed82908f3f7b20d3b3d
chore!: breaking change for `fuel-core@v0.44.0` # Summary - Breaking change for the following PR: - #3901 # Breaking Changes - `fuel-core` release [`v0.44.0`](https://github.com/FuelLabs/fuel-core/releases/tag/v0.44.0) is a breaking change. # Checklist - [X] All **changes** are **covered** by **test...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: chore!: breaking change for `fuel-core@v0.44.0`", "scope_files": [ ".changeset/full-carpets-lose.md", ".changeset/hungry-clouds-switch.md" ] } ]
[ { "subtask_id": "s1", "scope_files": [ ".changeset/full-carpets-lose.md", ".changeset/hungry-clouds-switch.md" ], "solution_diff": "diff --git a/.changeset/full-carpets-lose.md b/.changeset/full-carpets-lose.md\nindex 90b55d28e1d..8b91dec33d7 100644\n--- a/.changeset/full-carpets-lose.md...
[]
diff --git a/.changeset/full-carpets-lose.md b/.changeset/full-carpets-lose.md index 90b55d28e1d..8b91dec33d7 100644 --- a/.changeset/full-carpets-lose.md +++ b/.changeset/full-carpets-lose.md @@ -1,11 +1,11 @@ --- -"@internal/fuel-core": patch -"@fuel-ts/account": patch -"@fuel-ts/contract": patch -"fuels": patch -"@...
1
2
FuelLabs/fuels-ts#3901
FuelLabs/fuels-ts
3,901
bce0f79ed13dca6b0f6b992b4501cdcfad140932
45430b237788817c8169a88c9d2557479173a835
Upgrade `fuel-core` to `0.44.0` Changelog: - https://github.com/FuelLabs/fuel-core/releases/tag/v0.44.0 The list above appears flat, but based on the PR below, it seems we have a few breaking changes: - https://github.com/FuelLabs/fuel-core/pull/3025 chore: upgrade `fuel-core` to `0.44.0` - Closes #3898 # Releas...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Upgrade `fuel-core` to `0.44.0`", "scope_files": [ "pnpm-lock.yaml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.changeset/` needed for: Upgrade `fuel-core` to `0.44.0`", "scop...
[ { "subtask_id": "s1", "scope_files": [ "pnpm-lock.yaml" ], "solution_diff": "diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml\nindex 66bd4eb9e18..569ec3e4ed2 100644\n--- a/pnpm-lock.yaml\n+++ b/pnpm-lock.yaml\n@@ -279,8 +279,8 @@ importers:\n apps/demo-nextjs:\n dependencies:\n '@fuels...
[ { "subtask_id": "s2", "comment": "```suggestion\r\nchore: upgrade `fuel-core` to `0.44.0`\r\n```", "revised_diff": "diff --git a/.changeset/full-carpets-lose.md b/.changeset/full-carpets-lose.md\nnew file mode 100644\nindex 00000000000..90b55d28e1d\n--- /dev/null\n+++ b/.changeset/full-carpets-lose.md\n...
diff --git a/.changeset/full-carpets-lose.md b/.changeset/full-carpets-lose.md new file mode 100644 index 00000000000..90b55d28e1d --- /dev/null +++ b/.changeset/full-carpets-lose.md @@ -0,0 +1,11 @@ +--- +"@internal/fuel-core": patch +"@fuel-ts/account": patch +"@fuel-ts/contract": patch +"fuels": patch +"@fuel-ts/pro...
26
33
FuelLabs/fuels-ts#3912
FuelLabs/fuels-ts
3,912
c8b6d0ee6331970bef02a23ce14cf0aa101c2920
f5d9e97c3f45a9dd228a411d57c0fa657404af24
ci(release): `v0.101.3` @ `master` # Summary In this release, we: - Implemented the auto-consolidation flow to detect when the max UTXO limit has been reached. - Added helper function for consolidating coins (`consolidateCoins`). - Added method for consolidating non-base assets. - Added the JSON ABI error entry to `...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: ci(release): `v0.101.3` @ `master`", "scope_files": [ ".changeset/beige-berries-train.md", ".changeset/cyan-pandas-know.md", ".changeset/dry-towns-swim.md", ".changeset/hungry-webs-join.md", ...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/beige-berries-train.md", ".changeset/cyan-pandas-know.md", ".changeset/dry-towns-swim.md", ".changeset/hungry-webs-join.md", ".changeset/lazy-coins-tease.md", ".changeset/spicy-waves-throw.md", ".changeset/stale-new...
[]
diff --git a/.changeset/beige-berries-train.md b/.changeset/beige-berries-train.md deleted file mode 100644 index 1efaeaff8f7..00000000000 --- a/.changeset/beige-berries-train.md +++ /dev/null @@ -1,4 +0,0 @@ ---- ---- - -chore: fix vercel deployment workflow \ No newline at end of file diff --git a/.changeset/cyan-pan...
23
53
FuelLabs/fuels-ts#3929
FuelLabs/fuels-ts
3,929
eefaa749833f7d609f6a9b4fd3d62ce33863ff0b
15fc369f5557285739d4e39443973ccdc88b774f
feat: added auto-consolidation of coins - Related to #3808 # Release notes In this release, we: - Implemented the auto-consolidation flow to detect when the max UTXO limit has been reached. - Added helper function for consolidating coins (`consolidateCoins`). # Summary With our previous implementation...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: feat: added auto-consolidation of coins", "scope_files": [ ".changeset/spicy-waves-throw.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `packages/account/src/` needed for: feat...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/spicy-waves-throw.md" ], "solution_diff": "diff --git a/.changeset/spicy-waves-throw.md b/.changeset/spicy-waves-throw.md\nnew file mode 100644\nindex 00000000000..bcfc09c6db9\n--- /dev/null\n+++ b/.changeset/spicy-waves-throw.md\n@@ -0,0 +1,8...
[ { "subtask_id": "s2", "comment": "callback hell, promise.then, promise.catch, are problems solved by `await` , which helps to write async code in a sync way, improving readability. \r\n\r\ncan we simplify it using try catch only? also on another places that the same is being done", "revised_diff": "diff...
diff --git a/.changeset/spicy-waves-throw.md b/.changeset/spicy-waves-throw.md new file mode 100644 index 00000000000..bcfc09c6db9 --- /dev/null +++ b/.changeset/spicy-waves-throw.md @@ -0,0 +1,8 @@ +--- +"@fuel-ts/account": patch +"@fuel-ts/contract": patch +"@fuel-ts/program": patch +"@fuel-ts/errors": patch +--- + +...
13
22
FuelLabs/fuels-ts#3923
FuelLabs/fuels-ts
3,923
9810db53d70f86f5225b14d9e27f9498bf9c63ff
30753767b129ec5ff9fb95425a4112e22185332a
Implement UTXO Consolidation Helpers (for non-base assets) Follow-up after: - https://github.com/FuelLabs/fuels-ts/issues/3645 It should extend the consolidation capabilities for dealing with non-base assets. feat: consolidate non-base asset - Closes #3855 # Release notes In this release, we: - Added met...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: Implement UTXO Consolidation Helpers (for non-base assets)", "scope_files": [ ".changeset/wild-dryers-retire.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `apps/docs/src/guide...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/wild-dryers-retire.md" ], "solution_diff": "diff --git a/.changeset/wild-dryers-retire.md b/.changeset/wild-dryers-retire.md\nnew file mode 100644\nindex 00000000000..eb64aad403c\n--- /dev/null\n+++ b/.changeset/wild-dryers-retire.md\n@@ -0,0 ...
[ { "subtask_id": "s3", "comment": "Was this intended to test a consolidation for the non-base asset?", "revised_diff": "diff --git a/packages/account/src/consolidate-coins.test.ts b/packages/account/src/consolidate-coins.test.ts\nindex c90a181de4f..b7386bd394e 100644\n--- a/packages/account/src/consolida...
diff --git a/.changeset/wild-dryers-retire.md b/.changeset/wild-dryers-retire.md new file mode 100644 index 00000000000..eb64aad403c --- /dev/null +++ b/.changeset/wild-dryers-retire.md @@ -0,0 +1,5 @@ +--- +"@fuel-ts/account": patch +--- + +feat: consolidate non-base asset diff --git a/apps/docs/src/guide/cookbook/com...
3
4
FuelLabs/fuels-ts#3915
FuelLabs/fuels-ts
3,915
7def0a56632cf3d49428b97caf5cc9ce7cedc403
f2abda4c1002a46cd7eb3e87ff5fca6b87cb375e
chore: fix vercel deployment workflow # Summary - Fixes the broken release pipeline - Fixes the broken preview URL in PR comments # Checklist - [X] All **changes** are **covered** by **tests** (or not applicable) - [X] All **changes** are **documented** (or not applicable) - [X] I **reviewed** the **entire...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: chore: fix vercel deployment workflow", "scope_files": [ ".changeset/beige-berries-train.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflows/` needed for: chore: ...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/beige-berries-train.md" ], "solution_diff": "diff --git a/.changeset/beige-berries-train.md b/.changeset/beige-berries-train.md\nnew file mode 100644\nindex 00000000000..1efaeaff8f7\n--- /dev/null\n+++ b/.changeset/beige-berries-train.md\n@@ -...
[]
diff --git a/.changeset/beige-berries-train.md b/.changeset/beige-berries-train.md new file mode 100644 index 00000000000..1efaeaff8f7 --- /dev/null +++ b/.changeset/beige-berries-train.md @@ -0,0 +1,4 @@ +--- +--- + +chore: fix vercel deployment workflow \ No newline at end of file diff --git a/.github/workflows/publi...
2
3
FuelLabs/fuels-ts#3921
FuelLabs/fuels-ts
3,921
4e018a571a5b576d93c933da449e2a78d5d1c633
8da7ac4b56a15bd6ac9df5d5016b923a64329bfb
chore: add JSON ABI error entry to `FuelError.metadata` # Release notes In this release, we: - Added the JSON ABI error entry to `FuelError.metadata` property # Checklist - [x] All **changes** are **covered** by **tests** (or not applicable) - [x] All **changes** are **documented** (or not applicable) - ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: chore: add JSON ABI error entry to `FuelError.metadata`", "scope_files": [ ".changeset/cyan-pandas-know.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `packages/account/src/pro...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/cyan-pandas-know.md" ], "solution_diff": "diff --git a/.changeset/cyan-pandas-know.md b/.changeset/cyan-pandas-know.md\nnew file mode 100644\nindex 00000000000..6c76bd10dfb\n--- /dev/null\n+++ b/.changeset/cyan-pandas-know.md\n@@ -0,0 +1,5 @@\...
[]
diff --git a/.changeset/cyan-pandas-know.md b/.changeset/cyan-pandas-know.md new file mode 100644 index 00000000000..6c76bd10dfb --- /dev/null +++ b/.changeset/cyan-pandas-know.md @@ -0,0 +1,5 @@ +--- +"@fuel-ts/account": patch +--- + +chore: add JSON ABI error entry to `FuelError.metadata` diff --git a/packages/accoun...
3
3
FuelLabs/fuels-ts#3913
FuelLabs/fuels-ts
3,913
c73a41703370c9feeed6585fa16c8f5f719a110d
12e40749d2c3c1c7f7b71915d3fb327d9fcab326
Fail gracefully when response body is not defined or null ## Summary Incoming from the [forum](https://forum.fuel.network/t/getting-error-while-calling-sender-transfer/9254) When performing a request, and the response body is `undefined` or `null`, we should handle this scenario gracefully and report potential issue...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: Fail gracefully when response body is not defined or null", "scope_files": [ ".changeset/hungry-webs-join.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `apps/docs/src/guide/er...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/hungry-webs-join.md" ], "solution_diff": "diff --git a/.changeset/hungry-webs-join.md b/.changeset/hungry-webs-join.md\nnew file mode 100644\nindex 00000000000..23ce5963bd1\n--- /dev/null\n+++ b/.changeset/hungry-webs-join.md\n@@ -0,0 +1,6 @@\...
[]
diff --git a/.changeset/hungry-webs-join.md b/.changeset/hungry-webs-join.md new file mode 100644 index 00000000000..23ce5963bd1 --- /dev/null +++ b/.changeset/hungry-webs-join.md @@ -0,0 +1,6 @@ +--- +"@fuel-ts/account": patch +"@fuel-ts/errors": patch +--- + +chore: handling for malformed response body diff --git a/a...
4
5
FuelLabs/fuels-ts#3904
FuelLabs/fuels-ts
3,904
b03dad84d171ee3972dccb339243cefbb5d1af63
81846575857e64b8f596950aee26fddf3034e427
chore: upgrade `esbuild` dependency Bumps the npm_and_yarn group with 1 update in the / directory: [esbuild](https://github.com/evanw/esbuild). Updates `esbuild` from 0.25.2 to 0.25.3 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/evanw/esbuild/releases">esbuild's releases<...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: chore: upgrade `esbuild` dependency", "scope_files": [ "pnpm-lock.yaml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.changeset/` needed for: chore: upgrade `esbuild` dependency", ...
[ { "subtask_id": "s1", "scope_files": [ "pnpm-lock.yaml" ], "solution_diff": "diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml\nindex b9213ff7ca3..66bd4eb9e18 100644\n--- a/pnpm-lock.yaml\n+++ b/pnpm-lock.yaml\n@@ -65,10 +65,10 @@ importers:\n version: 6.21.0(eslint@8.57.0)(typescript@5.7.3...
[]
diff --git a/.changeset/dry-towns-swim.md b/.changeset/dry-towns-swim.md new file mode 100644 index 00000000000..3914180f501 --- /dev/null +++ b/.changeset/dry-towns-swim.md @@ -0,0 +1,5 @@ +--- +"fuels": patch +--- + +chore: upgrade `esbuild` dependency diff --git a/packages/fuels/package.json b/packages/fuels/package...
3
3
FuelLabs/fuels-ts#3908
FuelLabs/fuels-ts
3,908
b0aa1065e0537a6a1e3e1663261d0dee72257a48
b7820d54bb84940710987c8754c2097dc2ded0c9
chore: migrate Vercel builds # Summary The latest `fuel-core` [PR](https://github.com/FuelLabs/fuels-ts/pull/3901) was failing to build the `docs` or `templates` in Vercel. This was due to an error while using `fuel-core` in the build (see error below). As we have no control over the [build image](https://vercel.co...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/actions/ci-setup/` needed for: chore: migrate Vercel builds", "scope_files": [ ".github/actions/ci-setup/action.yaml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/actions/vercel-deploy/`...
[ { "subtask_id": "s1", "scope_files": [ ".github/actions/ci-setup/action.yaml" ], "solution_diff": "diff --git a/.github/actions/ci-setup/action.yaml b/.github/actions/ci-setup/action.yaml\nindex d7aff1c20e8..798421bde04 100644\n--- a/.github/actions/ci-setup/action.yaml\n+++ b/.github/actions/...
[]
diff --git a/.github/actions/ci-setup/action.yaml b/.github/actions/ci-setup/action.yaml index d7aff1c20e8..798421bde04 100644 --- a/.github/actions/ci-setup/action.yaml +++ b/.github/actions/ci-setup/action.yaml @@ -29,3 +29,9 @@ runs: with: version: ${{ inputs.pnpm-version }} run_install: tru...
3
4
FuelLabs/fuels-ts#3911
FuelLabs/fuels-ts
3,911
365cfa84866e05db41820bd0c30cd8ba942c726f
47f96723d3724b72890ec60de2b1efda8dee3ce4
Add Object Parameter Support to TransactionResponse Constructor The current `TransactionResponse` constructor only accepts positional parameters, making it difficult to maintain and extend as the number of parameters grows. We should add support for an object parameter in the constructor to allow configuration via a ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: Add Object Parameter Support to TransactionResponse Constructor", "scope_files": [ ".changeset/stale-news-go.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `packages/account/sr...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/stale-news-go.md" ], "solution_diff": "diff --git a/.changeset/stale-news-go.md b/.changeset/stale-news-go.md\nnew file mode 100644\nindex 00000000000..4e8435a7e7e\n--- /dev/null\n+++ b/.changeset/stale-news-go.md\n@@ -0,0 +1,5 @@\n+---\n+\"@f...
[]
diff --git a/.changeset/stale-news-go.md b/.changeset/stale-news-go.md new file mode 100644 index 00000000000..4e8435a7e7e --- /dev/null +++ b/.changeset/stale-news-go.md @@ -0,0 +1,5 @@ +--- +"@fuel-ts/account": patch +--- + +chore: add object parameter support to `TransactionResponse` constructor diff --git a/package...
4
5
FuelLabs/fuels-ts#3894
FuelLabs/fuels-ts
3,894
34b77dc327004eabd0f5619ac45b8c8e063bb9e0
4155d0b4bb2034acd5cbf59ae15f10fb5ac0731c
Add support for ABI Error Types Here is the RFC: - https://github.com/FuelLabs/sway-rfcs/blob/master/rfcs/0014-abi-errors.md Related Sway issue: - https://github.com/FuelLabs/sway/issues/6765 feat: implement support for new ABI error codes - Closes #3807 # Release notes In this release, we: - Implement s...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: Add support for ABI Error Types", "scope_files": [ ".changeset/hot-results-happen.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `apps/create-fuels-counter-guide/` needed for: ...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/hot-results-happen.md" ], "solution_diff": "diff --git a/.changeset/hot-results-happen.md b/.changeset/hot-results-happen.md\nnew file mode 100644\nindex 00000000000..5b3ad19d9fe\n--- /dev/null\n+++ b/.changeset/hot-results-happen.md\n@@ -0,0 ...
[ { "subtask_id": "s20", "comment": "Why have we removed `FAILED_UNKNOWN_SIGNAL`?", "revised_diff": "diff --git a/packages/transactions/src/configs.ts b/packages/transactions/src/configs.ts\nindex bee093067d7..9608ba041f0 100644\n--- a/packages/transactions/src/configs.ts\n+++ b/packages/transactions/src/...
diff --git a/.changeset/hot-results-happen.md b/.changeset/hot-results-happen.md new file mode 100644 index 00000000000..5b3ad19d9fe --- /dev/null +++ b/.changeset/hot-results-happen.md @@ -0,0 +1,11 @@ +--- +"@fuel-ts/transactions": patch +"@fuel-ts/abi-typegen": patch +"@fuel-ts/abi-coder": patch +"@fuel-ts/versions"...
24
31
FuelLabs/fuels-ts#3899
FuelLabs/fuels-ts
3,899
bfb62ad6029bad39ebaaf79dd8fef0a1b6d781d7
014580a0b1d60d1410fbd881c23dedad7fe88a1d
ci(release): `v0.101.2` @ `master` # Summary In this release, we: - Implement support for new ABI error codes - Populated transaction summary property `calls` with invoked contract `fn` and `args` - Deprecated Node 18 - upgrade to a newer version of Node. - Upgraded `forc` to `0.68.6` # Features - [#3894](https://gi...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: ci(release): `v0.101.2` @ `master`", "scope_files": [ ".changeset/angry-donuts-enter.md", ".changeset/curvy-olives-hear.md", ".changeset/dark-pets-travel.md", ".changeset/fresh-kings-matter.md", ...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/angry-donuts-enter.md", ".changeset/curvy-olives-hear.md", ".changeset/dark-pets-travel.md", ".changeset/fresh-kings-matter.md", ".changeset/hot-results-happen.md", ".changeset/lucky-needles-greet.md", ".changeset/s...
[]
diff --git a/.changeset/angry-donuts-enter.md b/.changeset/angry-donuts-enter.md deleted file mode 100644 index 1f3ba4a5ee2..00000000000 --- a/.changeset/angry-donuts-enter.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@fuel-ts/account": patch ---- - -fix: contract operation summary for multi-calls diff --git a/.changeset/cu...
24
54
FuelLabs/fuels-ts#3905
FuelLabs/fuels-ts
3,905
0d710657c987fdc2277613b326568772009a9e6f
4fc94f5a4dc485588a777425ad7e1094347baabf
chore: update CODEOWNERS # Checklist - [x] All **changes** are **covered** by **tests** (or not applicable) - [x] All **changes** are **documented** (or not applicable) - [x] I **reviewed** the **entire PR** myself (preferably, on GH UI) - [x] I **described** all **Breaking Changes** (or there's none)
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: chore: update CODEOWNERS", "scope_files": [ ".changeset/dark-pets-travel.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/` needed for: chore: update CODEOWNERS", "s...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/dark-pets-travel.md" ], "solution_diff": "diff --git a/.changeset/dark-pets-travel.md b/.changeset/dark-pets-travel.md\nnew file mode 100644\nindex 00000000000..40c355a8f1a\n--- /dev/null\n+++ b/.changeset/dark-pets-travel.md\n@@ -0,0 +1,4 @@\...
[]
diff --git a/.changeset/dark-pets-travel.md b/.changeset/dark-pets-travel.md new file mode 100644 index 00000000000..40c355a8f1a --- /dev/null +++ b/.changeset/dark-pets-travel.md @@ -0,0 +1,4 @@ +--- +--- + +chore: update CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 3fed9e1b8a4..d199c3e5185 10...
2
2
FuelLabs/fuels-ts#3889
FuelLabs/fuels-ts
3,889
909c3fb3034a3b6ad0f7534d14a9c668ce92c8cf
aad7e10377c3500ec056c553112eb18e3cb5e996
chore: updated dependencies Bumps the npm_and_yarn group with 3 updates in the / directory: [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite), [next](https://github.com/vercel/next.js) and [esbuild](https://github.com/evanw/esbuild). Bumps the npm_and_yarn group with 1 update in the /apps/create-fuels-cou...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: chore: updated dependencies", "scope_files": [ "package.json", "pnpm-lock.yaml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.changeset/` needed for: chore: updated dependenci...
[ { "subtask_id": "s1", "scope_files": [ "package.json", "pnpm-lock.yaml" ], "solution_diff": "diff --git a/package.json b/package.json\nindex 64075e9084b..3bfca7da1b1 100644\n--- a/package.json\n+++ b/package.json\n@@ -116,7 +116,7 @@\n \"tsx\": \"4.19.3\",\n \"turbo\": \"2.4.2\",...
[]
diff --git a/.changeset/curvy-olives-hear.md b/.changeset/curvy-olives-hear.md new file mode 100644 index 00000000000..6f4b572e1a9 --- /dev/null +++ b/.changeset/curvy-olives-hear.md @@ -0,0 +1,6 @@ +--- +"fuels": patch +"create-fuels": patch +--- + +chore: updated dependencies diff --git a/apps/create-fuels-counter-gu...
9
10
FuelLabs/fuels-ts#3900
FuelLabs/fuels-ts
3,900
8c19d93c82dcd1dd30f2ea889fd268e0b93c4dad
2a79edcd4ca9d9a069703876f53c85696d73bf9a
ci(deps): bump dawidd6/action-download-artifact from 9 to 10 Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 9 to 10. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dawidd6/action-download-artifact/releases">dawidd6/action-d...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: ci(deps): bump dawidd6/action-download-artifact from 9 to 10", "scope_files": [ ".changeset/smooth-papayas-stick.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflo...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/smooth-papayas-stick.md" ], "solution_diff": "diff --git a/.changeset/smooth-papayas-stick.md b/.changeset/smooth-papayas-stick.md\nnew file mode 100644\nindex 00000000000..45f40a6dcb2\n--- /dev/null\n+++ b/.changeset/smooth-papayas-stick.md\n...
[]
diff --git a/.changeset/smooth-papayas-stick.md b/.changeset/smooth-papayas-stick.md new file mode 100644 index 00000000000..45f40a6dcb2 --- /dev/null +++ b/.changeset/smooth-papayas-stick.md @@ -0,0 +1,4 @@ +--- +--- + +chore: updated GitHub action `download-artifact` from `9` to `10` diff --git a/.github/workflows/te...
2
2
FuelLabs/fuels-ts#3902
FuelLabs/fuels-ts
3,902
ec2ac46d2b3dd3944d4b07c18b612a47b8979796
7cf7cda1539e2b333233af283296c21c43fc9f08
chore: support Node 24 - depreciate Node 18 - Related to #3524 # Release notes In this release, we: - Deprecated Node 18 - upgrade to a newer version of Node. # Summary Removed support for Node 18 due to the version no longer being maintained. # Checklist - [X] All **changes** are **covered** by ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: chore: support Node 24 - depreciate Node 18", "scope_files": [ "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.changeset/` needed for: chore: support Node 24 - deprecia...
[ { "subtask_id": "s1", "scope_files": [ "package.json" ], "solution_diff": "diff --git a/package.json b/package.json\nindex d051b141d03..64075e9084b 100644\n--- a/package.json\n+++ b/package.json\n@@ -5,7 +5,7 @@\n \"author\": \"Fuel Labs <contact@fuel.sh> (https://fuel.network/)\",\n \"pri...
[]
diff --git a/.changeset/fresh-kings-matter.md b/.changeset/fresh-kings-matter.md new file mode 100644 index 00000000000..fe56b4809cf --- /dev/null +++ b/.changeset/fresh-kings-matter.md @@ -0,0 +1,23 @@ +--- +"create-fuels": patch +"@fuel-ts/transactions": patch +"@fuel-ts/abi-typegen": patch +"@fuel-ts/abi-coder": pat...
22
22
FuelLabs/fuels-ts#3897
FuelLabs/fuels-ts
3,897
b575c6ea0f07740864dc6002d67104c82561974e
6308d037400d92eb75affdf65ce9fdda8bd675ba
Assembling a transaction summary using multicall incorrectly sets contract operations Follow on from #2530, assembling a transaction summary from a multicall is not building the operations correctly. Whilst it no longer throws, the second operation uses the call from the first operation. I had proposed a solution us...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: Assembling a transaction summary using multicall incorrectly sets contract operations", "scope_files": [ ".changeset/angry-donuts-enter.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/angry-donuts-enter.md" ], "solution_diff": "diff --git a/.changeset/angry-donuts-enter.md b/.changeset/angry-donuts-enter.md\nnew file mode 100644\nindex 00000000000..1f3ba4a5ee2\n--- /dev/null\n+++ b/.changeset/angry-donuts-enter.md\n@@ -0,0 ...
[]
diff --git a/.changeset/angry-donuts-enter.md b/.changeset/angry-donuts-enter.md new file mode 100644 index 00000000000..1f3ba4a5ee2 --- /dev/null +++ b/.changeset/angry-donuts-enter.md @@ -0,0 +1,5 @@ +--- +"@fuel-ts/account": patch +--- + +fix: contract operation summary for multi-calls diff --git a/packages/account/...
4
6
FuelLabs/fuels-ts#3893
FuelLabs/fuels-ts
3,893
52dfa5b02735a507dea611f40ed369cdd97ea6c9
92abba9522097fdcc48c5ba2bacfcc1446dfc242
ci(release): `v0.101.1` @ `master` # Summary In this release, we: - Made `Account.signTransaction` returns `TransactionRequest` or `string` # Chores - [#3895](https://github.com/FuelLabs/fuels-ts/pull/3895) - Made `Account.signTransaction` returns `TransactionRequest`, by [@Torres-ssf](https://github.com/Torres-ssf)
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: ci(release): `v0.101.1` @ `master`", "scope_files": [ ".changeset/good-horses-speak.md", ".changeset/slow-lands-shave.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `inte...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/good-horses-speak.md", ".changeset/slow-lands-shave.md" ], "solution_diff": "diff --git a/.changeset/good-horses-speak.md b/.changeset/good-horses-speak.md\ndeleted file mode 100644\nindex 8773ae16bfa..00000000000\n--- a/.changeset/good-...
[]
diff --git a/.changeset/good-horses-speak.md b/.changeset/good-horses-speak.md deleted file mode 100644 index 8773ae16bfa..00000000000 --- a/.changeset/good-horses-speak.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@fuel-ts/account": patch ---- - -chore: made `Account.signTransaction` returns `TransactionRequest` diff --git...
23
47
FuelLabs/fuels-ts#3895
FuelLabs/fuels-ts
3,895
67b3c80db53e5f2c73e52212811656b71f2509d0
154d85b54acdb9e902cc6432882723d7983136aa
Make Connectors `signTransaction` Method Return `TransactionRequest` We need to update the `signTransaction` method in the [Connector](https://github.com/FuelLabs/fuels-ts/blob/67b3c80db53e5f2c73e52212811656b71f2509d0/packages/account/src/connectors/fuel-connector.ts#L21) interface to return a `TransactionRequest`. A...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: Make Connectors `signTransaction` Method Return `TransactionRequest`", "scope_files": [ ".changeset/good-horses-speak.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `packages/a...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/good-horses-speak.md" ], "solution_diff": "diff --git a/.changeset/good-horses-speak.md b/.changeset/good-horses-speak.md\nnew file mode 100644\nindex 00000000000..8773ae16bfa\n--- /dev/null\n+++ b/.changeset/good-horses-speak.md\n@@ -0,0 +1,5...
[]
diff --git a/.changeset/good-horses-speak.md b/.changeset/good-horses-speak.md new file mode 100644 index 00000000000..8773ae16bfa --- /dev/null +++ b/.changeset/good-horses-speak.md @@ -0,0 +1,5 @@ +--- +"@fuel-ts/account": patch +--- + +chore: made `Account.signTransaction` returns `TransactionRequest` diff --git a/p...
5
5
FuelLabs/fuels-ts#3892
FuelLabs/fuels-ts
3,892
4ceb8984097cda8e87fb36236b594d86baed8a80
7ef01235aaa9bebf36df8a4b79996fa8229e4b72
chore: update CODEOWNERS file # Checklist - [x] All **changes** are **covered** by **tests** (or not applicable) - [x] All **changes** are **documented** (or not applicable) - [x] I **reviewed** the **entire PR** myself (preferably, on GH UI) - [x] I **described** all **Breaking Changes** (or there's none)
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: chore: update CODEOWNERS file", "scope_files": [ ".changeset/slow-lands-shave.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/` needed for: chore: update CODEOWNERS fil...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/slow-lands-shave.md" ], "solution_diff": "diff --git a/.changeset/slow-lands-shave.md b/.changeset/slow-lands-shave.md\nnew file mode 100644\nindex 00000000000..1243c1c670f\n--- /dev/null\n+++ b/.changeset/slow-lands-shave.md\n@@ -0,0 +1,4 @@\...
[]
diff --git a/.changeset/slow-lands-shave.md b/.changeset/slow-lands-shave.md new file mode 100644 index 00000000000..1243c1c670f --- /dev/null +++ b/.changeset/slow-lands-shave.md @@ -0,0 +1,4 @@ +--- +--- + +chore: update CODEOWNERS file diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 231305310b0..3fed9e1b8...
2
2
FuelLabs/fuels-ts#3884
FuelLabs/fuels-ts
3,884
68df54a2da76ff7fd5a3d058651d8af1caec961e
03ba4dde988181f86023c97c5118fbdb2acdc261
ci(release): `v0.101.0` @ `master` # Summary In this release, we: - Added method `setData` to `Predicate` class - Added support for on-the-fly modifications to `TransactionRequest` when using `InvocationScope` - Made `provider.assembleTx()` to consider `reserveGas` when setting TX `gasLimit` - Enforced Predicate's `...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: ci(release): `v0.101.0` @ `master`", "scope_files": [ ".changeset/bumpy-states-do.md", ".changeset/curvy-coats-laugh.md", ".changeset/eighty-lies-end.md", ".changeset/huge-stars-attend.md", ...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/bumpy-states-do.md", ".changeset/curvy-coats-laugh.md", ".changeset/eighty-lies-end.md", ".changeset/huge-stars-attend.md", ".changeset/loud-bags-deny.md", ".changeset/rare-kids-grab.md" ], "solution_diff": "diff ...
[]
diff --git a/.changeset/bumpy-states-do.md b/.changeset/bumpy-states-do.md deleted file mode 100644 index 0ee2b530e91..00000000000 --- a/.changeset/bumpy-states-do.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@fuel-ts/program": minor ---- - -chore!: remove `BaseInvocationScope.getTransactionId()` diff --git a/.changeset/cur...
23
51
FuelLabs/fuels-ts#3864
FuelLabs/fuels-ts
3,864
e91eb6c892529ced9f660447a041e2ef5ed77ba5
ff5bc73e958cbfc0bced31fc9e342305d1a1a19e
Remove `BaseInvocationScope.getTransactionId` We have a [getTransactionId](https://github.com/FuelLabs/fuels-ts/blob/0fb6fa8e7d964e9c56eaa5e5554fde660f438bf4/packages/program/src/functions/base-invocation-scope.ts#L475) method on the `BaseInvocationScope`. It is very unlikely that the transaction ID that this method o...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: Remove `BaseInvocationScope.getTransactionId`", "scope_files": [ ".changeset/bumpy-states-do.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `apps/docs/src/guide/scripts/` neede...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/bumpy-states-do.md" ], "solution_diff": "diff --git a/.changeset/bumpy-states-do.md b/.changeset/bumpy-states-do.md\nnew file mode 100644\nindex 00000000000..0ee2b530e91\n--- /dev/null\n+++ b/.changeset/bumpy-states-do.md\n@@ -0,0 +1,5 @@\n+--...
[]
diff --git a/.changeset/bumpy-states-do.md b/.changeset/bumpy-states-do.md new file mode 100644 index 00000000000..0ee2b530e91 --- /dev/null +++ b/.changeset/bumpy-states-do.md @@ -0,0 +1,5 @@ +--- +"@fuel-ts/program": minor +--- + +chore!: remove `BaseInvocationScope.getTransactionId()` diff --git a/apps/docs/src/guid...
4
4
FuelLabs/fuels-ts#3875
FuelLabs/fuels-ts
3,875
4cbd72c1373e2cf2eb29288c65b56bf4e35a045e
28af88a4cdf73a75d35c04e9ac26888b59eb4d79
Allow Custom Modifications On Transaction Request When Using `InvocationScope` During the implementation of [assembleTx](https://github.com/FuelLabs/fuels-ts/pull/3747), we had to roll back the changes introduced in [#3773](https://github.com/FuelLabs/fuels-ts/pull/3773). The reverted changes allowed users to manuall...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: Allow Custom Modifications On Transaction Request When Using `InvocationScope`", "scope_files": [ ".changeset/huge-stars-attend.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/huge-stars-attend.md" ], "solution_diff": "diff --git a/.changeset/huge-stars-attend.md b/.changeset/huge-stars-attend.md\nnew file mode 100644\nindex 00000000000..d07df14fb0d\n--- /dev/null\n+++ b/.changeset/huge-stars-attend.md\n@@ -0,0 +1,6...
[ { "subtask_id": "s3", "comment": "```suggestion\r\nFor instance, imagine a liquidity pool contract where users can deposit a specific asset to receive some form of benefit. To enhance the experience and make it more attractive, one could use a predicate to cover the transaction fees. This way, users only ne...
diff --git a/.changeset/huge-stars-attend.md b/.changeset/huge-stars-attend.md new file mode 100644 index 00000000000..d07df14fb0d --- /dev/null +++ b/.changeset/huge-stars-attend.md @@ -0,0 +1,6 @@ +--- +"@fuel-ts/account": patch +"@fuel-ts/program": patch +--- + +feat: support TX customization at BaseInvocationScope ...
17
21
FuelLabs/fuels-ts#3886
FuelLabs/fuels-ts
3,886
842e0f392c6f349b051fefa6ffd8684390900cb5
4bf3f1fdc55cf6c2056714c286eef02a53025dd6
Better error messages for predicate setData The current encoding error messages were weak on details and should be improved. > [!NOTE] > - Incoming from https://github.com/FuelLabs/fuels-ts/discussions/1545 Typegen'd `PredicateData` must be mandatory when predicate has required arguments Consider the following p...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: Better error messages for predicate setData", "scope_files": [ ".changeset/loud-bags-deny.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `apps/create-fuels-counter-guide/src/co...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/loud-bags-deny.md" ], "solution_diff": "diff --git a/.changeset/loud-bags-deny.md b/.changeset/loud-bags-deny.md\nnew file mode 100644\nindex 00000000000..d126cfe917f\n--- /dev/null\n+++ b/.changeset/loud-bags-deny.md\n@@ -0,0 +1,5 @@\n+---\n+...
[]
diff --git a/.changeset/loud-bags-deny.md b/.changeset/loud-bags-deny.md new file mode 100644 index 00000000000..d126cfe917f --- /dev/null +++ b/.changeset/loud-bags-deny.md @@ -0,0 +1,5 @@ +--- +"@fuel-ts/account": minor +--- + +fix!: enforce `predicateData` when predicate has arguments diff --git a/apps/create-fuels-...
8
10
FuelLabs/fuels-ts#3887
FuelLabs/fuels-ts
3,887
388ad982771a06e73334275c2c96eed8402057d9
eae817ef4ded37f7122a2a8bf25b5d2d65913916
`waitForPreConfirmation` Does Not Terminate Subscription Immediately When using `transactionResponse.waitForPreConfirmation`, the TS SDK listens for subscription updates—either via `statusChange` or `submitAndAwait`—until the transaction reaches one of the `preconfirmation` statuses: `PreconfirmationSuccess` or `Preco...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: `waitForPreConfirmation` Does Not Terminate Subscription Immediately", "scope_files": [ ".changeset/rare-kids-grab.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `packages/acco...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/rare-kids-grab.md" ], "solution_diff": "diff --git a/.changeset/rare-kids-grab.md b/.changeset/rare-kids-grab.md\nnew file mode 100644\nindex 00000000000..c0f63450039\n--- /dev/null\n+++ b/.changeset/rare-kids-grab.md\n@@ -0,0 +1,5 @@\n+---\n+...
[]
diff --git a/.changeset/rare-kids-grab.md b/.changeset/rare-kids-grab.md new file mode 100644 index 00000000000..c0f63450039 --- /dev/null +++ b/.changeset/rare-kids-grab.md @@ -0,0 +1,5 @@ +--- +"@fuel-ts/account": patch +--- + +fix: close subscription after `Preconfirmation` status when applicable diff --git a/packag...
3
3
FuelLabs/fuels-ts#3885
FuelLabs/fuels-ts
3,885
8889cd7950256ab2d810483c6ea2a0c788490181
e4747b811731aae2858f5b65bc041b8c9d451244
Reintroduction `setData` for the Predicate # Summary We previously had a method to `setData` on a predicate; however, this was removed. We should reintroduce this method to update the predicate data. It should also validate the data that is being passed, and an error should be thrown early. feat: add `Predicate` me...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: Reintroduction `setData` for the Predicate", "scope_files": [ ".changeset/curvy-coats-laugh.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `apps/docs/src/guide/predicates/` nee...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/curvy-coats-laugh.md" ], "solution_diff": "diff --git a/.changeset/curvy-coats-laugh.md b/.changeset/curvy-coats-laugh.md\nnew file mode 100644\nindex 00000000000..e9d35b2b933\n--- /dev/null\n+++ b/.changeset/curvy-coats-laugh.md\n@@ -0,0 +1,5...
[]
diff --git a/.changeset/curvy-coats-laugh.md b/.changeset/curvy-coats-laugh.md new file mode 100644 index 00000000000..e9d35b2b933 --- /dev/null +++ b/.changeset/curvy-coats-laugh.md @@ -0,0 +1,5 @@ +--- +"@fuel-ts/account": patch +--- + +feat: add `Predicate` method `setData` diff --git a/apps/docs/src/guide/predicate...
5
7
FuelLabs/fuels-ts#3883
FuelLabs/fuels-ts
3,883
f778fe4298aa1a7d7fc8e80624884d01ca7307ba
0795d514dd87d3d788fc5dee57690312862af2e6
chore: fix flaky Vitest tests in browser environment # Checklist - [x] All **changes** are **covered** by **tests** (or not applicable) - [x] All **changes** are **documented** (or not applicable) - [x] I **reviewed** the **entire PR** myself (preferably, on GH UI) - [x] I **described** all **Breaking Changes** ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: chore: fix flaky Vitest tests in browser environment", "scope_files": [ "vitest.browser.config.mts" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.changeset/` needed for: chore: fix ...
[ { "subtask_id": "s1", "scope_files": [ "vitest.browser.config.mts" ], "solution_diff": "diff --git a/vitest.browser.config.mts b/vitest.browser.config.mts\nindex dae3178ddcc..2105491342d 100644\n--- a/vitest.browser.config.mts\n+++ b/vitest.browser.config.mts\n@@ -36,7 +36,17 @@ const config: ...
[]
diff --git a/.changeset/eighty-lies-end.md b/.changeset/eighty-lies-end.md new file mode 100644 index 00000000000..03a2355f099 --- /dev/null +++ b/.changeset/eighty-lies-end.md @@ -0,0 +1,4 @@ +--- +--- + +chore: fix flaky Vitest tests in browser environment diff --git a/packages/fuels/src/setup-launch-node-server.ts b...
3
3
FuelLabs/fuels-ts#3882
FuelLabs/fuels-ts
3,882
1b9e399c5503372604a9f08ce975e13b0ebbb110
6b39299053e7370fad96123be181e1cfe2023556
Remove `demo-react-cra` app `create-react-app` has been [sunset](https://react.dev/blog/2025/02/14/sunsetting-create-react-app) by the react team so there's no point in us keeping this app alive. We should also consider removing `demo-nextjs` and `demo-react-vite` because we already have the templates for nextjs and ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Remove `demo-react-cra` app", "scope_files": [ ".eslintignore", ".prettierignore", "pnpm-lock.yaml", "vitest.shared.config.mts" ] }, { "subtask_id": "s2", "goal": "Implement the chang...
[ { "subtask_id": "s1", "scope_files": [ ".eslintignore", ".prettierignore", "pnpm-lock.yaml", "vitest.shared.config.mts" ], "solution_diff": "diff --git a/.eslintignore b/.eslintignore\nindex b009b53e259..09e949c1cba 100644\n--- a/.eslintignore\n+++ b/.eslintignore\n@@ -9,7 +9...
[]
diff --git a/.changeset/config.json b/.changeset/config.json index ea7d2ddbcae..9bed09ca20c 100644 --- a/.changeset/config.json +++ b/.changeset/config.json @@ -11,7 +11,6 @@ "docs", "demo-fuels", "demo-bun-fuels", - "demo-react-cra", "demo-react-vite", "demo-nextjs", "demo-node-esm", d...
5
25
FuelLabs/fuels-ts#3880
FuelLabs/fuels-ts
3,880
303379c7eb329993455b4194ce4c181d16e40ee3
5ed2f415171b647718cfb8db10389e3920dc4b32
ci(release): `v0.100.6` @ `master` # Summary In this release, we: - Made connector `sendTransaction` return `TransactionResponse` instead `TransactionResponseJson` # Chores - [#3879](https://github.com/FuelLabs/fuels-ts/pull/3879) - Made connector returns `TransactionResponse` type, by [@Torres-ssf](https://github.c...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: ci(release): `v0.100.6` @ `master`", "scope_files": [ ".changeset/cyan-oranges-smash.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `internal/check-imports/` needed for: ci(rel...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/cyan-oranges-smash.md" ], "solution_diff": "diff --git a/.changeset/cyan-oranges-smash.md b/.changeset/cyan-oranges-smash.md\ndeleted file mode 100644\nindex 1f40631fe35..00000000000\n--- a/.changeset/cyan-oranges-smash.md\n+++ /dev/null\n@@ -...
[]
diff --git a/.changeset/cyan-oranges-smash.md b/.changeset/cyan-oranges-smash.md deleted file mode 100644 index 1f40631fe35..00000000000 --- a/.changeset/cyan-oranges-smash.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@fuel-ts/account": patch ---- - -chore: made connector returns `TransactionResponse` type diff --git a/inte...
23
46
FuelLabs/fuels-ts#3879
FuelLabs/fuels-ts
3,879
7f094bbfa577d717977f88e33afae1afca7e17ba
66ad3c9d9e1743396d30d8f9689c20eb5ab6ec57
chore: made connector returns `TransactionResponse` type # Release notes In this release, we: - Made connector `sendTransaction` return `TransactionResponse` instead `TransactionResponseJson` # Checklist - [x] All **changes** are **covered** by **tests** (or not applicable) - [x] All **changes** are **doc...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: chore: made connector returns `TransactionResponse` type", "scope_files": [ ".changeset/cyan-oranges-smash.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `packages/account/src/...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/cyan-oranges-smash.md" ], "solution_diff": "diff --git a/.changeset/cyan-oranges-smash.md b/.changeset/cyan-oranges-smash.md\nnew file mode 100644\nindex 00000000000..1f40631fe35\n--- /dev/null\n+++ b/.changeset/cyan-oranges-smash.md\n@@ -0,0 ...
[]
diff --git a/.changeset/cyan-oranges-smash.md b/.changeset/cyan-oranges-smash.md new file mode 100644 index 00000000000..1f40631fe35 --- /dev/null +++ b/.changeset/cyan-oranges-smash.md @@ -0,0 +1,5 @@ +--- +"@fuel-ts/account": patch +--- + +chore: made connector returns `TransactionResponse` type diff --git a/packages...
6
7
FuelLabs/fuels-ts#3874
FuelLabs/fuels-ts
3,874
416e9e76d5f36e32b796ec26480a5daf33b9a87a
8452d3e52144082130dbba2fc2bd93898fa1ec6b
ci(release): `v0.100.5` @ `master` # Summary In this release, we: - Implemented helpers to serialize/deserialize `TransactionResponse` - Fixed error with missing `CALL` receipt in `getAllDecodedLogs` - Fixed `Provider` auto-refetch strategy # Features - [#3878](https://github.com/FuelLabs/fuels-ts/pull/3878) - Imple...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: ci(release): `v0.100.5` @ `master`", "scope_files": [ ".changeset/bright-steaks-wave.md", ".changeset/khaki-zoos-cough.md", ".changeset/nine-games-arrive.md" ] }, { "subtask_id": "s2", ...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/bright-steaks-wave.md", ".changeset/khaki-zoos-cough.md", ".changeset/nine-games-arrive.md" ], "solution_diff": "diff --git a/.changeset/bright-steaks-wave.md b/.changeset/bright-steaks-wave.md\ndeleted file mode 100644\nindex 6aed...
[]
diff --git a/.changeset/bright-steaks-wave.md b/.changeset/bright-steaks-wave.md deleted file mode 100644 index 6aed675dfc2..00000000000 --- a/.changeset/bright-steaks-wave.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@fuel-ts/account": patch ---- - -fix: ensure contract call receipt exists when decoding logs diff --git a/....
23
48
FuelLabs/fuels-ts#3878
FuelLabs/fuels-ts
3,878
0a8b276e74f3ba26f5151cbcb562c37633973ada
dca89618a1583e460e4e756c39cdf0c08b93ed81
Implement method to serialize/deserialize `TransactionResponse` We must implement two other methods to serialize and deserialize a `TransactionResponse` instance to exchange it between the SDK vs. Connectors/Wallet via JSON RPC. This is necessary for the conclusion of: - https://github.com/FuelLabs/fuel-connectors/iss...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: Implement method to serialize/deserialize `TransactionResponse`", "scope_files": [ ".changeset/nine-games-arrive.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `packages/accoun...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/nine-games-arrive.md" ], "solution_diff": "diff --git a/.changeset/nine-games-arrive.md b/.changeset/nine-games-arrive.md\nnew file mode 100644\nindex 00000000000..1e84841da9e\n--- /dev/null\n+++ b/.changeset/nine-games-arrive.md\n@@ -0,0 +1,5...
[]
diff --git a/.changeset/nine-games-arrive.md b/.changeset/nine-games-arrive.md new file mode 100644 index 00000000000..1e84841da9e --- /dev/null +++ b/.changeset/nine-games-arrive.md @@ -0,0 +1,5 @@ +--- +"@fuel-ts/account": patch +--- + +feat: implement methods to serialize/deserialize `TransactionResponse` diff --git...
7
9
FuelLabs/fuels-ts#3869
FuelLabs/fuels-ts
3,869
444b80eaec148961f1317479d0b35f3dbef7fcc8
caf95048b0d07a5478e35991431aff68943a7c8c
Provider re-requesting chain + node config unnecessarily # Summary We have logic to re-fetch the chain + node info, given the consensus parameters change (indicating a `fuel-core` update): https://github.com/FuelLabs/fuels-ts/blob/3af8692471a6bfd865448cdcd51b8536dcbf9a40/packages/account/src/providers/provider.ts#L1...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.changeset/` needed for: Provider re-requesting chain + node config unnecessarily", "scope_files": [ ".changeset/khaki-zoos-cough.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `packages/account/src/pr...
[ { "subtask_id": "s1", "scope_files": [ ".changeset/khaki-zoos-cough.md" ], "solution_diff": "diff --git a/.changeset/khaki-zoos-cough.md b/.changeset/khaki-zoos-cough.md\nnew file mode 100644\nindex 00000000000..b3a5dfa4291\n--- /dev/null\n+++ b/.changeset/khaki-zoos-cough.md\n@@ -0,0 +1,5 @@\...
[]
diff --git a/.changeset/khaki-zoos-cough.md b/.changeset/khaki-zoos-cough.md new file mode 100644 index 00000000000..b3a5dfa4291 --- /dev/null +++ b/.changeset/khaki-zoos-cough.md @@ -0,0 +1,5 @@ +--- +"@fuel-ts/account": patch +--- + +fix: provider auto-refetch diff --git a/packages/account/src/providers/operations.gr...
4
6
FuelLabs/sway#7653
FuelLabs/sway
7,653
baa7a253690c0ebde40222c8d5ea550ded9dd395
1bf4b0b1cb438fa64439bc328084309ca28206c0
Improve `storage_benchmarks` tooling ## Description This PR reworks how storage benchmark results are collected and compared. Results are no longer accumulated in RESULTS.md; instead, each run saves its output to a timestamped file in the `perf_out` folder, and diffs are computed between any two such files. Benchma...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Improve `storage_benchmarks` tooling", "scope_files": [ "justfile" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/` ...
[ { "subtask_id": "s1", "scope_files": [ "justfile" ], "solution_diff": "diff --git a/justfile b/justfile\nindex a19867aec25..6eaf8248f8b 100644\n--- a/justfile\n+++ b/justfile\n@@ -58,10 +58,16 @@ perf-in-lang filter='':\n ./test/src/in_language_tests/run_in_language_tests.sh --release {{fi...
[ { "subtask_id": "s2", "comment": "### Perf diff output name collision\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`perf_diff.sh` names its CSV and Markdown outputs using only the ten-digit timestamps parsed from the two input filenames. Any two comparisons that share the same before/after timestam...
diff --git a/justfile b/justfile index a19867aec25..6eaf8248f8b 100644 --- a/justfile +++ b/justfile @@ -58,10 +58,16 @@ perf-in-lang filter='': ./test/src/in_language_tests/run_in_language_tests.sh --release {{filter}} | tee /dev/stderr | ./scripts/perf/extract-gas-usages.sh > "$outfile" echo "Gas usages wri...
3
9
FuelLabs/sway#7654
FuelLabs/sway
7,654
65d0272fffd7e4cf201755499e286e09c20028bb
c044fa73051a35d59d72daa22c57c8092e5397bd
IR tests snapshots ## Description This PR is a necessary change for https://github.com/FuelLabs/sway/pull/7646. Some IR tests have a bug: their harness is expecting some passes to return `modified = true` even when the pass is not modifying anything. To make sure that #7646 is NOT changing the optimisation itsel...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: IR tests snapshots", "scope_files": [ "Cargo.lock", "justfile" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `sway-ir/` needed for: IR tests snapshots", "scope_files": [ ...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock", "justfile" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex 47633dd5ecd..c542d09a12f 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -7686,6 +7686,7 @@ dependencies = [\n \"downcast-rs\",\n \"filecheck\",\n \"indexmap...
[ { "subtask_id": "s3", "comment": "### Snapshot failures silently ignored\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\n`insta::assert_snapshot!` runs inside `catch_unwind` and the result is discarded, so a snapshot mismatch no longer fails the test. Regression coverage from the new `.ir.snap` files is...
diff --git a/Cargo.lock b/Cargo.lock index 47633dd5ecd..c542d09a12f 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -7686,6 +7686,7 @@ dependencies = [ "downcast-rs", "filecheck", "indexmap 2.14.0", + "insta", "itertools 0.13.0", "once_cell", "peg", @@ -7697,6 +7698,7 @@ dependencies = [ "sway-ir-macros", "...
21
89
FuelLabs/sway#7652
FuelLabs/sway
7,652
e6c1979e32fe73b005afc3bd1ba7f12dd7be4c15
64edabd7ff936527518251886a056c0d7a33a497
Fix `forc-fmt` issues with displaced comments In the `StorageVec` implementation given in #7649 `forc-fmt` displaced some of the comments. The formatting looks weird, but it was left in the PR to satisfy the `forc-fmt-check-sway-lib-std` CI step. Here is the diff that shows displaced formatting: ``` diff --git a/swa...
[ { "subtask_id": "s1", "goal": "Implement the changes under `sway-lib-std/src/storage/` needed for: Fix `forc-fmt` issues with displaced comments", "scope_files": [ "sway-lib-std/src/storage/storage_vec.sw" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `swayfmt/src...
[ { "subtask_id": "s1", "scope_files": [ "sway-lib-std/src/storage/storage_vec.sw" ], "solution_diff": "diff --git a/sway-lib-std/src/storage/storage_vec.sw b/sway-lib-std/src/storage/storage_vec.sw\nindex 32cea254387..26c697b3386 100644\n--- a/sway-lib-std/src/storage/storage_vec.sw\n+++ b/sway...
[]
diff --git a/sway-lib-std/src/storage/storage_vec.sw b/sway-lib-std/src/storage/storage_vec.sw index 32cea254387..26c697b3386 100644 --- a/sway-lib-std/src/storage/storage_vec.sw +++ b/sway-lib-std/src/storage/storage_vec.sw @@ -1351,7 +1351,9 @@ impl<V> StorageKey<StorageVec<V>> { // requires the offset t...
3
3
FuelLabs/sway#7649
FuelLabs/sway
7,649
ac933ff4f16f0e726b099752806b503ad3836627
56b5d54eb0a47fbf345081f8ea74739eff875c92
Implement chunk-based dynamic storage `StorageVec` ## Description This PR implements a chunk-based dynamic storage `StorageVec<V>`: - vec content is stored in consecutive dynamic storage slots each holding at most `CHUNK_MAX_SIZE` bytes of element data. - all slots hold the same maximum number of elements: `CHUNK...
[ { "subtask_id": "s1", "goal": "Implement the changes under `sway-lib-std/src/storage/` needed for: Implement chunk-based dynamic storage `StorageVec`", "scope_files": [ "sway-lib-std/src/storage/storage_vec.sw" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/s...
[ { "subtask_id": "s1", "scope_files": [ "sway-lib-std/src/storage/storage_vec.sw" ], "solution_diff": "diff --git a/sway-lib-std/src/storage/storage_vec.sw b/sway-lib-std/src/storage/storage_vec.sw\nindex 369b7de24dc..32cea254387 100644\n--- a/sway-lib-std/src/storage/storage_vec.sw\n+++ b/sway...
[ { "subtask_id": "s1", "comment": "### Debug TODO comments left in\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nSeveral new `const SIZE_OF_V` lines in `remove`, `insert`, `store_vec`, and `load_vec` carry inline `TODO-IG!: Report this bug.` notes. These read as temporary author debugging markers, not A...
diff --git a/sway-lib-std/src/storage/storage_vec.sw b/sway-lib-std/src/storage/storage_vec.sw index 369b7de24dc..32cea254387 100644 --- a/sway-lib-std/src/storage/storage_vec.sw +++ b/sway-lib-std/src/storage/storage_vec.sw @@ -65,6 +65,11 @@ pub struct StorageVec<V> {} /// - `StorageVec<StorageMap<u64, b256>>` ///...
15
17
FuelLabs/sway#7636
FuelLabs/sway
7,636
cf225bed222b6bc8849cfa7bcfdb9d2a6ae7aac5
7575fe5b2b56f1d8bdc4c5283324d25c90f495da
Fix redundant ops ## Description We have been considering any `NOOP`, and others, as redundant, but in reality they are only redundant if their const def registers are not read by the immediate op. This PR takes this into consideration. ## Checklist - [ ] I have linked to any relevant issues. - [x] I have...
[ { "subtask_id": "s1", "goal": "Implement the changes under `sway-core/src/asm_generation/fuel/optimizations/` needed for: Fix redundant ops", "scope_files": [ "sway-core/src/asm_generation/fuel/optimizations/constant_propagate.rs", "sway-core/src/asm_generation/fuel/optimizations/misc.rs", ...
[ { "subtask_id": "s1", "scope_files": [ "sway-core/src/asm_generation/fuel/optimizations/constant_propagate.rs", "sway-core/src/asm_generation/fuel/optimizations/misc.rs", "sway-core/src/asm_generation/fuel/optimizations/mod.rs" ], "solution_diff": "diff --git a/sway-core/src/asm_ge...
[ { "subtask_id": "s1", "comment": "Nitpick. Nested `if`s with two `else`s looks like a lot of code... \n```suggestion\n let remove = remove && ops.peek().map(|next_op| op.def_const_registers().intersection(&next_op.use_registers()).count()\n == 0).unwrap_or(true);\n```", "revised_diff": "diff ...
diff --git a/sway-core/src/asm_generation/fuel/optimizations/constant_propagate.rs b/sway-core/src/asm_generation/fuel/optimizations/constant_propagate.rs index 90ecbdb9768..41ddfe8191f 100644 --- a/sway-core/src/asm_generation/fuel/optimizations/constant_propagate.rs +++ b/sway-core/src/asm_generation/fuel/optimizatio...
2
5
FuelLabs/sway#7629
FuelLabs/sway
7,629
b556c08b9756a84623c9171ec4c32e72e3970053
8d92e1af0a83adeb50949f28568b38ed824b8b05
Consider optimizing `mcp dest src $zero` away At first look, it looks like `mcp dest src $zero` can be safely optimized away (with respect to cleaning the `$err`, of course). Even if `dest == src` FuelVM will not panic, so except for `$err` reset as in all opcodes, there should be no side-effects. We should take a c...
[ { "subtask_id": "s1", "goal": "Implement the changes under `sway-core/src/asm_generation/fuel/optimizations/` needed for: Consider optimizing `mcp dest src $zero` away", "scope_files": [ "sway-core/src/asm_generation/fuel/optimizations/misc.rs" ] }, { "subtask_id": "s2", "goal": "I...
[ { "subtask_id": "s1", "scope_files": [ "sway-core/src/asm_generation/fuel/optimizations/misc.rs" ], "solution_diff": "diff --git a/sway-core/src/asm_generation/fuel/optimizations/misc.rs b/sway-core/src/asm_generation/fuel/optimizations/misc.rs\nindex 7fbff419eab..9e59fa39a7c 100644\n--- a/swa...
[ { "subtask_id": "s3", "comment": "To get address semantics for the pointers passed to `asm`, we need to take addresses, otherwise it is interpreted as `mcp` from the absolute address 42 to absolute address 0.\n```suggestion\n asm(dst_ptr: __addr_of(dst), src_ptr: __addr_of(src), zero: 0u64) {\n```", ...
diff --git a/sway-core/src/asm_generation/fuel/optimizations/misc.rs b/sway-core/src/asm_generation/fuel/optimizations/misc.rs index 7fbff419eab..9e59fa39a7c 100644 --- a/sway-core/src/asm_generation/fuel/optimizations/misc.rs +++ b/sway-core/src/asm_generation/fuel/optimizations/misc.rs @@ -1,6 +1,8 @@ use super::sup...
3
3
FuelLabs/sway#7635
FuelLabs/sway
7,635
aa2e3b1d2ea6498cc891ea29d004f96790a0991e
88767d10c466f783b8bdb040334a16dc87290b44
Optimize execution speed of `in_language` tests ## Description This PR adds optional regex-based filtering to in-language test runs so CI only executes relevant projects for experimental feature-specific variants. Addresses first part of the #7617. ## Checklist - [x] I have linked to any relevant issues. ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: Optimize execution speed of `in_language` tests", "scope_files": [ ".github/workflows/ci.yml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/src/in_language_tests/` ne...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/ci.yml" ], "solution_diff": "diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml\nindex 94c9154ad52..3aa6b53f508 100644\n--- a/.github/workflows/ci.yml\n+++ b/.github/workflows/ci.yml\n@@ -545,17 +545,17 @@ jobs:\n - ...
[]
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 94c9154ad52..3aa6b53f508 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -545,17 +545,17 @@ jobs: - name: Run In Language Unit Tests (Release) run: ./test/src/in_language_tests/run_in_language_tests.sh --relea...
2
2
FuelLabs/sway#7634
FuelLabs/sway
7,634
54a2d0f9426a577c77e6b556317e34020800eb03
457ce1d19657e7504060ea9ee985a80fc2b4201e
Bump to 0.71.2 and fix crates.io publish ## Summary - Bump workspace and `sway-lib-std` to **0.71.2** after the failed v0.71.1 crates.io publish (only `sway-utils` 0.71.1 made it up; binaries for v0.71.1 are fine). - Fix publish breakage from **yanked `core2`** (RUSTSEC-2026-0105): `FuelLabs/publish-crates` runs `car...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Bump to 0.71.2 and fix crates.io publish", "scope_files": [ "Cargo.lock", "Cargo.toml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `forc-pkg/` needed for: Bump to 0.71.2 and f...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock", "Cargo.toml" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex 112609114f3..47633dd5ecd 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -109,13 +109,13 @@ dependencies = [\n \"derive_more 2.1.1\",\n \"foldhash\",\n \"h...
[ { "subtask_id": "s3", "comment": "### Local IPFS API call wrong\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\nLocal package fetch now issues an HTTP GET to `/api/v0/cat`, but Kubo’s RPC API expects POST and the previous client used `/api/v0/get` for `/ipfs/{cid}` paths. Directory CIDs (typical registr...
diff --git a/Cargo.lock b/Cargo.lock index 112609114f3..47633dd5ecd 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -109,13 +109,13 @@ dependencies = [ "derive_more 2.1.1", "foldhash", "hashbrown 0.15.5", - "indexmap 2.13.1", + "indexmap 2.14.0", "itoa", "k256", "keccak-asm", "paste", "proptest", - "rand 0....
7
8
FuelLabs/sway#7632
FuelLabs/sway
7,632
f494ba0994ce511398a92b27c4220d299262c364
0597b73bd8e9d57bc4e25dc3b2b5d9195722c955
fix help link that needs compiler version ## Description Fix required attribute help link. ## Checklist - [ ] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and th...
[ { "subtask_id": "s1", "goal": "Implement the changes under `docs/book/src/advanced/` needed for: fix help link that needs compiler version", "scope_files": [ "docs/book/src/advanced/index.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `sway-error/src/` needed f...
[ { "subtask_id": "s1", "scope_files": [ "docs/book/src/advanced/index.md" ], "solution_diff": "diff --git a/docs/book/src/advanced/index.md b/docs/book/src/advanced/index.md\nindex 3d1795af288..207936b3f78 100644\n--- a/docs/book/src/advanced/index.md\n+++ b/docs/book/src/advanced/index.md\n@@ ...
[]
diff --git a/docs/book/src/advanced/index.md b/docs/book/src/advanced/index.md index 3d1795af288..207936b3f78 100644 --- a/docs/book/src/advanced/index.md +++ b/docs/book/src/advanced/index.md @@ -10,3 +10,4 @@ Advanced concepts. - [Generics and Trait Constraints](./generics_and_trait_constraints.md) - [Assembly](./a...
3
3
FuelLabs/sway#7631
FuelLabs/sway
7,631
b840704fe007503dd7a391a03ec976a599698f37
e3757f406e53bc2f1fc38a8fd944f062072dd30b
Bump to 0.71.1
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Bump to 0.71.1", "scope_files": [ "Cargo.lock", "Cargo.toml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `sway-lib-std/` needed for: Bump to 0.71.1", "scope_files": [ ...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock", "Cargo.toml" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex 2fb28ed7759..112609114f3 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -2505,7 +2505,7 @@ checksum = \"d9c4f5dac5e15c24eb999c26181a6ca40b39fe946cbe4c263c720...
[]
diff --git a/Cargo.lock b/Cargo.lock index 2fb28ed7759..112609114f3 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2505,7 +2505,7 @@ checksum = "d9c4f5dac5e15c24eb999c26181a6ca40b39fe946cbe4c263c7209467bc83af2" [[package]] name = "forc" -version = "0.71.0" +version = "0.71.1" dependencies = [ "annotate-snippets", ...
2
3
FuelLabs/sway#7575
FuelLabs/sway
7,575
9e8750e0f618b460b7e7c88af3b690f15ae9d12d
094041d5f9a37889918e867ae39e6addba61f3c4
Compiler attribute to guarantee that types are trivially encodable/decodable Contract functions can gain a lot of performance if their inputs are trivially decodable, but today there is no easy way for a developer to check if a type is "trivially decodable" or not. And there is not way to fail compilation if a type is...
[ { "subtask_id": "s1", "goal": "Implement the changes under `docs/book/` needed for: Compiler attribute to guarantee that types are trivially encodable/decodable", "scope_files": [ "docs/book/spell-check-custom-words.txt" ] }, { "subtask_id": "s2", "goal": "Implement the changes und...
[ { "subtask_id": "s1", "scope_files": [ "docs/book/spell-check-custom-words.txt" ], "solution_diff": "diff --git a/docs/book/spell-check-custom-words.txt b/docs/book/spell-check-custom-words.txt\nindex a45f2308622..eb828999754 100644\n--- a/docs/book/spell-check-custom-words.txt\n+++ b/docs/boo...
[ { "subtask_id": "s5", "comment": "### Debug statement accidentally committed to production\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nA `dbg!` macro call printing `decls_to_check` was left in the production code path of `compile_to_asm`. This runs on every compilation, printing debug output to st...
diff --git a/docs/book/spell-check-custom-words.txt b/docs/book/spell-check-custom-words.txt index a45f2308622..eb828999754 100644 --- a/docs/book/spell-check-custom-words.txt +++ b/docs/book/spell-check-custom-words.txt @@ -275,3 +275,9 @@ Preload preloads Preloads VM's +Decodable +Encodable +callee +decodable +enc...
37
58
FuelLabs/sway#7626
FuelLabs/sway
7,626
ce310eb1b5abad4a885af393559834afe7f18716
19e8fbb7f2bae5aa0733fd5c7e0b0f4be31e504a
Add comprehensive in-language tests for all storage types ## Description This PR adds in-language tests for all all storage types, except for `StorageKey` and `StorageVec`, which are added in #7614. Existing SDK harness tests that were testing the same functionality are deleted. This is aligned with the decision...
[ { "subtask_id": "s1", "goal": "Implement the changes under `test/src/in_language_tests/test_programs/storage_bytes_contract_tests/` needed for: Add comprehensive in-language tests for all storage types", "scope_files": [ "test/src/in_language_tests/test_programs/storage_bytes_contract_tests/Forc.t...
[ { "subtask_id": "s1", "scope_files": [ "test/src/in_language_tests/test_programs/storage_bytes_contract_tests/Forc.toml" ], "solution_diff": "diff --git a/test/src/sdk-harness/test_projects/storage_string/Forc.toml b/test/src/in_language_tests/test_programs/storage_bytes_contract_tests/Forc.to...
[]
diff --git a/test/src/sdk-harness/test_projects/storage_string/Forc.toml b/test/src/in_language_tests/test_programs/storage_bytes_contract_tests/Forc.toml similarity index 80% rename from test/src/sdk-harness/test_projects/storage_string/Forc.toml rename to test/src/in_language_tests/test_programs/storage_bytes_contra...
15
20
FuelLabs/sway#7582
FuelLabs/sway
7,582
c1600d30409941616330b0dff70fec14435da9a3
2a991efd623ecab749d2a36791ec55e3dfafeb62
Optimize encoding and decoding of `Vec<T>` when `T` is trivial ## Description This PR optimizes the encoding and decoding of `std::vec::Vec::<T>` when `T` is a trivially encodable and decodable type. In that case, we don't have encode each element individually, but just encode the vector's length and mem-copy its c...
[ { "subtask_id": "s1", "goal": "Implement the changes under `sway-core/src/ir_generation/` needed for: Optimize encoding and decoding of `Vec<T>` when `T` is trivial", "scope_files": [ "sway-core/src/ir_generation/function.rs" ] }, { "subtask_id": "s2", "goal": "Implement the change...
[ { "subtask_id": "s1", "scope_files": [ "sway-core/src/ir_generation/function.rs" ], "solution_diff": "diff --git a/sway-core/src/ir_generation/function.rs b/sway-core/src/ir_generation/function.rs\nindex 812d8fe0a82..2169d4aa07c 100644\n--- a/sway-core/src/ir_generation/function.rs\n+++ b/sway...
[ { "subtask_id": "s21", "comment": "### Test `vec_non_trivial` incorrectly tests trivial path instead\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `vec_non_trivial` test calls `create_vec_trivial(10)` and uses `Vec<u64>`, making it an exact duplicate of `vec_trivial`. It was clearly intended to ...
diff --git a/sway-core/src/ir_generation/function.rs b/sway-core/src/ir_generation/function.rs index 812d8fe0a82..2169d4aa07c 100644 --- a/sway-core/src/ir_generation/function.rs +++ b/sway-core/src/ir_generation/function.rs @@ -2056,534 +2056,7 @@ impl<'a> FnCompiler<'a> { Ok(TerminatorValue::new(buff...
25
35
FuelLabs/sway#7620
FuelLabs/sway
7,620
b0a91271a06042763b2f62a058141edcfa06cb5f
69ac773306a480b5013bc9fe53af650da8b54f04
Fix `Vec` with ZSTs ## Description Fix a bug on `Vec` on ZST. ## Checklist - [ ] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my...
[ { "subtask_id": "s1", "goal": "Implement the changes under `sway-core/src/ir_generation/` needed for: Fix `Vec` with ZSTs", "scope_files": [ "sway-core/src/ir_generation/function.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `sway-ir/src/` needed for: Fix `Vec...
[ { "subtask_id": "s1", "scope_files": [ "sway-core/src/ir_generation/function.rs" ], "solution_diff": "diff --git a/sway-core/src/ir_generation/function.rs b/sway-core/src/ir_generation/function.rs\nindex b3089c62be5..812d8fe0a82 100644\n--- a/sway-core/src/ir_generation/function.rs\n+++ b/sway...
[ { "subtask_id": "s5", "comment": "I think this is fine because this is a debug build.", "revised_diff": "diff --git a/test/src/e2e_vm_tests/test_programs/should_pass/language/intrinsics/dbg/stdout.snap b/test/src/e2e_vm_tests/test_programs/should_pass/language/intrinsics/dbg/stdout.snap\nindex faafb9f67...
diff --git a/sway-core/src/ir_generation/function.rs b/sway-core/src/ir_generation/function.rs index b3089c62be5..812d8fe0a82 100644 --- a/sway-core/src/ir_generation/function.rs +++ b/sway-core/src/ir_generation/function.rs @@ -4068,26 +4068,88 @@ impl<'a> FnCompiler<'a> { // Compile the struct expression. ...
8
14
FuelLabs/sway#7614
FuelLabs/sway
7,614
514ccec75cccc818254f09e0c284db2c78b2ec2a
ecc2c92ea28c187e76d47f70d6de0024c884c202
`StorageVec::insert()` does not work with nested storage types E.g., having: ```Sway storage { nested_vec: StorageVec<StorageVec<u64>> = StorageVec {}, } ``` and inserting: ``` storage.nested_vec.insert(0, StorageVec {}); storage.nested_vec.insert(0, StorageVec {}); ``` will revert at runtime at the sec...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: `StorageVec::insert()` does not work with nested storage types", "scope_files": [ "justfile" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflows/` needed for: `StorageVec...
[ { "subtask_id": "s1", "scope_files": [ "justfile" ], "solution_diff": "diff --git a/justfile b/justfile\nindex a17ec470a50..47785bc1de2 100644\n--- a/justfile\n+++ b/justfile\n@@ -53,7 +53,9 @@ perf-in-lang filter='':\n #!/usr/bin/env bash\n branch=$(git rev-parse --abbrev-ref HEAD 2>/...
[ { "subtask_id": "s29", "comment": "### Test verification uses wrong split point for expected sequence\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe expected sequence construction in `assert_insert_impl` uses `middle_index` (which is an index into the *vector* after front insertion) as a split point...
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 663f5c6d925..94c9154ad52 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -523,22 +523,39 @@ jobs: run: forc test --path sway-lib-std --experimental dynamic_storage - name: Run Std Unit Tests - ['dynamic_storag...
79
100
FuelLabs/sway#7622
FuelLabs/sway
7,622
c53e7e0cb9183f5ef09c14d4eba94ef4f7e284ce
14e106959414f2f34152f5f3a0b3626628140232
Either support or forbid `validate_abi/storage_slots` test options in `unit_tests_pass` tests Currently, it is allowed to have these options in `unit_test_pass` tests and even set them to true, but they are not checked in the test harness. They are checked only for `compiles` and `runs` tests. We should either forbid...
[ { "subtask_id": "s1", "goal": "Implement the changes under `sway-core/src/ir_generation/` needed for: Either support or forbid `validate_abi/storage_slots` test options in `unit_tests_pass` tests", "scope_files": [ "sway-core/src/ir_generation/storage.rs" ] }, { "subtask_id": "s2", ...
[ { "subtask_id": "s1", "scope_files": [ "sway-core/src/ir_generation/storage.rs" ], "solution_diff": "diff --git a/sway-core/src/ir_generation/storage.rs b/sway-core/src/ir_generation/storage.rs\nindex fb0f59751c8..65a35c9a489 100644\n--- a/sway-core/src/ir_generation/storage.rs\n+++ b/sway-cor...
[]
diff --git a/sway-core/src/ir_generation/storage.rs b/sway-core/src/ir_generation/storage.rs index fb0f59751c8..65a35c9a489 100644 --- a/sway-core/src/ir_generation/storage.rs +++ b/sway-core/src/ir_generation/storage.rs @@ -121,23 +121,25 @@ pub(super) fn add_to_b256(x: Bytes32, y: u64) -> Bytes32 { Bytes32::from...
36
100
FuelLabs/sway#7611
FuelLabs/sway
7,611
27f3d9977b5ff5fa0d77d2e3fc75f2710d4dde34
692b463220166cf7c1c070ed1866a98b7583efc5
Fix tuple codec helpers to avoid LSP stack overflows ## Summary I reproduced an LSP crash where opening and incrementally editing `fuel-o2-exports/contracts/order-book/src/main.sw` could abort the server and leave stale semantic highlighting behind in the client. Daniel pointed out that the generated tuple helpers i...
[ { "subtask_id": "s1", "goal": "Implement the changes under `sway-lib-std/` needed for: Fix tuple codec helpers to avoid LSP stack overflows", "scope_files": [ "sway-lib-std/generate.sh" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `sway-lib-std/src/` needed for: ...
[ { "subtask_id": "s1", "scope_files": [ "sway-lib-std/generate.sh" ], "solution_diff": "diff --git a/sway-lib-std/generate.sh b/sway-lib-std/generate.sh\nindex 16db557f65e..fa873c07087 100755\n--- a/sway-lib-std/generate.sh\n+++ b/sway-lib-std/generate.sh\n@@ -1,12 +1,24 @@\n #! /bin/bash\n \n+...
[]
diff --git a/sway-lib-std/generate.sh b/sway-lib-std/generate.sh index 16db557f65e..fa873c07087 100755 --- a/sway-lib-std/generate.sh +++ b/sway-lib-std/generate.sh @@ -1,12 +1,24 @@ #! /bin/bash +# Use GNU sed (`gsed` on macOS via `brew install gnu-sed`); BSD sed in-place +# semantics differ and break the substitut...
13
13
FuelLabs/sway#7608
FuelLabs/sway
7,608
3005dcbf538835975b217cf3b63f5183746ed1cc
78292cb6ebbad0b270ef56a98c718eee0c03d533
Increase test coverage for `dynamic_storage` ## Description This PR increases test coverage for `dynamic_storage` experimental feature, by reusing existing E2E storage tests and running them with the `dynamic_storage` feature enabled. Tests containing `StorageVec` are not included. This will be done in the PR th...
[ { "subtask_id": "s1", "goal": "Implement the changes under `test/src/e2e_vm_tests/test_programs/should_fail/const_eval_bad_struct/` needed for: Increase test coverage for `dynamic_storage`", "scope_files": [ "test/src/e2e_vm_tests/test_programs/should_fail/const_eval_bad_struct/test.dynamic_storag...
[ { "subtask_id": "s1", "scope_files": [ "test/src/e2e_vm_tests/test_programs/should_fail/const_eval_bad_struct/test.dynamic_storage.toml" ], "solution_diff": "diff --git a/test/src/e2e_vm_tests/test_programs/should_fail/const_eval_bad_struct/test.dynamic_storage.toml b/test/src/e2e_vm_tests/tes...
[ { "subtask_id": "s30", "comment": "### Redundant `experimental_new_encoding` field in test config\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `experimental_new_encoding = true` field on line 4 is redundant because `experimental = { new_encoding = true, dynamic_storage = true }` on line 2 already ...
diff --git a/test/src/e2e_vm_tests/test_programs/should_fail/const_eval_bad_struct/test.dynamic_storage.toml b/test/src/e2e_vm_tests/test_programs/should_fail/const_eval_bad_struct/test.dynamic_storage.toml new file mode 100644 index 00000000000..56c5b3a5516 --- /dev/null +++ b/test/src/e2e_vm_tests/test_programs/shou...
47
49
FuelLabs/sway#7601
FuelLabs/sway
7,601
fe31b4a85b3096812399fa1c319f14cf232892a5
3c8b892282de63c81d6dc24e3a0be2b13176f866
Reassignment to const generic array emits "Type is not indexable" error E.g., this code: ```sway fn const_generic_array<const N: u64>() -> [u8; N] { let mut res = [0u8; N]; res[0] = 1; res } ``` emits: ``` error: Type is not indexable --> const-generic-array-not-an-indexable-type/sway_const_generic_arr...
[ { "subtask_id": "s1", "goal": "Implement the changes under `sway-core/src/semantic_analysis/ast_node/expression/` needed for: Reassignment to const generic array emits \"Type is not indexable\" error", "scope_files": [ "sway-core/src/semantic_analysis/ast_node/expression/typed_expression.rs" ]...
[ { "subtask_id": "s1", "scope_files": [ "sway-core/src/semantic_analysis/ast_node/expression/typed_expression.rs" ], "solution_diff": "diff --git a/sway-core/src/semantic_analysis/ast_node/expression/typed_expression.rs b/sway-core/src/semantic_analysis/ast_node/expression/typed_expression.rs\n...
[ { "subtask_id": "s9", "comment": "### Swapped loop bounds in nested array test function\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nIn `simple_const_generic_nested_array_reassignment`, the loop bounds for `a` and `b` are swapped relative to the array dimensions. The type `[[u64; A]; B]` is an arra...
diff --git a/sway-core/src/semantic_analysis/ast_node/expression/typed_expression.rs b/sway-core/src/semantic_analysis/ast_node/expression/typed_expression.rs index 9ab3cc6921d..c6bb40ece71 100644 --- a/sway-core/src/semantic_analysis/ast_node/expression/typed_expression.rs +++ b/sway-core/src/semantic_analysis/ast_nod...
9
13
FuelLabs/sway#7598
FuelLabs/sway
7,598
e12e6118dee66417a41872ca2b743d279a28174a
4470322123dad3af6202bfe55d90ea81164eacd1
Fix issues found during testing of the `Iterator` implementation for `StorageVec` The tests written in #6821 fails for types `()`, `[u64;0]`, and the `EmptyStruct`. Using `()` causes an ICE: ``` error --> /.../sway/sway-lib-std/src/option.sw:191:15 | 189 | /// ``` 190 | pub fn unwrap(self) -> T...
[ { "subtask_id": "s1", "goal": "Implement the changes under `sway-core/src/ir_generation/` needed for: Fix issues found during testing of the `Iterator` implementation for `StorageVec`", "scope_files": [ "sway-core/src/ir_generation/function.rs", "sway-core/src/ir_generation/purity.rs", ...
[ { "subtask_id": "s1", "scope_files": [ "sway-core/src/ir_generation/function.rs", "sway-core/src/ir_generation/purity.rs", "sway-core/src/ir_generation/storage.rs" ], "solution_diff": "diff --git a/sway-core/src/ir_generation/function.rs b/sway-core/src/ir_generation/function.rs\ni...
[ { "subtask_id": "s10", "comment": "### Overly broad storage purity annotation on clear_slice_slot\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`clear_slice_slot` is annotated `#[storage(read, write)]` but only calls `__state_clear_slots`, which is a write-only operation. This unnecessarily forces c...
diff --git a/sway-core/src/ir_generation/function.rs b/sway-core/src/ir_generation/function.rs index f7658966e6f..b3089c62be5 100644 --- a/sway-core/src/ir_generation/function.rs +++ b/sway-core/src/ir_generation/function.rs @@ -796,7 +796,7 @@ impl<'a> FnCompiler<'a> { self.compile_storage_access( ...
73
84
FuelLabs/sway#7151
FuelLabs/sway
7,151
f9fcae93c14937700a61ec031e572d70a5ce41c0
5e898c6c00d31a811fefefc9dfe49a7dfa8e6c59
Optimize `crypto` module for bytecode size and gas usage ## Description This PR optimizes the `std::crypto` module for bytecode size and gas cost by using optimization techniques similar to those used in #7087, #7092, and #7096. The optimized public functions are listed in the below code snippet. **The bytecode ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `sway-lib-std/src/` needed for: Optimize `crypto` module for bytecode size and gas usage", "scope_files": [ "sway-lib-std/src/bytes.sw" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `sway-lib-std/src/crypt...
[ { "subtask_id": "s1", "scope_files": [ "sway-lib-std/src/bytes.sw" ], "solution_diff": "diff --git a/sway-lib-std/src/bytes.sw b/sway-lib-std/src/bytes.sw\nindex a2fb83c2d10..04bf122f320 100644\n--- a/sway-lib-std/src/bytes.sw\n+++ b/sway-lib-std/src/bytes.sw\n@@ -956,6 +956,41 @@ impl Bytes {...
[]
diff --git a/sway-lib-std/src/bytes.sw b/sway-lib-std/src/bytes.sw index a2fb83c2d10..04bf122f320 100644 --- a/sway-lib-std/src/bytes.sw +++ b/sway-lib-std/src/bytes.sw @@ -956,6 +956,41 @@ impl Bytes { index: 0, } } + + /// Returns true if all the bytes within the `Bytes` are zero. + /...
2
8
FuelLabs/sway#6853
FuelLabs/sway
6,853
9e1c320cead802983266e5b5fd9d55d7e40234a6
6ecef9652ba1658b9c2033d91a20f81084d44221
Bump to v0.66.6
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Bump to v0.66.6", "scope_files": [ "Cargo.lock", "Cargo.toml" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock", "Cargo.toml" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex c012ee3100a..6dab0cc2304 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -2662,7 +2662,7 @@ checksum = \"f81ec6369c545a7d40e4589b5597581fa1c441fe1cce96dd1de43...
[]
diff --git a/Cargo.lock b/Cargo.lock index c012ee3100a..6dab0cc2304 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2662,7 +2662,7 @@ checksum = "f81ec6369c545a7d40e4589b5597581fa1c441fe1cce96dd1de43159910a36a2" [[package]] name = "forc" -version = "0.66.5" +version = "0.66.6" dependencies = [ "annotate-snippets", ...
1
2
FuelLabs/sway#7385
FuelLabs/sway
7,385
4a44a36718e049cca3648483c1ac0bf965a59355
770e69e537d177d1d82e7692cca913c5b621d051
Trait coherence: disallow inherent impls on external types This improves the trait coherence checks for impl self case, and polishes a bit of the wording on the existing diagnostics. We now enforce package-level check in impl-self type checking, which means we now reject inherent impls for external nominal types (s...
[ { "subtask_id": "s1", "goal": "Implement the changes under `sway-core/src/semantic_analysis/ast_node/declaration/` needed for: Trait coherence: disallow inherent impls on external types", "scope_files": [ "sway-core/src/semantic_analysis/ast_node/declaration/impl_trait.rs" ] }, { "subt...
[ { "subtask_id": "s1", "scope_files": [ "sway-core/src/semantic_analysis/ast_node/declaration/impl_trait.rs" ], "solution_diff": "diff --git a/sway-core/src/semantic_analysis/ast_node/declaration/impl_trait.rs b/sway-core/src/semantic_analysis/ast_node/declaration/impl_trait.rs\nindex d1e8a6117...
[ { "subtask_id": "s1", "comment": "I thought that, as we discussed, this whitelisting wasn't actually necessary for licit usages of `impl StorageKey<SomeType>`", "revised_diff": "diff --git a/sway-core/src/semantic_analysis/ast_node/declaration/impl_trait.rs b/sway-core/src/semantic_analysis/ast_node/dec...
diff --git a/sway-core/src/semantic_analysis/ast_node/declaration/impl_trait.rs b/sway-core/src/semantic_analysis/ast_node/declaration/impl_trait.rs index d1e8a611791..bd66481df8c 100644 --- a/sway-core/src/semantic_analysis/ast_node/declaration/impl_trait.rs +++ b/sway-core/src/semantic_analysis/ast_node/declaration/i...
9
14
FuelLabs/sway#7597
FuelLabs/sway
7,597
fbb524c2dfc726636e321ada342060f51e17de19
b5e6a40b1fdda31e38456a3572b8f626d17539a9
`__smo` and `__log` intrinsics not correctly compiled and can cause ICE `__smo` and `__log` intrinsics return unit `()` but the returned value is not correctly compiled in the IR. Instead of having a const `()` as their return value they just return their underlaying IR instruction that does not return a value. E.g. ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `docs/book/` needed for: `__smo` and `__log` intrinsics not correctly compiled and can cause ICE", "scope_files": [ "docs/book/spell-check-custom-words.txt" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `d...
[ { "subtask_id": "s1", "scope_files": [ "docs/book/spell-check-custom-words.txt" ], "solution_diff": "diff --git a/docs/book/spell-check-custom-words.txt b/docs/book/spell-check-custom-words.txt\nindex 733ba3f73e7..a45f2308622 100644\n--- a/docs/book/spell-check-custom-words.txt\n+++ b/docs/boo...
[ { "subtask_id": "s7", "comment": "### `StateLoadWord` always gets two arguments breaking non-dynamic path\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`type_check_state_load_word` now always emits two arguments (`vec![key_exp, offset_exp]`) in the typed intrinsic, even when `dynamic_storage` is dis...
diff --git a/docs/book/spell-check-custom-words.txt b/docs/book/spell-check-custom-words.txt index 733ba3f73e7..a45f2308622 100644 --- a/docs/book/spell-check-custom-words.txt +++ b/docs/book/spell-check-custom-words.txt @@ -270,3 +270,8 @@ backtrace Backtrace backtracing Backtracing +preload +Preload +preloads +Pre...
38
71
FuelLabs/sway#7595
FuelLabs/sway
7,595
f9b815898a7db0e1cf775d62872a833fe5c87a4a
a871f09720d69cdb15106a526ac2493cbd687796
Implement dynamic storage opcodes in the compiler ## Description This PR is a step in implementing #7560. It adds compiler support for [dynamic storage opcodes](https://github.com/FuelLabs/fuel-specs/pull/640) by: - supporting all opcodes in `asm` blocks. - adding IR instructions for all opcodes. Note that the...
[ { "subtask_id": "s1", "goal": "Implement the changes under `forc-plugins/forc-debug/src/server/handlers/` needed for: Implement dynamic storage opcodes in the compiler", "scope_files": [ "forc-plugins/forc-debug/src/server/handlers/handle_variables.rs" ] }, { "subtask_id": "s2", "g...
[ { "subtask_id": "s1", "scope_files": [ "forc-plugins/forc-debug/src/server/handlers/handle_variables.rs" ], "solution_diff": "diff --git a/forc-plugins/forc-debug/src/server/handlers/handle_variables.rs b/forc-plugins/forc-debug/src/server/handlers/handle_variables.rs\nindex d056bbeb777..36075...
[ { "subtask_id": "s7", "comment": "### Inconsistent offset type check in state slot verification\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `verify_state_read_slot` method checks `offset` with `Type::is_uint` (accepts any unsigned integer width), while `verify_state_update_slot` checks the sem...
diff --git a/forc-plugins/forc-debug/src/server/handlers/handle_variables.rs b/forc-plugins/forc-debug/src/server/handlers/handle_variables.rs index d056bbeb777..36075512706 100644 --- a/forc-plugins/forc-debug/src/server/handlers/handle_variables.rs +++ b/forc-plugins/forc-debug/src/server/handlers/handle_variables.rs...
14
26
FuelLabs/sway#7594
FuelLabs/sway
7,594
011b75113331be21b5d3a1ca83f08dbf04654609
4c36f20bc9550e5cdf67efbc0326f6564cf8c33a
Bump to 0.71.0 ## Description This PR bumps the `std` and the crates in `sway` repository to v0.71.0. ## Checklist - [ ] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the refere...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Bump to 0.71.0", "scope_files": [ "Cargo.lock", "Cargo.toml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `sway-lib-std/` needed for: Bump to 0.71.0", "scope_files": [ ...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock", "Cargo.toml" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex ce852af8c96..2fb28ed7759 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -2505,7 +2505,7 @@ checksum = \"d9c4f5dac5e15c24eb999c26181a6ca40b39fe946cbe4c263c720...
[]
diff --git a/Cargo.lock b/Cargo.lock index ce852af8c96..2fb28ed7759 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2505,7 +2505,7 @@ checksum = "d9c4f5dac5e15c24eb999c26181a6ca40b39fe946cbe4c263c7209467bc83af2" [[package]] name = "forc" -version = "0.70.3" +version = "0.71.0" dependencies = [ "annotate-snippets", ...
2
3
FuelLabs/sway#7593
FuelLabs/sway
7,593
4382e71f35d8b7f7deed31fdace001dcb797118e
4264490fe63b8098254a223b489cd8fe6a5be9ea
Fix default gas costs and add perf diff scripts to `storage_benchmarks` ## Description This PR: - fixes inconsistent gas cost values across tools. All default gas costs are now obtained via `GasCostsSource::BuiltIn.provide_gas_costs()` method. - improves analyzing `storage_benchmarks` by: - printing histograms...
[ { "subtask_id": "s1", "goal": "Implement the changes under `forc-plugins/forc-debug/src/server/` needed for: Fix default gas costs and add perf diff scripts to `storage_benchmarks`", "scope_files": [ "forc-plugins/forc-debug/src/server/mod.rs" ] }, { "subtask_id": "s2", "goal": "Im...
[ { "subtask_id": "s1", "scope_files": [ "forc-plugins/forc-debug/src/server/mod.rs" ], "solution_diff": "diff --git a/forc-plugins/forc-debug/src/server/mod.rs b/forc-plugins/forc-debug/src/server/mod.rs\nindex 5b4f7faddda..e19e046c97a 100644\n--- a/forc-plugins/forc-debug/src/server/mod.rs\n++...
[ { "subtask_id": "s1", "comment": "### Unnecessary `unwrap()` and repeated deserialization in closure\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`GasCostsSource::BuiltIn.provide_gas_costs().unwrap()` is called inside a `filter_map` closure, introducing a panic point where every other call site use...
diff --git a/forc-plugins/forc-debug/src/server/mod.rs b/forc-plugins/forc-debug/src/server/mod.rs index 5b4f7faddda..e19e046c97a 100644 --- a/forc-plugins/forc-debug/src/server/mod.rs +++ b/forc-plugins/forc-debug/src/server/mod.rs @@ -20,9 +20,8 @@ use forc_pkg::{ use forc_test::{ execute::{DebugResult, TestExe...
4
11
FuelLabs/sway#7592
FuelLabs/sway
7,592
0507c2c9a65a147ef2026fda8ac52ba7223aca40
14da455eda533c4e7b7c1daeef9164a5b9f04a00
Const Generics This PR is the tracking-issue for the `const_generics` feature. For more details go to: https://github.com/FuelLabs/sway-rfcs/pull/42 - [x] Feature toggle (https://github.com/FuelLabs/sway/pull/6926) - [x] Parsing (https://github.com/FuelLabs/sway/pull/6926) - [x] `impl` trait for arrays (https://gith...
[ { "subtask_id": "s1", "goal": "Implement the changes under `docs/book/src/reference/` needed for: Const Generics", "scope_files": [ "docs/book/src/reference/experimental_features.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `docs/slides/` needed for: Const Ge...
[ { "subtask_id": "s1", "scope_files": [ "docs/book/src/reference/experimental_features.md" ], "solution_diff": "diff --git a/docs/book/src/reference/experimental_features.md b/docs/book/src/reference/experimental_features.md\nindex d06f8b3c772..acb56e5ed05 100644\n--- a/docs/book/src/reference/...
[]
diff --git a/docs/book/src/reference/experimental_features.md b/docs/book/src/reference/experimental_features.md index d06f8b3c772..acb56e5ed05 100644 --- a/docs/book/src/reference/experimental_features.md +++ b/docs/book/src/reference/experimental_features.md @@ -12,7 +12,7 @@ The list of [currently active](https://gi...
25
41
FuelLabs/sway#7565
FuelLabs/sway
7,565
076d4388ebb9b596949c7b802ffc83261e69597c
e3c9bf0432891f033f82e35d8fefc5927d06bf9b
Confusing error message when using non-const `tx_field_id` in `__gtf` E.g: ``` let x = 0xA; let _ = __gtf::<raw_ptr>(0, x); ^ Could not evaluate initializer to a const declaration. ``` We should provide a clear error message explaining that `tx_field_id` must be a `u64` constant. Add `dy...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Confusing error message when using non-const `tx_field_id` in `__gtf`", "scope_files": [ "Cargo.lock", "Cargo.toml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workfl...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock", "Cargo.toml" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex 0f9b8da44b2..ce852af8c96 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -514,6 +514,28 @@ version = \"1.5.0\"\n source = \"registry+https://github.com/rust-l...
[ { "subtask_id": "s17", "comment": "### `StateLoadWord` offset not hashed in function deduplication\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `offset` field on `FuelVmInstruction::StateLoadWord` is not included in the hash computation for function deduplication. Two functions that are identic...
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 12c8140031e..65da388ac2f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -437,6 +437,14 @@ jobs: run: cargo run --locked --release -p forc -- build --release --locked --path ./test/src/sdk-harness --experimental str_...
54
69
FuelLabs/sway#7588
FuelLabs/sway
7,588
551e37f20aa44e49f2520e333e2934b3d209f820
c26d6fc22d061f92aef1e6435c589918e3ac2c37
Add comprehensive benchmarks for `StorageVec` ## Description This PR is a continuation of #7583. It adds additional benchmarks for benchmarking all `StorageVec` API methods for different element sizes and different number of elements stored. The `README.md` explains the benchmarks and how to use the benchmarking...
[ { "subtask_id": "s1", "goal": "Implement the changes under `test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/` needed for: Add comprehensive benchmarks for `StorageVec`", "scope_files": [ "test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/README.md", "test/...
[ { "subtask_id": "s1", "scope_files": [ "test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/README.md", "test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/RESULTS.md", "test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/bench_storage_vec.sh",...
[]
diff --git a/test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/README.md b/test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/README.md index f03ee0b1165..453bbf2516b 100644 --- a/test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/README.md +++ b/test/src/e2e_vm_tests/t...
15
32
FuelLabs/sway#7587
FuelLabs/sway
7,587
31d4ea8e68762d7a6fdeb572bccd439b2e5213f9
a73428e7bf6d4cbd47bce903a89a36f156e78f1d
Pin tracing-subscriber to 0.3.19 ## Summary Pin `tracing-subscriber` to `0.3.19`. ## Why `forc` output regressed because newer `tracing-subscriber` releases escape ANSI sequences in normal terminal output. This was not a snapshot-test-only issue; it changed compiler and CLI output behavior in general. Pinning to `0...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Pin tracing-subscriber to 0.3.19", "scope_files": [ "Cargo.lock", "Cargo.toml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflows/scripts/check-dep-versions/src/` ...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock", "Cargo.toml" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex 65cae06a8f4..0f9b8da44b2 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -726,7 +726,7 @@ source = \"registry+https://github.com/rust-lang/crates.io-index\"\n...
[]
diff --git a/.github/workflows/scripts/check-dep-versions/src/main.rs b/.github/workflows/scripts/check-dep-versions/src/main.rs index 0015e6a8311..066d15232c6 100644 --- a/.github/workflows/scripts/check-dep-versions/src/main.rs +++ b/.github/workflows/scripts/check-dep-versions/src/main.rs @@ -7,9 +7,16 @@ use toml::...
2
3
FuelLabs/sway#7585
FuelLabs/sway
7,585
cd2aa3562318186e6316edc89721084c69099f56
da43263b2d39149139144f0ff2badec8efcaea12
Remove forc-mcp from sway repo ## Summary This temporarily removes `forc-mcp` from the Sway repo so we can unblock the upcoming Sway release work and break the current release-order circular dependency. The immediate issue is that `forc-mcp` still lives in this repo while depending on `forc-client` from the `forc` r...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Remove forc-mcp from sway repo", "scope_files": [ "Cargo.lock", "Cargo.toml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflows/` needed for: Remove forc-mcp from ...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock", "Cargo.toml" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex 4c8b001d46e..65cae06a8f4 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -27,24 +27,13 @@ version = \"2.0.1\"\n source = \"registry+https://github.com/rust-la...
[]
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0e379449fce..12c8140031e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -235,6 +235,8 @@ jobs: run: cargo install --locked --path ./forc - name: Install Forc plugins run: | + cargo uninstall...
12
25
FuelLabs/sway#7299
FuelLabs/sway
7,299
f9fcb0edc308edba34d9cbf43ade15882614677d
fb2758255a53ebad95a74d269d688cf435846d45
Optimize initialization of array repeat when the initial value is zero ## Description Continuation of https://github.com/FuelLabs/sway/issues/6860. This PR improves performance of arrays initialized with zero like `[0u16; 5]`. Before, the compiler was initializing the array with `SW` or using a loop, depending o...
[ { "subtask_id": "s1", "goal": "Implement the changes under `sway-core/src/abi_generation/` needed for: Optimize initialization of array repeat when the initial value is zero", "scope_files": [ "sway-core/src/abi_generation/abi_str.rs" ] }, { "subtask_id": "s2", "goal": "Implement t...
[ { "subtask_id": "s1", "scope_files": [ "sway-core/src/abi_generation/abi_str.rs" ], "solution_diff": "diff --git a/sway-core/src/abi_generation/abi_str.rs b/sway-core/src/abi_generation/abi_str.rs\nindex decaaf27b38..263122461a0 100644\n--- a/sway-core/src/abi_generation/abi_str.rs\n+++ b/sway...
[ { "subtask_id": "s2", "comment": "Is that intended to be implemented in a later PR or what?", "revised_diff": "diff --git a/sway-core/src/asm_generation/evm/evm_asm_builder.rs b/sway-core/src/asm_generation/evm/evm_asm_builder.rs\nindex 16fd7fd2758..989258ea575 100644\n--- a/sway-core/src/asm_generation...
diff --git a/sway-core/src/abi_generation/abi_str.rs b/sway-core/src/abi_generation/abi_str.rs index decaaf27b38..263122461a0 100644 --- a/sway-core/src/abi_generation/abi_str.rs +++ b/sway-core/src/abi_generation/abi_str.rs @@ -57,8 +57,11 @@ impl TypeId { } (TypeInfo::Array(_, length...
23
42
FuelLabs/sway#7410
FuelLabs/sway
7,410
7d45f82d11a7df26ac1b868ad9a87ccb1c553ad7
e907a527f40108ae144a797b50fec08d34b18781
Bump to v0.69.4
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Bump to v0.69.4", "scope_files": [ "Cargo.lock", "Cargo.toml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `sway-lib-std/` needed for: Bump to v0.69.4", "scope_files": [ ...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock", "Cargo.toml" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex 4e45b7420dc..d2973e9fdc0 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -3712,7 +3712,7 @@ checksum = \"d9c4f5dac5e15c24eb999c26181a6ca40b39fe946cbe4c263c720...
[]
diff --git a/Cargo.lock b/Cargo.lock index 4e45b7420dc..d2973e9fdc0 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3712,7 +3712,7 @@ checksum = "d9c4f5dac5e15c24eb999c26181a6ca40b39fe946cbe4c263c7209467bc83af2" [[package]] name = "forc" -version = "0.69.3" +version = "0.69.4" dependencies = [ "annotate-snippets", ...
2
3
FuelLabs/sway#7583
FuelLabs/sway
7,583
8e643df9de76cb6dbf7972382fed15f820230cff
97f3a232bbf7ffc26f16a0f9492c4b7983a4d2e8
Add comprehensive benchmarks for storage access ## Description This PR adds comprehensive benchmarks for storage fields access. We want to have the benchmark and historical values collected, in order to be able to compare them with the storage access costs after #7560 is implemented. The `README.md` explains the...
[ { "subtask_id": "s1", "goal": "Implement the changes under `test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/` needed for: Add comprehensive benchmarks for storage access", "scope_files": [ "test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/README.md", "tes...
[ { "subtask_id": "s1", "scope_files": [ "test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/README.md", "test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/RESULTS.md", "test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/bench.sh" ], "...
[ { "subtask_id": "s6", "comment": "### Wrong package name in stored_types Forc.lock\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `stored_types/Forc.lock` is a verbatim copy of the `storage_slot_key_calculation/Forc.lock` from a different project. It declares `name = \"storage_slot_key_calculation\"...
diff --git a/test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/README.md b/test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/README.md new file mode 100644 index 00000000000..f03ee0b1165 --- /dev/null +++ b/test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/README.md @...
7
14
FuelLabs/sway#7247
FuelLabs/sway
7,247
b21e87e4aa0ea6a7ebf1ff24b5f0474ff71e42b7
ba4b97c051240b8678ff82d9b604dd2703b46e45
bump to 0.68.9 ## Description ~~waiting on #7246 which fixes a critical bug in `forc pkg`~~ ## Checklist - [x] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: bump to 0.68.9", "scope_files": [ "Cargo.lock", "Cargo.toml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `sway-lib-std/` needed for: bump to 0.68.9", "scope_files": [ ...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock", "Cargo.toml" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex c70a843a305..e149dbb7027 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -2880,7 +2880,7 @@ checksum = \"d9c4f5dac5e15c24eb999c26181a6ca40b39fe946cbe4c263c720...
[]
diff --git a/Cargo.lock b/Cargo.lock index c70a843a305..e149dbb7027 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2880,7 +2880,7 @@ checksum = "d9c4f5dac5e15c24eb999c26181a6ca40b39fe946cbe4c263c7209467bc83af2" [[package]] name = "forc" -version = "0.68.8" +version = "0.68.9" dependencies = [ "annotate-snippets", ...
3
4
FuelLabs/sway#7580
FuelLabs/sway
7,580
cf207d23df1ded1b21b0fb00a5cfb56175e0f354
a62000fc6206dad3d5136cf66f548a795663a625
`cfg` attribute not working in `impl Contract` E.g., this compiles as expected: ```sway contract; abi MyContract { fn some_contract_method(); } impl MyContract for Contract { #[cfg(experimental_new_encoding = true)] fn some_contract_method() { } #[cfg(experimental_new_encoding = false)] fn some...
[ { "subtask_id": "s1", "goal": "Implement the changes under `sway-core/src/language/parsed/declaration/` needed for: `cfg` attribute not working in `impl Contract`", "scope_files": [ "sway-core/src/language/parsed/declaration/impl_trait.rs" ] }, { "subtask_id": "s2", "goal": "Implem...
[ { "subtask_id": "s1", "scope_files": [ "sway-core/src/language/parsed/declaration/impl_trait.rs" ], "solution_diff": "diff --git a/sway-core/src/language/parsed/declaration/impl_trait.rs b/sway-core/src/language/parsed/declaration/impl_trait.rs\nindex b5dc4632a07..420d623008c 100644\n--- a/swa...
[ { "subtask_id": "s3", "comment": "### Wrong filter allows excluded attributes on ABI interface\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe code comment at lines 976–978 explicitly states that `#[inline]` is \"not on the ABI interface method itself,\" yet the filter calls `can_annotate_abi_or_t...
diff --git a/sway-core/src/language/parsed/declaration/impl_trait.rs b/sway-core/src/language/parsed/declaration/impl_trait.rs index b5dc4632a07..420d623008c 100644 --- a/sway-core/src/language/parsed/declaration/impl_trait.rs +++ b/sway-core/src/language/parsed/declaration/impl_trait.rs @@ -61,8 +61,11 @@ impl DebugWi...
15
24
FuelLabs/sway#7566
FuelLabs/sway
7,566
0d16c93b2470d61f669dc7907d53eb20aeb444f4
c9e6eae53020e7a85177b2a89abecb9f52895881
Slides for trivial encoding, const generics and dbg ## Description Slides and better documentation for trivial encoding, const generics and `__dbg`. ## Checklist - [ ] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the doc...
[ { "subtask_id": "s1", "goal": "Implement the changes under `docs/slides/` needed for: Slides for trivial encoding, const generics and dbg", "scope_files": [ "docs/slides/const_generics.md", "docs/slides/dbg.md", "docs/slides/trivial_encoding.md" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "docs/slides/const_generics.md", "docs/slides/dbg.md", "docs/slides/trivial_encoding.md" ], "solution_diff": "diff --git a/docs/slides/const_generics.md b/docs/slides/const_generics.md\nnew file mode 100644\nindex 00000000000..8e0455d307a\n---...
[ { "subtask_id": "s1", "comment": "```suggestion\nThis allowed us to implement all the `std` traits for arrays, string arrays etc.\n```", "revised_diff": "diff --git a/docs/slides/const_generics.md b/docs/slides/const_generics.md\nnew file mode 100644\nindex 00000000000..8e0455d307a\n--- /dev/null\n+++ b...
diff --git a/docs/slides/const_generics.md b/docs/slides/const_generics.md new file mode 100644 index 00000000000..8e0455d307a --- /dev/null +++ b/docs/slides/const_generics.md @@ -0,0 +1,76 @@ +--- +layout: cover +marp: true +--- + +<!-- markdownlint-disable --> +# Const Generics + +`const generics` let you parameteri...
1
3
FuelLabs/sway#7561
FuelLabs/sway
7,561
d71243f17aba2ac1a6af8d0659a573cab7517e38
91cad8715014c01bf53f49a3ec87e4812840578a
Optimise `pshl` ## Description Change the order of register allocation... instead of starting from "lower" registers... it starts from higher registers... that means that for functions with very few registers, there is no need to save them with `pshl`. Example: ```sway #[inline(never)] fn leaf_fn_6(a: u64, b: ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `forc-plugins/forc-debug/tests/` needed for: Optimise `pshl`", "scope_files": [ "forc-plugins/forc-debug/tests/server_integration.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `forc/tests/` needed for:...
[ { "subtask_id": "s1", "scope_files": [ "forc-plugins/forc-debug/tests/server_integration.rs" ], "solution_diff": "diff --git a/forc-plugins/forc-debug/tests/server_integration.rs b/forc-plugins/forc-debug/tests/server_integration.rs\nindex 30d71f0f10a..3e7d8ee9eb5 100644\n--- a/forc-plugins/fo...
[ { "subtask_id": "s5", "comment": "### Off-by-one excludes valid register 16 from allocation\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\nThe boundary check `if id <= 16` incorrectly excludes register 16, which is a valid allocatable register. `NUM_ALLOCATABLE_REGISTERS` is 37, so the register allocat...
diff --git a/sway-core/src/asm_generation/fuel/allocated_abstract_instruction_set.rs b/sway-core/src/asm_generation/fuel/allocated_abstract_instruction_set.rs index abdfde3511e..726d4ee65e8 100644 --- a/sway-core/src/asm_generation/fuel/allocated_abstract_instruction_set.rs +++ b/sway-core/src/asm_generation/fuel/alloc...
43
44
FuelLabs/sway#7550
FuelLabs/sway
7,550
5cd44e7788de590177213e1b4040493b2db8b989
2765f4af57abc203a826d5890c77e4593c6095ff
`$err` register propagated from `move` to `eq` although `move` clears it Consider the following example: ```sway #[storage(read)] fn srdd_empty_slot() { let dest = [42u64; 2]; let is_err = asm(slot: B256_ZERO, res: __addr_of(dest), index: 0, len: dest.len()) { srdd res slot index len; err ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: `$err` register propagated from `move` to `eq` although `move` clears it", "scope_files": [ "Cargo.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `forc/tests/` needed for: `$err`...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex 2c6a09423f9..4c8b001d46e 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -9163,6 +9163,7 @@ dependencies = [\n \"clap\",\n \"dirs 5.0.1\",\n \"either\",\n+ \"expect-test\",\n ...
[ { "subtask_id": "s5", "comment": "### EXP optimization incorrectly folds `0^x` to zero\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\nThe rule `if left is 0 assigns 0` for `EXP` assumes `0^x = 0` for all `x`, but `0^0 = 1`. When the left operand is known to be 0 and the right operand is unknown at comp...
diff --git a/Cargo.lock b/Cargo.lock index 2c6a09423f9..4c8b001d46e 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -9163,6 +9163,7 @@ dependencies = [ "clap", "dirs 5.0.1", "either", + "expect-test", "fuel-abi-types", "fuel-ethabi", "fuel-etk-asm", diff --git a/sway-core/Cargo.toml b/sway-core/Cargo.toml index...
53
57
FuelLabs/sway#7569
FuelLabs/sway
7,569
56a6518ed5aca466ce0c2cccfe43c5cd4f45cf03
cea3271f8288104865bae95d083a511353ee3117
Bump Rust to 1.93.0 ## Description This PR: - bumps CI version of Rust to 1.93.0, - fixes new Clippy issues, - explicitly installs `forc-node` from the `forc` repo in the `build-mdbook` CI step. ## Checklist - [ ] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: Bump Rust to 1.93.0", "scope_files": [ ".github/workflows/ci.yml", ".github/workflows/gh-pages.yml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `forc-pkg/src/source...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/ci.yml", ".github/workflows/gh-pages.yml" ], "solution_diff": "diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml\nindex a23912d2b7b..0e379449fce 100644\n--- a/.github/workflows/ci.yml\n+++ b/.github/workflows/ci.yml...
[ { "subtask_id": "s4", "comment": "### Overbroad unused_assignments suppression on large function\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `#[allow(unused_assignments)]` is applied at the function level on `connect_expression`, which is a very large function (~800 lines with dozens of match arm...
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a23912d2b7b..0e379449fce 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,8 +18,8 @@ permissions: env: CARGO_TERM_COLOR: always REGISTRY: ghcr.io - RUST_VERSION: 1.90.0 - NIGHTLY_RUST_VERSION: nightly-2025-09-28 +...
9
10
FuelLabs/sway#7563
FuelLabs/sway
7,563
f9de5456ea65806768cc83ddd74333fc90271711
4e4d13296c762c0c010586231b4e4be667f428a2
Verify all jumps on asm are using ControlFlowOp ## Description This PR will be useful for https://github.com/FuelLabs/sway/pull/7550 testing. Currently, we expect all jumps to use `ControlFlowOp`. We have two exceptions at the moment: 1 - JAL when returning from functions; 2 - and `__jmp_mem()` used on `run_ext...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Verify all jumps on asm are using ControlFlowOp", "scope_files": [ "Cargo.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflows/` needed for: Verify all jumps on asm ...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex feee725e639..2c6a09423f9 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -9831,12 +9831,14 @@ dependencies = [\n \"fuels-accounts 0.76.0\",\n \"futures\",\n \"gag\",\n+ \"giml...
[ { "subtask_id": "s3", "comment": "### JumpToAddr not recognized as block-ending control flow\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe basic block tracking in `collect_far_jumps()` and `map_label_offsets()` doesn't recognize `JumpToAddr` as a block-ending control flow operation. The pattern ...
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index dd8018e48f1..a23912d2b7b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -35,7 +35,6 @@ jobs: - check-sdk-harness-test-suite-compatibility - build-mdbook - build-forc-doc-sway-lib-std - - build-forc-...
12
21
FuelLabs/sway#7242
FuelLabs/sway
7,242
0ac606c13232af77d646944b4eeb77f1b48ab02a
7e4be669bb2e8a45aab16b92e4360437d3628362
Add criterion benchmark to forc-doc + initial code quality pass ## Description Doing some general code quality changes at the same time. ## Checklist - [ ] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation wh...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Add criterion benchmark to forc-doc + initial code quality pass", "scope_files": [ "Cargo.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflows/` needed for: Add crit...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex 02e0c4f5195..2fba7d4074e 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -3040,6 +3040,7 @@ version = \"0.69.0\"\n dependencies = [\n \"anyhow\",\n \"clap\",\n+ \"codspeed-crit...
[ { "subtask_id": "s5", "comment": "nit:\n```suggestion\n #[clap(long)]\n```", "revised_diff": "diff --git a/forc-plugins/forc-doc/src/lib.rs b/forc-plugins/forc-doc/src/lib.rs\nindex a264481a8f3..af3b5d20840 100644\n--- a/forc-plugins/forc-doc/src/lib.rs\n+++ b/forc-plugins/forc-doc/src/lib.rs\n@@ -1,...
diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 4f40b19a74f..7903654f5c1 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -10,7 +10,7 @@ on: - sway-lsp/** - forc-pkg/** - sway-core/** - + - forc-plugins/forc-doc/** ...
23
42
Genymobile/scrcpy#6859
Genymobile/scrcpy
6,859
4d79fb5b260a00665f54e3fe618d42d154497a83
f457fd4cf5ff4e91853159cbbbbbb98efa8f30b3
Fix size constraints algorithm The algorithm used to constrain a size according to the video capabilities, implemented in #6766, was too simplistic: it computed the maximum landscape size by retrieving the maximum width and its associated maximum height (and vice versa for the maximum portrait size). In addition to...
[ { "subtask_id": "s1", "goal": "Implement the changes under `server/src/main/java/com/genymobile/scrcpy/model/` needed for: Fix size constraints algorithm", "scope_files": [ "server/src/main/java/com/genymobile/scrcpy/model/Size.java" ] }, { "subtask_id": "s2", "goal": "Implement th...
[ { "subtask_id": "s1", "scope_files": [ "server/src/main/java/com/genymobile/scrcpy/model/Size.java" ], "solution_diff": "diff --git a/server/src/main/java/com/genymobile/scrcpy/model/Size.java b/server/src/main/java/com/genymobile/scrcpy/model/Size.java\nindex 63648a9e8f..51211969e2 100644\n--...
[ { "subtask_id": "s1", "comment": "```suggestion\n int minMinor = alignUp(landscape ? caps.getSupportedHeights().getLower() : caps.getSupportedWidths().getLower(), alignment);\n```\nFor below assertions to work.", "revised_diff": "diff --git a/server/src/main/java/com/genymobile/scrcpy/model/Size....
diff --git a/server/src/main/java/com/genymobile/scrcpy/model/Size.java b/server/src/main/java/com/genymobile/scrcpy/model/Size.java index 63648a9e8f..51211969e2 100644 --- a/server/src/main/java/com/genymobile/scrcpy/model/Size.java +++ b/server/src/main/java/com/genymobile/scrcpy/model/Size.java @@ -1,8 +1,12 @@ pac...
5
6
Genymobile/scrcpy#6769
Genymobile/scrcpy
6,769
f457fd4cf5ff4e91853159cbbbbbb98efa8f30b3
0bdd750447b0826039d8c6111c2c21dc10d70af1
Encoder support for new Onyx Devices - [x] I have checked that a similar [feature request](https://github.com/Genymobile/scrcpy/issues?q=is%3Aopen+is%3Aissue+label%3A%22feature+request%22) does not already exist. **Is your feature request related to a problem? Please describe.** A clear and concise description of wh...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Encoder support for new Onyx Devices", "scope_files": [ "app/scrcpy.1" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/data/bash-completion/` needed for: Encoder support for new Onyx ...
[ { "subtask_id": "s1", "scope_files": [ "app/scrcpy.1" ], "solution_diff": "diff --git a/app/scrcpy.1 b/app/scrcpy.1\nindex 644206cb82..d6d33a5baa 100644\n--- a/app/scrcpy.1\n+++ b/app/scrcpy.1\n@@ -652,7 +652,7 @@ Default is 0 (no buffering).\n \n .TP\n .BI \"\\-\\-video\\-codec \" name\n-Sele...
[ { "subtask_id": "s5", "comment": "```suggestion\n bool video_expects_config_packet;\n bool audio_expects_config_packet;\n```\nAbove and below, `video_*` is always declared before `audio_*`.", "revised_diff": "diff --git a/app/src/recorder.h b/app/src/recorder.h\nindex 70b738362c..8638c72ee6 100644...
diff --git a/app/data/bash-completion/scrcpy b/app/data/bash-completion/scrcpy index 80551d7765..53ab5edc45 100644 --- a/app/data/bash-completion/scrcpy +++ b/app/data/bash-completion/scrcpy @@ -118,7 +118,7 @@ _scrcpy() { case "$prev" in --video-codec) - COMPREPLY=($(compgen -W 'h264 h265 av...
7
12
Genymobile/scrcpy#6772
Genymobile/scrcpy
6,772
32d2f06f84ef7e423103f7653979554d3e85d44b
1db8da559fd5b412b02b564e9ad40c2580bb9b34
Add flex display support (resizable virtual display) ```bash # Start Android Settings in a window scrcpy --new-display=1024x768 --start-app=com.android.settings --flex-display # -x is equivalent to --flex-display scrcpy --new-display=1024x768 --start-app=com.android.settings -x # By default, the display size/...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Add flex display support (resizable virtual display)", "scope_files": [ "app/scrcpy.1" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/data/bash-completion/` needed for: Add flex disp...
[ { "subtask_id": "s1", "scope_files": [ "app/scrcpy.1" ], "solution_diff": "diff --git a/app/scrcpy.1 b/app/scrcpy.1\nindex bfa1267f2d..c8f7c1d3c4 100644\n--- a/app/scrcpy.1\n+++ b/app/scrcpy.1\n@@ -294,7 +294,11 @@ List displays available on the device.\n \n .TP\n .BI \"\\-m, \\-\\-max\\-size ...
[ { "subtask_id": "s4", "comment": "Other places in this file signal the condvar with the lock held, so for consistency the mutex should be unlocked at the end of this function. (In this case it surely doesn't matter, but I think it would matter in the case of multiple waiter threads for scheduling policy/pre...
diff --git a/app/data/bash-completion/scrcpy b/app/data/bash-completion/scrcpy index e8cae851af..f55db26f10 100644 --- a/app/data/bash-completion/scrcpy +++ b/app/data/bash-completion/scrcpy @@ -82,6 +82,7 @@ _scrcpy() { --record-format= --record-orientation= --render-driver= + --rende...
16
47
Genymobile/scrcpy#6822
Genymobile/scrcpy
6,822
3fcb0108230686a52fc1da2c53026c181f3aa8df
5830dedbe4d71ba06d725f3013ce7d34cea6a5a8
Restore retry-on-error mechanism First, restore retry on spurious error. MediaCodec may fail spuriously, typically when stopping an encoding and starting a new one immediately (for example on device rotation). This was initially fixed by 07806ba9159b1f4dbd2ede77b110e254af1fd7f6 (#3693), but the fix was r...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Restore retry-on-error mechanism", "scope_files": [ "app/scrcpy.1" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/data/bash-completion/` needed for: Restore retry-on-error mechanism"...
[ { "subtask_id": "s1", "scope_files": [ "app/scrcpy.1" ], "solution_diff": "diff --git a/app/scrcpy.1 b/app/scrcpy.1\nindex c8f7c1d3c4..9695aa920c 100644\n--- a/app/scrcpy.1\n+++ b/app/scrcpy.1\n@@ -398,6 +398,12 @@ By default, scrcpy automatically synchronizes the computer clipboard to the dev...
[ { "subtask_id": "s7", "comment": "It would be nice if this was moved right below `getSize()` like previously.", "revised_diff": "diff --git a/server/src/main/java/com/genymobile/scrcpy/video/ScreenCapture.java b/server/src/main/java/com/genymobile/scrcpy/video/ScreenCapture.java\nindex 68bddab360..2278b...
diff --git a/app/data/bash-completion/scrcpy b/app/data/bash-completion/scrcpy index f55db26f10..80551d7765 100644 --- a/app/data/bash-completion/scrcpy +++ b/app/data/bash-completion/scrcpy @@ -58,6 +58,7 @@ _scrcpy() { --no-audio-playback --no-cleanup --no-clipboard-autosync + --no-d...
7
17
Genymobile/scrcpy#6854
Genymobile/scrcpy
6,854
2892d4095a4b7a72542c7531e68d47c2425a1ca5
09a5c17b070b0395730464639c7f04060c3e5d06
Include LICENSE file in release archives
[ { "subtask_id": "s1", "goal": "Implement the changes under `release/` needed for: Include LICENSE file in release archives", "scope_files": [ "release/build_linux.sh", "release/build_macos.sh", "release/build_windows.sh" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "release/build_linux.sh", "release/build_macos.sh", "release/build_windows.sh" ], "solution_diff": "diff --git a/release/build_linux.sh b/release/build_linux.sh\nindex 37dc763bf5..7810c80381 100755\n--- a/release/build_linux.sh\n+++ b/release/...
[]
diff --git a/release/build_linux.sh b/release/build_linux.sh index 37dc763bf5..7810c80381 100755 --- a/release/build_linux.sh +++ b/release/build_linux.sh @@ -44,4 +44,5 @@ cp "$LINUX_BUILD_DIR"/app/scrcpy "$LINUX_BUILD_DIR/dist/" cp app/data/scrcpy.png "$LINUX_BUILD_DIR/dist/" cp app/data/disconnected.png "$LINUX_BU...
1
3
Genymobile/scrcpy#6853
Genymobile/scrcpy
6,853
610eff34140bead565cbd5aa8f72d4cd9ea917ae
2892d4095a4b7a72542c7531e68d47c2425a1ca5
Fix gamepad In SDL2, the `which` field in `SDL_ControllerDeviceEvent` contained the device index. In SDL3, the `which` field in `SDL_GamepadDeviceEvent` is the joystick instance id directly. This was not properly migrated from SDL2 to SDL3 in commit 02989249f6a992090a70c4d61e0834a990f004fa. Refs #6216 Refs ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/src/` needed for: Fix gamepad", "scope_files": [ "app/src/input_manager.c", "app/src/scrcpy.c" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "app/src/input_manager.c", "app/src/scrcpy.c" ], "solution_diff": "diff --git a/app/src/input_manager.c b/app/src/input_manager.c\nindex 103067a7bc..3b123842b0 100644\n--- a/app/src/input_manager.c\n+++ b/app/src/input_manager.c\n@@ -1048,13 +1048,1...
[]
diff --git a/app/src/input_manager.c b/app/src/input_manager.c index 103067a7bc..3b123842b0 100644 --- a/app/src/input_manager.c +++ b/app/src/input_manager.c @@ -1048,13 +1048,13 @@ sc_input_manager_process_gamepad_device(struct sc_input_manager *im, if (event->type == SDL_EVENT_GAMEPAD_ADDED) { SDL_Game...
1
2
Genymobile/scrcpy#6807
Genymobile/scrcpy
6,807
3de3325b984ff5b83b22b94fd9c8adba901c7136
198cc19afb23f5d119318c88084451307faa143a
Add option to change the background color Introduce a `--background-color` option that accepts hexadecimal color codes (3-digit or 6-digit formats): ```bash scrcpy --background-color=#234567 scrcpy --background-color=234567 # leading '#' is optional scrcpy --background-color=#567 # equivalent to #556677 ```...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Add option to change the background color", "scope_files": [ "app/scrcpy.1" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/data/bash-completion/` needed for: Add option to change the...
[ { "subtask_id": "s1", "scope_files": [ "app/scrcpy.1" ], "solution_diff": "diff --git a/app/scrcpy.1 b/app/scrcpy.1\nindex 69d814cbc5..bfa1267f2d 100644\n--- a/app/scrcpy.1\n+++ b/app/scrcpy.1\n@@ -97,6 +97,12 @@ Encode the video at the given bit rate, expressed in bits/s. Unit suffixes are s\...
[ { "subtask_id": "s4", "comment": "```suggestion\n .text = \"Set the background color, encoded as hexadecimal color code \"\n```", "revised_diff": "diff --git a/app/src/cli.c b/app/src/cli.c\nindex 39576d8d20..2cb0d3e23d 100644\n--- a/app/src/cli.c\n+++ b/app/src/cli.c\n@@ -106,6 +106,7 @@ enum {\...
diff --git a/app/data/bash-completion/scrcpy b/app/data/bash-completion/scrcpy index 0cae593a45..e8cae851af 100644 --- a/app/data/bash-completion/scrcpy +++ b/app/data/bash-completion/scrcpy @@ -12,6 +12,7 @@ _scrcpy() { --audio-source= --audio-output-buffer= -b --video-bit-rate= + --b...
5
10
Genymobile/scrcpy#6662
Genymobile/scrcpy
6,662
bad2183087185c1ddd7cacf2fe68be1a7429499f
a4000a14879831bd61f935fccc5af896e3098dfb
Display disconnected icon before closing When the connection to the device is lost while mirroring, the window closed immediately, suggesting scrcpy had crashed. To make it clear that a disconnection occurred, display a disconnected icon for 2 seconds before closing the window. The icon replaces the screen conte...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Display disconnected icon before closing", "scope_files": [ "run" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/` needed for: Display disconnected icon before closing", "scop...
[ { "subtask_id": "s1", "scope_files": [ "run" ], "solution_diff": "diff --git a/run b/run\nindex 56f0a4e1c0..abc4c9a09e 100755\n--- a/run\n+++ b/run\n@@ -20,6 +20,6 @@ then\n exit 1\n fi\n \n-SCRCPY_ICON_PATH=\"app/data/icon.png\" \\\n+SCRCPY_ICON_DIR=\"app/data\" \\\n SCRCPY_SERVER_PATH=\"...
[ { "subtask_id": "s4", "comment": "I think there is an issue here in case `sc_disconnect_start()` failed to initialize the mutex/cond/thread. I would add a check like this above the while-loop:\r\n```c\r\n if (!screen->disconnect_started) {\r\n // If sc_disconnect_start() failed, quit immediately\r...
diff --git a/app/data/disconnected.png b/app/data/disconnected.png new file mode 100644 index 0000000000..37ff3d855e Binary files /dev/null and b/app/data/disconnected.png differ diff --git a/app/data/icon.png b/app/data/scrcpy.png similarity index 100% rename from app/data/icon.png rename to app/data/scrcpy.png diff -...
7
26
Genymobile/scrcpy#6216
Genymobile/scrcpy
6,216
09eed565fc6aae4c554c7536f7964fbee8f1d06a
dee1fd46a674ec6078da56acc3d577e18b9d65fd
Migrate from SDL2 to SDL3 First, this PR contains some fixes that could be merged directly into `dev`. Then, there are some refactors to make the transition easier, especially the handling of integer scrolling (https://github.com/Genymobile/scrcpy/issues/6156#issuecomment-3016836940) and the configuration of the co...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Migrate from SDL2 to SDL3", "scope_files": [ "README.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflows/` needed for: Migrate from SDL2 to SDL3", "scope_files": ...
[ { "subtask_id": "s1", "scope_files": [ "README.md" ], "solution_diff": "diff --git a/README.md b/README.md\nindex 07501a2cbf..c88978063c 100644\n--- a/README.md\n+++ b/README.md\n@@ -129,7 +129,7 @@ Here are just some common examples.\n scrcpy --otg\n ```\n \n- - Control the device usi...
[ { "subtask_id": "s4", "comment": "You probably mean SDL_WAYLAND?", "revised_diff": "diff --git a/app/deps/sdl.sh b/app/deps/sdl.sh\nindex f74ccf4124..2219d5c8e5 100755\n--- a/app/deps/sdl.sh\n+++ b/app/deps/sdl.sh\n@@ -3,9 +3,9 @@ set -ex\n . $(dirname ${BASH_SOURCE[0]})/_init\n process_args \"$@\"\n \n...
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 2bb5a38c88..138ad821e0 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -72,16 +72,30 @@ jobs: - name: Checkout code uses: actions/checkout@v4 + # Same as build-linux-x86_64 ...
10
47
Genymobile/scrcpy#6816
Genymobile/scrcpy
6,816
1db8da559fd5b412b02b564e9ad40c2580bb9b34
3fcb0108230686a52fc1da2c53026c181f3aa8df
Replace run-on-main-thread implementation Use `SDL_RunOnMainThread()` introduced in SDL3.
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/src/` needed for: Replace run-on-main-thread implementation", "scope_files": [ "app/src/events.c", "app/src/events.h", "app/src/main.c", "app/src/receiver.c", "app/src/scrcpy.c" ] }, { "subtask_id":...
[ { "subtask_id": "s1", "scope_files": [ "app/src/events.c", "app/src/events.h", "app/src/main.c", "app/src/receiver.c", "app/src/scrcpy.c" ], "solution_diff": "diff --git a/app/src/events.c b/app/src/events.c\nindex 5269bdbcf8..b7a3a7a34a 100644\n--- a/app/src/events.c\n...
[ { "subtask_id": "s1", "comment": "Can this include be removed in the previous-to-last commit already?", "revised_diff": "diff --git a/app/src/main.c b/app/src/main.c\nindex 3ab03243f7..7327e07d3e 100644\n--- a/app/src/main.c\n+++ b/app/src/main.c\n@@ -8,6 +8,7 @@\n #include <SDL3/SDL.h>\n \n #include \"...
diff --git a/app/src/events.c b/app/src/events.c index 5269bdbcf8..b7a3a7a34a 100644 --- a/app/src/events.c +++ b/app/src/events.c @@ -5,6 +5,9 @@ #include "util/log.h" #include "util/thread.h" +static sc_mutex mutex; +static bool stopped; + bool sc_push_event_impl(uint32_t type, void *ptr, const char *name) { ...
3
8
Genymobile/scrcpy#6809
Genymobile/scrcpy
6,809
198cc19afb23f5d119318c88084451307faa143a
32d2f06f84ef7e423103f7653979554d3e85d44b
Share SDL hints between normal and OTG modes Some hints were missing for OTG. Fixes #6808
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Share SDL hints between normal and OTG modes", "scope_files": [ "app/meson.build" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/src/` needed for: Share SDL hints between normal and ...
[ { "subtask_id": "s1", "scope_files": [ "app/meson.build" ], "solution_diff": "diff --git a/app/meson.build b/app/meson.build\nindex d3336daae7..fd58098eb5 100644\n--- a/app/meson.build\n+++ b/app/meson.build\n@@ -32,6 +32,7 @@ src = [\n 'src/recorder.c',\n 'src/scrcpy.c',\n 'src/sc...
[]
diff --git a/app/meson.build b/app/meson.build index d3336daae7..fd58098eb5 100644 --- a/app/meson.build +++ b/app/meson.build @@ -32,6 +32,7 @@ src = [ 'src/recorder.c', 'src/scrcpy.c', 'src/screen.c', + 'src/sdl_hints.c', 'src/server.c', 'src/texture.c', 'src/version.c', diff --git a/...
3
5
Genymobile/scrcpy#6801
Genymobile/scrcpy
6,801
bf8bff430fc3dce9a443720b114544f297ea75ff
19c4d0b4e9d23d998a3aa6850066894c2f336f12
Where is the developer's public PGP key located? Dear Rom1v, Under each scrcpy release, there is an asc file for the checksums (SHA256SUMS.txt). Where is the public PGP key for verifying the asc file? Thank you! Document release signature verification Fixes #6800 Rendered: https://github.com/Genymobile/scrcpy/blo...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Where is the developer's public PGP key located?", "scope_files": [ "README.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `doc/` needed for: Where is the developer's public PGP ke...
[ { "subtask_id": "s1", "scope_files": [ "README.md" ], "solution_diff": "diff --git a/README.md b/README.md\nindex 3eef095141..d784e746c2 100644\n--- a/README.md\n+++ b/README.md\n@@ -165,6 +165,7 @@ documented in the following pages:\n - [Translations][wiki] (not necessarily up to date)\n - ...
[]
diff --git a/README.md b/README.md index 3eef095141..d784e746c2 100644 --- a/README.md +++ b/README.md @@ -165,6 +165,7 @@ documented in the following pages: - [Translations][wiki] (not necessarily up to date) - [Build instructions](doc/build.md) - [Developers](doc/develop.md) + - [Verify release signatures](doc/...
2
2
Genymobile/scrcpy#6794
Genymobile/scrcpy
6,794
a0057ef134bce474ffbd61b2176e769ee2584b44
5b220515c6b6c41a8ee676411b773f0f19481bb3
Fix OpenGL runner shutdown deadlock `OpenGLRunner.stopAndRelease()` posts work to its internal `HandlerThread`, so the thread must remain alive until the task completes. Otherwise, the method may never terminate. However, `OpenGLRunner.quit()` was called before `asyncProcessor.join()` (in particular before `Surface...
[ { "subtask_id": "s1", "goal": "Implement the changes under `server/src/main/java/com/genymobile/scrcpy/` needed for: Fix OpenGL runner shutdown deadlock", "scope_files": [ "server/src/main/java/com/genymobile/scrcpy/Server.java" ] }, { "subtask_id": "s2", "goal": "Implement the cha...
[ { "subtask_id": "s1", "scope_files": [ "server/src/main/java/com/genymobile/scrcpy/Server.java" ], "solution_diff": "diff --git a/server/src/main/java/com/genymobile/scrcpy/Server.java b/server/src/main/java/com/genymobile/scrcpy/Server.java\nindex e3f1680de8..d7d1a76ba8 100644\n--- a/server/s...
[]
diff --git a/server/src/main/java/com/genymobile/scrcpy/Server.java b/server/src/main/java/com/genymobile/scrcpy/Server.java index e3f1680de8..d7d1a76ba8 100644 --- a/server/src/main/java/com/genymobile/scrcpy/Server.java +++ b/server/src/main/java/com/genymobile/scrcpy/Server.java @@ -175,8 +175,6 @@ private static vo...
2
2
Genymobile/scrcpy#6792
Genymobile/scrcpy
6,792
b48feed0a024a3b24655de5e1532746fb526dd24
9b2498c852ad61bceb35a6c9b4a90b987b84ba56
Add --keep-active An an option to simulate user activity to prevent the screen from turning off due to inactivity. Fixes #6787 Supersedes #6789 --- Contrary to what I proposed here: https://github.com/Genymobile/scrcpy/pull/6789#issuecomment-4319038666 I didn't add a parameter to specify the interval durati...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Add --keep-active", "scope_files": [ "app/scrcpy.1" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/data/bash-completion/` needed for: Add --keep-active", "scope_files": [ "...
[ { "subtask_id": "s1", "scope_files": [ "app/scrcpy.1" ], "solution_diff": "diff --git a/app/scrcpy.1 b/app/scrcpy.1\nindex 8548646c31..69d814cbc5 100644\n--- a/app/scrcpy.1\n+++ b/app/scrcpy.1\n@@ -233,6 +233,10 @@ Print this help.\n .B \\-K\n Same as \\fB\\-\\-keyboard=uhid\\fR, or \\fB\\-\\-...
[ { "subtask_id": "s7", "comment": "Should you also call `keepActiveThread.join()` in `Controller.join()`? Or you don't because it's a daemon thread?", "revised_diff": "diff --git a/server/src/main/java/com/genymobile/scrcpy/control/Controller.java b/server/src/main/java/com/genymobile/scrcpy/control/Cont...
diff --git a/app/data/bash-completion/scrcpy b/app/data/bash-completion/scrcpy index 3f4c649d37..0cae593a45 100644 --- a/app/data/bash-completion/scrcpy +++ b/app/data/bash-completion/scrcpy @@ -34,6 +34,7 @@ _scrcpy() { --gamepad= -h --help -K + --keep-active --keyboard= ...
9
14
Genymobile/scrcpy#6771
Genymobile/scrcpy
6,771
965d0e6856c63dbf474f89ec38e3dfa84a40ec44
266e2eaf149771682ddafe0f35c589ed47237a46
Align the virtual display size When the virtual display size is not aligned, a resize filter may be inserted to compensate for small dimension mismatches, increasing processing and resulting in a blurry image.
[ { "subtask_id": "s1", "goal": "Implement the changes under `server/src/main/java/com/genymobile/scrcpy/model/` needed for: Align the virtual display size", "scope_files": [ "server/src/main/java/com/genymobile/scrcpy/model/Size.java" ] }, { "subtask_id": "s2", "goal": "Implement th...
[ { "subtask_id": "s1", "scope_files": [ "server/src/main/java/com/genymobile/scrcpy/model/Size.java" ], "solution_diff": "diff --git a/server/src/main/java/com/genymobile/scrcpy/model/Size.java b/server/src/main/java/com/genymobile/scrcpy/model/Size.java\nindex 13c6c28856..385597a8a2 100644\n--...
[ { "subtask_id": "s2", "comment": "If I understand correctly, you want to avoid `filter.addResize(filteredSize)` below? If yes, then is there a reason not to do `displaySize = displayInfo.getSize().constrain(getVideoConstraints())` in order to match min/max constraints in addition to alignment?", "revise...
diff --git a/server/src/main/java/com/genymobile/scrcpy/model/Size.java b/server/src/main/java/com/genymobile/scrcpy/model/Size.java index 13c6c28856..385597a8a2 100644 --- a/server/src/main/java/com/genymobile/scrcpy/model/Size.java +++ b/server/src/main/java/com/genymobile/scrcpy/model/Size.java @@ -84,6 +84,15 @@ pu...
2
2
Genymobile/scrcpy#6766
Genymobile/scrcpy
6,766
fd6536b34af024852b333fa28159cf743b8e245e
66005e88893f39dc995472def203f0c4bc9aa2b3
Replace retry-with-lower-resolution mechanism with video capabilities constraints A mechanism was introduced to retry capture at a lower resolution to support devices unable to encode at the device screen resolution (#2947). While useful, this approach is inherently limited and will not be able to handle the dy...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Replace retry-with-lower-resolution mechanism with video capabilities constraints", "scope_files": [ "app/scrcpy.1" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/data/bash-completio...
[ { "subtask_id": "s1", "scope_files": [ "app/scrcpy.1" ], "solution_diff": "diff --git a/app/scrcpy.1 b/app/scrcpy.1\nindex e2a65bae72..b6423c28c4 100644\n--- a/app/scrcpy.1\n+++ b/app/scrcpy.1\n@@ -384,12 +384,6 @@ By default, scrcpy automatically synchronizes the computer clipboard to the dev...
[ { "subtask_id": "s8", "comment": "```suggestion\n```", "revised_diff": "diff --git a/server/src/main/java/com/genymobile/scrcpy/video/SurfaceCapture.java b/server/src/main/java/com/genymobile/scrcpy/video/SurfaceCapture.java\nindex 81da337b77..18633c84af 100644\n--- a/server/src/main/java/com/genymobile...
diff --git a/app/data/bash-completion/scrcpy b/app/data/bash-completion/scrcpy index eedbd5041e..3f4c649d37 100644 --- a/app/data/bash-completion/scrcpy +++ b/app/data/bash-completion/scrcpy @@ -56,7 +56,6 @@ _scrcpy() { --no-audio-playback --no-cleanup --no-clipboard-autosync - --no-d...
9
19
Genymobile/scrcpy#6780
Genymobile/scrcpy
6,780
175134c0ca1d9018c14d10b467dbfcdff6d1c3be
12b129a17d5b2d575b6401c03ee4919393fd1e47
Add MOD+q shortcut to quit Fixes #6612
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Add MOD+q shortcut to quit", "scope_files": [ "app/scrcpy.1" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/src/` needed for: Add MOD+q shortcut to quit", "scope_files": [ ...
[ { "subtask_id": "s1", "scope_files": [ "app/scrcpy.1" ], "solution_diff": "diff --git a/app/scrcpy.1 b/app/scrcpy.1\nindex a484de8487..8548646c31 100644\n--- a/app/scrcpy.1\n+++ b/app/scrcpy.1\n@@ -695,6 +695,10 @@ device disconnects while a session is active, exit code 2 will be returned.\n I...
[]
diff --git a/app/scrcpy.1 b/app/scrcpy.1 index a484de8487..8548646c31 100644 --- a/app/scrcpy.1 +++ b/app/scrcpy.1 @@ -695,6 +695,10 @@ device disconnects while a session is active, exit code 2 will be returned. In the following list, MOD is the shortcut modifier. By default, it's (left) Alt or (left) Super, but it c...
3
4
Genymobile/scrcpy#6777
Genymobile/scrcpy
6,777
3f7ecafc53dbd2ad3f4d2cf879bc14595396071f
175134c0ca1d9018c14d10b467dbfcdff6d1c3be
Add F11 as fullscreen shortcut
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Add F11 as fullscreen shortcut", "scope_files": [ "app/scrcpy.1" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/src/` needed for: Add F11 as fullscreen shortcut", "scope_files": ...
[ { "subtask_id": "s1", "scope_files": [ "app/scrcpy.1" ], "solution_diff": "diff --git a/app/scrcpy.1 b/app/scrcpy.1\nindex a3437019f8..a484de8487 100644\n--- a/app/scrcpy.1\n+++ b/app/scrcpy.1\n@@ -696,7 +696,7 @@ In the following list, MOD is the shortcut modifier. By default, it's (left)\n A...
[ { "subtask_id": "s2", "comment": "Am I correctly assuming that you want to forward the <kbd>F11</kbd> key to the device (as before) unless it corresponds to a toggle-fullscreen shortcut? There is a small inconsistency in the sense that <kbd>F11</kbd>-down is captured whereas <kbd>F11</kbd>-up is forwarded (...
diff --git a/app/scrcpy.1 b/app/scrcpy.1 index a3437019f8..a484de8487 100644 --- a/app/scrcpy.1 +++ b/app/scrcpy.1 @@ -696,7 +696,7 @@ In the following list, MOD is the shortcut modifier. By default, it's (left) Alt or (left) Super, but it can be configured by \fB\-\-shortcut\-mod\fR (see above). .TP -.B MOD+f +.B ...
3
5
Genymobile/scrcpy#6775
Genymobile/scrcpy
6,775
f4a872bef4f048ea2bce0d273317dc93e30f881a
b5cc6f2be515e3d801e60e8d8de5dac99221a98c
Set default audio-output-buffer to 10ms Change the default value of `--audio-output-buffer` from 5ms to 10ms. In practice, the audio output backends do not support values below 10ms. When the setting is set to 5ms, several successive calls are made every 10ms or more. Additionally, a 5ms output buffer can cause ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Set default audio-output-buffer to 10ms", "scope_files": [ "app/scrcpy.1" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/src/` needed for: Set default audio-output-buffer to 10ms", ...
[ { "subtask_id": "s1", "scope_files": [ "app/scrcpy.1" ], "solution_diff": "diff --git a/app/scrcpy.1 b/app/scrcpy.1\nindex b6423c28c4..a3437019f8 100644\n--- a/app/scrcpy.1\n+++ b/app/scrcpy.1\n@@ -87,9 +87,9 @@ Default is output.\n .BI \"\\-\\-audio\\-output\\-buffer \" ms\n Configure the siz...
[]
diff --git a/app/scrcpy.1 b/app/scrcpy.1 index b6423c28c4..a3437019f8 100644 --- a/app/scrcpy.1 +++ b/app/scrcpy.1 @@ -87,9 +87,9 @@ Default is output. .BI "\-\-audio\-output\-buffer " ms Configure the size of the SDL audio output buffer (in milliseconds). -If you get "robotic" audio playback, you should test with ...
3
4
Genymobile/scrcpy#6770
Genymobile/scrcpy
6,770
b38ba2f6871e8601096521253f3da10c149d46c9
03878083fb8e5af806a78a3ad99f401edac47a95
Reset capture on rotation (fix square displays) `DisplayMonitor` previously only triggered a capture reset when the display size changed. In most cases, rotation also changes dimensions, so the behavior was correct… except for square displays where width and height remain unchanged. However, rotation still requ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `server/src/main/java/com/genymobile/scrcpy/display/` needed for: Reset capture on rotation (fix square displays)", "scope_files": [ "server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java", "server/src/main/java/com/...
[ { "subtask_id": "s1", "scope_files": [ "server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java", "server/src/main/java/com/genymobile/scrcpy/display/DisplayProperties.java" ], "solution_diff": "diff --git a/server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMon...
[ { "subtask_id": "s1", "comment": "Two `Ln.v(\"DisplaySizeMonitor:` in `start()` that should be replaced with `DisplayMonitor`.", "revised_diff": "diff --git a/server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java b/server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.ja...
diff --git a/server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java b/server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java similarity index 70% rename from server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java rename to server/src/main/java/com/genymobile/scrcp...
2
4
Genymobile/scrcpy#6746
Genymobile/scrcpy
6,746
5fedc79530672ae2b0df6ac7654d75a6f2e18ce3
de3db4299793450b6d28648852c70ba18ff7887c
Use optimal size alignment The video was always constrained to use a size that is a multiple of 8. This was sometimes not necessary (recent codecs only require a video size that is a multiple of 2 or even 1) and sometimes insufficient (some codecs require a size that is multiple of 16). Use the size alignment re...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Use optimal size alignment", "scope_files": [ "app/scrcpy.1" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/data/bash-completion/` needed for: Use optimal size alignment", "scope...
[ { "subtask_id": "s1", "scope_files": [ "app/scrcpy.1" ], "solution_diff": "diff --git a/app/scrcpy.1 b/app/scrcpy.1\nindex f0848077c5..5013e2c8e2 100644\n--- a/app/scrcpy.1\n+++ b/app/scrcpy.1\n@@ -296,6 +296,16 @@ Same as \\fB\\-\\-mouse=uhid\\fR, or \\fB\\-\\-mouse=aoa\\fR if \\fB\\-\\-otg\\...
[ { "subtask_id": "s7", "comment": "Documentation should be updated, e.g.:\n```diff\n /**\n- * Round both dimensions of this size to be a multiple of 8 (as required by many encoders).\n+ * Round both dimensions of this size to be a multiple of {@code alignment} (as required by many encoders).\n *...
diff --git a/app/data/bash-completion/scrcpy b/app/data/bash-completion/scrcpy index 956926ac83..dd8ea42432 100644 --- a/app/data/bash-completion/scrcpy +++ b/app/data/bash-completion/scrcpy @@ -45,6 +45,7 @@ _scrcpy() { -m --max-size= -M --max-fps= + --min-size-alignment= --m...
8
17
Genymobile/scrcpy#6694
Genymobile/scrcpy
6,694
10e0c3226c3a3a9078c86a42c931d9b288e035f0
e17a885f32fcc90337c9719ad3908cecaf03f8f1
Open the scrcpy window earlier Previously, the window was opened only once the first frame was available. Instead, open it as soon as the frame dimensions are known. This is especially useful when the encoder does not produce an initial frame while the phone is turned off (e.g., with `--no-power-on`). Fi...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/src/` needed for: Open the scrcpy window earlier", "scope_files": [ "app/src/events.h", "app/src/screen.c", "app/src/screen.h" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "app/src/events.h", "app/src/screen.c", "app/src/screen.h" ], "solution_diff": "diff --git a/app/src/events.h b/app/src/events.h\nindex 8667bc5796..567268ab7f 100644\n--- a/app/src/events.h\n+++ b/app/src/events.h\n@@ -9,6 +9,7 @@\n \n enum {\...
[ { "subtask_id": "s1", "comment": "```suggestion\n struct sc_size render_size = sc_sdl_get_render_output_size(renderer);\n```", "revised_diff": "diff --git a/app/src/screen.c b/app/src/screen.c\nindex d78dff7bc5..d50b670f89 100644\n--- a/app/src/screen.c\n+++ b/app/src/screen.c\n@@ -198,19 +198,30...
diff --git a/app/src/events.h b/app/src/events.h index 8667bc5796..567268ab7f 100644 --- a/app/src/events.h +++ b/app/src/events.h @@ -9,6 +9,7 @@ enum { SC_EVENT_NEW_FRAME = SDL_EVENT_USER, + SC_EVENT_OPEN_WINDOW, SC_EVENT_RUN_ON_MAIN_THREAD, SC_EVENT_DEVICE_DISCONNECTED, SC_EVENT_SERVER_CONN...
1
3
Genymobile/scrcpy#6667
Genymobile/scrcpy
6,667
f91fa56593ecf1b6b5355b000899fbcc465e845b
8b0206f7bea4929829da09d1ebe0492bcb60e57f
Keep Windows terminal open on error by default If scrcpy is launched by double-clicking `scrcpy.exe` in Windows Explorer, automatically set `--pause-on-exit=if-error`. Without this, the terminal would close immediately, preventing the user from seeing the error. Also remove `scrcpy-console.bat`, which is now use...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/data/` needed for: Keep Windows terminal open on error by default", "scope_files": [ "app/data/scrcpy-console.bat" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/src/` needed for: Keep Windows ter...
[ { "subtask_id": "s1", "scope_files": [ "app/data/scrcpy-console.bat" ], "solution_diff": "diff --git a/app/data/scrcpy-console.bat b/app/data/scrcpy-console.bat\ndeleted file mode 100644\nindex 0ea7619f4a..0000000000\n--- a/app/data/scrcpy-console.bat\n+++ /dev/null\n@@ -1,2 +0,0 @@\n-@echo of...
[ { "subtask_id": "s3", "comment": "```suggestion\n`scrcpy-noconsole.vbs` and add the desired arguments.\n```", "revised_diff": "diff --git a/doc/windows.md b/doc/windows.md\nindex cdc30bdce9..b0c4c5ca98 100644\n--- a/doc/windows.md\n+++ b/doc/windows.md\n@@ -72,18 +72,6 @@ Documentation for command line ...
diff --git a/app/data/scrcpy-console.bat b/app/data/scrcpy-console.bat deleted file mode 100644 index 0ea7619f4a..0000000000 --- a/app/data/scrcpy-console.bat +++ /dev/null @@ -1,2 +0,0 @@ -@echo off -scrcpy.exe --pause-on-exit=if-error %* diff --git a/app/src/cli.c b/app/src/cli.c index 9c955fb532..c3a955832d 100644...
4
6