task_id
stringlengths
10
58
repo
stringclasses
854 values
pr_number
int32
1
321k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
task
stringlengths
2
105k
plan
listlengths
1
100
subagents
listlengths
1
100
revisions
listlengths
0
100
final_diff
stringlengths
256
202M
num_subtasks
int32
1
100
num_changed_files
int32
2
100
Genymobile/scrcpy#6671
Genymobile/scrcpy
6,671
90d11810e3eaa2938459752ec2fdaf0b61395cca
323549e82f0604400b487ec6cfa5d2640a20b6ee
Prevent build from falling back to system libs Ensure that if a file or function is not found, the build does not attempt to use system libraries. Falling back could introduce incompatible versions or libraries compiles with different features.
[ { "subtask_id": "s1", "goal": "Implement the changes under `release/` needed for: Prevent build from falling back to system libs", "scope_files": [ "release/build_linux.sh", "release/build_macos.sh", "release/build_windows.sh" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "release/build_linux.sh", "release/build_macos.sh", "release/build_windows.sh" ], "solution_diff": "diff --git a/release/build_linux.sh b/release/build_linux.sh\nindex 6bca6979d7..e83d355e00 100755\n--- a/release/build_linux.sh\n+++ b/release/...
[]
diff --git a/release/build_linux.sh b/release/build_linux.sh index 6bca6979d7..e83d355e00 100755 --- a/release/build_linux.sh +++ b/release/build_linux.sh @@ -22,9 +22,12 @@ app/deps/libusb.sh linux native static DEPS_INSTALL_DIR="$PWD/app/deps/work/install/linux-native-static" ADB_INSTALL_DIR="$PWD/app/deps/work/ins...
1
3
Genymobile/scrcpy#6664
Genymobile/scrcpy
6,664
e39d7a06e461c5731dc0529dfa3240a2f5f1c13e
82e102e036c7b983ea8a1af418213fd0c31bd7d0
Improve adb devices parsing `adb devices -l` prints one device per line, containing, separated by spaces: - the device serial, - the device state, - a list of key:value pairs. However, the device serial itself may contain spaces, making a simple split ambiguous. To avoid ambiguity, parse the string backwar...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/src/adb/` needed for: Improve adb devices parsing", "scope_files": [ "app/src/adb/adb_parser.c" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/tests/` needed for: Improve adb devices parsing", ...
[ { "subtask_id": "s1", "scope_files": [ "app/src/adb/adb_parser.c" ], "solution_diff": "diff --git a/app/src/adb/adb_parser.c b/app/src/adb/adb_parser.c\nindex 90a1b30b9a..72fd141d60 100644\n--- a/app/src/adb/adb_parser.c\n+++ b/app/src/adb/adb_parser.c\n@@ -8,6 +8,49 @@\n #include \"util/log.h...
[ { "subtask_id": "s1", "comment": "When using libusb backend (`$ADB_LIBUSB=1` or default on some [older versions](https://developer.android.com/tools/releases/platform-tools#3500_february_2024)) the devpath doesn't have a colon:\n\n```txt\n$ adb devices -l\nList of devices attached\nbd9d00cc de...
diff --git a/app/src/adb/adb_parser.c b/app/src/adb/adb_parser.c index 90a1b30b9a..72fd141d60 100644 --- a/app/src/adb/adb_parser.c +++ b/app/src/adb/adb_parser.c @@ -8,6 +8,49 @@ #include "util/log.h" #include "util/str.h" +static size_t +rstrip_len(const char *s, size_t len) { + size_t i = len; + + // Ignor...
2
2
Genymobile/scrcpy#6663
Genymobile/scrcpy
6,663
bb6d1c634834d6262d8daee6a162ce53311c976f
e39d7a06e461c5731dc0529dfa3240a2f5f1c13e
Properly serialize command line arguments for Windows Scrcpy exposes a process API to execute commands: https://github.com/Genymobile/scrcpy/blob/c8c1316db9adefca6aae054be936049c2f8e02f1/app/src/util/process.h#L72-L95 In practice, it is only used to execute simple `adb` commands, so the Windows implementation wa...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Properly serialize command line arguments for Windows", "scope_files": [ "app/meson.build" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/src/adb/` needed for: Properly serialize com...
[ { "subtask_id": "s1", "scope_files": [ "app/meson.build" ], "solution_diff": "diff --git a/app/meson.build b/app/meson.build\nindex c730ce0755..35c2e3eac9 100644\n--- a/app/meson.build\n+++ b/app/meson.build\n@@ -75,6 +75,7 @@ conf.set('_GNU_SOURCE', true)\n if host_machine.system() == 'window...
[]
diff --git a/app/meson.build b/app/meson.build index c730ce0755..35c2e3eac9 100644 --- a/app/meson.build +++ b/app/meson.build @@ -75,6 +75,7 @@ conf.set('_GNU_SOURCE', true) if host_machine.system() == 'windows' windows = import('windows') src += [ + 'src/util/command.c', 'src/sys/win/file.c...
5
9
Genymobile/scrcpy#6651
Genymobile/scrcpy
6,651
c497718a3e3617c60a2d7cc8decfa9adc32d05d2
77998f543f4b1dfb5e3c1863593190c2711253b0
Refactor: Move rendering to sc_screen and introduce sc_texture Three components are involved in displaying device content on screen: - a window - a renderer - a texture Originally, all three were handled by `sc_screen`. Commit 051b74c88338702508d98bd532057b343e0a177c later extracted the renderer and textur...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Refactor: Move rendering to sc_screen and introduce sc_texture", "scope_files": [ "app/meson.build" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/src/` needed for: Refactor: Move re...
[ { "subtask_id": "s1", "scope_files": [ "app/meson.build" ], "solution_diff": "diff --git a/app/meson.build b/app/meson.build\nindex 36b72cfdbe..c730ce0755 100644\n--- a/app/meson.build\n+++ b/app/meson.build\n@@ -15,7 +15,6 @@ src = [\n 'src/delay_buffer.c',\n 'src/demuxer.c',\n 's...
[]
diff --git a/app/meson.build b/app/meson.build index 36b72cfdbe..c730ce0755 100644 --- a/app/meson.build +++ b/app/meson.build @@ -15,7 +15,6 @@ src = [ 'src/delay_buffer.c', 'src/demuxer.c', 'src/device_msg.c', - 'src/display.c', 'src/events.c', 'src/icon.c', 'src/file_pusher.c', @@ -3...
3
10
Genymobile/scrcpy#6649
Genymobile/scrcpy
6,649
1a99a46b574ff3beac20ec1cbc71ad9c24c90258
07f056353bf4295c3721dac066bd2cc1b9f7ae04
Refactor: Use common sc_screen for normal and OTG modes Originally, the default scrcpy window always displayed the video stream. Since the OTG mode window only contains the scrcpy logo, it was implemented as a separate component (91418c79ab3b7056c21ef6c64f903704c8f00a52). Later, the `--no-video` option was added (8...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Refactor: Use common sc_screen for normal and OTG modes", "scope_files": [ "app/meson.build" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/src/` needed for: Refactor: Use common sc_...
[ { "subtask_id": "s1", "scope_files": [ "app/meson.build" ], "solution_diff": "diff --git a/app/meson.build b/app/meson.build\nindex 6f6f64c19d..36b72cfdbe 100644\n--- a/app/meson.build\n+++ b/app/meson.build\n@@ -104,7 +104,6 @@ if usb_support\n 'src/usb/keyboard_aoa.c',\n 'src...
[]
diff --git a/app/meson.build b/app/meson.build index 6f6f64c19d..36b72cfdbe 100644 --- a/app/meson.build +++ b/app/meson.build @@ -104,7 +104,6 @@ if usb_support 'src/usb/keyboard_aoa.c', 'src/usb/mouse_aoa.c', 'src/usb/scrcpy_otg.c', - 'src/usb/screen_otg.c', 'src/usb/usb.c',...
3
5
Genymobile/scrcpy#6159
Genymobile/scrcpy
6,159
f4cc07da24939890e546f6be972ca9ad15b7621e
826076f753832789d3b879c4215efcf616e49e61
Add session metadata for video stream Introduce a new packet type, a "session" packet, containing metadata about the encoding session. It is used only for the video stream, and currently includes the video resolution. For illustration, here is a sequence of packets on the video stream: ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/src/` needed for: Add session metadata for video stream", "scope_files": [ "app/src/audio_player.c", "app/src/decoder.c", "app/src/decoder.h", "app/src/delay_buffer.c", "app/src/delay_buffer.h", "app/src/...
[ { "subtask_id": "s1", "scope_files": [ "app/src/audio_player.c", "app/src/decoder.c", "app/src/decoder.h", "app/src/delay_buffer.c", "app/src/delay_buffer.h", "app/src/demuxer.c", "app/src/recorder.c", "app/src/screen.c", "app/src/v4l2_sink.c" ], ...
[]
diff --git a/app/src/audio_player.c b/app/src/audio_player.c index 3e88ea453f..270e29d496 100644 --- a/app/src/audio_player.c +++ b/app/src/audio_player.c @@ -47,7 +47,10 @@ sc_audio_player_frame_sink_push(struct sc_frame_sink *sink, static bool sc_audio_player_frame_sink_open(struct sc_frame_sink *sink, - ...
6
20
Genymobile/scrcpy#5870
Genymobile/scrcpy
5,870
c63d9e1803c658b29b067d5ea68baa38df7e1359
bef2d8473b3426b1dd2ea9ed0cae3a243a999218
[Feature request] option to choose unprocessed microphone output of phone (and other processing options) I would like to have an option to remove the processing applied by the phone to it's microphone before being send via scrcpy. by selecting a flag for example --mic-processing process ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: [Feature request] option to choose unprocessed microphone output of phone (and other processing options)", "scope_files": [ "app/scrcpy.1" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `...
[ { "subtask_id": "s1", "scope_files": [ "app/scrcpy.1" ], "solution_diff": "diff --git a/app/scrcpy.1 b/app/scrcpy.1\nindex 5eea94f4ce..ffb66ab9ed 100644\n--- a/app/scrcpy.1\n+++ b/app/scrcpy.1\n@@ -67,13 +67,19 @@ The available encoders can be listed by \\fB\\-\\-list\\-encoders\\fR.\n \n .TP\...
[]
diff --git a/app/data/bash-completion/scrcpy b/app/data/bash-completion/scrcpy index 8d149f9745..9918918c36 100644 --- a/app/data/bash-completion/scrcpy +++ b/app/data/bash-completion/scrcpy @@ -122,7 +122,7 @@ _scrcpy() { return ;; --audio-source) - COMPREPLY=($(compgen -W...
8
15
Genymobile/scrcpy#6172
Genymobile/scrcpy
6,172
98d30288f78b0dd40ae1aa1b285c45f5769f49fc
b81e0f92b59fe3d3e76fcd67b39d4d484e7f13ae
Improve/fix mouse scrolling support Scrolling values reported by SDL can produce fractional values (like 0.05, when precise scrolling is enabled), and also values greater than 1 or less than -1. Currently, the reported value was clamped to [-1, 1]. To support larger values, extend the range to [-16, 16] for SDK mou...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/src/` needed for: Improve/fix mouse scrolling support", "scope_files": [ "app/src/control_msg.c", "app/src/input_events.h", "app/src/input_manager.c" ] }, { "subtask_id": "s2", "goal": "Implement the change...
[ { "subtask_id": "s1", "scope_files": [ "app/src/control_msg.c", "app/src/input_events.h", "app/src/input_manager.c" ], "solution_diff": "diff --git a/app/src/control_msg.c b/app/src/control_msg.c\nindex e78f0c573e..e46c61656d 100644\n--- a/app/src/control_msg.c\n+++ b/app/src/contr...
[]
diff --git a/app/src/control_msg.c b/app/src/control_msg.c index e78f0c573e..e46c61656d 100644 --- a/app/src/control_msg.c +++ b/app/src/control_msg.c @@ -127,10 +127,14 @@ sc_control_msg_serialize(const struct sc_control_msg *msg, uint8_t *buf) { return 32; case SC_CONTROL_MSG_TYPE_INJECT_SCROLL_...
5
9
Genymobile/scrcpy#5154
Genymobile/scrcpy
5,154
f691ebb1b4fde44789292d1e8ed41adaee8e6854
2b6089cbfc29c41643e0c0e8049bda3ede777b61
Enable workarounds by default Workarounds were disabled by default, and enabled only on some device or in specific conditions. But it seems they are needed for more and more devices, so enable them by default. They could be disabled for specific devices if necessary in the future. In the past, these workarounds ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `server/src/main/java/com/genymobile/scrcpy/` needed for: Enable workarounds by default", "scope_files": [ "server/src/main/java/com/genymobile/scrcpy/Server.java", "server/src/main/java/com/genymobile/scrcpy/Workarounds.java" ] ...
[ { "subtask_id": "s1", "scope_files": [ "server/src/main/java/com/genymobile/scrcpy/Server.java", "server/src/main/java/com/genymobile/scrcpy/Workarounds.java" ], "solution_diff": "diff --git a/server/src/main/java/com/genymobile/scrcpy/Server.java b/server/src/main/java/com/genymobile/sc...
[]
diff --git a/server/src/main/java/com/genymobile/scrcpy/Server.java b/server/src/main/java/com/genymobile/scrcpy/Server.java index 11429e6ce8..7817fdf5b9 100644 --- a/server/src/main/java/com/genymobile/scrcpy/Server.java +++ b/server/src/main/java/com/genymobile/scrcpy/Server.java @@ -144,7 +144,7 @@ private static vo...
1
2
Genymobile/scrcpy#5102
Genymobile/scrcpy
5,102
9d1d79b004ed7171f481225993d54c3b100411a7
ed4066902d08e4abb91b4b6c7d828f190ab65bfb
Add option to keep audio playing on device while mirroring Add a new method to capture audio on the device, provided by @yume-chan in #4380. It is exposed as a separate audio source (in addition to `output` and `mic`): ``` scrcpy --audio-source=playback ``` There are pros and cons, as noted by @yume-chan: ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Add option to keep audio playing on device while mirroring", "scope_files": [ "app/scrcpy.1" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/data/bash-completion/` needed for: Add opt...
[ { "subtask_id": "s1", "scope_files": [ "app/scrcpy.1" ], "solution_diff": "diff --git a/app/scrcpy.1 b/app/scrcpy.1\nindex 1c0c0f7aff..de2b8ac687 100644\n--- a/app/scrcpy.1\n+++ b/app/scrcpy.1\n@@ -49,6 +49,12 @@ The list of possible codec options is available in the Android documentation:\n \...
[]
diff --git a/app/data/bash-completion/scrcpy b/app/data/bash-completion/scrcpy index b35ea5e488..e0928cbd72 100644 --- a/app/data/bash-completion/scrcpy +++ b/app/data/bash-completion/scrcpy @@ -6,6 +6,7 @@ _scrcpy() { --audio-buffer= --audio-codec= --audio-codec-options= + --audio-dup...
7
23
Genymobile/scrcpy#5076
Genymobile/scrcpy
5,076
b50f9eb41d1bd7b75a77e2c388b0144365e3cd5f
9989668226f100534452e0af812807562ff5212f
Feature Request: Keyboard Shortcut for Forwarding Clicks A feature request posted on [reddit](https://www.reddit.com/r/scrcpy/comments/1dtwr1l/feature_request_keyboard_shortcut_for_forwarding/): > So with the recent Scrcpy release, the forwarding clicks behavior changed. So I added this: > > --mouse-bind=bhsn...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Feature Request: Keyboard Shortcut for Forwarding Clicks", "scope_files": [ "app/scrcpy.1" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/src/` needed for: Feature Request: Keyboard ...
[ { "subtask_id": "s1", "scope_files": [ "app/scrcpy.1" ], "solution_diff": "diff --git a/app/scrcpy.1 b/app/scrcpy.1\nindex cf8dfa7fe4..1c0c0f7aff 100644\n--- a/app/scrcpy.1\n+++ b/app/scrcpy.1\n@@ -258,10 +258,14 @@ LAlt, LSuper or RSuper toggle the capture mode, to give control of the mouse b...
[]
diff --git a/app/scrcpy.1 b/app/scrcpy.1 index cf8dfa7fe4..1c0c0f7aff 100644 --- a/app/scrcpy.1 +++ b/app/scrcpy.1 @@ -258,10 +258,14 @@ LAlt, LSuper or RSuper toggle the capture mode, to give control of the mouse bac Also see \fB\-\-keyboard\fR. .TP -.BI "\-\-mouse\-bind " xxxx +.BI "\-\-mouse\-bind " xxxx[:xxxx] ...
5
12
Genymobile/scrcpy#5044
Genymobile/scrcpy
5,044
a4f8c025027964a9978925396459d36b8337623d
b419eef55e19a4700af3ea0a170d8d0a9ce6bd16
Do not report controller error on device disconnected A device disconnection (when the adb connection is closed) makes the `read()` on the "receiver" socket fail. Since commit 063a8339ed27b94a8fe1e53a284507eb2d044e15, this is reported as an error. As a consequence, scrcpy fails with: ERROR: Controlle...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/src/` needed for: Do not report controller error on device disconnected", "scope_files": [ "app/src/controller.c", "app/src/controller.h", "app/src/receiver.c", "app/src/receiver.h", "app/src/scrcpy.c" ] ...
[ { "subtask_id": "s1", "scope_files": [ "app/src/controller.c", "app/src/controller.h", "app/src/receiver.c", "app/src/receiver.h", "app/src/scrcpy.c" ], "solution_diff": "diff --git a/app/src/controller.c b/app/src/controller.c\nindex edd767eb1b..d50e1921cb 100644\n--- ...
[]
diff --git a/app/src/controller.c b/app/src/controller.c index edd767eb1b..d50e1921cb 100644 --- a/app/src/controller.c +++ b/app/src/controller.c @@ -7,12 +7,13 @@ #define SC_CONTROL_MSG_QUEUE_MAX 64 static void -sc_controller_receiver_on_error(struct sc_receiver *receiver, void *userdata) { +sc_controller_receive...
1
5
Genymobile/scrcpy#5039
Genymobile/scrcpy
5,039
f5e6b8092afd82bab402e7c2c3d00b1719f9bb57
76332282783f72bc611dcb1b871f4baacd59de1d
Forward mouse hover events Also add an option `--no-mouse-hover` to get the old behavior. Fixes #2743 Fixes #3070
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Forward mouse hover events", "scope_files": [ "app/scrcpy.1" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/data/bash-completion/` needed for: Forward mouse hover events", "scope...
[ { "subtask_id": "s1", "scope_files": [ "app/scrcpy.1" ], "solution_diff": "diff --git a/app/scrcpy.1 b/app/scrcpy.1\nindex b2021f26ce..cf8dfa7fe4 100644\n--- a/app/scrcpy.1\n+++ b/app/scrcpy.1\n@@ -317,6 +317,10 @@ Do not forward repeated key events when a key is held down.\n .B \\-\\-no\\-mip...
[]
diff --git a/app/data/bash-completion/scrcpy b/app/data/bash-completion/scrcpy index f00fadaeba..b35ea5e488 100644 --- a/app/data/bash-completion/scrcpy +++ b/app/data/bash-completion/scrcpy @@ -50,6 +50,7 @@ _scrcpy() { --no-downsize-on-error --no-key-repeat --no-mipmaps + --no-mouse-...
5
10
Genymobile/scrcpy#5022
Genymobile/scrcpy
5,022
40493dff608cda7f0f37c166a2d8fef92581acf0
f5e6b8092afd82bab402e7c2c3d00b1719f9bb57
Add option to configure mouse bindings The argument must be exactly 4 characters, one for each secondary click: --mouse-bind=xxxx ^^^^ |||| ||| `- 5th click || `-- 4th click | `--- middle click `---- rig...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Add option to configure mouse bindings", "scope_files": [ "app/scrcpy.1" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/data/bash-completion/` needed for: Add option to configure mou...
[ { "subtask_id": "s1", "scope_files": [ "app/scrcpy.1" ], "solution_diff": "diff --git a/app/scrcpy.1 b/app/scrcpy.1\nindex 2be9ef59d6..b2021f26ce 100644\n--- a/app/scrcpy.1\n+++ b/app/scrcpy.1\n@@ -163,10 +163,6 @@ Start in fullscreen.\n .B \\-\\-force\\-adb\\-forward\n Do not attempt to use \...
[]
diff --git a/app/data/bash-completion/scrcpy b/app/data/bash-completion/scrcpy index e6b2c91a96..f00fadaeba 100644 --- a/app/data/bash-completion/scrcpy +++ b/app/data/bash-completion/scrcpy @@ -25,7 +25,6 @@ _scrcpy() { -e --select-tcpip -f --fullscreen --force-adb-forward - --forward...
6
15
Genymobile/scrcpy#4868
Genymobile/scrcpy
4,868
22d78e8a82bc3d6d1c18a1cc419be536201a003c
063a8339ed27b94a8fe1e53a284507eb2d044e15
Add scrcpy window without video playback Add the possibility to solely control the device without screen mirroring: scrcpy --no-video --no-audio This is different from OTG mode, which does not require USB debugging at all. Here, it is just the standard mode but with the possibility to disable video playb...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Add scrcpy window without video playback", "scope_files": [ "app/scrcpy.1" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/src/` needed for: Add scrcpy window without video playback",...
[ { "subtask_id": "s1", "scope_files": [ "app/scrcpy.1" ], "solution_diff": "diff --git a/app/scrcpy.1 b/app/scrcpy.1\nindex eb09f53081..f9ef3498af 100644\n--- a/app/scrcpy.1\n+++ b/app/scrcpy.1\n@@ -316,6 +316,10 @@ Disable video forwarding.\n .B \\-\\-no\\-video\\-playback\n Disable video play...
[]
diff --git a/app/scrcpy.1 b/app/scrcpy.1 index eb09f53081..f9ef3498af 100644 --- a/app/scrcpy.1 +++ b/app/scrcpy.1 @@ -316,6 +316,10 @@ Disable video forwarding. .B \-\-no\-video\-playback Disable video playback on the computer. +.TP +.B \-\-no\-window +Disable scrcpy window. Implies --no-video-playback and --no-co...
3
20
Genymobile/scrcpy#4748
Genymobile/scrcpy
4,748
be3d357a6dcdf0f3fccabd795b869a30e1e5bee1
1c3801a0b1624258e5004e651c9dbcff7eafe324
Pause and resume screen mirroring using a shortcut - [X] I have checked that a similar [feature request](https://github.com/Genymobile/scrcpy/issues?q=is%3Aopen+is%3Aissue+label%3A%22feature+request%22) does not already exist. **Is your feature request related to a problem? Please describe.** Oftentimes, I find m...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Pause and resume screen mirroring using a shortcut", "scope_files": [ "app/scrcpy.1" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/src/` needed for: Pause and resume screen mirrorin...
[ { "subtask_id": "s1", "scope_files": [ "app/scrcpy.1" ], "solution_diff": "diff --git a/app/scrcpy.1 b/app/scrcpy.1\nindex 1e3c91b1ce..eb09f53081 100644\n--- a/app/scrcpy.1\n+++ b/app/scrcpy.1\n@@ -577,6 +577,14 @@ Flip display horizontally\n .B MOD+Shift+Up, MOD+Shift+Down\n Flip display vert...
[]
diff --git a/app/scrcpy.1 b/app/scrcpy.1 index 1e3c91b1ce..eb09f53081 100644 --- a/app/scrcpy.1 +++ b/app/scrcpy.1 @@ -577,6 +577,14 @@ Flip display horizontally .B MOD+Shift+Up, MOD+Shift+Down Flip display vertically +.TP +.B MOD+z +Pause or re-pause display + +.TP +.B MOD+Shift+z +Unpause display + .TP .B MOD+g...
3
6
Genymobile/scrcpy#4741
Genymobile/scrcpy
4,741
592ca0b59b3f57e6d721a57554e0efc5a52bb70f
0b926922bc169eab704f9805e6d35f79f7a1aa95
Simplify/restrict shortcut mods Restrict shortcut modifiers to be composed of only one item each. Currently, it is possible to select a list of multiple combinations of modifier keys, like `--shortcut-mod='lctrl+lalt,rctrl+rsuper'`, meaning that shortcuts would be triggered either by <kbd>LCtrl</kbd>+<kbd>LAlt<...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/` needed for: Simplify/restrict shortcut mods", "scope_files": [ "app/scrcpy.1" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/src/` needed for: Simplify/restrict shortcut mods", "scope_files"...
[ { "subtask_id": "s1", "scope_files": [ "app/scrcpy.1" ], "solution_diff": "diff --git a/app/scrcpy.1 b/app/scrcpy.1\nindex f9ef3498af..2be9ef59d6 100644\n--- a/app/scrcpy.1\n+++ b/app/scrcpy.1\n@@ -424,9 +424,9 @@ Turn the device screen off immediately.\n .BI \"\\-\\-shortcut\\-mod \" key\\fR[...
[]
diff --git a/app/scrcpy.1 b/app/scrcpy.1 index f9ef3498af..2be9ef59d6 100644 --- a/app/scrcpy.1 +++ b/app/scrcpy.1 @@ -424,9 +424,9 @@ Turn the device screen off immediately. .BI "\-\-shortcut\-mod " key\fR[+...]][,...] Specify the modifiers to use for scrcpy shortcuts. Possible keys are "lctrl", "rctrl", "lalt", "ra...
4
11
Genymobile/scrcpy#4713
Genymobile/scrcpy
4,713
36189b90ea815d8fced961c36c80f146d5952324
8d87b91f692914ada1c146bd911ab4623552174b
Build all dependencies for Windows releases Remove the mechanism to download (and link against) pre-built dependencies, and add a new mechanism to download the dependencies sources and build them. Executing `./release.sh` builds everything. Here are 32-bit and 64-bit Windows binaries for the current `dev` branch...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Build all dependencies for Windows releases", "scope_files": [ "release.mk" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/deps/` needed for: Build all dependencies for Windows re...
[ { "subtask_id": "s1", "scope_files": [ "release.mk" ], "solution_diff": "diff --git a/release.mk b/release.mk\nindex fd969e5a63..89f3da215a 100644\n--- a/release.mk\n+++ b/release.mk\n@@ -62,38 +62,38 @@ build-server:\n \t\tmeson setup \"$(SERVER_BUILD_DIR)\" --buildtype release -Dcompile_app=...
[ { "subtask_id": "s2", "comment": "The source release is the .bz2 file, also available on SourceForge https://sourceforge.net/projects/libusb/files/libusb-1.0/", "revised_diff": "diff --git a/app/deps/libusb.sh b/app/deps/libusb.sh\nnew file mode 100755\nindex 0000000000..97fc3c72fb\n--- /dev/null\n+++ b...
diff --git a/app/deps/.gitignore b/app/deps/.gitignore new file mode 100644 index 0000000000..ccf6a49e2d --- /dev/null +++ b/app/deps/.gitignore @@ -0,0 +1,1 @@ +/work diff --git a/app/deps/README b/app/deps/README new file mode 100644 index 0000000000..9cfb5c06a1 --- /dev/null +++ b/app/deps/README @@ -0,0 +1,27 @@ +T...
4
15
Genymobile/scrcpy#4649
Genymobile/scrcpy
4,649
be3f949aa5c4dcad276ac0f2b36671a3309ce12f
9efa162949c2a3e3e42564862ff390700270394d
Configure clean up actions dynamically Some actions may be performed when scrcpy exits, currently: - disable "show touches" - restore "stay on while plugged in" - power off screen - restore "power mode" (to disable "turn screen off") They are performed from a separate process so that they can be executed ev...
[ { "subtask_id": "s1", "goal": "Implement the changes under `server/src/main/java/com/genymobile/scrcpy/` needed for: Configure clean up actions dynamically", "scope_files": [ "server/src/main/java/com/genymobile/scrcpy/CleanUp.java", "server/src/main/java/com/genymobile/scrcpy/Controller.jav...
[ { "subtask_id": "s1", "scope_files": [ "server/src/main/java/com/genymobile/scrcpy/CleanUp.java", "server/src/main/java/com/genymobile/scrcpy/Controller.java", "server/src/main/java/com/genymobile/scrcpy/Server.java" ], "solution_diff": "diff --git a/server/src/main/java/com/genymo...
[]
diff --git a/server/src/main/java/com/genymobile/scrcpy/CleanUp.java b/server/src/main/java/com/genymobile/scrcpy/CleanUp.java index c84e25bb89..f9b1efd6e1 100644 --- a/server/src/main/java/com/genymobile/scrcpy/CleanUp.java +++ b/server/src/main/java/com/genymobile/scrcpy/CleanUp.java @@ -1,11 +1,8 @@ package com.gen...
1
3
GoogleChrome/lighthouse#17073
GoogleChrome/lighthouse
17,073
c0ac986843022ab015a0d6e7dbe8a69166ca7358
0dbad9a903b601d072e35651e8937bb96b4de738
v13.4.0
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: v13.4.0", "scope_files": [ "changelog.md", "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `core/test/fixtures/user-flows/reports/` needed for: v13.4.0", "scope...
[ { "subtask_id": "s1", "scope_files": [ "changelog.md", "package.json" ], "solution_diff": "diff --git a/changelog.md b/changelog.md\nindex 60d8af64f401..810031092e08 100644\n--- a/changelog.md\n+++ b/changelog.md\n@@ -1,3 +1,75 @@\n+<a name=\"13.4.0\"></a>\n+# 13.4.0 (2026-06-09)\n+[Full...
[]
diff --git a/changelog.md b/changelog.md index 60d8af64f401..810031092e08 100644 --- a/changelog.md +++ b/changelog.md @@ -1,3 +1,75 @@ +<a name="13.4.0"></a> +# 13.4.0 (2026-06-09) +[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v13.3.0...v13.4.0) + +We expect this release to ship in the DevTools ...
6
7
GoogleChrome/lighthouse#17071
GoogleChrome/lighthouse
17,071
6894326a9ae5764e92d074a1748603b56f9668fd
be5d571677f2bdc2dea495eeb3b0d6ed95289e32
i18n: import
[ { "subtask_id": "s1", "goal": "Implement the changes under `shared/localization/locales/` needed for: i18n: import", "scope_files": [ "shared/localization/locales/ar-XB.json", "shared/localization/locales/ar.json", "shared/localization/locales/bg.json", "shared/localization/local...
[ { "subtask_id": "s1", "scope_files": [ "shared/localization/locales/ar-XB.json", "shared/localization/locales/ar.json", "shared/localization/locales/bg.json", "shared/localization/locales/ca.json", "shared/localization/locales/cs.json", "shared/localization/locales/da.jso...
[]
diff --git a/shared/localization/locales/ar-XB.json b/shared/localization/locales/ar-XB.json index 2c4650c2b472..e5a257558648 100644 --- a/shared/localization/locales/ar-XB.json +++ b/shared/localization/locales/ar-XB.json @@ -206,6 +206,15 @@ "core/audits/accessibility/aria-valid-attr.js | title": { "message":...
1
46
GoogleChrome/lighthouse#17070
GoogleChrome/lighthouse
17,070
2a5241417d3e35ecb323a2388637b06ba27dc619
7c17d3ec825b220d4a3a922df44fba42bb4f2452
deps: upgrade deps ```diff - "axe-core": "^4.11.4", - "chrome-devtools-frontend": "1.0.1625854", - "csp_evaluator": "1.1.5", - "third-party-web": "^0.29.0", - "tldts-icann": "^7.0.30", - "web-features": "^3.26.0", + "axe-core": "^4.12.0", + "chrome-devtools-frontend": "1.0.1642845", ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: deps: upgrade deps", "scope_files": [ "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `core/audits/accessibility/` needed for: deps: upgrade deps", "scope_files": [ ...
[ { "subtask_id": "s1", "scope_files": [ "package.json" ], "solution_diff": "diff --git a/package.json b/package.json\nindex 69a79a134d8f..101b7c05b22f 100644\n--- a/package.json\n+++ b/package.json\n@@ -138,7 +138,7 @@\n \"archiver\": \"^7.0.1\",\n \"builtin-modules\": \"^3.3.0\",\n ...
[]
diff --git a/core/audits/accessibility/accesskeys.js b/core/audits/accessibility/accesskeys.js index 56f44fd25d54..8238d16909dd 100644 --- a/core/audits/accessibility/accesskeys.js +++ b/core/audits/accessibility/accesskeys.js @@ -20,7 +20,7 @@ const UIStrings = { /** Description of a Lighthouse audit that tells the...
11
100
GoogleChrome/lighthouse#16774
GoogleChrome/lighthouse
16,774
85c711da09022748ec991ccfb6e019a0f50d7d7f
93ea5c537e90df537fce3cacfdd41a4dda374c33
core: match scripts to network requests using frameId Fixes a reporting issue in byte-efficiency audits (such as "Remove unused JavaScript") where cached duplicate script requests were reported with full network transfer sizes. ### Impact When a script is loaded in the main frame (network transfer) and subsequentl...
[ { "subtask_id": "s1", "goal": "Implement the changes under `core/audits/` needed for: core: match scripts to network requests using frameId", "scope_files": [ "core/audits/network-requests.js" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `core/lib/` needed for: c...
[ { "subtask_id": "s1", "scope_files": [ "core/audits/network-requests.js" ], "solution_diff": "diff --git a/core/audits/network-requests.js b/core/audits/network-requests.js\nindex c0296589d7c6..149dba518bea 100644\n--- a/core/audits/network-requests.js\n+++ b/core/audits/network-requests.js\n@...
[]
diff --git a/core/audits/network-requests.js b/core/audits/network-requests.js index c0296589d7c6..149dba518bea 100644 --- a/core/audits/network-requests.js +++ b/core/audits/network-requests.js @@ -70,6 +70,8 @@ class NetworkRequests extends Audit { url: UrlUtils.elideDataURI(record.url), sessionTarg...
5
5
GoogleChrome/lighthouse#16835
GoogleChrome/lighthouse
16,835
eb3d98ad56d93f271d3a674d20433d83b429c448
23118d5b950513b73733a14dd554089fd7d06461
core(geolocation-on-start): mention `geolocation` element Added a suggestion to use the <geolocation> element for better user experience. <!-- Thank you for submitting a pull request! See CONTRIBUTING.MD for help in getting a change landed. https://github.com/GoogleChrome/lighthouse/blob/main/CONTRIBUTING.md ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `core/audits/dobetterweb/` needed for: core(geolocation-on-start): mention `geolocation` element", "scope_files": [ "core/audits/dobetterweb/geolocation-on-start.js" ] }, { "subtask_id": "s2", "goal": "Implement the changes...
[ { "subtask_id": "s1", "scope_files": [ "core/audits/dobetterweb/geolocation-on-start.js" ], "solution_diff": "diff --git a/core/audits/dobetterweb/geolocation-on-start.js b/core/audits/dobetterweb/geolocation-on-start.js\nindex 7e6ce55b4832..aea3c98b51b4 100644\n--- a/core/audits/dobetterweb/g...
[]
diff --git a/core/audits/dobetterweb/geolocation-on-start.js b/core/audits/dobetterweb/geolocation-on-start.js index 7e6ce55b4832..aea3c98b51b4 100644 --- a/core/audits/dobetterweb/geolocation-on-start.js +++ b/core/audits/dobetterweb/geolocation-on-start.js @@ -21,7 +21,8 @@ const UIStrings = { /** Description of a...
4
5
GoogleChrome/lighthouse#17057
GoogleChrome/lighthouse
17,057
eb3d98ad56d93f271d3a674d20433d83b429c448
8c2f942d22e7aab8b135e2678cc19f24aaa1b50b
New llms.txt check fails for YOAST due to BOM ### FAQ - [x] Yes, my issue is not about [variability](https://github.com/GoogleChrome/lighthouse/blob/main/docs/variability.md) or [throttling](https://github.com/GoogleChrome/lighthouse/blob/main/docs/throttling.md). - [x] Yes, my issue is not about a specific accessibi...
[ { "subtask_id": "s1", "goal": "Implement the changes under `core/audits/agentic/` needed for: New llms.txt check fails for YOAST due to BOM", "scope_files": [ "core/audits/agentic/llms-txt.js" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `core/test/audits/agentic...
[ { "subtask_id": "s1", "scope_files": [ "core/audits/agentic/llms-txt.js" ], "solution_diff": "diff --git a/core/audits/agentic/llms-txt.js b/core/audits/agentic/llms-txt.js\nindex e19f031ede69..538481518650 100644\n--- a/core/audits/agentic/llms-txt.js\n+++ b/core/audits/agentic/llms-txt.js\n@...
[]
diff --git a/core/audits/agentic/llms-txt.js b/core/audits/agentic/llms-txt.js index e19f031ede69..538481518650 100644 --- a/core/audits/agentic/llms-txt.js +++ b/core/audits/agentic/llms-txt.js @@ -84,7 +84,7 @@ class LlmsTxt extends Audit { throw new Error(`Status ${status} was valid, but content was null`); ...
2
2
GoogleChrome/lighthouse#17064
GoogleChrome/lighthouse
17,064
a218df7cf8d2c423cb252b99c29ddcffeac4410b
298636d9e341ef20e2416825c6fb246894368eb2
Fail to load Github Gist URL in LH Viewer with 401 error. ### FAQ - [X] Yes, my issue is not about [variability](https://github.com/GoogleChrome/lighthouse/blob/master/docs/variability.md) or [throttling](https://github.com/GoogleChrome/lighthouse/blob/master/docs/throttling.md). - [X] Yes, my issue is not about a...
[ { "subtask_id": "s1", "goal": "Implement the changes under `viewer/app/src/` needed for: Fail to load Github Gist URL in LH Viewer with 401 error.", "scope_files": [ "viewer/app/src/firebase-auth.js", "viewer/app/src/github-api.js" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "viewer/app/src/firebase-auth.js", "viewer/app/src/github-api.js" ], "solution_diff": "diff --git a/viewer/app/src/firebase-auth.js b/viewer/app/src/firebase-auth.js\nindex be9031dbbf48..9a5982c1fa20 100644\n--- a/viewer/app/src/firebase-auth.js\n++...
[]
diff --git a/viewer/app/src/firebase-auth.js b/viewer/app/src/firebase-auth.js index be9031dbbf48..9a5982c1fa20 100644 --- a/viewer/app/src/firebase-auth.js +++ b/viewer/app/src/firebase-auth.js @@ -5,7 +5,7 @@ */ import {initializeApp} from 'firebase/app'; -import {getAuth, signInWithPopup, GithubAuthProvider} fr...
1
2
GoogleChrome/lighthouse#17061
GoogleChrome/lighthouse
17,061
0bf723095aeb031f3a8a0dc63b1479f736686481
cc6ab3fa27af4f5869b6074161387f4c5bfdfc38
misc: migrate typescript moduleResolution to bundler To address the deprecation of `moduleResolution=node10` in TypeScript 6+, this commit modernizes our configuration by moving to `"bundler"` resolution. This strategy correctly enforces package `exports` maps. Specific changes to support this strict resolutio...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: misc: migrate typescript moduleResolution to bundler", "scope_files": [ "package.json", "tsconfig-base.json", "yarn.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `ty...
[ { "subtask_id": "s1", "scope_files": [ "package.json", "tsconfig-base.json", "yarn.lock" ], "solution_diff": "diff --git a/package.json b/package.json\nindex f47a8949bf4a..69a79a134d8f 100644\n--- a/package.json\n+++ b/package.json\n@@ -124,6 +124,7 @@\n \"@types/mocha\": \"^9....
[]
diff --git a/package.json b/package.json index f47a8949bf4a..69a79a134d8f 100644 --- a/package.json +++ b/package.json @@ -124,6 +124,7 @@ "@types/mocha": "^9.0.0", "@types/node": "*", "@types/pako": "^1.0.1", + "@types/pg": "^8.20.0", "@types/resize-observer-browser": "^0.1.1", "@types/reso...
2
4
GoogleChrome/lighthouse#17060
GoogleChrome/lighthouse
17,060
71f281b40f364a328cb6a17c2d3efa668c7791b7
252e89e8bae0d16bab2987b6a8c47a40c9886dad
deps: upgrade typescript to 6.0.3 https://www.typescriptlang.org/docs/handbook/release-notes/typescript-6-0.html - Added "ignoreDeprecations": "6.0" to tsconfig-base.json to silence the moduleResolution=node10 deprecation warning. - Updated deprecated global module declarations to use the namespace keyword across ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: deps: upgrade typescript to 6.0.3", "scope_files": [ "package.json", "tsconfig-base.json", "yarn.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `clients/extension/scr...
[ { "subtask_id": "s1", "scope_files": [ "package.json", "tsconfig-base.json", "yarn.lock" ], "solution_diff": "diff --git a/package.json b/package.json\nindex 68da20645368..f47a8949bf4a 100644\n--- a/package.json\n+++ b/package.json\n@@ -109,7 +109,7 @@\n \"@testing-library/prea...
[]
diff --git a/clients/extension/scripts/popup.js b/clients/extension/scripts/popup.js index 2cd5be865bd7..43a3b7608066 100644 --- a/clients/extension/scripts/popup.js +++ b/clients/extension/scripts/popup.js @@ -4,6 +4,9 @@ * SPDX-License-Identifier: Apache-2.0 */ +// eslint-disable-next-line spaced-comment +/// <...
10
13
GoogleChrome/lighthouse#17059
GoogleChrome/lighthouse
17,059
0337a1a6abc5ac3c75d249d7ec57e03214420dd8
a6a9876e8d9dabfc9c66fd2301ae13c74e9a4635
deps: upgrade terser to 5.48.0 https://github.com/terser/terser/blob/master/CHANGELOG.md
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: deps: upgrade terser to 5.48.0", "scope_files": [ "package.json", "yarn.lock" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "package.json", "yarn.lock" ], "solution_diff": "diff --git a/package.json b/package.json\nindex f3d3fecf5ddf..68da20645368 100644\n--- a/package.json\n+++ b/package.json\n@@ -170,7 +170,7 @@\n \"resolve\": \"^1.22.10\",\n \"rollup-plugin-po...
[]
diff --git a/package.json b/package.json index f3d3fecf5ddf..68da20645368 100644 --- a/package.json +++ b/package.json @@ -170,7 +170,7 @@ "resolve": "^1.22.10", "rollup-plugin-polyfill-node": "^0.12.0", "source-map-support": "^0.5.21", - "terser": "^5.18.2", + "terser": "^5.48.0", "testdouble...
1
2
GoogleChrome/lighthouse#17058
GoogleChrome/lighthouse
17,058
7174701873b4168ff9cb0108f257564bd7f54a9c
415327f9a8580943001b00e0a218c6e61aefcf9d
deps: upgrade esbuild to 0.28.0 https://github.com/evanw/esbuild/blob/main/CHANGELOG.md
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: deps: upgrade esbuild to 0.28.0", "scope_files": [ "package.json", "yarn.lock" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "package.json", "yarn.lock" ], "solution_diff": "diff --git a/package.json b/package.json\nindex 2151d5c19c72..f3d3fecf5ddf 100644\n--- a/package.json\n+++ b/package.json\n@@ -144,7 +144,7 @@\n \"core-js-compat\": \"^3.44.0\",\n \"cpy\": \"^...
[]
diff --git a/package.json b/package.json index 2151d5c19c72..f3d3fecf5ddf 100644 --- a/package.json +++ b/package.json @@ -144,7 +144,7 @@ "core-js-compat": "^3.44.0", "cpy": "^8.1.2", "csv-validator": "^0.0.3", - "esbuild": "0.25.9", + "esbuild": "0.28.0", "eslint": "^9.28.0", "eslint-co...
1
2
GoogleChrome/lighthouse#17050
GoogleChrome/lighthouse
17,050
b5efe05b452780e5aed0f34fe45f58a4bb9ac6f2
5563257cb11947773623bc2a8e73e97bfa5867ef
core(driver): add ExecutionContext.evaluateOnObject This adds `ExecutionContext.evaluateOnObject` to wrap the CDP `Runtime.callFunctionOn` command, providing the same ergonomics, dependency serialization, and robust error handling as `.evaluate()`. Key benefits over raw `session.sendCommand` calls: - Protects na...
[ { "subtask_id": "s1", "goal": "Implement the changes under `build/test/` needed for: core(driver): add ExecutionContext.evaluateOnObject", "scope_files": [ "build/test/page-functions-test-case-computeBenchmarkIndex.js", "build/test/page-functions-test-case-getElementsInDocument.js", "b...
[ { "subtask_id": "s1", "scope_files": [ "build/test/page-functions-test-case-computeBenchmarkIndex.js", "build/test/page-functions-test-case-getElementsInDocument.js", "build/test/page-functions-test-case-getNodeDetails.js" ], "solution_diff": "diff --git a/build/test/page-functions...
[ { "subtask_id": "s2", "comment": "This was only here because direct callers of `Runtime.callFunctionOn` needed it to prevent minification errors from bundling / name mangling - but better to inject in `_callFunctionOn`. It also was already being done for `_evaluateInContext` (so it was sent twice for `evalu...
diff --git a/core/gather/driver/execution-context.js b/core/gather/driver/execution-context.js index 225dc4b9160c..9f76227d85dc 100644 --- a/core/gather/driver/execution-context.js +++ b/core/gather/driver/execution-context.js @@ -223,6 +223,7 @@ class ExecutionContext { const expression = `(() => { ${Exe...
6
12
GoogleChrome/lighthouse#17048
GoogleChrome/lighthouse
17,048
aef5a935f9ba467965e0c35f0f19c663b478e5b4
47d7149040cc0d8bbdeaddaf977d8845494f1b7d
lr-mobile-config.d.ts breaks TS builds: Cannot find namespace 'LH' ### FAQ - [x] Yes, my issue is not about [variability](https://github.com/GoogleChrome/lighthouse/blob/main/docs/variability.md) or [throttling](https://github.com/GoogleChrome/lighthouse/blob/main/docs/throttling.md). - [x] Yes, my issue is not about...
[ { "subtask_id": "s1", "goal": "Implement the changes under `core/config/` needed for: lr-mobile-config.d.ts breaks TS builds: Cannot find namespace 'LH'", "scope_files": [ "core/config/agentic-browsing-config.js", "core/config/config-helpers.js", "core/config/config-plugin.js", "...
[ { "subtask_id": "s1", "scope_files": [ "core/config/agentic-browsing-config.js", "core/config/config-helpers.js", "core/config/config-plugin.js", "core/config/config.js", "core/config/constants.js", "core/config/experimental-config.js", "core/config/filters.js", ...
[]
diff --git a/core/config/agentic-browsing-config.js b/core/config/agentic-browsing-config.js index fc26c9a75d8b..04772f842e1e 100644 --- a/core/config/agentic-browsing-config.js +++ b/core/config/agentic-browsing-config.js @@ -4,6 +4,7 @@ * SPDX-License-Identifier: Apache-2.0 */ +import * as LH from '../../types/...
1
12
GoogleChrome/lighthouse#17047
GoogleChrome/lighthouse
17,047
25c7b888dbda67b7ba394bca2bb9fc35695911dd
39fe9e1fd00300df2e356956a2b26bbe465cadd3
misc(build): generate subset of web-features data The web-features/data.json file is 5.1 MB, heavily inflating the bundle size. This commit introduces a build script to extract only the baseline statuses needed by the baseline audit, and groups them by tier ('high', 'low', 'limited') to further reduce their size on...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: misc(build): generate subset of web-features data", "scope_files": [ "package.json", "tsconfig.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `build/` needed for: misc(buil...
[ { "subtask_id": "s1", "scope_files": [ "package.json", "tsconfig.json" ], "solution_diff": "diff --git a/package.json b/package.json\nindex c44838a7ff6d..2151d5c19c72 100644\n--- a/package.json\n+++ b/package.json\n@@ -15,7 +15,8 @@\n \"scripts\": {\n \"prepack\": \"yarn build-repo...
[]
diff --git a/build/build-baseline-data.js b/build/build-baseline-data.js new file mode 100644 index 000000000000..046d6857dd51 --- /dev/null +++ b/build/build-baseline-data.js @@ -0,0 +1,40 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +/** + * @fileoverview Reduce th...
5
6
GoogleChrome/lighthouse#17046
GoogleChrome/lighthouse
17,046
d21355db3ddca29ad4e6157d93cfd20bd63ed871
ec7d41a350d60e1b0ba09fbcb5efa8fad84cd2ad
Time to First Byte reported as 0 ms in LCP Breakdown ### FAQ - [x] Yes, my issue is not about [variability](https://github.com/GoogleChrome/lighthouse/blob/main/docs/variability.md) or [throttling](https://github.com/GoogleChrome/lighthouse/blob/main/docs/throttling.md). - [x] Yes, my issue is not about a specific ac...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Time to First Byte reported as 0 ms in LCP Breakdown", "scope_files": [ "package.json", "yarn.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `shared/localization/locales/` ...
[ { "subtask_id": "s1", "scope_files": [ "package.json", "yarn.lock" ], "solution_diff": "diff --git a/package.json b/package.json\nindex c709b17bd785..c44838a7ff6d 100644\n--- a/package.json\n+++ b/package.json\n@@ -177,7 +177,7 @@\n \"webtreemap-cdt\": \"^3.2.1\"\n },\n \"depende...
[]
diff --git a/package.json b/package.json index c709b17bd785..c44838a7ff6d 100644 --- a/package.json +++ b/package.json @@ -177,7 +177,7 @@ "webtreemap-cdt": "^3.2.1" }, "dependencies": { - "@paulirish/trace_engine": "0.0.64", + "@paulirish/trace_engine": "0.0.65", "@sentry/node": "^9.28.1", "...
2
49
GoogleChrome/lighthouse#16765
GoogleChrome/lighthouse
16,765
aed7dc5b3ce5ed85ff85117d0d2616c31b99af8f
2e91947a64f6622f1c6f2ea5f43d65bd9b90418e
Canonical URL audit mistakes invalid URLs for relative ones <!-- Before creating an issue please make sure you are using the latest version and have checked for duplicate issues. --> <!-- Before creating an Accessibility issue please test that it is reproducible upstream with axe (https://www.deque.com/axe/) first ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `core/audits/seo/` needed for: Canonical URL audit mistakes invalid URLs for relative ones", "scope_files": [ "core/audits/seo/canonical.js" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `core/test/audits/...
[ { "subtask_id": "s1", "scope_files": [ "core/audits/seo/canonical.js" ], "solution_diff": "diff --git a/core/audits/seo/canonical.js b/core/audits/seo/canonical.js\nindex 1a1868188e4b..2c615422a355 100644\n--- a/core/audits/seo/canonical.js\n+++ b/core/audits/seo/canonical.js\n@@ -5,7 +5,6 @@\...
[ { "subtask_id": "s1", "comment": "(not yet considering the larger context but…)\r\n\r\nlet's use `URL.parse()` here (instead of `new URL()` so we can avoid the try/catch cascade", "revised_diff": "diff --git a/core/audits/seo/canonical.js b/core/audits/seo/canonical.js\nindex 1a1868188e4b..2c615422a355 ...
diff --git a/core/audits/seo/canonical.js b/core/audits/seo/canonical.js index 1a1868188e4b..2c615422a355 100644 --- a/core/audits/seo/canonical.js +++ b/core/audits/seo/canonical.js @@ -5,7 +5,6 @@ */ import {Audit} from '../audit.js'; -import UrlUtils from '../../lib/url-utils.js'; import {MainResource} from '....
2
2
GoogleChrome/lighthouse#17045
GoogleChrome/lighthouse
17,045
aed7dc5b3ce5ed85ff85117d0d2616c31b99af8f
798aa0e039eb61b0602fc7ccd34ec77e8efbf217
Explodey performance gauge shows unstylized score for a few seconds We added this ~3 years ago, and haven't changed it since. I confirmed that reports generated by earlier versions of Lighthouse still present this bug. So the issue is that Chrome / the web changed something, and we must have been relying on some unspe...
[ { "subtask_id": "s1", "goal": "Implement the changes under `report/assets/` needed for: Explodey performance gauge shows unstylized score for a few seconds", "scope_files": [ "report/assets/styles.css" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `report/renderer...
[ { "subtask_id": "s1", "scope_files": [ "report/assets/styles.css" ], "solution_diff": "diff --git a/report/assets/styles.css b/report/assets/styles.css\nindex 72a9e50177b7..2ea501ade9a9 100644\n--- a/report/assets/styles.css\n+++ b/report/assets/styles.css\n@@ -2282,10 +2282,7 @@ details[open]...
[]
diff --git a/report/assets/styles.css b/report/assets/styles.css index 72a9e50177b7..2ea501ade9a9 100644 --- a/report/assets/styles.css +++ b/report/assets/styles.css @@ -2282,10 +2282,7 @@ details[open] .lh-clump-toggletext--hide { display: block;} animation-fill-mode: forwards; } .lh-exp-gauge-component .state--...
2
3
GoogleChrome/lighthouse#16938
GoogleChrome/lighthouse
16,938
5fca441bc1d205dab081ad53b7699eef3cd90645
927cb7c7c8f243b8f14f15fedb0fa7c8842d4cee
misc(ci): bump actions/upload-artifact from 4 to 7 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 7. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p> <bloc...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: misc(ci): bump actions/upload-artifact from 4 to 7", "scope_files": [ ".github/workflows/ci.yml", ".github/workflows/devtools.yml", ".github/workflows/smoke.yml", ".github/workflows/unit.y...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/ci.yml", ".github/workflows/devtools.yml", ".github/workflows/smoke.yml", ".github/workflows/unit.yml" ], "solution_diff": "diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml\nindex 7e67ce7ece7b..f35064d2...
[]
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7e67ce7ece7b..f35064d2ffba 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -82,7 +82,7 @@ jobs: BT_API_AUTH_TOKEN: ${{ secrets.BT_API_AUTH_TOKEN }} - name: Upload dist - uses: actions/upload-artifact@v4 +...
1
4
GoogleChrome/lighthouse#17028
GoogleChrome/lighthouse
17,028
8d19778c314eae8ba5b30057e71589a56a9faeb0
81a63f1ac474ca3ace3590192fdcd64ff5eff96d
Naming collision: Lighthouse exports Audit class and Audit namespace from the root ### FAQ - [x] Yes, my issue is not about [variability](https://github.com/GoogleChrome/lighthouse/blob/main/docs/variability.md) or [throttling](https://github.com/GoogleChrome/lighthouse/blob/main/docs/throttling.md). - [x] Yes, my is...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Naming collision: Lighthouse exports Audit class and Audit namespace from the root", "scope_files": [ "tsconfig.json", "types.js" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `...
[ { "subtask_id": "s1", "scope_files": [ "tsconfig.json", "types.js" ], "solution_diff": "diff --git a/tsconfig.json b/tsconfig.json\nindex 1eb0e9531691..389acc7ec981 100644\n--- a/tsconfig.json\n+++ b/tsconfig.json\n@@ -16,6 +16,7 @@\n \"core/index.cjs\",\n \"clients/**/*.js\",\n ...
[]
diff --git a/tsconfig.json b/tsconfig.json index 1eb0e9531691..389acc7ec981 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -16,6 +16,7 @@ "core/index.cjs", "clients/**/*.js", "build/**/*.js", + "types.js", "./types/**/*.d.ts", "eslint-local-rules.cjs", "third-party/axe/valid-langs.js...
2
3
GoogleChrome/lighthouse#17041
GoogleChrome/lighthouse
17,041
9977be6c6801cbaae81772f356e0aab900c297ae
1ace96d2bf8f6d71a523e268047f5b8f07b43fcb
clients(viewer): disable agentic-browsing in PSI api call this is not enabled yet in PSI, so it fails atm: https://googlechrome.github.io/lighthouse/viewer/?psiurl=https://google.com @lusayaa FYI
[ { "subtask_id": "s1", "goal": "Implement the changes under `viewer/app/src/` needed for: clients(viewer): disable agentic-browsing in PSI api call", "scope_files": [ "viewer/app/src/psi-api.js" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `viewer/test/` needed fo...
[ { "subtask_id": "s1", "scope_files": [ "viewer/app/src/psi-api.js" ], "solution_diff": "diff --git a/viewer/app/src/psi-api.js b/viewer/app/src/psi-api.js\nindex ca55cbad512e..07831851a1fe 100644\n--- a/viewer/app/src/psi-api.js\n+++ b/viewer/app/src/psi-api.js\n@@ -13,7 +13,8 @@ const PSI_DEF...
[]
diff --git a/viewer/app/src/psi-api.js b/viewer/app/src/psi-api.js index ca55cbad512e..07831851a1fe 100644 --- a/viewer/app/src/psi-api.js +++ b/viewer/app/src/psi-api.js @@ -13,7 +13,8 @@ const PSI_DEFAULT_CATEGORIES = [ 'accessibility', 'seo', 'best-practices', - 'agentic-browsing', + // TODO: this is not ...
2
2
GoogleChrome/lighthouse#16845
GoogleChrome/lighthouse
16,845
8b1978324b51947be2784c94b60f0ddddeb6ee8b
a828eda693a1eec9dc1324ddc14d50c7a143f4bb
tests: remove unused c8 I removed `c8` and its related coverage configurations since we're not really using it anymore. This naturally resolves the security alerts caused by the older `cross-spawn` version that `c8` was pulling in, while also cleaning up some technical debt. I've also kept the `cross-spawn` resoluti...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: tests: remove unused c8", "scope_files": [ "package.json", "yarn.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflows/` needed for: tests: remove unused c8", ...
[ { "subtask_id": "s1", "scope_files": [ "package.json", "yarn.lock" ], "solution_diff": "diff --git a/package.json b/package.json\nindex 21b6f51a31e1..c709b17bd785 100644\n--- a/package.json\n+++ b/package.json\n@@ -33,7 +33,6 @@\n \"build-viewer\": \"node ./build/build-viewer.js\",\n...
[]
diff --git a/.github/workflows/smoke.yml b/.github/workflows/smoke.yml index 72776a40a7c5..8ee011306a29 100644 --- a/.github/workflows/smoke.yml +++ b/.github/workflows/smoke.yml @@ -56,8 +56,7 @@ jobs: - name: Run smoke tests run: | - yarn c8 yarn smoke --debug -j=2 --retries=2 --shard=${{ matrix....
3
5
GoogleChrome/lighthouse#17019
GoogleChrome/lighthouse
17,019
a0361753417b435d86ccd08c2aa44d2fa7c93645
cb243914632769e48937e06630c7864b86e9b938
deps: upgrade puppeteer to 25.0.2 Addressing breaking changes in v25 https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md#2500-2026-05-12
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: deps: upgrade puppeteer to 25.0.2", "scope_files": [ "package.json", "yarn.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `build/test/` needed for: deps: upgrade puppeteer ...
[ { "subtask_id": "s1", "scope_files": [ "package.json", "yarn.lock" ], "solution_diff": "diff --git a/package.json b/package.json\nindex 7acbe6900446..21b6f51a31e1 100644\n--- a/package.json\n+++ b/package.json\n@@ -170,7 +170,7 @@\n \"pako\": \"^2.1.0\",\n \"preact\": \"^10.7.2\"...
[]
diff --git a/clients/lightrider/lightrider-entry.js b/clients/lightrider/lightrider-entry.js index 531f53ade3d4..4f6723d01f94 100644 --- a/clients/lightrider/lightrider-entry.js +++ b/clients/lightrider/lightrider-entry.js @@ -7,8 +7,8 @@ import {Buffer} from 'buffer'; import log from 'lighthouse-logger'; -import {...
5
7
GoogleChrome/lighthouse#17008
GoogleChrome/lighthouse
17,008
f1460505034cb8c542fd09847a87e20cbf6f31b2
19b3564df5e127a5c0085927bc13557f4e14c333
v13.3.0
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: v13.3.0", "scope_files": [ "changelog.md", "package.json", "yarn.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `core/test/fixtures/user-flows/reports/` needed for: v...
[ { "subtask_id": "s1", "scope_files": [ "changelog.md", "package.json", "yarn.lock" ], "solution_diff": "diff --git a/changelog.md b/changelog.md\nindex 2fd0eee08574..60d8af64f401 100644\n--- a/changelog.md\n+++ b/changelog.md\n@@ -1,3 +1,31 @@\n+ <a name=\"13.3.0\"></a>\n+# 13.3.0 ...
[]
diff --git a/changelog.md b/changelog.md index 2fd0eee08574..60d8af64f401 100644 --- a/changelog.md +++ b/changelog.md @@ -1,3 +1,31 @@ + <a name="13.3.0"></a> +# 13.3.0 (2026-05-07) +[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v13.2.0...v13.3.0) + +We expect this release to ship in the DevTools...
6
8
GoogleChrome/lighthouse#17006
GoogleChrome/lighthouse
17,006
ec66b4af8424d43901f956f3070aca1aa1e4c03b
3076d36be5619e8219098264c6418b4fbd3dbef3
deps: upgrade dependencies
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: deps: upgrade dependencies", "scope_files": [ "package.json", "yarn.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `core/lib/` needed for: deps: upgrade dependencies", ...
[ { "subtask_id": "s1", "scope_files": [ "package.json", "yarn.lock" ], "solution_diff": "diff --git a/package.json b/package.json\nindex 0682006a73d8..c38f466dd3ad 100644\n--- a/package.json\n+++ b/package.json\n@@ -141,7 +141,7 @@\n \"builtin-modules\": \"^3.3.0\",\n \"c8\": \"^7...
[]
diff --git a/core/lib/baseline/web-features-metadata.json b/core/lib/baseline/web-features-metadata.json index f232b6f4ad56..802210db1daf 100644 --- a/core/lib/baseline/web-features-metadata.json +++ b/core/lib/baseline/web-features-metadata.json @@ -1,3 +1,3 @@ { - "date": "2026-03-18" + "date": "2026-05-01" } dif...
5
6
GoogleChrome/lighthouse#17005
GoogleChrome/lighthouse
17,005
147d04cee1546d6ce93416495a3750e929224552
71901435684679c05d1a61f9bba0475d63b217dd
core(llms-txt): adjust titles and descriptions and add smoketests Trying to be more accurate in the title. also add smoketests.
[ { "subtask_id": "s1", "goal": "Implement the changes under `cli/test/fixtures/` needed for: core(llms-txt): adjust titles and descriptions and add smoketests", "scope_files": [ "cli/test/fixtures/llms.txt" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `cli/test/fi...
[ { "subtask_id": "s1", "scope_files": [ "cli/test/fixtures/llms.txt" ], "solution_diff": "diff --git a/cli/test/fixtures/llms.txt b/cli/test/fixtures/llms.txt\nnew file mode 100644\nindex 000000000000..2cf07dc5e693\n--- /dev/null\n+++ b/cli/test/fixtures/llms.txt\n@@ -0,0 +1,1 @@\n+Bad llms txt...
[]
diff --git a/core/audits/agentic/llms-txt.js b/core/audits/agentic/llms-txt.js index a4307b443038..e19f031ede69 100644 --- a/core/audits/agentic/llms-txt.js +++ b/core/audits/agentic/llms-txt.js @@ -11,15 +11,15 @@ const HTTP_CLIENT_ERROR_CODE_LOW = 400; const HTTP_SERVER_ERROR_CODE_LOW = 500; const UIStrings = { -...
8
9
GoogleChrome/lighthouse#16999
GoogleChrome/lighthouse
16,999
e120fadb6f58a31fb0cdebd30cd97aa9ab3c9c8f
6de2800342787fdb098dfbd329d7ed2ec5f34ea0
tests(webmcp): add webmcp smoketests Add webmcp smoketests This PR also add Chrome flags as a test runner options. This is to allow WebMCP tests to pass the WebMCPTesting feature flag, without which these audits are N/A. We don't want to turn on WebMCPTesting by default yet because we don't want to turn on WebMCP a...
[ { "subtask_id": "s1", "goal": "Implement the changes under `cli/test/fixtures/webmcp/` needed for: tests(webmcp): add webmcp smoketests", "scope_files": [ "cli/test/fixtures/webmcp/webmcp_tester.html" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `cli/test/smokeho...
[ { "subtask_id": "s1", "scope_files": [ "cli/test/fixtures/webmcp/webmcp_tester.html" ], "solution_diff": "diff --git a/cli/test/fixtures/webmcp/webmcp_tester.html b/cli/test/fixtures/webmcp/webmcp_tester.html\nnew file mode 100644\nindex 000000000000..faa7ec626f2a\n--- /dev/null\n+++ b/cli/tes...
[]
diff --git a/types/internal/smokehouse.d.ts b/types/internal/smokehouse.d.ts index 66c65ea3c6f8..cabbad760723 100644 --- a/types/internal/smokehouse.d.ts +++ b/types/internal/smokehouse.d.ts @@ -42,6 +42,10 @@ declare global { config?: Config; /** If test is performance sensitive, set to true so that it w...
5
9
GoogleChrome/lighthouse#17002
GoogleChrome/lighthouse
17,002
e148cc6b9d6668aa878caac66b0f3dd14261e939
6bbb5a5b8bdeb0810472fcef0bf6feb798338680
core(agentic browsing): add agentic browsing category to default config Also remove custom config from bundle. <img width="1046" height="871" alt="image" src="https://github.com/user-attachments/assets/5dfa42d9-7579-4d6a-8d7d-c902af2beb5b" />
[ { "subtask_id": "s1", "goal": "Implement the changes under `build/` needed for: core(agentic browsing): add agentic browsing category to default config", "scope_files": [ "build/build-bundle-mcp.js" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `build/test/` neede...
[ { "subtask_id": "s1", "scope_files": [ "build/build-bundle-mcp.js" ], "solution_diff": "diff --git a/build/build-bundle-mcp.js b/build/build-bundle-mcp.js\nindex 31afacfda9f5..e88324b4edfd 100644\n--- a/build/build-bundle-mcp.js\n+++ b/build/build-bundle-mcp.js\n@@ -18,7 +18,6 @@ import esbuil...
[]
diff --git a/build/build-bundle-mcp.js b/build/build-bundle-mcp.js index 31afacfda9f5..e88324b4edfd 100644 --- a/build/build-bundle-mcp.js +++ b/build/build-bundle-mcp.js @@ -18,7 +18,6 @@ import esbuild from 'esbuild'; import * as plugins from './esbuild-plugins.js'; import {Runner} from '../core/runner.js'; import...
17
19
GoogleChrome/lighthouse#17003
GoogleChrome/lighthouse
17,003
081b1f26d31ea0d62550eea92f0d385e732b77d7
f1a733c10cec1fd09dfd7b176d7c3f8c92c13b40
Revert "clients(devtools): include agentic browsing config in devtools entry" Reverts GoogleChrome/lighthouse#16998
[ { "subtask_id": "s1", "goal": "Implement the changes under `build/test/` needed for: Revert \"clients(devtools): include agentic browsing config in devtools entry\"", "scope_files": [ "build/test/build-bundle-test.js" ] }, { "subtask_id": "s2", "goal": "Implement the changes under ...
[ { "subtask_id": "s1", "scope_files": [ "build/test/build-bundle-test.js" ], "solution_diff": "diff --git a/build/test/build-bundle-test.js b/build/test/build-bundle-test.js\nindex af329f8bf2a1..3147c87a0969 100644\n--- a/build/test/build-bundle-test.js\n+++ b/build/test/build-bundle-test.js\n@...
[]
diff --git a/clients/devtools/devtools-entry.js b/clients/devtools/devtools-entry.js index 7c72816bcb54..b8909cc8acf2 100644 --- a/clients/devtools/devtools-entry.js +++ b/clients/devtools/devtools-entry.js @@ -8,7 +8,7 @@ import {Buffer} from 'buffer'; import log from 'lighthouse-logger'; -import lighthouse, {nav...
2
2
GoogleChrome/lighthouse#16998
GoogleChrome/lighthouse
16,998
8c6a64e0776bd97f2dd1603b8fd0581a5a2c8b56
98b468217ad994d8ce123b3b44ffc0616015eaa2
clients(devtools): include agentic browsing config in devtools entry
[ { "subtask_id": "s1", "goal": "Implement the changes under `build/test/` needed for: clients(devtools): include agentic browsing config in devtools entry", "scope_files": [ "build/test/build-bundle-test.js" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `clients/de...
[ { "subtask_id": "s1", "scope_files": [ "build/test/build-bundle-test.js" ], "solution_diff": "diff --git a/build/test/build-bundle-test.js b/build/test/build-bundle-test.js\nindex 3147c87a0969..af329f8bf2a1 100644\n--- a/build/test/build-bundle-test.js\n+++ b/build/test/build-bundle-test.js\n@...
[]
diff --git a/clients/devtools/devtools-entry.js b/clients/devtools/devtools-entry.js index b8909cc8acf2..7c72816bcb54 100644 --- a/clients/devtools/devtools-entry.js +++ b/clients/devtools/devtools-entry.js @@ -8,7 +8,7 @@ import {Buffer} from 'buffer'; import log from 'lighthouse-logger'; -import lighthouse, {nav...
2
2
GoogleChrome/lighthouse#16997
GoogleChrome/lighthouse
16,997
8c6a64e0776bd97f2dd1603b8fd0581a5a2c8b56
0cfeb44f1311175ae6a7d255971bcb3a71a13531
core(agentic-web): add links to category and audit descriptions
[ { "subtask_id": "s1", "goal": "Implement the changes under `core/audits/` needed for: core(agentic-web): add links to category and audit descriptions", "scope_files": [ "core/audits/webmcp-form-coverage.js", "core/audits/webmcp-registered-tools.js", "core/audits/webmcp-schema-validity....
[ { "subtask_id": "s1", "scope_files": [ "core/audits/webmcp-form-coverage.js", "core/audits/webmcp-registered-tools.js", "core/audits/webmcp-schema-validity.js" ], "solution_diff": "diff --git a/core/audits/webmcp-form-coverage.js b/core/audits/webmcp-form-coverage.js\nindex c9d434c...
[]
diff --git a/core/audits/agentic/agent-accessibility-tree.js b/core/audits/agentic/agent-accessibility-tree.js index 52023ac50436..82e051acf4b0 100644 --- a/core/audits/agentic/agent-accessibility-tree.js +++ b/core/audits/agentic/agent-accessibility-tree.js @@ -13,7 +13,7 @@ const UIStrings = { /** Title shown when...
4
7
GoogleChrome/lighthouse#16995
GoogleChrome/lighthouse
16,995
e8b309ad8c7fe0565256ec871c9ce2b889fe979a
2d2592b6f613de4931087155f40d037266dceee1
misc(bundle): update build-bundle-mcp
[ { "subtask_id": "s1", "goal": "Implement the changes under `build/` needed for: misc(bundle): update build-bundle-mcp", "scope_files": [ "build/build-bundle-mcp.js" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `build/test/` needed for: misc(bundle): update build-...
[ { "subtask_id": "s1", "scope_files": [ "build/build-bundle-mcp.js" ], "solution_diff": "diff --git a/build/build-bundle-mcp.js b/build/build-bundle-mcp.js\nindex 9c4e6c891d15..31afacfda9f5 100644\n--- a/build/build-bundle-mcp.js\n+++ b/build/build-bundle-mcp.js\n@@ -76,7 +76,7 @@ function getM...
[]
diff --git a/build/build-bundle-mcp.js b/build/build-bundle-mcp.js index 9c4e6c891d15..31afacfda9f5 100644 --- a/build/build-bundle-mcp.js +++ b/build/build-bundle-mcp.js @@ -76,7 +76,7 @@ function getMcpRequiredGathererNames() { 'MainDocumentContent', 'MetaElements', 'Stacks', 'Trace', ]; const a11yArtifact...
2
2
GoogleChrome/lighthouse#16994
GoogleChrome/lighthouse
16,994
2caf7c29acbf64ba1fa0a3e65713ed1ef3ea8963
c006eac9b369120e7749a0f5d3baadc2d461d44c
v13.2.0
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: v13.2.0", "scope_files": [ "changelog.md", "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `core/test/fixtures/user-flows/reports/` needed for: v13.2.0", "scope...
[ { "subtask_id": "s1", "scope_files": [ "changelog.md", "package.json" ], "solution_diff": "diff --git a/changelog.md b/changelog.md\nindex 57ba5a3d2e3a..2fd0eee08574 100644\n--- a/changelog.md\n+++ b/changelog.md\n@@ -1,3 +1,58 @@\n+ <a name=\"13.2.0\"></a>\n+# 13.2.0 (2026-04-30)\n+[Ful...
[]
diff --git a/changelog.md b/changelog.md index 57ba5a3d2e3a..2fd0eee08574 100644 --- a/changelog.md +++ b/changelog.md @@ -1,3 +1,58 @@ + <a name="13.2.0"></a> +# 13.2.0 (2026-04-30) +[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v13.1.0...v13.2.0) + +We expect this release to ship in the DevTools...
6
7
GoogleChrome/lighthouse#16992
GoogleChrome/lighthouse
16,992
dd652bf1bf6b4df095c27d2ad321227522bba1ac
a3e7f70c37235a06ebba905b9f0b33c233a91dcf
deps: upgrade deps
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: deps: upgrade deps", "scope_files": [ "package.json", "yarn.lock" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "package.json", "yarn.lock" ], "solution_diff": "diff --git a/package.json b/package.json\nindex f44cd5476632..cd0274907d4e 100644\n--- a/package.json\n+++ b/package.json\n@@ -141,7 +141,7 @@\n \"builtin-modules\": \"^3.3.0\",\n \"c8\": \"^7...
[]
diff --git a/package.json b/package.json index f44cd5476632..cd0274907d4e 100644 --- a/package.json +++ b/package.json @@ -141,7 +141,7 @@ "builtin-modules": "^3.3.0", "c8": "^7.11.3", "chalk": "^2.4.1", - "chrome-devtools-frontend": "1.0.1608453", + "chrome-devtools-frontend": "1.0.1621678", ...
1
2
GoogleChrome/lighthouse#16987
GoogleChrome/lighthouse
16,987
9f10dd45304955114973bcdaef01ab3e40c020a3
a9f89d4d00c33e46ede89fb4d7c971916c3efb72
core(webmcp): adjust how webmcp audits handle lack of WebMCP support WebMCP audits should only be applicable in these cases: * WebMCP is supported, meaning `navigator.modelContext` is exposed. This is the case if `WebMCPForTesting` flag is enabled or the site is part of the origin trial. * WebMCP.enable CDP call is...
[ { "subtask_id": "s1", "goal": "Implement the changes under `cli/` needed for: core(webmcp): adjust how webmcp audits handle lack of WebMCP support", "scope_files": [ "cli/bin.js" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `core/audits/` needed for: core(webmcp)...
[ { "subtask_id": "s1", "scope_files": [ "cli/bin.js" ], "solution_diff": "diff --git a/cli/bin.js b/cli/bin.js\nindex be2428fba872..a7b7d90e9cd4 100644\n--- a/cli/bin.js\n+++ b/cli/bin.js\n@@ -107,6 +107,11 @@ async function begin() {\n cliFlags.precomputedLanternData = data;\n }\n \n+ i...
[]
diff --git a/cli/bin.js b/cli/bin.js index be2428fba872..a7b7d90e9cd4 100644 --- a/cli/bin.js +++ b/cli/bin.js @@ -107,6 +107,11 @@ async function begin() { cliFlags.precomputedLanternData = data; } + if (!Array.isArray(cliFlags.chromeFlags)) { + cliFlags.chromeFlags = [cliFlags.chromeFlags]; + } + cliF...
8
12
GoogleChrome/lighthouse#16990
GoogleChrome/lighthouse
16,990
9f10dd45304955114973bcdaef01ab3e40c020a3
3a37547a4c5ba3a38be03313149a5c1b045ee233
core(agentic_category): add disclaimer to category description
[ { "subtask_id": "s1", "goal": "Implement the changes under `core/config/` needed for: core(agentic_category): add disclaimer to category description", "scope_files": [ "core/config/agentic-browsing-config.js" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `shared/l...
[ { "subtask_id": "s1", "scope_files": [ "core/config/agentic-browsing-config.js" ], "solution_diff": "diff --git a/core/config/agentic-browsing-config.js b/core/config/agentic-browsing-config.js\nindex 89cdd4765f2e..d48d6c170dd3 100644\n--- a/core/config/agentic-browsing-config.js\n+++ b/core/c...
[]
diff --git a/core/config/agentic-browsing-config.js b/core/config/agentic-browsing-config.js index 89cdd4765f2e..d48d6c170dd3 100644 --- a/core/config/agentic-browsing-config.js +++ b/core/config/agentic-browsing-config.js @@ -10,8 +10,9 @@ const UIStrings = { /** Title of the Agentic Browsing category of audits. */...
2
3
GoogleChrome/lighthouse#16982
GoogleChrome/lighthouse
16,982
ebddc17a4bdf7dc1702bdfe7d3a1264ab3f6ddea
51d3dcc20c947b7c06688d1b5651512b7d95feb0
core(config): aggregate agent accessabilty audits <img width="877" height="659" alt="Screenshot 2026-04-24 at 2 06 44 PM" src="https://github.com/user-attachments/assets/d44d96ba-b0cf-41cb-bf06-69a8c8972e45" /> This PR aggregates the agent accessibility audits into a unified view. Introduces the agent-accessibili...
[ { "subtask_id": "s1", "goal": "Implement the changes under `core/audits/agentic/` needed for: core(config): aggregate agent accessabilty audits", "scope_files": [ "core/audits/agentic/agent-accessibility-tree.js" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `core...
[ { "subtask_id": "s1", "scope_files": [ "core/audits/agentic/agent-accessibility-tree.js" ], "solution_diff": "diff --git a/core/audits/agentic/agent-accessibility-tree.js b/core/audits/agentic/agent-accessibility-tree.js\nnew file mode 100644\nindex 000000000000..52023ac50436\n--- /dev/null\n+...
[ { "subtask_id": "s1", "comment": "nit: I'd maybe drop the `Agentic` here and below. The accessibility tree isn't really specific to agents, it just happens to also help agents.", "revised_diff": "diff --git a/core/audits/agentic/agent-accessibility-tree.js b/core/audits/agentic/agent-accessibility-tree....
diff --git a/core/audits/agentic/agent-accessibility-tree.js b/core/audits/agentic/agent-accessibility-tree.js new file mode 100644 index 000000000000..52023ac50436 --- /dev/null +++ b/core/audits/agentic/agent-accessibility-tree.js @@ -0,0 +1,115 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Iden...
9
10
GoogleContainerTools/jib#4493
GoogleContainerTools/jib
4,493
24b44450133f589584d7ee15caf0c85b20a119d0
cef8a92b9fa8411184bb4006286b05b314498456
chore: Migrate gsutil usage to gcloud storage Automated: Migrate {target_path} from gsutil to gcloud storage This CL is part of the on going effort to migrate from the legacy `gsutil` tool to the new and improved `gcloud storage` command-line interface. `gcloud storage` is the recommended and modern tool for interact...
[ { "subtask_id": "s1", "goal": "Implement the changes under `jib-cli/scripts/` needed for: chore: Migrate gsutil usage to gcloud storage", "scope_files": [ "jib-cli/scripts/update_gcs_latest.sh" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `jib-gradle-plugin/scrip...
[ { "subtask_id": "s1", "scope_files": [ "jib-cli/scripts/update_gcs_latest.sh" ], "solution_diff": "diff --git a/jib-cli/scripts/update_gcs_latest.sh b/jib-cli/scripts/update_gcs_latest.sh\nindex 28aa42a6bc..6c0261b397 100755\n--- a/jib-cli/scripts/update_gcs_latest.sh\n+++ b/jib-cli/scripts/up...
[ { "subtask_id": "s1", "comment": "![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)\n\nFor better efficiency and atomicity, you can combine the copy and ACL update into a single command by using the `--predefined-acl=public-read` flag. This avoids a second API call to update the object'...
diff --git a/jib-cli/scripts/update_gcs_latest.sh b/jib-cli/scripts/update_gcs_latest.sh index 28aa42a6bc..6c0261b397 100755 --- a/jib-cli/scripts/update_gcs_latest.sh +++ b/jib-cli/scripts/update_gcs_latest.sh @@ -28,8 +28,8 @@ versionString="{\"latest\":\"$1\"}" destination="gs://jib-versions/jib-cli" echo $versi...
3
3
GoogleContainerTools/jib#4491
GoogleContainerTools/jib
4,491
c43ab0773bccff38f5463d53d36af6daa82a3d8a
41417f4abe1e59e760fa6fa109251e4c892eba27
Refactor Github Action per b/485167538 This is a http://go/LSC run by http://go/ghss to automatically refactor your Github Actions per http://b/485167538. This is a PR to help you upgrade to the latest standards in Github Actions. Please merge this PR to accept the changes. NOTE: if you do not accept this PR, it may...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: Refactor Github Action per b/485167538", "scope_files": [ ".github/workflows/jib-cli-release.yml", ".github/workflows/prepare-release.yml" ] } ]
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/jib-cli-release.yml", ".github/workflows/prepare-release.yml" ], "solution_diff": "diff --git a/.github/workflows/jib-cli-release.yml b/.github/workflows/jib-cli-release.yml\nindex cdebc3eb69..cea1c54d30 100644\n--- a/.github/work...
[]
diff --git a/.github/workflows/jib-cli-release.yml b/.github/workflows/jib-cli-release.yml index cdebc3eb69..cea1c54d30 100644 --- a/.github/workflows/jib-cli-release.yml +++ b/.github/workflows/jib-cli-release.yml @@ -30,32 +30,38 @@ jobs: - name: Build project run: | - if [[ ! "${{ github.e...
1
2
GoogleContainerTools/jib#4486
GoogleContainerTools/jib
4,486
cf25fbd9849e2cdd0a91d4ba0845e11f7b3d0682
6ef57b1d3e810a17a4b17f5ab7f6e4f371a033e7
chore: update changelog and examples to use 3.5.3 jib-gradle-plugin Update the changelog and examples to use latest jib-gradle-plugin release 3.5.3.
[ { "subtask_id": "s1", "goal": "Implement the changes under `examples/helloworld/` needed for: chore: update changelog and examples to use 3.5.3 jib-gradle-plugin", "scope_files": [ "examples/helloworld/build.gradle" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `e...
[ { "subtask_id": "s1", "scope_files": [ "examples/helloworld/build.gradle" ], "solution_diff": "diff --git a/examples/helloworld/build.gradle b/examples/helloworld/build.gradle\nindex c4360803f5..b74b1e9270 100644\n--- a/examples/helloworld/build.gradle\n+++ b/examples/helloworld/build.gradle\n...
[]
diff --git a/examples/helloworld/build.gradle b/examples/helloworld/build.gradle index c4360803f5..b74b1e9270 100644 --- a/examples/helloworld/build.gradle +++ b/examples/helloworld/build.gradle @@ -1,6 +1,6 @@ plugins { id 'java' - id 'com.google.cloud.tools.jib' version '3.5.2' + id 'com.google.cloud.tools.jib'...
8
8
GoogleContainerTools/jib#4467
GoogleContainerTools/jib
4,467
7ca8957f22dbf8390ba3abf90223a2d51f719857
52446d3f0f6dc610ea543c0a66b6b389aff87d40
Plugin Release v3.5.2-gradle ## Requirements - [x] ⚠️ Ensure the release process has succeeded before proceeding ## GCS - [x] Run `./jib-gradle-plugin/scripts/update_gcs_latest.sh 3.5.2` script to update GCS with the latest version number ## Github - [x] Update [CHANGELOG.md](https://github.com/GoogleContainerTools/...
[ { "subtask_id": "s1", "goal": "Implement the changes under `examples/helloworld/` needed for: Plugin Release v3.5.2-gradle", "scope_files": [ "examples/helloworld/build.gradle" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `examples/java-agent/` needed for: Plugin...
[ { "subtask_id": "s1", "scope_files": [ "examples/helloworld/build.gradle" ], "solution_diff": "diff --git a/examples/helloworld/build.gradle b/examples/helloworld/build.gradle\nindex 2ff9785662..c4360803f5 100644\n--- a/examples/helloworld/build.gradle\n+++ b/examples/helloworld/build.gradle\n...
[]
diff --git a/examples/helloworld/build.gradle b/examples/helloworld/build.gradle index 2ff9785662..c4360803f5 100644 --- a/examples/helloworld/build.gradle +++ b/examples/helloworld/build.gradle @@ -1,6 +1,6 @@ plugins { id 'java' - id 'com.google.cloud.tools.jib' version '3.5.1' + id 'com.google.cloud.tools.jib'...
8
9
GoogleContainerTools/jib#2999
GoogleContainerTools/jib
2,999
ee8519e88bda36f7e2f938d5bfb0862217820abd
e36544461b9a77022364100606e03ff067afcf59
Add registry mirror config to jib-core API and Jib global config Towards #1396. * Jib Core * Adds `Containerizer.withRegistryMirrors(...)` to the jib-core API. * Jib Maven/Gradle plugins * Adds the property `registryMirrors` to the global Jib config. * Also see #3002 for the proposed public doc change...
[ { "subtask_id": "s1", "goal": "Implement the changes under `jib-core/src/main/java/com/google/cloud/tools/jib/api/` needed for: Add registry mirror config to jib-core API and Jib global config ", "scope_files": [ "jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java", "ji...
[ { "subtask_id": "s1", "scope_files": [ "jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java", "jib-core/src/main/java/com/google/cloud/tools/jib/api/JibContainerBuilder.java" ], "solution_diff": "diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/api/Cont...
[ { "subtask_id": "s2", "comment": "How about using `ImmutableListMultimap` instead of `ImmutableMap<String, ImmutableList<String>>` here? ", "revised_diff": "diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildContext.java b/jib-core/src/main/java/com/google/cloud/tools/jib...
diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java b/jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java index 1bd06d11a3..e2747d2a33 100644 --- a/jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java +++ b/jib-core/src/main/java/com/google/clou...
9
17
GoogleContainerTools/jib#4460
GoogleContainerTools/jib
4,460
afdfba9d1c10c3187d8cf8881c96574787d5a05b
b5c1f451e28529af15eb3d20ee572b3157d91f47
chore: 3.5.0 post release updates
[ { "subtask_id": "s1", "goal": "Implement the changes under `examples/dropwizard/` needed for: chore: 3.5.0 post release updates", "scope_files": [ "examples/dropwizard/pom.xml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `examples/helloworld/` needed for: chore:...
[ { "subtask_id": "s1", "scope_files": [ "examples/dropwizard/pom.xml" ], "solution_diff": "diff --git a/examples/dropwizard/pom.xml b/examples/dropwizard/pom.xml\nindex 9c4b4821e7..5a75180165 100644\n--- a/examples/dropwizard/pom.xml\n+++ b/examples/dropwizard/pom.xml\n@@ -26,7 +26,7 @@\n ...
[ { "subtask_id": "s9", "comment": "![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)\n\nThe `compile` dependency configuration is deprecated in Gradle. It's better to use `implementation` to align with modern Gradle practices and avoid confusion for users.\n\n```suggestion\n implementat...
diff --git a/examples/dropwizard/pom.xml b/examples/dropwizard/pom.xml index 9c4b4821e7..5a75180165 100644 --- a/examples/dropwizard/pom.xml +++ b/examples/dropwizard/pom.xml @@ -26,7 +26,7 @@ <dropwizard-template-config.version>1.5.0</dropwizard-template-config.version> <jib.container.appRoot>/app<...
11
18
GoogleContainerTools/jib#4452
GoogleContainerTools/jib
4,452
0ca8ed07dbb8f94ddca6a2622bb482e831d2758d
379587813f098905ae015c17e80accffd2df4254
chore: 3.5.0 post release updates - **docs: modify CHANGELOG.md** - **docs: update README files** - **docs: update examples**
[ { "subtask_id": "s1", "goal": "Implement the changes under `examples/dropwizard/` needed for: chore: 3.5.0 post release updates", "scope_files": [ "examples/dropwizard/pom.xml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `examples/helloworld/` needed for: chore:...
[ { "subtask_id": "s1", "scope_files": [ "examples/dropwizard/pom.xml" ], "solution_diff": "diff --git a/examples/dropwizard/pom.xml b/examples/dropwizard/pom.xml\nindex 7d64dd82e3..9c4b4821e7 100644\n--- a/examples/dropwizard/pom.xml\n+++ b/examples/dropwizard/pom.xml\n@@ -26,7 +26,7 @@\n ...
[ { "subtask_id": "s9", "comment": "![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)\n\nThere's a small typo here with a duplicated 'deps:' prefix. Removing it will improve the changelog's clarity.\n\n```suggestion\n- deps: update `org.ow2.asm:asm` to version 9.8 for java 25 support\n```...
diff --git a/examples/dropwizard/pom.xml b/examples/dropwizard/pom.xml index 7d64dd82e3..9c4b4821e7 100644 --- a/examples/dropwizard/pom.xml +++ b/examples/dropwizard/pom.xml @@ -26,7 +26,7 @@ <dropwizard-template-config.version>1.5.0</dropwizard-template-config.version> <jib.container.appRoot>/app<...
11
18
GoogleContainerTools/jib#4432
GoogleContainerTools/jib
4,432
d5b3e64afcb7510b4c5490c37f24c05de15cc125
1864c7f1727b1a26cfc05c697c6c0dc145278a25
Fully support Java 25 and its flexible main methods https://github.com/GoogleContainerTools/jib/pull/4418#issuecomment-3461109393 feat: support Java 25 main methods Fixes #4431
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Fully support Java 25 and its flexible main methods", "scope_files": [ "build.gradle" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `jib-core/src/main/java/com/google/cloud/tools/jib/...
[ { "subtask_id": "s1", "scope_files": [ "build.gradle" ], "solution_diff": "diff --git a/build.gradle b/build.gradle\nindex a6d76b491b..e83cba6046 100644\n--- a/build.gradle\n+++ b/build.gradle\n@@ -35,7 +35,7 @@ project.ext.dependencyStrings = [\n JACKSON_DATABIND: 'com.fasterxml.jackson.cor...
[ { "subtask_id": "s2", "comment": "![high](https://www.gstatic.com/codereviewagent/high-priority.svg)\n\nAccording to JEP 463 (Flexible Main Methods and Main Classes), a main method can be `synchronized` or `strictfp`. The current implementation does not account for these optional modifiers, which would caus...
diff --git a/build.gradle b/build.gradle index a6d76b491b..e83cba6046 100644 --- a/build.gradle +++ b/build.gradle @@ -35,7 +35,7 @@ project.ext.dependencyStrings = [ JACKSON_DATABIND: 'com.fasterxml.jackson.core:jackson-databind', JACKSON_DATAFORMAT_YAML: 'com.fasterxml.jackson.dataformat:jackson-dataformat-yaml...
4
9
GoogleContainerTools/jib#4418
GoogleContainerTools/jib
4,418
08a45eca1188dbbc114e1caf97ba79c19bb53c84
27127e9fa7de15b064582a98419eb769b09166bf
Support java 25 Maven - 3.9.9 Liberica JDK - 25.0.0-37 jib-maven-plugin - 3.4.6 ASM ClassReader complains about unsupported version in the newest java jdk 25. I have looked at https://github.com/GoogleContainerTools/jib/blob/master/docs/faq.md#i-am-seeing-unsupported-class-file-major-version-when-building and fix...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Support java 25", "scope_files": [ "build.gradle" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/` needed for: Suppor...
[ { "subtask_id": "s1", "scope_files": [ "build.gradle" ], "solution_diff": "diff --git a/build.gradle b/build.gradle\nindex bfa4d3807e..a6d76b491b 100644\n--- a/build.gradle\n+++ b/build.gradle\n@@ -35,7 +35,7 @@ project.ext.dependencyStrings = [\n JACKSON_DATABIND: 'com.fasterxml.jackson.cor...
[ { "subtask_id": "s3", "comment": "![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)\n\nFor consistency with other parts of the codebase and for better readability, this `for` loop can be converted to a `while` loop. The `while ((entry = ...getNextEntry()) != null)` pattern is more idiom...
diff --git a/build.gradle b/build.gradle index bfa4d3807e..a6d76b491b 100644 --- a/build.gradle +++ b/build.gradle @@ -35,7 +35,7 @@ project.ext.dependencyStrings = [ JACKSON_DATABIND: 'com.fasterxml.jackson.core:jackson-databind', JACKSON_DATAFORMAT_YAML: 'com.fasterxml.jackson.dataformat:jackson-dataformat-yaml...
6
7
GoogleContainerTools/jib#4436
GoogleContainerTools/jib
4,436
87b4c0e1dd16419f7920a3b498ed1c4e310909a8
e841ee229ed8f19a3bfe99858d3e583b49f70d62
feat: add default base image for Java 25
[ { "subtask_id": "s1", "goal": "Implement the changes under `docs/` needed for: feat: add default base image for Java 25", "scope_files": [ "docs/google-cloud-build.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `jib-cli/src/main/java/com/google/cloud/tools/jib/...
[ { "subtask_id": "s1", "scope_files": [ "docs/google-cloud-build.md" ], "solution_diff": "diff --git a/docs/google-cloud-build.md b/docs/google-cloud-build.md\nindex 71d779bdaa..d3996ce82c 100644\n--- a/docs/google-cloud-build.md\n+++ b/docs/google-cloud-build.md\n@@ -13,7 +13,7 @@ Any Java con...
[]
diff --git a/docs/google-cloud-build.md b/docs/google-cloud-build.md index 71d779bdaa..d3996ce82c 100644 --- a/docs/google-cloud-build.md +++ b/docs/google-cloud-build.md @@ -13,7 +13,7 @@ Any Java container can be used for building, not only the `gcr.io/cloud-builders ```yaml steps: - - name: 'docker.io/library/e...
8
8
GoogleContainerTools/jib#4398
GoogleContainerTools/jib
4,398
586b4a6f57f208bb4128aa7286741a23bf9eda7b
0a5184177118936f46f2f06a7af5043f2a9e9903
Docs site redirection is down The `docs/README.md` has a link to `https://googlecontainertools.github.io/jib/` which doesn't exist (404) https://github.com/GoogleContainerTools/jib/blob/master/docs/README.md chore: remove unused file related to wiki page I believe these files are not used anymore as we mived the FA...
[ { "subtask_id": "s1", "goal": "Implement the changes under `docs/` needed for: Docs site redirection is down", "scope_files": [ "docs/README.md", "docs/_config.yml" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "docs/README.md", "docs/_config.yml" ], "solution_diff": "diff --git a/docs/README.md b/docs/README.md\ndeleted file mode 100644\nindex 4f1a51ed9b..0000000000\n--- a/docs/README.md\n+++ /dev/null\n@@ -1,1 +0,0 @@\n-These docs generate [googlecontain...
[]
diff --git a/docs/README.md b/docs/README.md deleted file mode 100644 index 4f1a51ed9b..0000000000 --- a/docs/README.md +++ /dev/null @@ -1,1 +0,0 @@ -These docs generate [googlecontainertools.github.io/jib](https://googlecontainertools.github.io/jib/). diff --git a/docs/_config.yml b/docs/_config.yml deleted file mode...
1
2
GoogleContainerTools/jib#4394
GoogleContainerTools/jib
4,394
fb6a9a120761a0a45c0657c6678ac3e46f83bf59
db7543865339b6b7287119ea7257c77ae50708ae
chore: update docs for jib-maven-plugin v3.4.6 release
[ { "subtask_id": "s1", "goal": "Implement the changes under `examples/dropwizard/` needed for: chore: update docs for jib-maven-plugin v3.4.6 release", "scope_files": [ "examples/dropwizard/pom.xml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `examples/helloworld...
[ { "subtask_id": "s1", "scope_files": [ "examples/dropwizard/pom.xml" ], "solution_diff": "diff --git a/examples/dropwizard/pom.xml b/examples/dropwizard/pom.xml\nindex d11f63c0c6..7d64dd82e3 100644\n--- a/examples/dropwizard/pom.xml\n+++ b/examples/dropwizard/pom.xml\n@@ -26,7 +26,7 @@\n ...
[]
diff --git a/examples/dropwizard/pom.xml b/examples/dropwizard/pom.xml index d11f63c0c6..7d64dd82e3 100644 --- a/examples/dropwizard/pom.xml +++ b/examples/dropwizard/pom.xml @@ -26,7 +26,7 @@ <dropwizard-template-config.version>1.5.0</dropwizard-template-config.version> <jib.container.appRoot>/app<...
6
7
GoogleContainerTools/jib#4345
GoogleContainerTools/jib
4,345
ec548da749b4e7c9146c7db3207631bb64414cde
0cca78c0eb445536cdaa166ab0e99df6132324cf
Jib Maven Plugin 3.4.4 doesn't consider user properties properly (breaks on Maven 4) **Environment**: - *Jib version:* 3.4.4 - *Build tool:* Maven 4.0.0-rc-2 - *OS:* macOS 15.2 arm64 **Description of the issue**: I have a working project with jib-maven-plugin 3.4.4 using Maven 3.9.9, but when I tried it wi...
[ { "subtask_id": "s1", "goal": "Implement the changes under `jib-maven-plugin/` needed for: Jib Maven Plugin 3.4.4 doesn't consider user properties properly (breaks on Maven 4)", "scope_files": [ "jib-maven-plugin/CHANGELOG.md", "jib-maven-plugin/README.md" ] }, { "subtask_id": "s...
[ { "subtask_id": "s1", "scope_files": [ "jib-maven-plugin/CHANGELOG.md", "jib-maven-plugin/README.md" ], "solution_diff": "diff --git a/jib-maven-plugin/CHANGELOG.md b/jib-maven-plugin/CHANGELOG.md\nindex 94750aa3c2..367a6a6f66 100644\n--- a/jib-maven-plugin/CHANGELOG.md\n+++ b/jib-maven-...
[ { "subtask_id": "s2", "comment": "can getUserProperties be null? if so can you please add null check too?", "revised_diff": "diff --git a/jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MavenProjectProperties.java b/jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MavenPro...
diff --git a/jib-maven-plugin/CHANGELOG.md b/jib-maven-plugin/CHANGELOG.md index 94750aa3c2..367a6a6f66 100644 --- a/jib-maven-plugin/CHANGELOG.md +++ b/jib-maven-plugin/CHANGELOG.md @@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file. ### Added ### Changed +- Update retrieval of Mav...
3
4
GoogleContainerTools/jib#4361
GoogleContainerTools/jib
4,361
f3fa52e794ea10660a33265f3f7e2ab7e8252661
d4a22d3f71af49ca2226abe571a3df2b0a9bbde8
chore: grant access for bots to push tags and create issues for release workflows
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: chore: grant access for bots to push tags and create issues for release workflows", "scope_files": [ ".github/workflows/jib-cli-release.yml", ".github/workflows/prepare-release.yml" ] } ]
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/jib-cli-release.yml", ".github/workflows/prepare-release.yml" ], "solution_diff": "diff --git a/.github/workflows/jib-cli-release.yml b/.github/workflows/jib-cli-release.yml\nindex a6507f8a19..cdebc3eb69 100644\n--- a/.github/work...
[]
diff --git a/.github/workflows/jib-cli-release.yml b/.github/workflows/jib-cli-release.yml index a6507f8a19..cdebc3eb69 100644 --- a/.github/workflows/jib-cli-release.yml +++ b/.github/workflows/jib-cli-release.yml @@ -7,6 +7,10 @@ on: required: true default: (for example, 0.1.0) +permissions: + co...
1
2
GoogleContainerTools/jib#4356
GoogleContainerTools/jib
4,356
c87a744c258f82d09517c83e2103afcedaf65b1e
2bb58614c609bee58f6f96e4871e1f0255e8dfe5
chore: explicitly state we should use java 8 in github prepare release action
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: chore: explicitly state we should use java 8 in github prepare release action", "scope_files": [ ".github/workflows/jib-cli-release.yml", ".github/workflows/prepare-release.yml" ] } ]
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/jib-cli-release.yml", ".github/workflows/prepare-release.yml" ], "solution_diff": "diff --git a/.github/workflows/jib-cli-release.yml b/.github/workflows/jib-cli-release.yml\nindex 2284e1f78e..a6507f8a19 100644\n--- a/.github/work...
[]
diff --git a/.github/workflows/jib-cli-release.yml b/.github/workflows/jib-cli-release.yml index 2284e1f78e..a6507f8a19 100644 --- a/.github/workflows/jib-cli-release.yml +++ b/.github/workflows/jib-cli-release.yml @@ -18,6 +18,12 @@ jobs: - name: Check out code uses: actions/checkout@v4 + - name...
1
2
GoogleContainerTools/jib#4355
GoogleContainerTools/jib
4,355
390c175c95a4396ecb7c63e6bab8dec04050b63f
ef088641214753182c8271375e1b88b956f780ec
chore: update docs and examples for 3.4.5 and 0.27.3 releases
[ { "subtask_id": "s1", "goal": "Implement the changes under `examples/dropwizard/` needed for: chore: update docs and examples for 3.4.5 and 0.27.3 releases", "scope_files": [ "examples/dropwizard/pom.xml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `examples/hel...
[ { "subtask_id": "s1", "scope_files": [ "examples/dropwizard/pom.xml" ], "solution_diff": "diff --git a/examples/dropwizard/pom.xml b/examples/dropwizard/pom.xml\nindex ba520eec2d..d11f63c0c6 100644\n--- a/examples/dropwizard/pom.xml\n+++ b/examples/dropwizard/pom.xml\n@@ -26,7 +26,7 @@\n ...
[]
diff --git a/examples/dropwizard/pom.xml b/examples/dropwizard/pom.xml index ba520eec2d..d11f63c0c6 100644 --- a/examples/dropwizard/pom.xml +++ b/examples/dropwizard/pom.xml @@ -26,7 +26,7 @@ <dropwizard-template-config.version>1.5.0</dropwizard-template-config.version> <jib.container.appRoot>/app<...
11
18
GoogleContainerTools/jib#4351
GoogleContainerTools/jib
4,351
5d9beaee002e21fdeeb868edbc09e3727696937c
9d2b9f7ea816400d3becb736562c8e30fea19d7f
No progress after "Container entrypoint set to" with jib-maven-plugin 3.4.3 <!-- Please follow the guidelines below before opening an issue: 1. Ensure the issue was not already reported. 2. Open a new issue if you are unable to find an existing issue addressing your problem. Make sure to include a title and clear ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `jib-core/src/main/java/com/google/cloud/tools/jib/docker/` needed for: No progress after \"Container entrypoint set to\" with jib-maven-plugin 3.4.3", "scope_files": [ "jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerCli...
[ { "subtask_id": "s1", "scope_files": [ "jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java" ], "solution_diff": "diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java b/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliD...
[]
diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java b/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java index 035c9316f3..37d0e3ef2d 100644 --- a/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java +++ b/jib-core/src/main/java/...
2
2
GoogleContainerTools/jib#4319
GoogleContainerTools/jib
4,319
a3c0c5b31dfc813c88c5843641a0e2bd4c8ffa0f
40572c45881e80a5ed75ca6045c163fa220a7fb3
fix: add timeout for docker info read to prevent Jib from getting stuck indefinitely #4311 1. Fixed gradle and maven integration tests to make mock docker executable output OSType and Architecture. As discovered in https://github.com/GoogleContainerTools/jib/issues/4311#issuecomment-2405793374, Jib ran successfull...
[ { "subtask_id": "s1", "goal": "Implement the changes under `jib-core/src/main/java/com/google/cloud/tools/jib/docker/` needed for: fix: add timeout for docker info read to prevent Jib from getting stuck indefinitely", "scope_files": [ "jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDo...
[ { "subtask_id": "s1", "scope_files": [ "jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java" ], "solution_diff": "diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java b/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliD...
[]
diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java b/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java index d3dcecd883..035c9316f3 100644 --- a/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java +++ b/jib-core/src/main/java/...
3
3
GoogleContainerTools/jib#4329
GoogleContainerTools/jib
4,329
a3c0c5b31dfc813c88c5843641a0e2bd4c8ffa0f
4944d13cf53378dcd1b441f619b0aec6f31a42d9
chore: update docs and examples for 3.4.4 and 0.27.2 releases
[ { "subtask_id": "s1", "goal": "Implement the changes under `examples/dropwizard/` needed for: chore: update docs and examples for 3.4.4 and 0.27.2 releases", "scope_files": [ "examples/dropwizard/pom.xml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `examples/hel...
[ { "subtask_id": "s1", "scope_files": [ "examples/dropwizard/pom.xml" ], "solution_diff": "diff --git a/examples/dropwizard/pom.xml b/examples/dropwizard/pom.xml\nindex 1a0780ecde..ba520eec2d 100644\n--- a/examples/dropwizard/pom.xml\n+++ b/examples/dropwizard/pom.xml\n@@ -26,7 +26,7 @@\n ...
[]
diff --git a/examples/dropwizard/pom.xml b/examples/dropwizard/pom.xml index 1a0780ecde..ba520eec2d 100644 --- a/examples/dropwizard/pom.xml +++ b/examples/dropwizard/pom.xml @@ -26,7 +26,7 @@ <dropwizard-template-config.version>1.5.0</dropwizard-template-config.version> <jib.container.appRoot>/app<...
11
18
GoogleContainerTools/jib#4292
GoogleContainerTools/jib
4,292
18d5c77392964ee417ba563084fe8335cb90a11c
9d6bc0ab5a77c70f58c49d59ec107abc5c13b959
chore: update release workflow Thank you for your interest in contributing! For general guidelines, please refer to the [contributing guide](https://github.com/GoogleContainerTools/jib/blob/master/CONTRIBUTING.md). Please follow the guidelines below before opening an issue or a PR: - [ ] Ensure the issue was not...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: chore: update release workflow ", "scope_files": [ ".github/workflows/jib-cli-release.yml", ".github/workflows/prepare-release.yml" ] } ]
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/jib-cli-release.yml", ".github/workflows/prepare-release.yml" ], "solution_diff": "diff --git a/.github/workflows/jib-cli-release.yml b/.github/workflows/jib-cli-release.yml\nindex db857d627b..2284e1f78e 100644\n--- a/.github/work...
[]
diff --git a/.github/workflows/jib-cli-release.yml b/.github/workflows/jib-cli-release.yml index db857d627b..2284e1f78e 100644 --- a/.github/workflows/jib-cli-release.yml +++ b/.github/workflows/jib-cli-release.yml @@ -56,9 +56,7 @@ jobs: uses: repo-sync/pull-request@v2.12.1 id: create-pr wit...
1
2
GoogleContainerTools/jib#4249
GoogleContainerTools/jib
4,249
8b13f0d1bd4d88d7b3503b570ae065e322daaf47
8eadc59b484b567cad1f32fc2a785a372f71fe9a
feat: determine platform details from local docker installation for jibDockerBuild This code has been tested manually with `jib/examples/helloworld/`. **Notes:** - If manifest list found then the log picks the image that contains the same os and architecture as the local docker environment (derived through `do...
[ { "subtask_id": "s1", "goal": "Implement the changes under `config/checkstyle/` needed for: feat: determine platform details from local docker installation for jibDockerBuild", "scope_files": [ "config/checkstyle/copyright-java.header" ] }, { "subtask_id": "s2", "goal": "Implement ...
[ { "subtask_id": "s1", "scope_files": [ "config/checkstyle/copyright-java.header" ], "solution_diff": "diff --git a/config/checkstyle/copyright-java.header b/config/checkstyle/copyright-java.header\nindex d15ad5912e..e60211cae3 100644\n--- a/config/checkstyle/copyright-java.header\n+++ b/config...
[ { "subtask_id": "s4", "comment": "Shall we error out if no matching found?", "revised_diff": "diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java b/jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java\nindex 46c63bfc9d..be760a13eb 100...
diff --git a/config/checkstyle/copyright-java.header b/config/checkstyle/copyright-java.header index d15ad5912e..e60211cae3 100644 --- a/config/checkstyle/copyright-java.header +++ b/config/checkstyle/copyright-java.header @@ -1,5 +1,5 @@ ^/\*$ -^ \* Copyright 20(17|18|19|20|21|22|23) Google LLC\.$ +^ \* Copyright 20(...
11
12
GoogleContainerTools/jib#4268
GoogleContainerTools/jib
4,268
b06b001ed26b6a1fedc1ac738f628513390433e9
71772a6025cc0dfc84fcfb473e82f9217953d44d
Impossible to build amd-64 docker on Mac M3 machine Starting 3.4.3 version of `jib-maven-plugin` it is not possible to build amd-64 image on Mac with Mx chip (arm-64) I didn't find a setting, that fix it. There is no problem with 3.4.2 version. fix: allow pushing images with different arch/os to docker daemon Fixes...
[ { "subtask_id": "s1", "goal": "Implement the changes under `jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/` needed for: Impossible to build amd-64 docker on Mac M3 machine", "scope_files": [ "jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibIntegrationTest.j...
[ { "subtask_id": "s1", "scope_files": [ "jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibIntegrationTest.java", "jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibMultiPlatformIntegrationTest.java" ], "solution_diff": "diff --git a/jib-core/src/inte...
[ { "subtask_id": "s1", "comment": "TODO(@mpeddada1): Add test for single image build with different os/arch. ", "revised_diff": "diff --git a/jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibIntegrationTest.java b/jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibI...
diff --git a/jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibIntegrationTest.java b/jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibIntegrationTest.java index 4e49d1e12d..bf60f5d025 100644 --- a/jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibIntegrationTes...
3
4
GoogleContainerTools/jib#2273
GoogleContainerTools/jib
2,273
4f438d4c66775a34f433eacd5e3758d69ac00d03
84f8d508452696357280b5ef9faf43d321ceee02
Improve checkstyle config - update checkstyle to 8.29 - improve config modification - add temporary check suppressions so fixes can go in gradually beginning of #2272
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Improve checkstyle config", "scope_files": [ "build.gradle" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `config/checkstyle/` needed for: Improve checkstyle config", "scope_files...
[ { "subtask_id": "s1", "scope_files": [ "build.gradle" ], "solution_diff": "diff --git a/build.gradle b/build.gradle\nindex 259224fa70..2526826d5f 100644\n--- a/build.gradle\n+++ b/build.gradle\n@@ -117,39 +117,27 @@ subprojects {\n \n /* CHECKSTYLE */\n checkstyle {\n- toolVersion = '8....
[ { "subtask_id": "s1", "comment": "refrenced --> referenced", "revised_diff": "diff --git a/build.gradle b/build.gradle\nindex 259224fa70..2526826d5f 100644\n--- a/build.gradle\n+++ b/build.gradle\n@@ -117,39 +117,27 @@ subprojects {\n \n /* CHECKSTYLE */\n checkstyle {\n- toolVersion = '8.18'\n+ ...
diff --git a/build.gradle b/build.gradle index 259224fa70..2526826d5f 100644 --- a/build.gradle +++ b/build.gradle @@ -117,39 +117,27 @@ subprojects { /* CHECKSTYLE */ checkstyle { - toolVersion = '8.18' + toolVersion = '8.29' - // use the google checks packaged with the jar + // use google checks...
2
2
GoogleContainerTools/jib#4192
GoogleContainerTools/jib
4,192
fb34ae43e614f228b62f355458f66a9d00640ce4
81da55ebe4c9530d1827aba1addb6ab4fb7040ea
Update CONTRIBUTING guidelines b/323273546
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Update CONTRIBUTING guidelines", "scope_files": [ "CONTRIBUTING.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/` needed for: Update CONTRIBUTING guidelines", "scope_fi...
[ { "subtask_id": "s1", "scope_files": [ "CONTRIBUTING.md" ], "solution_diff": "diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md\nindex 481284fa9d..aad54536bc 100644\n--- a/CONTRIBUTING.md\n+++ b/CONTRIBUTING.md\n@@ -1,7 +1,13 @@\n+\n+This project is currently stable, and we are primarily focused ...
[ { "subtask_id": "s2", "comment": "I think these checkboxes are still very valid, can we keep them? I know people are not really following them right now but it still helps. ", "revised_diff": "diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md\nindex c30fc7d966..f47aa2784e ...
diff --git a/.github/ISSUE_TEMPLATE/issue_report.md b/.github/ISSUE_TEMPLATE/issue_report.md index 73c5bbeffe..804b3a3f1e 100644 --- a/.github/ISSUE_TEMPLATE/issue_report.md +++ b/.github/ISSUE_TEMPLATE/issue_report.md @@ -8,7 +8,13 @@ assignees: '' --- <!-- -Before filing an issue, please reproduce with the latest...
3
3
GraphiteEditor/Graphite#4198
GraphiteEditor/Graphite
4,198
cde8dd78e69d30404bb9a784fb50a8e79a81382c
fdcd63d9db43cd8fef91b929d90740c835cf12f8
Add graph-storage crate <!-- Graphite has ZERO-TOLERANCE for contributing undisclosed AI-generated content. If your PR involves AI, you must read our AI contribution policy (it's short): https://graphite.art/volunteer/guide/starting-a-task/ai-contribution-policy REMEMBER: - You are responsible for thoroughly te...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Add graph-storage crate", "scope_files": [ "Cargo.lock", "Cargo.toml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `document/graph-storage/` needed for: Add graph-storage crate...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock", "Cargo.toml" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex f3878680c1..88e882908e 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -1921,6 +1921,21 @@ dependencies = [\n \"winit\",\n ]\n \n+[[package]]\n+name = \"grap...
[ { "subtask_id": "s3", "comment": "![security-high](https://www.gstatic.com/codereviewagent/security-high-priority.svg) ![high](https://www.gstatic.com/codereviewagent/high-priority.svg)\n\nTo prevent potential Denial of Service (DoS) or Out of Memory (OOM) vulnerabilities, we should validate the `slot` inde...
diff --git a/Cargo.lock b/Cargo.lock index f3878680c1..88e882908e 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1921,6 +1921,21 @@ dependencies = [ "winit", ] +[[package]] +name = "graph-storage" +version = "0.0.0" +dependencies = [ + "blake3", + "core-types", + "graph-craft", + "graphene-resource", + "rmp-serde", ...
6
20
GraphiteEditor/Graphite#1479
GraphiteEditor/Graphite
1,479
4fdf8410cf31e0a792d701e3c5c5153daeb0141c
4cddea5682d64c0bf54492597c2faa35028a3011
Add a View > Rulers toggle to disable rulers You will store the rulers enabled/disabled status next to `pub view_mode: ViewMode,` in `document_message_handler.rs`, as a boolean called `rulers_visible: bool,`. Then you need to add a `DocumentMessage` message and its handler which enables/disables that, you can call ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `editor/src/messages/frontend/` needed for: Add a View > Rulers toggle to disable rulers", "scope_files": [ "editor/src/messages/frontend/frontend_message.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under ...
[ { "subtask_id": "s1", "scope_files": [ "editor/src/messages/frontend/frontend_message.rs" ], "solution_diff": "diff --git a/editor/src/messages/frontend/frontend_message.rs b/editor/src/messages/frontend/frontend_message.rs\nindex ea04e0ae20..30cff95c35 100644\n--- a/editor/src/messages/fronte...
[]
diff --git a/editor/src/messages/frontend/frontend_message.rs b/editor/src/messages/frontend/frontend_message.rs index ea04e0ae20..30cff95c35 100644 --- a/editor/src/messages/frontend/frontend_message.rs +++ b/editor/src/messages/frontend/frontend_message.rs @@ -173,6 +173,7 @@ pub enum FrontendMessage { origin: (f6...
8
9
GraphiteEditor/Graphite#2182
GraphiteEditor/Graphite
2,182
2d90bb0cbf6925ca23d344ca61b3b7605cd12a09
f23f7ab283155a7b9322aeebd2bda47643530660
Snake-like wires in the node graph Wires between nodes currently follow bendy, angled curves: ![capture](https://github.com/user-attachments/assets/c76da177-298f-411b-ac66-855ad7a969f5) We want to redesign this style of curvature so it follows only right-angle horizontal and vertical paths: ![capture](https:/...
[ { "subtask_id": "s1", "goal": "Implement the changes under `editor/src/messages/dialog/preferences_dialog/` needed for: Snake-like wires in the node graph", "scope_files": [ "editor/src/messages/dialog/preferences_dialog/preferences_dialog_message_handler.rs" ] }, { "subtask_id": "s2",...
[ { "subtask_id": "s1", "scope_files": [ "editor/src/messages/dialog/preferences_dialog/preferences_dialog_message_handler.rs" ], "solution_diff": "diff --git a/editor/src/messages/dialog/preferences_dialog/preferences_dialog_message_handler.rs b/editor/src/messages/dialog/preferences_dialog/pre...
[]
diff --git a/editor/src/messages/dialog/preferences_dialog/preferences_dialog_message_handler.rs b/editor/src/messages/dialog/preferences_dialog/preferences_dialog_message_handler.rs index a4b13e70fb..8c0df6d42c 100644 --- a/editor/src/messages/dialog/preferences_dialog/preferences_dialog_message_handler.rs +++ b/edito...
9
11
GraphiteEditor/Graphite#1731
GraphiteEditor/Graphite
1,731
438c45eb802e75e41aad5ce0ab055c006563a334
fa5a2f87ffd830f9e3b5a5784a6edce777439220
Add alpha to Extract Channel node and remove Extract Alpha node <!-- Please reference any relevant issue number below, optionally with a "Closes"/"Resolves"/"Fixes" prefix --> From `#code-todo-list` ([link](https://discord.com/channels/731730685944922173/881073965047636018/1214825672678309918)): > `ExtractAlphaN...
[ { "subtask_id": "s1", "goal": "Implement the changes under `editor/src/messages/portfolio/document/node_graph/` needed for: Add alpha to Extract Channel node and remove Extract Alpha node", "scope_files": [ "editor/src/messages/portfolio/document/node_graph/document_node_types.rs", "editor/s...
[ { "subtask_id": "s1", "scope_files": [ "editor/src/messages/portfolio/document/node_graph/document_node_types.rs", "editor/src/messages/portfolio/document/node_graph/node_properties.rs" ], "solution_diff": "diff --git a/editor/src/messages/portfolio/document/node_graph/document_node_type...
[]
diff --git a/editor/src/messages/portfolio/document/node_graph/document_node_types.rs b/editor/src/messages/portfolio/document/node_graph/document_node_types.rs index 93dcd47cd7..4a8ffc627e 100644 --- a/editor/src/messages/portfolio/document/node_graph/document_node_types.rs +++ b/editor/src/messages/portfolio/document...
4
5
GraphiteEditor/Graphite#1691
GraphiteEditor/Graphite
1,691
5bca931813e456e2f6035844c21e77ee590b7728
06a8e81c41e117aec74f00885cc674816c5f9bd0
Refresh node graph when changing tabs Currently if you open the node graph (node graph button in the top right) and then switch document tabs, the node graph will not update to reflect the new document until the document is interacted with. See `PortfolioMessage::SelectDocument` and `NodeGraphMessage::SendGraph`. Ref...
[ { "subtask_id": "s1", "goal": "Implement the changes under `editor/src/messages/portfolio/` needed for: Refresh node graph when changing tabs", "scope_files": [ "editor/src/messages/portfolio/portfolio_message_handler.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes un...
[ { "subtask_id": "s1", "scope_files": [ "editor/src/messages/portfolio/portfolio_message_handler.rs" ], "solution_diff": "diff --git a/editor/src/messages/portfolio/portfolio_message_handler.rs b/editor/src/messages/portfolio/portfolio_message_handler.rs\nindex 8c4d14e82d..5f166b8fb0 100644\n--...
[ { "subtask_id": "s2", "comment": "Small nitpick: please add a blank line above this.", "revised_diff": "diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs\nindex 15c9958acb..b8873247a7 100644\n--- a/editor/...
diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs index 15c9958acb..b8873247a7 100644 --- a/editor/src/messages/portfolio/document/document_message_handler.rs +++ b/editor/src/messages/portfolio/document/document_message_...
2
2
GraphiteEditor/Graphite#2640
GraphiteEditor/Graphite
2,640
7a2144e31e8585c0dee22ace18f4dfbae6e9c507
7cae9372008d9d08e6694ed3501157aceb903285
Double-click selecting anchors in a filled region, with anchors disabled, crashes the editor https://github.com/user-attachments/assets/4095e915-3dc7-4de4-8815-f528156046bc Fix editor crash due to mismanaged selected points on layers Fixes #2636
[ { "subtask_id": "s1", "goal": "Implement the changes under `editor/src/messages/tool/common_functionality/` needed for: Double-click selecting anchors in a filled region, with anchors disabled, crashes the editor", "scope_files": [ "editor/src/messages/tool/common_functionality/shape_editor.rs" ...
[ { "subtask_id": "s1", "scope_files": [ "editor/src/messages/tool/common_functionality/shape_editor.rs" ], "solution_diff": "diff --git a/editor/src/messages/tool/common_functionality/shape_editor.rs b/editor/src/messages/tool/common_functionality/shape_editor.rs\nindex 62e7eb45e4..39053e93ac 1...
[]
diff --git a/editor/src/messages/tool/common_functionality/shape_editor.rs b/editor/src/messages/tool/common_functionality/shape_editor.rs index 62e7eb45e4..39053e93ac 100644 --- a/editor/src/messages/tool/common_functionality/shape_editor.rs +++ b/editor/src/messages/tool/common_functionality/shape_editor.rs @@ -44,46...
2
2
GraphiteEditor/Graphite#1078
GraphiteEditor/Graphite
1,078
eac301d6f0e7ff2cf6808c291c52b963758a5d0c
081953706e7d1e2b67679a9d399ff128634c3fee
Crash with zero scale # Steps - Open latest build https://dev.graphite.rs/ - Draw a rectangle - Set the scale or dimensions to 0 in the properties panel by typing in the input field - Confirm with enter - Type a new number into the dimensions or scale field and press enter. - `panicked at 'tried to transform poi...
[ { "subtask_id": "s1", "goal": "Implement the changes under `document-legacy/src/layers/` needed for: Crash with zero scale", "scope_files": [ "document-legacy/src/layers/shape_layer.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `editor/src/messages/portfolio/d...
[ { "subtask_id": "s1", "scope_files": [ "document-legacy/src/layers/shape_layer.rs" ], "solution_diff": "diff --git a/document-legacy/src/layers/shape_layer.rs b/document-legacy/src/layers/shape_layer.rs\nindex 48873ba3d7..43236f7c37 100644\n--- a/document-legacy/src/layers/shape_layer.rs\n+++ ...
[]
diff --git a/document-legacy/src/layers/shape_layer.rs b/document-legacy/src/layers/shape_layer.rs index 48873ba3d7..43236f7c37 100644 --- a/document-legacy/src/layers/shape_layer.rs +++ b/document-legacy/src/layers/shape_layer.rs @@ -59,7 +59,7 @@ impl LayerData for ShapeLayer { fn bounding_box(&self, transform: g...
2
2
GraphiteEditor/Graphite#2052
GraphiteEditor/Graphite
2,052
79408fc0ccb596ff6eb02c0fc19cf08431bd098d
ba654838d1ded026ef51053f0dd151333c26f2c6
When editing text in the viewport, hitting Escape seems to delete all the text When editing text using the text tool, in the viewport, pressing Escape seems to delete the text and the text disappears. Desired behavior is for the Escape button to function the same as rmb when using the text tool. [Discord thread he...
[ { "subtask_id": "s1", "goal": "Implement the changes under `editor/src/messages/input_mapper/` needed for: When editing text in the viewport, hitting Escape seems to delete all the text", "scope_files": [ "editor/src/messages/input_mapper/input_mappings.rs" ] }, { "subtask_id": "s2", ...
[ { "subtask_id": "s1", "scope_files": [ "editor/src/messages/input_mapper/input_mappings.rs" ], "solution_diff": "diff --git a/editor/src/messages/input_mapper/input_mappings.rs b/editor/src/messages/input_mapper/input_mappings.rs\nindex bccaadef53..5b2c759aeb 100644\n--- a/editor/src/messages/...
[]
diff --git a/editor/src/messages/input_mapper/input_mappings.rs b/editor/src/messages/input_mapper/input_mappings.rs index bccaadef53..5b2c759aeb 100644 --- a/editor/src/messages/input_mapper/input_mappings.rs +++ b/editor/src/messages/input_mapper/input_mappings.rs @@ -151,7 +151,7 @@ pub fn input_mappings() -> Mappin...
2
2
GraphiteEditor/Graphite#43
GraphiteEditor/Graphite
43
27e7332e3f77af6ffee74f9ca537e671bcfdaf40
fdf9d2c11c8d3e48cf9c90ddf0a24ceb1dc0477c
Implement update_colors
[ { "subtask_id": "s1", "goal": "Implement the changes under `client/web/wasm/src/` needed for: Implement update_colors", "scope_files": [ "client/web/wasm/src/viewport.rs", "client/web/wasm/src/wrappers.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `core/...
[ { "subtask_id": "s1", "scope_files": [ "client/web/wasm/src/viewport.rs", "client/web/wasm/src/wrappers.rs" ], "solution_diff": "diff --git a/client/web/wasm/src/viewport.rs b/client/web/wasm/src/viewport.rs\nindex 6deaa21505..2eaabbb98b 100644\n--- a/client/web/wasm/src/viewport.rs\n+++...
[]
diff --git a/client/web/wasm/src/viewport.rs b/client/web/wasm/src/viewport.rs index 6deaa21505..2eaabbb98b 100644 --- a/client/web/wasm/src/viewport.rs +++ b/client/web/wasm/src/viewport.rs @@ -24,5 +24,7 @@ pub fn on_mouse_move(x: u32, y: u32) { /// Update working colors #[wasm_bindgen] pub fn update_colors(primar...
2
3
GraphiteEditor/Graphite#2307
GraphiteEditor/Graphite
2,307
2d1837882355a84b2fe58d6c1991433856dd466a
9a96551b6bd601b9f91249c611a44147350ae982
New node: Merge by Distance Here's a patch that adds a new node to collapse segments with chord shorter than a distance (parameter to the node). It's not finished but this version works - I tried it out by drawing freehand then watching the segments collapse as the distance increases. Things still to do: - [x] A...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: New node: Merge by Distance", "scope_files": [ "Cargo.lock", "Cargo.toml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `node-graph/gcore/` needed for: New node: Merge by Distan...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock", "Cargo.toml" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex df363e2164..830d8ac025 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -1751,6 +1751,12 @@ version = \"0.4.2\"\n source = \"registry+https://github.com/rust-l...
[ { "subtask_id": "s5", "comment": "TODO this is dead and will be removed", "revised_diff": "diff --git a/node-graph/gcore/src/vector/vector_data/attributes.rs b/node-graph/gcore/src/vector/vector_data/attributes.rs\nindex 57c5289f8a..bb7ed2ae88 100644\n--- a/node-graph/gcore/src/vector/vector_data/attrib...
diff --git a/Cargo.lock b/Cargo.lock index df363e2164..830d8ac025 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1751,6 +1751,12 @@ version = "0.4.2" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "0ce7134b9999ecaf8bcd65542e436736ef32ddca1b3e06094cb6ec5755203b80" +[[package]] +name = "fix...
5
10
GraphiteEditor/Graphite#1860
GraphiteEditor/Graphite
1,860
e1df23c28e96907c57b6067c51153c512db6289e
e1c734a3bcb8afe0c1aa7aaa2e93f7f2d96f5a5b
Fix spelling in several code comments
[ { "subtask_id": "s1", "goal": "Implement the changes under `node-graph/gcore/src/` needed for: Fix spelling in several code comments", "scope_files": [ "node-graph/gcore/src/transform.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `node-graph/gcore/src/raster/`...
[ { "subtask_id": "s1", "scope_files": [ "node-graph/gcore/src/transform.rs" ], "solution_diff": "diff --git a/node-graph/gcore/src/transform.rs b/node-graph/gcore/src/transform.rs\nindex 357bf4c50f..7d387362ef 100644\n--- a/node-graph/gcore/src/transform.rs\n+++ b/node-graph/gcore/src/transform...
[]
diff --git a/node-graph/gcore/src/raster/adjustments.rs b/node-graph/gcore/src/raster/adjustments.rs index 4b511d3ddd..968bccec82 100644 --- a/node-graph/gcore/src/raster/adjustments.rs +++ b/node-graph/gcore/src/raster/adjustments.rs @@ -1083,7 +1083,7 @@ fn selective_color_node( .into_iter() .fold((0., 0., 0.), |...
4
4
GraphiteEditor/Graphite#1214
GraphiteEditor/Graphite
1,214
cfe38c6413f6bb6e28bacf9a72d9fe2aad0b90a3
a7d8bb108669c0bb64d78583a055d4058a42203b
Curves image adjustment node
[ { "subtask_id": "s1", "goal": "Implement the changes under `editor/src/messages/layout/` needed for: Curves image adjustment node", "scope_files": [ "editor/src/messages/layout/layout_message_handler.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `editor/src/me...
[ { "subtask_id": "s1", "scope_files": [ "editor/src/messages/layout/layout_message_handler.rs" ], "solution_diff": "diff --git a/editor/src/messages/layout/layout_message_handler.rs b/editor/src/messages/layout/layout_message_handler.rs\nindex 8b3d1fc28e..f32f3bc4b8 100644\n--- a/editor/src/mes...
[]
diff --git a/editor/src/messages/layout/layout_message_handler.rs b/editor/src/messages/layout/layout_message_handler.rs index 8b3d1fc28e..f32f3bc4b8 100644 --- a/editor/src/messages/layout/layout_message_handler.rs +++ b/editor/src/messages/layout/layout_message_handler.rs @@ -123,6 +123,12 @@ impl<F: Fn(&MessageDiscr...
19
29
GraphiteEditor/Graphite#1082
GraphiteEditor/Graphite
1,082
508726d73ffc53e544bea976f1b32a76a0a3399b
ad2b0f6eeb7bc0461116f5d424d45b580951d97a
Bezier-rs: Add lookup table function for subpath and make it support euclidean parameterization <!-- Please reference any relevant issue number below, optionally with a "Closes"/"Resolves"/"Fixes" prefix --> Added `compute_lookup_table` to subpath class. Added `tvalue_type: Option<TValueType>` to `compute_lookup_tab...
[ { "subtask_id": "s1", "goal": "Implement the changes under `editor/src/messages/tool/common_functionality/` needed for: Bezier-rs: Add lookup table function for subpath and make it support euclidean parameterization", "scope_files": [ "editor/src/messages/tool/common_functionality/shape_editor.rs"...
[ { "subtask_id": "s1", "scope_files": [ "editor/src/messages/tool/common_functionality/shape_editor.rs" ], "solution_diff": "diff --git a/editor/src/messages/tool/common_functionality/shape_editor.rs b/editor/src/messages/tool/common_functionality/shape_editor.rs\nindex 6407c8d68e..1034fae195 1...
[]
diff --git a/editor/src/messages/tool/common_functionality/shape_editor.rs b/editor/src/messages/tool/common_functionality/shape_editor.rs index 6407c8d68e..1034fae195 100644 --- a/editor/src/messages/tool/common_functionality/shape_editor.rs +++ b/editor/src/messages/tool/common_functionality/shape_editor.rs @@ -375,7...
6
11
GraphiteEditor/Graphite#1650
GraphiteEditor/Graphite
1,650
c3a886116aa3a17f205496a7928d207b938c9818
7eac88e2bc4fc2c71a600996edda3cba0714d3aa
Solidify stroke node Convert `outline` (from #1083) in bezier-rs into a node. And as a bonus, add a button to the options bar of the Select tool for this node to be inserted at the appropriate place in the graph for the selected vector layer(s) when clicked. New node: Solidify Stroke This node can be added after a s...
[ { "subtask_id": "s1", "goal": "Implement the changes under `editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/` needed for: Solidify stroke node", "scope_files": [ "editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs" ]...
[ { "subtask_id": "s1", "scope_files": [ "editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs" ], "solution_diff": "diff --git a/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs b/editor/src/messag...
[]
diff --git a/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs b/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs index 037b1a917d..ea2e3b3d13 100644 --- a/editor/src/messages/portfolio/document/node_graph/node_graph_me...
3
4
GraphiteEditor/Graphite#2110
GraphiteEditor/Graphite
2,110
337b8bad13cb7920bc9551bf872c651c45f77bd0
3bcefafe426f84381a435a7b239d3f9a9f995e8e
Smarter placement of layers into the artboards that bound them Currently, new layers are drawn, they are placed into the last selected artboard. To improve upon this, we want: - [x] Placing layers in correct artboard based on its location within the bounds of any artboard (#2110) - [ ] Transferring layers between ar...
[ { "subtask_id": "s1", "goal": "Implement the changes under `editor/src/messages/portfolio/document/` needed for: Smarter placement of layers into the artboards that bound them", "scope_files": [ "editor/src/messages/portfolio/document/document_message_handler.rs" ] }, { "subtask_id": "...
[ { "subtask_id": "s1", "scope_files": [ "editor/src/messages/portfolio/document/document_message_handler.rs" ], "solution_diff": "diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs\nindex 502438fc3...
[]
diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs index 502438fc3b..9131341cee 100644 --- a/editor/src/messages/portfolio/document/document_message_handler.rs +++ b/editor/src/messages/portfolio/document/document_message_...
2
9
GraphiteEditor/Graphite#1399
GraphiteEditor/Graphite
1,399
48fdaddc37b8123348d412ee67288bbaf81607bf
c5799da97b1518ee72dc9930b88e04df7f84cf4b
New nodes: Logical boolean operations (OR, AND, XOR, NOT) Adds these boolean operator nodes: - Not - And - OR - XOR
[ { "subtask_id": "s1", "goal": "Implement the changes under `editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/` needed for: New nodes: Logical boolean operations (OR, AND, XOR, NOT)", "scope_files": [ "editor/src/messages/portfolio/document/node_graph/node_graph_message_...
[ { "subtask_id": "s1", "scope_files": [ "editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs", "editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/node_properties.rs" ], "solution_diff": "diff --git a/editor/src/mes...
[ { "subtask_id": "s1", "comment": "Thoughts on capitalisation @Keavon? They are often capitalised in logic but look slightly out of place with the other title case nodes.", "revised_diff": "diff --git a/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs b/...
diff --git a/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs b/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs index f3d360e9eb..265219c687 100644 --- a/editor/src/messages/portfolio/document/node_graph/node_graph_me...
3
5
GraphiteEditor/Graphite#622
GraphiteEditor/Graphite
622
70ba704058f1bb9076f8c5ade69410348e62faed
b82c5721b3c2f4c4a38c59f1688f393dbf4f34cb
Add a shortcut to pick a random color This would be useful for testing and probably useful for actual art some of the time as well. Perhaps it could be added to, I'll just arbitrarily say, <kbd>Alt</kbd><kbd>C</kbd>. It would replace the primary color swatch with a randomly picked hue, saturation, and value. Select r...
[ { "subtask_id": "s1", "goal": "Implement the changes under `editor/src/input/` needed for: Add a shortcut to pick a random color", "scope_files": [ "editor/src/input/input_mapper.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `editor/src/viewport_tools/` needed...
[ { "subtask_id": "s1", "scope_files": [ "editor/src/input/input_mapper.rs" ], "solution_diff": "diff --git a/editor/src/input/input_mapper.rs b/editor/src/input/input_mapper.rs\nindex 715fd322c4..2bf39cfa52 100644\n--- a/editor/src/input/input_mapper.rs\n+++ b/editor/src/input/input_mapper.rs\n...
[ { "subtask_id": "s2", "comment": "This looks nice and clean! The one thing is that I think it would be more useful if it's always opaque, so can you please modify this so the alpha value is always 1? Thanks!", "revised_diff": "diff --git a/editor/src/viewport_tools/tool_message_handler.rs b/editor/src/v...
diff --git a/editor/src/input/input_mapper.rs b/editor/src/input/input_mapper.rs index 715fd322c4..2bf39cfa52 100644 --- a/editor/src/input/input_mapper.rs +++ b/editor/src/input/input_mapper.rs @@ -142,7 +142,8 @@ impl Default for Mapping { // Colors entry! {action=ToolMessage::ResetColors, key_down=KeyX, modi...
2
3
GraphiteEditor/Graphite#3222
GraphiteEditor/Graphite
3,222
f186465220b583606f1c5517f6c37d47e947470a
2531ee750262a4d9123074e169ffcf3da2a47b13
Hints for G/R/S on the path tool don't show ## Reproduction With the select tool, you can select a layer and press <kbd>G</kbd> to apply a translation to it (like in blender). At the bottom of the screen some hints show as to available operations <img width="535" height="271" alt="Image" src="https://github.com/user...
[ { "subtask_id": "s1", "goal": "Implement the changes under `editor/src/messages/tool/common_functionality/` needed for: Hints for G/R/S on the path tool don't show", "scope_files": [ "editor/src/messages/tool/common_functionality/shape_editor.rs" ] }, { "subtask_id": "s2", "goal": ...
[ { "subtask_id": "s1", "scope_files": [ "editor/src/messages/tool/common_functionality/shape_editor.rs" ], "solution_diff": "diff --git a/editor/src/messages/tool/common_functionality/shape_editor.rs b/editor/src/messages/tool/common_functionality/shape_editor.rs\nindex f102bbb56f..0183d65cc3 1...
[]
diff --git a/editor/src/messages/tool/common_functionality/shape_editor.rs b/editor/src/messages/tool/common_functionality/shape_editor.rs index f102bbb56f..0183d65cc3 100644 --- a/editor/src/messages/tool/common_functionality/shape_editor.rs +++ b/editor/src/messages/tool/common_functionality/shape_editor.rs @@ -1879,...
2
2
GraphiteEditor/Graphite#215
GraphiteEditor/Graphite
215
8a56d6cf465928681594e2935bb642e81b921040
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
Support for closing document tabs Click the X button in a tab to close it. Also <kbd>Ctrl</kbd><kbd>W</kbd> closes the current tab (warning: you can't test this yet, it'll close your browser tab also). This needs a confirmation to prevent loss of work. It also needs to handle what happens when all tabs are closed, per...
[ { "subtask_id": "s1", "goal": "Implement the changes under `client/web/src/` needed for: Support for closing document tabs", "scope_files": [ "client/web/src/response-handler.ts" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `client/web/src/components/workspace/` ...
[ { "subtask_id": "s1", "scope_files": [ "client/web/src/response-handler.ts" ], "solution_diff": "diff --git a/client/web/src/response-handler.ts b/client/web/src/response-handler.ts\nindex 5f842644ad..11c05191b5 100644\n--- a/client/web/src/response-handler.ts\n+++ b/client/web/src/response-ha...
[ { "subtask_id": "s4", "comment": "atleat -> atleast (also we usually don't end comments with a period but that's an unimportant nitpick)\r\n\r\nI will review the rest of this later for you but I wanted to point out this typo in case I missed it on a later pass.", "revised_diff": "diff --git a/core/edito...
diff --git a/client/web/src/components/workspace/Panel.vue b/client/web/src/components/workspace/Panel.vue index dc167abf79..5b59705a3c 100644 --- a/client/web/src/components/workspace/Panel.vue +++ b/client/web/src/components/workspace/Panel.vue @@ -4,7 +4,7 @@ <div class="tab-group"> <div class="tab" :class=...
6
7
GraphiteEditor/Graphite#3565
GraphiteEditor/Graphite
3,565
8b67840f0c24f83f461b1dfa348a8649113f3204
fb4891207439be1dbef67bf61a477ae4ed3365ad
QR Code Node Novelty QR Codes (rounded corners, graphic overlay in center, gradient mask..) are pretty common nowadays, and they seem well-suited to Graphite's render pipeline, and especially its ImageMagick-style cli workflow. I propose a QR Code Generator node that returns a vector QR Code when given a string, and p...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: QR Code Node", "scope_files": [ "Cargo.lock", "Cargo.toml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `node-graph/nodes/vector/` needed for: QR Code Node", "scope_files":...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock", "Cargo.toml" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex fc6ef1afe1..532c79277a 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -4659,6 +4659,12 @@ dependencies = [\n \"bytemuck\",\n ]\n \n+[[package]]\n+name = \"q...
[ { "subtask_id": "s3", "comment": "```suggestion\n#[node_macro::node(category(\"Vector: Shape\"), name(\"QR Code\"))]\n```", "revised_diff": "diff --git a/node-graph/nodes/vector/src/generator_nodes.rs b/node-graph/nodes/vector/src/generator_nodes.rs\nindex 098b1782ac..2d1b1a26de 100644\n--- a/node-graph...
diff --git a/Cargo.lock b/Cargo.lock index fc6ef1afe1..532c79277a 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -4659,6 +4659,12 @@ dependencies = [ "bytemuck", ] +[[package]] +name = "qrcodegen" +version = "1.8.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "4339fc7a1021c9c1621d87f...
3
6
GraphiteEditor/Graphite#2727
GraphiteEditor/Graphite
2,727
4a65ad290c1c4d5042a70e7f97fd440b79c3ca18
5be3a43037a05a946d4ca1fa4be43697a9ea8eb8
Sample Points should have option to sample by count (like in blender) Currently can only set desired distance between points. Rename 'Sample Points' node to 'Sample Polyline' and add a parameter spacing based on separation or quantity Closes #2720
[ { "subtask_id": "s1", "goal": "Implement the changes under `demo-artwork/` needed for: Sample Points should have option to sample by count (like in blender)", "scope_files": [ "demo-artwork/parametric-dunescape.graphite", "demo-artwork/procedural-string-lights.graphite", "demo-artwork/...
[ { "subtask_id": "s1", "scope_files": [ "demo-artwork/parametric-dunescape.graphite", "demo-artwork/procedural-string-lights.graphite", "demo-artwork/red-dress.graphite" ], "solution_diff": "diff --git a/demo-artwork/parametric-dunescape.graphite b/demo-artwork/parametric-dunescape....
[ { "subtask_id": "s3", "comment": "Please be consistent with Title Case.", "revised_diff": "diff --git a/editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs b/editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs\nindex af8f6bd130..729334dc52 100644\n--...
diff --git a/demo-artwork/parametric-dunescape.graphite b/demo-artwork/parametric-dunescape.graphite index 86ba52f545..0cc3a05d88 100644 --- a/demo-artwork/parametric-dunescape.graphite +++ b/demo-artwork/parametric-dunescape.graphite @@ -1,1 +1,1 @@ -{"network_interface":{"network":{"exports":[{"Node":{"node_id":44459...
8
12