task_id
stringlengths
10
58
repo
stringclasses
854 values
pr_number
int32
1
321k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
task
stringlengths
2
105k
plan
listlengths
1
100
subagents
listlengths
1
100
revisions
listlengths
0
100
final_diff
stringlengths
256
202M
num_subtasks
int32
1
100
num_changed_files
int32
2
100
BloopAI/vibe-kanban#3217
BloopAI/vibe-kanban
3,217
40223b4163a619b26bc9c9c1ae20f39680170a0a
07b42a2300b3491ff6c20c706fea5b3ba84a0a5c
Add notification click handling for Windows, macOS, and Linux (Vibe Kanban) ## Summary When a user clicks an OS notification, the app now opens and navigates to the relevant workspace page. This works across all three desktop platforms. ### Problem `tauri-plugin-notification` v2 has no desktop click handling — click...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Add notification click handling for Windows, macOS, and Linux (Vibe Kanban)", "scope_files": [ "Cargo.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `crates/server-info/` needed ...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex 3a9d4e460aa..0e2a1b4a2d4 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -33,7 +33,7 @@ version = \"0.5.2\"\n source = \"registry+https://github.com/rust-lang/crates.io-index\"\n...
[ { "subtask_id": "s4", "comment": "### macOS notification click won't focus window without deeplinkPath\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nOn macOS, the window `show()`/`set_focus()` logic is nested inside the `if let Some(value) = deeplink` block. When a notification has no `deeplinkPath`...
diff --git a/Cargo.lock b/Cargo.lock index 3a9d4e460aa..0e2a1b4a2d4 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -33,7 +33,7 @@ version = "0.5.2" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "d122413f284cf2d62fb1b7db97e02edb8cda96d769b16e443a4f6195e35662b0" dependencies = [ - "crypto-co...
6
10
BloopAI/vibe-kanban#3299
BloopAI/vibe-kanban
3,299
abe62af2ba655a6a370b26411521fe2d7fde2116
95dafa61d4fabfdf7d6949efbc422060e0895b36
feat: add "Hide blocked" filter toggle to kanban board (Vibe Kanban) ## Summary - Adds a **"Hide blocked"** toggle to the kanban filter dialog that hides issues blocked by unresolved blocking relationships - Issues are considered blocked when they have a `blocking` relationship where the blocking issue is not yet in ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `crates/db/.sqlx/` needed for: feat: add \"Hide blocked\" filter toggle to kanban board (Vibe Kanban)", "scope_files": [ "crates/db/.sqlx/query-04e5a05c7cad438d39c4c8590410889ab1eefa7376d474a10c119d3f4d9143c7.json", "crates/db/.sqlx/...
[ { "subtask_id": "s1", "scope_files": [ "crates/db/.sqlx/query-04e5a05c7cad438d39c4c8590410889ab1eefa7376d474a10c119d3f4d9143c7.json", "crates/db/.sqlx/query-0ac0d0f3826330836e3fd1bf57c42777eb489ac41a650f9361e6b563fc69bf35.json", "crates/db/.sqlx/query-29cc3aa8d0ad5deda94494402500a4125e2938...
[ { "subtask_id": "s4", "comment": "### Blocking filter scans all relationships per issue without lookup map\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `hideBlocked` filter iterates over the entire `issueRelationships` array for every issue in `result`, giving O(n×m) complexity. The existing assig...
diff --git a/crates/db/.sqlx/query-04e5a05c7cad438d39c4c8590410889ab1eefa7376d474a10c119d3f4d9143c7.json b/crates/db/.sqlx/query-04e5a05c7cad438d39c4c8590410889ab1eefa7376d474a10c119d3f4d9143c7.json deleted file mode 100644 index d089f210423..00000000000 --- a/crates/db/.sqlx/query-04e5a05c7cad438d39c4c8590410889ab1eef...
9
20
BloopAI/vibe-kanban#3283
BloopAI/vibe-kanban
3,283
f1c3cfa13315e421442397239b397a77d4e85da8
bea0ad443bb15636843351f6ffc829df2681bcfd
Fix connection failed when viewing logs in Tauri app (Vibe Kanban) ## Summary Fixes persistent "Connection failed" errors in the logs panel and fix script dialog, particularly when: - A coding agent finishes running (live logs replaced by error) - Viewing logs for any already-completed process (always shows error) #...
[ { "subtask_id": "s1", "goal": "Implement the changes under `crates/server/src/routes/` needed for: Fix connection failed when viewing logs in Tauri app (Vibe Kanban)", "scope_files": [ "crates/server/src/routes/execution_processes.rs" ] }, { "subtask_id": "s2", "goal": "Implement t...
[ { "subtask_id": "s1", "scope_files": [ "crates/server/src/routes/execution_processes.rs" ], "solution_diff": "diff --git a/crates/server/src/routes/execution_processes.rs b/crates/server/src/routes/execution_processes.rs\nindex ab698ce5d6c..425d0694264 100644\n--- a/crates/server/src/routes/ex...
[ { "subtask_id": "s3", "comment": "### Error never shown because `dataRef.current` is always truthy\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe condition `!dataRef.current && retryAttemptsRef.current > 6` is always false, so the \"Connection failed\" error is never displayed. `dataRef.current` ...
diff --git a/crates/server/src/routes/execution_processes.rs b/crates/server/src/routes/execution_processes.rs index ab698ce5d6c..425d0694264 100644 --- a/crates/server/src/routes/execution_processes.rs +++ b/crates/server/src/routes/execution_processes.rs @@ -7,7 +7,7 @@ use axum::{ routing::{get, post}, }; use...
3
4
BloopAI/vibe-kanban#3281
BloopAI/vibe-kanban
3,281
37190901b6396261e6283667d48b91d619f74d64
ece9c26abd00a9282f00f95e8d66b71f601b9c88
fix: make live diff stream accurate and self-correcting Eliminates stale/incorrect diff stats in the session chat box during live changes. - efficient periodic reconciliation (5s) to self-correct drift - atomic full diff state reset - debounced resets (1s) on HEAD changes (checkout/rebase) - avoid full reset on ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `crates/executors/src/logs/utils/` needed for: fix: make live diff stream accurate and self-correcting", "scope_files": [ "crates/executors/src/logs/utils/patch.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes ...
[ { "subtask_id": "s1", "scope_files": [ "crates/executors/src/logs/utils/patch.rs" ], "solution_diff": "diff --git a/crates/executors/src/logs/utils/patch.rs b/crates/executors/src/logs/utils/patch.rs\nindex f19317007a1..2ee3471a9a7 100644\n--- a/crates/executors/src/logs/utils/patch.rs\n+++ b/...
[ { "subtask_id": "s3", "comment": "### Consecutive commits trigger unnecessary full resets\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\n`handle_git_state_change` doesn't update `last_head_commit` when it identifies a simple commit (fast path). A second commit arriving before the 5-second reconcile cycl...
diff --git a/crates/executors/src/logs/utils/patch.rs b/crates/executors/src/logs/utils/patch.rs index f19317007a1..2ee3471a9a7 100644 --- a/crates/executors/src/logs/utils/patch.rs +++ b/crates/executors/src/logs/utils/patch.rs @@ -1,4 +1,7 @@ -use std::{collections::HashSet, sync::Arc}; +use std::{ + collections::...
4
4
BloopAI/vibe-kanban#3248
BloopAI/vibe-kanban
3,248
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs ## Summary Full rewrite of the diff viewer rendering pipeline. Replaces TanStack Virtual with Pierre's native `<Virtualizer>`, optimizes for 300+ file PRs in Tauri/WKWebView, and adds file-in-view tracking with tree auto-sc...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs", "scope_files": [ "Cargo.lock", "pnpm-lock.yaml", "pnpm-workspace.yaml" ] }, { "subtask_id": "s2"...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock", "pnpm-lock.yaml", "pnpm-workspace.yaml" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex be0591b7ce9..bee253883b8 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -8788,6 +8788,19 @@ dependencies = [\n \"walkdir\",...
[ { "subtask_id": "s23", "comment": "### Effect cleanup clears store on every dependency change\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\nThe `useEffect` cleanup calls `clearWorkspaceDiffData()` on every dependency change, not just on unmount. Since `diffs`, `diffPaths`, `diffStats`, etc. change fre...
diff --git a/Cargo.lock b/Cargo.lock index be0591b7ce9..bee253883b8 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -8788,6 +8788,19 @@ dependencies = [ "walkdir", ] +[[package]] +name = "tauri-plugin-macos-fps" +version = "0.1.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "11177f7c9...
25
54
BloopAI/vibe-kanban#3139
BloopAI/vibe-kanban
3,139
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
Add WebRTC direct tunneling with relay fallback ## Summary Adds WebRTC data channel transport for direct host-to-host connectivity, bypassing the relay server for lower latency. Falls back to relay transparently when WebRTC isn't available. ### New crates - **`relay-webrtc`** — WebRTC client/host peers, signaling, H...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Add WebRTC direct tunneling with relay fallback", "scope_files": [ "Cargo.lock", "Cargo.toml", "Dockerfile" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflow...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock", "Cargo.toml", "Dockerfile" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex be0591b7ce9..81b832438d0 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -275,6 +275,15 @@ dependencies = [\n \"x11rb\",\n ]\n \n+[[packa...
[ { "subtask_id": "s20", "comment": "### Multi-valued HTTP headers silently dropped via WebRTC\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nBoth the server-side proxy (`peer.rs`) and the client-side request builder (`relay-hosts/src/lib.rs`) convert HTTP headers into `HashMap<String, String>`, which ...
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 118f9d3bf58..246d170b0f2 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -73,8 +73,10 @@ jobs: - 'crates/relay-client/**' - 'crates/relay-control/**' - 'crates/relay-hosts/...
35
69
BloopAI/vibe-kanban#3264
BloopAI/vibe-kanban
3,264
76c818f7a3dc83bf1e5d308738a1f48a1a7d2c24
a9367cee105793c0c3004623737b2c143bc20e63
bump codex <!-- CURSOR_SUMMARY --> > [!NOTE] > **Medium Risk** > Moderate risk because it upgrades Codex protocol/CLI versions and significantly expands log normalization for new JSON-RPC request/notification shapes (dynamic tools, direct item events), which could affect session rendering and approval flows. > > **Ov...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: bump codex", "scope_files": [ "Cargo.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `crates/executors/` needed for: bump codex", "scope_files": [ "crates/executors/Carg...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex be0591b7ce9..c9421c7b805 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -1128,8 +1128,8 @@ checksum = \"e9b18233253483ce2f65329a24072ec414db782531bdbb7d0bbc4bd2ce6b7e21\"\n \n [...
[ { "subtask_id": "s4", "comment": "### Fallback creates invisible command state without UI entry\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `update_tool_status` fallback for unknown `call_id`s with `PendingApproval` status creates a new `CommandState` via `command_state()`, which always starts...
diff --git a/Cargo.lock b/Cargo.lock index be0591b7ce9..c9421c7b805 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1128,8 +1128,8 @@ checksum = "e9b18233253483ce2f65329a24072ec414db782531bdbb7d0bbc4bd2ce6b7e21" [[package]] name = "codex-app-server-protocol" -version = "0.114.0" -source = "git+https://github.com/opena...
5
7
BloopAI/vibe-kanban#3275
BloopAI/vibe-kanban
3,275
695efaf4275e9f1e281f4e4d85c40530d2b37957
ad962d02c1f8bd7aa26744d61a154170509bdf8a
POC: Replace TanStack Virtual with Pierre native Virtualizer ## Summary Replace TanStack Virtual with Pierre's native `<Virtualizer>` for the diff panel. POC branch to validate the approach before merging into the main diff optimization PR. ### Architecture Change **Before:** `TanStack Virtual` → `PierreDiffCard` →...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: POC: Replace TanStack Virtual with Pierre native Virtualizer", "scope_files": [ "pnpm-lock.yaml", "pnpm-workspace.yaml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `packages/u...
[ { "subtask_id": "s1", "scope_files": [ "pnpm-lock.yaml", "pnpm-workspace.yaml" ], "solution_diff": "diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml\nindex 888abb651fa..fb6b91759af 100644\n--- a/pnpm-lock.yaml\n+++ b/pnpm-lock.yaml\n@@ -4,6 +4,11 @@ settings:\n autoInstallPeers: true\n e...
[ { "subtask_id": "s6", "comment": "### Hardcoded mock `|| 3` shows fake GitHub comment count\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\n`githubCommentCount` falls back to `3` via `|| 3` when `githubCommentsForFile.length` is `0`. This means every file with zero GitHub comments will display a badge s...
diff --git a/packages/ui/package.json b/packages/ui/package.json index 78d897b41b5..ba084261214 100644 --- a/packages/ui/package.json +++ b/packages/ui/package.json @@ -25,7 +25,7 @@ "@lexical/react": "^0.36.2", "@lexical/table": "^0.36.2", "@phosphor-icons/react": "^2.1.10", - "@pierre/diffs": "^1.1....
11
20
BloopAI/vibe-kanban#3279
BloopAI/vibe-kanban
3,279
102b291ff3c1d628bc75ca67c33998c2863633a8
58682e7ce50e74bad2df10bf9632988d8d47944c
fix(tauri): use dynamic frontend port for dev mode ## Summary - The Tauri dev script (`tauri:dev`) had a hardcoded `devUrl` of `http://localhost:3000`, but the frontend port is dynamically assigned and often lands on 3001 or 3002 - The Tauri app's `main.rs` also had `http://localhost:3000` hardcoded for the dev webvie...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: fix(tauri): use dynamic frontend port for dev mode", "scope_files": [ "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `crates/tauri-app/src/` needed for: fix(tauri): use ...
[ { "subtask_id": "s1", "scope_files": [ "package.json" ], "solution_diff": "diff --git a/package.json b/package.json\nindex 5b4634fe0c6..ae7e0acea32 100644\n--- a/package.json\n+++ b/package.json\n@@ -48,7 +48,7 @@\n \"remote:dev:clean\": \"cd crates/remote && docker compose --env-file .env...
[]
diff --git a/crates/tauri-app/src/main.rs b/crates/tauri-app/src/main.rs index 88d768db95b..d3295ae018a 100644 --- a/crates/tauri-app/src/main.rs +++ b/crates/tauri-app/src/main.rs @@ -120,10 +120,13 @@ fn main() { // Dev mode: frontend dev server (Vite) and backend are started // exte...
2
2
BloopAI/vibe-kanban#3276
BloopAI/vibe-kanban
3,276
ce59de9112161fcde26d7ab776ca8e3fb57f3895
b2917a6e039b9a2705c346661aa395f8387d8637
Render Markdown in Diff PR Comments (Vibe Kanban) ## Summary This PR fixes PR comment rendering in the diffs view so GitHub PR comments display as Markdown instead of plain text. ## What Changed - Updated `GitHubCommentRenderer` to render `comment.body` with `MarkdownPreview` instead of a plain text `<div>`. - Added ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `packages/web-core/src/pages/workspaces/` needed for: Render Markdown in Diff PR Comments (Vibe Kanban)", "scope_files": [ "packages/web-core/src/pages/workspaces/GitHubCommentRenderer.tsx", "packages/web-core/src/pages/workspaces/Pi...
[ { "subtask_id": "s1", "scope_files": [ "packages/web-core/src/pages/workspaces/GitHubCommentRenderer.tsx", "packages/web-core/src/pages/workspaces/PierreDiffCard.tsx" ], "solution_diff": "diff --git a/packages/web-core/src/pages/workspaces/GitHubCommentRenderer.tsx b/packages/web-core/sr...
[]
diff --git a/packages/web-core/src/pages/workspaces/GitHubCommentRenderer.tsx b/packages/web-core/src/pages/workspaces/GitHubCommentRenderer.tsx index c937f9e292c..869d05e77d2 100644 --- a/packages/web-core/src/pages/workspaces/GitHubCommentRenderer.tsx +++ b/packages/web-core/src/pages/workspaces/GitHubCommentRenderer...
1
2
BloopAI/vibe-kanban#3262
BloopAI/vibe-kanban
3,262
1660e3f644a7294ad74491922f2b49494760fc8e
792841adf3335f6fffdc18e3a24f3d76a95bf628
chore: remove dead code and tighten boundaries <!-- CURSOR_SUMMARY --> > [!NOTE] > **Low Risk** > Primarily deletes unused functions/types and narrows visibility (`pub` -> `pub(crate)`/private) without changing core algorithms; main risk is unintended downstream compile breakage where removed APIs were still reference...
[ { "subtask_id": "s1", "goal": "Implement the changes under `crates/api-types/src/` needed for: chore: remove dead code and tighten boundaries", "scope_files": [ "crates/api-types/src/issue_assignee.rs", "crates/api-types/src/issue_follower.rs", "crates/api-types/src/issue_relationship....
[ { "subtask_id": "s1", "scope_files": [ "crates/api-types/src/issue_assignee.rs", "crates/api-types/src/issue_follower.rs", "crates/api-types/src/issue_relationship.rs", "crates/api-types/src/issue_tag.rs" ], "solution_diff": "diff --git a/crates/api-types/src/issue_assignee.r...
[]
diff --git a/crates/api-types/src/issue_assignee.rs b/crates/api-types/src/issue_assignee.rs index 46839b843ea..2067b4562c4 100644 --- a/crates/api-types/src/issue_assignee.rs +++ b/crates/api-types/src/issue_assignee.rs @@ -3,8 +3,6 @@ use serde::{Deserialize, Serialize}; use ts_rs::TS; use uuid::Uuid; -use crate:...
33
100
BloopAI/vibe-kanban#3265
BloopAI/vibe-kanban
3,265
9a0fb95505b20ddfd247dc0e4750e6d8ac306110
1764f9957c930b2fd5de52dc34cd261b46d7eb28
fix(wysiwyg): restore full WYSIWYG editing, fix code escape bugs ## Summary Reverts the edit/preview mode split that was introduced as a workaround for code block and inline code escape issues. Instead of working around these Lexical bugs, this PR fixes them directly: - **Restore MarkdownShortcutPlugin** — markdown ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: fix(wysiwyg): restore full WYSIWYG editing, fix code escape bugs", "scope_files": [ "pnpm-lock.yaml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `packages/ui/src/components/` needed...
[ { "subtask_id": "s1", "scope_files": [ "pnpm-lock.yaml" ], "solution_diff": "diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml\nindex 197163eddf7..ac730aa8855 100644\n--- a/pnpm-lock.yaml\n+++ b/pnpm-lock.yaml\n@@ -815,6 +815,12 @@ importers:\n rehype-highlight:\n specifier: ^7.0.0\n ...
[ { "subtask_id": "s4", "comment": "### Duplicate CODE transformer in allTransformers array\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `CODE` transformer is included explicitly on its own *and* again inside `...TRANSFORMERS` (which bundles all built-in element transformers including `CODE`, `HE...
diff --git a/packages/ui/src/components/CodeBlockEscapePlugin.tsx b/packages/ui/src/components/CodeBlockEscapePlugin.tsx new file mode 100644 index 00000000000..a76154db777 --- /dev/null +++ b/packages/ui/src/components/CodeBlockEscapePlugin.tsx @@ -0,0 +1,128 @@ +import { useEffect } from 'react'; +import { useLexical...
4
12
BloopAI/vibe-kanban#3271
BloopAI/vibe-kanban
3,271
76c818f7a3dc83bf1e5d308738a1f48a1a7d2c24
d4f8ff1c1aaa2e41a34fe093b51dde13ee7b3081
Fix macOS app menu branding to Vibe Kanban (Vibe Kanban) ## Summary This PR fixes desktop app branding in the macOS application menu so users only see **Vibe Kanban** instead of the internal binary name (`vibe-kanban-tauri`). ## What Changed - Updated macOS bundle metadata in `crates/tauri-app/Info.plist`: - Added ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `crates/tauri-app/` needed for: Fix macOS app menu branding to Vibe Kanban (Vibe Kanban)", "scope_files": [ "crates/tauri-app/Info.plist", "crates/tauri-app/tauri.conf.json" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "crates/tauri-app/Info.plist", "crates/tauri-app/tauri.conf.json" ], "solution_diff": "diff --git a/crates/tauri-app/Info.plist b/crates/tauri-app/Info.plist\nindex 3f53873965b..e9df7876620 100644\n--- a/crates/tauri-app/Info.plist\n+++ b/crates/tau...
[]
diff --git a/crates/tauri-app/Info.plist b/crates/tauri-app/Info.plist index 3f53873965b..e9df7876620 100644 --- a/crates/tauri-app/Info.plist +++ b/crates/tauri-app/Info.plist @@ -2,6 +2,10 @@ <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> <plist version="1.0">...
1
2
BloopAI/vibe-kanban#3125
BloopAI/vibe-kanban
3,125
70864474038dd09ea4af9cb09254561872dde2e6
646730f959130eabe7b5de56958d9ee3bd36135c
feat: add markdown preview toggle in diff view for .md files ## Summary Adds a markdown preview toggle to the diff card header for `.md` and `.mdx` files. Clicking the eye icon switches between the raw code diff and a rendered markdown preview. - Toggle button (eye icon) appears in the diff card header for markd...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: feat: add markdown preview toggle in diff view for .md files", "scope_files": [ "pnpm-lock.yaml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `packages/web-core/` needed for: feat: a...
[ { "subtask_id": "s1", "scope_files": [ "pnpm-lock.yaml" ], "solution_diff": "diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml\nindex adf3179ad4f..e5076f7ac98 100644\n--- a/pnpm-lock.yaml\n+++ b/pnpm-lock.yaml\n@@ -773,6 +773,9 @@ importers:\n lucide-react:\n specifier: ^0.539.0\n ...
[ { "subtask_id": "s11", "comment": "### Syntax highlighting dependency added but never wired up\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`rehype-highlight` is added to `package.json` and listed in the PR description as a new dependency, but it's never imported or passed as a `rehypePlugins` prop...
diff --git a/packages/web-core/package.json b/packages/web-core/package.json index a0e9f306ac9..6303efc6a99 100644 --- a/packages/web-core/package.json +++ b/packages/web-core/package.json @@ -70,16 +70,20 @@ "lexical": "^0.36.2", "lodash": "^4.17.21", "lucide-react": "^0.539.0", + "mermaid": "^11.4.0...
11
12
BloopAI/vibe-kanban#3233
BloopAI/vibe-kanban
3,233
70864474038dd09ea4af9cb09254561872dde2e6
70e287464b68ea539401a2b0af7f7ac5b8665a4f
Add conversation turn navigation popover (Vibe Kanban) ## Summary Adds a ChatGPT-style conversation turn navigation feature that lets users quickly jump to any of their previous messages in a conversation. - Hovering over the existing "scroll to previous message" (arrow up) button reveals a popover listing all user ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `packages/ui/src/components/` needed for: Add conversation turn navigation popover (Vibe Kanban)", "scope_files": [ "packages/ui/src/components/SessionChatBox.tsx", "packages/ui/src/components/TurnNavigationPopup.tsx" ] }, { ...
[ { "subtask_id": "s1", "scope_files": [ "packages/ui/src/components/SessionChatBox.tsx", "packages/ui/src/components/TurnNavigationPopup.tsx" ], "solution_diff": "diff --git a/packages/ui/src/components/SessionChatBox.tsx b/packages/ui/src/components/SessionChatBox.tsx\nindex 881d192923f....
[ { "subtask_id": "s1", "comment": "### PopoverTrigger click handler conflicts with button onClick\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `TurnNavigationPopup` is designed to open on hover, but Radix's `PopoverTrigger` also adds a click handler that calls `onOpenChange` to toggle the popove...
diff --git a/packages/ui/src/components/SessionChatBox.tsx b/packages/ui/src/components/SessionChatBox.tsx index 881d192923f..11ff965577b 100644 --- a/packages/ui/src/components/SessionChatBox.tsx +++ b/packages/ui/src/components/SessionChatBox.tsx @@ -33,6 +33,10 @@ import { AskUserQuestionBanner, type AskUserQu...
4
7
BloopAI/vibe-kanban#3252
BloopAI/vibe-kanban
3,252
e96323b81c43abc4d6df740d0caed893a88ffa08
6e2dc95a663202e0221b8be3b9dd7db92d4c1999
ci: pin all third-party GitHub Actions and cargo installs to commit hashes Supply-chain security hardening: - Pin all third-party GitHub Actions to exact commit SHAs. - Replace raw `cargo install` commands with `taiki-e/cache-cargo-install-action` using git commit pinning. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/actions/cargo-checks-common-setup/` needed for: ci: pin all third-party GitHub Actions and cargo installs to commit hashes", "scope_files": [ ".github/actions/cargo-checks-common-setup/action.yml" ] }, { "subtask_id": ...
[ { "subtask_id": "s1", "scope_files": [ ".github/actions/cargo-checks-common-setup/action.yml" ], "solution_diff": "diff --git a/.github/actions/cargo-checks-common-setup/action.yml b/.github/actions/cargo-checks-common-setup/action.yml\nindex b0adfc359c7..3b50ffbd317 100644\n--- a/.github/acti...
[]
diff --git a/.github/actions/cargo-checks-common-setup/action.yml b/.github/actions/cargo-checks-common-setup/action.yml index b0adfc359c7..3b50ffbd317 100644 --- a/.github/actions/cargo-checks-common-setup/action.yml +++ b/.github/actions/cargo-checks-common-setup/action.yml @@ -33,19 +33,19 @@ runs: - name: In...
3
9
BloopAI/vibe-kanban#3199
BloopAI/vibe-kanban
3,199
da4580042168a17accb3b30dded6c7c45325fb4e
332612ccfada5fb8ab89506fdc1439771860606a
feat: self-host improvements - Bypass OAuth provider configuration - Gate `relay` and `attachments` behind feature flags <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Adds a new local email/password login path and changes token refresh validation behavior, which touches authentication/session flows. Al...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: feat: self-host improvements", "scope_files": [ "Caddyfile.example", "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `crates/api-types/src/` needed for: feat: self-...
[ { "subtask_id": "s1", "scope_files": [ "Caddyfile.example", "package.json" ], "solution_diff": "diff --git a/Caddyfile.example b/Caddyfile.example\nnew file mode 100644\nindex 00000000000..64a882ca8ec\n--- /dev/null\n+++ b/Caddyfile.example\n@@ -0,0 +1,15 @@\n+localhost:3001, relay.local...
[ { "subtask_id": "s5", "comment": "### Empty env vars crash server on startup\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\n`LocalAuthConfig::from_env()` uses `env::var(...).ok()` which converts `Ok(\"\")` to `Some(\"\")`. The docker-compose passes `${SELF_HOST_LOCAL_AUTH_EMAIL:-}` which resolves to an...
diff --git a/Caddyfile.example b/Caddyfile.example new file mode 100644 index 00000000000..64a882ca8ec --- /dev/null +++ b/Caddyfile.example @@ -0,0 +1,15 @@ +localhost:3001, relay.localhost:3001, *.relay.localhost:3001 { + tls internal + + @relay host relay.localhost *.relay.localhost + handle @relay { + ...
16
24
BloopAI/vibe-kanban#3249
BloopAI/vibe-kanban
3,249
8a0e4c93dce4e80d30f2c4b400e734615c742b3f
c08bb069ace38e0c27dda8b5f7221af0538efa46
fix: bump rmcp <!-- CURSOR_SUMMARY --> > [!NOTE] > **Medium Risk** > Moderate risk because it upgrades the core `rmcp` dependency and updates MCP server/tool wiring and error handling paths; behavior should be equivalent but could affect runtime compatibility and error surfaces. > > **Overview** > Upgrades `crates/mc...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: fix: bump rmcp", "scope_files": [ "Cargo.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `crates/mcp/` needed for: fix: bump rmcp", "scope_files": [ "crates/mcp/Cargo.to...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex a91d8c6ecf3..be0591b7ce9 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -791,7 +791,7 @@ version = \"3.9.1\"\n source = \"registry+https://github.com/rust-lang/crates.io-index\"...
[]
diff --git a/Cargo.lock b/Cargo.lock index a91d8c6ecf3..be0591b7ce9 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -791,7 +791,7 @@ version = "3.9.1" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "519bd3116aeeb42d5372c29d982d16d0170d3d4a5ed85fc7dd91642ffff3c67c" dependencies = [ - "darling...
4
14
BloopAI/vibe-kanban#3240
BloopAI/vibe-kanban
3,240
70864474038dd09ea4af9cb09254561872dde2e6
40d269acebb23e2c9f96cc86051c772cebde43cf
refactor: isolate git2 usage behind GitService wrappers (Vibe Kanban) ## Summary This PR completes a cleanup/refactor to route Git operations through the `git` crate service layer instead of calling `git2` directly from other crates. ## What Changed - Refactored dependent crates to use `GitService` wrappers instead o...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: refactor: isolate git2 usage behind GitService wrappers (Vibe Kanban)", "scope_files": [ "Cargo.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `crates/deployment/` needed for: re...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex a554fcf4216..03089217c15 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -1813,7 +1813,6 @@ dependencies = [\n \"executors\",\n \"futures\",\n \"git\",\n- \"git2\",\n \"previ...
[ { "subtask_id": "s13", "comment": "### `FileDiffDetails` struct is now unused dead code\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `FileDiffDetails` struct in `utils/src/diff.rs` is now dead code. Its only consumer was `create_file_details` in the git crate, which was removed in this PR as part ...
diff --git a/Cargo.lock b/Cargo.lock index a554fcf4216..03089217c15 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1813,7 +1813,6 @@ dependencies = [ "executors", "futures", "git", - "git2", "preview-proxy", "relay-control", "relay-hosts", @@ -7698,7 +7697,6 @@ dependencies = [ "futures-util", "git", "g...
15
16
BloopAI/vibe-kanban#3138
BloopAI/vibe-kanban
3,138
fa00afc9f8e78fa55484f8db097efd3fe7a829c7
5b281c75951695175babe40f6deba1f1b2a21ad4
fix(auth): Add refresh token refresh grace window and degraded auth UI - Remote: align auth implementation with common practices. - allow a grace window for refresh token reuse. - on reuse, revoke the affected auth session only. - UX: handle degraded auth gracefully. - avoid logging out the user on degraded ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `crates/api-types/src/` needed for: fix(auth): Add refresh token refresh grace window and degraded auth UI", "scope_files": [ "crates/api-types/src/auth.rs", "crates/api-types/src/oauth.rs" ] }, { "subtask_id": "s2", ...
[ { "subtask_id": "s1", "scope_files": [ "crates/api-types/src/auth.rs", "crates/api-types/src/oauth.rs" ], "solution_diff": "diff --git a/crates/api-types/src/auth.rs b/crates/api-types/src/auth.rs\nindex 3e2aa6bf06c..65613584d74 100644\n--- a/crates/api-types/src/auth.rs\n+++ b/crates/ap...
[ { "subtask_id": "s29", "comment": "### Recovery backoff skips first exponential step\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe exponential backoff in `runRecoveryAttempt` is off by one because `getToken`'s error handler calls `this.syncRecoveryState()` (which schedules a timeout using the curre...
diff --git a/crates/api-types/src/auth.rs b/crates/api-types/src/auth.rs index 3e2aa6bf06c..65613584d74 100644 --- a/crates/api-types/src/auth.rs +++ b/crates/api-types/src/auth.rs @@ -11,6 +11,8 @@ pub struct AuthSession { pub revoked_at: Option<DateTime<Utc>>, pub refresh_token_id: Option<Uuid>, pub re...
31
44
BloopAI/vibe-kanban#3113
BloopAI/vibe-kanban
3,113
69aba3041b7b7051f5e51eb01ce0192cd5ce358c
94c1c457f2e5b156d904bfa758c0de585fa7adbd
feat: link PRs to issues directly Add the ability to link PRs to issues without going through workspace creation. ## Summary Adds the ability to link PRs to issues directly, without requiring a workspace. Users can paste a PR URL or browse open PRs from connected repos. - Local: extracts PR tracking from the ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `crates/api-types/src/` needed for: feat: link PRs to issues directly", "scope_files": [ "crates/api-types/src/pull_request.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `crates/db/.sqlx/` needed for: ...
[ { "subtask_id": "s1", "scope_files": [ "crates/api-types/src/pull_request.rs" ], "solution_diff": "diff --git a/crates/api-types/src/pull_request.rs b/crates/api-types/src/pull_request.rs\nindex 7d96280287d..bce2654e207 100644\n--- a/crates/api-types/src/pull_request.rs\n+++ b/crates/api-types...
[ { "subtask_id": "s3", "comment": "### Migration silently drops duplicate PR-workspace associations\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe migration uses `INSERT OR IGNORE` to copy PR rows from `merges` into `tracked_prs`, which has a `UNIQUE` constraint on `pr_url`. If multiple workspaces...
diff --git a/crates/api-types/src/pull_request.rs b/crates/api-types/src/pull_request.rs index 7d96280287d..bce2654e207 100644 --- a/crates/api-types/src/pull_request.rs +++ b/crates/api-types/src/pull_request.rs @@ -23,12 +23,21 @@ pub struct PullRequest { pub merged_at: Option<DateTime<Utc>>, pub merge_comm...
34
97
BloopAI/vibe-kanban#3241
BloopAI/vibe-kanban
3,241
1bfdc294715573209a20e5a801dfcc760154eb2b
fc19b5b8c1e0aa9b51561237c97a9ba2ff1b48b8
fix(ci): fix pnpm run lint and add missing crates to CI path filters (Vibe Kanban) ## Summary - **Fixed clippy lint failure** in `relay-tunnel-core`: replaced field-reassignment-after-`Default::default()` with struct initialization syntax (`YamuxConfig { ..Default::default() }`) to satisfy `clippy::field_reassign_wit...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: fix(ci): fix pnpm run lint and add missing crates to CI path filters (Vibe Kanban)", "scope_files": [ ".github/workflows/test.yml" ] }, { "subtask_id": "s2", "goal": "Implement the changes u...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/test.yml" ], "solution_diff": "diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml\nindex ccf84ab06dd..c9c097cbc9a 100644\n--- a/.github/workflows/test.yml\n+++ b/.github/workflows/test.yml\n@@ -59,16 +59,31 @@ jobs:\n ...
[]
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ccf84ab06dd..c9c097cbc9a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -59,16 +59,31 @@ jobs: - '.github/actions/**' backend: - 'crates/api-types/**' + - 'crat...
3
3
BloopAI/vibe-kanban#3225
BloopAI/vibe-kanban
3,225
70ca5a068e449c0e699f315e8cbee31f7a4e30bf
390cc3352e99a67e0097c303b8cc99548c5ff236
Add cursor models to include composer-2, composer-2-fast Adding cursor models list to include Composer 2 and Composer 2 Fast <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: this only expands the selectable model list and updates schema/descriptions, without changing execution or permission logic. > ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `crates/executors/src/executors/` needed for: Add cursor models to include composer-2, composer-2-fast", "scope_files": [ "crates/executors/src/executors/cursor.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes ...
[ { "subtask_id": "s1", "scope_files": [ "crates/executors/src/executors/cursor.rs" ], "solution_diff": "diff --git a/crates/executors/src/executors/cursor.rs b/crates/executors/src/executors/cursor.rs\nindex bde8027657f..fd3eefde866 100644\n--- a/crates/executors/src/executors/cursor.rs\n+++ b/...
[]
diff --git a/crates/executors/src/executors/cursor.rs b/crates/executors/src/executors/cursor.rs index bde8027657f..fd3eefde866 100644 --- a/crates/executors/src/executors/cursor.rs +++ b/crates/executors/src/executors/cursor.rs @@ -47,7 +47,7 @@ pub struct CursorAgent { pub force: Option<bool>, #[serde(defau...
2
2
BloopAI/vibe-kanban#3238
BloopAI/vibe-kanban
3,238
74ee4a6e886858d3b89ebc8f27039c6b652e60f7
fc1a38023500b2ffc1727729a18671805cc716b4
fix(relay): use actual server bind address instead of hardcoded 127.0.0.1 (Vibe Kanban) ## Summary On macOS, the Tauri app binds to `localhost:0` which resolves to `::1` (IPv6), but the relay client and preview proxy were hardcoded to connect to `127.0.0.1` (IPv4). This mismatch caused all relay-tunneled requests to ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `crates/client-info/src/` needed for: fix(relay): use actual server bind address instead of hardcoded 127.0.0.1 (Vibe Kanban)", "scope_files": [ "crates/client-info/src/lib.rs" ] }, { "subtask_id": "s2", "goal": "Implement ...
[ { "subtask_id": "s1", "scope_files": [ "crates/client-info/src/lib.rs" ], "solution_diff": "diff --git a/crates/client-info/src/lib.rs b/crates/client-info/src/lib.rs\nindex 378f5f5adb9..91ac1d2fe87 100644\n--- a/crates/client-info/src/lib.rs\n+++ b/crates/client-info/src/lib.rs\n@@ -1,10 +1,9...
[ { "subtask_id": "s6", "comment": "### Non-IP hostname causes infinite retry loop\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `local_hostname` is validated as `Some` in `resolve_relay_params` but only parsed as `IpAddr` later inside `start_relay`, which runs inside the reconnect retry loop. In the...
diff --git a/crates/client-info/src/lib.rs b/crates/client-info/src/lib.rs index 378f5f5adb9..91ac1d2fe87 100644 --- a/crates/client-info/src/lib.rs +++ b/crates/client-info/src/lib.rs @@ -1,10 +1,9 @@ -use std::sync::OnceLock; +use std::{net::SocketAddr, sync::OnceLock}; /// Runtime information about the local serv...
6
7
BookStackApp/BookStack#6109
BookStackApp/BookStack
6,109
4f370ccddb4f5fd8eddff5915a9413786ae2a2c7
00239bb6c85e36cf724c2c9dfce7e3deb7c558a2
PDF: Started building system to allow custom DOMPDF font loading Adds a way for custom fonts to be loaded for use with DomPDF. On export, BookStack scans the `storage/fonts/dompdf` folder for `*.ttf` font files, then for each attempts to build the required `.ufm` (font-metrics) file where they don't already exist. ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/Config/` needed for: PDF: Started building system to allow custom DOMPDF font loading", "scope_files": [ "app/Config/exports.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/Exports/` needed fo...
[ { "subtask_id": "s1", "scope_files": [ "app/Config/exports.php" ], "solution_diff": "diff --git a/app/Config/exports.php b/app/Config/exports.php\nindex 2e22bc759e3..f48fe0a67a3 100644\n--- a/app/Config/exports.php\n+++ b/app/Config/exports.php\n@@ -68,7 +68,7 @@\n * Times-Roman, Time...
[]
diff --git a/app/Config/exports.php b/app/Config/exports.php index 2e22bc759e3..f48fe0a67a3 100644 --- a/app/Config/exports.php +++ b/app/Config/exports.php @@ -68,7 +68,7 @@ * Times-Roman, Times-Bold, Times-BoldItalic, Times-Italic, * Symbol, ZapfDingbats. */ - 'font_dir' => storag...
7
9
BookStackApp/BookStack#6108
BookStackApp/BookStack
6,108
083fb1a600f1eeb8acb719675bdeb089c86ceee1
426f9ac4934308da9f57580bc0e2fe399346cbb1
Permissions: Started addition of revision-view permission For #4526 ### Todo - [x] Add at a database level - [x] Add for roles based on any existing page-view-all or page-view-own permissions. - [x] Testing coverage - [x] Access control testing - [x] Manual testing ### Docs Updates - Update Adviso...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/Entities/Controllers/` needed for: Permissions: Started addition of revision-view permission", "scope_files": [ "app/Entities/Controllers/PageRevisionController.php" ] }, { "subtask_id": "s2", "goal": "Implement the ch...
[ { "subtask_id": "s1", "scope_files": [ "app/Entities/Controllers/PageRevisionController.php" ], "solution_diff": "diff --git a/app/Entities/Controllers/PageRevisionController.php b/app/Entities/Controllers/PageRevisionController.php\nindex 4bc15e6e967..cc6b79bfe45 100644\n--- a/app/Entities/Co...
[]
diff --git a/app/Entities/Controllers/PageRevisionController.php b/app/Entities/Controllers/PageRevisionController.php index 4bc15e6e967..cc6b79bfe45 100644 --- a/app/Entities/Controllers/PageRevisionController.php +++ b/app/Entities/Controllers/PageRevisionController.php @@ -34,6 +34,7 @@ public function __construct( ...
10
11
BookStackApp/BookStack#6085
BookStackApp/BookStack
6,085
e033578feaa86dd0a3ac8dc4137bfec66a1baee7
58e2e0ea241e4059e202084fec40d7668613e774
Maintenance: Started work for PHPStan Level 4
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Maintenance: Started work for PHPStan Level 4", "scope_files": [ ".gitignore", "phpstan.neon.dist" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/Access/` needed for: Mainte...
[ { "subtask_id": "s1", "scope_files": [ ".gitignore", "phpstan.neon.dist" ], "solution_diff": "diff --git a/.gitignore b/.gitignore\nindex b545d161f13..06a8723c5c1 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -2,6 +2,7 @@\n /node_modules\n /.vscode\n /composer\n+/composer.phar\n /covera...
[]
diff --git a/.gitignore b/.gitignore index b545d161f13..06a8723c5c1 100644 --- a/.gitignore +++ b/.gitignore @@ -2,6 +2,7 @@ /node_modules /.vscode /composer +/composer.phar /coverage Homestead.yaml .env diff --git a/app/Access/EmailConfirmationService.php b/app/Access/EmailConfirmationService.php index 1a5156d3e...
20
34
BookStackApp/BookStack#5919
BookStackApp/BookStack
5,919
0f40aeb0d31cae2f7b27ec7e7a9e6ad7562341eb
313326b32adc8a916420d77d1ce1aa6f1d6b8ebb
Merge v25-11 changes into dev
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Merge v25-11 changes into dev", "scope_files": [ "composer.json", "composer.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/Access/Controllers/` needed for: Merge v25-1...
[ { "subtask_id": "s1", "scope_files": [ "composer.json", "composer.lock" ], "solution_diff": "diff --git a/composer.json b/composer.json\nindex ab33e87a46c..7e7412976d6 100644\n--- a/composer.json\n+++ b/composer.json\n@@ -29,7 +29,7 @@\n \"league/flysystem-aws-s3-v3\": \"^3.0\",\...
[]
diff --git a/app/Access/Controllers/OidcController.php b/app/Access/Controllers/OidcController.php index 055d4c1403f..654ed692880 100644 --- a/app/Access/Controllers/OidcController.php +++ b/app/Access/Controllers/OidcController.php @@ -9,11 +9,9 @@ class OidcController extends Controller { - protected OidcServi...
10
15
BookStackApp/BookStack#6100
BookStackApp/BookStack
6,100
0760e677b25d96306b2d1a732c0f92d83ac41ac0
18364d1e6e235ab129a03e77279201436bcd954a
WYSIWYG: Added inline code support to minimal editor Used for comments and descriptions. Also updated shortcut handling that we're not registering shortcuts for edits which can't use the related formatting types. For #6003
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/Util/` needed for: WYSIWYG: Added inline code support to minimal editor", "scope_files": [ "app/Util/HtmlDescriptionFilter.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `resources/js/wysiwyg/` ne...
[ { "subtask_id": "s1", "scope_files": [ "app/Util/HtmlDescriptionFilter.php" ], "solution_diff": "diff --git a/app/Util/HtmlDescriptionFilter.php b/app/Util/HtmlDescriptionFilter.php\nindex 1baa11ffcfa..ba145460381 100644\n--- a/app/Util/HtmlDescriptionFilter.php\n+++ b/app/Util/HtmlDescription...
[]
diff --git a/app/Util/HtmlDescriptionFilter.php b/app/Util/HtmlDescriptionFilter.php index 1baa11ffcfa..ba145460381 100644 --- a/app/Util/HtmlDescriptionFilter.php +++ b/app/Util/HtmlDescriptionFilter.php @@ -27,6 +27,7 @@ class HtmlDescriptionFilter 'span' => [], 'em' => [], 'br' => [], + ...
5
5
BookStackApp/BookStack#6095
BookStackApp/BookStack
6,095
93f84a81b28ada7467e66d240182a71e5d60278f
208629ee1fce280c31f9baf30a6ed79c3cd17df0
API: New tag endpoints Adds new API endpoints to get tag information, providing the same benefits as the `/tags` UI view. For #5835 ### Todo - [x] Add some API docs guidance to note how tags are created/updated/deleted (via entities). - [x] Add API docs examples - [x] Cover with testing - [x] Test results...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/Activity/` needed for: API: New tag endpoints", "scope_files": [ "app/Activity/TagRepo.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/Activity/Controllers/` needed for: API: New tag endpoin...
[ { "subtask_id": "s1", "scope_files": [ "app/Activity/TagRepo.php" ], "solution_diff": "diff --git a/app/Activity/TagRepo.php b/app/Activity/TagRepo.php\nindex 82c26b00e28..3e8d5545ab6 100644\n--- a/app/Activity/TagRepo.php\n+++ b/app/Activity/TagRepo.php\n@@ -18,9 +18,10 @@ public function __c...
[]
diff --git a/app/Activity/Controllers/TagApiController.php b/app/Activity/Controllers/TagApiController.php new file mode 100644 index 00000000000..f5c5e95d420 --- /dev/null +++ b/app/Activity/Controllers/TagApiController.php @@ -0,0 +1,68 @@ +<?php + +declare(strict_types=1); + +namespace BookStack\Activity\Controllers...
9
14
BookStackApp/BookStack#6083
BookStackApp/BookStack
6,083
25790fd0245257ffaffe6690b8e12d56b326af9b
abed4eae0c541a44990d260796e21e420d8243ad
New HTML to Plaintext handling To achieve a better and more consistent output. ### Todo - [x] See if we can use this new class for exports also.
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/Activity/Models/` needed for: New HTML to Plaintext handling", "scope_files": [ "app/Activity/Models/Comment.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/Activity/Notifications/Messages/` n...
[ { "subtask_id": "s1", "scope_files": [ "app/Activity/Models/Comment.php" ], "solution_diff": "diff --git a/app/Activity/Models/Comment.php b/app/Activity/Models/Comment.php\nindex ab7d917729c..3faa76657b6 100644\n--- a/app/Activity/Models/Comment.php\n+++ b/app/Activity/Models/Comment.php\n@@ ...
[]
diff --git a/app/Activity/Models/Comment.php b/app/Activity/Models/Comment.php index ab7d917729c..3faa76657b6 100644 --- a/app/Activity/Models/Comment.php +++ b/app/Activity/Models/Comment.php @@ -9,6 +9,7 @@ use BookStack\Users\Models\OwnableInterface; use BookStack\Util\HtmlContentFilter; use BookStack\Util\HtmlCo...
8
9
BookStackApp/BookStack#6094
BookStackApp/BookStack
6,094
5e78dc6ed54aeb6d3d2565334074286a0e249b78
5fbaab474058c9c90496649d53dd002e25419884
Install Module Command Updates - Theme module ZIPs will now support their files being in a single nested directory within a ZIP, to support common ZIP structure approaches. Added test to cover. - Allowed cross-origin redirects on download, With a prompt to the user to confirm they trust the new origin. For #6066
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/Console/Commands/` needed for: Install Module Command Updates", "scope_files": [ "app/Console/Commands/InstallModuleCommand.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/Theming/` needed for...
[ { "subtask_id": "s1", "scope_files": [ "app/Console/Commands/InstallModuleCommand.php" ], "solution_diff": "diff --git a/app/Console/Commands/InstallModuleCommand.php b/app/Console/Commands/InstallModuleCommand.php\nindex 20252525df8..114bfb105d8 100644\n--- a/app/Console/Commands/InstallModul...
[]
diff --git a/app/Console/Commands/InstallModuleCommand.php b/app/Console/Commands/InstallModuleCommand.php index 20252525df8..114bfb105d8 100644 --- a/app/Console/Commands/InstallModuleCommand.php +++ b/app/Console/Commands/InstallModuleCommand.php @@ -213,15 +213,23 @@ protected function downloadModuleFile(string $loc...
4
4
BookStackApp/BookStack#6090
BookStackApp/BookStack
6,090
e033578feaa86dd0a3ac8dc4137bfec66a1baee7
45ff8c21b4b127e3a843813bca0e410491ea76ec
Maintenance: Updated NPM packages Includes typescript update to 6. Needed to update some typescript config to align with actual module environment used and built by esbuild.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Maintenance: Updated NPM packages", "scope_files": [ "jest.config.ts", "package-lock.json", "package.json", "tsconfig.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes u...
[ { "subtask_id": "s1", "scope_files": [ "jest.config.ts", "package-lock.json", "package.json", "tsconfig.json" ], "solution_diff": "diff --git a/jest.config.ts b/jest.config.ts\nindex 53bfceb053e..f7b5596de46 100644\n--- a/jest.config.ts\n+++ b/jest.config.ts\n@@ -5,7 +5,15 @@...
[]
diff --git a/.github/workflows/test-js.yml b/.github/workflows/test-js.yml index 13f9a8a9819..379f1ebfaa7 100644 --- a/.github/workflows/test-js.yml +++ b/.github/workflows/test-js.yml @@ -17,7 +17,7 @@ jobs: if: ${{ github.ref != 'refs/heads/l10n_development' }} runs-on: ubuntu-24.04 steps: - - uses:...
2
5
BookStackApp/BookStack#6067
BookStackApp/BookStack
6,067
25790fd0245257ffaffe6690b8e12d56b326af9b
c5e188c2aab4ba8dcef9870f444c5af97ef550b9
Updated translations with latest Crowdin changes
[ { "subtask_id": "s1", "goal": "Implement the changes under `lang/da/` needed for: Updated translations with latest Crowdin changes", "scope_files": [ "lang/da/editor.php", "lang/da/entities.php", "lang/da/errors.php", "lang/da/settings.php" ] }, { "subtask_id": "s2", ...
[ { "subtask_id": "s1", "scope_files": [ "lang/da/editor.php", "lang/da/entities.php", "lang/da/errors.php", "lang/da/settings.php" ], "solution_diff": "diff --git a/lang/da/editor.php b/lang/da/editor.php\nindex f135f06a90b..628e1319e21 100644\n--- a/lang/da/editor.php\n+++ b/...
[]
diff --git a/lang/da/editor.php b/lang/da/editor.php index f135f06a90b..628e1319e21 100644 --- a/lang/da/editor.php +++ b/lang/da/editor.php @@ -36,7 +36,7 @@ 'paragraph' => 'Paragraf', 'blockquote' => 'Citat', 'inline_code' => 'Inline kode', - 'callouts' => 'Callouts', + 'callouts' => 'Tekstfelter...
5
13
BookStackApp/BookStack#6064
BookStackApp/BookStack
6,064
0120b475eb18c7d4e1851a937cafd12724fabb31
cebad23b352b2675293e11310a54f8d2c74c3f84
Updated translations with latest Crowdin changes
[ { "subtask_id": "s1", "goal": "Implement the changes under `lang/cs/` needed for: Updated translations with latest Crowdin changes", "scope_files": [ "lang/cs/settings.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `lang/de/` needed for: Updated translations w...
[ { "subtask_id": "s1", "scope_files": [ "lang/cs/settings.php" ], "solution_diff": "diff --git a/lang/cs/settings.php b/lang/cs/settings.php\nindex ef25f1a2035..a8c4036e87e 100644\n--- a/lang/cs/settings.php\n+++ b/lang/cs/settings.php\n@@ -104,7 +104,7 @@\n 'sort_rule_op_chapters_first' =>...
[]
diff --git a/lang/cs/settings.php b/lang/cs/settings.php index ef25f1a2035..a8c4036e87e 100644 --- a/lang/cs/settings.php +++ b/lang/cs/settings.php @@ -104,7 +104,7 @@ 'sort_rule_op_chapters_first' => 'Kapitoly jako první', 'sort_rule_op_chapters_last' => 'Kapitoly jako poslední', 'sorting_page_limits' ...
5
9
BookStackApp/BookStack#6060
BookStackApp/BookStack
6,060
0120b475eb18c7d4e1851a937cafd12724fabb31
04dd9f8e19301fde58218864ae51eef6b678f27a
Update PHP_CodeSniffer repository link PHP_CodeSniffer has moved to a new GitHub organization. The `squizlabs/PHP_CodeSniffer` repository is now archived and the project is actively maintained at https://github.com/PHPCSStandards/PHP_CodeSniffer. See: https://github.com/squizlabs/PHP_CodeSniffer/issues/3932
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Update PHP_CodeSniffer repository link", "scope_files": [ "readme.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `dev/docs/` needed for: Update PHP_CodeSniffer repository link", ...
[ { "subtask_id": "s1", "scope_files": [ "readme.md" ], "solution_diff": "diff --git a/readme.md b/readme.md\nindex 194f81e4a05..00eb135046e 100644\n--- a/readme.md\n+++ b/readme.md\n@@ -178,7 +178,7 @@ Note: This is not an exhaustive list of all libraries and projects that would be\n * [phpsecl...
[]
diff --git a/dev/docs/development.md b/dev/docs/development.md index 418e9ead672..2c73a0256c5 100644 --- a/dev/docs/development.md +++ b/dev/docs/development.md @@ -37,7 +37,7 @@ We use tools to manage code standards and formatting within the project. If subm ### PHP -PHP code standards are managed by [using PHP_C...
2
2
BookStackApp/BookStack#6007
BookStackApp/BookStack
6,007
46dcc30bf7504459385192a3edcf525a4877a4de
5a8dfcaad45d3a4ad0f370a29e34185367e66221
Updated translations with latest Crowdin changes
[ { "subtask_id": "s1", "goal": "Implement the changes under `lang/ar/` needed for: Updated translations with latest Crowdin changes", "scope_files": [ "lang/ar/settings.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `lang/bg/` needed for: Updated translations w...
[ { "subtask_id": "s1", "scope_files": [ "lang/ar/settings.php" ], "solution_diff": "diff --git a/lang/ar/settings.php b/lang/ar/settings.php\nindex dc95ac8468f..3191bbe3a0a 100644\n--- a/lang/ar/settings.php\n+++ b/lang/ar/settings.php\n@@ -104,7 +104,7 @@\n 'sort_rule_op_chapters_first' =>...
[]
diff --git a/lang/ar/settings.php b/lang/ar/settings.php index dc95ac8468f..3191bbe3a0a 100644 --- a/lang/ar/settings.php +++ b/lang/ar/settings.php @@ -104,7 +104,7 @@ 'sort_rule_op_chapters_first' => 'الفصول الأولى', 'sort_rule_op_chapters_last' => 'الفصول الأخيرة', 'sorting_page_limits' => 'حدود العرض...
51
72
BookStackApp/BookStack#6057
BookStackApp/BookStack
6,057
151823b84e227e6ed63a216ff970ce2fa5491fca
5f5fea7c83992cecca61b4aabfc1e07053dfa4c4
V25.12 changes v3
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: V25.12 changes v3", "scope_files": [ "composer.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/Entities/Controllers/` needed for: V25.12 changes v3", "scope_files": [ ...
[ { "subtask_id": "s1", "scope_files": [ "composer.lock" ], "solution_diff": "diff --git a/composer.lock b/composer.lock\nindex 18d0da62191..d8ea0066265 100644\n--- a/composer.lock\n+++ b/composer.lock\n@@ -62,16 +62,16 @@\n },\n {\n \"name\": \"aws/aws-sdk-php\",\n- ...
[]
diff --git a/app/Entities/Controllers/PageRevisionController.php b/app/Entities/Controllers/PageRevisionController.php index 35f1e8daf0e..4bc15e6e967 100644 --- a/app/Entities/Controllers/PageRevisionController.php +++ b/app/Entities/Controllers/PageRevisionController.php @@ -12,6 +12,8 @@ use BookStack\Facades\Activi...
5
5
BookStackApp/BookStack#6035
BookStackApp/BookStack
6,035
6808292c90ce9cced8562651b12635f5ac6a3f3b
25ed242f61293731210e7962ac63561796396654
Merge further v25-12 changes into development
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Merge further v25-12 changes into development", "scope_files": [ "composer.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/Util/` needed for: Merge further v25-12 changes int...
[ { "subtask_id": "s1", "scope_files": [ "composer.lock" ], "solution_diff": "diff --git a/composer.lock b/composer.lock\nindex c72b6dd1bdb..18d0da62191 100644\n--- a/composer.lock\n+++ b/composer.lock\n@@ -62,16 +62,16 @@\n },\n {\n \"name\": \"aws/aws-sdk-php\",\n- ...
[]
diff --git a/app/Util/ConfiguredHtmlPurifier.php b/app/Util/ConfiguredHtmlPurifier.php index ab23333882a..1f2528e7155 100644 --- a/app/Util/ConfiguredHtmlPurifier.php +++ b/app/Util/ConfiguredHtmlPurifier.php @@ -71,6 +71,8 @@ protected function setConfig(HTMLPurifier_Config $config, string $cachePath): vo $co...
3
3
BookStackApp/BookStack#6027
BookStackApp/BookStack
6,027
5e12b678c78735ea20d73445a159f0df5bb45080
80204518a25bb98beb0790f06496f19ec66d61ca
Merge changes from V25-12 patches
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Merge changes from V25-12 patches", "scope_files": [ ".env.example.complete", "composer.json", "composer.lock", "phpunit.xml", "readme.md" ] }, { "subtask_id": "s2", "goal": "Im...
[ { "subtask_id": "s1", "scope_files": [ ".env.example.complete", "composer.json", "composer.lock", "phpunit.xml", "readme.md" ], "solution_diff": "diff --git a/.env.example.complete b/.env.example.complete\nindex 18e7bd00d9c..ebebaf9e3e8 100644\n--- a/.env.example.comple...
[]
diff --git a/.env.example.complete b/.env.example.complete index 18e7bd00d9c..ebebaf9e3e8 100644 --- a/.env.example.complete +++ b/.env.example.complete @@ -351,10 +351,25 @@ EXPORT_PDF_COMMAND_TIMEOUT=15 # Only used if 'ALLOW_UNTRUSTED_SERVER_FETCHING=true' which disables security protections. WKHTMLTOPDF=false -#...
12
25
BookStackApp/BookStack#5998
BookStackApp/BookStack
5,998
ff59bbdc0780d0ac5e197ce16b99713b36a6ade8
057d7be0bc7eb7bc6b62136da6e98c199f82f12f
Further theme system developments ### Additions - Before/After view include support. - Modular hack support - Theme Modules - Module fetch format/system. - Split out show/index template sidebar elements into their own views for easier customization control. ### Ideas - Abstract usage of `THEME_*` config en...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/App/` needed for: Further theme system developments", "scope_files": [ "app/App/helpers.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/App/Providers/` needed for: Further theme system develop...
[ { "subtask_id": "s1", "scope_files": [ "app/App/helpers.php" ], "solution_diff": "diff --git a/app/App/helpers.php b/app/App/helpers.php\nindex 0e357e36aee..8f210ecafd4 100644\n--- a/app/App/helpers.php\n+++ b/app/App/helpers.php\n@@ -81,8 +81,7 @@ function setting(?string $key = null, mixed $...
[]
diff --git a/app/App/Providers/ThemeServiceProvider.php b/app/App/Providers/ThemeServiceProvider.php index 2cf581d3863..671e5e1df74 100644 --- a/app/App/Providers/ThemeServiceProvider.php +++ b/app/App/Providers/ThemeServiceProvider.php @@ -4,6 +4,8 @@ use BookStack\Theming\ThemeEvents; use BookStack\Theming\ThemeS...
19
55
BookStackApp/BookStack#5997
BookStackApp/BookStack
5,997
ff59bbdc0780d0ac5e197ce16b99713b36a6ade8
e389f9f5f309352fb1fe3f3833115df56da273b9
Updated translations with latest Crowdin changes
[ { "subtask_id": "s1", "goal": "Implement the changes under `lang/ar/` needed for: Updated translations with latest Crowdin changes", "scope_files": [ "lang/ar/errors.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `lang/bg/` needed for: Updated translations wit...
[ { "subtask_id": "s1", "scope_files": [ "lang/ar/errors.php" ], "solution_diff": "diff --git a/lang/ar/errors.php b/lang/ar/errors.php\nindex 491f04c079a..25ba3544d57 100644\n--- a/lang/ar/errors.php\n+++ b/lang/ar/errors.php\n@@ -125,6 +125,7 @@\n 'api_incorrect_token_secret' => 'الشفرة ال...
[]
diff --git a/lang/ar/errors.php b/lang/ar/errors.php index 491f04c079a..25ba3544d57 100644 --- a/lang/ar/errors.php +++ b/lang/ar/errors.php @@ -125,6 +125,7 @@ 'api_incorrect_token_secret' => 'الشفرة المُقدمة لرمز API المستخدم المحدد غير صحيحة', 'api_user_no_api_permission' => 'مالك رمز API المستخدم ليس لديه...
51
65
BookStackApp/BookStack#5970
BookStackApp/BookStack
5,970
07ec880e3385221f99f3f1428fe5d8488887ff8d
f4f970fa280a02a2d39a9d79821557695c420e9b
Updated translations with latest Crowdin changes
[ { "subtask_id": "s1", "goal": "Implement the changes under `lang/bg/` needed for: Updated translations with latest Crowdin changes", "scope_files": [ "lang/bg/auth.php", "lang/bg/common.php", "lang/bg/editor.php", "lang/bg/errors.php" ] }, { "subtask_id": "s2", "g...
[ { "subtask_id": "s1", "scope_files": [ "lang/bg/auth.php", "lang/bg/common.php", "lang/bg/editor.php", "lang/bg/errors.php" ], "solution_diff": "diff --git a/lang/bg/auth.php b/lang/bg/auth.php\nindex 71cd2a71295..4a7e56f22e0 100644\n--- a/lang/bg/auth.php\n+++ b/lang/bg/auth...
[]
diff --git a/lang/bg/auth.php b/lang/bg/auth.php index 71cd2a71295..4a7e56f22e0 100644 --- a/lang/bg/auth.php +++ b/lang/bg/auth.php @@ -6,7 +6,7 @@ */ return [ - 'failed' => 'Въведените удостоверителни данни не съвпадат с нашите записи.', + 'failed' => 'Въведените данни не съвпадат с информацията в системат...
16
61
BookStackApp/BookStack#5962
BookStackApp/BookStack
5,962
38d3697246a294d011461ceb9850bc45bcef61ce
a3bb752b3e71481f0a665afadbdd302e9e577a28
Updated translations with latest Crowdin changes
[ { "subtask_id": "s1", "goal": "Implement the changes under `lang/ar/` needed for: Updated translations with latest Crowdin changes", "scope_files": [ "lang/ar/errors.php", "lang/ar/validation.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `lang/bg/` need...
[ { "subtask_id": "s1", "scope_files": [ "lang/ar/errors.php", "lang/ar/validation.php" ], "solution_diff": "diff --git a/lang/ar/errors.php b/lang/ar/errors.php\nindex 4c6325cb3a1..491f04c079a 100644\n--- a/lang/ar/errors.php\n+++ b/lang/ar/errors.php\n@@ -109,6 +109,7 @@\n 'import_zi...
[]
diff --git a/lang/ar/errors.php b/lang/ar/errors.php index 4c6325cb3a1..491f04c079a 100644 --- a/lang/ar/errors.php +++ b/lang/ar/errors.php @@ -109,6 +109,7 @@ 'import_zip_cant_read' => 'لم أتمكن من قراءة المِلَفّ المضغوط -ZIP-.', 'import_zip_cant_decode_data' => 'لم نتمكن من العثور على محتوى المِلَفّ المضغو...
41
100
BookStackApp/BookStack#5968
BookStackApp/BookStack
5,968
38d3697246a294d011461ceb9850bc45bcef61ce
b08d1b36de36d96fae55fff65bcb5908a43e63b5
Add some additional resource-based limits - Limits ZIP import file sizes to the configured `FILE_UPLOAD_SIZE_LIMIT`. - Limits the amount of search terms which can be used in one search. ### Docs Updates Update search page to note limits: ``` $searchLimit = $userLoggedIn ? 10 : 5; $exactLimi...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/Exports/ZipExports/` needed for: Add some additional resource-based limits", "scope_files": [ "app/Exports/ZipExports/ZipExportReader.php", "app/Exports/ZipExports/ZipFileReferenceRule.php", "app/Exports/ZipExports/ZipImpo...
[ { "subtask_id": "s1", "scope_files": [ "app/Exports/ZipExports/ZipExportReader.php", "app/Exports/ZipExports/ZipFileReferenceRule.php", "app/Exports/ZipExports/ZipImportRunner.php" ], "solution_diff": "diff --git a/app/Exports/ZipExports/ZipExportReader.php b/app/Exports/ZipExports...
[]
diff --git a/app/Exports/ZipExports/ZipExportReader.php b/app/Exports/ZipExports/ZipExportReader.php index c3d5c23cfec..28b830167c8 100644 --- a/app/Exports/ZipExports/ZipExportReader.php +++ b/app/Exports/ZipExports/ZipExportReader.php @@ -58,6 +58,16 @@ public function readData(): array { $this->open();...
5
10
BookStackApp/BookStack#5933
BookStackApp/BookStack
5,933
21730aeb398727574c8e014f031a97dacfa46aea
4d900a1459d8172dfd5931d773c6f1a927d158c4
Updated translations with latest Crowdin changes
[ { "subtask_id": "s1", "goal": "Implement the changes under `lang/ar/` needed for: Updated translations with latest Crowdin changes", "scope_files": [ "lang/ar/notifications.php", "lang/ar/preferences.php", "lang/ar/settings.php" ] }, { "subtask_id": "s2", "goal": "Imple...
[ { "subtask_id": "s1", "scope_files": [ "lang/ar/notifications.php", "lang/ar/preferences.php", "lang/ar/settings.php" ], "solution_diff": "diff --git a/lang/ar/notifications.php b/lang/ar/notifications.php\nindex 30a49a631cf..69d5dfdcf52 100644\n--- a/lang/ar/notifications.php\n+++...
[]
diff --git a/lang/ar/notifications.php b/lang/ar/notifications.php index 30a49a631cf..69d5dfdcf52 100644 --- a/lang/ar/notifications.php +++ b/lang/ar/notifications.php @@ -11,6 +11,8 @@ 'updated_page_subject' => 'تم تحديث الصفحة: :pageName', 'updated_page_intro' => 'تم تحديث الصفحة في :appName:', 'updat...
32
100
BookStackApp/BookStack#5939
BookStackApp/BookStack
5,939
1ee57114353887420d1dcf0366876d92f554c7ec
3e1b0587ec5fc81f02e5df4ba5544e233942ce92
Lexical fixes for v25.12 For #5631 - Updated focus control for popup modal forms to focus on first form-field on show, and restore focus to the editor on hide. - Fixed `undefined` default search value in link item search selector popup. - Updated item search selector popup to pre-fill search input with selected t...
[ { "subtask_id": "s1", "goal": "Implement the changes under `resources/js/wysiwyg/services/` needed for: Lexical fixes for v25.12", "scope_files": [ "resources/js/wysiwyg/services/shortcuts.ts" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `resources/js/wysiwyg/ui/...
[ { "subtask_id": "s1", "scope_files": [ "resources/js/wysiwyg/services/shortcuts.ts" ], "solution_diff": "diff --git a/resources/js/wysiwyg/services/shortcuts.ts b/resources/js/wysiwyg/services/shortcuts.ts\nindex ead4c38d432..c4be0f3cf2f 100644\n--- a/resources/js/wysiwyg/services/shortcuts.ts...
[]
diff --git a/resources/js/wysiwyg/services/shortcuts.ts b/resources/js/wysiwyg/services/shortcuts.ts index ead4c38d432..c4be0f3cf2f 100644 --- a/resources/js/wysiwyg/services/shortcuts.ts +++ b/resources/js/wysiwyg/services/shortcuts.ts @@ -71,13 +71,17 @@ const actionsByKeys: Record<string, ShortcutAction> = { ...
3
4
BookStackApp/BookStack#5944
BookStackApp/BookStack
5,944
9211062e8e0429f7c7b76037cfa38b99649398bb
a941d1b403f66d1162f0a23d4dc88a99234b9423
Comment mentions Related to #560. ### Todo - [x] Finish off editor UI. - [x] Address remaining todos in code changes - [x] Add lookup for users - [x] Limit to those with ability to create/update comments for now. - [x] Back-end comment parsing - [x] Notification on mention - [x] Notification preferenc...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Comment mentions", "scope_files": [ "package-lock.json", "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/Activity/Models/` needed for: Comment mentions", "...
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex b85d1f5e28f..e8a1493d42f 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -40,7 +40,6 @@\n \"eslint-plugin-import\...
[]
diff --git a/app/Activity/Models/MentionHistory.php b/app/Activity/Models/MentionHistory.php new file mode 100644 index 00000000000..7386a4d742b --- /dev/null +++ b/app/Activity/Models/MentionHistory.php @@ -0,0 +1,20 @@ +<?php + +namespace BookStack\Activity\Models; + +use Illuminate\Database\Eloquent\Model; +use Illu...
29
48
BookStackApp/BookStack#5606
BookStackApp/BookStack
5,606
3e99ce4098cf45eafd8917e9b208b3b6a4aaa1ec
b6110ed3cd15cf9d0472f1ccced3dbe6fdc7db76
Feature Request - Define number of shelves to display on one page **Describe the feature you'd like** The ability for an admin to set a global value for the number of shelves to display on one page before showing the next page option. **Describe the benefits this feature would bring to BookStack users** Allow use...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/App/` needed for: Feature Request - Define number of shelves to display on one page", "scope_files": [ "app/App/HomeController.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/Entities/Controll...
[ { "subtask_id": "s1", "scope_files": [ "app/App/HomeController.php" ], "solution_diff": "diff --git a/app/App/HomeController.php b/app/App/HomeController.php\nindex 0585e0af5cc..7ec8b0af207 100644\n--- a/app/App/HomeController.php\n+++ b/app/App/HomeController.php\n@@ -83,7 +83,7 @@ public fun...
[]
diff --git a/app/App/HomeController.php b/app/App/HomeController.php index 0585e0af5cc..7ec8b0af207 100644 --- a/app/App/HomeController.php +++ b/app/App/HomeController.php @@ -83,7 +83,7 @@ public function index( if ($homepageOption === 'bookshelves') { $shelves = $this->queries->shelves->visible...
4
5
BookStackApp/BookStack#5928
BookStackApp/BookStack
5,928
cf847974d2ffcddd9ffc10ad524237bf4b462a50
b5246a28f0268460588ae33e555337493426e2b0
Initial developer API for WYSIWYG editor For #5763 ### Todo - [x] Address todos in code
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Initial developer API for WYSIWYG editor", "scope_files": [ "package-lock.json", "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `dev/docs/` needed for: Initial dev...
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex fb6a1d4fa01..b85d1f5e28f 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -5,20 +5,20 @@\n \"packages\": {\n \"\": {...
[]
diff --git a/dev/docs/development.md b/dev/docs/development.md index 6c250902a9f..418e9ead672 100644 --- a/dev/docs/development.md +++ b/dev/docs/development.md @@ -3,7 +3,7 @@ All development on BookStack is currently done on the `development` branch. When it's time for a release the `development` branch is merged ...
11
20
BookStackApp/BookStack#5923
BookStackApp/BookStack
5,923
0f40aeb0d31cae2f7b27ec7e7a9e6ad7562341eb
bb350639c6be27c746ab886c70f620e39eebfa05
Styles: Made non-active dark/light css variables exist by default This means that it would be possible to jump between light/dark mode with just the class, and no reload needed. Not something we'll directly use right now, but may be useful in customizations.
[ { "subtask_id": "s1", "goal": "Implement the changes under `resources/views/layouts/parts/` needed for: Styles: Made non-active dark/light css variables exist by default", "scope_files": [ "resources/views/layouts/parts/custom-styles.blade.php" ] }, { "subtask_id": "s2", "goal": "I...
[ { "subtask_id": "s1", "scope_files": [ "resources/views/layouts/parts/custom-styles.blade.php" ], "solution_diff": "diff --git a/resources/views/layouts/parts/custom-styles.blade.php b/resources/views/layouts/parts/custom-styles.blade.php\nindex bfdcc851289..b31334e7331 100644\n--- a/resources...
[]
diff --git a/resources/views/layouts/parts/custom-styles.blade.php b/resources/views/layouts/parts/custom-styles.blade.php index bfdcc851289..b31334e7331 100644 --- a/resources/views/layouts/parts/custom-styles.blade.php +++ b/resources/views/layouts/parts/custom-styles.blade.php @@ -1,15 +1,22 @@ -@php - $settingSu...
2
2
BookStackApp/BookStack#5878
BookStackApp/BookStack
5,878
5bf2d801cf0e4a8ea3fc8b6739ee8651952ebf31
8ab9252f9bd1626b87df044b14ce3469b1ca07bf
DB: Updated entity scope to use models dynamic table This was hardcoded since the table was always the same, but in some cases Laravel will auto-alias the table name (for example, when in sub-queries) which will break MySQL 5.7 when the scope attempts to use the table name instead of the alias. Needs testing covera...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/Entities/Models/` needed for: DB: Updated entity scope to use models dynamic table", "scope_files": [ "app/Entities/Models/Book.php", "app/Entities/Models/EntityScope.php" ] }, { "subtask_id": "s2", "goal": "Impl...
[ { "subtask_id": "s1", "scope_files": [ "app/Entities/Models/Book.php", "app/Entities/Models/EntityScope.php" ], "solution_diff": "diff --git a/app/Entities/Models/Book.php b/app/Entities/Models/Book.php\nindex afd50797b15..1909dbd5631 100644\n--- a/app/Entities/Models/Book.php\n+++ b/app...
[]
diff --git a/app/Entities/Models/Book.php b/app/Entities/Models/Book.php index afd50797b15..1909dbd5631 100644 --- a/app/Entities/Models/Book.php +++ b/app/Entities/Models/Book.php @@ -67,8 +67,7 @@ public function directPages(): HasMany */ public function chapters(): HasMany { - return $this->ha...
4
6
BookStackApp/BookStack#5850
BookStackApp/BookStack
5,850
abe9c1e5a3c624b17e7de52e119544ea0b37f499
a949900570c80c9c46c140a57c17e2d42738232e
API: Started building comments API endpoints For #4194 ### Todo - [x] Address TODOS in controller - [x] Testing - [x] Store API example requests/responses
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/Activity/` needed for: API: Started building comments API endpoints", "scope_files": [ "app/Activity/CommentRepo.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/Activity/Controllers/` needed f...
[ { "subtask_id": "s1", "scope_files": [ "app/Activity/CommentRepo.php" ], "solution_diff": "diff --git a/app/Activity/CommentRepo.php b/app/Activity/CommentRepo.php\nindex 7005f8fcf83..1802e390585 100644\n--- a/app/Activity/CommentRepo.php\n+++ b/app/Activity/CommentRepo.php\n@@ -4,10 +4,11 @@\...
[]
diff --git a/app/Activity/CommentRepo.php b/app/Activity/CommentRepo.php index 7005f8fcf83..1802e390585 100644 --- a/app/Activity/CommentRepo.php +++ b/app/Activity/CommentRepo.php @@ -4,10 +4,11 @@ use BookStack\Activity\Models\Comment; use BookStack\Entities\Models\Entity; +use BookStack\Entities\Models\Page; us...
20
30
BookStackApp/BookStack#5846
BookStackApp/BookStack
5,846
0bfd79925e9e23f9b6cd6d0534d5ba5ef49f40ca
ea6344898f435c54e225926a68d0b9a26697acd1
Images: Added nulling of image page relation on page delete Part of DB cleanup/restructure work.
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/Entities/Tools/` needed for: Images: Added nulling of image page relation on page delete", "scope_files": [ "app/Entities/Tools/TrashCan.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `database/mi...
[ { "subtask_id": "s1", "scope_files": [ "app/Entities/Tools/TrashCan.php" ], "solution_diff": "diff --git a/app/Entities/Tools/TrashCan.php b/app/Entities/Tools/TrashCan.php\nindex cc43b909625..c298169c383 100644\n--- a/app/Entities/Tools/TrashCan.php\n+++ b/app/Entities/Tools/TrashCan.php\n@@ ...
[]
diff --git a/app/Entities/Tools/TrashCan.php b/app/Entities/Tools/TrashCan.php index cc43b909625..c298169c383 100644 --- a/app/Entities/Tools/TrashCan.php +++ b/app/Entities/Tools/TrashCan.php @@ -15,6 +15,7 @@ use BookStack\Exceptions\NotifyException; use BookStack\Facades\Activity; use BookStack\Uploads\Attachment...
3
3
BookStackApp/BookStack#5365
BookStackApp/BookStack
5,365
a8ef820443cc444423f0fd21c4e1ce9fb64cbac0
ebe2ca7faff580ccb8064920a24fb2fad6412105
Range of fixes/updates for the new Lexical based editor Following feedback in #5245. - Adds auto-linking on space/enter press. - Adds dark-mode support. - Adds mobile support in UI and styles. - Adds "about/help" modal & button. - Details/collapsible blocks: - Added toolbar with actions - Made summary/lab...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Range of fixes/updates for the new Lexical based editor", "scope_files": [ "jest.config.ts" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `dev/build/` needed for: Range of fixes/updat...
[ { "subtask_id": "s1", "scope_files": [ "jest.config.ts" ], "solution_diff": "diff --git a/jest.config.ts b/jest.config.ts\nindex 3c04f05b218..53bfceb053e 100644\n--- a/jest.config.ts\n+++ b/jest.config.ts\n@@ -185,6 +185,7 @@ const config: Config = {\n // A map from regular expressions to pa...
[]
diff --git a/dev/build/svg-blank-transform.js b/dev/build/svg-blank-transform.js new file mode 100644 index 00000000000..5183014c880 --- /dev/null +++ b/dev/build/svg-blank-transform.js @@ -0,0 +1,14 @@ +// This is a basic transformer stub to help jest handle SVG files. +// Essentially blanks them since we don't really...
29
43
BookStackApp/BookStack#5731
BookStackApp/BookStack
5,731
0a73b70b64e1b4852a43b461cf21fdcdb1fb3346
d145efb6f6eac73947c7f3c53173f42b4dd9a615
New WYSIWYG editor changes for July 2025 Related to #5631 ### Changes - Fixed text highlight action & updated label. - Fixed unstable table cell background colors. - Fixed incorrect header levels used via format shortcuts. - Fixed UI menu not reflecting block format changes. - Fixed URLs not allowing any pro...
[ { "subtask_id": "s1", "goal": "Implement the changes under `lang/en/` needed for: New WYSIWYG editor changes for July 2025", "scope_files": [ "lang/en/editor.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `resources/js/wysiwyg/` needed for: New WYSIWYG editor ...
[ { "subtask_id": "s1", "scope_files": [ "lang/en/editor.php" ], "solution_diff": "diff --git a/lang/en/editor.php b/lang/en/editor.php\nindex 752c6f3f702..0d250e9a7bd 100644\n--- a/lang/en/editor.php\n+++ b/lang/en/editor.php\n@@ -48,6 +48,7 @@\n 'superscript' => 'Superscript',\n 'subsc...
[]
diff --git a/lang/en/editor.php b/lang/en/editor.php index 752c6f3f702..0d250e9a7bd 100644 --- a/lang/en/editor.php +++ b/lang/en/editor.php @@ -48,6 +48,7 @@ 'superscript' => 'Superscript', 'subscript' => 'Subscript', 'text_color' => 'Text color', + 'highlight_color' => 'Highlight color', 'custo...
15
18
BookStackApp/BookStack#5782
BookStackApp/BookStack
5,782
d6296ac7a5f7133abf4ddaa3c46ecf99d92416ae
a27ce6e9154387ac24ad3d3df3321ddb19dd7592
Laravel 12 & dependancy upgrades ### Doc Updates: - Update Notes: - The `APP_NAME` env option is now not used for the cache key. This option was never documented at all, but if used to prevent cache collisions please use the `CACHE_PREFIX` option instead.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Laravel 12 & dependancy upgrades", "scope_files": [ "composer.json", "composer.lock", "package-lock.json", "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes und...
[ { "subtask_id": "s1", "scope_files": [ "composer.json", "composer.lock", "package-lock.json", "package.json" ], "solution_diff": "diff --git a/composer.json b/composer.json\nindex 2ea1d802b59..2285a22cb18 100644\n--- a/composer.json\n+++ b/composer.json\n@@ -22,7 +22,7 @@\n ...
[]
diff --git a/app/Config/cache.php b/app/Config/cache.php index 9a0be8eabfc..01c822a653b 100644 --- a/app/Config/cache.php +++ b/app/Config/cache.php @@ -85,6 +85,6 @@ | */ - 'prefix' => env('CACHE_PREFIX', Str::slug(env('APP_NAME', 'laravel'), '_') . '_cache_'), + 'prefix' => env('CACHE_PREFIX', 'book...
10
15
BookStackApp/BookStack#5917
BookStackApp/BookStack
5,917
0f40aeb0d31cae2f7b27ec7e7a9e6ad7562341eb
3cd3e73f607dc7513c1bd7dc9d458808267eae4c
Internal reference handling on content copying For #3239 ### Remaining Todo - [x] Implement core reference change logic - [x] Manual testing to double check implementation
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/Entities/Models/` needed for: Internal reference handling on content copying", "scope_files": [ "app/Entities/Models/Page.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/Entities/Tools/` neede...
[ { "subtask_id": "s1", "scope_files": [ "app/Entities/Models/Page.php" ], "solution_diff": "diff --git a/app/Entities/Models/Page.php b/app/Entities/Models/Page.php\nindex 88c59bd1bd0..a1d3fc7b40d 100644\n--- a/app/Entities/Models/Page.php\n+++ b/app/Entities/Models/Page.php\n@@ -124,6 +124,14 ...
[]
diff --git a/app/Entities/Models/Page.php b/app/Entities/Models/Page.php index 88c59bd1bd0..a1d3fc7b40d 100644 --- a/app/Entities/Models/Page.php +++ b/app/Entities/Models/Page.php @@ -124,6 +124,14 @@ public function getUrl(string $path = ''): string return url('/' . implode('/', $parts)); } + /** +...
4
8
BookStackApp/BookStack#5913
BookStackApp/BookStack
5,913
ad582ab9f8eb6354f7da8930ddb3f455e5279319
cdd164e3e3e0fb1bcd40329043503b1bea849cab
Slug History Tracking & Usage Adds a purpose-built slug tracking system to note old slugs on changes, so that they can be used for lookup. We're already doing something similar via page revisions, but this will be a more robust implementation which works for all core content types. For #5411 ### Todo - [x] C...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/App/` needed for: Slug History Tracking & Usage", "scope_files": [ "app/App/SluggableInterface.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/Entities/Controllers/` needed for: Slug History T...
[ { "subtask_id": "s1", "scope_files": [ "app/App/SluggableInterface.php" ], "solution_diff": "diff --git a/app/App/SluggableInterface.php b/app/App/SluggableInterface.php\nindex 96af49cd323..dd544f5ed21 100644\n--- a/app/App/SluggableInterface.php\n+++ b/app/App/SluggableInterface.php\n@@ -5,11...
[]
diff --git a/app/App/SluggableInterface.php b/app/App/SluggableInterface.php index 96af49cd323..dd544f5ed21 100644 --- a/app/App/SluggableInterface.php +++ b/app/App/SluggableInterface.php @@ -5,11 +5,9 @@ /** * Assigned to models that can have slugs. * Must have the below properties. + * + * @property string $slu...
12
25
BookStackApp/BookStack#5909
BookStackApp/BookStack
5,909
47f12cc8f6830a8e20b3c3d8efad40d7c689a217
9934f85ba93a9450b2a7a02559e658c5181aca61
Images: Updated access to consider public secure_restricted Had prevented public access for images when secure_restricted images was enabled (and for just secure images) when app settings allowed public access. This considers the app public setting, and adds tests to cover extra scenarios to prevent regression. ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Images: Updated access to consider public secure_restricted", "scope_files": [ "composer.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/Uploads/` needed for: Images: Updated...
[ { "subtask_id": "s1", "scope_files": [ "composer.lock" ], "solution_diff": "diff --git a/composer.lock b/composer.lock\nindex 282a6b23988..881521a43d8 100644\n--- a/composer.lock\n+++ b/composer.lock\n@@ -62,16 +62,16 @@\n },\n {\n \"name\": \"aws/aws-sdk-php\",\n- ...
[]
diff --git a/app/Uploads/ImageService.php b/app/Uploads/ImageService.php index a26a04ac5c6..ed640913ec3 100644 --- a/app/Uploads/ImageService.php +++ b/app/Uploads/ImageService.php @@ -264,7 +264,7 @@ public function pathAccessible(string $imagePath): bool return false; } - if ($this->sto...
3
4
BookStackApp/BookStack#5899
BookStackApp/BookStack
5,899
8ab9252f9bd1626b87df044b14ce3469b1ca07bf
aaa28186bc0dff12c38f4627dac2034fa9ddb63d
Exports: Updated perm checking for images in ZIP exports For #5885 Adds to, uses and cleans-up central permission checking in ImageService to mirror that which would be experienced by users in the UI to result in the same image access conditions. Adds testing to cover.
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/Exports/ZipExports/` needed for: Exports: Updated perm checking for images in ZIP exports", "scope_files": [ "app/Exports/ZipExports/ZipExportReferences.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes un...
[ { "subtask_id": "s1", "scope_files": [ "app/Exports/ZipExports/ZipExportReferences.php" ], "solution_diff": "diff --git a/app/Exports/ZipExports/ZipExportReferences.php b/app/Exports/ZipExports/ZipExportReferences.php\nindex 64107cf21aa..a79988d44fe 100644\n--- a/app/Exports/ZipExports/ZipExpo...
[]
diff --git a/app/Exports/ZipExports/ZipExportReferences.php b/app/Exports/ZipExports/ZipExportReferences.php index 64107cf21aa..a79988d44fe 100644 --- a/app/Exports/ZipExports/ZipExportReferences.php +++ b/app/Exports/ZipExports/ZipExportReferences.php @@ -15,6 +15,7 @@ use BookStack\Permissions\Permission; use BookS...
3
5
BookStackApp/BookStack#5584
BookStackApp/BookStack
5,584
fa566f156ad8998d67a63be2856dafc7ce277d88
32b29fcdfc9e54416d5c01cf54b8a9df6753d326
Content Comments Related to #1265 ## Todo - [x] Inline comment display - [ ] ~~Option for controlling display~~ - Omitting this for initial implementation as we'll gather some feedback about best placement and control level. - [x] Selection zone representation (on focus/click?) - [x] Indicator for ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/Activity/` needed for: Content Comments", "scope_files": [ "app/Activity/CommentRepo.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/Activity/Controllers/` needed for: Content Comments", "...
[ { "subtask_id": "s1", "scope_files": [ "app/Activity/CommentRepo.php" ], "solution_diff": "diff --git a/app/Activity/CommentRepo.php b/app/Activity/CommentRepo.php\nindex 3336e17e988..7005f8fcf83 100644\n--- a/app/Activity/CommentRepo.php\n+++ b/app/Activity/CommentRepo.php\n@@ -4,6 +4,8 @@\n ...
[]
diff --git a/app/Activity/CommentRepo.php b/app/Activity/CommentRepo.php index 3336e17e988..7005f8fcf83 100644 --- a/app/Activity/CommentRepo.php +++ b/app/Activity/CommentRepo.php @@ -4,6 +4,8 @@ use BookStack\Activity\Models\Comment; use BookStack\Entities\Models\Entity; +use BookStack\Exceptions\NotifyException;...
17
40
BookStackApp/BookStack#5843
BookStackApp/BookStack
5,843
4c7d6420ee6ab08c5d1df5221962d84abcb89b21
d7335f091d3907232137afc3456386d5caab0e0e
Updated translations with latest Crowdin changes
[ { "subtask_id": "s1", "goal": "Implement the changes under `lang/de/` needed for: Updated translations with latest Crowdin changes", "scope_files": [ "lang/de/entities.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `lang/de_informal/` needed for: Updated trans...
[ { "subtask_id": "s1", "scope_files": [ "lang/de/entities.php" ], "solution_diff": "diff --git a/lang/de/entities.php b/lang/de/entities.php\nindex 2cfdd1490ed..94c327b7e06 100644\n--- a/lang/de/entities.php\n+++ b/lang/de/entities.php\n@@ -65,7 +65,7 @@\n 'import_errors_desc' => 'Die folge...
[]
diff --git a/lang/de/entities.php b/lang/de/entities.php index 2cfdd1490ed..94c327b7e06 100644 --- a/lang/de/entities.php +++ b/lang/de/entities.php @@ -65,7 +65,7 @@ 'import_errors_desc' => 'Die folgenden Fehler sind während des Importversuchs aufgetreten:', 'breadcrumb_siblings_for_page' => 'Navigate siblin...
6
8
BookStackApp/BookStack#5860
BookStackApp/BookStack
5,860
652124abaf8888339190bf2cbfd74c225ae28421
02d024aa322e4cd7ef127e1c45940ba122e34eea
API: Added endpoints for reading image data For #5519 ### Todo - [x] Check all tests are passing - [x] Run some manual tests
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/Config/` needed for: API: Added endpoints for reading image data", "scope_files": [ "app/Config/filesystems.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/Uploads/` needed for: API: Added end...
[ { "subtask_id": "s1", "scope_files": [ "app/Config/filesystems.php" ], "solution_diff": "diff --git a/app/Config/filesystems.php b/app/Config/filesystems.php\nindex ab73fec2968..facf5f2df2f 100644\n--- a/app/Config/filesystems.php\n+++ b/app/Config/filesystems.php\n@@ -11,7 +11,7 @@\n return [...
[]
diff --git a/app/Config/filesystems.php b/app/Config/filesystems.php index ab73fec2968..facf5f2df2f 100644 --- a/app/Config/filesystems.php +++ b/app/Config/filesystems.php @@ -11,7 +11,7 @@ return [ // Default Filesystem Disk - // Options: local, local_secure, s3 + // Options: local, local_secure, local_...
6
7
BookStackApp/BookStack#5854
BookStackApp/BookStack
5,854
c21c36e2a6668f0d1764598f37fb3524b0091609
751934c84a3e4c0482ca8086997c485ee6d6f077
Pagable and efficient search This PR aims to change how searches are done, to use a single core query instead of a query per entity type. This should make the search more efficient, while resulting in a stable & consistent response item count. ### Todo - [x] Debug large response processing time gap between maki...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/Entities/Models/` needed for: Pagable and efficient search", "scope_files": [ "app/Entities/Models/Entity.php", "app/Entities/Models/EntityTable.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes unde...
[ { "subtask_id": "s1", "scope_files": [ "app/Entities/Models/Entity.php", "app/Entities/Models/EntityTable.php" ], "solution_diff": "diff --git a/app/Entities/Models/Entity.php b/app/Entities/Models/Entity.php\nindex 77393cbbc4e..b47a029ece8 100644\n--- a/app/Entities/Models/Entity.php\n+...
[]
diff --git a/app/Entities/Models/Entity.php b/app/Entities/Models/Entity.php index 77393cbbc4e..b47a029ece8 100644 --- a/app/Entities/Models/Entity.php +++ b/app/Entities/Models/Entity.php @@ -471,4 +471,17 @@ protected function getContentsAttributes(): array return $contentFields; } + + /** + * ...
7
11
BookStackApp/BookStack#5844
BookStackApp/BookStack
5,844
4c7d6420ee6ab08c5d1df5221962d84abcb89b21
efff8700d47f83ab9c4c83b27143d9a27dc69c9a
Updated handling of deleted user ID handling in DB Updated uses of user ID to nullify on delete. Added testing to cover deletion of user relations. Added model factories to support changes and potential other tests. Cleans existing ID references in the DB via migration. Aligns with entity changes to get the dat...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/Access/` needed for: Updated handling of deleted user ID handling in DB", "scope_files": [ "app/Access/SocialAccount.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/Access/Mfa/` needed for: Up...
[ { "subtask_id": "s1", "scope_files": [ "app/Access/SocialAccount.php" ], "solution_diff": "diff --git a/app/Access/SocialAccount.php b/app/Access/SocialAccount.php\nindex b76dbb9ec85..f52f74cc48c 100644\n--- a/app/Access/SocialAccount.php\n+++ b/app/Access/SocialAccount.php\n@@ -5,18 +5,23 @@\...
[]
diff --git a/app/Access/Mfa/MfaValue.php b/app/Access/Mfa/MfaValue.php index 64d20eb18f6..dd3e04618f7 100644 --- a/app/Access/Mfa/MfaValue.php +++ b/app/Access/Mfa/MfaValue.php @@ -4,6 +4,7 @@ use BookStack\Users\Models\User; use Carbon\Carbon; +use Illuminate\Database\Eloquent\Factories\HasFactory; use Illuminate...
16
24
BookStackApp/BookStack#5800
BookStackApp/BookStack
5,800
08dfff05f4dd00bd155cc68990b997544d713373
b67110d33273b2ae691e55c022f424c3c8234f0e
Big scary entity table change This PR aims to merge the core entity types (books, chapters, pages, shelves) into one core table, with sub-tables for added data. This moves things into three new tables: - `entities` - All items, containing most shared metadata. - `entity_container_data` - The added data for cont...
[ { "subtask_id": "s1", "goal": "Implement the changes under `app/Access/Mfa/` needed for: Big scary entity table change", "scope_files": [ "app/Access/Mfa/MfaSession.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `app/Console/Commands/` needed for: Big scary en...
[ { "subtask_id": "s1", "scope_files": [ "app/Access/Mfa/MfaSession.php" ], "solution_diff": "diff --git a/app/Access/Mfa/MfaSession.php b/app/Access/Mfa/MfaSession.php\nindex 09b9e53b8ae..b1285341257 100644\n--- a/app/Access/Mfa/MfaSession.php\n+++ b/app/Access/Mfa/MfaSession.php\n@@ -11,7 +11,...
[]
diff --git a/app/Access/Mfa/MfaSession.php b/app/Access/Mfa/MfaSession.php index 09b9e53b8ae..b1285341257 100644 --- a/app/Access/Mfa/MfaSession.php +++ b/app/Access/Mfa/MfaSession.php @@ -11,7 +11,6 @@ class MfaSession */ public function isRequiredForUser(User $user): bool { - // TODO - Test bot...
35
100
BurntSushi/ripgrep#3431
BurntSushi/ripgrep
3,431
4857d6fa67db69a95cd4b6f2adda5d807d4d0119
d913049ba8f7aa3208be9c165c8c0776c2f1dcde
Provide Statically Compiled Binaries for (aarch64|arm64) Linux Hi, the current releases for arm64 Linux is based on gnu and not musl. As a result, the binary is dynamically linked: ```bash $ https://github.com/BurntSushi/ripgrep/releases/download/14.1.0/ripgrep-14.1.0-aarch64-unknown-linux-gnu.tar.gz $ file rg && ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: Provide Statically Compiled Binaries for (aarch64|arm64) Linux", "scope_files": [ ".github/workflows/ci.yml", ".github/workflows/release.yml" ] } ]
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/ci.yml", ".github/workflows/release.yml" ], "solution_diff": "diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml\nindex 47d33a4a7b..2095280421 100644\n--- a/.github/workflows/ci.yml\n+++ b/.github/workflows/ci.yml\n@...
[]
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 47d33a4a7b..2095280421 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -75,6 +75,10 @@ jobs: os: ubuntu-latest rust: stable target: aarch64-unknown-linux-gnu + - build: stable-aarch64-m...
1
2
BurntSushi/ripgrep#3416
BurntSushi/ripgrep
3,416
4519153e5e461527f4bca45b042fff45c4ec6fb9
543c11321b2eeb0db63acb37d1f9d993559d20bc
docs: add AI policy for contributors I've shamlessly adapted this from [uv's AI policy]. [uv's AI policy]: https://github.com/astral-sh/.github/blob/c5187e200db51bfe11d56e13053d29bd3793fdd8/AI_POLICY.md
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: docs: add AI policy for contributors", "scope_files": [ "AI_POLICY.md", "CONTRIBUTING.md" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "AI_POLICY.md", "CONTRIBUTING.md" ], "solution_diff": "diff --git a/AI_POLICY.md b/AI_POLICY.md\nnew file mode 100644\nindex 0000000000..e0ddbaaea0\n--- /dev/null\n+++ b/AI_POLICY.md\n@@ -0,0 +1,38 @@\n+# AI Policy\n+\n+Using AI (i.e., LLMs) as tool...
[]
diff --git a/AI_POLICY.md b/AI_POLICY.md new file mode 100644 index 0000000000..e0ddbaaea0 --- /dev/null +++ b/AI_POLICY.md @@ -0,0 +1,38 @@ +# AI Policy + +Using AI (i.e., LLMs) as tools for coding is welcome. A high bar is held for +all contributions to this project. Moreover, the project maintainers remain +responsi...
1
2
BurntSushi/ripgrep#3279
BurntSushi/ripgrep
3,279
cb66736f146f093497f4dc537b33d0826f9af33c
3fc9f4134bb95364f8748610d69f27dfa3ca472b
docs: clarify half-boundary syntax for the -w/--word-regexp flag In [regex 1.10.0](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md#1100-2023-10-09), the `\b{start-half}` and `\b{end-half}` assertions were introduced to improve how the `-w`/`--word-regexp` flag handles patterns containing non-word character...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: docs: clarify half-boundary syntax for the -w/--word-regexp flag", "scope_files": [ "GUIDE.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `crates/core/flags/` needed for: docs: cla...
[ { "subtask_id": "s1", "scope_files": [ "GUIDE.md" ], "solution_diff": "diff --git a/GUIDE.md b/GUIDE.md\nindex 6d51e460ef..5f1378839c 100644\n--- a/GUIDE.md\n+++ b/GUIDE.md\n@@ -1004,7 +1004,11 @@ used options that will likely impact how you use ripgrep on a regular basis.\n as a literal st...
[]
diff --git a/GUIDE.md b/GUIDE.md index 6d51e460ef..5f1378839c 100644 --- a/GUIDE.md +++ b/GUIDE.md @@ -1004,7 +1004,11 @@ used options that will likely impact how you use ripgrep on a regular basis. as a literal string. * `-w/--word-regexp`: Require that all matches of the pattern be surrounded by word boundari...
2
2
BurntSushi/ripgrep#3165
BurntSushi/ripgrep
3,165
096f79ab9824753cedd989da92076be12f0904ea
0dc19f291b97826ab4fa3613e10cac5eadb8ae6b
Add RISC-V (riscv64gc-unknown-linux-gnu) CI and release artifacts **This PR adds official riscv64 Linux release artifacts so RISC-V developers can run ripgrep natively without cross-compiling.** ## Context & Purpose **Why**: ripgrep ships binaries for many platforms but not riscv64. Adding a riscv64 GNU artifact giv...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Add RISC-V (riscv64gc-unknown-linux-gnu) CI and release artifacts", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflows/` needed for: Add ...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex afd821dd13..5dfe1f5a84 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -67,6 +67,8 @@ Feature enhancements:\n Improve completions for `--hyperlink-format` in bash and...
[]
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bf6a5541fe..47d33a4a7b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -95,6 +95,10 @@ jobs: os: ubuntu-latest rust: stable target: s390x-unknown-linux-gnu + - build: stable-riscv64 + ...
3
4
BurntSushi/ripgrep#3248
BurntSushi/ripgrep
3,248
cd1f981beafaeb9b61537e47e91314cea125400b
0ab6dd87ce7427e869eaca194f6e2b7579a25936
Fix compression tests in QEMU cross-compilation environments ## Problem Compression tests (lz4, brotli, zstd) fail on `riscv64` when running under QEMU user-mode emulation. The tests attempt to execute compression commands even when the required tools are missing, instead of skipping as expected. ## Root Cause Th...
[ { "subtask_id": "s1", "goal": "Implement the changes under `tests/` needed for: Fix compression tests in QEMU cross-compilation environments", "scope_files": [ "tests/misc.rs", "tests/util.rs" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "tests/misc.rs", "tests/util.rs" ], "solution_diff": "diff --git a/tests/misc.rs b/tests/misc.rs\nindex df79e95655..aae84da8d4 100644\n--- a/tests/misc.rs\n+++ b/tests/misc.rs\n@@ -922,8 +922,6 @@ be, to a very large extent, the result of luck. Sher...
[]
diff --git a/tests/misc.rs b/tests/misc.rs index df79e95655..aae84da8d4 100644 --- a/tests/misc.rs +++ b/tests/misc.rs @@ -922,8 +922,6 @@ be, to a very large extent, the result of luck. Sherlock Holmes eqnice!(expected, cmd.stdout()); }); -// lz4 decompression tool doesn't work under RISC-V QEMU emulation in ...
1
2
BurntSushi/ripgrep#3212
BurntSushi/ripgrep
3,212
36b7597693c994ffaf023b95d2e18aeeda7d9286
b9517b5c3054385cdad0a4e681e1df5c7b0bcea5
ignore: only stat .jj if we actually care I was comparing the work being done by fd and find and noticed (with strace -f -c -S calls) that fd was doing a ton of failed statx calls. Upon closer inspection it was stating .jj even though I was passing --no-ignore. Eventually I turned up this check in Ignore::add_child_pa...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: ignore: only stat .jj if we actually care", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `crates/ignore/src/` needed for: ignore: only stat .jj if we ...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 2b17916042..ecb564d925 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -2,6 +2,11 @@ TBD\n ===\n Unreleased changes. Release notes have not yet been written.\n \n+Bug f...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 2b17916042..ecb564d925 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,11 @@ TBD === Unreleased changes. Release notes have not yet been written. +Bug fixes: + +* [BUG #3212](https://github.com/BurntSushi/ripgrep/pull/3212): + Don't check for the existence of ...
2
2
BurntSushi/ripgrep#3195
BurntSushi/ripgrep
3,195
38d630261aded3a8e535fe85761e68af35bc462d
eb60087486a01f573cae9186fcca8973ef602dfd
Line buffering appears broken in 15.0.0 ### Please tick this box to confirm you have reviewed the above. - [x] I have a different issue. ### What version of ripgrep are you using? ``` ripgrep 15.0.0 features:+pcre2 simd(compile):+SSE2,+SSSE3,+AVX2 simd(runtime):+SSE2,+SSSE3,+AVX2 PCRE2 10.45 is available (JIT is ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Line buffering appears broken in 15.0.0", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `crates/searcher/src/` needed for: Line buffering appears broke...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 22a2b39777..eaf51031a8 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -1,7 +1,12 @@\n-TBD\n-===\n+15.0.1\n+======\n Unreleased changes. Release notes have not yet been...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 22a2b39777..eaf51031a8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,12 @@ -TBD -=== +15.0.1 +====== Unreleased changes. Release notes have not yet been written. +Bug fixes: + +* [BUG #3194](https://github.com/BurntSushi/ripgrep/issues/3194): + Fix a regressi...
3
3
BurntSushi/ripgrep#3190
BurntSushi/ripgrep
3,190
b610d1cb1506feab33459c5853e4c0d0cb16a6e2
5e0e5b538bfc297c92a27465bddf74f7d3f5d1bc
printer: fix `--stats` for `--json` Somehow, the JSON printer seems to have never emitted correct summary statistics. And I believe #3178 is the first time anyone has ever reported it. I believe this bug has persisted for years. That's surprising. Anyway, the problem here was that we were bailing out of `finish()` on...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: printer: fix `--stats` for `--json`", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `crates/printer/src/` needed for: printer: fix `--stats` for `--jso...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 439c0b3da6..c52964ff1f 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -50,6 +50,8 @@ Bug fixes:\n Statically compile PCRE2 into macOS release artifacts on `aarch64`....
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 439c0b3da6..c52964ff1f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -50,6 +50,8 @@ Bug fixes: Statically compile PCRE2 into macOS release artifacts on `aarch64`. * [BUG #3173](https://github.com/BurntSushi/ripgrep/issues/3173): Fix ancestor ignore filter bug when...
2
2
BurntSushi/ripgrep#3189
BurntSushi/ripgrep
3,189
9ec08522bee566c8fbf03c340acd7a1ff1789a9f
12b81e5ba3468269d60521902db3e6fd5b3d3826
ignore::WalkBuilder.git_global(true) does not behave correctly with rooted files This bug was originally reported in the helix repository: https://github.com/helix-editor/helix/issues/12604 I was doing a bit of a research in that issue, and I found that helix [is using the package `ignore`](https://github.com/helix-e...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: ignore::WalkBuilder.git_global(true) does not behave correctly with rooted files", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `crates/core/flags/` n...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex ed4f567485..439c0b3da6 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -50,6 +50,8 @@ Bug fixes:\n Statically compile PCRE2 into macOS release artifacts on `aarch64`....
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index ed4f567485..439c0b3da6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -50,6 +50,8 @@ Bug fixes: Statically compile PCRE2 into macOS release artifacts on `aarch64`. * [BUG #3173](https://github.com/BurntSushi/ripgrep/issues/3173): Fix ancestor ignore filter bug when...
4
6
BurntSushi/ripgrep#3185
BurntSushi/ripgrep
3,185
de2567a4c76fa671005538d6cd841abc44932b9a
146f78f77ff24e74fccf6da91a5e28ce4c48dfa1
Excessive slowdown with larger `-A` context windows? ### Please tick this box to confirm you have reviewed the above. - [x] I have a different issue. ### What version of ripgrep are you using? rg --version ripgrep 14.1.1 features:-pcre2 simd(compile):+SSE2,-SSSE3,-AVX2 simd(runtime):+SSE2,+SSSE3,+AVX2 PCRE2 is no...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Excessive slowdown with larger `-A` context windows?", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `crates/searcher/src/` needed for: Excessive slowd...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex b6ece534a8..ed4f567485 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -8,6 +8,8 @@ Performance improvements:\n Don't resolve helper binaries on Windows when `-z/--se...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index b6ece534a8..ed4f567485 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,8 @@ Performance improvements: Don't resolve helper binaries on Windows when `-z/--search-zip` isn't used. * [PERF #2865](https://github.com/BurntSushi/ripgrep/pull/2865): Avoid using pat...
3
4
BurntSushi/ripgrep#3182
BurntSushi/ripgrep
3,182
916415857f084e63efda03cf25a67fe7f6d24244
1e80e6e8a4ba4126e04df36aa9558bf6cb6ce73c
rg panic caused by --replace, --multiline, a particular pattern, and search text containing repeats and newlines ### Please tick this box to confirm you have reviewed the above. - [x] I have a different issue. ### What version of ripgrep are you using? ripgrep 14.1.1 features:+pcre2 simd(compile):+SSE2,-SSSE3,-AVX...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: rg panic caused by --replace, --multiline, a particular pattern, and search text containing repeats and newlines", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the chan...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 8f0177d12e..b6ece534a8 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -4,6 +4,8 @@ Unreleased changes. Release notes have not yet been written.\n \n Performance improv...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 8f0177d12e..b6ece534a8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,8 @@ Unreleased changes. Release notes have not yet been written. Performance improvements: +* [PERF #2111](https://github.com/BurntSushi/ripgrep/issues/2111): + Don't resolve helper binar...
3
3
BurntSushi/ripgrep#3177
BurntSushi/ripgrep
3,177
7c2161d68755e2c47db26717f6757f5099d500e4
88c471220d1564296c258c5cdd5990858baea409
fix a few small outstanding bugs This combines multiple fixes in one PR. See the commit messages for details.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: fix a few small outstanding bugs", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `crates/core/flags/` needed for: fix a few small outstanding bugs", ...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 5dfe1f5a84..91d2994098 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -12,9 +12,11 @@ Bug fixes:\n * [BUG #829](https://github.com/BurntSushi/ripgrep/issues/829),\n ...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 5dfe1f5a84..91d2994098 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,9 +12,11 @@ Bug fixes: * [BUG #829](https://github.com/BurntSushi/ripgrep/issues/829), [BUG #2731](https://github.com/BurntSushi/ripgrep/issues/2731), [BUG #2747](https://github.com/BurntSush...
3
6
BurntSushi/ripgrep#3174
BurntSushi/ripgrep
3,174
bb88a1ac45c70bef97e0d6ccd6e91595610de860
ce3d884a06ab68082846ed1a58e904904330ee23
hidden files whitelisted by ancestor .ignore are not searched when . is directory argument ### Please tick this box to confirm you have reviewed the above. - [x] I have a different issue. ### What version of ripgrep are you using? ``` ripgrep 14.1.1 features:+pcre2 simd(compile):+SSE2,-SSSE3,-AVX2 simd(runtime):+S...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: hidden files whitelisted by ancestor .ignore are not searched when . is directory argument", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `crates/igno...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 075b997c7f..23efcadc7b 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -37,6 +37,8 @@ Bug fixes:\n Ensure hyphens in flag names are escaped in the roff text for the m...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 075b997c7f..23efcadc7b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -37,6 +37,8 @@ Bug fixes: Ensure hyphens in flag names are escaped in the roff text for the man page. * [BUG #3155](https://github.com/BurntSushi/ripgrep/issues/3155): Statically compile PCRE2 in...
3
3
BurntSushi/ripgrep#3166
BurntSushi/ripgrep
3,166
9802945e6342ec284633924cb7d8d3ce67204995
81b166187f8bed4c623856b2541efb29a07867f0
`--max-count` not working properly with `--multiline` if matches are on consecutive lines ### Please tick this box to confirm you have reviewed the above. - [x] I have a different issue. ### What version of ripgrep are you using? ripgrep 14.1.1 (rev 4649aa9700) features:+pcre2 PCRE2 10.43 is available (JIT is una...
[ { "subtask_id": "s1", "goal": "Implement the changes under `crates/core/flags/` needed for: `--max-count` not working properly with `--multiline` if matches are on consecutive lines", "scope_files": [ "crates/core/flags/hiargs.rs" ] }, { "subtask_id": "s2", "goal": "Implement the c...
[ { "subtask_id": "s1", "scope_files": [ "crates/core/flags/hiargs.rs" ], "solution_diff": "diff --git a/crates/core/flags/hiargs.rs b/crates/core/flags/hiargs.rs\nindex a0b3282c93..a98bde23c6 100644\n--- a/crates/core/flags/hiargs.rs\n+++ b/crates/core/flags/hiargs.rs\n@@ -596,7 +596,6 @@ impl ...
[]
diff --git a/crates/core/flags/hiargs.rs b/crates/core/flags/hiargs.rs index a0b3282c93..a98bde23c6 100644 --- a/crates/core/flags/hiargs.rs +++ b/crates/core/flags/hiargs.rs @@ -596,7 +596,6 @@ impl HiArgs { ) -> grep::printer::JSON<W> { grep::printer::JSONBuilder::new() .pretty(false) - ...
2
3
BurntSushi/ripgrep#3157
BurntSushi/ripgrep
3,157
c1fc6a5eb8c971fc43041d3df34cf8bd49f31032
956e84d9d878f65391fc21962c10cccb819eaa6d
rg -c omits files when a NUL byte is encountered after an earlier match ### Please tick this box to confirm you have reviewed the above. - [x] I have a different issue. ### What version of ripgrep are you using? ``` ripgrep 14.1.1 features:+pcre2 simd(compile):+SSE2,+SSSE3,-AVX2 simd(runtime):+SSE2,+SSSE3,+AVX2 PC...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: rg -c omits files when a NUL byte is encountered after an earlier match", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `crates/core/flags/` needed for...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 7fe2cbe16e..075b997c7f 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -31,6 +31,8 @@ Bug fixes:\n Preserve line terminators when using `-r/--replace` flag.\n * [BUG ...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 7fe2cbe16e..075b997c7f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -31,6 +31,8 @@ Bug fixes: Preserve line terminators when using `-r/--replace` flag. * [BUG #3108](https://github.com/BurntSushi/ripgrep/issues/3108): Fix a bug where `-q --files-without-match` in...
3
4
BurntSushi/ripgrep#3156
BurntSushi/ripgrep
3,156
8b5d3d1c1e3b0e32f22aa634d000b314f6d4d465
f05549d7be238c622c516bc574dd7aa174a87f3a
ripgrep is not self-contained on aarach64 darwin ### Please tick this box to confirm you have reviewed the above. - [x] I have a different issue. ### What version of ripgrep are you using? 14.1.1 ### How did you install ripgrep? Download tarball from github release ### What operating system are you using ripgrep...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: ripgrep is not self-contained on aarach64 darwin", "scope_files": [ "CHANGELOG.md", "RELEASE-CHECKLIST.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflows/` nee...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md", "RELEASE-CHECKLIST.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 928d099820..7fe2cbe16e 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -33,6 +33,8 @@ Bug fixes:\n Fix a bug where `-q --files-without-m...
[]
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9a9cc0386e..3139d03247 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -114,6 +114,10 @@ jobs: os: macos-latest rust: nightly target: x86_64-apple-darwin + - build: ...
3
4
BurntSushi/ripgrep#3154
BurntSushi/ripgrep
3,154
491bf3f6d5bc1a621754440e291960f460a9c003
635afac2ebe52dcb5c8393567f204703d0c7c347
Inconsistent behaviour when using --files-with-matches vs without ### Please tick this box to confirm you have reviewed the above. - [x] I have a different issue. ### What version of ripgrep are you using? ripgrep 14.1.1 features:+pcre2 simd(compile):+SSE2,-SSSE3,-AVX2 simd(runtime):+SSE2,+SSSE3,+AVX2 PCRE2 10.43...
[ { "subtask_id": "s1", "goal": "Implement the changes under `crates/printer/src/` needed for: Inconsistent behaviour when using --files-with-matches vs without", "scope_files": [ "crates/printer/src/summary.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `tests/`...
[ { "subtask_id": "s1", "scope_files": [ "crates/printer/src/summary.rs" ], "solution_diff": "diff --git a/crates/printer/src/summary.rs b/crates/printer/src/summary.rs\nindex 86ce09544c..615abd2e15 100644\n--- a/crates/printer/src/summary.rs\n+++ b/crates/printer/src/summary.rs\n@@ -683,7 +683,...
[]
diff --git a/crates/printer/src/summary.rs b/crates/printer/src/summary.rs index 86ce09544c..615abd2e15 100644 --- a/crates/printer/src/summary.rs +++ b/crates/printer/src/summary.rs @@ -683,7 +683,11 @@ impl<'p, 's, M: Matcher, W: WriteColor> Sink for SummarySink<'p, 's, M, W> { true ...
2
2
BurntSushi/ripgrep#3152
BurntSushi/ripgrep
3,152
a7b7d81d66b6e2e4311d5dd0683022c2978650f1
e3addd3f675cef740381bbd40d27c11ee925e691
cargo: set MSRV to 1.85 I believe the current stable version of Debian packages 1.85 rustc. So if the next release of ripgrep uses a higher MSRV, then I think Debian won't be able to package it. It also turned out that I wasn't using anything from beyond Rust 1.85 anyway. It's likely that I could make use of let-cha...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: cargo: set MSRV to 1.85", "scope_files": [ "Cargo.toml", "README.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflows/` needed for: cargo: set MSRV to 1.85", ...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.toml", "README.md" ], "solution_diff": "diff --git a/Cargo.toml b/Cargo.toml\nindex ad58eca02e..baeac1bdc4 100644\n--- a/Cargo.toml\n+++ b/Cargo.toml\n@@ -25,7 +25,7 @@ exclude = [\n build = \"build.rs\"\n autotests = false\n edition = \"2024...
[]
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 33622fcabc..bf6a5541fe 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -53,7 +53,7 @@ jobs: include: - build: pinned os: ubuntu-latest - rust: 1.88.0 + rust: 1.85.0 - bu...
2
3
BurntSushi/ripgrep#3151
BurntSushi/ripgrep
3,151
bb8172fe9baa450ede7ff84677ab45048675fd02
2355ee6ae93d400e876aca526d7b7c751ad21bad
fix: clippy errors I opened the project in RustRover on Windows after you merged the rollup branch, and it showed a few Clippy errors. Those were displayed by highlighting a few files in red, which is annoying, so I thought I'd rather get rid of them. This is basically the equivalent of handling the output of `carg...
[ { "subtask_id": "s1", "goal": "Implement the changes under `crates/cli/src/` needed for: fix: clippy errors", "scope_files": [ "crates/cli/src/decompress.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `crates/ignore/examples/` needed for: fix: clippy errors", ...
[ { "subtask_id": "s1", "scope_files": [ "crates/cli/src/decompress.rs" ], "solution_diff": "diff --git a/crates/cli/src/decompress.rs b/crates/cli/src/decompress.rs\nindex 9e93c98257..0bfc93e69f 100644\n--- a/crates/cli/src/decompress.rs\n+++ b/crates/cli/src/decompress.rs\n@@ -177,7 +177,7 @@ ...
[]
diff --git a/crates/cli/src/decompress.rs b/crates/cli/src/decompress.rs index 9e93c98257..0bfc93e69f 100644 --- a/crates/cli/src/decompress.rs +++ b/crates/cli/src/decompress.rs @@ -177,7 +177,7 @@ impl DecompressionMatcher { /// If there are multiple possible commands matching the given path, then /// the c...
3
4
BurntSushi/ripgrep#3149
BurntSushi/ripgrep
3,149
119a58a400ea948c2d2b0cd4ec58361e74478641
14d19122f372292238c1c82d70673973a54cd207
rollup: clear the extant PR queue This rolls up a number of outstanding PRs into one. Where possible, I preserved author information in each commit. Most non-trivial PRs required changes. Instead of letting the PRs go through more rounds of feedback, I find it more efficient to just lump everything in all at once.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: rollup: clear the extant PR queue", "scope_files": [ "CHANGELOG.md", "Cargo.lock", "Cargo.toml", "FAQ.md", "README.md", "build.rs", "rustfmt.toml" ] }, { "subtask_id": "...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md", "Cargo.lock", "Cargo.toml", "FAQ.md", "README.md", "build.rs", "rustfmt.toml" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 9cc576ec65..928d099820 100644\n--- a/CHANGELOG.md\n+++ b...
[]
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5389cafa0c..33622fcabc 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -99,11 +99,14 @@ jobs: os: macos-latest rust: nightly - build: win-msvc - os: windows-2022 + os: windows-...
31
84
BurntSushi/ripgrep#3109
BurntSushi/ripgrep
3,109
3b7fd442a6f3aa73f650e763d7cbb902c03d700e
682833b6506f98304d07bdde46cb199c034e0d1d
msrv: bump to Rust 1.88 This is to prep for the next release. I don't know if the requirement will actually be for Rust 1.88, but it is intended to support the latest version of stable Rust.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: msrv: bump to Rust 1.88", "scope_files": [ "Cargo.toml", "README.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflows/` needed for: msrv: bump to Rust 1.88", ...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.toml", "README.md" ], "solution_diff": "diff --git a/Cargo.toml b/Cargo.toml\nindex 2ec69c92a5..f956a8e672 100644\n--- a/Cargo.toml\n+++ b/Cargo.toml\n@@ -24,7 +24,7 @@ exclude = [\n build = \"build.rs\"\n autotests = false\n edition = \"2021...
[]
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4c8a3bfee4..5389cafa0c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -53,7 +53,7 @@ jobs: include: - build: pinned os: ubuntu-latest - rust: 1.74.0 + rust: 1.88.0 - bu...
2
3
BurntSushi/ripgrep#3028
BurntSushi/ripgrep
3,028
5fbc4fee64131b5cd14675be71e43768a9763553
00cbee12335a3d01c63976bfe3a063a48e977af0
build(deps): bump crossbeam-channel from 0.5.13 to 0.5.15 Bumps [crossbeam-channel](https://github.com/crossbeam-rs/crossbeam) from 0.5.13 to 0.5.15. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crossbeam-rs/crossbeam/releases">crossbeam-channel's releases</a>.</em></p> <b...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: build(deps): bump crossbeam-channel from 0.5.13 to 0.5.15", "scope_files": [ "Cargo.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `crates/ignore/` needed for: build(deps): bump ...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex 07420ec4e8..fb94f9d016 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -47,9 +47,9 @@ checksum = \"baf1de4339761588bc0619e3cbc0120ee582ebb74b53b4efbf79117bd2da40fd\"\n \n [[packa...
[]
diff --git a/Cargo.lock b/Cargo.lock index 07420ec4e8..fb94f9d016 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -47,9 +47,9 @@ checksum = "baf1de4339761588bc0619e3cbc0120ee582ebb74b53b4efbf79117bd2da40fd" [[package]] name = "crossbeam-channel" -version = "0.5.13" +version = "0.5.15" source = "registry+https://github...
2
2
CanCanCommunity/cancancan#675
CanCanCommunity/cancancan
675
07dc15d55fe79fd46fabf59d16b815fa98d03d53
c220e8741f11cc8313d57b3c0b9baf5cf5b67d59
Support modifying the `accessible_by` querying strategy on a per-query basis See discussion at https://github.com/CanCanCommunity/cancancan/discussions/668
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Support modifying the `accessible_by` querying strategy on a per-query basis", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `lib/cancan/` needed for: ...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex d9a426283..b0952e3ff 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -1,3 +1,7 @@\n+## Unreleased\n+\n+* [#675](https://github.com/CanCanCommunity/cancancan/pull/675): ...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index d9a426283..b0952e3ff 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## Unreleased + +* [#675](https://github.com/CanCanCommunity/cancancan/pull/675): Support modifying the `accessible_by` querying strategy on a per-query basis. ([@ghiculescu][]) + ## 3.2.1 ...
3
4
CanCanCommunity/cancancan#849
CanCanCommunity/cancancan
849
54a605c10b839fed0160074a66e732e8d9fb522f
4112cbc80f8f552c90ff7fe31f1ad5d406ce946b
Update the tests matrix Let's refresh the matrix of tests, removing ruby 2.6 and rails < 5.2. We also add rails 7.0 and 7.1 and ruby 3.2 and 3.3. We stop testing on jruby and truffleruby because tests are failing right now
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Update the tests matrix", "scope_files": [ ".gitignore", ".rubocop.yml", ".rubocop_todo.yml", "Appraisals" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/wor...
[ { "subtask_id": "s1", "scope_files": [ ".gitignore", ".rubocop.yml", ".rubocop_todo.yml", "Appraisals" ], "solution_diff": "diff --git a/.gitignore b/.gitignore\nindex 8ec036cb..4eb7b201 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -13,6 +13,6 @@ Gemfile.lock\n .ruby-versio...
[ { "subtask_id": "s2", "comment": "> We stop testing on jruby and truffleruby because tests are failing right now\r\n\r\nIt seems specs should pass on TruffleRuby now (or actually fail in the same way they are failing on CRuby on the `develop` branch).\r\n\r\nI've enabled truffleruby-head in a fork (https://...
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 08d0a5af..49687f7a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -14,41 +14,38 @@ jobs: strategy: fail-fast: false matrix: - ruby: ['2.6', '2.7', '3.0', 'jruby', 'truffleruby'] - gem...
4
13
CanCanCommunity/cancancan#839
CanCanCommunity/cancancan
839
178d2c5bdf97225751a1a089e9815a4060b03265
f68d752f735d3af7a201b41fd34a5f96d1678ac6
In permitted_attributes, switch from database column detection to Rails attributes detection. Addresses #838 This pull request addresses #838 and makes Cancancan "see" attributes that are not backed by the database. It enables code like the following: ```ruby class Foo < ApplicationRecord attribute :bar end `...
[ { "subtask_id": "s1", "goal": "Implement the changes under `lib/cancan/ability/` needed for: In permitted_attributes, switch from database column detection to Rails attributes detection. Addresses #838", "scope_files": [ "lib/cancan/ability/strong_parameter_support.rb" ] }, { "subtask_...
[ { "subtask_id": "s1", "scope_files": [ "lib/cancan/ability/strong_parameter_support.rb" ], "solution_diff": "diff --git a/lib/cancan/ability/strong_parameter_support.rb b/lib/cancan/ability/strong_parameter_support.rb\nindex 31da7457..892d250a 100644\n--- a/lib/cancan/ability/strong_parameter_...
[]
diff --git a/lib/cancan/ability/strong_parameter_support.rb b/lib/cancan/ability/strong_parameter_support.rb index 31da7457..892d250a 100644 --- a/lib/cancan/ability/strong_parameter_support.rb +++ b/lib/cancan/ability/strong_parameter_support.rb @@ -31,7 +31,7 @@ def get_attributes(rule, subject) klass = subj...
2
2
CanCanCommunity/cancancan#841
CanCanCommunity/cancancan
841
178d2c5bdf97225751a1a089e9815a4060b03265
56e1c57e396f8acaa2ccc8a27ad6b0d0def25543
add docs page to cancancan using vitepress I think cancancan could benefit a docs page using vitepress. VitePress https://vitepress.dev is already used by many others and it allows user to create fast docs page. You can see a preview at: https://cancancan.pages.dev (i will remove this project so you can claim th...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: add docs page to cancancan using vitepress", "scope_files": [ ".gitignore", "CONTRIBUTING.md", "package-lock.json", "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the ch...
[ { "subtask_id": "s1", "scope_files": [ ".gitignore", "CONTRIBUTING.md", "package-lock.json", "package.json" ], "solution_diff": "diff --git a/.gitignore b/.gitignore\nindex 5b936d51..8ec036cb 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -13,3 +13,6 @@ Gemfile.lock\n .ruby-v...
[ { "subtask_id": "s3", "comment": "assuming this will be the domain", "revised_diff": "diff --git a/docs/.vitepress/config.mts b/docs/.vitepress/config.mts\nnew file mode 100644\nindex 00000000..d492843d\n--- /dev/null\n+++ b/docs/.vitepress/config.mts\n@@ -0,0 +1,97 @@\n+import { defineConfig } from 'vi...
diff --git a/.gitignore b/.gitignore index 5b936d51..8ec036cb 100644 --- a/.gitignore +++ b/.gitignore @@ -13,3 +13,6 @@ Gemfile.lock .ruby-version .ruby-gemset /tmp +docs/.vitepress/cache +node_modules +docs/.vitepress/dist diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 7252e2f3..a925aa7e 100644 --- a/CONTRIB...
5
23
CanCanCommunity/cancancan#843
CanCanCommunity/cancancan
843
178d2c5bdf97225751a1a089e9815a4060b03265
4caca501b6079f35ebeb5cde8906b8eaad0e347a
Compress duplicates rules Hello 👋 In my current project, some rules are duplicated and applied several times. It creates big SQL queries that are hard to read. With this PR, the duplicated rules are removed and the SQL query is equivalent and simpler. We also have some performance gain on some specific querie...
[ { "subtask_id": "s1", "goal": "Implement the changes under `lib/cancan/` needed for: Compress duplicates rules", "scope_files": [ "lib/cancan/rules_compressor.rb" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `spec/cancan/` needed for: Compress duplicates rules", ...
[ { "subtask_id": "s1", "scope_files": [ "lib/cancan/rules_compressor.rb" ], "solution_diff": "diff --git a/lib/cancan/rules_compressor.rb b/lib/cancan/rules_compressor.rb\nindex 01b9e325..46f5a4cb 100644\n--- a/lib/cancan/rules_compressor.rb\n+++ b/lib/cancan/rules_compressor.rb\n@@ -11,6 +11,7...
[]
diff --git a/lib/cancan/rules_compressor.rb b/lib/cancan/rules_compressor.rb index 01b9e325..46f5a4cb 100644 --- a/lib/cancan/rules_compressor.rb +++ b/lib/cancan/rules_compressor.rb @@ -11,6 +11,7 @@ def initialize(rules) end def compress(array) + array = simplify(array) idx = array.rindex(&:ca...
2
2
CanCanCommunity/cancancan#689
CanCanCommunity/cancancan
689
7629f56a090183554a657bc4d3f63b10421ef430
c65a9cda6f40f68f70e00f1fd8334f1204fef15b
Implement detection for sti for including subclasses in check * Remove subclass rule inclusion for non sti classes * Start of implementing more sti detection utilities which are going to be used in a rewrite (coming) @coorasse how do you want to handle this ? It seems like STI will have some issues with the curren...
[ { "subtask_id": "s1", "goal": "Implement the changes under `lib/cancan/` needed for: Implement detection for sti for including subclasses in check", "scope_files": [ "lib/cancan/class_matcher.rb", "lib/cancan/sti_detector.rb" ] }, { "subtask_id": "s2", "goal": "Implement the ...
[ { "subtask_id": "s1", "scope_files": [ "lib/cancan/class_matcher.rb", "lib/cancan/sti_detector.rb" ], "solution_diff": "diff --git a/lib/cancan/class_matcher.rb b/lib/cancan/class_matcher.rb\nindex 0bdf0fd9..65efcca3 100644\n--- a/lib/cancan/class_matcher.rb\n+++ b/lib/cancan/class_match...
[ { "subtask_id": "s1", "comment": "Only include the subclasses in the check if the model is an sti class", "revised_diff": "diff --git a/lib/cancan/class_matcher.rb b/lib/cancan/class_matcher.rb\nindex 0bdf0fd9..65efcca3 100644\n--- a/lib/cancan/class_matcher.rb\n+++ b/lib/cancan/class_matcher.rb\n@@ -1,...
diff --git a/lib/cancan/class_matcher.rb b/lib/cancan/class_matcher.rb index 0bdf0fd9..65efcca3 100644 --- a/lib/cancan/class_matcher.rb +++ b/lib/cancan/class_matcher.rb @@ -1,3 +1,5 @@ +require_relative 'sti_detector' + # This class is responsible for matching classes and their subclasses as well as # upmatching cl...
3
4
CanCanCommunity/cancancan#474
CanCanCommunity/cancancan
474
7a144c28edf1119cb93c8ac12957056a59656d9d
795a51c79d29fb51a858f27b069f5f96a63dd7a7
Adds support for rules at the attribute/method level Allows you to add attribute-level rules, e.g. ```ruby can :read, User, :first_name can :read, User, :last_name cannot :read, User, :api_key ```
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Adds support for rules at the attribute/method level", "scope_files": [ "Appraisals", "cancancan.gemspec" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `gemfiles/` needed for: A...
[ { "subtask_id": "s1", "scope_files": [ "Appraisals", "cancancan.gemspec" ], "solution_diff": "diff --git a/Appraisals b/Appraisals\nindex 383d04c2..43584ed9 100644\n--- a/Appraisals\n+++ b/Appraisals\n@@ -27,7 +27,7 @@ appraise 'activerecord_5.0.2' do\n \n gemfile.platforms :ruby, :msw...
[ { "subtask_id": "s4", "comment": "I'm not a fan of this syntax. I prefer the old-style `if...else` block. Nothing really important but just to let you know ;)", "revised_diff": "diff --git a/lib/cancan/conditions_matcher.rb b/lib/cancan/conditions_matcher.rb\nindex 9c5fee15..3e7d2e73 100644\n--- a/lib/c...
diff --git a/Appraisals b/Appraisals index 383d04c2..43584ed9 100644 --- a/Appraisals +++ b/Appraisals @@ -27,7 +27,7 @@ appraise 'activerecord_5.0.2' do gemfile.platforms :ruby, :mswin, :mingw do gem 'sqlite3' - gem 'pg', '~> 0.21' + gem 'pg', '~> 0.18' end end diff --git a/cancancan.gemspec b/ca...
7
14
CanCanCommunity/cancancan#823
CanCanCommunity/cancancan
823
bd7158cb9f98ea581095b4149dc99f76fd9e696b
23d689fc2b61bd7194eff9d0fd1cebe6406d8345
Add Pennylane to sponsors > $100 a month > [...] > We will publish your logo in the README of the project, within the "Sponsors" section. We've been sponsoring this repo for a couple of months now. Here's our logo.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Add Pennylane to sponsors", "scope_files": [ "README.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `logo/` needed for: Add Pennylane to sponsors", "scope_files": [ "logo...
[ { "subtask_id": "s1", "scope_files": [ "README.md" ], "solution_diff": "diff --git a/README.md b/README.md\nindex 04fa2b68..a1a72ece 100644\n--- a/README.md\n+++ b/README.md\n@@ -26,6 +26,12 @@ of models automatically and reduce duplicated code.\n \n ## Our sponsors\n <br/>\n+<a href=\"https:/...
[]
diff --git a/README.md b/README.md index 04fa2b68..a1a72ece 100644 --- a/README.md +++ b/README.md @@ -26,6 +26,12 @@ of models automatically and reduce duplicated code. ## Our sponsors <br/> +<a href="https://www.pennylane.com/" target="_blank"> + <img src="./logo/pennylane.svg" alt="Pennylane" height="50"/> +</a...
2
2
CanCanCommunity/cancancan#722
CanCanCommunity/cancancan
722
2957182474e84e79fd73b60aef05889944ece520
5c8883f92293e7afe468cb41aa2d687713698665
New documentation A whole refactoring of the current documentation.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: New documentation", "scope_files": [ "README.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `docs/` needed for: New documentation", "scope_files": [ "docs/Ability-Precede...
[ { "subtask_id": "s1", "scope_files": [ "README.md" ], "solution_diff": "diff --git a/README.md b/README.md\nindex bd5bf3ffb..526740022 100644\n--- a/README.md\n+++ b/README.md\n@@ -6,7 +6,7 @@\n [![Github Actions badge](https://github.com/CanCanCommunity/cancancan/actions/workflows/test.yml/ba...
[ { "subtask_id": "s3", "comment": "Hi @coorasse meanwhile this URL is outdated, should probably be changed to:\r\nhttps://github.com/CanCanCommunity/cancancan/blob/develop/docs/define_check_abilities.md", "revised_diff": "diff --git a/lib/generators/cancan/ability/templates/ability.rb b/lib/generators/ca...
diff --git a/README.md b/README.md index bd5bf3ffb..526740022 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ [![Github Actions badge](https://github.com/CanCanCommunity/cancancan/actions/workflows/test.yml/badge.svg)](https://github.com/CanCanCommunity/cancancan/actions/workflows/test.yml/badge.svg) [![Code C...
4
59
CanCanCommunity/cancancan#814
CanCanCommunity/cancancan
814
7c99c593dd55127db16b0920167814a296c38e0d
dbfbd847e78fc315e5fc3da74e05f4ec84570ea6
add support for polymorphic associations in active record This PR attempts to add support for polymorphic associations in Active Record. It addresses this issue: https://github.com/CanCanCommunity/cancancan/issues/793 The solution works for the most part but there are some difficulties with making it work correctly...
[ { "subtask_id": "s1", "goal": "Implement the changes under `lib/cancan/` needed for: add support for polymorphic associations in active record", "scope_files": [ "lib/cancan/conditions_matcher.rb" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `lib/cancan/model_ada...
[ { "subtask_id": "s1", "scope_files": [ "lib/cancan/conditions_matcher.rb" ], "solution_diff": "diff --git a/lib/cancan/conditions_matcher.rb b/lib/cancan/conditions_matcher.rb\nindex 009c3f6a..6c43a7e4 100644\n--- a/lib/cancan/conditions_matcher.rb\n+++ b/lib/cancan/conditions_matcher.rb\n@@ -...
[]
diff --git a/lib/cancan/conditions_matcher.rb b/lib/cancan/conditions_matcher.rb index 009c3f6a..6c43a7e4 100644 --- a/lib/cancan/conditions_matcher.rb +++ b/lib/cancan/conditions_matcher.rb @@ -39,11 +39,13 @@ def matches_non_block_conditions(subject) def nested_subject_matches_conditions?(subject_hash) pa...
3
4
CanCanCommunity/cancancan#594
CanCanCommunity/cancancan
594
8cc9d02111bf44ef4179f92b02085b50d08cfcea
0610ee3308d2ae6c7a84d5cb7bce2b30b63dd1e1
Add support to translate action This PR allows to translate an action's name in unauthorized message using ActiveSupport I18n.
[ { "subtask_id": "s1", "goal": "Implement the changes under `lib/cancan/` needed for: Add support to translate action", "scope_files": [ "lib/cancan/unauthorized_message_resolver.rb" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `spec/cancan/` needed for: Add suppo...
[ { "subtask_id": "s1", "scope_files": [ "lib/cancan/unauthorized_message_resolver.rb" ], "solution_diff": "diff --git a/lib/cancan/unauthorized_message_resolver.rb b/lib/cancan/unauthorized_message_resolver.rb\nindex 7dfe6cf9..678772e5 100644\n--- a/lib/cancan/unauthorized_message_resolver.rb\n...
[]
diff --git a/lib/cancan/unauthorized_message_resolver.rb b/lib/cancan/unauthorized_message_resolver.rb index 7dfe6cf9..678772e5 100644 --- a/lib/cancan/unauthorized_message_resolver.rb +++ b/lib/cancan/unauthorized_message_resolver.rb @@ -4,7 +4,8 @@ module CanCan module UnauthorizedMessageResolver def unauthor...
2
2