task_id
stringlengths
10
58
repo
stringclasses
854 values
pr_number
int32
1
321k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
task
stringlengths
2
105k
plan
listlengths
1
100
subagents
listlengths
1
100
revisions
listlengths
0
100
final_diff
stringlengths
256
202M
num_subtasks
int32
1
100
num_changed_files
int32
2
100
ChrisPritchard/FSH#13
ChrisPritchard/FSH
13
47ded51ea134efc9ba914f3a128c9ada7a266118
02f71b48eae5be1e2d46c5251edc109df23c8a22
Terminal fixes Not resolved entirely, but merging for now
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Terminal fixes", "scope_files": [ "README.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/` needed for: Terminal fixes", "scope_files": [ "src/Common.fs", "src/...
[ { "subtask_id": "s1", "scope_files": [ "README.md" ], "solution_diff": "diff --git a/README.md b/README.md\nindex fa205e6..6b65b74 100644\n--- a/README.md\n+++ b/README.md\n@@ -23,7 +23,9 @@ For something more advanced, you could implement a simple 'grep' command (grep i\n \t(let grep (s:strin...
[]
diff --git a/README.md b/README.md index fa205e6..6b65b74 100644 --- a/README.md +++ b/README.md @@ -23,7 +23,9 @@ For something more advanced, you could implement a simple 'grep' command (grep i (let grep (s:string) arr = arr |> Array.filter (fun line -> line.Contains(s))) -(**Note** that shift+enter will go t...
2
8
ChromeDevTools/chrome-devtools-mcp#2200
ChromeDevTools/chrome-devtools-mcp
2,200
228cf3936ad99d9e0c09b43d77fbbac8712f2357
bc5e51c6a0319818fbbe0939d42a92e6d334908d
fix: Reset toolGroups before gathering toolGroups `getToolGroups` can be called multiple times. We want to reset the `window.__dtmcp.toolGroups` array each time to prevent duplications.
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/` needed for: fix: Reset toolGroups before gathering toolGroups", "scope_files": [ "src/McpResponse.ts" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `tests/tools/` needed for: fix: Reset toolGroups b...
[ { "subtask_id": "s1", "scope_files": [ "src/McpResponse.ts" ], "solution_diff": "diff --git a/src/McpResponse.ts b/src/McpResponse.ts\nindex d0de129a8..a86cf69b3 100644\n--- a/src/McpResponse.ts\n+++ b/src/McpResponse.ts\n@@ -113,6 +113,9 @@ async function getToolGroups(page: McpPage): Promise...
[]
diff --git a/src/McpResponse.ts b/src/McpResponse.ts index d0de129a8..a86cf69b3 100644 --- a/src/McpResponse.ts +++ b/src/McpResponse.ts @@ -113,6 +113,9 @@ async function getToolGroups(page: McpPage): Promise<ToolGroups> { } const toolGroups = await page.pptrPage.evaluate(() => { + if (window.__dtmcp) { + ...
2
2
ChromeDevTools/chrome-devtools-mcp#2184
ChromeDevTools/chrome-devtools-mcp
2,184
f90f863d4b9d643ab880c9dc8cdd78b6c88ae38d
6bc44969ac68224c9ab2f35f1ed1feb99ab141ab
chore(deps-dev): bump chrome-devtools-frontend from 1.0.1638082 to 1.0.1641723 in the bundled-devtools group Bumps the bundled-devtools group with 1 update: [chrome-devtools-frontend](https://github.com/ChromeDevTools/devtools-frontend). Updates `chrome-devtools-frontend` from 1.0.1638082 to 1.0.1641723 <details> <su...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: chore(deps-dev): bump chrome-devtools-frontend from 1.0.1638082 to 1.0.1641723 in the bundled-devtools group", "scope_files": [ "package-lock.json", "package.json" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex 8a8433012..55723ae9c 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -28,7 +28,7 @@\n \"@types/yargs\": \"^17.0.3...
[]
diff --git a/package-lock.json b/package-lock.json index 8a8433012..55723ae9c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -28,7 +28,7 @@ "@types/yargs": "^17.0.33", "@typescript-eslint/eslint-plugin": "^8.43.0", "@typescript-eslint/parser": "^8.43.0", - "chrome-devtools-f...
1
2
ChromeDevTools/chrome-devtools-mcp#2185
ChromeDevTools/chrome-devtools-mcp
2,185
f90f863d4b9d643ab880c9dc8cdd78b6c88ae38d
44290f61a53babe46d380ba4e79907067b2af6db
chore(deps): bump actions/checkout from 6.0.2 to 6.0.3 in the all group Bumps the all group with 1 update: [actions/checkout](https://github.com/actions/checkout). Updates `actions/checkout` from 6.0.2 to 6.0.3 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: chore(deps): bump actions/checkout from 6.0.2 to 6.0.3 in the all group", "scope_files": [ ".github/workflows/pre-release.yml", ".github/workflows/presubmit.yml", ".github/workflows/publish-to-n...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/pre-release.yml", ".github/workflows/presubmit.yml", ".github/workflows/publish-to-npm-on-tag.yml", ".github/workflows/run-tests.yml" ], "solution_diff": "diff --git a/.github/workflows/pre-release.yml b/.github/workfl...
[]
diff --git a/.github/workflows/pre-release.yml b/.github/workflows/pre-release.yml index e0b680d00..1668e93dd 100644 --- a/.github/workflows/pre-release.yml +++ b/.github/workflows/pre-release.yml @@ -14,7 +14,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out repository - uses: actions/...
1
4
ChromeDevTools/chrome-devtools-mcp#2186
ChromeDevTools/chrome-devtools-mcp
2,186
02b4492ca605755f67f016ee1de98aa1f506168c
6efd1e0d6cde680355d4bca30b42e7889a4141ce
chore: install HostBindingAdapter This PR introduces the HostBindingAdapter to utilize the functions usually available to DevTools. Additionally I moved all the DevTools related files under a `devtools` directory to better separate the extractor logic. The patch scripts for DevTools were moved under a function to re...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/` needed for: chore: install HostBindingAdapter", "scope_files": [ "src/McpContext.ts", "src/PageCollector.ts" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/devtools/` needed for: chore: in...
[ { "subtask_id": "s1", "scope_files": [ "src/McpContext.ts", "src/PageCollector.ts" ], "solution_diff": "diff --git a/src/McpContext.ts b/src/McpContext.ts\nindex 4346070d2..a1f80f33f 100644\n--- a/src/McpContext.ts\n+++ b/src/McpContext.ts\n@@ -10,8 +10,11 @@ import os from 'node:os';\n ...
[ { "subtask_id": "s2", "comment": "TODO revett his.", "revised_diff": "diff --git a/src/DevtoolsUtils.ts b/src/devtools/DevtoolsUtils.ts\nsimilarity index 84%\nrename from src/DevtoolsUtils.ts\nrename to src/devtools/DevtoolsUtils.ts\nindex c09a1d87d..5f130a153 100644\n--- a/src/DevtoolsUtils.ts\n+++ b/s...
diff --git a/src/McpContext.ts b/src/McpContext.ts index 4346070d2..a1f80f33f 100644 --- a/src/McpContext.ts +++ b/src/McpContext.ts @@ -10,8 +10,11 @@ import os from 'node:os'; import path from 'node:path'; import {fileURLToPath, pathToFileURL} from 'node:url'; -import type {TargetUniverse} from './DevtoolsUtils.j...
7
10
ChromeDevTools/chrome-devtools-mcp#2187
ChromeDevTools/chrome-devtools-mcp
2,187
29e389848fd0cae1116620d44fbce508b4404137
4dc723a44c2aecfcf1e79ad59e82ae36dfbe8b4e
feat: Add retaining paths MCP tool This PR adds the `get_heapsnapshot_retaining_paths` MCP tool. This can be used to find the paths from the target object to the GC roots which keep that object alive.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: feat: Add retaining paths MCP tool", "scope_files": [ "README.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `docs/` needed for: feat: Add retaining paths MCP tool", "scope_fil...
[ { "subtask_id": "s1", "scope_files": [ "README.md" ], "solution_diff": "diff --git a/README.md b/README.md\nindex ea3f4e962..d92c80d77 100644\n--- a/README.md\n+++ b/README.md\n@@ -514,12 +514,13 @@ If you run into any issues, checkout our [troubleshooting guide](./docs/troubles\n - [`take_s...
[ { "subtask_id": "s3", "comment": "I am curious if it make sense to provide a simple explanation of structure.\nOnce we have a proper benchmarks I think this would be worth trying.", "revised_diff": "diff --git a/src/McpResponse.ts b/src/McpResponse.ts\nindex 9dfea8be2..00baad2ac 100644\n--- a/src/McpRes...
diff --git a/README.md b/README.md index ea3f4e962..d92c80d77 100644 --- a/README.md +++ b/README.md @@ -514,12 +514,13 @@ If you run into any issues, checkout our [troubleshooting guide](./docs/troubles - [`take_snapshot`](docs/tool-reference.md#take_snapshot) - [`screencast_start`](docs/tool-reference.md#screen...
9
13
ChromeDevTools/chrome-devtools-mcp#1915
ChromeDevTools/chrome-devtools-mcp
1,915
02b4492ca605755f67f016ee1de98aa1f506168c
6e475da087fe4cbc56faee327382bfb079476ee8
feat: implement extension service worker logs This PR introduces the possiblity to collect console messages from service workers.
[ { "subtask_id": "s1", "goal": "Implement the changes under `docs/` needed for: feat: implement extension service worker logs", "scope_files": [ "docs/tool-reference.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/` needed for: feat: implement extension serv...
[ { "subtask_id": "s1", "scope_files": [ "docs/tool-reference.md" ], "solution_diff": "diff --git a/docs/tool-reference.md b/docs/tool-reference.md\nindex 91380a00b..f2a002f5f 100644\n--- a/docs/tool-reference.md\n+++ b/docs/tool-reference.md\n@@ -394,6 +394,7 @@ so returned values have to be JS...
[ { "subtask_id": "s2", "comment": "I think we need to close the session in all cases.", "revised_diff": "diff --git a/src/ServiceWorkerCollector.ts b/src/ServiceWorkerCollector.ts\nnew file mode 100644\nindex 000000000..562ffeb35\n--- /dev/null\n+++ b/src/ServiceWorkerCollector.ts\n@@ -0,0 +1,227 @@\n+/*...
diff --git a/docs/tool-reference.md b/docs/tool-reference.md index 91380a00b..f2a002f5f 100644 --- a/docs/tool-reference.md +++ b/docs/tool-reference.md @@ -394,6 +394,7 @@ so returned values have to be JSON-serializable. - **includePreservedMessages** (boolean) _(optional)_: Set to true to return the preserved messag...
9
18
ChromeDevTools/chrome-devtools-mcp#2153
ChromeDevTools/chrome-devtools-mcp
2,153
8b458f7ad194b52305b831d5bfd6c0b6f5a53376
e93f2d63b36bf459ecdfae10e62ca6fe7e975cf4
chore(main): release chrome-devtools-mcp 1.2.0 :robot: I have created a release *beep* *boop* --- ## [1.2.0](https://github.com/ChromeDevTools/chrome-devtools-mcp/compare/chrome-devtools-mcp-v1.1.1...chrome-devtools-mcp-v1.2.0) (2026-06-08) ### 🎉 Features * add experimental TOON support for structured content ou...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: chore(main): release chrome-devtools-mcp 1.2.0", "scope_files": [ ".release-please-manifest.json", "CHANGELOG.md", "gemini-extension.json", "package-lock.json", "package.json", "server.js...
[ { "subtask_id": "s1", "scope_files": [ ".release-please-manifest.json", "CHANGELOG.md", "gemini-extension.json", "package-lock.json", "package.json", "server.json" ], "solution_diff": "diff --git a/.release-please-manifest.json b/.release-please-manifest.json\nind...
[]
diff --git a/.claude-plugin/marketplace.json b/.claude-plugin/marketplace.json index 8d2172818..d7e4a7147 100644 --- a/.claude-plugin/marketplace.json +++ b/.claude-plugin/marketplace.json @@ -1,6 +1,6 @@ { "name": "chrome-devtools-plugins", - "version": "1.1.1", + "version": "1.2.0", "description": "Bundled p...
5
11
ChromeDevTools/chrome-devtools-mcp#2194
ChromeDevTools/chrome-devtools-mcp
2,194
a97c642d43d19fc5198038a7544ff41528ddc316
c4f528f3b5116ae038c0ec5b797cfc8d1ca47b2e
chore: expose loadResouce HostBinding This makes sure that if any resource that is loaded via the HostBinding will be correctly checked agains the roots object.
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/` needed for: chore: expose loadResouce HostBinding", "scope_files": [ "src/McpContext.ts" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/devtools/` needed for: chore: expose loadResouce HostBindi...
[ { "subtask_id": "s1", "scope_files": [ "src/McpContext.ts" ], "solution_diff": "diff --git a/src/McpContext.ts b/src/McpContext.ts\nindex 061e1e5ad..756ad0071 100644\n--- a/src/McpContext.ts\n+++ b/src/McpContext.ts\n@@ -113,7 +113,11 @@ export class McpContext implements Context {\n optio...
[]
diff --git a/src/McpContext.ts b/src/McpContext.ts index 061e1e5ad..756ad0071 100644 --- a/src/McpContext.ts +++ b/src/McpContext.ts @@ -113,7 +113,11 @@ export class McpContext implements Context { options: McpContextOptions, locatorClass: typeof Locator, ) { - overrideDevToolsGlobals(); + overrideD...
3
5
ChromeDevTools/chrome-devtools-mcp#2193
ChromeDevTools/chrome-devtools-mcp
2,193
834b259eb211a98b4866a70f44b09894099e9941
14c9731d6bd23d54e47d1fefea0af3557a507aaa
feat: Use HeapSnapshotProxy.nodeIndexById
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: feat: Use HeapSnapshotProxy.nodeIndexById", "scope_files": [ "package-lock.json", "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/` needed for: feat: Use HeapS...
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex 4f4c6cdd5..0fcb6418d 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -29,7 +29,7 @@\n \"@types/yargs\": \"^17.0.3...
[]
diff --git a/package-lock.json b/package-lock.json index 4f4c6cdd5..0fcb6418d 100644 --- a/package-lock.json +++ b/package-lock.json @@ -29,7 +29,7 @@ "@types/yargs": "^17.0.33", "@typescript-eslint/eslint-plugin": "^8.43.0", "@typescript-eslint/parser": "^8.43.0", - "chrome-devtools-f...
2
3
ChromeDevTools/chrome-devtools-mcp#2180
ChromeDevTools/chrome-devtools-mcp
2,180
6bd8c91678035b5aa18ee40f72e1f630aa528837
51f8260561b546171934f0c31274eb6557700819
feat: Add the get_heapsnapshot_edges MCP tool This PR adds the get_heapsnapshot_edges MCP tool. Agents can use it to look at the outgoing edges for a specifc object.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: feat: Add the get_heapsnapshot_edges MCP tool", "scope_files": [ "README.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `docs/` needed for: feat: Add the get_heapsnapshot_edges MCP...
[ { "subtask_id": "s1", "scope_files": [ "README.md" ], "solution_diff": "diff --git a/README.md b/README.md\nindex d92c80d77..b155b1629 100644\n--- a/README.md\n+++ b/README.md\n@@ -514,11 +514,12 @@ If you run into any issues, checkout our [troubleshooting guide](./docs/troubles\n - [`take_s...
[]
diff --git a/README.md b/README.md index d92c80d77..b155b1629 100644 --- a/README.md +++ b/README.md @@ -514,11 +514,12 @@ If you run into any issues, checkout our [troubleshooting guide](./docs/troubles - [`take_snapshot`](docs/tool-reference.md#take_snapshot) - [`screencast_start`](docs/tool-reference.md#screen...
7
10
ChromeDevTools/chrome-devtools-mcp#2196
ChromeDevTools/chrome-devtools-mcp
2,196
6bd8c91678035b5aa18ee40f72e1f630aa528837
b745b1788ccc90a9d64defe4c0657a4264fde846
chore(deps-dev): bump the dev-dependencies group across 1 directory with 9 updates Bumps the dev-dependencies group with 9 updates in the / directory: | Package | From | To | | --- | --- | --- | | [@google/genai](https://github.com/googleapis/js-genai) | `2.7.0` | `2.8.0` | | [@toon-format/toon](https://github.com/to...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: chore(deps-dev): bump the dev-dependencies group across 1 directory with 9 updates", "scope_files": [ "package-lock.json", "package.json" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex 0fcb6418d..0f606271a 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -39,7 +39,7 @@\n \"lighthouse\": \"13.3.0\",...
[]
diff --git a/package-lock.json b/package-lock.json index 0fcb6418d..0f606271a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -39,7 +39,7 @@ "lighthouse": "13.3.0", "prettier": "^3.6.2", "puppeteer": "25.1.0", - "rollup": "4.61.0", + "rollup": "4.61.1", "rollu...
1
2
ChromeDevTools/chrome-devtools-mcp#2174
ChromeDevTools/chrome-devtools-mcp
2,174
dfc111502fc09ef0a8b13be3640550c908b02788
6e02498039db53633d8cfb46146f319d59af76f2
feat: Adds close_heapsnapshot MCP tool This commit adds the close_heapsnapshot MCP tool such that the coding agent can close heap snapshots again.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: feat: Adds close_heapsnapshot MCP tool", "scope_files": [ "README.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `docs/` needed for: feat: Adds close_heapsnapshot MCP tool", "s...
[ { "subtask_id": "s1", "scope_files": [ "README.md" ], "solution_diff": "diff --git a/README.md b/README.md\nindex 1ffbafa00..b5291249e 100644\n--- a/README.md\n+++ b/README.md\n@@ -514,8 +514,9 @@ If you run into any issues, checkout our [troubleshooting guide](./docs/troubles\n - [`take_sna...
[ { "subtask_id": "s6", "comment": "I am not really sure about this. I guess depending on how one interprets that flag, it might be considered `true` as well.", "revised_diff": "diff --git a/src/tools/memory.ts b/src/tools/memory.ts\nindex e9cd00215..792a05996 100644\n--- a/src/tools/memory.ts\n+++ b/src/...
diff --git a/README.md b/README.md index 1ffbafa00..b5291249e 100644 --- a/README.md +++ b/README.md @@ -514,8 +514,9 @@ If you run into any issues, checkout our [troubleshooting guide](./docs/troubles - [`take_snapshot`](docs/tool-reference.md#take_snapshot) - [`screencast_start`](docs/tool-reference.md#screenca...
7
9
ChromeDevTools/chrome-devtools-mcp#2169
ChromeDevTools/chrome-devtools-mcp
2,169
8713b93b41ce301acf0ebc555c9a1b25d29bc526
dd2c12b2593009f5fb6d21004279326fc7b22724
feat: memory debugging tools Updates the flag for the memory tooling to remove the experimental bit (keep alias for backwards compatibility). And updates the SKILLs to reflected the update names and point to the available tools. Q: Should it be called `take_heapsnapshot` or `take_heap_snapshot`?
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: feat: memory debugging tools", "scope_files": [ "README.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `docs/` needed for: feat: memory debugging tools", "scope_files": [ ...
[ { "subtask_id": "s1", "scope_files": [ "README.md" ], "solution_diff": "diff --git a/README.md b/README.md\nindex b5291249e..cfe7dd3ea 100644\n--- a/README.md\n+++ b/README.md\n@@ -609,8 +609,8 @@ The Chrome DevTools MCP server supports the following configuration option:\n Whether to enable...
[]
diff --git a/README.md b/README.md index b5291249e..cfe7dd3ea 100644 --- a/README.md +++ b/README.md @@ -609,8 +609,8 @@ The Chrome DevTools MCP server supports the following configuration option: Whether to enable coordinate-based tools such as click_at(x,y). Usually requires a computer-use model able to produce ac...
10
11
ChromeDevTools/chrome-devtools-mcp#2136
ChromeDevTools/chrome-devtools-mcp
2,136
176eb695137d9c46a61e2d4d5571880c5145cf46
11c29b2640b7cfe538d5ca0de95f2e5900897139
refactor: remove redundant validatePath calls We should primarily validate in the tool calls before we start invoking tool handlers. These paths are already validated by tools.
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/` needed for: refactor: remove redundant validatePath calls", "scope_files": [ "src/McpContext.ts" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/tools/` needed for: refactor: remove redundant val...
[ { "subtask_id": "s1", "scope_files": [ "src/McpContext.ts" ], "solution_diff": "diff --git a/src/McpContext.ts b/src/McpContext.ts\nindex 2a4e1da9d..fe288c6cc 100644\n--- a/src/McpContext.ts\n+++ b/src/McpContext.ts\n@@ -830,7 +830,6 @@ export class McpContext implements Context {\n }\n \n ...
[]
diff --git a/src/McpContext.ts b/src/McpContext.ts index 2a4e1da9d..fe288c6cc 100644 --- a/src/McpContext.ts +++ b/src/McpContext.ts @@ -830,7 +830,6 @@ export class McpContext implements Context { } async installExtension(extensionPath: string): Promise<string> { - await this.validatePath(extensionPath); ...
2
2
ChromeDevTools/chrome-devtools-mcp#2117
ChromeDevTools/chrome-devtools-mcp
2,117
2eab50938093e848ca9786f2ce0c5bf371e63619
b2311a698056f1df010003a006aec78c39e6fba4
Server process does not exit on stdin EOF after a page has been opened ### Description of the bug `chrome-devtools-mcp` does not exit when its stdin is closed if a `navigate_page` (or any tool that opens a Chrome instance) has been issued during the session. The MCP protocol does not define a `shutdown` RPC and conve...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/` needed for: Server process does not exit on stdin EOF after a page has been opened", "scope_files": [ "src/browser.ts" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/bin/` needed for: Server pro...
[ { "subtask_id": "s1", "scope_files": [ "src/browser.ts" ], "solution_diff": "diff --git a/src/browser.ts b/src/browser.ts\nindex 7deea75b4..20f254865 100644\n--- a/src/browser.ts\n+++ b/src/browser.ts\n@@ -19,6 +19,7 @@ import type {\n import {puppeteer} from './third_party/index.js';\n \n let...
[ { "subtask_id": "s2", "comment": "how does this work together with signal handling installed by Puppeteer for launched browsers?", "revised_diff": "diff --git a/src/bin/chrome-devtools-mcp-main.ts b/src/bin/chrome-devtools-mcp-main.ts\nindex 1d03c089b..25fb69b19 100644\n--- a/src/bin/chrome-devtools-mcp...
diff --git a/src/bin/chrome-devtools-mcp-main.ts b/src/bin/chrome-devtools-mcp-main.ts index 1d03c089b..25fb69b19 100644 --- a/src/bin/chrome-devtools-mcp-main.ts +++ b/src/bin/chrome-devtools-mcp-main.ts @@ -8,6 +8,7 @@ import '../polyfill.js'; import process from 'node:process'; +import {closeBrowser} from '../b...
3
3
ChromeDevTools/chrome-devtools-mcp#2086
ChromeDevTools/chrome-devtools-mcp
2,086
329fbf1ac9b4cbec808c64312d3fc50aab1a80b8
4c7f393d97ef6c9f45818522d16ce3517b7dbd97
Impossible to start two Chrome instances from DevTools for agents MCP server when using Claude Code CLI ### Description of the bug It looks like it's not possible to start multiple sessions using DevTools for agents MCP server with Claude Code CLI. ### Reproduction - Open Claude Code CLI - Insert prompt asking to ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Impossible to start two Chrome instances from DevTools for agents MCP server when using Claude Code CLI", "scope_files": [ ".release-please-manifest.json", "CHANGELOG.md", "gemini-extension.json", "p...
[ { "subtask_id": "s1", "scope_files": [ ".release-please-manifest.json", "CHANGELOG.md", "gemini-extension.json", "package-lock.json", "package.json", "server.json" ], "solution_diff": "diff --git a/.release-please-manifest.json b/.release-please-manifest.json\nind...
[]
diff --git a/.claude-plugin/marketplace.json b/.claude-plugin/marketplace.json index 1cf2c12dd..ec77f2740 100644 --- a/.claude-plugin/marketplace.json +++ b/.claude-plugin/marketplace.json @@ -1,6 +1,6 @@ { "name": "chrome-devtools-plugins", - "version": "1.0.1", + "version": "1.1.0", "description": "Bundled p...
5
11
ChromeDevTools/chrome-devtools-mcp#2142
ChromeDevTools/chrome-devtools-mcp
2,142
0089ebdd37a6b16e52820a3fcb4af133214754a0
864ee64bfd475a4ebefba1ecc2cfdff6fb0bdd45
fix(cli): have pageId as first argument Refs #1777 This change makes pageId as the first argument for CLI if experimentalPageIdRouting flag is enabled
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/` needed for: fix(cli): have pageId as first argument", "scope_files": [ "src/ToolHandler.ts" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/tools/` needed for: fix(cli): have pageId as first argu...
[ { "subtask_id": "s1", "scope_files": [ "src/ToolHandler.ts" ], "solution_diff": "diff --git a/src/ToolHandler.ts b/src/ToolHandler.ts\nindex c9bf56d9f..80950c97b 100644\n--- a/src/ToolHandler.ts\n+++ b/src/ToolHandler.ts\n@@ -163,7 +163,7 @@ export class ToolHandler {\n tool.pageScoped &...
[]
diff --git a/src/ToolHandler.ts b/src/ToolHandler.ts index c9bf56d9f..80950c97b 100644 --- a/src/ToolHandler.ts +++ b/src/ToolHandler.ts @@ -163,7 +163,7 @@ export class ToolHandler { tool.pageScoped && serverArgs.experimentalPageIdRouting && !serverArgs.slim - ? {...tool.schema, ...pageIdSc...
2
2
ChromeDevTools/chrome-devtools-mcp#2135
ChromeDevTools/chrome-devtools-mcp
2,135
2eab50938093e848ca9786f2ce0c5bf371e63619
c5c20b5a6bece6c8042259f6181995d63668a9b3
Releases should update the chrome-devtools-mcp version in plugins Currently, all of our plugins use the latest MCP server by default https://github.com/ChromeDevTools/chrome-devtools-mcp/blob/main/.cursor-plugin/plugin.json#L14 we should update the release-please process to generate the version of the chrome-devtools...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Releases should update the chrome-devtools-mcp version in plugins", "scope_files": [ "gemini-extension.json", "release-please-config.json" ] }, { "subtask_id": "s2", "goal": "Implement the change...
[ { "subtask_id": "s1", "scope_files": [ "gemini-extension.json", "release-please-config.json" ], "solution_diff": "diff --git a/gemini-extension.json b/gemini-extension.json\nindex 10c45cb9d..39dfeab6a 100644\n--- a/gemini-extension.json\n+++ b/gemini-extension.json\n@@ -1,10 +1,10 @@\n {...
[ { "subtask_id": "s1", "comment": "should this be `args[0]`?", "revised_diff": "diff --git a/release-please-config.json b/release-please-config.json\nindex 25e06142d..5abfdd2af 100644\n--- a/release-please-config.json\n+++ b/release-please-config.json\n@@ -40,15 +40,40 @@\n \"path\": \".claude-...
diff --git a/.claude-plugin/plugin.json b/.claude-plugin/plugin.json index 08f3e3dda..f6d3aa57f 100644 --- a/.claude-plugin/plugin.json +++ b/.claude-plugin/plugin.json @@ -6,7 +6,7 @@ "chrome-devtools": { "command": "npx", "args": [ - "chrome-devtools-mcp@latest" + "chrome-devtools-mcp...
4
5
ChromeDevTools/chrome-devtools-mcp#2146
ChromeDevTools/chrome-devtools-mcp
2,146
4c886a1c8bf71cdf94beb278c1a0a77e529f5762
84c18162039d1e2ac9798b61cc5911a03a28b95b
test: drop node20 code in tests
[ { "subtask_id": "s1", "goal": "Implement the changes under `scripts/` needed for: test: drop node20 code in tests", "scope_files": [ "scripts/test.mjs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `tests/` needed for: test: drop node20 code in tests", "scope_...
[ { "subtask_id": "s1", "scope_files": [ "scripts/test.mjs" ], "solution_diff": "diff --git a/scripts/test.mjs b/scripts/test.mjs\nindex d545f392b..0d427847f 100644\n--- a/scripts/test.mjs\n+++ b/scripts/test.mjs\n@@ -38,11 +38,7 @@ if (userArgs.length > 0) {\n files.push(testPath);\n }\n ...
[]
diff --git a/scripts/test.mjs b/scripts/test.mjs index d545f392b..0d427847f 100644 --- a/scripts/test.mjs +++ b/scripts/test.mjs @@ -38,11 +38,7 @@ if (userArgs.length > 0) { files.push(testPath); } } else { - const isNode20 = process.version.startsWith('v20.'); if (flags.includes('--test-only')) { - if...
6
17
ChromeDevTools/chrome-devtools-mcp#2148
ChromeDevTools/chrome-devtools-mcp
2,148
af17797f3b87b5d2123e47950d36cb01673abe38
7d9edb27b2553cb9080d6848a87c05abedfd8c4f
chore(main): release chrome-devtools-mcp 1.1.1 :robot: I have created a release *beep* *boop* --- ## [1.1.1](https://github.com/ChromeDevTools/chrome-devtools-mcp/compare/chrome-devtools-mcp-v1.1.0...chrome-devtools-mcp-v1.1.1) (2026-05-27) ### 🛠️ Fixes * **cli:** have pageId as first argument ([#2142](https://g...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: chore(main): release chrome-devtools-mcp 1.1.1", "scope_files": [ ".release-please-manifest.json", "CHANGELOG.md", "gemini-extension.json", "package-lock.json", "package.json", "server.js...
[ { "subtask_id": "s1", "scope_files": [ ".release-please-manifest.json", "CHANGELOG.md", "gemini-extension.json", "package-lock.json", "package.json", "server.json" ], "solution_diff": "diff --git a/.release-please-manifest.json b/.release-please-manifest.json\nind...
[]
diff --git a/.claude-plugin/marketplace.json b/.claude-plugin/marketplace.json index ec77f2740..8d2172818 100644 --- a/.claude-plugin/marketplace.json +++ b/.claude-plugin/marketplace.json @@ -1,6 +1,6 @@ { "name": "chrome-devtools-plugins", - "version": "1.1.0", + "version": "1.1.1", "description": "Bundled p...
5
11
ChromeDevTools/chrome-devtools-mcp#2131
ChromeDevTools/chrome-devtools-mcp
2,131
7b5ec3a1b85bed929032348aeed78dd93614bbc1
64a94ea77478c758cdcc87d96620b159a02d0079
The Crux data returned is not accurate ### Description of the bug There are several points to note regarding the CruX data using `performance_start_trace`: - **It is not accurate**: there are noticeable differences compared to the CruX data returned by the [PageSpeed website.](https://pagespeed.web.dev/) Using the P...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/` needed for: The Crux data returned is not accurate", "scope_files": [ "src/McpResponse.ts" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/trace-processing/` needed for: The Crux data returned is...
[ { "subtask_id": "s1", "scope_files": [ "src/McpResponse.ts" ], "solution_diff": "diff --git a/src/McpResponse.ts b/src/McpResponse.ts\nindex 17d7a9f75..b00fba007 100644\n--- a/src/McpResponse.ts\n+++ b/src/McpResponse.ts\n@@ -209,6 +209,10 @@ export class McpResponse implements Response {\n ...
[]
diff --git a/src/McpResponse.ts b/src/McpResponse.ts index 17d7a9f75..b00fba007 100644 --- a/src/McpResponse.ts +++ b/src/McpResponse.ts @@ -209,6 +209,10 @@ export class McpResponse implements Response { #error?: Error; #attachedWaitForResult?: WaitForEventsResult; + get #deviceScope(): DevTools.CrUXManager.D...
3
3
ChromeDevTools/chrome-devtools-mcp#2152
ChromeDevTools/chrome-devtools-mcp
2,152
50cecd810b9362f6b3fd3806bcceaca0e2b9d1fb
6c455fa90f0c821bc074cff083757200ec4ebfb5
[Task]: Refactor path validation ### Task to do: Currently we call validatePath in any tool with filePath inputs. Instead, we should add a new required annotation called `filePathFields: array<string>` requiring each tool to list field paths that require validation. The validation can then be done centrally when hand...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/` needed for: [Task]: Refactor path validation", "scope_files": [ "src/ToolHandler.ts" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/tools/` needed for: [Task]: Refactor path validation", "sc...
[ { "subtask_id": "s1", "scope_files": [ "src/ToolHandler.ts" ], "solution_diff": "diff --git a/src/ToolHandler.ts b/src/ToolHandler.ts\nindex 80950c97b..01e07d2a5 100644\n--- a/src/ToolHandler.ts\n+++ b/src/ToolHandler.ts\n@@ -220,6 +220,12 @@ export class ToolHandler {\n \n response.setR...
[ { "subtask_id": "s2", "comment": "let's make it required so that it is less frequently overlooked", "revised_diff": "diff --git a/src/tools/ToolDefinition.ts b/src/tools/ToolDefinition.ts\nindex dd8cba89b..7350b2b45 100644\n--- a/src/tools/ToolDefinition.ts\n+++ b/src/tools/ToolDefinition.ts\n@@ -48,6 +...
diff --git a/src/ToolHandler.ts b/src/ToolHandler.ts index 80950c97b..01e07d2a5 100644 --- a/src/ToolHandler.ts +++ b/src/ToolHandler.ts @@ -220,6 +220,12 @@ export class ToolHandler { response.setRedactNetworkHeaders(this.serverArgs.redactNetworkHeaders); try { + if (this.tool.verifyFilesSchema)...
5
20
ChromeDevTools/chrome-devtools-mcp#2158
ChromeDevTools/chrome-devtools-mcp
2,158
2e039c09e1a273581d9b51081a0feb8a57791947
67b0f9d51aa81c1639b00e7980a71246643bc294
chore(deps-dev): bump chrome-devtools-frontend from 1.0.1635648 to 1.0.1638082 in the bundled-devtools group Bumps the bundled-devtools group with 1 update: [chrome-devtools-frontend](https://github.com/ChromeDevTools/devtools-frontend). Updates `chrome-devtools-frontend` from 1.0.1635648 to 1.0.1638082 <details> <su...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: chore(deps-dev): bump chrome-devtools-frontend from 1.0.1635648 to 1.0.1638082 in the bundled-devtools group", "scope_files": [ "package-lock.json", "package.json" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex a06a97544..505103376 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -28,7 +28,7 @@\n \"@types/yargs\": \"^17.0.3...
[]
diff --git a/package-lock.json b/package-lock.json index a06a97544..505103376 100644 --- a/package-lock.json +++ b/package-lock.json @@ -28,7 +28,7 @@ "@types/yargs": "^17.0.33", "@typescript-eslint/eslint-plugin": "^8.43.0", "@typescript-eslint/parser": "^8.43.0", - "chrome-devtools-f...
1
2
ChromeDevTools/chrome-devtools-mcp#2165
ChromeDevTools/chrome-devtools-mcp
2,165
63304ef89624f1f89a6a2aad14bbc9a7ae6dde58
26c3ddc107a51c9345a1e762fecba951d94a8dec
refactor: change type of logger This change aligns most of our logger allowing them to be omitted when needed meaning code inside the args will not be executed unconditionally - example `logger?.(JSON.stringy(X))`. Currently only changes the type, while in a follow up I will remove the `debug` package and update th...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/` needed for: refactor: change type of logger", "scope_files": [ "src/McpContext.ts", "src/McpPage.ts", "src/PageCollector.ts", "src/TextSnapshot.ts", "src/ToolHandler.ts", "src/WaitForHelper.ts", "...
[ { "subtask_id": "s1", "scope_files": [ "src/McpContext.ts", "src/McpPage.ts", "src/PageCollector.ts", "src/TextSnapshot.ts", "src/ToolHandler.ts", "src/WaitForHelper.ts", "src/browser.ts", "src/index.ts", "src/logger.ts", "src/types.ts" ], ...
[]
diff --git a/src/McpContext.ts b/src/McpContext.ts index 3855c02f4..1d15b3421 100644 --- a/src/McpContext.ts +++ b/src/McpContext.ts @@ -27,7 +27,6 @@ import { type Browser, type BrowserContext, type ConsoleMessage, - type Debugger, type HTTPRequest, type Page, type ScreenRecorder, @@ -41,6 +40,7 @@ ...
8
24
ChromeDevTools/chrome-devtools-mcp#2166
ChromeDevTools/chrome-devtools-mcp
2,166
a97c642d43d19fc5198038a7544ff41528ddc316
403465713614e9ef9875e9667437357ad7229235
Include page title in `list_pages` output ### Is your feature request related to a problem? Please describe. `list_pages` shows each page's URL but not its title, which is painful when pages share a host — e.g. several accounts of the same product, all under `app.example.com/u/0/…`, `/u/1/…`, `/u/2/…`. There's no way...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/` needed for: Include page title in `list_pages` output", "scope_files": [ "src/McpResponse.ts" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `tests/` needed for: Include page title in `list_pages` ou...
[ { "subtask_id": "s1", "scope_files": [ "src/McpResponse.ts" ], "solution_diff": "diff --git a/src/McpResponse.ts b/src/McpResponse.ts\nindex b2abf7660..d0de129a8 100644\n--- a/src/McpResponse.ts\n+++ b/src/McpResponse.ts\n@@ -759,7 +759,7 @@ export class McpResponse implements Response {\n ...
[ { "subtask_id": "s1", "comment": "Please add a character limit as requested in https://github.com/ChromeDevTools/chrome-devtools-mcp/issues/2156#issuecomment-4610053690\nIt would be good to extract this to a separate function since you'll need to do this in three places.", "revised_diff": "diff --git a/...
diff --git a/src/McpResponse.ts b/src/McpResponse.ts index b2abf7660..d0de129a8 100644 --- a/src/McpResponse.ts +++ b/src/McpResponse.ts @@ -759,7 +759,7 @@ export class McpResponse implements Response { ); } - format( + async format( toolName: string, context: McpContext, data: { @@ -777,7 +...
3
3
ChromeDevTools/chrome-devtools-mcp#2042
ChromeDevTools/chrome-devtools-mcp
2,042
29e389848fd0cae1116620d44fbce508b4404137
ea498ffa226e4a174517d0caf6914dbf3ffd9535
feat: add experimental TOON support for structured content output Adds `--experimentalToonFormat` boolean flag, controlling how structured content is formatted in text response. By default, custom shorthand format is used. With this flag, TOON format (see https://github.com/toon-format/toon) is used instead. TOON ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: feat: add experimental TOON support for structured content output", "scope_files": [ "package-lock.json", "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/` nee...
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex 55723ae9c..09fdbf3ae 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -20,6 +20,7 @@\n \"@rollup/plugin-json\": \"...
[]
diff --git a/package-lock.json b/package-lock.json index 55723ae9c..09fdbf3ae 100644 --- a/package-lock.json +++ b/package-lock.json @@ -20,6 +20,7 @@ "@rollup/plugin-json": "^6.1.0", "@rollup/plugin-node-resolve": "^16.0.3", "@stylistic/eslint-plugin": "^5.4.0", + "@toon-format/toon":...
6
8
ChromeDevTools/chrome-devtools-mcp#2037
ChromeDevTools/chrome-devtools-mcp
2,037
f90f863d4b9d643ab880c9dc8cdd78b6c88ae38d
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
feat: support allowedUrlPattern & blockedUrlPattern Options ## Support for Network Blocklists and Allowlists (`--blocked-url-pattern` & `--allowed-url-pattern` arguments) This PR adds support for CLI options to restrict network access in the browser session via URL patterns. ### Key Features & How It Works - ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: feat: support allowedUrlPattern & blockedUrlPattern Options", "scope_files": [ "README.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/` needed for: feat: support allowedUrlPat...
[ { "subtask_id": "s1", "scope_files": [ "README.md" ], "solution_diff": "diff --git a/README.md b/README.md\nindex cfe7dd3ea..ea3f4e962 100644\n--- a/README.md\n+++ b/README.md\n@@ -637,6 +637,14 @@ The Chrome DevTools MCP server supports the following configuration option:\n Additional argum...
[ { "subtask_id": "s3", "comment": "Please document CLI args in details, what will be blocked and what will not be blocked and starting from which Chrome version.", "revised_diff": "diff --git a/src/bin/chrome-devtools-mcp-cli-options.ts b/src/bin/chrome-devtools-mcp-cli-options.ts\nindex b65929e12..0cfb3...
diff --git a/README.md b/README.md index cfe7dd3ea..ea3f4e962 100644 --- a/README.md +++ b/README.md @@ -637,6 +637,14 @@ The Chrome DevTools MCP server supports the following configuration option: Additional arguments for Chrome. Only applies when Chrome is launched by chrome-devtools-mcp. - **Type:** array +-...
5
11
ChromeDevTools/chrome-devtools-mcp#2164
ChromeDevTools/chrome-devtools-mcp
2,164
63304ef89624f1f89a6a2aad14bbc9a7ae6dde58
a574d57c4618667a39ab0fca27c6728348e53f0b
chore(deps-dev): bump the dev-dependencies group across 1 directory with 4 updates Bumps the dev-dependencies group with 4 updates in the / directory: [@google/genai](https://github.com/googleapis/js-genai), [@rollup/plugin-commonjs](https://github.com/rollup/plugins/tree/HEAD/packages/commonjs), [eslint-import-resolv...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: chore(deps-dev): bump the dev-dependencies group across 1 directory with 4 updates", "scope_files": [ "package-lock.json", "package.json" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex 505103376..dfa81ca7f 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -38,7 +38,7 @@\n \"lighthouse\": \"13.3.0\",...
[]
diff --git a/package-lock.json b/package-lock.json index 505103376..dfa81ca7f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -38,7 +38,7 @@ "lighthouse": "13.3.0", "prettier": "^3.6.2", "puppeteer": "25.1.0", - "rollup": "4.60.4", + "rollup": "4.61.0", "rollu...
1
2
ChromeDevTools/chrome-devtools-mcp#2112
ChromeDevTools/chrome-devtools-mcp
2,112
57f32b0cd4afe1775b96ba35c27f25d6f0770331
e11a5d0a1481e1a65029edefaafcda64e740e7a9
chore(deps-dev): bump chrome-devtools-frontend from 1.0.1631386 to 1.0.1632065 in the bundled-devtools group Bumps the bundled-devtools group with 1 update: [chrome-devtools-frontend](https://github.com/ChromeDevTools/devtools-frontend). Updates `chrome-devtools-frontend` from 1.0.1631386 to 1.0.1632065 <details> <su...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: chore(deps-dev): bump chrome-devtools-frontend from 1.0.1631386 to 1.0.1632065 in the bundled-devtools group", "scope_files": [ "package-lock.json", "package.json" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex 2d3adfc60..96a46e700 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -28,7 +28,7 @@\n \"@types/yargs\": \"^17.0.3...
[]
diff --git a/package-lock.json b/package-lock.json index 2d3adfc60..96a46e700 100644 --- a/package-lock.json +++ b/package-lock.json @@ -28,7 +28,7 @@ "@types/yargs": "^17.0.33", "@typescript-eslint/eslint-plugin": "^8.43.0", "@typescript-eslint/parser": "^8.43.0", - "chrome-devtools-f...
1
2
ChromeDevTools/chrome-devtools-mcp#2124
ChromeDevTools/chrome-devtools-mcp
2,124
57f32b0cd4afe1775b96ba35c27f25d6f0770331
0020ad809c8192b7225ea941807782d53510a6f3
fix(cli): address pid file creation issues
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/daemon/` needed for: fix(cli): address pid file creation issues", "scope_files": [ "src/daemon/daemon.ts" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `tests/daemon/` needed for: fix(cli): address pi...
[ { "subtask_id": "s1", "scope_files": [ "src/daemon/daemon.ts" ], "solution_diff": "diff --git a/src/daemon/daemon.ts b/src/daemon/daemon.ts\nindex e6cb8bd08..6708f31f5 100644\n--- a/src/daemon/daemon.ts\n+++ b/src/daemon/daemon.ts\n@@ -6,8 +6,9 @@\n * SPDX-License-Identifier: Apache-2.0\n */...
[]
diff --git a/src/daemon/daemon.ts b/src/daemon/daemon.ts index e6cb8bd08..6708f31f5 100644 --- a/src/daemon/daemon.ts +++ b/src/daemon/daemon.ts @@ -6,8 +6,9 @@ * SPDX-License-Identifier: Apache-2.0 */ -import fs from 'node:fs'; +import fs, {constants, openSync, writeSync, closeSync} from 'node:fs'; import {crea...
2
2
ChromeDevTools/chrome-devtools-mcp#2127
ChromeDevTools/chrome-devtools-mcp
2,127
2eab50938093e848ca9786f2ce0c5bf371e63619
b68617198aacdd566015187168bff37f4dbdadf0
fix: use realpath for MCP roots validation
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/` needed for: fix: use realpath for MCP roots validation", "scope_files": [ "src/McpContext.ts" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/tools/` needed for: fix: use realpath for MCP roots v...
[ { "subtask_id": "s1", "scope_files": [ "src/McpContext.ts" ], "solution_diff": "diff --git a/src/McpContext.ts b/src/McpContext.ts\nindex f8b5f3cd8..2a4e1da9d 100644\n--- a/src/McpContext.ts\n+++ b/src/McpContext.ts\n@@ -5,6 +5,7 @@\n */\n \n import fs from 'node:fs/promises';\n+import fsProm...
[ { "subtask_id": "s1", "comment": "Could there be cases where a directory structure of 2 or more directories need to be created?\n`/existing/first_new/second_new/foo.bar`", "revised_diff": "diff --git a/src/McpContext.ts b/src/McpContext.ts\nindex f8b5f3cd8..2a4e1da9d 100644\n--- a/src/McpContext.ts\n+++...
diff --git a/src/McpContext.ts b/src/McpContext.ts index f8b5f3cd8..2a4e1da9d 100644 --- a/src/McpContext.ts +++ b/src/McpContext.ts @@ -5,6 +5,7 @@ */ import fs from 'node:fs/promises'; +import fsPromises from 'node:fs/promises'; import os from 'node:os'; import path from 'node:path'; import {fileURLToPath, pa...
5
15
ChromeDevTools/chrome-devtools-mcp#2130
ChromeDevTools/chrome-devtools-mcp
2,130
8ea5f098ef7e8d8ae4f4bbaea5291cef84b8f15f
bcb62b86580590c6508ef314b9ff7e7b7f99ddd1
chore(deps-dev): bump puppeteer from 25.0.4 to 25.1.0 in the bundled group Bumps the bundled group with 1 update: [puppeteer](https://github.com/puppeteer/puppeteer). Updates `puppeteer` from 25.0.4 to 25.1.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/puppeteer/puppetee...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: chore(deps-dev): bump puppeteer from 25.0.4 to 25.1.0 in the bundled group", "scope_files": [ "package-lock.json", "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `...
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex ebb296e8c..1ab7d8ec1 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -37,7 +37,7 @@\n \"globals\": \"^17.0.0\",\n...
[]
diff --git a/package-lock.json b/package-lock.json index ebb296e8c..1ab7d8ec1 100644 --- a/package-lock.json +++ b/package-lock.json @@ -37,7 +37,7 @@ "globals": "^17.0.0", "lighthouse": "13.3.0", "prettier": "^3.6.2", - "puppeteer": "25.0.4", + "puppeteer": "25.1.0", "...
3
4
ChromeDevTools/chrome-devtools-mcp#2129
ChromeDevTools/chrome-devtools-mcp
2,129
3ba70d350a135f5b444826f204724d08aaa9b924
44d499c2f4ce36fdca3093134ba2bbc9a0719e38
chore(deps-dev): bump chrome-devtools-frontend from 1.0.1632065 to 1.0.1635648 in the bundled-devtools group Bumps the bundled-devtools group with 1 update: [chrome-devtools-frontend](https://github.com/ChromeDevTools/devtools-frontend). Updates `chrome-devtools-frontend` from 1.0.1632065 to 1.0.1635648 <details> <su...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: chore(deps-dev): bump chrome-devtools-frontend from 1.0.1632065 to 1.0.1635648 in the bundled-devtools group", "scope_files": [ "package-lock.json", "package.json" ] }, { "subtask_id": "s2", "goa...
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex 4e64ad44f..127cb22c5 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -28,7 +28,7 @@\n \"@types/yargs\": \"^17.0.3...
[]
diff --git a/package-lock.json b/package-lock.json index 4e64ad44f..127cb22c5 100644 --- a/package-lock.json +++ b/package-lock.json @@ -28,7 +28,7 @@ "@types/yargs": "^17.0.33", "@typescript-eslint/eslint-plugin": "^8.43.0", "@typescript-eslint/parser": "^8.43.0", - "chrome-devtools-f...
2
3
ChromeDevTools/chrome-devtools-mcp#2123
ChromeDevTools/chrome-devtools-mcp
2,123
57f32b0cd4afe1775b96ba35c27f25d6f0770331
ce5332eea1a649dbcc013b7496bcc0b974677637
chore: fix two typos in issue templates ## Summary Two small typo fixes in `.github/ISSUE_TEMPLATE/`: - `02-feature.yml`: "Suggest an idea for for chrome-devtools-mcp" had a duplicate "for". - `03-task.yml`: "mainainers only" was missing the first `t`. Both strings appear on the GitHub issue picker when a user clic...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/ISSUE_TEMPLATE/` needed for: chore: fix two typos in issue templates", "scope_files": [ ".github/ISSUE_TEMPLATE/02-feature.yml", ".github/ISSUE_TEMPLATE/03-task.yml" ] } ]
[ { "subtask_id": "s1", "scope_files": [ ".github/ISSUE_TEMPLATE/02-feature.yml", ".github/ISSUE_TEMPLATE/03-task.yml" ], "solution_diff": "diff --git a/.github/ISSUE_TEMPLATE/02-feature.yml b/.github/ISSUE_TEMPLATE/02-feature.yml\nindex 784433690..0bd648bf4 100644\n--- a/.github/ISSUE_TEM...
[]
diff --git a/.github/ISSUE_TEMPLATE/02-feature.yml b/.github/ISSUE_TEMPLATE/02-feature.yml index 784433690..0bd648bf4 100644 --- a/.github/ISSUE_TEMPLATE/02-feature.yml +++ b/.github/ISSUE_TEMPLATE/02-feature.yml @@ -1,5 +1,5 @@ name: Feature -description: Suggest an idea for for chrome-devtools-mcp +description: Sugg...
1
2
ChromeDevTools/chrome-devtools-mcp#2168
ChromeDevTools/chrome-devtools-mcp
2,168
bf0574da8ce0986beb5dd2f026a2332a7e63b791
db0e80c095d1984a1b6d1ec1545aaba654bbc83a
feat: Handle multiple providers of third-party developer tools This allows a page to have multiple providers of third-party developer tools, which each respond to the `devtoolstooldiscovery` event. - Multiple `ToolGroup`s - MCP tool responses only mention third-party developer tools, if there are any. Otherwise th...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/` needed for: feat: Handle multiple providers of third-party developer tools", "scope_files": [ "src/McpPage.ts", "src/McpResponse.ts" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/tools/` ...
[ { "subtask_id": "s1", "scope_files": [ "src/McpPage.ts", "src/McpResponse.ts" ], "solution_diff": "diff --git a/src/McpPage.ts b/src/McpPage.ts\nindex 0a32c2de8..7dd2955d7 100644\n--- a/src/McpPage.ts\n+++ b/src/McpPage.ts\n@@ -14,7 +14,7 @@ import type {\n WebMCPTool,\n } from './thir...
[ { "subtask_id": "s1", "comment": "Nit: Maybe we can extract a type as I see it used very often.", "revised_diff": "diff --git a/src/McpPage.ts b/src/McpPage.ts\nindex 0a32c2de8..7dd2955d7 100644\n--- a/src/McpPage.ts\n+++ b/src/McpPage.ts\n@@ -14,7 +14,7 @@ import type {\n WebMCPTool,\n } from './thir...
diff --git a/src/McpPage.ts b/src/McpPage.ts index 0a32c2de8..7dd2955d7 100644 --- a/src/McpPage.ts +++ b/src/McpPage.ts @@ -14,7 +14,7 @@ import type { WebMCPTool, } from './third_party/index.js'; import {takeSnapshot} from './tools/snapshot.js'; -import type {ToolGroup, ToolDefinition} from './tools/thirdPartyDe...
4
7
ChromeDevTools/chrome-devtools-mcp#2096
ChromeDevTools/chrome-devtools-mcp
2,096
ce31594d6c9614c63a93cd7abddf4522a4c4a053
19451ed328b414f4e673b8ea5db7e4f723389537
fix: Fix throttling info in performance trace output This addresses #1955. Throttling information needs to be passed to the parser for the output to be correct.
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/` needed for: fix: Fix throttling info in performance trace output", "scope_files": [ "src/McpContext.ts" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/tools/` needed for: fix: Fix throttling inf...
[ { "subtask_id": "s1", "scope_files": [ "src/McpContext.ts" ], "solution_diff": "diff --git a/src/McpContext.ts b/src/McpContext.ts\nindex a77bc06bc..2916163cd 100644\n--- a/src/McpContext.ts\n+++ b/src/McpContext.ts\n@@ -481,7 +481,7 @@ export class McpContext implements Context {\n page...
[]
diff --git a/src/McpContext.ts b/src/McpContext.ts index a77bc06bc..2916163cd 100644 --- a/src/McpContext.ts +++ b/src/McpContext.ts @@ -481,7 +481,7 @@ export class McpContext implements Context { page.networkConditions, ); page.pptrPage.setDefaultNavigationTimeout( - NAVIGATION_TIMEOUT * network...
4
5
ClickHouse/ClickHouse#100479
ClickHouse/ClickHouse
100,479
bf2051399e17d9e2b620d7d2c02568ff125011a6
38d0e3535d5d16ae471b8f753284fd142a5ca3cb
Occurs error when (I)LIKE doesn't support search with-non-constant needles in constant haystack when left side is constant ### Company or project name _No response_ ### Describe what's wrong When execution query like ``` select * from sample_tables where 'foo' ilike concat('%', sample_column, '%'); ``` Occurs er...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Functions/` needed for: Occurs error when (I)LIKE doesn't support search with-non-constant needles in constant haystack when left side is constant", "scope_files": [ "src/Functions/MatchImpl.h", "src/Functions/match.cpp" ] ...
[ { "subtask_id": "s1", "scope_files": [ "src/Functions/MatchImpl.h", "src/Functions/match.cpp" ], "solution_diff": "diff --git a/src/Functions/MatchImpl.h b/src/Functions/MatchImpl.h\nindex a35e6a7f4650..26f47a3b63ec 100644\n--- a/src/Functions/MatchImpl.h\n+++ b/src/Functions/MatchImpl.h...
[ { "subtask_id": "s1", "comment": "`constantVector` no longer throws `ILLEGAL_COLUMN`, so `ErrorCodes::ILLEGAL_COLUMN` at the top of this file became unused. This is currently failing style CI (`ErrorCodes::ILLEGAL_COLUMN is defined but not used`). Please remove the unused declaration from `namespace ErrorCo...
diff --git a/src/Functions/MatchImpl.h b/src/Functions/MatchImpl.h index a35e6a7f4650..26f47a3b63ec 100644 --- a/src/Functions/MatchImpl.h +++ b/src/Functions/MatchImpl.h @@ -11,13 +11,14 @@ namespace DB { -namespace ErrorCodes +namespace impl { - extern const int ILLEGAL_COLUMN; -} -namespace impl +/// Does ...
2
6
ClickHouse/ClickHouse#105543
ClickHouse/ClickHouse
105,543
ef937ef552415585853632049b17591e0c7c37f4
41b943bafc47fe9e7b467ca712c94a6eccd9270b
`variant_throw_on_type_mismatch=false` fails for comparison functions: `try_build` only wraps `build`, not `execute` _Found via ClickGap automated review. Please close or comment if this is incorrect or needs adjustment._ _Retrospective finding from a historical scan of [PR #95811](https://github.com/ClickHouse/Click...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Functions/` needed for: `variant_throw_on_type_mismatch=false` fails for comparison functions: `try_build` only wraps `build`, not `execute`", "scope_files": [ "src/Functions/FunctionDynamicAdaptor.cpp", "src/Functions/FunctionV...
[ { "subtask_id": "s1", "scope_files": [ "src/Functions/FunctionDynamicAdaptor.cpp", "src/Functions/FunctionVariantAdaptor.cpp" ], "solution_diff": "diff --git a/src/Functions/FunctionDynamicAdaptor.cpp b/src/Functions/FunctionDynamicAdaptor.cpp\nindex 8d0400a3e2a1..7cd00eddb9c5 100644\n--...
[ { "subtask_id": "s1", "comment": "This catch is now around `execute`, not just overload resolution, so `CANNOT_CONVERT_TYPE` is too broad here. For example, `accurateCast(v, 'UInt8')` on a `Variant(UInt16, String)` value `300` can build successfully and then throw `CANNOT_CONVERT_TYPE` from the per-value ov...
diff --git a/src/Functions/FunctionDynamicAdaptor.cpp b/src/Functions/FunctionDynamicAdaptor.cpp index 8d0400a3e2a1..7cd00eddb9c5 100644 --- a/src/Functions/FunctionDynamicAdaptor.cpp +++ b/src/Functions/FunctionDynamicAdaptor.cpp @@ -85,6 +85,33 @@ ColumnPtr ExecutableFunctionDynamicAdaptor::executeImpl(const ColumnsW...
2
6
ClickHouse/ClickHouse#107389
ClickHouse/ClickHouse
107,389
a09d30d9e0c46faad1b63a07583ec10f1501397f
b0af15f8c38ffd32582a0a931f6fcab8b5b6baec
Fix `arrayResize` with a `Decimal` size <!-- Related: https://github.com/ClickHouse/ClickHouse/pull/107319 --> `arrayResize` read its size argument via `IColumn::getInt`, which for a `Decimal` column returns the raw unscaled value rather than the logical one. As a result `arrayResize([1, 2, 3], 1.5::Decimal(2, 1))` r...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Functions/array/` needed for: Fix `arrayResize` with a `Decimal` size", "scope_files": [ "src/Functions/array/arrayResize.cpp" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/Functions/tests/` need...
[ { "subtask_id": "s1", "scope_files": [ "src/Functions/array/arrayResize.cpp" ], "solution_diff": "diff --git a/src/Functions/array/arrayResize.cpp b/src/Functions/array/arrayResize.cpp\nindex bbf0f2f18472..8513b4444295 100644\n--- a/src/Functions/array/arrayResize.cpp\n+++ b/src/Functions/arra...
[]
diff --git a/src/Functions/array/arrayResize.cpp b/src/Functions/array/arrayResize.cpp index bbf0f2f18472..8513b4444295 100644 --- a/src/Functions/array/arrayResize.cpp +++ b/src/Functions/array/arrayResize.cpp @@ -4,6 +4,7 @@ #include <Functions/GatherUtils/GatherUtils.h> #include <DataTypes/DataTypeArray.h> #inclu...
3
4
ClickHouse/ClickHouse#107430
ClickHouse/ClickHouse
107,430
0303010ba9899c1667080ad1b98daeaf326ab2aa
fd2eda719fe3db1cbec94af2409829dcfe8b0a9c
Do not rewrite NULL-preserving aggregates with optimize_rewrite_aggregate_function_with_if <!-- Linked issues and pull requests. Use full GitHub URLs, one relationship per line; delete the lines you don't need. Closes: https://github.com/ClickHouse/ClickHouse/issues/107421 --> ### Changelog category (leave one): - ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Analyzer/Passes/` needed for: Do not rewrite NULL-preserving aggregates with optimize_rewrite_aggregate_function_with_if", "scope_files": [ "src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp" ] }, { "subtask_id": ...
[ { "subtask_id": "s1", "scope_files": [ "src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp" ], "solution_diff": "diff --git a/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp b/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp\nindex 4e1dec0a9b27..bbc16d0571f0 100644...
[ { "subtask_id": "s1", "comment": "And what if it has a custom Null Adapter, which is non-default?", "revised_diff": "diff --git a/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp b/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp\nindex 4e1dec0a9b27..bbc16d0571f0 100644\n--- a/src/An...
diff --git a/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp b/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp index 4e1dec0a9b27..bbc16d0571f0 100644 --- a/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp +++ b/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp @@ -2,8 +2,10 @@ ...
2
3
ClickHouse/ClickHouse#107387
ClickHouse/ClickHouse
107,387
19059120f5e793db617f4370f6493365992fe4df
8b605e0806f52e43e61ca75c35d88903e1e508f1
Revert "Revert "Fix session_timezone ignored on LowCardinality(DateTime)"" Reverts ClickHouse/ClickHouse#107315
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/DataTypes/Serializations/` needed for: Revert \"Revert \"Fix session_timezone ignored on LowCardinality(DateTime)\"\"", "scope_files": [ "src/DataTypes/Serializations/SerializationLowCardinality.cpp" ] }, { "subtask_id": "...
[ { "subtask_id": "s1", "scope_files": [ "src/DataTypes/Serializations/SerializationLowCardinality.cpp" ], "solution_diff": "diff --git a/src/DataTypes/Serializations/SerializationLowCardinality.cpp b/src/DataTypes/Serializations/SerializationLowCardinality.cpp\nindex cb47cc7537d9..5dcdbb2c55c4 ...
[ { "subtask_id": "s2", "comment": "This restores the same shared-server shape that made `#106634` flaky and led to `#107315`: the test warms and checks the process-global `SerializationObjectPool` through `${CLICKHOUSE_CLIENT}`, so other parallel stateless tests using the same server can affect which `LowCar...
diff --git a/src/DataTypes/Serializations/SerializationLowCardinality.cpp b/src/DataTypes/Serializations/SerializationLowCardinality.cpp index cb47cc7537d9..5dcdbb2c55c4 100644 --- a/src/DataTypes/Serializations/SerializationLowCardinality.cpp +++ b/src/DataTypes/Serializations/SerializationLowCardinality.cpp @@ -44,11...
2
3
ClickHouse/ClickHouse#107124
ClickHouse/ClickHouse
107,124
0f3fdcf807d5dc4e712c66d6cca0fdc30ad4a5a3
c0aeba1961af0305083fca9cf933476eee3536a6
Preserve constant columns of `ActionsDAG` input nodes in serialization `ActionsDAG::serialize` skipped the column for all `INPUT` nodes: ```cpp const bool has_column = (node.type != ActionType::INPUT && node.column != nullptr); ``` However, `INPUT` nodes can legitimately carry a constant column: lambda capture DAGs ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Interpreters/` needed for: Preserve constant columns of `ActionsDAG` input nodes in serialization", "scope_files": [ "src/Interpreters/ActionsDAG.cpp" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `te...
[ { "subtask_id": "s1", "scope_files": [ "src/Interpreters/ActionsDAG.cpp" ], "solution_diff": "diff --git a/src/Interpreters/ActionsDAG.cpp b/src/Interpreters/ActionsDAG.cpp\nindex a88b14751d5b..ce7921950bc8 100644\n--- a/src/Interpreters/ActionsDAG.cpp\n+++ b/src/Interpreters/ActionsDAG.cpp\n@...
[]
diff --git a/src/Interpreters/ActionsDAG.cpp b/src/Interpreters/ActionsDAG.cpp index a88b14751d5b..ce7921950bc8 100644 --- a/src/Interpreters/ActionsDAG.cpp +++ b/src/Interpreters/ActionsDAG.cpp @@ -3886,8 +3886,13 @@ void ActionsDAG::serialize(WriteBuffer & out, SerializedSetsRegistry & registry) writeVar...
2
3
ClickHouse/ClickHouse#74691
ClickHouse/ClickHouse
74,691
1a5e24c889955eaff7e2e29e19e0074f30bf1322
09b2afe7949a3181110e32075ef51c49474b53e9
Add `FORMAT PNG` support <!--- A technical comment, you are free to remove or leave it as it is when PR is created The following categories are used in the next scripts, update them accordingly utils/changelog/changelog.py tests/ci/cancel_and_rerun_workflow_lambda/app.py --> ### Changelog category (leave one): ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Add `FORMAT PNG` support", "scope_files": [ ".gitmodules" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `ci/jobs/` needed for: Add `FORMAT PNG` support", "scope_files": [ "c...
[ { "subtask_id": "s1", "scope_files": [ ".gitmodules" ], "solution_diff": "diff --git a/.gitmodules b/.gitmodules\nindex 038e3ac05c35..33373dbc389e 100644\n--- a/.gitmodules\n+++ b/.gitmodules\n@@ -357,6 +357,9 @@\n [submodule \"contrib/SHA3IUF\"]\n \tpath = contrib/SHA3IUF\n \turl = https://gi...
[ { "subtask_id": "s4", "comment": "Not making libpng dependent on ENABLE_LIBRARIES will compile it unconditionally in all builds. This isn't good, FastTest does a minimal build with as few as possible library dependencies. Let's restore l. 1-6.", "revised_diff": "diff --git a/contrib/libpng-cmake/CMakeLi...
diff --git a/.gitmodules b/.gitmodules index 038e3ac05c35..33373dbc389e 100644 --- a/.gitmodules +++ b/.gitmodules @@ -357,6 +357,9 @@ [submodule "contrib/SHA3IUF"] path = contrib/SHA3IUF url = https://github.com/brainhub/SHA3IUF.git +[submodule "contrib/libpng"] + path = contrib/libpng + url = https://github.com/...
12
29
ClickHouse/ClickHouse#102904
ClickHouse/ClickHouse
102,904
1f08686bb837d2b91e23cad6c25dad138bb6c2f3
315a58477683b8b311dfb7957838d89cd730afa0
Disable lazy materialization for patch parts ### Changelog category (leave one): - Not for changelog (changelog entry is not required) ### Changelog entry (a [user-readable short description](https://github.com/ClickHouse/ClickHouse/blob/master/docs/changelog_entry_guidelines.md) of the changes that goes into CHAN...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Processors/QueryPlan/Optimizations/` needed for: Disable lazy materialization for patch parts", "scope_files": [ "src/Processors/QueryPlan/Optimizations/optimizeLazyMaterialization.cpp" ] }, { "subtask_id": "s2", "goal...
[ { "subtask_id": "s1", "scope_files": [ "src/Processors/QueryPlan/Optimizations/optimizeLazyMaterialization.cpp" ], "solution_diff": "diff --git a/src/Processors/QueryPlan/Optimizations/optimizeLazyMaterialization.cpp b/src/Processors/QueryPlan/Optimizations/optimizeLazyMaterialization.cpp\nind...
[ { "subtask_id": "s2", "comment": "Typo in test comment: \"where for error\" reads oddly. Please rephrase to something like \"Test reproduces regression with error\".\n", "revised_diff": "diff --git a/tests/queries/0_stateless/04102_lazy_materialization_with_patch_parts.sql b/tests/queries/0_stateless/04...
diff --git a/src/Processors/QueryPlan/Optimizations/optimizeLazyMaterialization.cpp b/src/Processors/QueryPlan/Optimizations/optimizeLazyMaterialization.cpp index d11c77b038aa..8347d10264d5 100644 --- a/src/Processors/QueryPlan/Optimizations/optimizeLazyMaterialization.cpp +++ b/src/Processors/QueryPlan/Optimizations/o...
2
3
ClickHouse/ClickHouse#98827
ClickHouse/ClickHouse
98,827
b0db88ca1cf6084fb5495911ec0a0ca3f53cc9f2
5198f3225264c04399828edefa93aec04b3ab11a
Implement http header validation for DataLakeCatalog ### Changelog category (leave one): - Bug Fix (user-visible misbehavior in an official stable release) ### Changelog entry (a [user-readable short description](https://github.com/ClickHouse/ClickHouse/blob/master/docs/changelog_entry_guidelines.md) of the chan...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Databases/DataLake/` needed for: Implement http header validation for DataLakeCatalog", "scope_files": [ "src/Databases/DataLake/DatabaseDataLake.cpp" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `te...
[ { "subtask_id": "s1", "scope_files": [ "src/Databases/DataLake/DatabaseDataLake.cpp" ], "solution_diff": "diff --git a/src/Databases/DataLake/DatabaseDataLake.cpp b/src/Databases/DataLake/DatabaseDataLake.cpp\nindex 4215f58cea1a..9744da4455e9 100644\n--- a/src/Databases/DataLake/DatabaseDataLa...
[ { "subtask_id": "s1", "comment": "### Header validation runs during ATTACH blocking server restart\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\nThe new forbidden-header validation runs unconditionally in the factory's `create_fn`, which is invoked for both `CREATE DATABASE` and `ATTACH DATABASE` (ser...
diff --git a/src/Databases/DataLake/DatabaseDataLake.cpp b/src/Databases/DataLake/DatabaseDataLake.cpp index 4215f58cea1a..9744da4455e9 100644 --- a/src/Databases/DataLake/DatabaseDataLake.cpp +++ b/src/Databases/DataLake/DatabaseDataLake.cpp @@ -47,6 +47,7 @@ #include <Parsers/ASTFunction.h> #include <Parsers/ASTDat...
5
6
ClickHouse/ClickHouse#107346
ClickHouse/ClickHouse
107,346
503b8321beb136b493f594dd79efaa00bcf6c6c4
821c3c723af96cb00ae75ee584786ffd524bbd3c
Backport #107071 to 26.5: Support trim character sets longer than 16 in trim* functions Original pull-request https://github.com/ClickHouse/ClickHouse/pull/107071 Cherry-pick pull-request https://github.com/ClickHouse/ClickHouse/pull/107177 This pull-request is a last step of an automated backporting. Treat it as a s...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Functions/` needed for: Backport #107071 to 26.5: Support trim character sets longer than 16 in trim* functions", "scope_files": [ "src/Functions/trim.cpp" ] }, { "subtask_id": "s2", "goal": "Implement the changes unde...
[ { "subtask_id": "s1", "scope_files": [ "src/Functions/trim.cpp" ], "solution_diff": "diff --git a/src/Functions/trim.cpp b/src/Functions/trim.cpp\nindex fbbfeab7635d..ea4c4b35a04c 100644\n--- a/src/Functions/trim.cpp\n+++ b/src/Functions/trim.cpp\n@@ -7,18 +7,24 @@\n #include <Functions/Functi...
[]
diff --git a/src/Functions/trim.cpp b/src/Functions/trim.cpp index fbbfeab7635d..ea4c4b35a04c 100644 --- a/src/Functions/trim.cpp +++ b/src/Functions/trim.cpp @@ -7,18 +7,24 @@ #include <Functions/FunctionHelpers.h> #include <base/find_symbols.h> +#include <array> + namespace DB { namespace ErrorCodes { ex...
2
7
ClickHouse/ClickHouse#107345
ClickHouse/ClickHouse
107,345
7a7d19151f4f1b72f4d39d6d5f4681a147a86704
89d221e6ba94850bc9f7bbff6246d6d1c155a91e
Backport #107071 to 26.4: Support trim character sets longer than 16 in trim* functions Original pull-request https://github.com/ClickHouse/ClickHouse/pull/107071 Cherry-pick pull-request https://github.com/ClickHouse/ClickHouse/pull/107176 This pull-request is a last step of an automated backporting. Treat it as a s...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Functions/` needed for: Backport #107071 to 26.4: Support trim character sets longer than 16 in trim* functions", "scope_files": [ "src/Functions/trim.cpp" ] }, { "subtask_id": "s2", "goal": "Implement the changes unde...
[ { "subtask_id": "s1", "scope_files": [ "src/Functions/trim.cpp" ], "solution_diff": "diff --git a/src/Functions/trim.cpp b/src/Functions/trim.cpp\nindex fbbfeab7635d..ea4c4b35a04c 100644\n--- a/src/Functions/trim.cpp\n+++ b/src/Functions/trim.cpp\n@@ -7,18 +7,24 @@\n #include <Functions/Functi...
[]
diff --git a/src/Functions/trim.cpp b/src/Functions/trim.cpp index fbbfeab7635d..ea4c4b35a04c 100644 --- a/src/Functions/trim.cpp +++ b/src/Functions/trim.cpp @@ -7,18 +7,24 @@ #include <Functions/FunctionHelpers.h> #include <base/find_symbols.h> +#include <array> + namespace DB { namespace ErrorCodes { ex...
2
7
ClickHouse/ClickHouse#107404
ClickHouse/ClickHouse
107,404
9606dc9fee640e794992e5e3bc76447de78fe727
50d133ad5475fa6e84282b834befad299b5e27bb
Backport #106507 to 26.4: Fix wrong-results equality with NaN-producing key function Original pull-request https://github.com/ClickHouse/ClickHouse/pull/106507 Cherry-pick pull-request https://github.com/ClickHouse/ClickHouse/pull/107403 This pull-request is a last step of an automated backporting. Treat it as a stan...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Storages/MergeTree/` needed for: Backport #106507 to 26.4: Fix wrong-results equality with NaN-producing key function", "scope_files": [ "src/Storages/MergeTree/KeyCondition.cpp" ] }, { "subtask_id": "s2", "goal": "Imp...
[ { "subtask_id": "s1", "scope_files": [ "src/Storages/MergeTree/KeyCondition.cpp" ], "solution_diff": "diff --git a/src/Storages/MergeTree/KeyCondition.cpp b/src/Storages/MergeTree/KeyCondition.cpp\nindex f072b15417b9..d33a22de871e 100644\n--- a/src/Storages/MergeTree/KeyCondition.cpp\n+++ b/sr...
[]
diff --git a/src/Storages/MergeTree/KeyCondition.cpp b/src/Storages/MergeTree/KeyCondition.cpp index f072b15417b9..d33a22de871e 100644 --- a/src/Storages/MergeTree/KeyCondition.cpp +++ b/src/Storages/MergeTree/KeyCondition.cpp @@ -1927,7 +1927,14 @@ bool KeyCondition::canConstantBeWrappedByDeterministicFunctions( ...
2
3
ClickHouse/ClickHouse#107406
ClickHouse/ClickHouse
107,406
503b8321beb136b493f594dd79efaa00bcf6c6c4
fabfda40ff61861206cadbd1e49d82901c35612c
Backport #106507 to 26.5: Fix wrong-results equality with NaN-producing key function Original pull-request https://github.com/ClickHouse/ClickHouse/pull/106507 Cherry-pick pull-request https://github.com/ClickHouse/ClickHouse/pull/107405 This pull-request is a last step of an automated backporting. Treat it as a stan...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Storages/MergeTree/` needed for: Backport #106507 to 26.5: Fix wrong-results equality with NaN-producing key function", "scope_files": [ "src/Storages/MergeTree/KeyCondition.cpp" ] }, { "subtask_id": "s2", "goal": "Imp...
[ { "subtask_id": "s1", "scope_files": [ "src/Storages/MergeTree/KeyCondition.cpp" ], "solution_diff": "diff --git a/src/Storages/MergeTree/KeyCondition.cpp b/src/Storages/MergeTree/KeyCondition.cpp\nindex 91aa8bc5f6ad..6b4360282121 100644\n--- a/src/Storages/MergeTree/KeyCondition.cpp\n+++ b/sr...
[]
diff --git a/src/Storages/MergeTree/KeyCondition.cpp b/src/Storages/MergeTree/KeyCondition.cpp index 91aa8bc5f6ad..6b4360282121 100644 --- a/src/Storages/MergeTree/KeyCondition.cpp +++ b/src/Storages/MergeTree/KeyCondition.cpp @@ -2097,7 +2097,14 @@ bool KeyCondition::canConstantBeWrappedByDeterministicFunctions( ...
2
3
ClickHouse/ClickHouse#105555
ClickHouse/ClickHouse
105,555
9b22faf1eca3a6d0f481985027d5d26eadcfad0c
f545887f70a4b870d32bf49cd18e13e85b717081
`applyTrivialInsertSelectOptimization` drops `columns_description` from context, breaking table function structure hints _Found via ClickGap automated review. Please close or comment if this is incorrect or needs adjustment._ _Retrospective finding from a historical scan of [PR #91599](https://github.com/ClickHouse/C...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Interpreters/` needed for: `applyTrivialInsertSelectOptimization` drops `columns_description` from context, breaking table function structure hints", "scope_files": [ "src/Interpreters/InterpreterInsertQuery.cpp" ] }, { "s...
[ { "subtask_id": "s1", "scope_files": [ "src/Interpreters/InterpreterInsertQuery.cpp" ], "solution_diff": "diff --git a/src/Interpreters/InterpreterInsertQuery.cpp b/src/Interpreters/InterpreterInsertQuery.cpp\nindex 2810d0acc257..4699cd6918f4 100644\n--- a/src/Interpreters/InterpreterInsertQue...
[]
diff --git a/src/Interpreters/Access/InterpreterExecuteAsQuery.cpp b/src/Interpreters/Access/InterpreterExecuteAsQuery.cpp index 8ab1a453a5ba..cc095e3e0b3e 100644 --- a/src/Interpreters/Access/InterpreterExecuteAsQuery.cpp +++ b/src/Interpreters/Access/InterpreterExecuteAsQuery.cpp @@ -33,7 +33,7 @@ namespace ...
4
5
ClickHouse/ClickHouse#107384
ClickHouse/ClickHouse
107,384
e78a4dac750cb4e71fb1928c6e3d760817d45e78
4668a438051d5f17a5d7ecbb24eb2d380f8eb210
read auth_response length as UInt8 in MySQL handshake `HandshakeResponse::readPayloadImpl` reads the `auth_response` length for the `CLIENT_SECURE_CONNECTION` path into a signed `char` and widens it with `static_cast<unsigned int>`. The matching writer emits this field as an unsigned byte (`static_cast<UInt8>(auth_res...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Core/MySQL/` needed for: read auth_response length as UInt8 in MySQL handshake", "scope_files": [ "src/Core/MySQL/PacketsConnection.cpp" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `tests/queries/0_...
[ { "subtask_id": "s1", "scope_files": [ "src/Core/MySQL/PacketsConnection.cpp" ], "solution_diff": "diff --git a/src/Core/MySQL/PacketsConnection.cpp b/src/Core/MySQL/PacketsConnection.cpp\nindex 0cc97f6a8df2..db127898ab3a 100644\n--- a/src/Core/MySQL/PacketsConnection.cpp\n+++ b/src/Core/MySQL...
[ { "subtask_id": "s1", "comment": "```suggestion\n readBinary(len, payload);\n```", "revised_diff": "diff --git a/src/Core/MySQL/PacketsConnection.cpp b/src/Core/MySQL/PacketsConnection.cpp\nindex 0cc97f6a8df2..db127898ab3a 100644\n--- a/src/Core/MySQL/PacketsConnection.cpp\n+++ b/src/Core/MySQL/P...
diff --git a/src/Core/MySQL/PacketsConnection.cpp b/src/Core/MySQL/PacketsConnection.cpp index 0cc97f6a8df2..db127898ab3a 100644 --- a/src/Core/MySQL/PacketsConnection.cpp +++ b/src/Core/MySQL/PacketsConnection.cpp @@ -148,9 +148,9 @@ void HandshakeResponse::readPayloadImpl(ReadBuffer & payload) } else if (ca...
2
3
ClickHouse/ClickHouse#101942
ClickHouse/ClickHouse
101,942
961aff5091dd55df14a173b7b3f58c1f9524b7e0
f6a6dce6c24bdd0f8a3630844943a0a43218c964
OOM Canary ### Company or project name ClickHouse ### Use case `clickhouse-server` should be notified before the OOM killer has a chance to kill it. We can implement it by launching a small child process with an inflated OOM score adjustment. If the process is killed, we know that it was the OOM killer, and we can ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `programs/` needed for: OOM Canary", "scope_files": [ "programs/CMakeLists.txt", "programs/main.cpp" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `programs/oom-canary/` needed for: OOM Canary", ...
[ { "subtask_id": "s1", "scope_files": [ "programs/CMakeLists.txt", "programs/main.cpp" ], "solution_diff": "diff --git a/programs/CMakeLists.txt b/programs/CMakeLists.txt\nindex c44a71c1a85a..10300277822a 100644\n--- a/programs/CMakeLists.txt\n+++ b/programs/CMakeLists.txt\n@@ -109,6 +109...
[ { "subtask_id": "s7", "comment": "`oom_canary_enable` defaults to `true`, so this high-impact behavior is enabled immediately for all deployments: once the canary receives `SIGKILL`, the server executes emergency actions (query cancellation, merge cancellation, crash-log path). For safer rollout, this shoul...
diff --git a/programs/CMakeLists.txt b/programs/CMakeLists.txt index c44a71c1a85a..10300277822a 100644 --- a/programs/CMakeLists.txt +++ b/programs/CMakeLists.txt @@ -109,6 +109,7 @@ add_subdirectory (keeper-data-dumper) add_subdirectory (keeper-utils) add_subdirectory (local) add_subdirectory (obfuscator) +add_subd...
11
21
ClickHouse/ClickHouse#106178
ClickHouse/ClickHouse
106,178
3659e5601eac2078ed0f3ccef17d3e9ea9bebc3c
64398d8d8d683085114dd085d2c89e005c18fea6
Add embedded documentation for database engines This is the second PR in the series that adds embedded, runtime-introspectable documentation to ClickHouse component registries. The first ([#106177](https://github.com/ClickHouse/ClickHouse/pull/106177)) did this for table engines; this one does it for database engines....
[ { "subtask_id": "s1", "goal": "Implement the changes under `docs/en/engines/database-engines/` needed for: Add embedded documentation for database engines", "scope_files": [ "docs/en/engines/database-engines/backup.md", "docs/en/engines/database-engines/datalake.md", "docs/en/engines/d...
[ { "subtask_id": "s1", "scope_files": [ "docs/en/engines/database-engines/backup.md", "docs/en/engines/database-engines/datalake.md", "docs/en/engines/database-engines/materialized-postgresql.md" ], "solution_diff": "diff --git a/docs/en/engines/database-engines/backup.md b/docs/en/...
[ { "subtask_id": "s2", "comment": "The page now documents the new `description`, `syntax`, `examples`, `introduced_in`, and `related` columns, but the example below still runs `SELECT *` and shows only the old `name` column. That result is no longer possible, so readers copying the docs will see a different ...
diff --git a/docs/en/engines/database-engines/backup.md b/docs/en/engines/database-engines/backup.md index 98fc17e402c3..cb3880d4c9c3 100644 --- a/docs/en/engines/database-engines/backup.md +++ b/docs/en/engines/database-engines/backup.md @@ -14,20 +14,13 @@ Database backup works with both incremental and non-increment...
10
25
ClickHouse/ClickHouse#107417
ClickHouse/ClickHouse
107,417
6a756730987624515ad9c08daab2b7831d343ba1
f76710f11cd3d9f161f1bfda5c6dcab075e448ad
Fix undefined behavior on a non-finite timestamp in prometheusQuery <!-- Linked issues and pull requests. Use full GitHub URLs, one relationship per line; delete the lines you don't need. --> No related open issue found (searched parseTimeSeriesTypes / prometheusQuery UBSan / getFromFloat). ### Changelog category (l...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Parsers/Prometheus/` needed for: Fix undefined behavior on a non-finite timestamp in prometheusQuery", "scope_files": [ "src/Parsers/Prometheus/parseTimeSeriesTypes.cpp" ] }, { "subtask_id": "s2", "goal": "Implement th...
[ { "subtask_id": "s1", "scope_files": [ "src/Parsers/Prometheus/parseTimeSeriesTypes.cpp" ], "solution_diff": "diff --git a/src/Parsers/Prometheus/parseTimeSeriesTypes.cpp b/src/Parsers/Prometheus/parseTimeSeriesTypes.cpp\nindex 9f1f69e5241d..bc140b6cbadf 100644\n--- a/src/Parsers/Prometheus/pa...
[]
diff --git a/src/Parsers/Prometheus/parseTimeSeriesTypes.cpp b/src/Parsers/Prometheus/parseTimeSeriesTypes.cpp index 9f1f69e5241d..bc140b6cbadf 100644 --- a/src/Parsers/Prometheus/parseTimeSeriesTypes.cpp +++ b/src/Parsers/Prometheus/parseTimeSeriesTypes.cpp @@ -46,6 +46,14 @@ namespace template <is_decimal T> ...
2
3
ClickHouse/ClickHouse#107398
ClickHouse/ClickHouse
107,398
503b8321beb136b493f594dd79efaa00bcf6c6c4
cb0ec6adb2b8544935d15a7ee8842fc48273a28a
Backport #107208 to 26.5: Do not narrow UnionStep pipeline when with read in order Original pull-request https://github.com/ClickHouse/ClickHouse/pull/107208 Cherry-pick pull-request https://github.com/ClickHouse/ClickHouse/pull/107397 This pull-request is a last step of an automated backporting. Treat it as a standa...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Core/` needed for: Backport #107208 to 26.5: Do not narrow UnionStep pipeline when with read in order", "scope_files": [ "src/Core/Settings.cpp" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/Inte...
[ { "subtask_id": "s1", "scope_files": [ "src/Core/Settings.cpp" ], "solution_diff": "diff --git a/src/Core/Settings.cpp b/src/Core/Settings.cpp\nindex 8c17611c7a15..4329fa1aa1a9 100644\n--- a/src/Core/Settings.cpp\n+++ b/src/Core/Settings.cpp\n@@ -5927,10 +5927,10 @@ Set default mode in INTERSE...
[]
diff --git a/src/Core/Settings.cpp b/src/Core/Settings.cpp index 8c17611c7a15..4329fa1aa1a9 100644 --- a/src/Core/Settings.cpp +++ b/src/Core/Settings.cpp @@ -5927,10 +5927,10 @@ Set default mode in INTERSECT query. Possible values: empty string, 'ALL', 'DIST Set default mode in EXCEPT query. Possible values: empty st...
6
11
ClickHouse/ClickHouse#104558
ClickHouse/ClickHouse
104,558
3659e5601eac2078ed0f3ccef17d3e9ea9bebc3c
fab23475deb70684d0dbccc0d18a7e25678d8983
order by + limit applied before arrayJoin ### Company or project name _No response_ ### Describe what's wrong It appears that "limit" is applied together with "order by" before "arrayJoin" is executed ### Does it reproduce on the most recent release? Yes ### How to reproduce Latest clickhouse version: I would ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Interpreters/` needed for: order by + limit applied before arrayJoin", "scope_files": [ "src/Interpreters/InterpreterSelectQuery.cpp" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/Planner/` neede...
[ { "subtask_id": "s1", "scope_files": [ "src/Interpreters/InterpreterSelectQuery.cpp" ], "solution_diff": "diff --git a/src/Interpreters/InterpreterSelectQuery.cpp b/src/Interpreters/InterpreterSelectQuery.cpp\nindex 70111d67b637..2de69143a2f0 100644\n--- a/src/Interpreters/InterpreterSelectQue...
[ { "subtask_id": "s4", "comment": "This still leaves a row-truncating sort path uncovered. `pushLimitByIntoSort` runs later and can attach a per-stream `LIMIT BY` hint to this same `SortingStep` while `getLimit()` stays zero, so this guard lets `arrayJoin` be lifted above a sort that will still drop rows bef...
diff --git a/src/Interpreters/InterpreterSelectQuery.cpp b/src/Interpreters/InterpreterSelectQuery.cpp index 70111d67b637..2de69143a2f0 100644 --- a/src/Interpreters/InterpreterSelectQuery.cpp +++ b/src/Interpreters/InterpreterSelectQuery.cpp @@ -369,6 +369,23 @@ InterpreterSelectQuery::~InterpreterSelectQuery() = defa...
5
18
ClickHouse/ClickHouse#106621
ClickHouse/ClickHouse
106,621
e78a4dac750cb4e71fb1928c6e3d760817d45e78
a2562ae47772b1636ed6b807d67418b4153ea9a0
Fix `Memory` table abort on `ALTER` commands with no per-row data effect (STID 2380-3043) Fixes `STID: 2380-3043` (`Logical error: Mutation of \`Memory\` table produced incomplete output: block 0 has 0 rows, expected N`), reported by @alexey-milovidov on https://github.com/ClickHouse/ClickHouse/pull/106615 as a chroni...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Storages/` needed for: Fix `Memory` table abort on `ALTER` commands with no per-row data effect (STID 2380-3043)", "scope_files": [ "src/Storages/StorageMemory.cpp" ] }, { "subtask_id": "s2", "goal": "Implement the cha...
[ { "subtask_id": "s1", "scope_files": [ "src/Storages/StorageMemory.cpp" ], "solution_diff": "diff --git a/src/Storages/StorageMemory.cpp b/src/Storages/StorageMemory.cpp\nindex f0fc30d478b6..065a3f4fa691 100644\n--- a/src/Storages/StorageMemory.cpp\n+++ b/src/Storages/StorageMemory.cpp\n@@ -24...
[ { "subtask_id": "s1", "comment": "This `MATERIALIZE_TTL` entry does not actually make `ALTER TABLE ... MATERIALIZE TTL` a no-op for `Memory`: `InterpreterAlterQuery::runCommandSegments` builds a `MutationsInterpreter` for validation before `StorageMemory::mutate` is called, and `MutationsInterpreter::prepar...
diff --git a/src/Storages/StorageMemory.cpp b/src/Storages/StorageMemory.cpp index f0fc30d478b6..065a3f4fa691 100644 --- a/src/Storages/StorageMemory.cpp +++ b/src/Storages/StorageMemory.cpp @@ -249,24 +249,38 @@ void StorageMemory::mutate(const MutationCommands & commands, ContextPtr context { std::lock_guard lo...
2
3
ClickHouse/ClickHouse#107419
ClickHouse/ClickHouse
107,419
1a5e24c889955eaff7e2e29e19e0074f30bf1322
653085058b9b2b5f932c03146f3ed39565d3225f
Retry the changed-files GitHub API call and report failures clearly <!-- Related: https://github.com/ClickHouse/ClickHouse/pull/74691 --> `GH.get_changed_files` fetches the list of files a PR touches via `gh api .../pulls/<n>/files`. The `store_data` pre-hook fetches it once and stores it into the job KV data; severa...
[ { "subtask_id": "s1", "goal": "Implement the changes under `ci/jobs/scripts/workflow_hooks/` needed for: Retry the changed-files GitHub API call and report failures clearly", "scope_files": [ "ci/jobs/scripts/workflow_hooks/feature_docs.py", "ci/jobs/scripts/workflow_hooks/pr_labels_and_cate...
[ { "subtask_id": "s1", "scope_files": [ "ci/jobs/scripts/workflow_hooks/feature_docs.py", "ci/jobs/scripts/workflow_hooks/pr_labels_and_category.py", "ci/jobs/scripts/workflow_hooks/team_notifications.py" ], "solution_diff": "diff --git a/ci/jobs/scripts/workflow_hooks/feature_docs....
[ { "subtask_id": "s2", "comment": "This is the contract the PR fixes, but it is not covered by a focused regression test. A future change could reintroduce the original one-shot behavior and CI would only catch it during the next transient GitHub outage. Please add a small `ci/tests/test_gh.py` test that mon...
diff --git a/ci/jobs/scripts/workflow_hooks/feature_docs.py b/ci/jobs/scripts/workflow_hooks/feature_docs.py index 11e1bd6488b7..f03428fbdb42 100644 --- a/ci/jobs/scripts/workflow_hooks/feature_docs.py +++ b/ci/jobs/scripts/workflow_hooks/feature_docs.py @@ -42,6 +42,11 @@ def check_docs(): info = Info() if L...
2
4
ClickHouse/ClickHouse#107388
ClickHouse/ClickHouse
107,388
19059120f5e793db617f4370f6493365992fe4df
02ce0c53642fe63bae3648444a0ee19fea98fffb
Data race on ServerSettings during reload ### Describe the bug (From Claude) This is a unsynchronized read/write race on the global ServerSettings object that lives inside ContextSharedPart. Here's what's happening: The writer (thread T812, ConfigReloader): During a config reload, Server.cpp:2482 calls Context::s...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Core/` needed for: Data race on ServerSettings during reload", "scope_files": [ "src/Core/ServerSettings.cpp", "src/Core/ServerSettings.h" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/Func...
[ { "subtask_id": "s1", "scope_files": [ "src/Core/ServerSettings.cpp", "src/Core/ServerSettings.h" ], "solution_diff": "diff --git a/src/Core/ServerSettings.cpp b/src/Core/ServerSettings.cpp\nindex 664af43c27c8..4c5319cd8ead 100644\n--- a/src/Core/ServerSettings.cpp\n+++ b/src/Core/Server...
[ { "subtask_id": "s2", "comment": "This restores the unsynchronized `ServerSettings` snapshot that triggered `#106902`. `Context::getServerSettings` returns a reference to `shared->server_settings` without taking `shared->mutex`, but config reload still mutates that same object under the mutex via `Context::...
diff --git a/src/Core/ServerSettings.cpp b/src/Core/ServerSettings.cpp index 664af43c27c8..4c5319cd8ead 100644 --- a/src/Core/ServerSettings.cpp +++ b/src/Core/ServerSettings.cpp @@ -30,9 +30,13 @@ #include <Common/MemoryTracker.h> #include <Common/DNSResolver.h> +#include <Common/ZooKeeper/ZooKeeper.h> +#include <...
5
8
ClickHouse/ClickHouse#93830
ClickHouse/ClickHouse
93,830
8a69decd78adb17700abfad4538c5d3750226194
07520f54fbc7a36adc637c461574cfc15b3a8c8e
Support for ALTER TABLE ADD ENUM VALUES ### Changelog category (leave one): - New Feature ### Changelog entry (a [user-readable short description](https://github.com/ClickHouse/ClickHouse/blob/master/docs/changelog_entry_guidelines.md) of the changes that goes into CHANGELOG.md): Implement `ADD ENUM VALUES` in `A...
[ { "subtask_id": "s1", "goal": "Implement the changes under `docs/en/sql-reference/data-types/` needed for: Support for ALTER TABLE ADD ENUM VALUES", "scope_files": [ "docs/en/sql-reference/data-types/enum.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `docs/en/...
[ { "subtask_id": "s1", "scope_files": [ "docs/en/sql-reference/data-types/enum.md" ], "solution_diff": "diff --git a/docs/en/sql-reference/data-types/enum.md b/docs/en/sql-reference/data-types/enum.md\nindex 5f330bcd8766..ecbc90e8bc42 100644\n--- a/docs/en/sql-reference/data-types/enum.md\n+++ ...
[ { "subtask_id": "s1", "comment": "I think about syntax. We never had function in `expression` of MODIFY COLUMN\r\nhttps://clickhouse.com/docs/sql-reference/statements/alter/column#modify-column. \r\n\r\nHave you seen any examples of similar logic in other DBMS?", "revised_diff": "diff --git a/docs/en/sq...
diff --git a/docs/en/sql-reference/data-types/enum.md b/docs/en/sql-reference/data-types/enum.md index 5f330bcd8766..ecbc90e8bc42 100644 --- a/docs/en/sql-reference/data-types/enum.md +++ b/docs/en/sql-reference/data-types/enum.md @@ -162,3 +162,26 @@ Enum values are also convertible to numeric types using the `toT` fu...
6
15
ClickHouse/ClickHouse#58957
ClickHouse/ClickHouse
58,957
b06c9fc1e8d0589a2689a964f841dfd2c4dde43b
5a97c47f8cc44684f949f702e24274d41258eb00
Parse detached part name properly in case of `tryN` suffix ### Changelog category (leave one): - Bug Fix (user-visible misbehavior in an official stable release) ### Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md): Make possible to drop detached parts with the `tryN`...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Storages/` needed for: Parse detached part name properly in case of `tryN` suffix", "scope_files": [ "src/Storages/StorageReplicatedMergeTree.cpp" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/St...
[ { "subtask_id": "s1", "scope_files": [ "src/Storages/StorageReplicatedMergeTree.cpp" ], "solution_diff": "diff --git a/src/Storages/StorageReplicatedMergeTree.cpp b/src/Storages/StorageReplicatedMergeTree.cpp\nindex fa5395886182..1c4ea80d3121 100644\n--- a/src/Storages/StorageReplicatedMergeTr...
[ { "subtask_id": "s2", "comment": "```suggestion\n chassert(dir_name.size() >= 2);\n```", "revised_diff": "diff --git a/src/Storages/MergeTree/MergeTreePartInfo.cpp b/src/Storages/MergeTree/MergeTreePartInfo.cpp\nindex 346b4bb09d75..c41ab2b4fcc1 100644\n--- a/src/Storages/MergeTree/MergeTreePartIn...
diff --git a/src/Storages/MergeTree/DataPartStorageOnDiskBase.cpp b/src/Storages/MergeTree/DataPartStorageOnDiskBase.cpp index c4e6846a48d1..03d3c603fb41 100644 --- a/src/Storages/MergeTree/DataPartStorageOnDiskBase.cpp +++ b/src/Storages/MergeTree/DataPartStorageOnDiskBase.cpp @@ -146,7 +146,7 @@ String DataPartStorag...
3
7
ClickHouse/ClickHouse#97014
ClickHouse/ClickHouse
97,014
d0534d76c0718cf7d990e929bf22660641ae4a90
75f70593f94f80f92b7be4250fa0de20ce47d032
Fix bugfix validation failing due to git ownership check in Docker ## Summary - The `find_master_builds` function (introduced in #96868) runs `git log origin/master` inside Docker containers that run as root, but the repository is owned by the `ubuntu` user - Git's ownership check blocks the command, returning empty o...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: Fix bugfix validation failing due to git ownership check in Docker", "scope_files": [ ".github/workflows/pull_request.yml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `ci...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/pull_request.yml" ], "solution_diff": "diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml\nindex 4133e1e09402..980b5711112e 100644\n--- a/.github/workflows/pull_request.yml\n+++ b/.github/workflows/pull...
[ { "subtask_id": "s3", "comment": "this job stage checks crashes which are, in context of bugfix validation, \"success\" case (bug reproduced), the stage supposed to be executed for every build for job to work correctly\n", "revised_diff": "diff --git a/ci/jobs/functional_tests.py b/ci/jobs/functional_te...
diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 4133e1e09402..980b5711112e 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -1698,7 +1698,7 @@ jobs: PYTHONUNBUFFERED=1 python3 -m praktika run 'Integration tests (amd_asan_ub...
5
7
ClickHouse/ClickHouse#101447
ClickHouse/ClickHouse
101,447
b187aa1ea88de810e7ee86961a0e725ab2b341d2
6278ace9a4a73d81694b62bd3322d323915a76db
Fix use-after-free of workload storage mutex during server shutdown During server shutdown, `ContextSharedPart` destroys `workload_entity_storage` via `unique_ptr::reset` while a query pipeline may still be running `PipelineExecutor::allocateCPU`, which holds a raw reference to the storage obtained from `getWorkloadEn...
[ { "subtask_id": "s1", "goal": "Implement the changes under `programs/server/` needed for: Fix use-after-free of workload storage mutex during server shutdown", "scope_files": [ "programs/server/Server.cpp" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/Common/...
[ { "subtask_id": "s1", "scope_files": [ "programs/server/Server.cpp" ], "solution_diff": "diff --git a/programs/server/Server.cpp b/programs/server/Server.cpp\nindex e0d4cb793493..375a650fdc01 100644\n--- a/programs/server/Server.cpp\n+++ b/programs/server/Server.cpp\n@@ -2543,7 +2543,7 @@ try\...
[ { "subtask_id": "s6", "comment": "`getWorkloadEntityStoragePtr` reads `shared->workload_entity_storage` without synchronization, but shutdown later writes to the same `shared_ptr` object (`delete_workload_entity_storage = std::move(workload_entity_storage)` under `shared->mutex`).\n\nConcurrent read/write o...
diff --git a/programs/server/Server.cpp b/programs/server/Server.cpp index e0d4cb793493..375a650fdc01 100644 --- a/programs/server/Server.cpp +++ b/programs/server/Server.cpp @@ -2543,7 +2543,7 @@ try } /// Load WORKLOADs and RESOURCEs. - global_context->getWorkloadEntityStorage()...
8
16
ClickHouse/ClickHouse#105248
ClickHouse/ClickHouse
105,248
3659e5601eac2078ed0f3ccef17d3e9ea9bebc3c
1fcf1c2b16335305856abda4740eb3e2275f4b12
Fix arrayRemove logical error when comparing incompatible Variant types Related: #95839 When `arrayRemove`'s first argument is an `Array(Variant(...))` whose Variant alternatives are all incompatible with the type of the second argument and `variant_throw_on_type_mismatch = 0`, `equals` returns `Nullable(Nothing)` in...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Functions/array/` needed for: Fix arrayRemove logical error when comparing incompatible Variant types", "scope_files": [ "src/Functions/array/arrayRemove.cpp" ] }, { "subtask_id": "s2", "goal": "Implement the changes u...
[ { "subtask_id": "s1", "scope_files": [ "src/Functions/array/arrayRemove.cpp" ], "solution_diff": "diff --git a/src/Functions/array/arrayRemove.cpp b/src/Functions/array/arrayRemove.cpp\nindex d3901c993284..b43364630a0b 100644\n--- a/src/Functions/array/arrayRemove.cpp\n+++ b/src/Functions/arra...
[ { "subtask_id": "s1", "comment": "Please limit this recovery path to the `Nothing` result described above. As written, any unexpected non-`UInt8` result from `equals` is converted into an all-zero filter, so `arrayRemove` would silently keep every element instead of surfacing a broken comparison contract. H...
diff --git a/src/Functions/array/arrayRemove.cpp b/src/Functions/array/arrayRemove.cpp index d3901c993284..b43364630a0b 100644 --- a/src/Functions/array/arrayRemove.cpp +++ b/src/Functions/array/arrayRemove.cpp @@ -138,6 +138,17 @@ ColumnPtr FunctionArrayRemove::executeImpl( /// equals() on tuples with nullabl...
2
3
ClickHouse/ClickHouse#106690
ClickHouse/ClickHouse
106,690
3659e5601eac2078ed0f3ccef17d3e9ea9bebc3c
da47f28415c7460ae1d6385dd4fa20fedae1f0be
Fix spurious resource request failure from reused `ResourceGuard::Request` `ResourceGuard::Request` is reused per thread via the `Request::local()` thread-local instance. Its `exception` member is set by `failed()` but was never cleared on reuse, so a thread that had previously run a failed resource request kept a sta...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Common/` needed for: Fix spurious resource request failure from reused `ResourceGuard::Request`", "scope_files": [ "src/Common/HTTPConnectionPool.cpp" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `sr...
[ { "subtask_id": "s1", "scope_files": [ "src/Common/HTTPConnectionPool.cpp" ], "solution_diff": "diff --git a/src/Common/HTTPConnectionPool.cpp b/src/Common/HTTPConnectionPool.cpp\nindex 5583cedf8792..999003858b4c 100644\n--- a/src/Common/HTTPConnectionPool.cpp\n+++ b/src/Common/HTTPConnectionP...
[ { "subtask_id": "s2", "comment": "The same failed-request path still leaves the thread-local `Request` in the wrong lifecycle state. In the default-lock constructor, `request.wait` throws after `failed` has moved the request to `Dequeued`; because the `ResourceGuard` constructor never completes, `~ResourceG...
diff --git a/src/Common/HTTPConnectionPool.cpp b/src/Common/HTTPConnectionPool.cpp index 5583cedf8792..999003858b4c 100644 --- a/src/Common/HTTPConnectionPool.cpp +++ b/src/Common/HTTPConnectionPool.cpp @@ -354,8 +354,22 @@ struct ResourceGuardSessionDataHooks : public Poco::Net::IHTTPSessionDataHooks void atStart...
3
5
ClickHouse/ClickHouse#106185
ClickHouse/ClickHouse
106,185
3659e5601eac2078ed0f3ccef17d3e9ea9bebc3c
1cfb6342b4652f83cd4799547ffe64ec00dff9e1
Add embedded documentation for aggregate function combinators Part of the series adding embedded, runtime-introspectable documentation to ClickHouse component registries (table engines [#106177](https://github.com/ClickHouse/ClickHouse/pull/106177), database engines [#106178](https://github.com/ClickHouse/ClickHouse/p...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/AggregateFunctions/Combinators/` needed for: Add embedded documentation for aggregate function combinators", "scope_files": [ "src/AggregateFunctions/Combinators/AggregateFunctionArray.cpp", "src/AggregateFunctions/Combinators/A...
[ { "subtask_id": "s1", "scope_files": [ "src/AggregateFunctions/Combinators/AggregateFunctionArray.cpp", "src/AggregateFunctions/Combinators/AggregateFunctionCombinatorFactory.cpp", "src/AggregateFunctions/Combinators/AggregateFunctionCombinatorFactory.h", "src/AggregateFunctions/Comb...
[ { "subtask_id": "s1", "comment": "The contract here is runtime-introspectable documentation for the combinator itself, but this description is only correct for single-argument nested aggregates such as `sumArgMin(x, key)`. `ArgMin` also supports zero-argument nested aggregates (`countArgMin(key)`) and multi...
diff --git a/src/AggregateFunctions/Combinators/AggregateFunctionArray.cpp b/src/AggregateFunctions/Combinators/AggregateFunctionArray.cpp index 86fceb681a75..24850d7d2afa 100644 --- a/src/AggregateFunctions/Combinators/AggregateFunctionArray.cpp +++ b/src/AggregateFunctions/Combinators/AggregateFunctionArray.cpp @@ -5...
3
19
ClickHouse/ClickHouse#106182
ClickHouse/ClickHouse
106,182
3659e5601eac2078ed0f3ccef17d3e9ea9bebc3c
c00a16a40690dcc4ac2f0115d37762520ed0a375
Add embedded documentation and a system table for dictionary layouts Fifth PR in the series that adds embedded, runtime-introspectable documentation to ClickHouse component registries (after table engines [#106177](https://github.com/ClickHouse/ClickHouse/pull/106177), database engines [#106178](https://github.com/Cli...
[ { "subtask_id": "s1", "goal": "Implement the changes under `docs/en/operations/system-tables/` needed for: Add embedded documentation and a system table for dictionary layouts", "scope_files": [ "docs/en/operations/system-tables/dictionary_layouts.md" ] }, { "subtask_id": "s2", "go...
[ { "subtask_id": "s1", "scope_files": [ "docs/en/operations/system-tables/dictionary_layouts.md" ], "solution_diff": "diff --git a/docs/en/operations/system-tables/dictionary_layouts.md b/docs/en/operations/system-tables/dictionary_layouts.md\nnew file mode 100644\nindex 000000000000..fc1df6d06...
[ { "subtask_id": "s1", "comment": "New documentation files under `docs/` must include the full required frontmatter set: `description`, `sidebar_label`, `sidebar_position`, `slug`, `title`, and `doc_type`. This page currently omits `sidebar_label` and `sidebar_position`, so it does not satisfy the repo docum...
diff --git a/docs/en/operations/system-tables/dictionary_layouts.md b/docs/en/operations/system-tables/dictionary_layouts.md new file mode 100644 index 000000000000..fc1df6d066bd --- /dev/null +++ b/docs/en/operations/system-tables/dictionary_layouts.md @@ -0,0 +1,45 @@ +--- +description: 'System table containing a lis...
5
21
ClickHouse/ClickHouse#107358
ClickHouse/ClickHouse
107,358
3659e5601eac2078ed0f3ccef17d3e9ea9bebc3c
637b70a43f4aedb960737c5cbb6860d2ad7e28c6
Add regression test for recursive CTE referenced from another recursive CTE <!-- Linked issues and pull requests. Use full GitHub URLs, one relationship per line; delete the lines you don't need. Related: https://github.com/ClickHouse/ClickHouse/issues/89844 --> Related: #89844 ### Changelog category (leave one): -...
[ { "subtask_id": "s1", "goal": "Implement the changes under `tests/queries/0_stateless/` needed for: Add regression test for recursive CTE referenced from another recursive CTE", "scope_files": [ "tests/queries/0_stateless/04337_recursive_cte_inner_ref_no_logical_error.reference", "tests/quer...
[ { "subtask_id": "s1", "scope_files": [ "tests/queries/0_stateless/04337_recursive_cte_inner_ref_no_logical_error.reference", "tests/queries/0_stateless/04337_recursive_cte_inner_ref_no_logical_error.sql" ], "solution_diff": "diff --git a/tests/queries/0_stateless/04337_recursive_cte_inne...
[]
diff --git a/tests/queries/0_stateless/04337_recursive_cte_inner_ref_no_logical_error.reference b/tests/queries/0_stateless/04337_recursive_cte_inner_ref_no_logical_error.reference new file mode 100644 index 000000000000..fd3c81a4d763 --- /dev/null +++ b/tests/queries/0_stateless/04337_recursive_cte_inner_ref_no_logic...
1
2
ClickHouse/ClickHouse#107326
ClickHouse/ClickHouse
107,326
a8282a90557dc185a09b8a636dc0fb2cf07ae8fe
7696bab5662bb22abb64a353e3f57fe60ad24173
Backport #105544 to 26.3: Fix ignoring `input_format_try_infer_datetimes` during insertion into shared data in JSON Original pull-request https://github.com/ClickHouse/ClickHouse/pull/105544 Cherry-pick pull-request https://github.com/ClickHouse/ClickHouse/pull/107325 This pull-request is a last step of an automated ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Formats/` needed for: Backport #105544 to 26.3: Fix ignoring `input_format_try_infer_datetimes` during insertion into shared data in JSON", "scope_files": [ "src/Formats/JSONExtractTree.cpp" ] }, { "subtask_id": "s2", ...
[ { "subtask_id": "s1", "scope_files": [ "src/Formats/JSONExtractTree.cpp" ], "solution_diff": "diff --git a/src/Formats/JSONExtractTree.cpp b/src/Formats/JSONExtractTree.cpp\nindex 29934e72dcaf..e127fe77cd67 100644\n--- a/src/Formats/JSONExtractTree.cpp\n+++ b/src/Formats/JSONExtractTree.cpp\n@...
[]
diff --git a/src/Formats/JSONExtractTree.cpp b/src/Formats/JSONExtractTree.cpp index 29934e72dcaf..e127fe77cd67 100644 --- a/src/Formats/JSONExtractTree.cpp +++ b/src/Formats/JSONExtractTree.cpp @@ -2206,6 +2206,7 @@ class ObjectJSONNode : public JSONExtractTreeNode<JSONParser> } }...
2
3
ClickHouse/ClickHouse#100177
ClickHouse/ClickHouse
100,177
3659e5601eac2078ed0f3ccef17d3e9ea9bebc3c
6555f83347cdcdb64e31699e7f5e92bf31e3e2ac
ThreadPool: wake most recently idle worker thread (LIFO) when scheduling a job to reduce memory fragmentation When a new job is scheduled, the thread pool now wakes the most recently idle thread (LIFO order) instead of an OS-determined arbitrary thread. This concentrates work on fewer OS threads, which: 1. Reduces me...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Common/` needed for: ThreadPool: wake most recently idle worker thread (LIFO) when scheduling a job to reduce memory fragmentation", "scope_files": [ "src/Common/ThreadPool.cpp", "src/Common/ThreadPool.h" ] }, { "sub...
[ { "subtask_id": "s1", "scope_files": [ "src/Common/ThreadPool.cpp", "src/Common/ThreadPool.h" ], "solution_diff": "diff --git a/src/Common/ThreadPool.cpp b/src/Common/ThreadPool.cpp\nindex ca6fc24a9b54..cb5414214d45 100644\n--- a/src/Common/ThreadPool.cpp\n+++ b/src/Common/ThreadPool.cpp...
[ { "subtask_id": "s1", "comment": "`ThreadFromThreadPool::worker` runs under `DENY_ALLOCATIONS_IN_SCOPE`, but `idle_thread_stack.push_back(this)` can allocate when the vector grows. That introduces allocation attempts on the worker path and can trigger allocation-denial failures/assertions.\n\nPlease make th...
diff --git a/src/Common/Scheduler/ResourceGuard.h b/src/Common/Scheduler/ResourceGuard.h index 5d894b8b9ed5..6dcc4e825825 100644 --- a/src/Common/Scheduler/ResourceGuard.h +++ b/src/Common/Scheduler/ResourceGuard.h @@ -95,6 +95,10 @@ class ResourceGuard // lock(mutex) is not required because `Finished` req...
4
5
ClickHouse/ClickHouse#107381
ClickHouse/ClickHouse
107,381
3659e5601eac2078ed0f3ccef17d3e9ea9bebc3c
591768e8f7d17d09e42c107df0ea8081301d9c95
Disable parallel replicas in nested scalar subquery contexts <!-- Linked issues and pull requests. Use full GitHub URLs, one relationship per line; delete the lines you don't need. Related: https://github.com/ClickHouse/ClickHouse/pull/94517 --> ### Changelog category (leave one): - Bug Fix (user-visible misbehavio...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Analyzer/Resolve/` needed for: Disable parallel replicas in nested scalar subquery contexts", "scope_files": [ "src/Analyzer/Resolve/evaluateScalarSubqueryIfNeeded.cpp" ] }, { "subtask_id": "s2", "goal": "Implement the...
[ { "subtask_id": "s1", "scope_files": [ "src/Analyzer/Resolve/evaluateScalarSubqueryIfNeeded.cpp" ], "solution_diff": "diff --git a/src/Analyzer/Resolve/evaluateScalarSubqueryIfNeeded.cpp b/src/Analyzer/Resolve/evaluateScalarSubqueryIfNeeded.cpp\nindex f2a8973b1d6d..97922f168b26 100644\n--- a/s...
[]
diff --git a/src/Analyzer/Resolve/evaluateScalarSubqueryIfNeeded.cpp b/src/Analyzer/Resolve/evaluateScalarSubqueryIfNeeded.cpp index f2a8973b1d6d..97922f168b26 100644 --- a/src/Analyzer/Resolve/evaluateScalarSubqueryIfNeeded.cpp +++ b/src/Analyzer/Resolve/evaluateScalarSubqueryIfNeeded.cpp @@ -145,6 +145,36 @@ void Que...
2
3
ClickHouse/ClickHouse#107374
ClickHouse/ClickHouse
107,374
3659e5601eac2078ed0f3ccef17d3e9ea9bebc3c
8e3b04f3ffa1ecc0b659147b61f8728198a669e2
Fix in-place mutation of shared Variant subcolumn when converting Variant to a column <!-- Linked issues and pull requests. Use full GitHub URLs, one relationship per line; delete the lines you don't need. Related: https://github.com/ClickHouse/ClickHouse/issues/101415 --> ### Changelog category (leave one): - Bug ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Functions/` needed for: Fix in-place mutation of shared Variant subcolumn when converting Variant to a column", "scope_files": [ "src/Functions/FunctionDynamicAdaptor.cpp", "src/Functions/FunctionVariantAdaptor.cpp", "src/...
[ { "subtask_id": "s1", "scope_files": [ "src/Functions/FunctionDynamicAdaptor.cpp", "src/Functions/FunctionVariantAdaptor.cpp", "src/Functions/FunctionsConversion.cpp" ], "solution_diff": "diff --git a/src/Functions/FunctionDynamicAdaptor.cpp b/src/Functions/FunctionDynamicAdaptor.c...
[ { "subtask_id": "s1", "comment": "This detaches the `Variant` fast path before `expand`, but the sibling `Dynamic` adaptor still has the same aliasing bug. In `FunctionDynamicAdaptor.cpp`, the single-type-plus-NULL path replaces the `Dynamic` argument with `variant_column.getVariantPtrByGlobalDiscriminator(...
diff --git a/src/Functions/FunctionDynamicAdaptor.cpp b/src/Functions/FunctionDynamicAdaptor.cpp index 7cd00eddb9c5..d0ec7f7babe8 100644 --- a/src/Functions/FunctionDynamicAdaptor.cpp +++ b/src/Functions/FunctionDynamicAdaptor.cpp @@ -31,6 +31,17 @@ namespace ErrorCodes extern const int NO_COMMON_TYPE; } +/// E...
2
5
ClickHouse/ClickHouse#107347
ClickHouse/ClickHouse
107,347
6133237facb11dbea3105e927047ef9b49e9b35e
85a67b9a38593a624ccde2932da111fbd0387b92
DeltaLake Logical error: Not found column cx in physical names map ### Describe the bug Not the same path as https://github.com/ClickHouse/ClickHouse/issues/87322 A `SELECT` from a persistent DeltaLake table aborts the server with: ``` Logical error: 'Not found column c0 in physical names map. There are only column...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Storages/ObjectStorage/DataLakes/DeltaLake/` needed for: DeltaLake Logical error: Not found column cx in physical names map", "scope_files": [ "src/Storages/ObjectStorage/DataLakes/DeltaLake/KernelUtils.cpp" ] }, { "subtas...
[ { "subtask_id": "s1", "scope_files": [ "src/Storages/ObjectStorage/DataLakes/DeltaLake/KernelUtils.cpp" ], "solution_diff": "diff --git a/src/Storages/ObjectStorage/DataLakes/DeltaLake/KernelUtils.cpp b/src/Storages/ObjectStorage/DataLakes/DeltaLake/KernelUtils.cpp\nindex 90e8a73f1a78..48eefca...
[]
diff --git a/src/Storages/ObjectStorage/DataLakes/DeltaLake/KernelUtils.cpp b/src/Storages/ObjectStorage/DataLakes/DeltaLake/KernelUtils.cpp index 90e8a73f1a78..48eefca1c513 100644 --- a/src/Storages/ObjectStorage/DataLakes/DeltaLake/KernelUtils.cpp +++ b/src/Storages/ObjectStorage/DataLakes/DeltaLake/KernelUtils.cpp @...
2
3
ClickHouse/ClickHouse#104896
ClickHouse/ClickHouse
104,896
215ff2543f8b19ca39ac6707fc5cad6195c57880
517ea582d303548bad870f4bd0d0878d7d4463e4
Fix LOGICAL_ERROR for materialized CTE under serialize_query_plan + parallel replicas Extracted from https://github.com/ClickHouse/ClickHouse/pull/97261 ### Changelog category (leave one): - Not for changelog (changelog entry is not required) --- Fix `LOGICAL_ERROR: CTE '...' does not have query tree, but wa...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Interpreters/ClusterProxy/` needed for: Fix LOGICAL_ERROR for materialized CTE under serialize_query_plan + parallel replicas", "scope_files": [ "src/Interpreters/ClusterProxy/executeQuery.cpp" ] }, { "subtask_id": "s2", ...
[ { "subtask_id": "s1", "scope_files": [ "src/Interpreters/ClusterProxy/executeQuery.cpp" ], "solution_diff": "diff --git a/src/Interpreters/ClusterProxy/executeQuery.cpp b/src/Interpreters/ClusterProxy/executeQuery.cpp\nindex 2a7214cf865e..df5a73c56b4d 100644\n--- a/src/Interpreters/ClusterProx...
[ { "subtask_id": "s1", "comment": "This new `serialize_query_plan` block is reachable from the old-analyzer path, where `query_tree` is intentionally `nullptr`.\n\nConcrete path:\n- `StorageMergeTree::read` calls `ClusterProxy::executeQueryWithParallelReplicas` (AST overload) when analyzer is disabled.\n- Th...
diff --git a/src/Interpreters/ClusterProxy/executeQuery.cpp b/src/Interpreters/ClusterProxy/executeQuery.cpp index 2a7214cf865e..df5a73c56b4d 100644 --- a/src/Interpreters/ClusterProxy/executeQuery.cpp +++ b/src/Interpreters/ClusterProxy/executeQuery.cpp @@ -738,7 +738,7 @@ void executeQueryWithParallelReplicas( ...
4
7
ClickHouse/ClickHouse#94681
ClickHouse/ClickHouse
94,681
f95eeea66d09a3bddb48df51b6e317cbe3c2325c
5bd94445fa4cc7e4f4c6b218e8dc149fe47cf9af
`EXPLAIN SYNTAX` and `IQueryTreeNode::toAST` should format all operators as functions For example, `SELECT 1 + 2` will be formatted as `SELECT plus(1, 2)`. This will simplify everything and allow us to continue in https://github.com/ClickHouse/ClickHouse/pull/92340 Format operators as functions in EXPLAIN SYNTAX and ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Analyzer/` needed for: `EXPLAIN SYNTAX` and `IQueryTreeNode::toAST` should format all operators as functions", "scope_files": [ "src/Analyzer/ConstantNode.cpp", "src/Analyzer/IQueryTreeNode.h" ] }, { "subtask_id": "s...
[ { "subtask_id": "s1", "scope_files": [ "src/Analyzer/ConstantNode.cpp", "src/Analyzer/IQueryTreeNode.h" ], "solution_diff": "diff --git a/src/Analyzer/ConstantNode.cpp b/src/Analyzer/ConstantNode.cpp\nindex c79fc91de9cf..3f193443bcf8 100644\n--- a/src/Analyzer/ConstantNode.cpp\n+++ b/src...
[ { "subtask_id": "", "comment": "(minor thing, could you change\n\n```\n-- Unary operators\n```\n\nto\n\n```sql\nSELECT 'Unary operators';\n```\n\nsuch that the reference file gains some \"separators\" between expected results?", "revised_diff": "diff --git a/tests/queries/0_stateless/03800_explain_synta...
diff --git a/src/Analyzer/ConstantNode.cpp b/src/Analyzer/ConstantNode.cpp index c79fc91de9cf..3f193443bcf8 100644 --- a/src/Analyzer/ConstantNode.cpp +++ b/src/Analyzer/ConstantNode.cpp @@ -180,6 +180,9 @@ ASTPtr ConstantNode::toASTImpl(const ConvertToASTOptions & options) const static const auto from_column = []...
4
100
ClickHouse/ClickHouse#105286
ClickHouse/ClickHouse
105,286
051854fa1daf6e2feb2b18c638b0f51f1c04434a
b6ccaf5a68eb8f9341f0bd98a2394dac3009b539
Logical error: Mutation of `Memory` table produced incomplete output: A (STID: 2380-3043) _Important: This issue was automatically generated and is used by CI for matching failures. DO NOT modify the body content. DO NOT remove labels._ Test name: Logical error: Mutation of `Memory` table produced incomplete output: ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Storages/` needed for: Logical error: Mutation of `Memory` table produced incomplete output: A (STID: 2380-3043)", "scope_files": [ "src/Storages/StorageMemory.cpp" ] }, { "subtask_id": "s2", "goal": "Implement the cha...
[ { "subtask_id": "s1", "scope_files": [ "src/Storages/StorageMemory.cpp" ], "solution_diff": "diff --git a/src/Storages/StorageMemory.cpp b/src/Storages/StorageMemory.cpp\nindex 109d1874da08..f0fc30d478b6 100644\n--- a/src/Storages/StorageMemory.cpp\n+++ b/src/Storages/StorageMemory.cpp\n@@ -13...
[ { "subtask_id": "s1", "comment": "~Wouldn't it be better to throw an error? This way we just silently don't do anything.~\r\n\r\nOkay, I see that Memory engine just silently ignores things, so this should be good.", "revised_diff": "diff --git a/src/Storages/StorageMemory.cpp b/src/Storages/StorageMemor...
diff --git a/src/Storages/StorageMemory.cpp b/src/Storages/StorageMemory.cpp index 109d1874da08..f0fc30d478b6 100644 --- a/src/Storages/StorageMemory.cpp +++ b/src/Storages/StorageMemory.cpp @@ -13,6 +13,7 @@ #include <DataTypes/DataTypeLowCardinality.h> #include <DataTypes/DataTypeString.h> #include <Storages/Alter...
2
3
ClickHouse/ClickHouse#106175
ClickHouse/ClickHouse
106,175
f95eeea66d09a3bddb48df51b6e317cbe3c2325c
8d617d769b286ed421c0f5cb29b803bbf8c0ef94
fix(docs): correct h3Distance example output value Several embedded function-documentation examples (shown in `SHOW CREATE FUNCTION` / docs and used by the docs generation) had incorrect outputs. This corrects them to match the actual server behavior: - `h3Distance`: the example distance between cells `59008054027563...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Functions/` needed for: fix(docs): correct h3Distance example output value", "scope_files": [ "src/Functions/h3Distance.cpp", "src/Functions/multiSearchFirstPositionCaseInsensitiveUTF8.cpp", "src/Functions/multiSearchFirst...
[ { "subtask_id": "s1", "scope_files": [ "src/Functions/h3Distance.cpp", "src/Functions/multiSearchFirstPositionCaseInsensitiveUTF8.cpp", "src/Functions/multiSearchFirstPositionUTF8.cpp", "src/Functions/readWkt.cpp" ], "solution_diff": "diff --git a/src/Functions/h3Distance.cpp...
[ { "subtask_id": "s1", "comment": "The example output still violates the PR's contract of matching server output: after changing the header to `readWKTMultiLineString`, the Pretty block width must grow too, but the value row and bottom border below still use the old `readWKTLineString` width. The generated o...
diff --git a/src/Functions/h3Distance.cpp b/src/Functions/h3Distance.cpp index bcdf8efb6e2e..038887be5851 100644 --- a/src/Functions/h3Distance.cpp +++ b/src/Functions/h3Distance.cpp @@ -141,7 +141,7 @@ This function calculates the minimum number of grid cells between the start and "SELECT h3Distance(59008...
1
4
ClickHouse/ClickHouse#106538
ClickHouse/ClickHouse
106,538
44aecc852cee7a9f38ec84df626833f5681e42f7
f22f3f8d702ec84858a7d0ef3f236ce0d929ed40
Add non-allocating IColumn::computeHashInto column hash kernel Split out the hash-production half of #106120 into its own pull request, as requested in review: keep the per-column hash calculation separate from the batched scatter interface so each can be reviewed and benchmarked in isolation. ## Motivation Seve...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Columns/` needed for: Add non-allocating IColumn::computeHashInto column hash kernel", "scope_files": [ "src/Columns/ColumnAggregateFunction.cpp", "src/Columns/ColumnAggregateFunction.h", "src/Columns/ColumnArray.cpp", ...
[ { "subtask_id": "s1", "scope_files": [ "src/Columns/ColumnAggregateFunction.cpp", "src/Columns/ColumnAggregateFunction.h", "src/Columns/ColumnArray.cpp", "src/Columns/ColumnArray.h", "src/Columns/ColumnBLOB.h", "src/Columns/ColumnCompressed.h", "src/Columns/ColumnCo...
[ { "subtask_id": "s1", "comment": "`ColumnDynamic::updateHashWithValue` normalizes shared-variant values by decoding the stored type and value, but this path delegates to `ColumnVariant`, where typed variants hash the nested value and shared variants hash the serialized `String` bytes. Two equal `Dynamic` ke...
diff --git a/src/Columns/ColumnAggregateFunction.cpp b/src/Columns/ColumnAggregateFunction.cpp index 3ce9eca657c1..1dcb6ac69b70 100644 --- a/src/Columns/ColumnAggregateFunction.cpp +++ b/src/Columns/ColumnAggregateFunction.cpp @@ -17,7 +17,6 @@ #include <Common/FieldVisitorToString.h> #include <Common/HashTable/Hash....
8
63
ClickHouse/ClickHouse#98115
ClickHouse/ClickHouse
98,115
bf9520191e35ccd524bcdeae9a5cff9753bc6e04
0040628c361a6ef5ca768242d89bb1b28ca5afd1
Enforce READ ON FILE checks for scalar file() and DESCRIBE TABLE file(). ### Changelog category (leave one): - Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR ### Changelog entry (a [user-readable short description](https://github.com/ClickHouse/ClickHouse/blob/master/docs/changelog_entry_guidelines.m...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Functions/` needed for: Enforce READ ON FILE checks for scalar file() and DESCRIBE TABLE file().", "scope_files": [ "src/Functions/FunctionFile.cpp" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/...
[ { "subtask_id": "s1", "scope_files": [ "src/Functions/FunctionFile.cpp" ], "solution_diff": "diff --git a/src/Functions/FunctionFile.cpp b/src/Functions/FunctionFile.cpp\nindex b7f154877876..697345fb06d1 100644\n--- a/src/Functions/FunctionFile.cpp\n+++ b/src/Functions/FunctionFile.cpp\n@@ -3,...
[ { "subtask_id": "s1", "comment": "We propagate context to `FunctionFile::create`. Can't we just save it in a field and use here?", "revised_diff": "diff --git a/src/Functions/FunctionFile.cpp b/src/Functions/FunctionFile.cpp\nindex b7f154877876..697345fb06d1 100644\n--- a/src/Functions/FunctionFile.cpp\...
diff --git a/src/Functions/FunctionFile.cpp b/src/Functions/FunctionFile.cpp index b7f154877876..697345fb06d1 100644 --- a/src/Functions/FunctionFile.cpp +++ b/src/Functions/FunctionFile.cpp @@ -3,6 +3,7 @@ #include <Columns/ColumnConst.h> #include <Columns/IColumn.h> #include <Functions/FunctionFactory.h> +#include...
3
4
ClickHouse/ClickHouse#99531
ClickHouse/ClickHouse
99,531
72360b4b81c935102c295264c815c8eb67ecd358
2c2c2d3e458c589a3e5bc20e9515e778cdeeab62
validate column structure before applying patches ### Changelog category (leave one): - Bug Fix (user-visible misbehavior in an official stable release) ### Changelog entry (a [user-readable short description](https://github.com/ClickHouse/ClickHouse/blob/master/docs/changelog_entry_guidelines.md) of the changes t...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Storages/MergeTree/PatchParts/` needed for: validate column structure before applying patches", "scope_files": [ "src/Storages/MergeTree/PatchParts/applyPatches.cpp" ] }, { "subtask_id": "s2", "goal": "Implement the ch...
[ { "subtask_id": "s1", "scope_files": [ "src/Storages/MergeTree/PatchParts/applyPatches.cpp" ], "solution_diff": "diff --git a/src/Storages/MergeTree/PatchParts/applyPatches.cpp b/src/Storages/MergeTree/PatchParts/applyPatches.cpp\nindex 6b8c2fcdcc70..447f51853eff 100644\n--- a/src/Storages/Mer...
[ { "subtask_id": "s1", "comment": "`applyPatchesToBlockCombined` checks `structureEquals` before `removeSpecialRepresentations`, unlike `applyPatchesToBlockRaw`. This can incorrectly mark compatible patches as incompatible when `result_column.column` is in sparse/replicated representation (patch columns are ...
diff --git a/src/Storages/MergeTree/PatchParts/applyPatches.cpp b/src/Storages/MergeTree/PatchParts/applyPatches.cpp index 6b8c2fcdcc70..447f51853eff 100644 --- a/src/Storages/MergeTree/PatchParts/applyPatches.cpp +++ b/src/Storages/MergeTree/PatchParts/applyPatches.cpp @@ -8,6 +8,7 @@ #include <DataTypes/DataTypesNum...
2
2
ClickHouse/ClickHouse#106507
ClickHouse/ClickHouse
106,507
ac805ce05b9d3821ec5d257f85b7ba9bb8d10815
d77ebd24d2589d3953e2fbde933b0050c4cc897b
Wrong results: equality predicate (col = const) drops rows when ORDER BY key is a NaN-producing function (sqrt/log of negatives) **Describe what's wrong** An equality predicate `col = <const>` returns **wrong (too few) results** when the table's `ORDER BY` (primary) key is a function that is **not defined (NaN) for s...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Storages/MergeTree/` needed for: Wrong results: equality predicate (col = const) drops rows when ORDER BY key is a NaN-producing function (sqrt/log of negatives)", "scope_files": [ "src/Storages/MergeTree/KeyCondition.cpp" ] }, ...
[ { "subtask_id": "s1", "scope_files": [ "src/Storages/MergeTree/KeyCondition.cpp" ], "solution_diff": "diff --git a/src/Storages/MergeTree/KeyCondition.cpp b/src/Storages/MergeTree/KeyCondition.cpp\nindex e40c5a9c2618..7a5b94afb2a8 100644\n--- a/src/Storages/MergeTree/KeyCondition.cpp\n+++ b/sr...
[]
diff --git a/src/Storages/MergeTree/KeyCondition.cpp b/src/Storages/MergeTree/KeyCondition.cpp index e40c5a9c2618..7a5b94afb2a8 100644 --- a/src/Storages/MergeTree/KeyCondition.cpp +++ b/src/Storages/MergeTree/KeyCondition.cpp @@ -1682,7 +1682,14 @@ bool KeyCondition::canConstantBeWrappedByDeterministicFunctions( ...
2
3
CompositionalIT/SAFE-Dojo#183
CompositionalIT/SAFE-Dojo
183
6381b8d7f8ea6c19065a0e3bf1f841073ec4fc8a
f88a650ffb49352ba7ee92c662046fce99d47a58
Bump vite from 5.0.13 to 5.4.6 Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.0.13 to 5.4.6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vitejs/vite/releases">vite's releases</a>.</em></p> <blockquote> <h2>create-vite@5.4.0</h2> <p>Please refe...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Bump vite from 5.0.13 to 5.4.6", "scope_files": [ "package-lock.json", "package.json" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex 6b5d855..5e17eee 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -18,7 +18,7 @@\n \"@vitejs/plugin-react\...
[]
diff --git a/package-lock.json b/package-lock.json index 6b5d855..5e17eee 100644 --- a/package-lock.json +++ b/package-lock.json @@ -18,7 +18,7 @@ "@vitejs/plugin-react": "^4.2.0", "mocha": "^8.3.2", "remotedev": "^0.2.9", - "vite": "^5.0.13" + ...
1
2
CompositionalIT/SAFE-Dojo#181
CompositionalIT/SAFE-Dojo
181
e18245e082261b44c2985992069fb4ac8d8b5297
81224465d413677384f87298e0cb1a0f7cc246ea
Bump vite from 5.0.12 to 5.0.13 Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.0.12 to 5.0.13. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/vitejs/vite/blob/v5.0.13/packages/vite/CHANGELOG.md">vite's changelog</a>.</em></p> <blockquote> <h2><!-- ra...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Bump vite from 5.0.12 to 5.0.13", "scope_files": [ "package-lock.json", "package.json" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex c0ea788..84b6ed3 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -18,7 +18,7 @@\n \"@vitejs/plugin-react\...
[]
diff --git a/package-lock.json b/package-lock.json index c0ea788..84b6ed3 100644 --- a/package-lock.json +++ b/package-lock.json @@ -18,7 +18,7 @@ "@vitejs/plugin-react": "^4.2.0", "mocha": "^8.3.2", "remotedev": "^0.2.9", - "vite": "^5.0.12" + ...
1
2
CompositionalIT/SAFE-Dojo#180
CompositionalIT/SAFE-Dojo
180
2ea3c88ff3bd3845b8550121365cea4649c8cbce
7bda8f3aa43abfc1fc182f5cbe16259b9a0fd628
Bump vite from 5.0.5 to 5.0.12 Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.0.5 to 5.0.12. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/vitejs/vite/blob/v5.0.12/packages/vite/CHANGELOG.md">vite's changelog</a>.</em></p> <blockquote> <h2><!-- raw ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Bump vite from 5.0.5 to 5.0.12", "scope_files": [ "package-lock.json", "package.json" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex ed1870c..c0ea788 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -18,7 +18,7 @@\n \"@vitejs/plugin-react\...
[]
diff --git a/package-lock.json b/package-lock.json index ed1870c..c0ea788 100644 --- a/package-lock.json +++ b/package-lock.json @@ -18,7 +18,7 @@ "@vitejs/plugin-react": "^4.2.0", "mocha": "^8.3.2", "remotedev": "^0.2.9", - "vite": "^5.0.5" + ...
1
2
CompositionalIT/SAFE-Dojo#179
CompositionalIT/SAFE-Dojo
179
dd84aebb8fc07e7ce8a470cd815b86854dc4b97d
68cb10d0ebc5a1edaaed4748abad2f1d8bf978c9
Remove incorrect url in Server.fs and fix url in launchsettings.json fix for #178
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Server/` needed for: Remove incorrect url in Server.fs and fix url in launchsettings.json", "scope_files": [ "src/Server/Server.fs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/Server/Properties...
[ { "subtask_id": "s1", "scope_files": [ "src/Server/Server.fs" ], "solution_diff": "diff --git a/src/Server/Server.fs b/src/Server/Server.fs\nindex 28fb3be..9fdbd40 100644\n--- a/src/Server/Server.fs\n+++ b/src/Server/Server.fs\n@@ -10,7 +10,7 @@ let webApp =\n |> Remoting.buildHttpHandler\...
[]
diff --git a/src/Server/Properties/launchSettings.json b/src/Server/Properties/launchSettings.json index 6464ef5..4c40621 100644 --- a/src/Server/Properties/launchSettings.json +++ b/src/Server/Properties/launchSettings.json @@ -6,7 +6,7 @@ "environmentVariables": { "ASPNETCORE_ENVIRONMENT": "Developmen...
2
2
CompositionalIT/SAFE-Dojo#176
CompositionalIT/SAFE-Dojo
176
4436185ed7ec8a543f8f7138e9b0c84ed903844d
feeaf9e297a8e2f443d05ddc1a7bb764e72ff1fe
Upgrade suggested solution to SAFE v5 This is the suggested solution branch with the SAFE v5 upgrade merged in and conflicts resolved. Most of the changes are from the other branch: #175
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Upgrade suggested solution to SAFE v5", "scope_files": [ ".editorconfig", "Build.fs", "Build.fsproj", "Helpers.fs", "README.md", "SAFE-dojo.sln", "global.json", "package-lock....
[ { "subtask_id": "s1", "scope_files": [ ".editorconfig", "Build.fs", "Build.fsproj", "Helpers.fs", "README.md", "SAFE-dojo.sln", "global.json", "package-lock.json", "package.json", "paket.dependencies", "paket.lock", "webpack.config.js",...
[]
diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json index cf268e8..aa15bcc 100644 --- a/.config/dotnet-tools.json +++ b/.config/dotnet-tools.json @@ -1,24 +1,30 @@ { - "version": 1, - "isRoot": true, - "tools": { - "paket": { - "version": "7.2.0", - "commands": [ - "paket" - ...
5
27
CompositionalIT/SAFE-Dojo#175
CompositionalIT/SAFE-Dojo
175
95bd37b72f675110ccfbe8f26a80a24acc280af6
a4009198c0cb767616b509b0be584362fecd48dc
Update to SAFE v5 Mostly I followed the official instructions to do the update (https://safe-stack.github.io/docs/recipes/upgrading/v4-to-v5/). The main deviations were: - Not adding Tailwind, since the whole thing is using Bulma. - Not upgrading tests since there are no tests - Change the server port to 8085 to...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Update to SAFE v5", "scope_files": [ ".editorconfig", "Build.fs", "Build.fsproj", "Helpers.fs", "Instructions.md", "SAFE-dojo.sln", "global.json", "package-lock.json", "...
[ { "subtask_id": "s1", "scope_files": [ ".editorconfig", "Build.fs", "Build.fsproj", "Helpers.fs", "Instructions.md", "SAFE-dojo.sln", "global.json", "package-lock.json", "package.json", "paket.dependencies", "paket.lock", "webpack.confi...
[ { "subtask_id": "s5", "comment": "Template uses Content for this reference. Does not seem like that would have any implications. ", "revised_diff": "diff --git a/src/Shared/Shared.fsproj b/src/Shared/Shared.fsproj\nindex 8fee1db..83a61a2 100644\n--- a/src/Shared/Shared.fsproj\n+++ b/src/Shared/Shared.fs...
diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json index cf268e8..aa15bcc 100644 --- a/.config/dotnet-tools.json +++ b/.config/dotnet-tools.json @@ -1,24 +1,30 @@ { - "version": 1, - "isRoot": true, - "tools": { - "paket": { - "version": "7.2.0", - "commands": [ - "paket" - ...
5
25
CompositionalIT/SAFE-Dojo#165
CompositionalIT/SAFE-Dojo
165
3757be45d5b6acc30fcfb87bd5380a40e6552f05
060f768016c0b24e17491056910c4a2c5cf8b18e
Bump webpack from 5.75.0 to 5.76.0 Bumps [webpack](https://github.com/webpack/webpack) from 5.75.0 to 5.76.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/webpack/webpack/releases">webpack's releases</a>.</em></p> <blockquote> <h2>v5.76.0</h2> <h2>Bugfixes</h2> <ul> <li>Av...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Bump webpack from 5.75.0 to 5.76.0", "scope_files": [ "package-lock.json", "package.json" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex d95054c..522c372 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -23,7 +23,7 @@\n \"sass\": \"^1.43.4\",\...
[]
diff --git a/package-lock.json b/package-lock.json index d95054c..522c372 100644 --- a/package-lock.json +++ b/package-lock.json @@ -23,7 +23,7 @@ "sass": "^1.43.4", "sass-loader": "^12.3.0", "style-loader": "^3.3.1", - "webpack": "^5.75.0", + ...
1
2
CompositionalIT/SAFE-Dojo#162
CompositionalIT/SAFE-Dojo
162
efe2890c6cd0938b75f3e3397bcac378acb2e80f
5fb405c021432620ff7c140f8379f54615495d1d
.NET6 + Fantomas 5 (solution)
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: .NET6 + Fantomas 5 (solution)", "scope_files": [ ".editorconfig", "global.json", "package.json", "paket.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.config/...
[ { "subtask_id": "s1", "scope_files": [ ".editorconfig", "global.json", "package.json", "paket.lock" ], "solution_diff": "diff --git a/.editorconfig b/.editorconfig\nindex 2bd711f..c822b3a 100644\n--- a/.editorconfig\n+++ b/.editorconfig\n@@ -7,6 +7,6 @@ charset = utf-8\n trim...
[]
diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json index b63ef6a..cf268e8 100644 --- a/.config/dotnet-tools.json +++ b/.config/dotnet-tools.json @@ -14,8 +14,8 @@ "fable" ] }, - "fantomas-tool": { - "version": "4.4.0", + "fantomas": { + "version": "5.0.0", "co...
3
6
CompositionalIT/SAFE-Dojo#161
CompositionalIT/SAFE-Dojo
161
868e3918c018abd7dcdef3c71d2948a333cf3229
948bee3db1f259a77900f792c932986cbddc6117
.NET6 + Fantomas 5
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: .NET6 + Fantomas 5", "scope_files": [ ".editorconfig", "global.json", "package-lock.json", "package.json", "paket.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes...
[ { "subtask_id": "s1", "scope_files": [ ".editorconfig", "global.json", "package-lock.json", "package.json", "paket.lock" ], "solution_diff": "diff --git a/.editorconfig b/.editorconfig\nindex 2bd711f..c822b3a 100644\n--- a/.editorconfig\n+++ b/.editorconfig\n@@ -7,6 +7,...
[]
diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json index b63ef6a..cf268e8 100644 --- a/.config/dotnet-tools.json +++ b/.config/dotnet-tools.json @@ -14,8 +14,8 @@ "fable" ] }, - "fantomas-tool": { - "version": "4.4.0", + "fantomas": { + "version": "5.0.0", "co...
6
13
CompositionalIT/SAFE-Dojo#160
CompositionalIT/SAFE-Dojo
160
bc2b268e3bfc0175fcf4e45df31377c7face36f7
9c68a7affc7d621b8a0724a91631ac64b81b6ab5
Upgraded to .net6 fixup
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Upgraded to .net6 fixup", "scope_files": [ "Build.fs", "webpack.config.js" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "Build.fs", "webpack.config.js" ], "solution_diff": "diff --git a/Build.fs b/Build.fs\nindex 4464b81..f6c3897 100644\n--- a/Build.fs\n+++ b/Build.fs\n@@ -21,7 +21,7 @@ Target.create \"InstallClient\" (fun _ -> run npm \"install\" \".\")\n \n Target....
[]
diff --git a/Build.fs b/Build.fs index 4464b81..f6c3897 100644 --- a/Build.fs +++ b/Build.fs @@ -21,7 +21,7 @@ Target.create "InstallClient" (fun _ -> run npm "install" ".") Target.create "Bundle" (fun _ -> [ "server", dotnet $"publish -c Release -o \"{deployPath}\"" serverPath - "client", dotnet "fable --...
1
2
CompositionalIT/SAFE-Dojo#158
CompositionalIT/SAFE-Dojo
158
669a566d3e279d1346db82a7ec89913e6db99a15
f5ede36786017cef0bb2da108d9fac6d33ba95bb
Upgrade to .NET 6
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Upgrade to .NET 6", "scope_files": [ ".gitignore", "Build.fs", "Build.fsproj", "global.json", "package-lock.json", "package.json", "paket.dependencies", "paket.lock", "w...
[ { "subtask_id": "s1", "scope_files": [ ".gitignore", "Build.fs", "Build.fsproj", "global.json", "package-lock.json", "package.json", "paket.dependencies", "paket.lock", "webpack.config.js" ], "solution_diff": "diff --git a/.gitignore b/.gitignore...
[ { "subtask_id": "s2", "comment": "Would it be worth updating Paket while we're updating everything else? It looks like it's on an RC version. (I'm putting the comment here because I can only comment on changed sections)", "revised_diff": "diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.jso...
diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json index 66218b2..b63ef6a 100644 --- a/.config/dotnet-tools.json +++ b/.config/dotnet-tools.json @@ -3,13 +3,13 @@ "isRoot": true, "tools": { "paket": { - "version": "6.0.0-rc002", + "version": "7.2.0", "commands": [ "p...
6
14
CompositionalIT/SAFE-Dojo#152
CompositionalIT/SAFE-Dojo
152
8ee963c099a2d556d7aac3a11131f0177a5aa380
97a9b9bb5a69555ed21ddb372b9ee8b5fb55c5ab
Bump glob-parent and webpack Bumps [glob-parent](https://github.com/gulpjs/glob-parent) to 5.1.2 and updates ancestor dependency [webpack](https://github.com/webpack/webpack). These dependencies need to be updated together. Updates `glob-parent` from 3.1.0 to 5.1.2 <details> <summary>Release notes</summary> <p><em>So...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Bump glob-parent and webpack", "scope_files": [ "package-lock.json", "package.json" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex 466bb68..8bc350c 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -23,7 +23,7 @@\n \"sass\": \"^1.34.0\",\...
[]
diff --git a/package-lock.json b/package-lock.json index 466bb68..8bc350c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -23,7 +23,7 @@ "sass": "^1.34.0", "sass-loader": "^9.0.3", "style-loader": "^1.2.1", - "webpack": "^4.46.0", + ...
1
2
CompositionalIT/SAFE-Dojo#150
CompositionalIT/SAFE-Dojo
150
bee7a1957a4fcba813353c01cfffcea9f94abb60
401d5944f55cd2569d6ab1f7ab206bbbb23fe33a
Bump glob-parent and webpack-dev-server Bumps [glob-parent](https://github.com/gulpjs/glob-parent) to 5.1.2 and updates ancestor dependency [webpack-dev-server](https://github.com/webpack/webpack-dev-server). These dependencies need to be updated together. Updates `glob-parent` from 3.1.0 to 5.1.2 <details> <summary>...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Bump glob-parent and webpack-dev-server", "scope_files": [ "package-lock.json", "package.json" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex ffab27c..0e62e20 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -23,9 +23,9 @@\n \"sass\": \"^1.34.0\",\...
[]
diff --git a/package-lock.json b/package-lock.json index ffab27c..0e62e20 100644 --- a/package-lock.json +++ b/package-lock.json @@ -23,9 +23,9 @@ "sass": "^1.34.0", "sass-loader": "^9.0.3", "style-loader": "^1.2.1", - "webpack": "^4.41.2", + ...
1
2
CompositionalIT/SAFE-Dojo#142
CompositionalIT/SAFE-Dojo
142
bee7a1957a4fcba813353c01cfffcea9f94abb60
cf9746651256a397d31ed30fac7f5e46c0b2e5d7
Bump node-forge and webpack-dev-server Bumps [node-forge](https://github.com/digitalbazaar/forge) and [webpack-dev-server](https://github.com/webpack/webpack-dev-server). These dependencies needed to be updated together. Updates `node-forge` from 0.10.0 to 1.3.1 <details> <summary>Changelog</summary> <p><em>Sourced fr...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Bump node-forge and webpack-dev-server", "scope_files": [ "package-lock.json", "package.json" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex ffab27c..1f7fa6a 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -25,7 +25,7 @@\n \"style-loader\": \"^1....
[]
diff --git a/package-lock.json b/package-lock.json index ffab27c..1f7fa6a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -25,7 +25,7 @@ "style-loader": "^1.2.1", "webpack": "^4.41.2", "webpack-cli": "^3.3.9", - "webpack-dev-server": "^3.11.3" ...
1
2
CompositionalIT/SAFE-Dojo#149
CompositionalIT/SAFE-Dojo
149
adfb3e8e649ef7ed7b6a3aab08383841502f08af
d6e7f3c840f4e47017a25e59f498fe106e1c1499
Bump ansi-html and webpack-dev-server Removes [ansi-html](https://github.com/Tjatse/ansi-html). It's no longer used after updating ancestor dependency [webpack-dev-server](https://github.com/webpack/webpack-dev-server). These dependencies need to be updated together. Removes `ansi-html` Updates `webpack-dev-server` ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Bump ansi-html and webpack-dev-server", "scope_files": [ "package-lock.json", "package.json" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex ed26e39..0f6a6ed 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -25,7 +25,7 @@\n \"style-loader\": \"^1....
[]
diff --git a/package-lock.json b/package-lock.json index ed26e39..0f6a6ed 100644 --- a/package-lock.json +++ b/package-lock.json @@ -25,7 +25,7 @@ "style-loader": "^1.2.1", "webpack": "^4.41.2", "webpack-cli": "^3.3.9", - "webpack-dev-server": "^3.8.2" +...
1
2
CompositionalIT/SAFE-Dojo#144
CompositionalIT/SAFE-Dojo
144
21736e318a47f36bed4745ee80a5a0e21f5c567d
363ed1b36f067709396a5ae8c70e599f4da450a5
Bump d3-color and recharts Bumps [d3-color](https://github.com/d3/d3-color) to 3.1.0 and updates ancestor dependency [recharts](https://github.com/recharts/recharts). These dependencies need to be updated together. Updates `d3-color` from 2.0.0 to 3.1.0 <details> <summary>Release notes</summary> <p><em>Sourced from <...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Bump d3-color and recharts", "scope_files": [ "package-lock.json", "package.json" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex a48b570..bd9bd0c 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -10,7 +10,7 @@\n \"pigeon-maps\": \"^0.1...
[]
diff --git a/package-lock.json b/package-lock.json index a48b570..bd9bd0c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -10,7 +10,7 @@ "pigeon-maps": "^0.19.7", "react": "^17.0.2", "react-dom": "^17.0.2", - "recharts": "^2.0.10", + ...
1
2
CompositionalIT/SAFE-Dojo#139
CompositionalIT/SAFE-Dojo
139
2e2000e9994d522c1edf23ba7d1dda48ad4681c3
79ecf482a60300b5e769455f916f92c2156adf9c
Use static JSON samples for type providers (issue #137) https://github.com/CompositionalIT/SAFE-Dojo/issues/137
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Use static JSON samples for type providers (issue #137)", "scope_files": [ "Build.fs", "README.md", "SAFE-dojo.sln", "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the c...
[ { "subtask_id": "s1", "scope_files": [ "Build.fs", "README.md", "SAFE-dojo.sln", "package.json" ], "solution_diff": "diff --git a/Build.fs b/Build.fs\nindex 362ffbb..846a4b8 100644\n--- a/Build.fs\n+++ b/Build.fs\n@@ -11,9 +11,6 @@ let sharedPath = Path.getFullName \"src/Shar...
[]
diff --git a/Build.fs b/Build.fs index 362ffbb..846a4b8 100644 --- a/Build.fs +++ b/Build.fs @@ -11,9 +11,6 @@ let sharedPath = Path.getFullName "src/Shared" let serverPath = Path.getFullName "src/Server" let clientPath = Path.getFullName "src/Client" let deployPath = Path.getFullName "deploy" -let sharedTestsPath =...
8
21
CompositionalIT/SAFE-Dojo#134
CompositionalIT/SAFE-Dojo
134
a95211fc671feda200aebee681bdaa10c9742569
f45fd41ec5ddbd3b67530502866f01cdcfe6479e
Metaweather alternative [metaweather.com](http://metaweather.com) is down. This PR changes the code to use [open-meteo.com](http://open-meteo.com)'s API and display [open source weather icons](https://github.com/erikflowers/weather-icons) instead.
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/Client/` needed for: Metaweather alternative", "scope_files": [ "src/Client/Index.fs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/Server/` needed for: Metaweather alternative", "scope_files...
[ { "subtask_id": "s1", "scope_files": [ "src/Client/Index.fs" ], "solution_diff": "diff --git a/src/Client/Index.fs b/src/Client/Index.fs\nindex d39b639..7a9776e 100644\n--- a/src/Client/Index.fs\n+++ b/src/Client/Index.fs\n@@ -163,7 +163,7 @@ module ViewParts =\n prop.child...
[ { "subtask_id": "s2", "comment": "`emptyWeather` still uses the `AverageTemperature` label that was renamed to `Temperature`, which causes the project to fail to build. (Api.fs, line 44)", "revised_diff": "diff --git a/src/Server/Api.fs b/src/Server/Api.fs\nindex 86885c7..53645cb 100644\n--- a/src/Serve...
diff --git a/src/Client/Index.fs b/src/Client/Index.fs index d39b639..7a9776e 100644 --- a/src/Client/Index.fs +++ b/src/Client/Index.fs @@ -163,7 +163,7 @@ module ViewParts = prop.children [ Html.img [ prop.style [ style.height 100] - ...
3
4